solidus_support 0.2.1 → 0.2.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5f38daae0fcb1b2de8343abb23d59c80e553fd0e1c72c3d15e11414862ad8b05
-  data.tar.gz: b5f61ace5703a2dcf5e03775e4ea22db6a116a19b21ce803c819153dad7d7080
+  metadata.gz: 7c6337566230395848b49403c4b56e36c77e145a4b622c08e144021b8fbf86e1
+  data.tar.gz: 6a89880916b4420dd0faafa0542d33da84e0ae95ee5193402441af91a96d3799
 SHA512:
-  metadata.gz: c920bb64d3fc147e2e86ca8edbe7356bff0273b98af6f08d45448dcdaa218b1a812f3f54a9d7bfe7cd26d4ad2091b67335bee21fa4453863f81d2e23b2dfb794
-  data.tar.gz: 6544d8cd2a38174b015871c4e267e8e92ab565e1a73483047e2a817f296875087d2de00f2f776576c971c2c6a16e068d5153536232606ad38501a2f4874e498e
+  metadata.gz: 3c202ec470b49983809717d7f9e8633e0a086bd1e782410aa0f221fd444e23842842f112fea46da313f23e66aba3a28ee0a9560b3c227b0f412c41ad129ce597
+  data.tar.gz: 6c03785d6c92023a8d9fe6b3e1fc5d12867c712fce458f7bf33417918ee4f814b91428ecae72593dbc30317e25cb70902780afb2693b10b4ee155e602e4b071d

data/.gitignore

@@ -7,3 +7,4 @@
 /pkg/
 /spec/reports/
 /tmp/
+/log/

data/.rspec

@@ -0,0 +1 @@
+--require spec_helper

data/.travis.yml

@@ -0,0 +1,23 @@
+sudo: false
+language: ruby
+dist: trusty
+cache:
+  bundler: true
+before_install:
+  - "gem install bundler --pre"
+  - "bundler -v"
+rvm:
+  - 2.4.2
+env:
+  matrix:
+    - SOLIDUS_BRANCH=v1.0
+    - SOLIDUS_BRANCH=v1.1
+    - SOLIDUS_BRANCH=v1.2
+    - SOLIDUS_BRANCH=v1.3
+    - SOLIDUS_BRANCH=v1.4
+    - SOLIDUS_BRANCH=v2.0
+    - SOLIDUS_BRANCH=v2.1
+    - SOLIDUS_BRANCH=v2.2
+    - SOLIDUS_BRANCH=v2.3
+    - SOLIDUS_BRANCH=v2.4
+    - SOLIDUS_BRANCH=master

data/Gemfile

@@ -1,7 +1,10 @@
 source 'https://rubygems.org'
 
 branch = ENV.fetch('SOLIDUS_BRANCH', 'master')
-gem 'solidus', github: 'solidusio/solidus', branch: branch
+gem 'solidus_core', github: 'solidusio/solidus', branch: branch
 
 # Specify your gem's dependencies in solidus_support.gemspec
 gemspec
+
+gem 'sqlite3'
+gem 'sprockets-rails'

data/README.md

@@ -24,6 +24,42 @@ SolidusSupport::Migration[5.0] # same as `ActiveRecord::Migration[5.0]`
 
 There's no reason to use `SolidusSupport::Migration[5.0]` over `ActiveRecord::Migration[5.0]`, but it is provided.
 
+### Testing Helpers
+
+This gem provides some useful helpers for RSpec to setup an extension's test
+environment easily.
+
+Into your extension's spec/spec_helper.rb:
+
+```ruby
+require "solidus_support/extension/feature_helper"
+```
+
+This helper loads configuration needed to run extensions feature specs
+correctly, setting up Capybara and configuring Rails test application
+to precompile assets before the first feature spec.
+
+This helper requires the `rails_helper`, also provided by this gem and
+requireable as a stand-alone helper.
+
+By doing:
+
+```ruby
+require "solidus_support/extension/rails_helper"
+```
+
+extension's test suite will have all Rails related tests configuration,
+like authorization helpers, Solidus core factories, url helpers, and
+other helpers to easily work with Solidus Config.
+
+This `rails_helper` in turn requires the basic `spec_helper`, which is
+responsible to load a basic RSpec configuration, which could be needed
+in all extensions. It is also requireable as a stand-alone helper with:
+
+```ruby
+require "solidus_support/extension/spec_helper"
+```
+
 ## Development
 
 After checking out the repo, run `bin/setup` to install dependencies. You can also run `bin/console` for an interactive prompt that will allow you to experiment.
@@ -33,4 +69,3 @@ To install this gem onto your local machine, run `bundle exec rake install`. To
 ## Contributing
 
 Bug reports and pull requests are welcome on GitHub at https://github.com/solidusio/solidus_support.
-

data/lib/solidus_support.rb

@@ -16,14 +16,31 @@ module SolidusSupport
       end
     end
 
+    def new_gateway_code?
+      first_version_with_new_gateway_code = Gem::Requirement.new('>= 2.3')
+      first_version_with_new_gateway_code.satisfied_by?(solidus_gem_version)
+    end
+
     def payment_source_parent_class
-      if solidus_gem_version > Gem::Version.new('2.2.x')
+      if new_gateway_code?
         Spree::PaymentSource
       else
         Spree::Base
       end
     end
 
+    def payment_method_parent_class(credit_card: false)
+      if new_gateway_code?
+        if credit_card
+          Spree::PaymentMethod::CreditCard
+        else
+          Spree::PaymentMethod
+        end
+      else
+        Spree::Gateway
+      end
+    end
+
     def frontend_available?
       defined?(Spree::Frontend::Engine)
     end

data/lib/solidus_support/extension/feature_helper.rb

@@ -2,7 +2,7 @@
 #
 # Can be required from an extension's spec/feature_helper.rb
 #
-#     require 'solidus_support/extension/feature_helper.rb'
+#     require 'solidus_support/extension/feature_helper'
 #
 
 require 'solidus_support/extension/rails_helper'

data/lib/solidus_support/extension/rails_helper.rb

@@ -2,7 +2,7 @@
 #
 # Can be required from an extension's spec/rails_helper.rb
 #
-#     require 'solidus_support/extension/rails_helper.rb'
+#     require 'solidus_support/extension/rails_helper'
 #
 
 require 'solidus_support/extension/spec_helper'

data/lib/solidus_support/extension/spec_helper.rb

@@ -2,7 +2,7 @@
 #
 # Can be required from an extension's spec/spec_helper.rb
 #
-#     require 'solidus_support/extension/spec_helper.rb'
+#     require 'solidus_support/extension/spec_helper'
 #
 
 RSpec.configure do |config|

data/lib/solidus_support/version.rb

@@ -1,3 +1,3 @@
 module SolidusSupport
-  VERSION = "0.2.1"
+  VERSION = "0.2.2"
 end

data/solidus_support.gemspec

@@ -16,6 +16,8 @@ Gem::Specification.new do |spec|
   spec.files         = `git ls-files -z`.split("\x0")
   spec.require_paths = ["lib"]
 
+  spec.add_development_dependency "solidus_core"
   spec.add_development_dependency "bundler", "~> 1.14"
   spec.add_development_dependency "rake", "~> 10.0"
+  spec.add_development_dependency "rspec-rails", "~> 3.7"
 end

data/spec/solidus_support_spec.rb

@@ -0,0 +1,41 @@
+RSpec.describe SolidusSupport do
+  describe '.payment_method_parent_class' do
+    subject { described_class.payment_method_parent_class(credit_card: credit_card) }
+
+    let(:credit_card) { nil }
+
+    before do
+      allow(described_class).to receive(:solidus_gem_version) do
+        Gem::Version.new(solidus_version)
+      end
+    end
+
+    context 'For Solidus < 2.3' do
+      let(:solidus_version) { '2.2.1' }
+
+      it { is_expected.to eq(Spree::Gateway) }
+    end
+
+    context 'For Solidus >= 2.3' do
+      let(:solidus_version) { '2.3.1' }
+
+      it { is_expected.to eq(Spree::PaymentMethod) }
+    end
+
+    context 'with credit_card: true' do
+      let(:credit_card) { true }
+
+      context 'For Solidus < 2.3' do
+        let(:solidus_version) { '2.2.1' }
+
+        it { is_expected.to eq(Spree::Gateway) }
+      end
+
+      context 'For Solidus >= 2.3' do
+        let(:solidus_version) { '2.3.1' }
+
+        it { is_expected.to eq(Spree::PaymentMethod::CreditCard) }
+      end
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -0,0 +1,2 @@
+require_relative 'support/dummy_app'
+require 'solidus_support/extension/spec_helper'

data/spec/support/dummy_app.rb

@@ -0,0 +1,18 @@
+ENV['RAILS_ENV'] = 'test'
+ENV['DISABLE_DATABASE_ENVIRONMENT_CHECK'] = '1'
+
+Bundler.setup
+
+require 'rails'
+require 'solidus_core'
+
+Bundler.require(:default, :test)
+
+module DummyApp
+  class Application < ::Rails::Application
+    config.eager_load               = false
+    config.paths["config/database"] = File.expand_path('../dummy_app/database.yml', __FILE__)
+  end
+end
+
+DummyApp::Application.initialize!

data/spec/support/dummy_app/database.yml

@@ -0,0 +1,4 @@
+test:
+  adapter: sqlite3
+  database: ':memory:'
+  timeout: 10000

metadata

@@ -1,15 +1,29 @@
 --- !ruby/object:Gem::Specification
 name: solidus_support
 version: !ruby/object:Gem::Version
-  version: 0.2.1
+  version: 0.2.2
 platform: ruby
 authors:
 - John Hawthorn
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-02-22 00:00:00.000000000 Z
+date: 2018-10-09 00:00:00.000000000 Z
 dependencies:
+- !ruby/object:Gem::Dependency
+  name: solidus_core
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -38,6 +52,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '10.0'
+- !ruby/object:Gem::Dependency
+  name: rspec-rails
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.7'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.7'
 description: Collection of common functionality for solidus extensions
 email:
 - john@stembolt.com
@@ -46,6 +74,8 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
+- ".rspec"
+- ".travis.yml"
 - Gemfile
 - README.md
 - Rakefile
@@ -56,6 +86,10 @@ files:
 - lib/solidus_support/migration.rb
 - lib/solidus_support/version.rb
 - solidus_support.gemspec
+- spec/solidus_support_spec.rb
+- spec/spec_helper.rb
+- spec/support/dummy_app.rb
+- spec/support/dummy_app/database.yml
 homepage: https://solidus.io
 licenses: []
 metadata: {}
@@ -75,7 +109,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.7.6
+rubygems_version: 2.7.3
 signing_key: 
 specification_version: 4
 summary: A common functionality for solidus extensions