solidus_stripe 5.0.0 → 5.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 74b8cc487cbedad02aed14419e47ff6b7ca67f07b23f6be92b9bcf5ff4951ec7
-  data.tar.gz: 5006de9a7167f75d0793a64a78a5a2a277330e49b2f6f9602a5f434e392d2858
+  metadata.gz: '024918e27fdd100b73a5695aa31d9217cc244ecb44fc4fb209df09eda07462af'
+  data.tar.gz: d9f652e6df2d4680e7a81e792449a34d189de9aecf8d320cad78ccb8d3460417
 SHA512:
-  metadata.gz: a1f208706bea3e1bac3022fbc290a8f09b7ea0864a7d00940a10d186014fed411670bee9eeecfb92b16adad11ac83b971acff9bf9610de01b9c444b3c0995ad9
-  data.tar.gz: 3f499461ef3d090f1deaf6f45eb8996667424aa2a7afad54da78342d20033814e81136b118faf80463090837f010742ab41c826333e010072ae62bac5af5567b
+  metadata.gz: df078370f8522e3ab4c38ddcb114aa91ffde2b932aa6bb63ab4292b24645f0828d7ba556319b1e52878b46b43bd672e0c60d396110b722192bf00764296a45f6
+  data.tar.gz: 6f2d40c7bb04dd739589e161e02777c872fbc547567767e4f0fc1f1508f800b22c7442c3a264b9ce1595c8bf1e483a89725500ffe27375c50a3f55e0f2fe0b69

data/Rakefile

@@ -8,3 +8,7 @@ task :default do
     sh 'bin/rspec'
   end
 end
+
+require 'rake/clean'
+CLOBBER.include('tmp/cache/rails-new')
+CLOBBER.include('dummy-app')

data/app/models/solidus_stripe/payment_intent.rb

@@ -39,7 +39,8 @@ module SolidusStripe
 
     def usable?
       stripe_intent_id &&
-      stripe_intent.status == 'requires_payment_method' &&
+      (stripe_intent.status == 'requires_payment_method' ||
+        stripe_intent.status == 'requires_confirmation') &&
       stripe_intent.amount == stripe_order_amount
     end
 

data/bin/dummy-app

@@ -22,8 +22,5 @@ echo "gem 'simplecov', '~> 0.22', require: false" >> Gemfile
 echo "gem 'simplecov-cobertura', require: false" >> Gemfile
 unbundled bundle install
 
-unbundled bundle add solidus --github solidusio/solidus --branch "${SOLIDUS_BRANCH:-main}" --version '> 0.a'
-unbundled bundle exec rake db:drop db:create
-unbundled bundle exec rails generate solidus:install --auto-accept --payment-method=none --no-seed --no-sample "$@"
 unbundled bundle add $extension_name --path ..
 unbundled bundle exec rails generate $extension_name:install --migrate --load-seeds=false --specs=all

data/bin/rails-new

@@ -11,6 +11,8 @@ rails_version=`bundle exec ruby -rrails/version -e'puts Rails.version'`
 solidus_version=`bundle exec ruby -rspree/core/version -e'puts Spree::VERSION'`
 cache_path="tmp/cache/rails-new/${app_name}-${rails_version}-${solidus_version}-${ruby_version}.zip"
 
+test $CI && cache_path="" # Disable caching on CI
+
 # Stay away from the bundler env of the containing extension.
 function unbundled {
   echo "~~> Running: $@"

data/lib/solidus_stripe/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module SolidusStripe
-  VERSION = '5.0.0'
+  VERSION = '5.0.2'
 end

data/spec/support/solidus_stripe/backend_test_helper.rb

@@ -70,7 +70,14 @@ module SolidusStripe::BackendTestHelper
 
   def visit_payment_page(payment)
     visit_payments_page
-    click_on payment.number
+    click_on_payment(payment)
+  end
+
+  def click_on_payment(payment)
+    payment_number_link = find_link(payment.number)
+    page.current_window.resize_to(1200, 800)
+    scroll_to payment_number_link
+    payment_number_link.click
   end
 
   # Action helper methods for performing operations on payments
@@ -110,6 +117,7 @@ module SolidusStripe::BackendTestHelper
   def complete_order_with_existing_payment_source
     visit_payments_page
     click_on "Continue"
+    page.current_window.resize_to(1200, 800)
     click_on "Confirm"
     click_on "Complete Order"
   end

data/spec/system/backend/solidus_stripe/orders/payments_spec.rb

@@ -13,8 +13,12 @@ RSpec.describe 'SolidusStripe Orders Payments', :js do
     it 'navigates to the payments page' do
       payment = create_authorized_payment
       visit_payments_page
-
-      click_on 'Payments'
+      within('[data-hook="admin_order_tabs"]') do
+        payments_link = find_link('Payments')
+        scroll_to payments_link
+        page.current_window.resize_to(1200, 800)
+        payments_link.click
+      end
       expect(page).to have_content(payment.number)
     end
 

data/spec/system/frontend/solidus_stripe/checkout_spec.rb

@@ -203,4 +203,23 @@ RSpec.describe 'SolidusStripe Checkout', :js do
       end
     end
   end
+
+  context 'when refreshing the confirmation page' do
+    it 'does not create a duplicate payment intent' do
+      create_payment_method
+      visit_payment_step(user: create(:user))
+      choose_new_stripe_payment
+      fill_in_stripe_country('United States')
+      fill_stripe_form(number: '4000000000003220')
+      submit_payment
+      expect(page).to have_content('Confirm')
+      check_terms_of_service # ensure we're on the confirm page before refreshing
+      page.driver.browser.navigate.refresh
+      check_terms_of_service
+      confirm_order
+      authorize_3d_secure_2_payment(authenticate: true)
+      expect(page).to have_content('Your order has been processed successfully')
+      payment_intent_is_created_with_required_capture
+    end
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: solidus_stripe
 version: !ruby/object:Gem::Version
-  version: 5.0.0
+  version: 5.0.2
 platform: ruby
 authors:
 - Solidus Team
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2023-08-02 00:00:00.000000000 Z
+date: 2023-11-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: solidus_core
@@ -291,7 +291,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.4.14
+rubygems_version: 3.4.18
 signing_key:
 specification_version: 4
 summary: Stripe Payment Method for Solidus