solidus_stripe 4.4.0 → 5.0.0.alpha.1

data/spec/system/frontend/solidus_stripe/checkout_spec.rb

@@ -0,0 +1,187 @@
+# frozen_string_literal: true
+
+require 'solidus_stripe_spec_helper'
+
+RSpec.describe 'SolidusStripe Checkout', :js do
+  include SolidusStripe::CheckoutTestHelper
+
+  # To learn more about setup_future_usage in different contexts with Stripe Payment Intents:
+  # https://stripe.com/docs/payments/payment-intents#future-usage
+  ['', 'on_session', 'off_session'].each do |setup_future_usage|
+    context "with Stripe Payment Intents and setup_future_usage=#{setup_future_usage}" do
+      before { create_payment_method(setup_future_usage: setup_future_usage) }
+
+      it 'creates a payment intent and successfully processes payment' do
+        successfully_creates_a_payment_intent(user: create(:user))
+
+        capture_last_valid_payment
+      end
+
+      context 'with a guest user' do
+        it 'creates a payment intent and successfully processes payment' do
+          successfully_creates_a_payment_intent
+
+          capture_last_valid_payment
+        end
+      end
+    end
+  end
+
+  context 'when auto-capture is enabled' do
+    it 'creates a payment intent and automatically processes payment' do
+      create_payment_method(auto_capture: true)
+
+      successfully_creates_a_payment_intent(user: create(:user), auto_capture: true)
+    end
+  end
+
+  context 'with a registered user' do
+    it 'successfully processes payment using available store credits' do
+      create(:store_credit_payment_method)
+      create_payment_method
+      user = create(:user)
+      store_credit_amount = 5
+      create(:store_credit, user: user, amount: store_credit_amount)
+
+      successfully_creates_a_payment_intent(user: user)
+
+      expects_to_have_specific_authorized_amount_on_stripe(current_order.total - store_credit_amount)
+    end
+
+    ['on_session', 'off_session'].each do |setup_future_usage|
+      context "when setup_future_usage is set with '#{setup_future_usage}'" do
+        before { create_payment_method(setup_future_usage: setup_future_usage) }
+
+        it "successfully reuses a previously saved card from the user's wallet" do
+          user = create(:user)
+          successfully_creates_a_payment_intent(user: user)
+
+          visit_payment_step(user: user)
+          find_existing_payment_radio(user.wallet_payment_sources.first.id).choose
+          submit_payment
+          complete_order
+          payment_intent_is_created_with_required_capture
+          capture_last_valid_payment
+        end
+      end
+    end
+
+    context 'when setup_future_usage is not set' do
+      it 'requires the user to enter their payment information for each new transaction' do
+        create_payment_method(setup_future_usage: '')
+        user = create(:user)
+
+        successfully_creates_a_payment_intent(user: user)
+
+        visit_payment_step(user: user)
+
+        expects_page_to_not_display_wallet_payment_sources
+      end
+    end
+  end
+
+  context 'with declined cards' do
+    it 'reject transactions with cards declined at intent creation or invalid fields and return an appropriate response' do # rubocop:disable Layout/LineLength
+      create_payment_method
+      visit_payment_step(user: create(:user))
+      choose_new_stripe_payment
+
+      # Refer to https://stripe.com/docs/testing#invalid-data for more
+      # information on generating test data with invalid values.
+      invalid_data_are_notified
+
+      # Generic error field messages that appear when the Stripe form
+      # has incomplete data for cards
+      incomplete_cards_are_notified
+
+      # Check the Stripe documentation for more information on
+      # how to test declined payments:
+      # https://stripe.com/docs/testing#declined-payments
+      declined_cards_at_intent_creation_are_notified
+    end
+
+    context 'with 3D Secure cards' do
+      it 'reject transaction with failed authentication and return an appropriate response' do
+        create_payment_method
+        visit_payment_step(user: create(:user))
+        choose_new_stripe_payment
+        fill_in_stripe_country('United States')
+
+        # This 3D Secure card requires authentication for all transactions,
+        # regardless of its setup.
+        # Please refer to the Stripe documentation for more information:
+        # https://stripe.com/docs/testing#authentication-and-setup
+        fill_stripe_form(number: '4000002760003184')
+        submit_payment
+
+        check_terms_of_service
+        confirm_order
+        authorize_3d_secure_payment(authenticate: false)
+
+        expects_page_and_order_to_be_in_payment_step
+        expect(page).to have_content(
+          "We are unable to authenticate your payment method. " \
+          "Please choose a different payment method and try again.",
+          wait: 15
+        )
+
+        fill_in_stripe_country('United States')
+        clear_stripe_form
+
+        # This test script is using 3D Secure 2 authentication, which must be
+        # completed for the payment to be successful.
+        # Please refer to the Stripe documentation for more information:
+        # https://stripe.com/docs/testing#three-ds-cards
+        fill_stripe_form(number: '4000000000003220')
+        submit_payment
+        check_terms_of_service
+        confirm_order
+        authorize_3d_secure_2_payment(authenticate: false)
+
+        expects_page_and_order_to_be_in_payment_step
+        expect(page).to have_content(
+          "We are unable to authenticate your payment method. " \
+          "Please choose a different payment method and try again.",
+          wait: 15
+        )
+      end
+
+      it 'processes the transaction with successful authentication' do
+        user = create(:user)
+
+        create_payment_method(setup_future_usage: '')
+        visit_payment_step(user: user)
+        choose_new_stripe_payment
+        fill_in_stripe_country('United States')
+
+        # This 3D Secure card requires authentication for all transactions,
+        # regardless of its setup.
+        # Please refer to the Stripe documentation for more information:
+        # https://stripe.com/docs/testing#authentication-and-setup
+        fill_stripe_form(number: '4000002760003184')
+        submit_payment
+        check_terms_of_service
+        confirm_order
+        authorize_3d_secure_payment(authenticate: true)
+        expect(page).to have_content('Your order has been processed successfully')
+        payment_intent_is_created_with_required_capture
+
+        visit_payment_step(user: user)
+        choose_new_stripe_payment
+        fill_in_stripe_country('United States')
+
+        # This test script is using 3D Secure 2 authentication, which must be
+        # completed for the payment to be successful.
+        # Please refer to the Stripe documentation for more information:
+        # https://stripe.com/docs/testing#three-ds-cards
+        fill_stripe_form(number: '4000000000003220')
+        submit_payment
+        check_terms_of_service
+        confirm_order
+        authorize_3d_secure_2_payment(authenticate: true)
+        expect(page).to have_content('Your order has been processed successfully')
+        payment_intent_is_created_with_required_capture
+      end
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: solidus_stripe
 version: !ruby/object:Gem::Version
-  version: 4.4.0
+  version: 5.0.0.alpha.1
 platform: ruby
 authors:
 - Solidus Team
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2022-12-19 00:00:00.000000000 Z
+date: 2023-04-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: solidus_core
@@ -16,7 +16,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '2.3'
+        version: '3.2'
     - - "<"
       - !ruby/object:Gem::Version
         version: '4'
@@ -26,7 +26,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '2.3'
+        version: '3.2'
     - - "<"
       - !ruby/object:Gem::Version
         version: '4'
@@ -45,27 +45,27 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0.8'
 - !ruby/object:Gem::Dependency
-  name: activemerchant
+  name: stripe
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.105'
+        version: '8.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.105'
+        version: '8.0'
 - !ruby/object:Gem::Dependency
-  name: rexml
+  name: redcarpet
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-  type: :runtime
+  type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
@@ -73,19 +73,75 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: solidus_dev_support
+  name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.5'
+        version: '1.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.5'
+        version: '1.0'
+- !ruby/object:Gem::Dependency
+  name: rubocop-performance
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.5'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.5'
+- !ruby/object:Gem::Dependency
+  name: rubocop-rails
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.3'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.3'
+- !ruby/object:Gem::Dependency
+  name: rubocop-rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.0'
+- !ruby/object:Gem::Dependency
+  name: yard
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Stripe Payment Method for Solidus
 email: contact@solidus.io
 executables: []
@@ -99,83 +155,133 @@ files:
 - ".gitignore"
 - ".rspec"
 - ".rubocop.yml"
-- ".rubocop_todo.yml"
-- ".travis.yml"
+- ".yardopts"
 - CHANGELOG.md
 - Gemfile
 - LICENSE
+- Procfile.dev
 - README.md
 - Rakefile
-- app/assets/javascripts/spree/frontend/solidus_stripe.js
-- app/assets/javascripts/spree/frontend/solidus_stripe/stripe-cart-page-checkout.js
-- app/assets/javascripts/spree/frontend/solidus_stripe/stripe-elements.js
-- app/assets/javascripts/spree/frontend/solidus_stripe/stripe-init.js
-- app/assets/javascripts/spree/frontend/solidus_stripe/stripe-payment-intents.js
-- app/assets/javascripts/spree/frontend/solidus_stripe/stripe-payment-request-button-shared.js
-- app/assets/javascripts/spree/frontend/solidus_stripe/stripe-payment.js
+- app/assets/javascripts/spree/backend/solidus_stripe.js
+- app/assets/stylesheets/spree/backend/solidus_stripe.css
 - app/controllers/solidus_stripe/intents_controller.rb
-- app/controllers/solidus_stripe/payment_request_controller.rb
-- app/controllers/spree/stripe_controller.rb
-- app/decorators/models/spree/order_update_attributes_decorator.rb
-- app/decorators/models/spree/payment_decorator.rb
-- app/decorators/models/spree/refund_decorator.rb
-- app/models/solidus_stripe/address_from_params_service.rb
-- app/models/solidus_stripe/create_intents_payment_service.rb
-- app/models/solidus_stripe/prepare_order_for_payment_service.rb
-- app/models/solidus_stripe/shipping_rates_service.rb
-- app/models/spree/payment_method/stripe_credit_card.rb
+- app/controllers/solidus_stripe/webhooks_controller.rb
+- app/models/concerns/solidus_stripe/log_entries.rb
+- app/models/solidus_stripe.rb
+- app/models/solidus_stripe/customer.rb
+- app/models/solidus_stripe/gateway.rb
+- app/models/solidus_stripe/payment_intent.rb
+- app/models/solidus_stripe/payment_method.rb
+- app/models/solidus_stripe/payment_source.rb
+- app/models/solidus_stripe/slug_entry.rb
+- app/subscribers/solidus_stripe/webhook/charge_subscriber.rb
+- app/subscribers/solidus_stripe/webhook/payment_intent_subscriber.rb
+- app/views/spree/admin/payments/source_forms/_stripe.html.erb
+- app/views/spree/admin/payments/source_forms/existing_payment/_stripe.html.erb
+- app/views/spree/admin/payments/source_forms/existing_payment/stripe/_card.html.erb
+- app/views/spree/admin/payments/source_forms/existing_payment/stripe/_default.html.erb
+- app/views/spree/admin/payments/source_views/_stripe.html.erb
+- app/views/spree/api/payments/source_views/_stripe.json.jbuilder
 - bin/console
-- bin/r
+- bin/dev
+- bin/dummy-app
 - bin/rails
+- bin/rails-dummy-app
 - bin/rails-engine
+- bin/rails-new
 - bin/rails-sandbox
 - bin/rake
+- bin/rspec
 - bin/sandbox
-- bin/sandbox_rails
 - bin/setup
+- bin/update-migrations
+- codecov.yml
 - config/locales/en.yml
 - config/routes.rb
-- db/migrate/20181010123508_update_stripe_payment_method_type_to_credit_card.rb
+- coverage.rb
+- db/migrate/20230109183332_create_solidus_stripe_payment_sources.rb
+- db/migrate/20230303154931_create_solidus_stripe_setup_intent.rb
+- db/migrate/20230306105520_create_solidus_stripe_payment_intents.rb
+- db/migrate/20230308122414_create_solidus_stripe_webhook_endpoints.rb
+- db/migrate/20230310152615_add_payment_method_reference_to_stripe_intents.rb
+- db/migrate/20230310171444_normalize_stripe_intent_id_attributes.rb
+- db/migrate/20230313150008_create_solidus_stripe_customers.rb
+- db/migrate/20230323154931_drop_solidus_stripe_setup_intent.rb
+- db/migrate/20230403094916_rename_webhook_endpoint_to_payment_method_slug_entries.rb
 - db/seeds.rb
-- lib/assets/stylesheets/spree/frontend/solidus_stripe.scss
 - lib/generators/solidus_stripe/install/install_generator.rb
+- lib/generators/solidus_stripe/install/templates/app/assets/stylesheets/spree/frontend/solidus_stripe.css
+- lib/generators/solidus_stripe/install/templates/app/javascript/controllers/solidus_stripe_confirm_controller.js
+- lib/generators/solidus_stripe/install/templates/app/javascript/controllers/solidus_stripe_payment_controller.js
+- lib/generators/solidus_stripe/install/templates/app/views/checkouts/existing_payment/_stripe.html.erb
+- lib/generators/solidus_stripe/install/templates/app/views/checkouts/existing_payment/stripe/_card.html.erb
+- lib/generators/solidus_stripe/install/templates/app/views/checkouts/existing_payment/stripe/_default.html.erb
+- lib/generators/solidus_stripe/install/templates/app/views/checkouts/payment/_stripe.html.erb
+- lib/generators/solidus_stripe/install/templates/app/views/orders/payment_info/_stripe.html.erb
+- lib/generators/solidus_stripe/install/templates/config/initializers/solidus_stripe.rb
 - lib/solidus_stripe.rb
 - lib/solidus_stripe/configuration.rb
 - lib/solidus_stripe/engine.rb
-- lib/solidus_stripe/testing_support/card_input_helper.rb
+- lib/solidus_stripe/money_to_stripe_amount_converter.rb
+- lib/solidus_stripe/refunds_synchronizer.rb
+- lib/solidus_stripe/seeds.rb
 - lib/solidus_stripe/testing_support/factories.rb
 - lib/solidus_stripe/version.rb
-- lib/tasks/solidus_stripe/db/seed.rake
-- lib/views/api/spree/api/payments/source_views/_stripe.json.jbuilder
-- lib/views/backend/spree/admin/log_entries/_stripe.html.erb
-- lib/views/backend/spree/admin/payments/source_forms/_stripe.html.erb
-- lib/views/backend/spree/admin/payments/source_views/_stripe.html.erb
-- lib/views/frontend/spree/checkout/existing_payment/_stripe.html.erb
-- lib/views/frontend/spree/checkout/payment/_stripe.html.erb
-- lib/views/frontend/spree/checkout/payment/v2/_javascript.html.erb
-- lib/views/frontend/spree/checkout/payment/v3/_elements.html.erb
-- lib/views/frontend/spree/checkout/payment/v3/_form_elements.html.erb
-- lib/views/frontend/spree/checkout/payment/v3/_intents.html.erb
-- lib/views/frontend/spree/checkout/payment/v3/_stripe.html.erb
-- lib/views/frontend/spree/orders/_stripe_payment_request_button.html.erb
+- lib/solidus_stripe/webhook/event.rb
 - solidus_stripe.gemspec
-- spec/features/stripe_checkout_spec.rb
-- spec/models/solidus_stripe/address_from_params_service_spec.rb
-- spec/models/solidus_stripe/create_intents_payment_service_spec.rb
-- spec/models/solidus_stripe/prepare_order_for_payment_service_spec.rb
-- spec/models/solidus_stripe/shipping_rates_service_spec.rb
-- spec/models/spree/payment_method/stripe_credit_card_spec.rb
-- spec/requests/payment_requests_spec.rb
-- spec/spec_helper.rb
-- spec/support/solidus_address_helper.rb
+- spec/lib/solidus_stripe/configuration_spec.rb
+- spec/lib/solidus_stripe/money_to_stripe_amount_converter_spec.rb
+- spec/lib/solidus_stripe/refunds_synchronizer_spec.rb
+- spec/lib/solidus_stripe/seeds_spec.rb
+- spec/lib/solidus_stripe/webhook/event_spec.rb
+- spec/models/concerns/solidus_stripe/log_entries_spec.rb
+- spec/models/solidus_stripe/customer_spec.rb
+- spec/models/solidus_stripe/gateway_spec.rb
+- spec/models/solidus_stripe/payment_intent_spec.rb
+- spec/models/solidus_stripe/payment_method_spec.rb
+- spec/models/solidus_stripe/payment_source_spec.rb
+- spec/requests/solidus_stripe/intents_controller_spec.rb
+- spec/requests/solidus_stripe/webhooks_controller/charge/refunded_spec.rb
+- spec/requests/solidus_stripe/webhooks_controller/payment_intent/canceled_spec.rb
+- spec/requests/solidus_stripe/webhooks_controller/payment_intent/payment_failed_spec.rb
+- spec/requests/solidus_stripe/webhooks_controller/payment_intent/succeeded_spec.rb
+- spec/requests/solidus_stripe/webhooks_controller_spec.rb
+- spec/solidus_stripe_spec_helper.rb
+- spec/subscribers/solidus_stripe/webhook/charge_subscriber_spec.rb
+- spec/subscribers/solidus_stripe/webhook/payment_intent_subscriber_spec.rb
+- spec/support/solidus_stripe/backend_test_helper.rb
+- spec/support/solidus_stripe/checkout_test_helper.rb
+- spec/support/solidus_stripe/factories.rb
+- spec/support/solidus_stripe/webhook/data_fixtures.rb
+- spec/support/solidus_stripe/webhook/event_with_context_factory.rb
+- spec/support/solidus_stripe/webhook/request_helper.rb
+- spec/system/backend/solidus_stripe/orders/payments_spec.rb
+- spec/system/frontend/.keep
+- spec/system/frontend/solidus_stripe/checkout_spec.rb
+- tmp/.keep
 homepage: https://github.com/solidusio/solidus_stripe#readme
 licenses:
 - BSD-3
 metadata:
   homepage_uri: https://github.com/solidusio/solidus_stripe#readme
   source_code_uri: https://github.com/solidusio/solidus_stripe
-  changelog_uri: https://github.com/solidusio/solidus_stripe/blob/master/CHANGELOG.md
-post_install_message:
+  changelog_uri: https://github.com/solidusio/solidus_stripe/releases
+post_install_message: |
+  ------------------------------------------------------------------------
+          ⚠️ **WARNING: `solidus_stripe` & `solidus_frontend** ⚠️
+  ------------------------------------------------------------------------
+
+  If you need support for `solidus_frontend` please add `< 5`
+  as a version requirement in your gemfile:
+
+  `gem 'solidus_stripe', '< 5'`
+
+  or if your tracking the github version please switch to
+  the `v4` branch:
+
+  `gem 'solidus_stripe', github: 'solidusio/solidus_stripe', branch: 'v4'`
+
+  ------------------------------------------------------------------------
 rdoc_options: []
 require_paths:
 - lib
@@ -183,24 +289,44 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '2.5'
+      version: '3.0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - ">"
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.3.1
 requirements: []
-rubygems_version: 3.3.26
+rubygems_version: 3.4.10
 signing_key:
 specification_version: 4
 summary: Stripe Payment Method for Solidus
 test_files:
-- spec/features/stripe_checkout_spec.rb
-- spec/models/solidus_stripe/address_from_params_service_spec.rb
-- spec/models/solidus_stripe/create_intents_payment_service_spec.rb
-- spec/models/solidus_stripe/prepare_order_for_payment_service_spec.rb
-- spec/models/solidus_stripe/shipping_rates_service_spec.rb
-- spec/models/spree/payment_method/stripe_credit_card_spec.rb
-- spec/requests/payment_requests_spec.rb
-- spec/spec_helper.rb
-- spec/support/solidus_address_helper.rb
+- spec/lib/solidus_stripe/configuration_spec.rb
+- spec/lib/solidus_stripe/money_to_stripe_amount_converter_spec.rb
+- spec/lib/solidus_stripe/refunds_synchronizer_spec.rb
+- spec/lib/solidus_stripe/seeds_spec.rb
+- spec/lib/solidus_stripe/webhook/event_spec.rb
+- spec/models/concerns/solidus_stripe/log_entries_spec.rb
+- spec/models/solidus_stripe/customer_spec.rb
+- spec/models/solidus_stripe/gateway_spec.rb
+- spec/models/solidus_stripe/payment_intent_spec.rb
+- spec/models/solidus_stripe/payment_method_spec.rb
+- spec/models/solidus_stripe/payment_source_spec.rb
+- spec/requests/solidus_stripe/intents_controller_spec.rb
+- spec/requests/solidus_stripe/webhooks_controller/charge/refunded_spec.rb
+- spec/requests/solidus_stripe/webhooks_controller/payment_intent/canceled_spec.rb
+- spec/requests/solidus_stripe/webhooks_controller/payment_intent/payment_failed_spec.rb
+- spec/requests/solidus_stripe/webhooks_controller/payment_intent/succeeded_spec.rb
+- spec/requests/solidus_stripe/webhooks_controller_spec.rb
+- spec/solidus_stripe_spec_helper.rb
+- spec/subscribers/solidus_stripe/webhook/charge_subscriber_spec.rb
+- spec/subscribers/solidus_stripe/webhook/payment_intent_subscriber_spec.rb
+- spec/support/solidus_stripe/backend_test_helper.rb
+- spec/support/solidus_stripe/checkout_test_helper.rb
+- spec/support/solidus_stripe/factories.rb
+- spec/support/solidus_stripe/webhook/data_fixtures.rb
+- spec/support/solidus_stripe/webhook/event_with_context_factory.rb
+- spec/support/solidus_stripe/webhook/request_helper.rb
+- spec/system/backend/solidus_stripe/orders/payments_spec.rb
+- spec/system/frontend/.keep
+- spec/system/frontend/solidus_stripe/checkout_spec.rb