solidus_starter_frontend 0.1.0

data/spec/controllers/spree/products_controller_spec.rb

@@ -0,0 +1,38 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe Spree::ProductsController, type: :controller do
+  let!(:product) { create(:product, available_on: 1.year.from_now) }
+
+  # Regression test for https://github.com/spree/spree/issues/1390
+  it "allows admins to view non-active products" do
+    allow(controller).to receive_messages try_spree_current_user: mock_model(Spree.user_class, has_spree_role?: true, last_incomplete_spree_order: nil, spree_api_key: 'fake')
+    get :show, params: { id: product.to_param }
+    expect(response.status).to eq(200)
+  end
+
+  it "cannot view non-active products" do
+    expect {
+      get :show, params: { id: product.to_param }
+    }.to raise_error(ActiveRecord::RecordNotFound)
+  end
+
+  it "should provide the current user to the searcher class" do
+    user = mock_model(Spree.user_class, last_incomplete_spree_order: nil, spree_api_key: 'fake')
+    allow(controller).to receive_messages try_spree_current_user: user
+    expect_any_instance_of(Spree::Config.searcher_class).to receive(:current_user=).with(user)
+    get :index
+    expect(response.status).to eq(200)
+  end
+
+  # Regression test for https://github.com/spree/spree/issues/2249
+  it "doesn't error when given an invalid referer" do
+    current_user = mock_model(Spree.user_class, has_spree_role?: true, last_incomplete_spree_order: nil, generate_spree_api_key!: nil)
+    allow(controller).to receive_messages try_spree_current_user: current_user
+    request.env['HTTP_REFERER'] = "not|a$url"
+
+    # Previously a URI::InvalidURIError exception was being thrown
+    get :show, params: { id: product.to_param }
+  end
+end

data/spec/controllers/spree/taxons_controller_spec.rb

@@ -0,0 +1,14 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe Spree::TaxonsController, type: :controller do
+  it "should provide the current user to the searcher class" do
+    taxon = create(:taxon, permalink: "test")
+    user = mock_model(Spree.user_class, last_incomplete_spree_order: nil, spree_api_key: 'fake')
+    allow(controller).to receive_messages try_spree_current_user: user
+    expect_any_instance_of(Spree::Config.searcher_class).to receive(:current_user=).with(user)
+    get :show, params: { id: taxon.permalink }
+    expect(response.status).to eq(200)
+  end
+end

data/spec/generators/solidus/views/override_generator_spec.rb

@@ -0,0 +1,50 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+require 'generator_spec'
+require 'generators/solidus_starter_frontend/views/override_generator'
+
+RSpec.describe SolidusStarterFrontend::Views::OverrideGenerator, type: :generator do
+  destination Rails.root.join('app', 'views', 'spree')
+
+  before(:all) do
+    prepare_destination
+  end
+
+  subject! do
+    run_generator arguments
+  end
+
+  let(:src) do
+    ::SolidusStarterFrontend::Engine.root.join('app', 'views', 'spree')
+  end
+
+  let(:dest) do
+    Rails.root.join('app', 'views', 'spree')
+  end
+
+  context 'without any arguments' do
+    let(:arguments) { %w() }
+
+    it 'copies all views into the host app' do
+      expect(src.entries).to match_array(dest.entries)
+    end
+  end
+
+  context 'when "products" is passed as --only argument' do
+    let(:arguments) { %w(--only products) }
+
+    context 'as folder' do
+      it 'exclusively copies views whose name contains "products"' do
+        Dir.glob(dest.join("**", "*")).each do |file|
+          next if File.directory?(file)
+          expect(file.to_s).to match("products")
+        end
+      end
+    end
+  end
+
+  after do
+    FileUtils.rm_rf destination_root
+  end
+end

data/spec/helpers/base_helper_spec.rb

@@ -0,0 +1,13 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+module Spree
+  describe BaseHelper, type: :helper do
+    # Regression test for https://github.com/spree/spree/issues/2759
+    it "nested_taxons_path works with a Taxon object" do
+      taxon = create(:taxon, name: "iphone")
+      expect(spree.nested_taxons_path(taxon)).to eq("/t/iphone")
+    end
+  end
+end

data/spec/helpers/order_helper_spec.rb

@@ -0,0 +1,14 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+module Spree
+  describe Spree::OrdersHelper, type: :helper do
+    # Regression test for https://github.com/spree/spree/issues/2518 and https://github.com/spree/spree/issues/2323
+    it "truncates HTML correctly in product description" do
+      product = double(description: "<strong>" + ("a" * 95) + "</strong> This content is invisible.")
+      expected = "<strong>" + ("a" * 95) + "</strong>..."
+      expect(truncated_product_description(product)).to eq(expected)
+    end
+  end
+end

data/spec/helpers/taxon_filters_helper_spec.rb

@@ -0,0 +1,12 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+RSpec.describe Spree::TaxonFiltersHelper, type: :helper do
+  let(:taxon) { nil }
+  subject { applicable_filters_for(taxon) }
+
+  it "returns the price/brand filters" do
+    expect(subject.map { |y| y[:name] }).to eq ['Brands', 'Price Range']
+  end
+end

data/spec/spec_helper.rb

@@ -0,0 +1,64 @@
+# frozen_string_literal: true
+
+# Configure Rails Environment
+ENV['RAILS_ENV'] = 'test'
+
+# Run Coverage report
+require 'solidus_dev_support/rspec/coverage'
+
+require File.expand_path('dummy/config/environment.rb', __dir__)
+
+require 'rails-controller-testing'
+require 'rspec/active_model/mocks'
+
+# Requires factories and other useful helpers defined in spree_core.
+require 'solidus_dev_support/rspec/feature_helper'
+require 'spree/testing_support/caching'
+require 'spree/testing_support/order_walkthrough'
+require 'spree/testing_support/translations' unless Spree.solidus_gem_version < Gem::Version.new('2.11')
+
+# Requires supporting ruby files with custom matchers and macros, etc,
+# in spec/support/ and its subdirectories.
+Dir[File.join(File.dirname(__FILE__), 'support/**/*.rb')].each { |f| require f }
+
+# Requires factories defined in lib/solidus_starter_frontend/factories.rb
+require 'solidus_starter_frontend/factories'
+
+RSpec.configure do |config|
+  config.infer_spec_type_from_file_location!
+  config.use_transactional_fixtures = false
+
+  if Spree.solidus_gem_version < Gem::Version.new('2.11')
+    config.extend Spree::TestingSupport::AuthorizationHelpers::Request, type: :system
+
+    config.after(:each, type: :system) do |example|
+      missing_translations = page.body.scan(/translation missing: #{I18n.locale}\.(.*?)[\s<\"&]/)
+      if missing_translations.any?
+        puts "Found missing translations: #{missing_translations.inspect}\n"
+        puts "In spec: #{example.location}"
+      end
+    end
+  end
+
+  if SolidusSupport.reset_spree_preferences_deprecated?
+    config.before :suite do
+      Spree::TestingSupport::Preferences.freeze_preferences(SolidusStarterFrontend::Config)
+    end
+  else
+    config.before do
+      SolidusStarterFrontend::Config.preference_store = SolidusStarterFrontend::Config.default_preferences
+    end
+  end
+
+  config.before do
+    Rails.cache.clear
+  end
+
+  config.before(:each, type: :system) do
+    driven_by((ENV['CAPYBARA_DRIVER'] || :rack_test).to_sym)
+  end
+
+  config.before(:each, type: :system, js: true) do
+    driven_by((ENV['CAPYBARA_JS_DRIVER'] || :apparition).to_sym)
+  end
+end

data/spec/support/shared_contexts/checkout_setup.rb

@@ -0,0 +1,12 @@
+# frozen_string_literal: true
+
+shared_context 'checkout setup' do
+  let!(:store) { create(:store) }
+  let!(:country) { create(:country, states_required: true) }
+  let!(:state) { create(:state, country: country) }
+  let!(:shipping_method) { create(:shipping_method) }
+  let!(:stock_location) { create(:stock_location) }
+  let!(:mug) { create(:product, name: "RoR Mug") }
+  let!(:payment_method) { create(:check_payment_method) }
+  let!(:zone) { create(:zone) }
+end

data/spec/support/shared_contexts/custom_products.rb

@@ -0,0 +1,28 @@
+# frozen_string_literal: true
+
+shared_context "custom products" do
+  before(:each) do
+    create(:store)
+    taxonomy = FactoryBot.create(:taxonomy, name: 'Categories')
+    root = taxonomy.root
+    clothing_taxon = FactoryBot.create(:taxon, name: 'Clothing', parent_id: root.id)
+    bags_taxon = FactoryBot.create(:taxon, name: 'Bags', parent_id: root.id)
+    mugs_taxon = FactoryBot.create(:taxon, name: 'Mugs', parent_id: root.id)
+
+    taxonomy = FactoryBot.create(:taxonomy, name: 'Brands')
+    root = taxonomy.root
+    apache_taxon = FactoryBot.create(:taxon, name: 'Apache', parent_id: root.id)
+    rails_taxon = FactoryBot.create(:taxon, name: 'Ruby on Rails', parent_id: root.id)
+    ruby_taxon = FactoryBot.create(:taxon, name: 'Ruby', parent_id: root.id)
+
+    FactoryBot.create(:custom_product, name: 'Ruby on Rails Ringer T-Shirt', price: '19.99', taxons: [rails_taxon, clothing_taxon])
+    FactoryBot.create(:custom_product, name: 'Ruby on Rails Mug', price: '15.99', taxons: [rails_taxon, mugs_taxon])
+    FactoryBot.create(:custom_product, name: 'Ruby on Rails Tote', price: '15.99', taxons: [rails_taxon, bags_taxon])
+    FactoryBot.create(:custom_product, name: 'Ruby on Rails Bag', price: '22.99', taxons: [rails_taxon, bags_taxon])
+    FactoryBot.create(:custom_product, name: 'Ruby on Rails Baseball Jersey', price: '19.99', taxons: [rails_taxon, clothing_taxon])
+    FactoryBot.create(:custom_product, name: 'Ruby on Rails Stein', price: '16.99', taxons: [rails_taxon, mugs_taxon])
+    FactoryBot.create(:custom_product, name: 'Ruby on Rails Jr. Spaghetti', price: '19.99', taxons: [rails_taxon, clothing_taxon])
+    FactoryBot.create(:custom_product, name: 'Ruby Baseball Jersey', price: '19.99', taxons: [ruby_taxon, clothing_taxon])
+    FactoryBot.create(:custom_product, name: 'Apache Baseball Jersey', price: '19.99', taxons: [apache_taxon, clothing_taxon])
+  end
+end

data/spec/support/shared_contexts/locales.rb

@@ -0,0 +1,16 @@
+# frozen_string_literal: true
+
+shared_context 'fr locale' do
+  before do
+    I18n.backend.store_translations(:fr, spree: {
+      i18n: { this_file_language: "Français" },
+      cart: 'Panier',
+      shopping_cart: 'Panier'
+    })
+  end
+
+  after do
+    I18n.locale = :en # reset locale after each spec.
+    I18n.reload!
+  end
+end

data/spec/system/address_spec.rb

@@ -0,0 +1,87 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe 'Address', type: :system, inaccessible: true do
+  let!(:product) { create(:product, name: "RoR Mug") }
+  let!(:order) { create(:order_with_totals, state: 'cart') }
+
+  stub_authorization!
+
+  before do
+    visit spree.root_path
+
+    click_link 'RoR Mug'
+    click_button 'add-to-cart-button'
+
+    address = 'order_bill_address_attributes'
+    @state_select_css = "##{address}_state_id"
+    @state_name_css = "##{address}_state_name"
+  end
+
+  context 'country requires state', js: true do
+    let!(:canada) { create(:country, name: 'Canada', states_required: true, iso: 'CA') }
+    let!(:uk) { create(:country, name: 'United Kingdom', states_required: true, iso: 'GB') }
+
+    before { stub_spree_preferences(default_country_iso: uk.iso) }
+
+    context 'but has no state' do
+      it 'shows the state input field' do
+        click_button 'Checkout'
+
+        within('#billing') do
+          select canada.name, from: 'Country'
+          expect(page).to have_no_css(@state_select_css)
+          expect(page).to have_css("#{@state_name_css}.required")
+        end
+      end
+    end
+
+    context 'and has state' do
+      before { create(:state, name: 'Ontario', country: canada) }
+
+      it 'shows the state collection selection' do
+        click_button 'Checkout'
+
+        within('#billing') do
+          select canada.name, from: 'Country'
+          expect(page).to have_no_css(@state_name_css)
+          expect(page).to have_css("#{@state_select_css}.required")
+        end
+      end
+    end
+
+    context 'user changes to country without states required' do
+      let!(:france) { create(:country, name: 'France', states_required: false, iso: 'FR') }
+
+      it 'clears the state name' do
+        click_button 'Checkout'
+        within('#billing') do
+          select canada.name, from: 'Country'
+
+          page.find(@state_name_css).set('Toscana')
+
+          select france.name, from: 'Country'
+
+          expect(page).to have_no_css(@state_name_css)
+          expect(page).to have_no_css(@state_select_css)
+        end
+      end
+    end
+  end
+
+  context 'country does not require state', js: true do
+    let!(:france) { create(:country, name: 'France', states_required: false, iso: 'FR') }
+
+    it 'shows a disabled state input field' do
+      click_button 'Checkout'
+
+      within('#billing') do
+        select france.name, from: 'Country'
+
+        expect(page).to have_no_css(@state_name_css)
+        expect(page).to have_css("#{@state_select_css}[disabled]", visible: false)
+      end
+    end
+  end
+end

data/spec/system/automatic_promotion_adjustments_spec.rb

@@ -0,0 +1,49 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe 'Automatic promotions', type: :system, js: true do
+  let!(:store) { create(:store) }
+  let!(:country) { create(:country, name: "United States of America", states_required: true) }
+  let!(:state) { create(:state, name: "Alabama", country: country) }
+  let!(:zone) { create(:zone) }
+  let!(:shipping_method) { create(:shipping_method) }
+  let!(:payment_method) { create(:check_payment_method) }
+  let!(:product) { create(:product, name: "RoR Mug", price: 20) }
+
+  let!(:promotion) do
+    promotion = Spree::Promotion.create!(name: "$10 off when you spend more than $100", apply_automatically: true)
+
+    calculator = Spree::Calculator::FlatRate.new
+    calculator.preferred_amount = 10
+
+    rule = Spree::Promotion::Rules::ItemTotal.create
+    rule.preferred_amount = 100
+    rule.save
+
+    promotion.rules << rule
+
+    action = Spree::Promotion::Actions::CreateAdjustment.create
+    action.calculator = calculator
+    action.save
+
+    promotion.actions << action
+  end
+
+  context "on the cart page" do
+    before do
+      visit spree.root_path
+      click_link product.name
+      click_button "add-to-cart-button"
+    end
+
+    it "automatically applies the promotion once the order crosses the threshold" do
+      fill_in "order_line_items_attributes_0_quantity", with: 10
+      click_button "Update"
+      expect(page).to have_content("Promotion ($10 off when you spend more than $100) -$10.00", normalize_ws: true)
+      fill_in "order_line_items_attributes_0_quantity", with: 1
+      click_button "Update"
+      expect(page).not_to have_content("Promotion ($10 off when you spend more than $100) -$10.00", normalize_ws: true)
+    end
+  end
+end

data/spec/system/caching/products_spec.rb

@@ -0,0 +1,48 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe 'products', type: :system, caching: true do
+  let!(:product) { create(:product) }
+  let!(:product2) { create(:product) }
+  let!(:taxonomy) { create(:taxonomy) }
+  let!(:taxon) { create(:taxon, taxonomy: taxonomy) }
+
+  before do
+    product2.update_column(:updated_at, 1.day.ago)
+    # warm up the cache
+    visit spree.root_path
+
+    clear_cache_events
+  end
+
+  it "reads from cache upon a second viewing" do
+    visit spree.root_path
+    expect(cache_writes.count).to eq(0)
+  end
+
+  it "busts the cache when a product is updated" do
+    product.update_column(:updated_at, 1.day.from_now)
+    visit spree.root_path
+    expect(cache_writes.count).to eq(2)
+  end
+
+  it "busts the cache when all products are soft-deleted" do
+    product.discard
+    product2.discard
+    visit spree.root_path
+    expect(cache_writes.count).to eq(1)
+  end
+
+  it "busts the cache when the newest product is soft-deleted" do
+    product.discard
+    visit spree.root_path
+    expect(cache_writes.count).to eq(1)
+  end
+
+  it "busts the cache when an older product is soft-deleted" do
+    product2.discard
+    visit spree.root_path
+    expect(cache_writes.count).to eq(1)
+  end
+end