solidus_simple_sale_price 0.0.2 → 0.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5f6b45abb7ef95302cd8514326df022eefee06a726c2d2f867a5f67eef0ba719
-  data.tar.gz: 63c92ac7cd485f8b7e4ba6441397abe7114e5461f7e98ead01772b18eba106ed
+  metadata.gz: 1890c3963e1dacd955f8fc96a40e4da8434ff9d65c92fed1dcae087720cad857
+  data.tar.gz: 28dabfee8eddb42c863c00dd7dd529419f260d6d8b2f47e5f55c64865d28d810
 SHA512:
-  metadata.gz: 5a1811fa669cf1c32d4c3aef88d444712c335f238a0275a03c9a8ba774d60832d091464b7af124cbbdafcd28accf95c835575700d9831278139df698ebb4b4e0
-  data.tar.gz: 067a2c21982980c5a0d9d45bba03cd1379836eb83a562a61216948473b0ccc0837cff577d8069a47c6d2b933f1d7f97a12e25d55a1c18b168456aa9d2941cf92
+  metadata.gz: 46c60de6bf15ee8fd9a1a5324a988b4ba27759400d70393009034e35e2d8904e45860b583fc29a0685db6650ba84438d4d2aa087bb5a4d0cc79be80c29e105cc
+  data.tar.gz: 6bb613db938ab0201e476ffecf6670e460699cfb6901880d098d6428e81e44311cbc39a109c374bb47955f6a00611e4b178f9fd3202fbfab47f32985989ce81c

data/app/models/spree/price_decorator.rb

@@ -8,7 +8,7 @@ Spree::Price.class_eval do
   end
 
   def on_sale?
-    sale_amount.present? && sale_amount < original_amount
+    sale_amount.present? && original_amount.present? && sale_amount < original_amount
   end
 
   def amount

data/app/models/spree/variant_decorator.rb

@@ -2,7 +2,7 @@ Spree::Variant.class_eval do
   delegate :on_sale?, :discount_percent, to: :default_price
 
   def on_sale_in?(currency)
-    price_in_currency(currency).on_sale?
+    !!price_in_currency(currency)&.on_sale?
   end
 
   def sale_price

data/lib/solidus_simple_sale_price/factories.rb

@@ -6,12 +6,12 @@ FactoryBot.define do
   # require 'solidus_simple_sale_price/factories'
 
   factory :price_on_sale, parent: :price do
-    sale_amount 10.90
+    sale_amount { 10.90 }
   end
 
   factory :international_variant, parent: :variant do
     transient do
-      price_currencies %w[KES UAH AUD]
+      price_currencies { %w[KES UAH AUD] }
     end
 
     after(:create) do |variant, evaluator|

data/lib/solidus_simple_sale_price/version.rb

@@ -1,3 +1,3 @@
 module SolidusSimpleSalePrice
-  VERSION = '0.0.2'.freeze
+  VERSION = '0.0.4'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: solidus_simple_sale_price
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.4
 platform: ruby
 authors:
 - Josua Schmid
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2018-06-21 00:00:00.000000000 Z
+date: 2022-10-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: solidus_core
@@ -212,7 +212,7 @@ homepage: http://github.com/renuo/solidus_simple_sale_price
 licenses:
 - BSD-3-Clause
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -227,9 +227,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.3
-signing_key: 
+rubygems_version: 3.3.10
+signing_key:
 specification_version: 4
 summary: Adds sale price functionality to Solidus
 test_files: []