solidus_reviews 1.2.0 → 1.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6fc709261f34b4979904d11cceeb17b22a57be36089f37f77dea475262506c24
-  data.tar.gz: 9a3b6b6f70b0867534f634426da005d312db19e21d5633bb9e5ca2e8ab6ba3ec
+  metadata.gz: d08b28f0274d8513a1b171c01fb30e52ef1c692e7166e9680cb62d19731605b3
+  data.tar.gz: b091c19c062b9dd3cd98c9726b9aab52371817e901a87e15e812349b9ca1a032
 SHA512:
-  metadata.gz: 8c4eaa7f6e301a830b196bd194c897a670a8c193607fe98542890625ed6a3d19b54c7ce8b8df9678ba45bc3db114b0a358c58d053a93be0e438b4fa6354939fe
-  data.tar.gz: e2d8efba5a9ba5602318c40e1bcccb16291f49a68c577e76acf2db42b37e879bb9adfcbc56367b47dbfa84092964bdfe199e7aacb47b85c071c94d134c7906e4
+  metadata.gz: 6d3044e1fa6a0d03491cef8269730d25be40d1ad3e1ebcd32cf81ce71c8dc520a29d8bd8e6415bc738075c11478461cb4be0eb53007d6adb8e613970d835f5e8
+  data.tar.gz: a34b5ea8da48129b82c7063fa9806a635f3d92949fae6a0af0b98c58337480db6dc2e7cfe5f61e8cd1077834e14557ddc72d41127f8664b227fcc62b1fd0791a

data/.rubocop.yml

@@ -1,322 +1,12 @@
-# Relaxed.Ruby.Style
+inherit_from: .rubocop_todo.yml
 
-AllCops:
-  Exclude:
-    - 'vendor/**/*'
-    - '**/vendor/**/*'
-    - '*/spec/dummy/**/*'
-    - 'sandbox/**/*'
-    - '**/templates/**/*'
-  TargetRubyVersion: 2.2
-
-# Sometimes I believe this reads better
-# This also causes spacing issues on multi-line fixes
-Style/BracesAroundHashParameters:
-  Enabled: false
-
-# We use class vars and will have to continue doing so for compatability
-Style/ClassVars:
-  Enabled: false
-
-# We need these names for backwards compatability
-Naming/PredicateName:
-  Enabled: false
-
-Naming/AccessorMethodName:
-  Enabled: false
-
-# This has been used for customization
-Style/MutableConstant:
-  Enabled: false
-
-Style/ClassAndModuleChildren:
-  Enabled: false
-
-Style/EmptyElse:
-  Enabled: false
-
-Style/GuardClause:
-  Enabled: false
-
-Style/Next:
-  Enabled: false
-
-Style/NumericPredicate:
-  Enabled: false
-
-Style/WordArray:
-  Enabled: false
-
-Style/ConditionalAssignment:
-  Enabled: false
-
-Performance/Count:
-  Enabled: false
-
-Style/RaiseArgs:
-  Enabled: false
-
-Naming/BinaryOperatorParameterName:
-  Enabled: false
-
-# We can use good judgement here
-Style/RegexpLiteral:
-  Enabled: false
-
-# Unicode comments are useful
-Style/AsciiComments:
-  Enabled: false
-
-Layout/EndAlignment:
-  Enabled: false
-
-Layout/ElseAlignment:
-  Enabled: false
-
-Layout/IndentationWidth:
-  Enabled: false
+require:
+  - solidus_extension_dev_tools/rubocop
 
-Layout/AlignParameters:
-  Enabled: false
+inherit_gem:
+  solidus_extension_dev_tools: .rubocop.extension.yml
 
-Layout/ClosingParenthesisIndentation:
-  Enabled: false
-
-Layout/MultilineMethodCallIndentation:
-  Enabled: false
-
-Layout/IndentArray:
-  Enabled: false
-
-Layout/IndentHash:
-  Enabled: false
-
-Layout/AlignHash:
-  Enabled: false
-
-Style/TrailingCommaInArguments:
-  Enabled: false
-
-Style/TrailingCommaInArrayLiteral:
-  Enabled: false
-
-Style/TrailingCommaInHashLiteral:
-  Enabled: false
-
-# Symbol Arrays are ok and the %i syntax widely unknown
-Style/SymbolArray:
-  Enabled: false
-
-Rails/DynamicFindBy:
-  Whitelist:
-    - find_by_param
-    - find_by_param!
-
-# We use a lot of
-#
-#     expect {
-#       something
-#     }.to { happen }
-#
-# syntax in the specs files.
-Lint/AmbiguousBlockAssociation:
-  Exclude:
-    - '*/spec/**/*'
-    - 'spec/**/*' # For the benefit of apps that inherit from this config
-
-# We use eval to add common_spree_dependencies into the Gemfiles of each of our gems
-Security/Eval:
+AllCops:
   Exclude:
-    - 'Gemfile'
-    - 'common_spree_dependencies.rb'
-    - '*/Gemfile'
-
-Naming/VariableNumber:
-  Enabled: false
-
-# Write empty methods as you wish.
-Style/EmptyMethod:
-  Enabled: false
-
-# From http://relaxed.ruby.style/
-
-Style/Alias:
-  Enabled: false
-  StyleGuide: http://relaxed.ruby.style/#stylealias
-
-Style/BeginBlock:
-  Enabled: false
-  StyleGuide: http://relaxed.ruby.style/#stylebeginblock
-
-Style/BlockDelimiters:
-  Enabled: false
-  StyleGuide: http://relaxed.ruby.style/#styleblockdelimiters
-
-Style/Documentation:
-  Enabled: false
-  StyleGuide: http://relaxed.ruby.style/#styledocumentation
-
-Layout/DotPosition:
-  Enabled: false
-  StyleGuide: http://relaxed.ruby.style/#styledotposition
-
-Style/DoubleNegation:
-  Enabled: false
-  StyleGuide: http://relaxed.ruby.style/#styledoublenegation
-
-Style/EndBlock:
-  Enabled: false
-  StyleGuide: http://relaxed.ruby.style/#styleendblock
-
-Style/FormatString:
-  Enabled: false
-  StyleGuide: http://relaxed.ruby.style/#styleformatstring
-
-Style/IfUnlessModifier:
-  Enabled: false
-  StyleGuide: http://relaxed.ruby.style/#styleifunlessmodifier
-
-Style/Lambda:
-  Enabled: false
-  StyleGuide: http://relaxed.ruby.style/#stylelambda
-
-Style/ModuleFunction:
-  Enabled: false
-  StyleGuide: http://relaxed.ruby.style/#stylemodulefunction
-
-Style/MultilineBlockChain:
-  Enabled: false
-  StyleGuide: http://relaxed.ruby.style/#stylemultilineblockchain
-
-Style/NegatedIf:
-  Enabled: false
-  StyleGuide: http://relaxed.ruby.style/#stylenegatedif
-
-Style/NegatedWhile:
-  Enabled: false
-  StyleGuide: http://relaxed.ruby.style/#stylenegatedwhile
-
-Style/ParallelAssignment:
-  Enabled: false
-  StyleGuide: http://relaxed.ruby.style/#styleparallelassignment
-
-Style/PercentLiteralDelimiters:
-  Enabled: false
-  StyleGuide: http://relaxed.ruby.style/#stylepercentliteraldelimiters
-
-Style/PerlBackrefs:
-  Enabled: false
-  StyleGuide: http://relaxed.ruby.style/#styleperlbackrefs
-
-Style/Semicolon:
-  Enabled: false
-  StyleGuide: http://relaxed.ruby.style/#stylesemicolon
-
-Style/SignalException:
-  Enabled: false
-  StyleGuide: http://relaxed.ruby.style/#stylesignalexception
-
-Style/SingleLineBlockParams:
-  Enabled: false
-  StyleGuide: http://relaxed.ruby.style/#stylesinglelineblockparams
-
-Style/SingleLineMethods:
-  Enabled: false
-  StyleGuide: http://relaxed.ruby.style/#stylesinglelinemethods
-
-Layout/SpaceBeforeBlockBraces:
-  Enabled: false
-  StyleGuide: http://relaxed.ruby.style/#stylespacebeforeblockbraces
-
-Layout/SpaceInsideParens:
-  Enabled: false
-  StyleGuide: http://relaxed.ruby.style/#stylespaceinsideparens
-
-Style/SpecialGlobalVars:
-  Enabled: false
-  StyleGuide: http://relaxed.ruby.style/#stylespecialglobalvars
-
-Style/StringLiterals:
-  Enabled: false
-  StyleGuide: http://relaxed.ruby.style/#stylestringliterals
-
-Style/SymbolProc:
-  Enabled: false
-
-Style/TernaryParentheses:
-  Enabled: false
-
-Style/WhileUntilModifier:
-  Enabled: false
-  StyleGuide: http://relaxed.ruby.style/#stylewhileuntilmodifier
-
-Lint/AmbiguousRegexpLiteral:
-  Enabled: false
-  StyleGuide: http://relaxed.ruby.style/#lintambiguousregexpliteral
-
-Lint/AssignmentInCondition:
-  Enabled: false
-  StyleGuide: http://relaxed.ruby.style/#lintassignmentincondition
-
-Metrics/AbcSize:
-  Enabled: false
-
-Metrics/BlockNesting:
-  Enabled: false
-
-Metrics/ClassLength:
-  Enabled: false
-
-Metrics/ModuleLength:
-  Enabled: false
-
-Metrics/BlockLength:
-  Enabled: false
-
-Metrics/CyclomaticComplexity:
-  Enabled: false
-
-Metrics/LineLength:
-  Enabled: false
-
-Metrics/MethodLength:
-  Enabled: false
-
-Metrics/ParameterLists:
-  Enabled: false
-
-Metrics/PerceivedComplexity:
-  Enabled: false
-
-Bundler/OrderedGems:
-  Enabled: false
-
-Style/NumericLiterals:
-  Enabled: false
-
-Style/FrozenStringLiteralComment:
-  Enabled: true
-  EnforcedStyle: always
-
-# json.() is idiomatic in jbuilder files
-Style/LambdaCall:
-  Enabled: false
-
-Naming/UncommunicativeMethodParamName:
-  AllowedNames:
-    - id
-    - to
-    - _
-
-# Rubocop doesn't understand side-effects
-Style/IdenticalConditionalBranches:
-  Enabled: false
-
-Naming/MemoizedInstanceVariableName:
-  Enabled: false
-
-Lint/UselessComparison:
-  Enabled: false
-
-Lint/HandleExceptions:
-  Enabled: false
+    - spec/dummy/**/*
+    - vendor/**/*

data/.rubocop_todo.yml

@@ -0,0 +1,221 @@
+# This configuration was generated by
+# `rubocop --auto-gen-config`
+# on 2019-11-27 10:11:04 +0100 using RuboCop version 0.76.0.
+# The point is for the user to remove these configuration records
+# one by one as the offenses are removed from the code base.
+# Note that changes in the inspected code, or installation of new
+# versions of RuboCop, may require this file to be generated again.
+
+# Offense count: 1
+# Configuration parameters: Include.
+# Include: **/*.gemfile, **/Gemfile, **/gems.rb
+Bundler/DuplicatedGem:
+  Exclude:
+    - 'Gemfile'
+
+# Offense count: 1
+# Configuration parameters: Include.
+# Include: **/*.gemspec, 
+Gemspec/RequiredRubyVersion:
+  Exclude:
+    - 'solidus_reviews.gemspec'
+
+# Offense count: 1
+Lint/AmbiguousOperator:
+  Exclude:
+    - 'lib/solidus_reviews/engine.rb'
+
+# Offense count: 1
+Lint/InterpolationCheck:
+  Exclude:
+    - 'spec/models/review_spec.rb'
+
+# Offense count: 33
+# Cop supports --auto-correct.
+# Configuration parameters: AutoCorrect, AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
+# URISchemes: http, https
+Metrics/LineLength:
+  Max: 155
+
+# Offense count: 1
+# Configuration parameters: EnforcedStyleForLeadingUnderscores.
+# SupportedStylesForLeadingUnderscores: disallowed, required, optional
+Naming/MemoizedInstanceVariableName:
+  Exclude:
+    - 'app/controllers/spree/feedback_reviews_controller.rb'
+
+# Offense count: 2
+# Configuration parameters: MinNameLength, AllowNamesEndingInNumbers, AllowedNames, ForbiddenNames.
+# AllowedNames: io, id, to, by, on, in, at, ip, db, os
+Naming/UncommunicativeMethodParamName:
+  Exclude:
+    - 'app/helpers/spree/reviews_helper.rb'
+
+# Offense count: 2
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: snake_case, normalcase, non_integer
+Naming/VariableNumber:
+  Exclude:
+    - 'spec/models/review_spec.rb'
+
+# Offense count: 2
+RSpec/AnyInstance:
+  Exclude:
+    - 'spec/controllers/spree/admin/reviews_controller_spec.rb'
+    - 'spec/controllers/spree/reviews_controller_spec.rb'
+
+# Offense count: 35
+# Configuration parameters: Prefixes.
+# Prefixes: when, with, without
+RSpec/ContextWording:
+  Exclude:
+    - 'spec/controllers/spree/api/reviews_controller_spec.rb'
+    - 'spec/controllers/spree/reviews_controller_spec.rb'
+    - 'spec/features/admin_spec.rb'
+    - 'spec/features/reviews_spec.rb'
+    - 'spec/helpers/review_helper_spec.rb'
+    - 'spec/models/feedback_review_spec.rb'
+    - 'spec/models/product_spec.rb'
+    - 'spec/models/review_spec.rb'
+    - 'spec/models/reviews_ability_spec.rb'
+
+# Offense count: 2
+RSpec/DescribeClass:
+  Exclude:
+    - 'spec/features/admin_spec.rb'
+    - 'spec/features/reviews_spec.rb'
+
+# Offense count: 6
+# Configuration parameters: CustomTransform, IgnoreMethods.
+RSpec/FilePath:
+  Exclude:
+    - 'spec/helpers/review_helper_spec.rb'
+    - 'spec/models/feedback_review_spec.rb'
+    - 'spec/models/product_spec.rb'
+    - 'spec/models/review_spec.rb'
+    - 'spec/models/reviews_ability_spec.rb'
+    - 'spec/models/reviews_configuration_spec.rb'
+
+# Offense count: 1
+# Configuration parameters: AssignmentOnly.
+RSpec/InstanceVariable:
+  Exclude:
+    - 'spec/controllers/spree/reviews_controller_spec.rb'
+
+# Offense count: 6
+RSpec/LetSetup:
+  Exclude:
+    - 'spec/controllers/spree/admin/feedback_reviews_controller_spec.rb'
+    - 'spec/models/product_spec.rb'
+
+# Offense count: 3
+# Configuration parameters: .
+# SupportedStyles: have_received, receive
+RSpec/MessageSpies:
+  EnforcedStyle: receive
+
+# Offense count: 51
+# Configuration parameters: AggregateFailuresByDefault.
+RSpec/MultipleExpectations:
+  Max: 8
+
+# Offense count: 71
+# Configuration parameters: IgnoreSharedExamples.
+RSpec/NamedSubject:
+  Exclude:
+    - 'spec/controllers/spree/api/reviews_controller_spec.rb'
+    - 'spec/models/reviews_configuration_spec.rb'
+
+# Offense count: 8
+RSpec/NestedGroups:
+  Max: 4
+
+# Offense count: 1
+RSpec/UnspecifiedException:
+  Exclude:
+    - 'spec/controllers/spree/feedback_reviews_controller_spec.rb'
+
+# Offense count: 2
+# Configuration parameters: IgnoreNameless, IgnoreSymbolicNames.
+RSpec/VerifiedDoubles:
+  Exclude:
+    - 'spec/models/reviews_ability_spec.rb'
+
+# Offense count: 1
+# Configuration parameters: Include.
+# Include: app/models/**/*.rb
+Rails/HasManyOrHasOneDependent:
+  Exclude:
+    - 'app/models/spree/review.rb'
+
+# Offense count: 1
+# Configuration parameters: Include.
+# Include: app/models/**/*.rb
+Rails/InverseOf:
+  Exclude:
+    - 'app/models/spree/review.rb'
+
+# Offense count: 1
+# Configuration parameters: Include.
+# Include: app/**/*.rb, config/**/*.rb, db/**/*.rb, lib/**/*.rb
+Rails/Output:
+  Exclude:
+    - 'lib/generators/solidus_reviews/install/install_generator.rb'
+
+# Offense count: 1
+# Configuration parameters: Include.
+# Include: **/Rakefile, **/*.rake
+Rails/RakeEnvironment:
+  Exclude:
+    - 'Rakefile'
+
+# Offense count: 2
+Rails/ReflectionClassName:
+  Exclude:
+    - 'app/models/spree/feedback_review.rb'
+    - 'app/models/spree/review.rb'
+
+# Offense count: 5
+# Configuration parameters: Blacklist, Whitelist.
+# Blacklist: decrement!, decrement_counter, increment!, increment_counter, toggle!, touch, update_all, update_attribute, update_column, update_columns, update_counters
+Rails/SkipsModelValidations:
+  Exclude:
+    - 'app/controllers/spree/admin/reviews_controller.rb'
+    - 'db/migrate/20120123141326_recalculate_ratings.rb'
+    - 'spec/controllers/spree/admin/reviews_controller_spec.rb'
+    - 'spec/models/product_spec.rb'
+
+# Offense count: 10
+# Cop supports --auto-correct.
+# Configuration parameters: AutoCorrect, EnforcedStyle.
+# SupportedStyles: nested, compact
+Style/ClassAndModuleChildren:
+  Exclude:
+    - 'app/controllers/spree/admin/feedback_reviews_controller.rb'
+    - 'app/controllers/spree/admin/review_settings_controller.rb'
+    - 'app/controllers/spree/admin/reviews_controller.rb'
+    - 'app/controllers/spree/feedback_reviews_controller.rb'
+    - 'app/controllers/spree/reviews_controller.rb'
+    - 'app/helpers/spree/reviews_helper.rb'
+    - 'app/models/spree/feedback_review.rb'
+    - 'app/models/spree/review.rb'
+    - 'app/models/spree/reviews_ability.rb'
+    - 'app/models/spree/reviews_configuration.rb'
+
+# Offense count: 2
+Style/ClassVars:
+  Exclude:
+    - 'app/decorators/helpers/solidus_reviews/spree/api/api_helpers_decorator.rb'
+
+# Offense count: 1
+# Configuration parameters: .
+# SupportedStyles: annotated, template, unannotated
+Style/FormatStringToken:
+  EnforcedStyle: unannotated
+
+# Offense count: 3
+# Configuration parameters: MinBodyLength.
+Style/GuardClause:
+  Exclude:
+    - 'app/controllers/spree/admin/reviews_controller.rb'
+    - 'lib/controllers/spree/api/reviews_controller.rb'