solidus_reviews 1.2.0 → 1.3.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (42) hide show
  1. checksums.yaml +4 -4
  2. data/.rubocop.yml +8 -318
  3. data/.rubocop_todo.yml +221 -0
  4. data/CHANGELOG.md +100 -0
  5. data/Gemfile +11 -10
  6. data/README.md +29 -44
  7. data/app/controllers/spree/feedback_reviews_controller.rb +2 -8
  8. data/app/controllers/spree/reviews_controller.rb +1 -1
  9. data/app/decorators/models/solidus_reviews/spree/product_decorator.rb +6 -5
  10. data/app/helpers/spree/reviews_helper.rb +5 -5
  11. data/app/models/spree/feedback_review.rb +1 -1
  12. data/app/models/spree/review.rb +9 -8
  13. data/app/models/spree/reviews_ability.rb +2 -2
  14. data/app/views/spree/api/reviews/_feedback_review.json.jbuilder +1 -1
  15. data/app/views/spree/api/reviews/_review.json.jbuilder +1 -1
  16. data/db/migrate/20120123141326_recalculate_ratings.rb +1 -2
  17. data/db/migrate/20190613165528_add_verified_purchaser_to_reviews.rb +2 -0
  18. data/lib/controllers/spree/api/reviews_controller.rb +16 -14
  19. data/lib/generators/solidus_reviews/install/install_generator.rb +1 -1
  20. data/lib/solidus_reviews.rb +4 -2
  21. data/lib/{spree_reviews → solidus_reviews}/engine.rb +3 -3
  22. data/lib/solidus_reviews/version.rb +5 -0
  23. data/solidus_reviews.gemspec +14 -23
  24. data/spec/controllers/spree/admin/feedback_reviews_controller_spec.rb +1 -1
  25. data/spec/controllers/spree/admin/review_settings_controller_spec.rb +3 -4
  26. data/spec/controllers/spree/admin/reviews_controller_spec.rb +3 -3
  27. data/spec/controllers/spree/api/reviews_controller_spec.rb +27 -25
  28. data/spec/controllers/spree/feedback_reviews_controller_spec.rb +7 -7
  29. data/spec/controllers/spree/products_controller_spec.rb +1 -1
  30. data/spec/controllers/spree/reviews_controller_spec.rb +6 -7
  31. data/spec/features/admin_spec.rb +6 -6
  32. data/spec/features/reviews_spec.rb +32 -31
  33. data/spec/models/feedback_review_spec.rb +13 -13
  34. data/spec/models/product_spec.rb +13 -10
  35. data/spec/models/review_spec.rb +36 -40
  36. data/spec/models/reviews_ability_spec.rb +14 -14
  37. data/spec/models/reviews_configuration_spec.rb +9 -10
  38. data/spec/spec_helper.rb +4 -19
  39. data/spec/support/config.rb +7 -0
  40. data/spec/support/factories.rb +3 -0
  41. metadata +18 -180
  42. data/CONTRIBUTING.md +0 -28
@@ -3,50 +3,49 @@
3
3
  require 'spec_helper'
4
4
 
5
5
  describe Spree::ReviewsConfiguration do
6
- subject { Spree::ReviewsConfiguration.new }
6
+ subject { described_class.new }
7
7
 
8
8
  before do
9
- reset_spree_preferences
10
- subject.preference_store = subject.default_preferences
9
+ subject.reset
11
10
  end
12
11
 
13
- it 'should have the include_unapproved_reviews preference' do
12
+ it 'has the include_unapproved_reviews preference' do
14
13
  expect(subject).to respond_to(:preferred_include_unapproved_reviews)
15
14
  expect(subject).to respond_to(:preferred_include_unapproved_reviews=)
16
15
  expect(subject.preferred_include_unapproved_reviews).to be false
17
16
  end
18
17
 
19
- it 'should have the preview_size preference' do
18
+ it 'has the preview_size preference' do
20
19
  expect(subject).to respond_to(:preferred_preview_size)
21
20
  expect(subject).to respond_to(:preferred_preview_size=)
22
21
  expect(subject.preferred_preview_size).to eq(3)
23
22
  end
24
23
 
25
- it 'should have the show_email preference' do
24
+ it 'has the show_email preference' do
26
25
  expect(subject).to respond_to(:preferred_show_email)
27
26
  expect(subject).to respond_to(:preferred_show_email=)
28
27
  expect(subject.preferred_show_email).to be false
29
28
  end
30
29
 
31
- it 'should have the show_verified_purchaser preference' do
30
+ it 'has the show_verified_purchaser preference' do
32
31
  expect(subject).to respond_to(:preferred_show_verified_purchaser)
33
32
  expect(subject).to respond_to(:preferred_show_verified_purchaser=)
34
33
  expect(subject.preferred_show_verified_purchaser).to be false
35
34
  end
36
35
 
37
- it 'should have the feedback_rating preference' do
36
+ it 'has the feedback_rating preference' do
38
37
  expect(subject).to respond_to(:preferred_feedback_rating)
39
38
  expect(subject).to respond_to(:preferred_feedback_rating=)
40
39
  expect(subject.preferred_feedback_rating).to be false
41
40
  end
42
41
 
43
- it 'should have the require_login preference' do
42
+ it 'has the require_login preference' do
44
43
  expect(subject).to respond_to(:preferred_require_login)
45
44
  expect(subject).to respond_to(:preferred_require_login=)
46
45
  expect(subject.preferred_require_login).to be true
47
46
  end
48
47
 
49
- it 'should have the track_locale preference' do
48
+ it 'has the track_locale preference' do
50
49
  expect(subject).to respond_to(:preferred_track_locale)
51
50
  expect(subject).to respond_to(:preferred_track_locale=)
52
51
  expect(subject.preferred_track_locale).to be false
data/spec/spec_helper.rb CHANGED
@@ -1,26 +1,11 @@
1
1
  # frozen_string_literal: true
2
2
 
3
- require "simplecov"
4
- SimpleCov.start "rails"
3
+ ENV['RAILS_ENV'] ||= 'test'
5
4
 
6
- ENV["RAILS_ENV"] ||= "test"
5
+ require 'solidus_extension_dev_tools/rspec/coverage'
7
6
 
8
7
  require File.expand_path('dummy/config/environment.rb', __dir__)
9
8
 
10
- require "solidus_support/extension/feature_helper"
11
- require 'spree/testing_support/controller_requests'
12
- require 'spree/testing_support/capybara_ext'
9
+ require 'solidus_extension_dev_tools/rspec/feature_helper'
13
10
 
14
- Dir[File.join(File.dirname(__FILE__), "support/**/*.rb")].each { |f| require f }
15
-
16
- require 'solidus_reviews/factories'
17
-
18
- RSpec.configure do |config|
19
- config.infer_spec_type_from_file_location!
20
- config.raise_errors_for_deprecations!
21
-
22
- config.example_status_persistence_file_path = "./spec/examples.txt"
23
-
24
- config.include Spree::TestingSupport::UrlHelpers
25
- config.include Spree::TestingSupport::ControllerRequests, type: :controller
26
- end
11
+ Dir[File.join(File.dirname(__FILE__), 'support/**/*.rb')].each { |f| require f }
@@ -0,0 +1,7 @@
1
+ # frozen_string_literal: true
2
+
3
+ RSpec.configure do |config|
4
+ config.before do
5
+ Spree::Reviews::Config.reset
6
+ end
7
+ end
@@ -0,0 +1,3 @@
1
+ # frozen_string_literal: true
2
+
3
+ require 'solidus_reviews/factories'
metadata CHANGED
@@ -1,14 +1,14 @@
1
1
  --- !ruby/object:Gem::Specification
2
2
  name: solidus_reviews
3
3
  version: !ruby/object:Gem::Version
4
- version: 1.2.0
4
+ version: 1.3.0
5
5
  platform: ruby
6
6
  authors:
7
7
  - Solidus Contrib
8
8
  autorequire:
9
9
  bindir: bin
10
10
  cert_chain: []
11
- date: 2019-09-17 00:00:00.000000000 Z
11
+ date: 2019-11-27 00:00:00.000000000 Z
12
12
  dependencies:
13
13
  - !ruby/object:Gem::Dependency
14
14
  name: deface
@@ -16,14 +16,14 @@ dependencies:
16
16
  requirements:
17
17
  - - "~>"
18
18
  - !ruby/object:Gem::Version
19
- version: '1'
19
+ version: '1.0'
20
20
  type: :runtime
21
21
  prerelease: false
22
22
  version_requirements: !ruby/object:Gem::Requirement
23
23
  requirements:
24
24
  - - "~>"
25
25
  - !ruby/object:Gem::Version
26
- version: '1'
26
+ version: '1.0'
27
27
  - !ruby/object:Gem::Dependency
28
28
  name: solidus
29
29
  requirement: !ruby/object:Gem::Requirement
@@ -46,180 +46,12 @@ dependencies:
46
46
  version: '3'
47
47
  - !ruby/object:Gem::Dependency
48
48
  name: solidus_support
49
- requirement: !ruby/object:Gem::Requirement
50
- requirements:
51
- - - "~>"
52
- - !ruby/object:Gem::Version
53
- version: '0.1'
54
- type: :runtime
55
- prerelease: false
56
- version_requirements: !ruby/object:Gem::Requirement
57
- requirements:
58
- - - "~>"
59
- - !ruby/object:Gem::Version
60
- version: '0.1'
61
- - !ruby/object:Gem::Dependency
62
- name: capybara
63
- requirement: !ruby/object:Gem::Requirement
64
- requirements:
65
- - - ">="
66
- - !ruby/object:Gem::Version
67
- version: '0'
68
- type: :development
69
- prerelease: false
70
- version_requirements: !ruby/object:Gem::Requirement
71
- requirements:
72
- - - ">="
73
- - !ruby/object:Gem::Version
74
- version: '0'
75
- - !ruby/object:Gem::Dependency
76
- name: capybara-screenshot
77
- requirement: !ruby/object:Gem::Requirement
78
- requirements:
79
- - - ">="
80
- - !ruby/object:Gem::Version
81
- version: '0'
82
- type: :development
83
- prerelease: false
84
- version_requirements: !ruby/object:Gem::Requirement
85
- requirements:
86
- - - ">="
87
- - !ruby/object:Gem::Version
88
- version: '0'
89
- - !ruby/object:Gem::Dependency
90
- name: coffee-rails
91
- requirement: !ruby/object:Gem::Requirement
92
- requirements:
93
- - - ">="
94
- - !ruby/object:Gem::Version
95
- version: '0'
96
- type: :development
97
- prerelease: false
98
- version_requirements: !ruby/object:Gem::Requirement
99
- requirements:
100
- - - ">="
101
- - !ruby/object:Gem::Version
102
- version: '0'
103
- - !ruby/object:Gem::Dependency
104
- name: database_cleaner
105
- requirement: !ruby/object:Gem::Requirement
106
- requirements:
107
- - - ">="
108
- - !ruby/object:Gem::Version
109
- version: '0'
110
- type: :development
111
- prerelease: false
112
- version_requirements: !ruby/object:Gem::Requirement
113
- requirements:
114
- - - ">="
115
- - !ruby/object:Gem::Version
116
- version: '0'
117
- - !ruby/object:Gem::Dependency
118
- name: ffaker
119
- requirement: !ruby/object:Gem::Requirement
120
- requirements:
121
- - - ">="
122
- - !ruby/object:Gem::Version
123
- version: '0'
124
- type: :development
125
- prerelease: false
126
- version_requirements: !ruby/object:Gem::Requirement
127
- requirements:
128
- - - ">="
129
- - !ruby/object:Gem::Version
130
- version: '0'
131
- - !ruby/object:Gem::Dependency
132
- name: poltergeist
133
49
  requirement: !ruby/object:Gem::Requirement
134
50
  requirements:
135
51
  - - ">="
136
52
  - !ruby/object:Gem::Version
137
53
  version: '0'
138
- type: :development
139
- prerelease: false
140
- version_requirements: !ruby/object:Gem::Requirement
141
- requirements:
142
- - - ">="
143
- - !ruby/object:Gem::Version
144
- version: '0'
145
- - !ruby/object:Gem::Dependency
146
- name: pry
147
- requirement: !ruby/object:Gem::Requirement
148
- requirements:
149
- - - ">="
150
- - !ruby/object:Gem::Version
151
- version: '0'
152
- type: :development
153
- prerelease: false
154
- version_requirements: !ruby/object:Gem::Requirement
155
- requirements:
156
- - - ">="
157
- - !ruby/object:Gem::Version
158
- version: '0'
159
- - !ruby/object:Gem::Dependency
160
- name: rspec-rails
161
- requirement: !ruby/object:Gem::Requirement
162
- requirements:
163
- - - "~>"
164
- - !ruby/object:Gem::Version
165
- version: 4.0.0.beta2
166
- type: :development
167
- prerelease: false
168
- version_requirements: !ruby/object:Gem::Requirement
169
- requirements:
170
- - - "~>"
171
- - !ruby/object:Gem::Version
172
- version: 4.0.0.beta2
173
- - !ruby/object:Gem::Dependency
174
- name: rubocop
175
- requirement: !ruby/object:Gem::Requirement
176
- requirements:
177
- - - "~>"
178
- - !ruby/object:Gem::Version
179
- version: 0.53.0
180
- type: :development
181
- prerelease: false
182
- version_requirements: !ruby/object:Gem::Requirement
183
- requirements:
184
- - - "~>"
185
- - !ruby/object:Gem::Version
186
- version: 0.53.0
187
- - !ruby/object:Gem::Dependency
188
- name: sass-rails
189
- requirement: !ruby/object:Gem::Requirement
190
- requirements:
191
- - - ">="
192
- - !ruby/object:Gem::Version
193
- version: '0'
194
- type: :development
195
- prerelease: false
196
- version_requirements: !ruby/object:Gem::Requirement
197
- requirements:
198
- - - ">="
199
- - !ruby/object:Gem::Version
200
- version: '0'
201
- - !ruby/object:Gem::Dependency
202
- name: selenium-webdriver
203
- requirement: !ruby/object:Gem::Requirement
204
- requirements:
205
- - - ">="
206
- - !ruby/object:Gem::Version
207
- version: '0'
208
- type: :development
209
- prerelease: false
210
- version_requirements: !ruby/object:Gem::Requirement
211
- requirements:
212
- - - ">="
213
- - !ruby/object:Gem::Version
214
- version: '0'
215
- - !ruby/object:Gem::Dependency
216
- name: simplecov
217
- requirement: !ruby/object:Gem::Requirement
218
- requirements:
219
- - - ">="
220
- - !ruby/object:Gem::Version
221
- version: '0'
222
- type: :development
54
+ type: :runtime
223
55
  prerelease: false
224
56
  version_requirements: !ruby/object:Gem::Requirement
225
57
  requirements:
@@ -227,7 +59,7 @@ dependencies:
227
59
  - !ruby/object:Gem::Version
228
60
  version: '0'
229
61
  - !ruby/object:Gem::Dependency
230
- name: sqlite3
62
+ name: solidus_extension_dev_tools
231
63
  requirement: !ruby/object:Gem::Requirement
232
64
  requirements:
233
65
  - - ">="
@@ -240,7 +72,7 @@ dependencies:
240
72
  - - ">="
241
73
  - !ruby/object:Gem::Version
242
74
  version: '0'
243
- description: Basic review and ratings facility for Solidus
75
+ description: Review and rating functionality for your Solidus store.
244
76
  email:
245
77
  executables: []
246
78
  extensions: []
@@ -250,7 +82,8 @@ files:
250
82
  - ".gitignore"
251
83
  - ".rspec"
252
84
  - ".rubocop.yml"
253
- - CONTRIBUTING.md
85
+ - ".rubocop_todo.yml"
86
+ - CHANGELOG.md
254
87
  - Gemfile
255
88
  - LICENSE.md
256
89
  - README.md
@@ -336,10 +169,11 @@ files:
336
169
  - lib/controllers/spree/api/reviews_controller.rb
337
170
  - lib/generators/solidus_reviews/install/install_generator.rb
338
171
  - lib/solidus_reviews.rb
172
+ - lib/solidus_reviews/engine.rb
339
173
  - lib/solidus_reviews/factories.rb
340
174
  - lib/solidus_reviews/factories/feedback_review_factory.rb
341
175
  - lib/solidus_reviews/factories/review_factory.rb
342
- - lib/spree_reviews/engine.rb
176
+ - lib/solidus_reviews/version.rb
343
177
  - solidus_reviews.gemspec
344
178
  - spec/controllers/spree/admin/feedback_reviews_controller_spec.rb
345
179
  - spec/controllers/spree/admin/review_settings_controller_spec.rb
@@ -357,8 +191,10 @@ files:
357
191
  - spec/models/reviews_ability_spec.rb
358
192
  - spec/models/reviews_configuration_spec.rb
359
193
  - spec/spec_helper.rb
194
+ - spec/support/config.rb
195
+ - spec/support/factories.rb
360
196
  - vendor/assets/javascripts/jquery.rating.js
361
- homepage: https://github.com/solidusio-contrib/solidus_reviews/
197
+ homepage: https://github.com/solidusio-contrib/solidus_reviews
362
198
  licenses:
363
199
  - BSD-3
364
200
  metadata: {}
@@ -378,10 +214,10 @@ required_rubygems_version: !ruby/object:Gem::Requirement
378
214
  version: '0'
379
215
  requirements:
380
216
  - none
381
- rubygems_version: 3.0.3
217
+ rubygems_version: 3.0.6
382
218
  signing_key:
383
219
  specification_version: 4
384
- summary: Basic review and ratings facility for Solidus
220
+ summary: Review and rating functionality for your Solidus store.
385
221
  test_files:
386
222
  - spec/controllers/spree/admin/feedback_reviews_controller_spec.rb
387
223
  - spec/controllers/spree/admin/review_settings_controller_spec.rb
@@ -399,3 +235,5 @@ test_files:
399
235
  - spec/models/reviews_ability_spec.rb
400
236
  - spec/models/reviews_configuration_spec.rb
401
237
  - spec/spec_helper.rb
238
+ - spec/support/config.rb
239
+ - spec/support/factories.rb
data/CONTRIBUTING.md DELETED
@@ -1,28 +0,0 @@
1
- # Contributing
2
-
3
- In the spirit of [free software][1], **everyone** is encouraged to help improve this project.
4
-
5
- Here are some ways *you* can contribute:
6
-
7
- - by using prerelease versions
8
- - by reporting [bugs][2]
9
- - by suggesting new features
10
- - by writing translations
11
- - by writing or editing documentation
12
- - by writing specifications
13
- - by writing code (*no patch is too small*: fix typos, add comments, clean up inconsistent whitespace)
14
- - by refactoring code
15
- - by resolving [issues][2]
16
- - by reviewing patches
17
-
18
- Starting point:
19
-
20
- - Fork the repo
21
- - Clone your repo
22
- - Run `bundle install`
23
- - Run `bundle exec rake test_app` to create the test application in `spec/test_app`
24
- - Ensure specs pass by running `bundle exec rspec spec`
25
- - Submit your pull request
26
-
27
- [1]: http://www.fsf.org/licensing/essays/free-sw.html
28
- [2]: https://github.com/spree-contrib/spree_reviews/issues