solidus_reviews 1.2.0 → 1.3.0

data/spec/models/reviews_configuration_spec.rb

@@ -3,50 +3,49 @@
 require 'spec_helper'
 
 describe Spree::ReviewsConfiguration do
-  subject { Spree::ReviewsConfiguration.new }
+  subject { described_class.new }
 
   before do
-    reset_spree_preferences
-    subject.preference_store = subject.default_preferences
+    subject.reset
   end
 
-  it 'should have the include_unapproved_reviews preference' do
+  it 'has the include_unapproved_reviews preference' do
     expect(subject).to respond_to(:preferred_include_unapproved_reviews)
     expect(subject).to respond_to(:preferred_include_unapproved_reviews=)
     expect(subject.preferred_include_unapproved_reviews).to be false
   end
 
-  it 'should have the preview_size preference' do
+  it 'has the preview_size preference' do
     expect(subject).to respond_to(:preferred_preview_size)
     expect(subject).to respond_to(:preferred_preview_size=)
     expect(subject.preferred_preview_size).to eq(3)
   end
 
-  it 'should have the show_email preference' do
+  it 'has the show_email preference' do
     expect(subject).to respond_to(:preferred_show_email)
     expect(subject).to respond_to(:preferred_show_email=)
     expect(subject.preferred_show_email).to be false
   end
 
-  it 'should have the show_verified_purchaser preference' do
+  it 'has the show_verified_purchaser preference' do
     expect(subject).to respond_to(:preferred_show_verified_purchaser)
     expect(subject).to respond_to(:preferred_show_verified_purchaser=)
     expect(subject.preferred_show_verified_purchaser).to be false
   end
 
-  it 'should have the feedback_rating preference' do
+  it 'has the feedback_rating preference' do
     expect(subject).to respond_to(:preferred_feedback_rating)
     expect(subject).to respond_to(:preferred_feedback_rating=)
     expect(subject.preferred_feedback_rating).to be false
   end
 
-  it 'should have the require_login preference' do
+  it 'has the require_login preference' do
     expect(subject).to respond_to(:preferred_require_login)
     expect(subject).to respond_to(:preferred_require_login=)
     expect(subject.preferred_require_login).to be true
   end
 
-  it 'should have the track_locale preference' do
+  it 'has the track_locale preference' do
     expect(subject).to respond_to(:preferred_track_locale)
     expect(subject).to respond_to(:preferred_track_locale=)
     expect(subject.preferred_track_locale).to be false

data/spec/spec_helper.rb

@@ -1,26 +1,11 @@
 # frozen_string_literal: true
 
-require "simplecov"
-SimpleCov.start "rails"
+ENV['RAILS_ENV'] ||= 'test'
 
-ENV["RAILS_ENV"] ||= "test"
+require 'solidus_extension_dev_tools/rspec/coverage'
 
 require File.expand_path('dummy/config/environment.rb', __dir__)
 
-require "solidus_support/extension/feature_helper"
-require 'spree/testing_support/controller_requests'
-require 'spree/testing_support/capybara_ext'
+require 'solidus_extension_dev_tools/rspec/feature_helper'
 
-Dir[File.join(File.dirname(__FILE__), "support/**/*.rb")].each { |f| require f }
-
-require 'solidus_reviews/factories'
-
-RSpec.configure do |config|
-  config.infer_spec_type_from_file_location!
-  config.raise_errors_for_deprecations!
-
-  config.example_status_persistence_file_path = "./spec/examples.txt"
-
-  config.include Spree::TestingSupport::UrlHelpers
-  config.include Spree::TestingSupport::ControllerRequests, type: :controller
-end
+Dir[File.join(File.dirname(__FILE__), 'support/**/*.rb')].each { |f| require f }

data/spec/support/config.rb

@@ -0,0 +1,7 @@
+# frozen_string_literal: true
+
+RSpec.configure do |config|
+  config.before do
+    Spree::Reviews::Config.reset
+  end
+end

data/spec/support/factories.rb

@@ -0,0 +1,3 @@
+# frozen_string_literal: true
+
+require 'solidus_reviews/factories'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: solidus_reviews
 version: !ruby/object:Gem::Version
-  version: 1.2.0
+  version: 1.3.0
 platform: ruby
 authors:
 - Solidus Contrib
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-09-17 00:00:00.000000000 Z
+date: 2019-11-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: deface
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1'
+        version: '1.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1'
+        version: '1.0'
 - !ruby/object:Gem::Dependency
   name: solidus
   requirement: !ruby/object:Gem::Requirement
@@ -46,180 +46,12 @@ dependencies:
         version: '3'
 - !ruby/object:Gem::Dependency
   name: solidus_support
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.1'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.1'
-- !ruby/object:Gem::Dependency
-  name: capybara
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: capybara-screenshot
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: coffee-rails
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: database_cleaner
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: ffaker
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: poltergeist
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: pry
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: rspec-rails
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 4.0.0.beta2
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 4.0.0.beta2
-- !ruby/object:Gem::Dependency
-  name: rubocop
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 0.53.0
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 0.53.0
-- !ruby/object:Gem::Dependency
-  name: sass-rails
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: selenium-webdriver
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: simplecov
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
+  type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
@@ -227,7 +59,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: sqlite3
+  name: solidus_extension_dev_tools
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -240,7 +72,7 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-description: Basic review and ratings facility for Solidus
+description: Review and rating functionality for your Solidus store.
 email: 
 executables: []
 extensions: []
@@ -250,7 +82,8 @@ files:
 - ".gitignore"
 - ".rspec"
 - ".rubocop.yml"
-- CONTRIBUTING.md
+- ".rubocop_todo.yml"
+- CHANGELOG.md
 - Gemfile
 - LICENSE.md
 - README.md
@@ -336,10 +169,11 @@ files:
 - lib/controllers/spree/api/reviews_controller.rb
 - lib/generators/solidus_reviews/install/install_generator.rb
 - lib/solidus_reviews.rb
+- lib/solidus_reviews/engine.rb
 - lib/solidus_reviews/factories.rb
 - lib/solidus_reviews/factories/feedback_review_factory.rb
 - lib/solidus_reviews/factories/review_factory.rb
-- lib/spree_reviews/engine.rb
+- lib/solidus_reviews/version.rb
 - solidus_reviews.gemspec
 - spec/controllers/spree/admin/feedback_reviews_controller_spec.rb
 - spec/controllers/spree/admin/review_settings_controller_spec.rb
@@ -357,8 +191,10 @@ files:
 - spec/models/reviews_ability_spec.rb
 - spec/models/reviews_configuration_spec.rb
 - spec/spec_helper.rb
+- spec/support/config.rb
+- spec/support/factories.rb
 - vendor/assets/javascripts/jquery.rating.js
-homepage: https://github.com/solidusio-contrib/solidus_reviews/
+homepage: https://github.com/solidusio-contrib/solidus_reviews
 licenses:
 - BSD-3
 metadata: {}
@@ -378,10 +214,10 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements:
 - none
-rubygems_version: 3.0.3
+rubygems_version: 3.0.6
 signing_key: 
 specification_version: 4
-summary: Basic review and ratings facility for Solidus
+summary: Review and rating functionality for your Solidus store.
 test_files:
 - spec/controllers/spree/admin/feedback_reviews_controller_spec.rb
 - spec/controllers/spree/admin/review_settings_controller_spec.rb
@@ -399,3 +235,5 @@ test_files:
 - spec/models/reviews_ability_spec.rb
 - spec/models/reviews_configuration_spec.rb
 - spec/spec_helper.rb
+- spec/support/config.rb
+- spec/support/factories.rb

data/CONTRIBUTING.md

@@ -1,28 +0,0 @@
-# Contributing
-
-In the spirit of [free software][1], **everyone** is encouraged to help improve this project.
-
-Here are some ways *you* can contribute:
-
-- by using prerelease versions
-- by reporting [bugs][2]
-- by suggesting new features
-- by writing translations
-- by writing or editing documentation
-- by writing specifications
-- by writing code (*no patch is too small*: fix typos, add comments, clean up inconsistent whitespace)
-- by refactoring code
-- by resolving [issues][2]
-- by reviewing patches
-
-Starting point:
-
-- Fork the repo
-- Clone your repo
-- Run `bundle install`
-- Run `bundle exec rake test_app` to create the test application in `spec/test_app`
-- Ensure specs pass by running `bundle exec rspec spec`
-- Submit your pull request
-
-[1]: http://www.fsf.org/licensing/essays/free-sw.html
-[2]: https://github.com/spree-contrib/spree_reviews/issues