solidus_reviews 1.3.0 → 1.4.0

data/spec/controllers/spree/api/feedback_reviews_controller_spec.rb

@@ -0,0 +1,136 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe Spree::Api::FeedbackReviewsController, type: :controller do
+  render_views
+
+  let!(:user) { create(:user) }
+  let!(:review) { create(:review) }
+  let!(:feedback_review) { create(:feedback_review, review: review) }
+
+  before do
+    user.generate_spree_api_key!
+  end
+
+  describe '#create' do
+    subject do
+      params = { review_id: review.id, token: user.spree_api_key, format: 'json' }.merge(feedback_review_params)
+      post :create, params: params
+      JSON.parse(response.body)
+    end
+
+    let(:feedback_review_params) do
+      {
+        "feedback_review": {
+          "rating": "5",
+          "comment": "I agree with what you said"
+        }
+      }
+    end
+
+    context 'when user has already left feedback on a reviewed this product' do
+      before do
+        feedback_review.update(user_id: user.id)
+      end
+
+      it 'returns with a fail' do
+        expect(subject["error"]).not_to be_empty
+        expect(subject["error"]).to match(/invalid resource/i)
+      end
+    end
+
+    context 'when it is a users first feedback for a review' do
+      it 'returns success with feedback' do
+        expect(subject).not_to be_empty
+        expect(subject["review_id"]).to eq(review.id)
+        expect(subject["rating"]).to eq(5)
+        expect(subject["comment"]).to eq("I agree with what you said")
+      end
+
+      it 'updates the review' do
+        expect(review).to receive(:touch)
+        feedback = create(:feedback_review, review: review)
+        feedback.save!
+      end
+    end
+  end
+
+  describe '#update' do
+    subject do
+      put :update, params: params
+      JSON.parse(response.body)
+    end
+
+    before { feedback_review.update(user_id: user.id) }
+
+    let(:params) { { review_id: review.id, id: feedback_review.id, token: user.spree_api_key, format: 'json' }.merge(feedback_review_params) }
+
+    let(:feedback_review_params) do
+      {
+        "feedback_review": {
+          "rating": "1",
+          "comment": "Actually I don't agree"
+        }
+      }
+    end
+
+    context 'when a user updates their own feedback for a review' do
+      it 'successfully updates their feedback' do
+        original = feedback_review
+        expect(subject["id"]).to eq(original.id)
+        expect(subject["user_id"]).to eq(original.user_id)
+        expect(subject["review_id"]).to eq(original.review_id)
+        expect(subject["rating"]).to eq(1)
+        expect(subject["comment"]).to eq("Actually I don't agree")
+      end
+    end
+
+    context 'when a user updates another users review' do
+      let(:other_user) { create(:user) }
+      let(:params) { { review_id: review.id, id: feedback_review.id, token: other_user.spree_api_key, format: 'json' }.merge(feedback_review_params) }
+
+      before do
+        other_user.generate_spree_api_key!
+      end
+
+      it 'returns an error' do
+        expect(subject["error"]).not_to be_empty
+        expect(subject["error"]).to match(/not authorized/i)
+      end
+    end
+  end
+
+  describe '#destroy' do
+    subject do
+      delete :destroy, params: params
+      JSON.parse(response.body)
+    end
+
+    before { feedback_review.update(user_id: user.id) }
+
+    let(:params) { { review_id: review.id, id: feedback_review.id, token: user.spree_api_key, format: 'json' } }
+
+    context "when a user destroys their own feedback" do
+      it 'returns the deleted feedback' do
+        expect(subject["id"]).to eq(feedback_review.id)
+        expect(subject["review_id"]).to eq(review.id)
+        expect(Spree::FeedbackReview.find_by(id: feedback_review.id)).to be_falsey
+      end
+    end
+
+    context "when a user destroys another users feedback" do
+      let(:other_user) { create(:user) }
+      let(:params) { { review_id: review.id, id: feedback_review.id, token: other_user.spree_api_key, format: 'json' } }
+
+      before do
+        other_user.generate_spree_api_key!
+      end
+
+      it 'returns an error' do
+        expect(subject["error"]).not_to be_empty
+        expect(subject["error"]).to match(/not authorized/i)
+      end
+    end
+  end
+end

data/spec/controllers/spree/reviews_controller_spec.rb

@@ -5,6 +5,7 @@ require 'spec_helper'
 describe Spree::ReviewsController, type: :controller do
   let(:user) { create(:user) }
   let(:product) { create(:product) }
+  let(:review) { create(:review, :approved, product: product, user: user) }
   let(:review_params) do
     { product_id: product.slug,
       review: { rating: 3,
@@ -67,6 +68,40 @@ describe Spree::ReviewsController, type: :controller do
     end
   end
 
+  describe '#edit' do
+
+    context 'for a product that does not exist' do
+      it 'responds with a 404' do
+        expect {
+          get :edit, params: { id: review.id, product_id: 'not_real' }
+        }.to raise_error(ActiveRecord::RecordNotFound)
+      end
+    end
+
+    it 'fail if the user is not authorized to edit a review' do
+      allow(controller).to receive(:authorize!).and_raise(RuntimeError)
+
+      expect {
+        post :edit, params: { id: review.id, product_id: product.slug }
+        assert_match 'ryanbig', response.body
+      }.to raise_error RuntimeError
+    end
+
+    it 'render the edit template' do
+      get :edit, params: { id: review.id, product_id: product.slug }
+      expect(response.status).to eq(200)
+      expect(response).to render_template(:edit)
+    end
+
+    it 'doesn\'t allow another user to update a users review' do
+      other_user = create(:user)
+      allow(controller).to receive(:spree_current_user).and_return(other_user)
+      get :edit, params: {id: review.id, product_id: product.slug }
+      expect(response).to_not render_template(:edit)
+      expect(flash[:error]).to eq "Authorization Failure"
+    end
+  end
+
   describe '#create' do
     before { allow(controller).to receive(:spree_current_user).and_return(user) }
 
@@ -159,4 +194,105 @@ describe Spree::ReviewsController, type: :controller do
       end
     end
   end
+
+  describe '#update' do
+    before {
+      allow(controller).to receive(:spree_current_user).and_return(user)
+      @review_params = { product_id: product.slug,
+        id: review.id,
+        review: { title: 'Amazing Product' } }
+    }
+
+    context 'for a product that does not exist' do
+      it 'responds with a 404' do
+        expect {
+          post :update, params: { id: review.id, product_id: 'not_real' }
+        }.to raise_error(ActiveRecord::RecordNotFound)
+      end
+    end
+
+    it 'updates a review' do
+      post :update, params: @review_params
+      
+      expect(assigns[:review].title).to eq 'Amazing Product'
+      expect(assigns[:review].product).to eq product
+      expect(assigns[:review].user).to eq user
+    end
+
+    it 'updates a review to be a rating only review' do
+      post :update, params: {
+        product_id: product.slug,
+        id: review.id,
+        review: { title: '', review: '', rating: 5 }
+      }
+
+      expect(assigns[:review].title).to eq ''
+      expect(assigns[:review].review).to eq ''
+      expect(assigns[:review].rating).to eq 5
+    end
+
+    it 'updates the attached image' do
+      post :update, params: {
+        product_id: product.slug,
+        id: review.id,
+        review: {
+          images: [
+            fixture_file_upload(File.new(Spree::Core::Engine.root + 'spec/fixtures/thinking-cat.jpg')),
+          ] }
+      }
+      expect(assigns[:review].images.count).to eq 1
+    end
+
+    it 'fails if the user is not authorized to create a review' do
+      allow(controller).to receive(:authorize!).and_raise(RuntimeError)
+
+      expect{
+        post :update, params: @review_params
+      }.to raise_error RuntimeError
+    end
+
+    it 'flashes the notice' do
+      post :update, params: @review_params
+
+      expect(flash[:notice]).to eq I18n.t('spree.review_successfully_submitted')
+    end
+
+    it 'redirects to product page' do
+      post :update, params: @review_params
+      review.reload
+      review.valid?
+      expect(response).to redirect_to spree.product_path(product)
+    end
+
+    it 'removes all non-numbers from ratings param' do
+      @review_params[:review][:rating] = 5
+      post :update, params: @review_params
+      expect(controller.params[:review][:rating]).to eq '5'
+    end
+
+    it 'doesnt change the current spree user as reviews user' do
+      post :update, params: @review_params
+      expect(assigns[:review].user_id).to eq user.id
+    end
+
+    context 'with invalid params' do
+      it 'renders edit when review.save fails' do
+        expect_any_instance_of(Spree::Review).to receive(:update).and_return(false)
+        post :update, params: @review_params
+        expect(response).to render_template :edit
+      end
+
+      it 'does not update a review' do
+        original_rating = review.rating
+        original_title = review.title
+        @review_params[:review][:rating] = 'not_a_number'
+        @review_params[:review][:title] = true
+        post :update, params: @review_params
+        
+        review.reload
+        expect(review.rating).to eq original_rating
+        expect(review.title).to eq original_title
+      end
+    end
+  end
 end

data/spec/models/review_spec.rb

@@ -219,4 +219,31 @@ describe Spree::Review do
       expect(review.verified_purchaser).to eq(false)
     end
   end
+
+  describe "#approve_review" do
+    let(:order) { create(:completed_order_with_totals) }
+    let(:product) { order.products.first }
+    let(:user) { order.user }
+    let(:review) { build(:review, title: '', review: '', user: user, product: product) }
+
+    it "auto approves star only review" do
+      stub_spree_preferences(Spree::Reviews::Config, approve_star_only: true)
+
+      expect(review.approved).to eq(false)
+      review.approve_review
+      expect(review.approved).to eq(true)
+    end
+
+    it "auto approves star only review for verified purchaser" do
+      stub_spree_preferences(Spree::Reviews::Config, approve_star_only_for_verified_purchaser: true)
+
+      expect(review.verified_purchaser).to eq(false)
+      expect(review.approved).to eq(false)
+      review.verify_purchaser
+      expect(review.verified_purchaser).to eq(true)
+      expect(review.approved).to eq(false)
+      review.approve_review
+      expect(review.approved).to eq(true)
+    end
+  end
 end

data/spec/models/reviews_configuration_spec.rb

@@ -50,4 +50,16 @@ describe Spree::ReviewsConfiguration do
     expect(subject).to respond_to(:preferred_track_locale=)
     expect(subject.preferred_track_locale).to be false
   end
+
+  it 'has the approve_star_only preference' do
+    expect(subject).to respond_to(:preferred_approve_star_only)
+    expect(subject).to respond_to(:preferred_approve_star_only=)
+    expect(subject.preferred_approve_star_only).to be false
+  end
+
+  it 'has the approve_star_only_for_verified_purchaser preference' do
+    expect(subject).to respond_to(:preferred_approve_star_only_for_verified_purchaser)
+    expect(subject).to respond_to(:preferred_approve_star_only_for_verified_purchaser=)
+    expect(subject.preferred_approve_star_only_for_verified_purchaser).to be false
+  end
 end

data/spec/spec_helper.rb

@@ -1,11 +1,24 @@
 # frozen_string_literal: true
 
-ENV['RAILS_ENV'] ||= 'test'
+# Configure Rails Environment
+ENV['RAILS_ENV'] = 'test'
 
-require 'solidus_extension_dev_tools/rspec/coverage'
+# Run Coverage report
+require 'solidus_dev_support/rspec/coverage'
 
 require File.expand_path('dummy/config/environment.rb', __dir__)
 
-require 'solidus_extension_dev_tools/rspec/feature_helper'
+# Requires factories and other useful helpers defined in spree_core.
+require 'solidus_dev_support/rspec/feature_helper'
 
+# Requires supporting ruby files with custom matchers and macros, etc,
+# in spec/support/ and its subdirectories.
 Dir[File.join(File.dirname(__FILE__), 'support/**/*.rb')].each { |f| require f }
+
+# Requires factories defined in lib/solidus_reviews/factories.rb
+require 'solidus_reviews/factories'
+
+RSpec.configure do |config|
+  config.infer_spec_type_from_file_location!
+  config.use_transactional_fixtures = false
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: solidus_reviews
 version: !ruby/object:Gem::Version
-  version: 1.3.0
+  version: 1.4.0
 platform: ruby
 authors:
 - Solidus Contrib
-autorequire: 
-bindir: bin
+autorequire:
+bindir: exe
 cert_chain: []
-date: 2019-11-27 00:00:00.000000000 Z
+date: 2020-08-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: deface
@@ -25,12 +25,12 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '1.0'
 - !ruby/object:Gem::Dependency
-  name: solidus
+  name: solidus_core
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '1.4'
+        version: 2.0.0
     - - "<"
       - !ruby/object:Gem::Version
         version: '3'
@@ -40,7 +40,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '1.4'
+        version: 2.0.0
     - - "<"
       - !ruby/object:Gem::Version
         version: '3'
@@ -48,18 +48,18 @@ dependencies:
   name: solidus_support
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.4'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.4'
 - !ruby/object:Gem::Dependency
-  name: solidus_extension_dev_tools
+  name: solidus_dev_support
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -72,20 +72,22 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-description: Review and rating functionality for your Solidus store.
-email: 
+description:
+email:
 executables: []
 extensions: []
 extra_rdoc_files: []
 files:
 - ".circleci/config.yml"
+- ".gem_release.yml"
+- ".github/stale.yml"
 - ".gitignore"
 - ".rspec"
 - ".rubocop.yml"
 - ".rubocop_todo.yml"
 - CHANGELOG.md
 - Gemfile
-- LICENSE.md
+- LICENSE
 - README.md
 - Rakefile
 - app/assets/images/store/reviews/delete.gif
@@ -99,12 +101,14 @@ files:
 - app/controllers/spree/admin/reviews_controller.rb
 - app/controllers/spree/feedback_reviews_controller.rb
 - app/controllers/spree/reviews_controller.rb
-- app/decorators/controllers/solidus_reviews/spree/admin/products_controller_decorator.rb
+- app/decorators/controllers/solidus_reviews/spree/products_controller_decorator.rb
 - app/decorators/helpers/solidus_reviews/spree/api/api_helpers_decorator.rb
 - app/decorators/models/solidus_reviews/spree/product_decorator.rb
 - app/decorators/models/solidus_reviews/spree/user_decorator.rb
 - app/helpers/spree/reviews_helper.rb
 - app/models/spree/feedback_review.rb
+- app/models/spree/permission_sets/review_display.rb
+- app/models/spree/permission_sets/review_management.rb
 - app/models/spree/review.rb
 - app/models/spree/reviews_ability.rb
 - app/models/spree/reviews_configuration.rb
@@ -125,6 +129,7 @@ files:
 - app/views/spree/feedback_reviews/create.js.erb
 - app/views/spree/reviews/_form.html.erb
 - app/views/spree/reviews/_stars.html.erb
+- app/views/spree/reviews/edit.html.erb
 - app/views/spree/reviews/index.html.erb
 - app/views/spree/reviews/new.html.erb
 - app/views/spree/shared/_rating.html.erb
@@ -132,7 +137,9 @@ files:
 - app/views/spree/shared/_review_summary.html.erb
 - app/views/spree/shared/_reviews.html.erb
 - app/views/spree/shared/_shortrating.html.erb
+- bin/console
 - bin/rails
+- bin/setup
 - config/initializers/constants.rb
 - config/initializers/load_preferences.rb
 - config/locales/de-CH.yml
@@ -166,6 +173,7 @@ files:
 - db/migrate/20190613165528_add_verified_purchaser_to_reviews.rb
 - db/sample/ratings.yml
 - db/sample/reviews.yml
+- lib/controllers/spree/api/feedback_reviews_controller.rb
 - lib/controllers/spree/api/reviews_controller.rb
 - lib/generators/solidus_reviews/install/install_generator.rb
 - lib/solidus_reviews.rb
@@ -178,9 +186,9 @@ files:
 - spec/controllers/spree/admin/feedback_reviews_controller_spec.rb
 - spec/controllers/spree/admin/review_settings_controller_spec.rb
 - spec/controllers/spree/admin/reviews_controller_spec.rb
+- spec/controllers/spree/api/feedback_reviews_controller_spec.rb
 - spec/controllers/spree/api/reviews_controller_spec.rb
 - spec/controllers/spree/feedback_reviews_controller_spec.rb
-- spec/controllers/spree/products_controller_spec.rb
 - spec/controllers/spree/reviews_controller_spec.rb
 - spec/features/admin_spec.rb
 - spec/features/reviews_spec.rb
@@ -196,44 +204,45 @@ files:
 - vendor/assets/javascripts/jquery.rating.js
 homepage: https://github.com/solidusio-contrib/solidus_reviews
 licenses:
-- BSD-3
-metadata: {}
-post_install_message: 
+- BSD-3-Clause
+metadata:
+  homepage_uri: https://github.com/solidusio-contrib/solidus_reviews
+  source_code_uri: https://github.com/solidusio-contrib/solidus_reviews
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - "~>"
     - !ruby/object:Gem::Version
-      version: 1.9.3
+      version: '2.4'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
-requirements:
-- none
-rubygems_version: 3.0.6
-signing_key: 
+requirements: []
+rubygems_version: 3.0.3
+signing_key:
 specification_version: 4
 summary: Review and rating functionality for your Solidus store.
 test_files:
-- spec/controllers/spree/admin/feedback_reviews_controller_spec.rb
+- spec/spec_helper.rb
+- spec/features/reviews_spec.rb
+- spec/features/admin_spec.rb
+- spec/models/reviews_configuration_spec.rb
+- spec/models/review_spec.rb
+- spec/models/reviews_ability_spec.rb
+- spec/models/product_spec.rb
+- spec/models/feedback_review_spec.rb
+- spec/support/factories.rb
+- spec/support/config.rb
 - spec/controllers/spree/admin/review_settings_controller_spec.rb
 - spec/controllers/spree/admin/reviews_controller_spec.rb
+- spec/controllers/spree/admin/feedback_reviews_controller_spec.rb
 - spec/controllers/spree/api/reviews_controller_spec.rb
-- spec/controllers/spree/feedback_reviews_controller_spec.rb
-- spec/controllers/spree/products_controller_spec.rb
+- spec/controllers/spree/api/feedback_reviews_controller_spec.rb
 - spec/controllers/spree/reviews_controller_spec.rb
-- spec/features/admin_spec.rb
-- spec/features/reviews_spec.rb
+- spec/controllers/spree/feedback_reviews_controller_spec.rb
 - spec/helpers/review_helper_spec.rb
-- spec/models/feedback_review_spec.rb
-- spec/models/product_spec.rb
-- spec/models/review_spec.rb
-- spec/models/reviews_ability_spec.rb
-- spec/models/reviews_configuration_spec.rb
-- spec/spec_helper.rb
-- spec/support/config.rb
-- spec/support/factories.rb