solidus_reviews 1.2.0 → 1.5.0

data/spec/models/review_spec.rb

@@ -18,36 +18,36 @@ describe Spree::Review do
 
     context 'rating' do
       it 'does not validate when no rating is specified' do
-        expect(build(:review, rating: nil)).to_not be_valid
+        expect(build(:review, rating: nil)).not_to be_valid
       end
 
       it 'does not validate when the rating is not a number' do
-        expect(build(:review, rating: 'not_a_number')).to_not be_valid
+        expect(build(:review, rating: 'not_a_number')).not_to be_valid
       end
 
       it 'does not validate when the rating is a float' do
-        expect(build(:review, rating: 2.718)).to_not be_valid
+        expect(build(:review, rating: 2.718)).not_to be_valid
       end
 
       it 'does not validate when the rating is less than 1' do
-        expect(build(:review, rating: 0)).to_not be_valid
-        expect(build(:review, rating: -5)).to_not be_valid
+        expect(build(:review, rating: 0)).not_to be_valid
+        expect(build(:review, rating: -5)).not_to be_valid
       end
 
       it 'does not validate when the rating is greater than 5' do
-        expect(build(:review, rating: 6)).to_not be_valid
-        expect(build(:review, rating: 8)).to_not be_valid
+        expect(build(:review, rating: 6)).not_to be_valid
+        expect(build(:review, rating: 8)).not_to be_valid
       end
 
       (1..5).each do |i|
-        it 'validates when the rating is #{i}' do
+        it "validates when the rating is #{i}" do
           expect(build(:review, rating: i)).to be_valid
         end
       end
     end
 
     context 'review body' do
-      it 'should be valid without a body' do
+      it 'is valid without a body' do
         expect(build(:review, review: nil)).to be_valid
       end
     end
@@ -60,11 +60,11 @@ describe Spree::Review do
       let!(:review_3) { create(:review, created_at: 5.days.ago) }
 
       it 'properly runs most_recent_first queries' do
-        expect(Spree::Review.most_recent_first.to_a).to eq([review_2, review_3, review_1])
+        expect(described_class.most_recent_first.to_a).to eq([review_2, review_3, review_1])
       end
 
       it 'defaults to most_recent_first queries' do
-        expect(Spree::Review.all.to_a).to eq([review_2, review_3, review_1])
+        expect(described_class.all.to_a).to eq([review_2, review_3, review_1])
       end
     end
 
@@ -72,19 +72,14 @@ describe Spree::Review do
       let!(:review_1) { create(:review, created_at: 10.days.ago) }
       let!(:review_2) { create(:review, created_at: 2.days.ago) }
       let!(:review_3) { create(:review, created_at: 5.days.ago) }
-      let!(:review_4) { create(:review, created_at: 1.days.ago) }
-
-      before do
-        reset_spree_preferences
-        Spree::Reviews::Config.preference_store = Spree::Reviews::Config.default_preferences
-      end
+      let!(:review_4) { create(:review, created_at: 1.day.ago) }
 
       it 'properly runs oldest_first queries' do
-        expect(Spree::Review.oldest_first.to_a).to eq([review_1, review_3, review_2, review_4])
+        expect(described_class.oldest_first.to_a).to eq([review_1, review_3, review_2, review_4])
       end
 
       it 'uses oldest_first for preview' do
-        expect(Spree::Review.preview.to_a).to eq([review_1, review_3, review_2])
+        expect(described_class.preview.to_a).to eq([review_1, review_3, review_2])
       end
     end
 
@@ -97,9 +92,9 @@ describe Spree::Review do
       let!(:fr_review_1) { create(:review, locale: 'fr', created_at: 10.days.ago) }
 
       it 'properly runs localized queries' do
-        expect(Spree::Review.localized('en').to_a).to eq([en_review_2, en_review_3, en_review_1])
-        expect(Spree::Review.localized('es').to_a).to eq([es_review_1])
-        expect(Spree::Review.localized('fr').to_a).to eq([fr_review_1])
+        expect(described_class.localized('en').to_a).to eq([en_review_2, en_review_3, en_review_1])
+        expect(described_class.localized('es').to_a).to eq([es_review_1])
+        expect(described_class.localized('fr').to_a).to eq([fr_review_1])
       end
     end
 
@@ -109,26 +104,26 @@ describe Spree::Review do
       let!(:approved_review_3) { create(:review, approved: true, created_at: 5.days.ago) }
 
       let!(:unapproved_review_1) { create(:review, approved: false, created_at: 7.days.ago) }
-      let!(:unapproved_review_2) { create(:review, approved: false, created_at: 1.days.ago) }
+      let!(:unapproved_review_2) { create(:review, approved: false, created_at: 1.day.ago) }
 
       it 'properly runs approved and unapproved queries' do
-        expect(Spree::Review.approved.to_a).to eq([approved_review_2, approved_review_3, approved_review_1])
-        expect(Spree::Review.not_approved.to_a).to eq([unapproved_review_2, unapproved_review_1])
-
-        Spree::Reviews::Config[:include_unapproved_reviews] = true
-        expect(Spree::Review.default_approval_filter.to_a).to eq([unapproved_review_2,
-                                                                  approved_review_2,
-                                                                  approved_review_3,
-                                                                  unapproved_review_1,
-                                                                  approved_review_1])
-
-        Spree::Reviews::Config[:include_unapproved_reviews] = false
-        expect(Spree::Review.default_approval_filter.to_a).to eq([approved_review_2, approved_review_3, approved_review_1])
+        expect(described_class.approved.to_a).to eq([approved_review_2, approved_review_3, approved_review_1])
+        expect(described_class.not_approved.to_a).to eq([unapproved_review_2, unapproved_review_1])
+
+        stub_spree_preferences(Spree::Reviews::Config, include_unapproved_reviews: true)
+        expect(described_class.default_approval_filter.to_a).to eq([unapproved_review_2,
+                                                                    approved_review_2,
+                                                                    approved_review_3,
+                                                                    unapproved_review_1,
+                                                                    approved_review_1])
+
+        stub_spree_preferences(Spree::Reviews::Config, include_unapproved_reviews: false)
+        expect(described_class.default_approval_filter.to_a).to eq([approved_review_2, approved_review_3, approved_review_1])
       end
     end
   end
 
-  context '#recalculate_product_rating' do
+  describe '#recalculate_product_rating' do
     let(:product) { create(:product) }
     let!(:review) { create(:review, product: product) }
 
@@ -141,7 +136,7 @@ describe Spree::Review do
     end
 
     it 'if not approved' do
-      expect(review).to_not receive(:recalculate_product_rating)
+      expect(review).not_to receive(:recalculate_product_rating)
       review.save!
     end
 
@@ -152,8 +147,9 @@ describe Spree::Review do
     end
   end
 
-  context '#feedback_stars' do
+  describe '#feedback_stars' do
     let!(:review) { create(:review) }
+
     before do
       3.times do |i|
         f = Spree::FeedbackReview.new
@@ -163,12 +159,12 @@ describe Spree::Review do
       end
     end
 
-    it 'should return the average rating from feedback reviews' do
+    it 'returns the average rating from feedback reviews' do
       expect(review.feedback_stars).to eq 2
     end
   end
 
-  context '#email' do
+  describe '#email' do
     it 'returns email from user' do
       user = build(:user, email: 'john@smith.com')
       review = build(:review, user: user)
@@ -191,7 +187,7 @@ describe Spree::Review do
     end
   end
 
-  context "#verify_purchaser" do
+  describe "#verify_purchaser" do
     let(:order) { create(:completed_order_with_totals) }
     let(:product) { order.products.first }
     let(:user) { order.user }
@@ -223,4 +219,31 @@ describe Spree::Review do
       expect(review.verified_purchaser).to eq(false)
     end
   end
+
+  describe "#approve_review" do
+    let(:order) { create(:completed_order_with_totals) }
+    let(:product) { order.products.first }
+    let(:user) { order.user }
+    let(:review) { build(:review, title: '', review: '', user: user, product: product) }
+
+    it "auto approves star only review" do
+      stub_spree_preferences(Spree::Reviews::Config, approve_star_only: true)
+
+      expect(review.approved).to eq(false)
+      review.approve_review
+      expect(review.approved).to eq(true)
+    end
+
+    it "auto approves star only review for verified purchaser" do
+      stub_spree_preferences(Spree::Reviews::Config, approve_star_only_for_verified_purchaser: true)
+
+      expect(review.verified_purchaser).to eq(false)
+      expect(review.approved).to eq(false)
+      review.verify_purchaser
+      expect(review.verified_purchaser).to eq(true)
+      expect(review.approved).to eq(false)
+      review.approve_review
+      expect(review.approved).to eq(true)
+    end
+  end
 end

data/spec/models/reviews_ability_spec.rb

@@ -5,12 +5,12 @@ require 'spec_helper'
 require "cancan/matchers"
 
 describe Spree::ReviewsAbility do
-  context '.allow_anonymous_reviews?' do
-    it 'should depend on Spree::Reviews::Config[:require_login]' do
-      Spree::Reviews::Config[:require_login] = false
-      expect(Spree::ReviewsAbility.allow_anonymous_reviews?).to be true
-      Spree::Reviews::Config[:require_login] = true
-      expect(Spree::ReviewsAbility.allow_anonymous_reviews?).to be false
+  describe '.allow_anonymous_reviews?' do
+    it 'depends on Spree::Reviews::Config[:require_login]' do
+      stub_spree_preferences(Spree::Reviews::Config, require_login: false)
+      expect(described_class.allow_anonymous_reviews?).to be true
+      stub_spree_preferences(Spree::Reviews::Config, require_login: true)
+      expect(described_class.allow_anonymous_reviews?).to be false
     end
   end
 
@@ -20,28 +20,28 @@ describe Spree::ReviewsAbility do
 
     context 'when anonymous reviews are allowed' do
       before do
-        Spree::Reviews::Config[:require_login] = false
+        stub_spree_preferences(Spree::Reviews::Config, require_login: false)
       end
 
       it 'lets anyone create a review or feedback review' do
         [user_without_email, user_with_email].each do |u|
-          expect(Spree::ReviewsAbility.new(u)).to be_able_to(:create, Spree::Review.new)
-          expect(Spree::ReviewsAbility.new(u)).to be_able_to(:create, Spree::FeedbackReview.new)
+          expect(described_class.new(u)).to be_able_to(:create, Spree::Review.new)
+          expect(described_class.new(u)).to be_able_to(:create, Spree::FeedbackReview.new)
         end
       end
     end
 
     context 'when anonymous reviews are not allowed' do
       before do
-        Spree::Reviews::Config[:require_login] = true
+        stub_spree_preferences(Spree::Reviews::Config, require_login: true)
       end
 
       it 'only allows users with an email to create a review or feedback review' do
-        expect(Spree::ReviewsAbility.new(user_without_email)).to_not be_able_to(:create, Spree::Review.new)
-        expect(Spree::ReviewsAbility.new(user_without_email)).to_not be_able_to(:create, Spree::FeedbackReview.new)
+        expect(described_class.new(user_without_email)).not_to be_able_to(:create, Spree::Review.new)
+        expect(described_class.new(user_without_email)).not_to be_able_to(:create, Spree::FeedbackReview.new)
 
-        expect(Spree::ReviewsAbility.new(user_with_email)).to be_able_to(:create, Spree::Review.new)
-        expect(Spree::ReviewsAbility.new(user_with_email)).to be_able_to(:create, Spree::FeedbackReview.new)
+        expect(described_class.new(user_with_email)).to be_able_to(:create, Spree::Review.new)
+        expect(described_class.new(user_with_email)).to be_able_to(:create, Spree::FeedbackReview.new)
       end
     end
   end

data/spec/models/reviews_configuration_spec.rb

@@ -3,52 +3,63 @@
 require 'spec_helper'
 
 describe Spree::ReviewsConfiguration do
-  subject { Spree::ReviewsConfiguration.new }
+  subject { described_class.new }
 
   before do
-    reset_spree_preferences
-    subject.preference_store = subject.default_preferences
+    subject.reset
   end
 
-  it 'should have the include_unapproved_reviews preference' do
+  it 'has the include_unapproved_reviews preference' do
     expect(subject).to respond_to(:preferred_include_unapproved_reviews)
     expect(subject).to respond_to(:preferred_include_unapproved_reviews=)
     expect(subject.preferred_include_unapproved_reviews).to be false
   end
 
-  it 'should have the preview_size preference' do
+  it 'has the preview_size preference' do
     expect(subject).to respond_to(:preferred_preview_size)
     expect(subject).to respond_to(:preferred_preview_size=)
     expect(subject.preferred_preview_size).to eq(3)
   end
 
-  it 'should have the show_email preference' do
+  it 'has the show_email preference' do
     expect(subject).to respond_to(:preferred_show_email)
     expect(subject).to respond_to(:preferred_show_email=)
     expect(subject.preferred_show_email).to be false
   end
 
-  it 'should have the show_verified_purchaser preference' do
+  it 'has the show_verified_purchaser preference' do
     expect(subject).to respond_to(:preferred_show_verified_purchaser)
     expect(subject).to respond_to(:preferred_show_verified_purchaser=)
     expect(subject.preferred_show_verified_purchaser).to be false
   end
 
-  it 'should have the feedback_rating preference' do
+  it 'has the feedback_rating preference' do
     expect(subject).to respond_to(:preferred_feedback_rating)
     expect(subject).to respond_to(:preferred_feedback_rating=)
     expect(subject.preferred_feedback_rating).to be false
   end
 
-  it 'should have the require_login preference' do
+  it 'has the require_login preference' do
     expect(subject).to respond_to(:preferred_require_login)
     expect(subject).to respond_to(:preferred_require_login=)
     expect(subject.preferred_require_login).to be true
   end
 
-  it 'should have the track_locale preference' do
+  it 'has the track_locale preference' do
     expect(subject).to respond_to(:preferred_track_locale)
     expect(subject).to respond_to(:preferred_track_locale=)
     expect(subject.preferred_track_locale).to be false
   end
+
+  it 'has the approve_star_only preference' do
+    expect(subject).to respond_to(:preferred_approve_star_only)
+    expect(subject).to respond_to(:preferred_approve_star_only=)
+    expect(subject.preferred_approve_star_only).to be false
+  end
+
+  it 'has the approve_star_only_for_verified_purchaser preference' do
+    expect(subject).to respond_to(:preferred_approve_star_only_for_verified_purchaser)
+    expect(subject).to respond_to(:preferred_approve_star_only_for_verified_purchaser=)
+    expect(subject.preferred_approve_star_only_for_verified_purchaser).to be false
+  end
 end

data/spec/spec_helper.rb

@@ -1,26 +1,31 @@
 # frozen_string_literal: true
 
-require "simplecov"
-SimpleCov.start "rails"
+# Configure Rails Environment
+ENV['RAILS_ENV'] = 'test'
 
-ENV["RAILS_ENV"] ||= "test"
+# Run Coverage report
+require 'solidus_dev_support/rspec/coverage'
 
-require File.expand_path('dummy/config/environment.rb', __dir__)
+# Create the dummy app if it's still missing.
+dummy_env = "#{__dir__}/dummy/config/environment.rb"
+system 'bin/rake extension:test_app' unless File.exist? dummy_env
+require dummy_env
 
-require "solidus_support/extension/feature_helper"
-require 'spree/testing_support/controller_requests'
-require 'spree/testing_support/capybara_ext'
+# Requires factories and other useful helpers defined in spree_core.
+require 'solidus_dev_support/rspec/feature_helper'
 
-Dir[File.join(File.dirname(__FILE__), "support/**/*.rb")].each { |f| require f }
+# Requires supporting ruby files with custom matchers and macros, etc,
+# in spec/support/ and its subdirectories.
+Dir["#{__dir__}/support/**/*.rb"].sort.each { |f| require f }
 
+# Requires factories defined in lib/solidus_reviews/factories.rb
 require 'solidus_reviews/factories'
 
 RSpec.configure do |config|
   config.infer_spec_type_from_file_location!
-  config.raise_errors_for_deprecations!
+  config.use_transactional_fixtures = false
 
-  config.example_status_persistence_file_path = "./spec/examples.txt"
-
-  config.include Spree::TestingSupport::UrlHelpers
-  config.include Spree::TestingSupport::ControllerRequests, type: :controller
+  if Spree.solidus_gem_version < Gem::Version.new('2.11')
+    config.extend Spree::TestingSupport::AuthorizationHelpers::Request, type: :system
+  end
 end

data/spec/support/config.rb

@@ -0,0 +1,7 @@
+# frozen_string_literal: true
+
+RSpec.configure do |config|
+  config.before do
+    Spree::Reviews::Config.reset
+  end
+end

data/spec/support/factories.rb

@@ -0,0 +1,3 @@
+# frozen_string_literal: true
+
+require 'solidus_reviews/factories'