solidus_product_feed 1.0.0 → 1.1.0

data/lib/solidus_product_feed/factories.rb

@@ -0,0 +1,4 @@
+# frozen_string_literal: true
+
+FactoryBot.define do
+end

data/lib/solidus_product_feed/version.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module SolidusProductFeed
-  VERSION = '1.0.0'
+  VERSION = '1.1.0'
 end

data/lib/spree_product_feed.rb

@@ -1 +1,3 @@
+# frozen_string_literal: true
+
 require 'solidus_product_feed/version'

data/solidus_product_feed.gemspec

@@ -1,31 +1,37 @@
-# encoding: UTF-8
-lib = File.expand_path('../lib/', __FILE__)
-$:.unshift lib unless $:.include?(lib)
-
-require 'solidus_product_feed/version'
-
-Gem::Specification.new do |s|
-  s.platform    = Gem::Platform::RUBY
-  s.name        = 'solidus_product_feed'
-  s.version     = SolidusProductFeed::VERSION
-  s.summary     = 'Spree extension that provides an RSS feed for products'
-  s.description = 'A Spree extension that provides an RSS feed for products, with Google Shopper extensions'
-  s.required_ruby_version = '>= 1.8.7'
-
-  s.author            = 'Joshua Nussbaum'
-  s.email             = 'joshnuss@gmail.com'
-
-  s.files         = `git ls-files`.split("\n")
-  s.test_files    = `git ls-files -- {test,spec,features}/*`.split("\n")
-  s.require_path = 'lib'
-  s.requirements << 'none'
-
-  s.add_runtime_dependency 'solidus_backend', [">= 1.0", "< 3"]
-
-  s.add_development_dependency 'rspec-rails', '~> 3.4'
-  s.add_development_dependency 'rubocop', '~> 0.39.0'
-  s.add_development_dependency 'factory_girl_rails'
-  s.add_development_dependency 'pry'
-  s.add_development_dependency 'faker'
-  s.add_development_dependency 'sqlite3'
+# frozen_string_literal: true
+
+require_relative 'lib/solidus_product_feed/version'
+
+Gem::Specification.new do |spec|
+  spec.name = 'solidus_product_feed'
+  spec.version = SolidusProductFeed::VERSION
+  spec.authors = ['Joshua Nussbaum']
+  spec.email = 'joshnuss@gmail.com'
+
+  spec.summary = 'Solidus extension that provides an RSS feed for products.'
+  spec.description = 'A Solidus extension that provides an RSS feed for products, with support for Google Merchant Feed.'
+  spec.homepage = 'https://github.com/solidusio-contrib/solidus_product_feed'
+  spec.license = 'BSD-3-Clause'
+
+  spec.metadata['homepage_uri'] = spec.homepage
+  spec.metadata['source_code_uri'] = 'https://github.com/solidusio-contrib/solidus_product_feed'
+  spec.metadata['changelog_uri'] = 'https://github.com/solidusio-contrib/solidus_product_feed/blob/master/CHANGELOG.md'
+
+  spec.required_ruby_version = Gem::Requirement.new('~> 2.5')
+
+  # Specify which files should be added to the gem when it is released.
+  # The `git ls-files -z` loads the files in the RubyGem that have been added into git.
+  files = Dir.chdir(__dir__) { `git ls-files -z`.split("\x0") }
+
+  spec.files = files.grep_v(%r{^(test|spec|features)/})
+  spec.test_files = files.grep(%r{^(test|spec|features)/})
+  spec.bindir = "exe"
+  spec.executables = files.grep(%r{^exe/}) { |f| File.basename(f) }
+  spec.require_paths = ["lib"]
+
+  spec.add_dependency 'deface'
+  spec.add_dependency 'solidus_core', ['>= 2.0.0', '< 3']
+  spec.add_dependency 'solidus_support', '~> 0.5'
+
+  spec.add_development_dependency 'solidus_dev_support'
 end

data/spec/controllers/products_controller_spec.rb

@@ -1,10 +1,12 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Spree::ProductsController, type: :controller do
   render_views
 
   context "GET #index" do
-    subject { spree_get :index, format: 'rss' }
+    subject { get :index, params: { format: 'rss' } }
 
     let!(:product) { create :product, name: "2 Hams", price: 20.00 }
 
@@ -14,7 +16,17 @@ describe Spree::ProductsController, type: :controller do
 
     it 'returns the correct content type' do
       subject
-      expect(response.content_type).to eq 'application/rss+xml'
+      expect(response.content_type.split(';').first).to eq 'application/rss+xml'
+    end
+  end
+
+  context 'GET #index with weirdo formats' do
+    subject { get :index, params: { format: 'wat' } }
+
+    let!(:product) { create :product, name: "2 Hams", price: 20.00 }
+
+    it "raises ActionController::UnkownFormat" do
+      expect { subject }.to raise_exception(ActionController::UnknownFormat)
     end
   end
 end

data/spec/models/spree/feed_product_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
 RSpec.describe Spree::FeedProduct do
@@ -18,23 +20,28 @@ RSpec.describe Spree::FeedProduct do
 
   describe "#category" do
     subject { feed_product.category }
+
     it { is_expected.to be_nil }
   end
 
   describe "#condition" do
     subject { feed_product.condition }
+
     it { is_expected.to eq "new" }
   end
 
   describe "#price" do
     subject { feed_product.price }
-    it { is_expected.to eq Spree::Money.new(19.99, currency: 'USD') }
+
+    it { is_expected.to eq '19.99 USD' }
   end
 
   describe "#image_link" do
     subject { feed_product.image_link }
+
     context "when the product has images" do
       before { Spree::Image.create! viewable: product.master, attachment_file_name: 'hams.png' }
+
       it { is_expected.to eq '/spree/products/1/large/hams.png' }
     end
 
@@ -45,11 +52,13 @@ RSpec.describe Spree::FeedProduct do
 
   describe "#description" do
     subject { feed_product.description }
+
     it { is_expected.to eq "As seen on TV!" }
   end
 
   describe "#title" do
     subject { feed_product.title }
+
     it { is_expected.to eq "2 Hams 20 Dollars" }
   end
 end

data/spec/spec_helper.rb

@@ -1,17 +1,27 @@
+# frozen_string_literal: true
+
 # Configure Rails Environment
-ENV["RAILS_ENV"] = "test"
-require File.expand_path("../dummy/config/environment.rb", __FILE__)
-require 'rspec/rails'
-require 'factory_girl_rails'
-require 'pry'
-require 'faker' # Required for factories.
-require 'spree/testing_support/factories'
-require 'spree/testing_support/controller_requests'
+ENV['RAILS_ENV'] = 'test'
+
+# Run Coverage report
+require 'solidus_dev_support/rspec/coverage'
+
+require File.expand_path('dummy/config/environment.rb', __dir__).tap { |file|
+  # Create the dummy app if it's still missing.
+  system 'bin/rake extension:test_app' unless File.exist? file
+}
+
+# Requires factories and other useful helpers defined in spree_core.
+require 'solidus_dev_support/rspec/feature_helper'
+
+# Requires supporting ruby files with custom matchers and macros, etc,
+# in spec/support/ and its subdirectories.
+Dir[File.join(File.dirname(__FILE__), 'support/**/*.rb')].each { |f| require f }
+
+# Requires factories defined in lib/solidus_product_feed/factories.rb
+require 'solidus_product_feed/factories'
 
 RSpec.configure do |config|
-  config.mock_with :rspec
-  config.use_transactional_fixtures = true
-  config.include Devise::TestHelpers, type: :controller
-  config.include Spree::TestingSupport::ControllerRequests, type: :controller
-  config.include FactoryGirl::Syntax::Methods
+  config.infer_spec_type_from_file_location!
+  config.use_transactional_fixtures = false
 end

data/spec/support/devise.rb

@@ -0,0 +1,5 @@
+# frozen_string_literal: true
+
+RSpec.configure do |config|
+  config.include Devise::Test::ControllerHelpers, type: :controller
+end

metadata

@@ -1,71 +1,23 @@
 --- !ruby/object:Gem::Specification
 name: solidus_product_feed
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.1.0
 platform: ruby
 authors:
 - Joshua Nussbaum
 autorequire: 
-bindir: bin
+bindir: exe
 cert_chain: []
-date: 2016-09-22 00:00:00.000000000 Z
+date: 2020-05-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: solidus_backend
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '1.0'
-    - - "<"
-      - !ruby/object:Gem::Version
-        version: '3'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '1.0'
-    - - "<"
-      - !ruby/object:Gem::Version
-        version: '3'
-- !ruby/object:Gem::Dependency
-  name: rspec-rails
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.4'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.4'
-- !ruby/object:Gem::Dependency
-  name: rubocop
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 0.39.0
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 0.39.0
-- !ruby/object:Gem::Dependency
-  name: factory_girl_rails
+  name: deface
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-  type: :development
+  type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
@@ -73,35 +25,41 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: pry
+  name: solidus_core
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
+        version: 2.0.0
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '3'
+  type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 2.0.0
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '3'
 - !ruby/object:Gem::Dependency
-  name: faker
+  name: solidus_support
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
+        version: '0.5'
+  type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.5'
 - !ruby/object:Gem::Dependency
-  name: sqlite3
+  name: solidus_dev_support
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -114,74 +72,77 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-description: A Spree extension that provides an RSS feed for products, with Google
-  Shopper extensions
+description: A Solidus extension that provides an RSS feed for products, with support
+  for Google Merchant Feed.
 email: joshnuss@gmail.com
 executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".circleci/config.yml"
+- ".gem_release.yml"
+- ".github/stale.yml"
 - ".gitignore"
 - ".rspec"
 - ".rubocop.yml"
-- ".travis.yml"
+- ".rubocop_todo.yml"
+- CHANGELOG.md
 - Gemfile
-- Guardfile
 - LICENSE
 - README.md
 - Rakefile
-- app/assets/javascripts/admin/solidus_product_feed.js
-- app/assets/javascripts/spree/backend/solidus_product_feed.js
-- app/assets/javascripts/spree/backend/spree_product_feed.js
-- app/assets/javascripts/spree/frontend/solidus_product_feed.js
-- app/assets/javascripts/spree/frontend/spree_product_feed.js
-- app/assets/javascripts/store/solidus_product_feed.js
-- app/assets/stylesheets/admin/solidus_product_feed.css
-- app/assets/stylesheets/spree/backend/solidus_product_feed.css
-- app/assets/stylesheets/spree/backend/spree_product_feed.css
-- app/assets/stylesheets/spree/frontend/solidus_product_feed.css
-- app/assets/stylesheets/spree/frontend/spree_product_feed.css
-- app/assets/stylesheets/store/solidus_product_feed.css
-- app/controllers/spree/products_controller_decorator.rb
+- app/decorators/controllers/solidus_product_feed/spree/products_controller_decorator.rb
 - app/models/spree/feed_product.rb
 - app/overrides/rss_link.rb
 - app/views/spree/products/index.rss.builder
+- bin/console
+- bin/r
+- bin/rails
+- bin/rake
+- bin/sandbox
+- bin/sandbox_rails
+- bin/setup
+- config/locales/en.yml
 - config/routes.rb
 - lib/generators/solidus_product_feed/install/install_generator.rb
 - lib/solidus_product_feed.rb
 - lib/solidus_product_feed/engine.rb
+- lib/solidus_product_feed/factories.rb
 - lib/solidus_product_feed/version.rb
 - lib/spree_product_feed.rb
-- script/rails
 - solidus_product_feed.gemspec
 - spec/controllers/products_controller_spec.rb
 - spec/models/spree/feed_product_spec.rb
 - spec/spec_helper.rb
-homepage: 
-licenses: []
-metadata: {}
+- spec/support/devise.rb
+homepage: https://github.com/solidusio-contrib/solidus_product_feed
+licenses:
+- BSD-3-Clause
+metadata:
+  homepage_uri: https://github.com/solidusio-contrib/solidus_product_feed
+  source_code_uri: https://github.com/solidusio-contrib/solidus_product_feed
+  changelog_uri: https://github.com/solidusio-contrib/solidus_product_feed/blob/master/CHANGELOG.md
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - "~>"
     - !ruby/object:Gem::Version
-      version: 1.8.7
+      version: '2.5'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
-requirements:
-- none
-rubyforge_project: 
-rubygems_version: 2.5.1
+requirements: []
+rubygems_version: 3.0.8
 signing_key: 
 specification_version: 4
-summary: Spree extension that provides an RSS feed for products
+summary: Solidus extension that provides an RSS feed for products.
 test_files:
 - spec/controllers/products_controller_spec.rb
 - spec/models/spree/feed_product_spec.rb
 - spec/spec_helper.rb
+- spec/support/devise.rb