solidus_paypal_braintree 1.1.0 → 1.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c26febf6421b70af375fcb3faa401ac062d11e0086df77b2a18c770beeda81ec
-  data.tar.gz: f4976b18fc728cfea2dc95ba99b63a8754610b9d0931553c4cc57b4c7590e2a5
+  metadata.gz: c020d3e16f7e113ad45cde24ae56a9df9df4eef47bc0698baf745648cd9f279b
+  data.tar.gz: 94214d4a10a14e6a894d32e859d674bb26476f8159e6b6549eb9b8c849d72f8b
 SHA512:
-  metadata.gz: 557543f455a52fbb02ad803c8ec007292cc5b045eddc63288fb5c39eb0e87ec920a7d92f83e84422b99ecf5386362ab212698756318de636c8e39c79490daf83
-  data.tar.gz: b9b1a28200855bfbfa2a03ad589f161b08993ce35525f889babb6ed3bcb9381c20b4ed1ee18d63cd097af010d28ec39c13b8d37ce0d54704a592438f5917e2e4
+  metadata.gz: 9f8f74dfa20c79a7c5b2df844260fd57887b4ccf35aa29724e605661d294ff5584eadc236c1d7a4cfc56b2cfff64913b727b9c029765600734c6874a4574fb79
+  data.tar.gz: 6876a643638762d3f6c6d8a915ea1651eea2f928f5ca3f92a59cbc0fcd81ce59d7ee6a688d9587a362bc9e0460efea6e312cd471c81f96fc7e4a797faab3c967

data/.circleci/config.yml

@@ -1,6 +1,8 @@
 version: 2.1
 
 orbs:
+  browser-tools: circleci/browser-tools@1.1
+
   # Always take the latest version of the orb, this allows us to
   # run specs against Solidus supported versions only without the need
   # to change this configuration every time a Solidus version is released
@@ -11,10 +13,12 @@ jobs:
   run-specs-with-postgres:
     executor: solidusio_extensions/postgres
     steps:
+      - browser-tools/install-browser-tools
       - solidusio_extensions/run-tests
   run-specs-with-mysql:
     executor: solidusio_extensions/mysql
     steps:
+      - browser-tools/install-browser-tools
       - solidusio_extensions/run-tests
   lint-code:
     executor: solidusio_extensions/sqlite-memory

data/.gitignore

@@ -7,6 +7,7 @@
 .project
 .sass-cache
 coverage
+Gemfile-local
 Gemfile.lock
 tmp
 nbproject

data/.rubocop.yml

@@ -3,7 +3,7 @@ require:
 
 AllCops:
   NewCops: enable
-  TargetRubyVersion: 2.5
+  TargetRubyVersion: 2.6
 
 Layout/FirstArgumentIndentation:
   EnforcedStyle: consistent

data/CHANGELOG.md

@@ -1,5 +1,46 @@
 # Changelog
 
+## [v1.1.1](https://github.com/solidusio/solidus_paypal_braintree/tree/v1.1.1) (2022-06-30)
+
+[Full Changelog](https://github.com/solidusio/solidus_paypal_braintree/compare/v1.1.0...v1.1.1)
+
+**Closed issues:**
+
+- StateMachines::InvalidTransition:  Cannot transition state via :invalidate from :checkout \(Reason\(s\): Payment method can't be blank\) [\#320](https://github.com/solidusio/solidus_paypal_braintree/issues/320)
+- Enable Venmo [\#304](https://github.com/solidusio/solidus_paypal_braintree/issues/304)
+- Make the Venmo button testable from outside US contries [\#303](https://github.com/solidusio/solidus_paypal_braintree/issues/303)
+
+**Merged pull requests:**
+
+- Make gem compatible with Rails 7 [\#321](https://github.com/solidusio/solidus_paypal_braintree/pull/321) ([gsmendoza](https://github.com/gsmendoza))
+- Rubocop -a on spec files [\#317](https://github.com/solidusio/solidus_paypal_braintree/pull/317) ([tvdeyen](https://github.com/tvdeyen))
+- Add email to Braintree customer [\#310](https://github.com/solidusio/solidus_paypal_braintree/pull/310) ([RyanofWoods](https://github.com/RyanofWoods))
+
+## [v1.1.0](https://github.com/solidusio/solidus_paypal_braintree/tree/v1.1.0) (2022-02-01)
+
+[Full Changelog](https://github.com/solidusio/solidus_paypal_braintree/compare/v1.0.0...v1.1.0)
+
+**Closed issues:**
+
+- solidus-frontend dependency still exists  [\#294](https://github.com/solidusio/solidus_paypal_braintree/issues/294)
+- Could we get a new release? [\#259](https://github.com/solidusio/solidus_paypal_braintree/issues/259)
+
+**Merged pull requests:**
+
+- Lower ActiveRecord::Migration version in add\_paypal\_funding\_source [\#314](https://github.com/solidusio/solidus_paypal_braintree/pull/314) ([mamhoff](https://github.com/mamhoff))
+- Fix rubocop warnings [\#313](https://github.com/solidusio/solidus_paypal_braintree/pull/313) ([mamhoff](https://github.com/mamhoff))
+- Add skip\_avs and skip\_cvv AVS Result Mapping [\#312](https://github.com/solidusio/solidus_paypal_braintree/pull/312) ([mamhoff](https://github.com/mamhoff))
+- Integrate Braintree Venmo [\#311](https://github.com/solidusio/solidus_paypal_braintree/pull/311) ([RyanofWoods](https://github.com/RyanofWoods))
+- Require MFA for RubyGems actions [\#306](https://github.com/solidusio/solidus_paypal_braintree/pull/306) ([RyanofWoods](https://github.com/RyanofWoods))
+- Add Venmo as a PayPal funding option for checkout [\#305](https://github.com/solidusio/solidus_paypal_braintree/pull/305) ([RyanofWoods](https://github.com/RyanofWoods))
+- Update PayPal configuration steps in README [\#300](https://github.com/solidusio/solidus_paypal_braintree/pull/300) ([RyanofWoods](https://github.com/RyanofWoods))
+- Update to Braintree 3.4.0 [\#299](https://github.com/solidusio/solidus_paypal_braintree/pull/299) ([pelargir](https://github.com/pelargir))
+- Remove remaining frontend dependencies [\#296](https://github.com/solidusio/solidus_paypal_braintree/pull/296) ([Rtwena](https://github.com/Rtwena))
+- Set sandbox mode if environment is sandbox [\#291](https://github.com/solidusio/solidus_paypal_braintree/pull/291) ([alexblackie](https://github.com/alexblackie))
+- Update to Solidus 3.0 [\#286](https://github.com/solidusio/solidus_paypal_braintree/pull/286) ([MinasMazar](https://github.com/MinasMazar))
+- Added 3ds errors in it locale [\#285](https://github.com/solidusio/solidus_paypal_braintree/pull/285) ([thomasrossetto](https://github.com/thomasrossetto))
+- Make use of data collector in JS configurable [\#238](https://github.com/solidusio/solidus_paypal_braintree/pull/238) ([mamhoff](https://github.com/mamhoff))
+
 ## [v1.0.0](https://github.com/solidusio/solidus_paypal_braintree/tree/v1.0.0) (2020-11-11)
 
 [Full Changelog](https://github.com/solidusio/solidus_paypal_braintree/compare/v0.4.0...v1.0.0)
@@ -21,7 +62,7 @@
 - On PayPal payment user shipping address gets set with uncorrect firstname and lastname values if they contain a space [\#226](https://github.com/solidusio/solidus_paypal_braintree/issues/226)
 - Default Braintree configuration on store creation overwrites custom configuration [\#224](https://github.com/solidusio/solidus_paypal_braintree/issues/224)
 - Undefined local variable or method `id' error on payment page [\#222](https://github.com/solidusio/solidus_paypal_braintree/issues/222)
-- Can't render JSON about an order as SolidusPaypalBraintree::Source doesn't have a `expiration\_month` method [\#221](https://github.com/solidusio/solidus_paypal_braintree/issues/221)
+- Can't render JSON about an order as SolidusPaypalBraintree::Source doesn't have a `expiration_month` method [\#221](https://github.com/solidusio/solidus_paypal_braintree/issues/221)
 - Paypal payment return invalid address [\#218](https://github.com/solidusio/solidus_paypal_braintree/issues/218)
 - Random Travis CI Failures [\#215](https://github.com/solidusio/solidus_paypal_braintree/issues/215)
 - Add Association for spree user to customer [\#210](https://github.com/solidusio/solidus_paypal_braintree/issues/210)
@@ -251,7 +292,35 @@
 - Default to US country code [\#32](https://github.com/solidusio/solidus_paypal_braintree/pull/32) ([adammathys](https://github.com/adammathys))
 - Allow JSON requests to transactions controller [\#31](https://github.com/solidusio/solidus_paypal_braintree/pull/31) ([luukveenis](https://github.com/luukveenis))
 - Vcr improvements [\#30](https://github.com/solidusio/solidus_paypal_braintree/pull/30) ([cbrunsdon](https://github.com/cbrunsdon))
+- Only prompt for email for not logged in users [\#29](https://github.com/solidusio/solidus_paypal_braintree/pull/29) ([luukveenis](https://github.com/luukveenis))
 - Implement API Controller to generate client tokens [\#28](https://github.com/solidusio/solidus_paypal_braintree/pull/28) ([stewart](https://github.com/stewart))
+- Conditionally load frontend code [\#27](https://github.com/solidusio/solidus_paypal_braintree/pull/27) ([adammathys](https://github.com/adammathys))
+- Show Source token in source\_view [\#26](https://github.com/solidusio/solidus_paypal_braintree/pull/26) ([stewart](https://github.com/stewart))
+- Set token on Source when creating customer profile [\#25](https://github.com/solidusio/solidus_paypal_braintree/pull/25) ([stewart](https://github.com/stewart))
+- Validate address before processing imports [\#24](https://github.com/solidusio/solidus_paypal_braintree/pull/24) ([luukveenis](https://github.com/luukveenis))
+- Add tests for gateway and source models [\#23](https://github.com/solidusio/solidus_paypal_braintree/pull/23) ([luukveenis](https://github.com/luukveenis))
+- Raise error for invalid transactions and add specs [\#22](https://github.com/solidusio/solidus_paypal_braintree/pull/22) ([luukveenis](https://github.com/luukveenis))
+- Save payment type to source [\#21](https://github.com/solidusio/solidus_paypal_braintree/pull/21) ([luukveenis](https://github.com/luukveenis))
+- Correctly parse error message for failure response [\#20](https://github.com/solidusio/solidus_paypal_braintree/pull/20) ([stewart](https://github.com/stewart))
+- Upcase country [\#19](https://github.com/solidusio/solidus_paypal_braintree/pull/19) ([cbrunsdon](https://github.com/cbrunsdon))
+- Add Source View [\#18](https://github.com/solidusio/solidus_paypal_braintree/pull/18) ([stewart](https://github.com/stewart))
+- Add actions, can\_\*? predicate methods to Source [\#17](https://github.com/solidusio/solidus_paypal_braintree/pull/17) ([stewart](https://github.com/stewart))
+- End to end transaction [\#16](https://github.com/solidusio/solidus_paypal_braintree/pull/16) ([cbrunsdon](https://github.com/cbrunsdon))
+- Correct foreign\_key creation for payment\_method reference on Source [\#15](https://github.com/solidusio/solidus_paypal_braintree/pull/15) ([stewart](https://github.com/stewart))
+- Update Gateway Configuration [\#14](https://github.com/solidusio/solidus_paypal_braintree/pull/14) ([stewart](https://github.com/stewart))
+- Use Braintree Customer ID, Payment Method ID when creating transactions [\#13](https://github.com/solidusio/solidus_paypal_braintree/pull/13) ([stewart](https://github.com/stewart))
+- Register gateway with Solidus [\#12](https://github.com/solidusio/solidus_paypal_braintree/pull/12) ([adammathys](https://github.com/adammathys))
+- Add Gateway\#cancel [\#11](https://github.com/solidusio/solidus_paypal_braintree/pull/11) ([adammathys](https://github.com/adammathys))
+- Implement Gateway\#create\_profile [\#10](https://github.com/solidusio/solidus_paypal_braintree/pull/10) ([stewart](https://github.com/stewart))
+- Add option to send extra options to Braintree [\#9](https://github.com/solidusio/solidus_paypal_braintree/pull/9) ([adammathys](https://github.com/adammathys))
+- Convert cents to dollars [\#8](https://github.com/solidusio/solidus_paypal_braintree/pull/8) ([adammathys](https://github.com/adammathys))
+- Add ability to capture authorized payments [\#7](https://github.com/solidusio/solidus_paypal_braintree/pull/7) ([adammathys](https://github.com/adammathys))
+- VCR Fixups [\#6](https://github.com/solidusio/solidus_paypal_braintree/pull/6) ([stewart](https://github.com/stewart))
+- Add support for refunding payments [\#5](https://github.com/solidusio/solidus_paypal_braintree/pull/5) ([adammathys](https://github.com/adammathys))
+- Add implementation for authorization transactions [\#4](https://github.com/solidusio/solidus_paypal_braintree/pull/4) ([stewart](https://github.com/stewart))
+- Implement voiding transactions [\#3](https://github.com/solidusio/solidus_paypal_braintree/pull/3) ([adammathys](https://github.com/adammathys))
+- Some minor clean-up [\#2](https://github.com/solidusio/solidus_paypal_braintree/pull/2) ([adammathys](https://github.com/adammathys))
+- FIx Up Test Environment [\#1](https://github.com/solidusio/solidus_paypal_braintree/pull/1) ([stewart](https://github.com/stewart))
 
 
 

data/Gemfile

@@ -4,12 +4,15 @@ source 'https://rubygems.org'
 git_source(:github) { |repo| "https://github.com/#{repo}.git" }
 
 branch = ENV.fetch('SOLIDUS_BRANCH', 'master')
-gem 'solidus', github: 'solidusio/solidus', branch: branch
+solidus_git, solidus_frontend_git = if (branch == 'master') || (branch >= 'v3.2')
+                                      %w[solidusio/solidus solidusio/solidus_frontend]
+                                    else
+                                      %w[solidusio/solidus] * 2
+                                    end
+gem 'solidus', github: solidus_git, branch: branch
+gem 'solidus_frontend', github: solidus_frontend_git, branch: branch
 
-# Needed to help Bundler figure out how to resolve dependencies,
-# otherwise it takes forever to resolve them.
-# See https://github.com/bundler/bundler/issues/6677
-gem 'rails', '>0.a'
+gem 'rails', ENV.fetch('RAILS_VERSION', nil)
 
 # Provides basic authentication functionality for testing parts of your engine
 gem 'solidus_auth_devise'
@@ -20,7 +23,7 @@ gem 'sassc-rails', platforms: :mri
 
 gem 'bourbon'
 
-case ENV['DB']
+case ENV.fetch('DB', nil)
 when 'mysql'
   gem 'mysql2'
 when 'postgresql'

data/app/models/solidus_paypal_braintree/gateway.rb

@@ -11,9 +11,9 @@ module SolidusPaypalBraintree
     # Error message from Braintree that gets returned by a non voidable transaction
     NON_VOIDABLE_STATUS_ERROR_REGEXP = /can only be voided if status is authorized/.freeze
 
-    TOKEN_GENERATION_DISABLED_MESSAGE = 'Token generation is disabled.' \
-                                        ' To re-enable set the `token_generation_enabled` preference on the' \
-                                        ' gateway to `true`.'
+    TOKEN_GENERATION_DISABLED_MESSAGE = 'Token generation is disabled. ' \
+                                        'To re-enable set the `token_generation_enabled` preference on the ' \
+                                        'gateway to `true`.'
 
     ALLOWED_BRAINTREE_OPTIONS = [
       :device_data,
@@ -414,6 +414,8 @@ module SolidusPaypalBraintree
     def customer_profile_params(payment)
       params = {}
 
+      params[:email] = payment&.order&.email
+
       if store_in_vault && payment.source.try(:nonce)
         params[:payment_method_nonce] = payment.source.nonce
       end

data/app/models/solidus_paypal_braintree/transaction.rb

@@ -18,8 +18,8 @@ module SolidusPaypalBraintree
         errors.add(:payment_method, 'Must be braintree')
       end
       if address && !address.valid?
-        address.errors.each do |field, error|
-          errors.add(:address, "#{field} #{error}")
+        address.errors.each do |error|
+          errors.add(:address, error.full_message)
         end
       end
     end

data/app/models/solidus_paypal_braintree/transaction_import.rb

@@ -12,8 +12,8 @@ module SolidusPaypalBraintree
       errors.add("Address", "is invalid") if address && !address.valid?
 
       if !transaction.valid?
-        transaction.errors.each do |field, error|
-          errors.add(field, error)
+        transaction.errors.each do |error|
+          errors.add(error.attribute, error.message)
         end
       end
       errors.none?

data/lib/solidus_paypal_braintree/engine.rb

@@ -19,9 +19,11 @@ module SolidusPaypalBraintree
     end
 
     initializer "register_solidus_paypal_braintree_gateway", after: "spree.register.payment_methods" do |app|
-      app.config.spree.payment_methods << SolidusPaypalBraintree::Gateway
-      SolidusPaypalBraintree::Gateway.allowed_admin_form_preference_types << :preference_select
-      Spree::PermittedAttributes.source_attributes.concat [:nonce, :payment_type, :paypal_funding_source]
+      config.to_prepare do
+        app.config.spree.payment_methods << SolidusPaypalBraintree::Gateway
+        SolidusPaypalBraintree::Gateway.allowed_admin_form_preference_types.push(:preference_select).uniq!
+        ::Spree::PermittedAttributes.source_attributes.concat([:nonce, :payment_type, :paypal_funding_source]).uniq!
+      end
     end
 
     if SolidusSupport.frontend_available?

data/lib/solidus_paypal_braintree/factories.rb

@@ -8,8 +8,8 @@ FactoryBot.define do
   # require 'solidus_paypal_braintree/factories'
 
   factory :solidus_paypal_braintree_payment_method, class: SolidusPaypalBraintree::Gateway do
-    name 'Solidus PayPal Braintree Gateway'
-    active true
+    name { 'Solidus PayPal Braintree Gateway' }
+    active { true }
   end
 
   factory :solidus_paypal_braintree_source, class: SolidusPaypalBraintree::Source do
@@ -17,15 +17,15 @@ FactoryBot.define do
     user
 
     trait :credit_card do
-      payment_type SolidusPaypalBraintree::Source::CREDIT_CARD
+      payment_type { SolidusPaypalBraintree::Source::CREDIT_CARD }
     end
 
     trait :paypal do
-      payment_type SolidusPaypalBraintree::Source::PAYPAL
+      payment_type { SolidusPaypalBraintree::Source::PAYPAL }
     end
 
     trait :apple_pay do
-      payment_type SolidusPaypalBraintree::Source::APPLE_PAY
+      payment_type { SolidusPaypalBraintree::Source::APPLE_PAY }
     end
   end
 end

data/lib/solidus_paypal_braintree/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module SolidusPaypalBraintree
-  VERSION = '1.1.0'
+  VERSION = '1.1.2'
 end

data/lib/views/frontend/solidus_paypal_braintree/payments/_payment.html.erb

@@ -1,12 +1,12 @@
 <br />
-<%= payment.source.display_payment_type %>
+<%= payment.source.try(:display_payment_type) %>
 
-<% if payment.source.paypal? %>
+<% if payment.source.try(:paypal?) %>
   <% if payment.source.respond_to?(:paypal_funding_source) && payment.source.paypal_funding_source.present? %>
     <br />
     <%= t('spree.paypal_funding', funding: payment.source.display_paypal_funding_source) %>
   <% end %>
-<% elsif payment.source.venmo? %>
+<% elsif payment.source.try(:venmo?) %>
   <br />
   <%= payment.source.source_description %>
 <% end %>

data/solidus_paypal_braintree.gemspec

@@ -19,7 +19,6 @@ Gem::Specification.new do |s|
   s.files = Dir.chdir(File.expand_path(__dir__)) do
     `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
   end
-  s.test_files = Dir['spec/**/*']
   s.bindir = "exe"
   s.executables = s.files.grep(%r{^exe/}) { |f| File.basename(f) }
   s.require_paths = ["lib"]

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: solidus_paypal_braintree
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 1.1.2
 platform: ruby
 authors:
 - Stembolt
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2022-02-01 00:00:00.000000000 Z
+date: 2022-10-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemerchant
@@ -269,65 +269,6 @@ files:
 - lib/views/frontend/spree/checkout/payment/_paypal_braintree.html.erb
 - lib/views/frontend/spree/shared/_paypal_checkout_button.html.erb
 - solidus_paypal_braintree.gemspec
-- spec/controllers/solidus_paypal_braintree/checkouts_controller_spec.rb
-- spec/controllers/solidus_paypal_braintree/client_tokens_controller_spec.rb
-- spec/controllers/solidus_paypal_braintree/configurations_controller_spec.rb
-- spec/controllers/solidus_paypal_braintree/transactions_controller_spec.rb
-- spec/features/backend/configuration_spec.rb
-- spec/features/backend/new_payment_spec.rb
-- spec/features/frontend/braintree_credit_card_checkout_spec.rb
-- spec/features/frontend/paypal_checkout_spec.rb
-- spec/features/frontend/venmo_checkout_spec.rb
-- spec/fixtures/cassettes/admin/invalid_credit_card.yml
-- spec/fixtures/cassettes/admin/resubmit_credit_card.yml
-- spec/fixtures/cassettes/admin/valid_credit_card.yml
-- spec/fixtures/cassettes/braintree/create_profile.yml
-- spec/fixtures/cassettes/braintree/generate_token.yml
-- spec/fixtures/cassettes/braintree/token.yml
-- spec/fixtures/cassettes/checkout/invalid_credit_card.yml
-- spec/fixtures/cassettes/checkout/resubmit_credit_card.yml
-- spec/fixtures/cassettes/checkout/update.yml
-- spec/fixtures/cassettes/checkout/valid_credit_card.yml
-- spec/fixtures/cassettes/checkout/valid_venmo_transaction.yml
-- spec/fixtures/cassettes/gateway/authorize.yml
-- spec/fixtures/cassettes/gateway/authorize/credit_card/address.yml
-- spec/fixtures/cassettes/gateway/authorize/merchant_account/EUR.yml
-- spec/fixtures/cassettes/gateway/authorize/paypal/EUR.yml
-- spec/fixtures/cassettes/gateway/authorize/paypal/address.yml
-- spec/fixtures/cassettes/gateway/authorized_transaction.yml
-- spec/fixtures/cassettes/gateway/cancel/missing.yml
-- spec/fixtures/cassettes/gateway/cancel/refunds.yml
-- spec/fixtures/cassettes/gateway/cancel/void.yml
-- spec/fixtures/cassettes/gateway/capture.yml
-- spec/fixtures/cassettes/gateway/complete.yml
-- spec/fixtures/cassettes/gateway/credit.yml
-- spec/fixtures/cassettes/gateway/purchase.yml
-- spec/fixtures/cassettes/gateway/settled_transaction.yml
-- spec/fixtures/cassettes/gateway/void.yml
-- spec/fixtures/cassettes/source/card_type.yml
-- spec/fixtures/cassettes/source/last4.yml
-- spec/fixtures/cassettes/transaction/import/valid.yml
-- spec/fixtures/cassettes/transaction/import/valid/capture.yml
-- spec/fixtures/views/spree/orders/edit.html.erb
-- spec/helpers/solidus_paypal_braintree/braintree_admin_helper_spec.rb
-- spec/helpers/solidus_paypal_braintree/braintree_checkout_helper_spec.rb
-- spec/models/solidus_paypal_braintree/address_spec.rb
-- spec/models/solidus_paypal_braintree/avs_result_spec.rb
-- spec/models/solidus_paypal_braintree/gateway_spec.rb
-- spec/models/solidus_paypal_braintree/response_spec.rb
-- spec/models/solidus_paypal_braintree/source_spec.rb
-- spec/models/solidus_paypal_braintree/transaction_address_spec.rb
-- spec/models/solidus_paypal_braintree/transaction_import_spec.rb
-- spec/models/solidus_paypal_braintree/transaction_spec.rb
-- spec/models/spree/store_spec.rb
-- spec/requests/spree/api/orders_controller_spec.rb
-- spec/spec_helper.rb
-- spec/support/capybara.rb
-- spec/support/factories.rb
-- spec/support/gateway_helpers.rb
-- spec/support/order_ready_for_payment.rb
-- spec/support/vcr.rb
-- spec/support/views.rb
 homepage: https://github.com/solidusio/solidus_paypal_braintree
 licenses:
 - BSD-3-Clause
@@ -350,67 +291,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.20
+rubygems_version: 3.2.32
 signing_key:
 specification_version: 4
 summary: Officially supported Paypal/Braintree extension
-test_files:
-- spec/spec_helper.rb
-- spec/features/frontend/venmo_checkout_spec.rb
-- spec/features/frontend/braintree_credit_card_checkout_spec.rb
-- spec/features/frontend/paypal_checkout_spec.rb
-- spec/features/backend/configuration_spec.rb
-- spec/features/backend/new_payment_spec.rb
-- spec/models/solidus_paypal_braintree/transaction_import_spec.rb
-- spec/models/solidus_paypal_braintree/gateway_spec.rb
-- spec/models/solidus_paypal_braintree/transaction_address_spec.rb
-- spec/models/solidus_paypal_braintree/transaction_spec.rb
-- spec/models/solidus_paypal_braintree/source_spec.rb
-- spec/models/solidus_paypal_braintree/avs_result_spec.rb
-- spec/models/solidus_paypal_braintree/response_spec.rb
-- spec/models/solidus_paypal_braintree/address_spec.rb
-- spec/models/spree/store_spec.rb
-- spec/requests/spree/api/orders_controller_spec.rb
-- spec/support/capybara.rb
-- spec/support/views.rb
-- spec/support/vcr.rb
-- spec/support/gateway_helpers.rb
-- spec/support/factories.rb
-- spec/support/order_ready_for_payment.rb
-- spec/fixtures/cassettes/transaction/import/valid.yml
-- spec/fixtures/cassettes/transaction/import/valid/capture.yml
-- spec/fixtures/cassettes/braintree/create_profile.yml
-- spec/fixtures/cassettes/braintree/generate_token.yml
-- spec/fixtures/cassettes/braintree/token.yml
-- spec/fixtures/cassettes/source/last4.yml
-- spec/fixtures/cassettes/source/card_type.yml
-- spec/fixtures/cassettes/admin/valid_credit_card.yml
-- spec/fixtures/cassettes/admin/invalid_credit_card.yml
-- spec/fixtures/cassettes/admin/resubmit_credit_card.yml
-- spec/fixtures/cassettes/checkout/valid_credit_card.yml
-- spec/fixtures/cassettes/checkout/invalid_credit_card.yml
-- spec/fixtures/cassettes/checkout/update.yml
-- spec/fixtures/cassettes/checkout/resubmit_credit_card.yml
-- spec/fixtures/cassettes/checkout/valid_venmo_transaction.yml
-- spec/fixtures/cassettes/gateway/cancel/missing.yml
-- spec/fixtures/cassettes/gateway/cancel/refunds.yml
-- spec/fixtures/cassettes/gateway/cancel/void.yml
-- spec/fixtures/cassettes/gateway/capture.yml
-- spec/fixtures/cassettes/gateway/settled_transaction.yml
-- spec/fixtures/cassettes/gateway/authorized_transaction.yml
-- spec/fixtures/cassettes/gateway/void.yml
-- spec/fixtures/cassettes/gateway/credit.yml
-- spec/fixtures/cassettes/gateway/authorize.yml
-- spec/fixtures/cassettes/gateway/authorize/credit_card/address.yml
-- spec/fixtures/cassettes/gateway/authorize/paypal/EUR.yml
-- spec/fixtures/cassettes/gateway/authorize/paypal/address.yml
-- spec/fixtures/cassettes/gateway/authorize/merchant_account/EUR.yml
-- spec/fixtures/cassettes/gateway/complete.yml
-- spec/fixtures/cassettes/gateway/purchase.yml
-- spec/fixtures/views/spree/orders/edit.html.erb
-- spec/controllers/solidus_paypal_braintree/configurations_controller_spec.rb
-- spec/controllers/solidus_paypal_braintree/transactions_controller_spec.rb
-- spec/controllers/solidus_paypal_braintree/client_tokens_controller_spec.rb
-- spec/controllers/solidus_paypal_braintree/checkouts_controller_spec.rb
-- spec/helpers/solidus_paypal_braintree/braintree_admin_helper_spec.rb
-- spec/helpers/solidus_paypal_braintree/braintree_checkout_helper_spec.rb
+test_files: []

data/spec/controllers/solidus_paypal_braintree/checkouts_controller_spec.rb

@@ -1,99 +0,0 @@
-require 'spec_helper'
-require 'support/order_ready_for_payment'
-
-RSpec.describe SolidusPaypalBraintree::CheckoutsController, type: :controller do
-  routes { SolidusPaypalBraintree::Engine.routes }
-
-  include_context 'when order is ready for payment'
-
-  describe 'PATCH update' do
-    subject(:patch_update) { patch :update, params: params }
-
-    let(:params) do
-      {
-        "state" => "payment",
-        "order" => {
-          "payments_attributes" => [
-            {
-              "payment_method_id" => payment_method.id,
-              "source_attributes" => {
-                "nonce" => "fake-paypal-billing-agreement-nonce",
-                "payment_type" => SolidusPaypalBraintree::Source::PAYPAL
-              }
-            }
-          ],
-          "use_billing" => "1",
-          "use_postmates_shipping" => "0"
-        },
-        "reuse_credit" => "1",
-        "order_bill_address" => "",
-        "reuse_bill_address" => "1"
-      }
-    end
-
-    let!(:payment_method) do
-      create_gateway
-    end
-
-    before do
-      allow(controller).to receive(:try_spree_current_user) { user }
-      allow(controller).to receive(:spree_current_user) { user }
-      allow(controller).to receive(:current_order) { order }
-    end
-
-    context "when a payment is created successfully", vcr: {
-      cassette_name: 'checkout/update',
-      match_requests_on: [:braintree_uri]
-    } do
-      it 'creates a payment' do
-        expect { patch_update }.
-          to change { order.payments.count }.
-          from(0).
-          to(1)
-      end
-
-      it 'creates a payment source' do
-        expect { patch_update }.
-          to change { SolidusPaypalBraintree::Source.count }.
-          from(0).
-          to(1)
-      end
-
-      it 'assigns @order' do
-        patch_update
-        expect(assigns(:order)).to eq order
-      end
-
-      it "is successful" do
-        expect(patch_update).to be_successful
-      end
-
-      it "renders 'ok'" do
-        expect(patch_update.body).to eql("ok")
-      end
-    end
-
-    context "when a payment is not created successfully" do
-      before do
-        allow_any_instance_of(::Spree::Payment).to receive(:save).and_return(false)
-      end
-
-      # No idea why this is the case, but I'm just adding the tests here
-      it "is successful" do
-        expect(patch_update).to be_successful
-      end
-
-      it "renders 'not-ok'" do
-        expect(patch_update.body).to eq('not-ok')
-      end
-
-      it "does not change the number of payments in the system" do
-        expect{ patch_update }.not_to(change{ ::Spree::Payment.count })
-      end
-
-      it "does not change the number of sources in the system" do
-        expect{ patch_update }.not_to(change{ SolidusPaypalBraintree::Source.count })
-      end
-    end
-  end
-end

data/spec/controllers/solidus_paypal_braintree/client_tokens_controller_spec.rb

@@ -1,55 +0,0 @@
-require 'spec_helper'
-
-describe SolidusPaypalBraintree::ClientTokensController do
-  routes { SolidusPaypalBraintree::Engine.routes }
-
-  cassette_options = { cassette_name: "braintree/token" }
-  describe "POST create", vcr: cassette_options do
-    let!(:gateway) { create_gateway }
-    let(:user) { create(:user) }
-    let(:json) { JSON.parse(response.body) }
-
-    before { user.generate_spree_api_key! }
-
-    context 'without a payment method id' do
-      subject(:response) do
-        post :create, params: { token: user.spree_api_key }
-      end
-
-      it "returns a client token", aggregate_failures: true do
-        expect(response).to have_http_status(:success)
-        expect(response.content_type).to include 'application/json'
-        expect(json["client_token"]).to be_present
-        expect(json["client_token"]).to be_a String
-        expect(json["payment_method_id"]).to eq gateway.id
-      end
-
-      context "when there's two gateway's for different stores" do
-        let!(:store1) { create(:store, code: 'store_1') }
-        let!(:store2) { create(:store, code: 'store_2') }
-        let!(:gateway_for_store1) { create_gateway.tap{ |gw| store1.payment_methods << gw } }
-        let!(:gateway_for_store2) { create_gateway.tap{ |gw| store2.payment_methods << gw } }
-
-        it "returns the correct gateway for store1" do
-          allow_any_instance_of(described_class).to receive(:current_store).and_return store1
-          expect(json["payment_method_id"]).to eq gateway_for_store1.id
-        end
-
-        it "returns the correct gateway for store2" do
-          allow_any_instance_of(described_class).to receive(:current_store).and_return store2
-          expect(json["payment_method_id"]).to eq gateway_for_store2.id
-        end
-      end
-    end
-
-    context 'with a payment method id' do
-      subject(:response) do
-        post :create, params: { token: user.spree_api_key, payment_method_id: gateway.id }
-      end
-
-      it 'uses the selected gateway' do
-        expect(json["payment_method_id"]).to eq gateway.id
-      end
-    end
-  end
-end