solidus_pagy 1.0.0

data/lib/generators/solidus_pagy/install/templates/initializer.rb

@@ -0,0 +1,30 @@
+# frozen_string_literal: true
+
+#  - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
+# | Option     | Helper               | Path                     |
+#  - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
+# | default    | pagy_nav             |                          |
+# | bootstrap  | pagy_bootstrap_nav   | pagy/extras/bootstrap    |
+# | bulma      | pagy_bulma_nav       | pagy/extras/bulma        |
+# | foundation | pagy_foundation_nav  | pagy/extras/foundation   |
+# | materialize| pagy_materialize_nav | pagy/extras/materialize  |
+# | semantic   | pagy_semantic_nav    | pagy/extras/semantic     |
+# | uikit      | pagy_uikit_nav       | pagy/extras/uikit        |
+#  - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
+
+SolidusPagy.configure do |config|
+  config.nav_helper = 'pagy_nav'
+  config.page = 1
+  config.items = 20
+  config.outset = 0
+  config.orders_per_page = 15
+  config.properties_per_page = 15
+  config.promotions_per_page = 15
+  config.admin_products_per_page = 10
+  config.admin_variants_per_page = 20
+end
+
+Pagy::DEFAULT[:page] = SolidusPagy.config.page
+Pagy::DEFAULT[:items] = SolidusPagy.config.items
+Pagy::DEFAULT[:outset] = SolidusPagy.config.outset
+Pagy::DEFAULT.freeze

data/lib/generators/solidus_pagy/install/templates/pagy.rb

@@ -0,0 +1,235 @@
+# frozen_string_literal: true
+
+# Pagy initializer file (5.10.1)
+# Customize only what you really need and notice that the core Pagy works also without any of the following lines.
+# Should you just cherry pick part of this file, please maintain the require-order of the extras
+
+# Pagy DEFAULT Variables
+# See https://ddnexus.github.io/pagy/api/pagy#variables
+# All the Pagy::DEFAULT are set for all the Pagy instances but can be overridden per instance by just passing them to
+# Pagy.new|Pagy::Countless.new|Pagy::Calendar::*.new or any of the #pagy* controller methods
+
+# Instance variables
+# See https://ddnexus.github.io/pagy/api/pagy#instance-variables
+# Pagy::DEFAULT[:page]   = 1                                  # default
+# Pagy::DEFAULT[:items]  = 20                                 # default
+# Pagy::DEFAULT[:outset] = 0                                  # default
+
+# Other Variables
+# See https://ddnexus.github.io/pagy/api/pagy#other-variables
+# Pagy::DEFAULT[:size]       = [1,4,4,1]                       # default
+# Pagy::DEFAULT[:page_param] = :page                           # default
+# The :params can be also set as a lambda e.g ->(params){ params.exclude('useless').merge!('custom' => 'useful') }
+# Pagy::DEFAULT[:params]     = {}                              # default
+# Pagy::DEFAULT[:fragment]   = '#fragment'                     # example
+# Pagy::DEFAULT[:link_extra] = 'data-remote="true"'            # example
+# Pagy::DEFAULT[:i18n_key]   = 'pagy.item_name'                # default
+# Pagy::DEFAULT[:cycle]      = true                            # example
+
+# Extras
+# See https://ddnexus.github.io/pagy/extras
+
+# Backend Extras
+
+# Array extra: Paginate arrays efficiently, avoiding expensive array-wrapping and without overriding
+# See https://ddnexus.github.io/pagy/extras/array
+# require 'pagy/extras/array'
+
+# Calendar extra: Add pagination filtering by calendar time unit (year, quarter, month, week, day)
+# See https://ddnexus.github.io/pagy/extras/calendar
+# require 'pagy/extras/calendar'
+# Default for each unit
+# Pagy::Calendar::Year::DEFAULT[:order]     = :asc        # Time direction of pagination
+# Pagy::Calendar::Year::DEFAULT[:format]    = '%Y'        # strftime format
+#
+# Pagy::Calendar::Quarter::DEFAULT[:order]  = :asc        # Time direction of pagination
+# Pagy::Calendar::Quarter::DEFAULT[:format] = '%Y-Q%q'    # strftime format
+#
+# Pagy::Calendar::Month::DEFAULT[:order]    = :asc        # Time direction of pagination
+# Pagy::Calendar::Month::DEFAULT[:format]   = '%Y-%m'     # strftime format
+#
+# Pagy::Calendar::Week::DEFAULT[:order]     = :asc        # Time direction of pagination
+# Pagy::Calendar::Week::DEFAULT[:format]    = '%Y-%W'     # strftime format
+#
+# Pagy::Calendar::Day::DEFAULT[:order]      = :asc        # Time direction of pagination
+# Pagy::Calendar::Day::DEFAULT[:format]     = '%Y-%m-%d'  # strftime format
+#
+# Uncomment the following lines, if you need calendar localization without using the I18n extra
+# module LocalizePagyCalendar
+#   def localize(time, opts)
+#     ::I18n.l(time, **opts)
+#   end
+# end
+# Pagy::Calendar.prepend LocalizePagyCalendar
+
+# Countless extra: Paginate without any count, saving one query per rendering
+# See https://ddnexus.github.io/pagy/extras/countless
+# require 'pagy/extras/countless'
+# Pagy::DEFAULT[:countless_minimal] = false   # default (eager loading)
+
+# Elasticsearch Rails extra: Paginate `ElasticsearchRails::Results` objects
+# See https://ddnexus.github.io/pagy/extras/elasticsearch_rails
+# Default :pagy_search method: change only if you use also
+# the searchkick or meilisearch extra that defines the same
+# Pagy::DEFAULT[:elasticsearch_rails_pagy_search] = :pagy_search
+# Default original :search method called internally to do the actual search
+# Pagy::DEFAULT[:elasticsearch_rails_search] = :search
+# require 'pagy/extras/elasticsearch_rails'
+
+# Headers extra: http response headers (and other helpers) useful for API pagination
+# See http://ddnexus.github.io/pagy/extras/headers
+# require 'pagy/extras/headers'
+# Pagy::DEFAULT[:headers] = { page: 'Current-Page',
+#                            items: 'Page-Items',
+#                            count: 'Total-Count',
+#                            pages: 'Total-Pages' }     # default
+
+# Meilisearch extra: Paginate `Meilisearch` result objects
+# See https://ddnexus.github.io/pagy/extras/meilisearch
+# Default :pagy_search method: change only if you use also
+# the elasticsearch_rails or searchkick extra that define the same method
+# Pagy::DEFAULT[:meilisearch_pagy_search] = :pagy_search
+# Default original :search method called internally to do the actual search
+# Pagy::DEFAULT[:meilisearch_search] = :ms_search
+# require 'pagy/extras/meilisearch'
+
+# Metadata extra: Provides the pagination metadata to Javascript frameworks like Vue.js, react.js, etc.
+# See https://ddnexus.github.io/pagy/extras/metadata
+# you must require the shared internal extra (BEFORE the metadata extra) ONLY if you need also the :sequels
+# require 'pagy/extras/shared'
+# require 'pagy/extras/metadata'
+# For performance reasons, you should explicitly set ONLY the metadata you use in the frontend
+# Pagy::DEFAULT[:metadata] = %i[scaffold_url page prev next last]   # example
+
+# Searchkick extra: Paginate `Searchkick::Results` objects
+# See https://ddnexus.github.io/pagy/extras/searchkick
+# Default :pagy_search method: change only if you use also
+# the elasticsearch_rails or meilisearch extra that defines the same
+# DEFAULT[:searchkick_pagy_search] = :pagy_search
+# Default original :search method called internally to do the actual search
+# Pagy::DEFAULT[:searchkick_search] = :search
+# require 'pagy/extras/searchkick'
+# uncomment if you are going to use Searchkick.pagy_search
+# Searchkick.extend Pagy::Searchkick
+
+# Frontend Extras
+
+# Bootstrap extra: Add nav, nav_js and combo_nav_js helpers and templates for Bootstrap pagination
+# See https://ddnexus.github.io/pagy/extras/bootstrap
+# require 'pagy/extras/bootstrap'
+
+# Bulma extra: Add nav, nav_js and combo_nav_js helpers and templates for Bulma pagination
+# See https://ddnexus.github.io/pagy/extras/bulma
+# require 'pagy/extras/bulma'
+
+# Foundation extra: Add nav, nav_js and combo_nav_js helpers and templates for Foundation pagination
+# See https://ddnexus.github.io/pagy/extras/foundation
+# require 'pagy/extras/foundation'
+
+# Materialize extra: Add nav, nav_js and combo_nav_js helpers for Materialize pagination
+# See https://ddnexus.github.io/pagy/extras/materialize
+# require 'pagy/extras/materialize'
+
+# Navs extra: Add nav_js and combo_nav_js javascript helpers
+# Notice: the other frontend extras add their own framework-styled versions,
+# so require this extra only if you need the unstyled version
+# See https://ddnexus.github.io/pagy/extras/navs
+# require 'pagy/extras/navs'
+
+# Semantic extra: Add nav, nav_js and combo_nav_js helpers for Semantic UI pagination
+# See https://ddnexus.github.io/pagy/extras/semantic
+# require 'pagy/extras/semantic'
+
+# UIkit extra: Add nav helper and templates for UIkit pagination
+# See https://ddnexus.github.io/pagy/extras/uikit
+# require 'pagy/extras/uikit'
+
+# Multi size var used by the *_nav_js helpers
+# See https://ddnexus.github.io/pagy/extras/navs#steps
+# Pagy::DEFAULT[:steps] = { 0 => [2,3,3,2], 540 => [3,5,5,3], 720 => [5,7,7,5] }   # example
+
+# Feature Extras
+
+# Gearbox extra: Automatically change the number of items per page depending on the page number
+# See https://ddnexus.github.io/pagy/extras/gearbox
+# require 'pagy/extras/gearbox'
+# set to false only if you want to make :gearbox_extra an opt-in variable
+# Pagy::DEFAULT[:gearbox_extra] = false               # default true
+# Pagy::DEFAULT[:gearbox_items] = [15, 30, 60, 100]   # default
+
+# Items extra: Allow the client to request a custom number of items per page with an optional selector UI
+# See https://ddnexus.github.io/pagy/extras/items
+# require 'pagy/extras/items'
+# set to false only if you want to make :items_extra an opt-in variable
+# Pagy::DEFAULT[:items_extra] = false    # default true
+# Pagy::DEFAULT[:items_param] = :items   # default
+# Pagy::DEFAULT[:max_items]   = 100      # default
+
+# Overflow extra: Allow for easy handling of overflowing pages
+# See https://ddnexus.github.io/pagy/extras/overflow
+# require 'pagy/extras/overflow'
+# Pagy::DEFAULT[:overflow] = :empty_page    # default  (other options: :last_page and :exception)
+
+# Support extra: Extra support for features like: incremental, infinite, auto-scroll pagination
+# See https://ddnexus.github.io/pagy/extras/support
+# require 'pagy/extras/support'
+
+# Trim extra: Remove the page=1 param from links
+# See https://ddnexus.github.io/pagy/extras/trim
+# require 'pagy/extras/trim'
+# set to false only if you want to make :trim_extra an opt-in variable
+# Pagy::DEFAULT[:trim_extra] = false # default true
+
+# Standalone extra: Use pagy in non Rack environment/gem
+# See https://ddnexus.github.io/pagy/extras/standalone
+# require 'pagy/extras/standalone'
+# Pagy::DEFAULT[:url] = 'http://www.example.com/subdir'  # optional default
+
+# Rails
+# Enable the .js file required by the helpers that use javascript
+# (pagy*_nav_js, pagy*_combo_nav_js, and pagy_items_selector_js)
+# See https://ddnexus.github.io/pagy/extras#javascript
+
+# With the asset pipeline
+# Sprockets need to look into the pagy javascripts dir, so add it to the assets paths
+# Rails.application.config.assets.paths << Pagy.root.join('javascripts')
+
+# I18n
+
+# Pagy internal I18n: ~18x faster using ~10x less memory than the i18n gem
+# See https://ddnexus.github.io/pagy/api/frontend#i18n
+# Notice: No need to configure anything in this section if your app uses only "en"
+# or if you use the i18n extra below
+#
+# Examples:
+# load the "de" built-in locale:
+# Pagy::I18n.load(locale: 'de')
+#
+# load the "de" locale defined in the custom file at :filepath:
+# Pagy::I18n.load(locale: 'de', filepath: 'path/to/pagy-de.yml')
+#
+# load the "de", "en" and "es" built-in locales:
+# (the first passed :locale will be used also as the default_locale)
+# Pagy::I18n.load({ locale: 'de' },
+#                 { locale: 'en' },
+#                 { locale: 'es' })
+#
+# load the "en" built-in locale, a custom "es" locale,
+# and a totally custom locale complete with a custom :pluralize proc:
+# (the first passed :locale will be used also as the default_locale)
+# Pagy::I18n.load({ locale: 'en' },
+#                 { locale: 'es', filepath: 'path/to/pagy-es.yml' },
+#                 { locale: 'xyz',  # not built-in
+#                   filepath: 'path/to/pagy-xyz.yml',
+#                   pluralize: lambda{ |count| ... } )
+
+# I18n extra: uses the standard i18n gem which is ~18x slower using ~10x more memory
+# than the default pagy internal i18n (see above)
+# See https://ddnexus.github.io/pagy/extras/i18n
+# require 'pagy/extras/i18n'
+
+# Default i18n key
+# Pagy::DEFAULT[:i18n_key] = 'pagy.item_name'   # default
+
+# When you are done setting your own default freeze it, so it will not get changed accidentally
+# Pagy::DEFAULT.freeze

data/lib/solidus_pagy/configuration.rb

@@ -0,0 +1,27 @@
+# frozen_string_literal: true
+
+module SolidusPagy
+  class Configuration
+    attr_accessor :nav_helper,
+      :page,
+      :items,
+      :outset,
+      :promotions_per_page,
+      :properties_per_page,
+      :orders_per_page,
+      :admin_products_per_page,
+      :admin_variants_per_page
+  end
+
+  class << self
+    def configuration
+      @configuration ||= Configuration.new
+    end
+
+    alias config configuration
+
+    def configure
+      yield configuration
+    end
+  end
+end

data/lib/solidus_pagy/engine.rb

@@ -0,0 +1,16 @@
+# frozen_string_literal: true
+
+module SolidusPagy
+  class Engine < Rails::Engine
+    include SolidusSupport::EngineExtensions
+
+    isolate_namespace ::Spree
+
+    engine_name 'solidus_pagy'
+
+    # use rspec for tests
+    config.generators do |g|
+      g.test_framework :rspec
+    end
+  end
+end

data/lib/solidus_pagy/testing_support/factories.rb

@@ -0,0 +1,4 @@
+# frozen_string_literal: true
+
+FactoryBot.define do
+end

data/lib/solidus_pagy/version.rb

@@ -0,0 +1,5 @@
+# frozen_string_literal: true
+
+module SolidusPagy
+  VERSION = '1.0.0'
+end

data/lib/solidus_pagy.rb

@@ -0,0 +1,11 @@
+# frozen_string_literal: true
+
+require 'solidus_core'
+require 'solidus_backend'
+require 'solidus_support'
+require 'deface'
+
+require 'solidus_pagy/configuration'
+require 'solidus_pagy/version'
+require 'solidus_pagy/engine'
+require 'pagy'

data/solidus_pagy.gemspec

@@ -0,0 +1,44 @@
+# frozen_string_literal: true
+
+require_relative 'lib/solidus_pagy/version'
+
+Gem::Specification.new do |s|
+  s.name = 'solidus_pagy'
+  s.version = SolidusPagy::VERSION
+  s.authors = ['Jonathan Tapia']
+  s.email = 'jonathan.tapia@magmalabs.io'
+
+  s.summary = 'Solidus extension using Pagy pagination.'
+  s.description = 'Solidus extension using Pagy pagination.'
+  s.homepage = 'https://github.com/solidusio-contrib/solidus_pagy#readme'
+  s.license = 'BSD-3-Clause'
+
+  if s.respond_to?(:metadata)
+    s.metadata['homepage_uri'] = s.homepage
+    s.metadata['source_code_uri'] = 'https://github.com/jtapia/solidus_pagy'
+    s.metadata['rubygems_mfa_required'] = 'true'
+    s.metadata['changelog_uri'] = 'https://github.com/jtapia/solidus_pagy/blob/master/CHANGELOG.md'
+  end
+
+  s.required_ruby_version = Gem::Requirement.new('>= 2.5')
+
+  # Specify which files should be added to the gem when it is released.
+  # The `git ls-files -z` loads the files in the RubyGem that have been added into git.
+  files = Dir.chdir(__dir__) { `git ls-files -z`.split("\x0") }
+
+  s.files = files.grep_v(%r{^(test|spec|features)/})
+  s.test_files = files.grep(%r{^(test|spec|features)/})
+  s.bindir = 'exe'
+  s.executables = files.grep(%r{^exe/}) { |f| File.basename(f) }
+  s.require_paths = ['lib']
+
+  solidus_version = ['>= 2.5', '< 4']
+
+  s.add_dependency 'pagy', '~> 5.10'
+  s.add_dependency 'solidus_core', solidus_version
+  s.add_dependency 'solidus_support', '~> 0.5'
+
+  s.add_development_dependency 'solidus_backend', solidus_version
+  s.add_development_dependency 'solidus_dev_support', '~> 2.5'
+  s.add_development_dependency 'solidus_frontend', solidus_version
+end

data/spec/controllers/spree/admin/orders_controller_spec.rb

@@ -0,0 +1,100 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe Spree::Admin::OrdersController, type: :controller do
+  let(:store) { create(:store) }
+
+  context 'with authorization' do
+    stub_authorization!
+
+    let(:order) do
+      mock_model(
+        Spree::Order,
+        completed?: true,
+        total: 100,
+        number: 'R123456789',
+        all_adjustments: adjustments,
+        ship_address: mock_model(Spree::Address)
+      )
+    end
+    let(:adjustments) do
+      instance_double('adjustments')
+    end
+
+    before do
+      request.env['HTTP_REFERER'] = 'http://localhost:3000'
+      allow(Spree::Order).to receive_message_chain(:includes, find_by!: order)
+      allow(order)
+        .to receive_messages(contents: Spree::OrderContents.new(order))
+    end
+
+    context 'with pagination' do
+      it 'can page through the orders' do
+        get :index, params: { page: 1, per_page: 10 }
+        expect(assigns[:pagy].page).to eq(1)
+        expect(assigns[:pagy].items).to eq(10)
+      end
+    end
+
+    # Test for https://github.com/spree/spree/issues/3919
+    context 'search' do
+      let(:user) { create(:user) }
+
+      before do
+        allow(controller).to receive(:try_spree_current_user) { user }
+        user.spree_roles << Spree::Role.find_or_create_by(name: 'admin')
+        create_list(:completed_order_with_totals, 2)
+      end
+
+      context 'by line_items_variant_id_in' do
+        it 'does not display duplicated results' do
+          get :index,
+            params: {
+              q: {
+                line_items_variant_id_in: Spree::Order.first.variants.map(&:id)
+              }
+            }
+          expect(assigns[:orders].size).to eq 1
+        end
+      end
+
+      context 'by email' do
+        it 'does not display duplicated results' do
+          get :index,
+            params: {
+              q: {
+                email_start: Spree::Order.first.email
+              }
+            }
+          expect(assigns[:orders].size).to eq 1
+          expect(assigns[:orders][0].email).to eq(Spree::Order.first.email)
+        end
+      end
+
+      context 'by created_at_gt' do
+        it 'does display item results' do
+          get :index,
+            params: {
+              q: {
+                created_at_gt: DateTime.now - 1.day
+              }
+            }
+          expect(assigns[:orders].size).to eq(2)
+        end
+      end
+
+      context 'by created_at_lt' do
+        it 'does display item results' do
+          get :index,
+            params: {
+              q: {
+                created_at_lt: DateTime.now
+              }
+            }
+          expect(assigns[:orders].size).to eq(2)
+        end
+      end
+    end
+  end
+end

data/spec/controllers/spree/admin/prices_controller_spec.rb

@@ -0,0 +1,80 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe Spree::Admin::PricesController, type: :controller do
+  stub_authorization!
+
+  let(:product) { create(:product) }
+
+  context 'with pagination' do
+    it 'can page through the product master prices' do
+      get :index, params: { product_id: product.slug, page: 1 }
+      expect(assigns[:pagy_master_prices].page).to eq(1)
+      expect(assigns[:pagy_master_prices].items).to eq(20)
+    end
+
+    it 'can page through the product variant prices' do
+      get :index, params: { product_id: product.slug, variants_page: 1 }
+      expect(assigns[:pagy_variant_prices].page).to eq(1)
+      expect(assigns[:pagy_variant_prices].items).to eq(20)
+    end
+  end
+
+  describe '#index' do
+    context 'when only given a product' do
+      let(:product) { create(:product) }
+
+      subject { get :index, params: { product_id: product.slug } }
+
+      it { is_expected.to be_successful }
+
+      it 'assigns usable instance variables' do
+        subject
+
+        expect(assigns(:search)).to be_a(Ransack::Search)
+        expect(assigns(:variant_prices)).to eq(product.prices.for_variant)
+        expect(assigns(:master_prices)).to eq(product.prices.for_master)
+        expect(assigns(:product)).to eq(product)
+      end
+    end
+
+    context 'when given a product and a variant' do
+      let(:variant) { create(:variant) }
+      let(:product) { variant.product }
+
+      subject do
+        get :index,
+          params: {
+            product_id: product.slug,
+            variant_id: variant.id
+          }
+      end
+
+      it { is_expected.to be_successful }
+
+      it 'assigns usable instance variables' do
+        subject
+
+        expect(assigns(:search)).to be_a(Ransack::Search)
+        expect(assigns(:variant_prices)).to eq(product.prices.for_variant)
+        expect(assigns(:master_prices)).to eq(product.prices.for_master)
+        expect(assigns(:variant_prices)).to include(variant.default_price)
+        expect(assigns(:product)).to eq(product)
+      end
+    end
+
+    context 'existent product id not given' do
+      subject do
+        get :index, params: { product_id: 'non-existent-product' }
+      end
+
+      it 'cannot find non-existent product' do
+        subject
+
+        expect(response).to redirect_to(spree.admin_products_path)
+        expect(flash[:error]).to eql('Product is not found')
+      end
+    end
+  end
+end

data/spec/controllers/spree/admin/products_controller_spec.rb

@@ -0,0 +1,57 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe Spree::Admin::ProductsController, type: :controller do
+  stub_authorization!
+
+  let(:product) { create(:product) }
+
+  context 'with pagination' do
+    it 'can page through the products' do
+      get :index, params: { page: 1, per_page: 10 }
+      expect(assigns[:pagy].page).to eq(1)
+      expect(assigns[:pagy].items).to eq(10)
+    end
+  end
+
+  describe '#index' do
+    let(:ability_user) do
+      stub_model(Spree::LegacyUser, has_spree_role?: true)
+    end
+
+    # Regression test for https://github.com/spree/spree/issues/1259
+    it 'can find a product by SKU' do
+      product = create(:product, sku: 'ABC123')
+
+      get :index, params: { q: { sku_start: 'ABC123' } }
+      expect(assigns[:collection]).not_to be_empty
+      expect(assigns[:collection]).to include(product)
+    end
+
+    # Regression test for https://github.com/spree/spree/issues/1903
+    context 'when soft deleted products exist' do
+      let(:soft_deleted_product) { create(:product, sku: 'ABC123') }
+
+      before { soft_deleted_product.discard }
+
+      context 'when params[:q][:with_discarded] is not set' do
+        let(:params) { { q: {} } }
+
+        it 'filters out soft-deleted products by default' do
+          get :index, params: params
+          expect(assigns[:collection]).not_to include(soft_deleted_product)
+        end
+      end
+
+      context "when params[:q][:with_discarded] is set to 'true'" do
+        let(:params) { { q: { with_discarded: 'true' } } }
+
+        it 'includes soft-deleted products' do
+          get :index, params: params
+          expect(assigns[:collection]).to include(soft_deleted_product)
+        end
+      end
+    end
+  end
+end

data/spec/controllers/spree/admin/promotion_codes_controller_spec.rb

@@ -0,0 +1,38 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe Spree::Admin::PromotionCodesController, type: :controller do
+  stub_authorization!
+
+  let(:promotion) { create(:promotion) }
+  let(:code1) { create(:promotion_code, promotion: promotion) }
+  let(:code2) { create(:promotion_code, promotion: promotion) }
+  let(:code3) { create(:promotion_code, promotion: promotion) }
+
+  context 'with pagination' do
+    it 'can page through the products' do
+      get :index,
+        params: {
+          promotion_id: promotion.id,
+          page: 1
+        }
+      expect(assigns[:pagy].page).to eq(1)
+      expect(assigns[:pagy].items).to eq(50)
+    end
+  end
+
+  describe '#index' do
+    it 'returns 200 as HTML' do
+      get :index, params: { promotion_id: promotion.id }
+
+      expect(response.status).to be(200)
+    end
+
+    it 'returns 200 as CSV' do
+      get :index, params: { promotion_id: promotion.id, format: :csv }
+
+      expect(response.status).to be(200)
+    end
+  end
+end