solidus_nexio 0.4.0 → 0.4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 30a0a8caecebecbaed158c6c195072fdad67eed7308658d91d4fd8ee39bbc07b
-  data.tar.gz: 2baa67ea4406dd56ca2caaee620fe36c6ff8ba191b68c8c34ef998e5972905d3
+  metadata.gz: c824e5f041c3632fed6eee4f0b6b16a87edbc939e4ce4b4a022cfad1099c7355
+  data.tar.gz: bb652b85568a70d550fdaab690a61f2ef103d5eaec22fdd11d53e49a22778a19
 SHA512:
-  metadata.gz: 56da292a0a75cea5dcea99eaae7ad90f4619cfa542f4afdc5dbef53f2735c0d9b7f8b472fb08167d20a01acbb263534dec993712df3bc4c18207ce55178c5cf9
-  data.tar.gz: 35e3c3b56afca1e4f4b6b4e8ebaa53e2267f5a184e49e33629cdb48ec93561914a772c94346ced58ecd9822ad01370ada3f2f24212eb256772286b67310ecf65
+  metadata.gz: '084bc6e66e4e6690b2932280af94932bbe80fe2f7eee9d9150660e01052897ddab09d647bcfc07f5a463a57c6db5817e4e0a5dfe6d6affef2bd8113f41b29fc1'
+  data.tar.gz: 5f90d10aa5c547180d5c6d204dd7cc5fbf041c1709ca0ff9fd980fde43d635f9563abcc435095f66234785887cd5bd5e20fe532d4df514b26830858f736e4837

data/app/controllers/solidus_nexio/payment_states_controller.rb

@@ -8,9 +8,13 @@ module SolidusNexio
 
     def capture
       payment_method = PaymentMethod.find(params[:payment_method_id])
-      payment = payment_method.payments.find(params[:payment_id])
-      @result = payment_method.capture_order_payment(payment, params[:id], params[:status])
-      render :capture, layout: false
+      payment = payment_method.payments.find_by(number: params[:payment_id])
+      if payment
+        @result = payment_method.capture_order_payment(payment, params[:id], params[:status])
+        render :capture, layout: false
+      else
+        head 404
+      end
     end
   end
 end

data/app/controllers/solidus_nexio/payments_controller.rb

@@ -4,7 +4,7 @@ module SolidusNexio
       if update_order
         payment_method = PaymentMethod.find(params[:payment_method_id])
         result = payment_method.process_order_payment(@order) do |payment|
-          capture_payment_method_payment_state_url(payment_method, payment)
+          capture_payment_method_payment_state_url(payment_method, payment.number)
         end
         render json: result
       else

data/app/models/solidus_nexio/payment_method.rb

@@ -41,7 +41,7 @@ module SolidusNexio
     def capture_order_payment(payment, id, status)
       return ProcessResult.new(:invalid, nil) unless payment.checkout?
 
-      if success_payment_status?(payment, id, status)
+      if id.present? && %w[pending authOnly].include?(status)
         payment.response_code = id
         auto_capture? ? payment.complete! : payment.pend!
         ProcessResult.new(:success, nil)
@@ -113,14 +113,5 @@ module SolidusNexio
 
       resp.params['redirectUrl'] if resp.params['status'] == 'redirect'
     end
-
-    def success_payment_status?(payment, id, status)
-      return false unless id.present? && %w[pending authOnly].include?(status)
-
-      data = gateway.get_transaction(id)
-      return false unless data
-
-      data.fetch('plugin', {})['orderNumber'] == payment.order.number
-    end
   end
 end

data/lib/solidus_nexio/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module SolidusNexio
-  VERSION = '0.4.0'
+  VERSION = '0.4.1'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: solidus_nexio
 version: !ruby/object:Gem::Version
-  version: 0.4.0
+  version: 0.4.1
 platform: ruby
 authors:
 - Whitespectre