solidus_legacy_return_authorizations 1.0.0

data/spec/features/admin/orders/legacy_return_authorizations_spec.rb

@@ -0,0 +1,26 @@
+require 'spec_helper'
+
+describe "legacy return authorizations" do
+  stub_authorization!
+
+  let!(:order) { create(:shipped_order) }
+
+  before do
+    create(:legacy_return_authorization,
+            :order => order,
+            :state => 'authorized',
+            :inventory_units => order.shipments.first.inventory_units,
+            :stock_location_id => order.shipments.first.stock_location_id)
+  end
+
+  # Regression test for #1107
+  it "doesn't blow up when receiving a legacy return authorization" do
+    visit spree.admin_path
+    click_link "Orders"
+    click_link order.number
+    click_link "Legacy Return Authorizations"
+    click_link "Edit"
+    expect { click_button "receive" }.not_to raise_error
+  end
+
+end

data/spec/models/spree/legacy_return_authorization_spec.rb

@@ -0,0 +1,214 @@
+require 'spec_helper'
+
+describe Spree::LegacyReturnAuthorization do
+  let(:stock_location) { Spree::StockLocation.create(:name => "test") }
+  let(:order) { FactoryGirl.create(:shipped_order) }
+
+  let(:variant) { order.variants.first }
+  let(:legacy_return_authorization) { Spree::LegacyReturnAuthorization.new(:order => order, :stock_location_id => stock_location.id) }
+
+  context "save" do
+    let(:order) { Spree::Order.create }
+
+    it "should be invalid when order has no inventory units" do
+      legacy_return_authorization.save
+      expect(legacy_return_authorization.errors[:order]).to eq(["has no shipped units"])
+    end
+  end
+
+  describe ".before_create" do
+    describe "#generate_number" do
+      context "number is assigned" do
+        let(:legacy_return_authorization) { Spree::LegacyReturnAuthorization.new(number: '123') }
+
+        it "should return the assigned number" do
+          legacy_return_authorization.save
+          expect(legacy_return_authorization.number).to eq('123')
+        end
+      end
+
+      context "number is not assigned" do
+        let(:legacy_return_authorization) { Spree::LegacyReturnAuthorization.new(number: nil) }
+
+        before { allow(legacy_return_authorization).to receive_messages valid?: true }
+
+        it "should assign number with random RMA number" do
+          legacy_return_authorization.save
+          expect(legacy_return_authorization.number).to match(/RMA\d{9}/)
+        end
+      end
+    end
+  end
+
+  context "add_variant" do
+    context "on empty rma" do
+      it "should associate inventory units as shipped" do
+        legacy_return_authorization.add_variant(variant.id, 1)
+        expect(legacy_return_authorization.inventory_units.where(state: 'shipped').size).to eq 1
+      end
+
+      it "should update order state" do
+        expect(order).to receive(:authorize_return!)
+        legacy_return_authorization.add_variant(variant.id, 1)
+      end
+    end
+
+    context "on rma that already has inventory_units" do
+      before do
+        legacy_return_authorization.add_variant(variant.id, 1)
+      end
+
+      it "should not associate more inventory units than there are on the order" do
+        legacy_return_authorization.add_variant(variant.id, 1)
+        expect(legacy_return_authorization.inventory_units.size).to eq 1
+      end
+
+      it "should not update order state" do
+        expect{legacy_return_authorization.add_variant(variant.id, 1)}.to_not change{order.state}
+      end
+    end
+  end
+
+  context "can_receive?" do
+    it "should allow_receive when inventory units assigned" do
+      allow(legacy_return_authorization).to receive_messages(:inventory_units => [1,2,3])
+      expect(legacy_return_authorization.can_receive?).to be_truthy
+    end
+
+    it "should not allow_receive with no inventory units" do
+      allow(legacy_return_authorization).to receive_messages(:inventory_units => [])
+      expect(legacy_return_authorization.can_receive?).to be_falsey
+    end
+  end
+
+  context "receive!" do
+    let(:inventory_unit) { order.shipments.first.inventory_units.first }
+
+    context "to the initial stock location" do
+      before do
+        allow(legacy_return_authorization).to receive_messages(:inventory_units => [inventory_unit], :amount => -20)
+        allow(legacy_return_authorization).to receive_messages(:stock_location_id => inventory_unit.shipment.stock_location.id)
+        allow(Spree::Adjustment).to receive(:create)
+        allow(order).to receive(:update!)
+      end
+
+      it "should mark all inventory units are returned" do
+        expect(inventory_unit).to receive(:return!)
+        legacy_return_authorization.receive!
+      end
+
+      it "should add credit for specified amount" do
+        legacy_return_authorization.amount = 20
+        expect(Spree::Adjustment).to receive(:create).with(adjustable: order, amount: -20, label: Spree.t(:legacy_rma_credit), source: legacy_return_authorization)
+        legacy_return_authorization.receive!
+      end
+
+      it "should update order state" do
+        expect(order).to receive :update!
+        legacy_return_authorization.receive!
+      end
+
+      context 'with Config.track_inventory_levels == true' do
+        before { Spree::Config.track_inventory_levels = true }
+
+        it "should update the stock item counts in the stock location" do
+          count_on_hand = inventory_unit.find_stock_item.count_on_hand
+          legacy_return_authorization.receive!
+          expect(inventory_unit.find_stock_item.count_on_hand).to eq(count_on_hand + 1)
+        end
+      end
+
+      context 'with Config.track_inventory_levels == false' do
+        before do
+          expect(Spree::StockItem).not_to receive(:find_by)
+          expect(Spree::StockMovement).not_to receive(:create!)
+          Spree::Config.track_inventory_levels = false
+        end
+
+        it "should NOT update the stock item counts in the stock location" do
+          count_on_hand = inventory_unit.find_stock_item.count_on_hand
+          legacy_return_authorization.receive!
+          expect(inventory_unit.find_stock_item.count_on_hand).to eql count_on_hand
+        end
+      end
+    end
+
+    context "to a different stock location" do
+      let(:new_stock_location) { FactoryGirl.create(:stock_location, :name => "other") }
+
+      before do
+        allow(legacy_return_authorization).to receive_messages(:stock_location_id => new_stock_location.id)
+        allow(legacy_return_authorization).to receive_messages(:inventory_units => [inventory_unit], :amount => -20)
+        Spree::Config.track_inventory_levels = true
+      end
+
+      it "should update the stock item counts in new stock location" do
+        count_on_hand = Spree::StockItem.where(variant_id: inventory_unit.variant_id, stock_location_id: new_stock_location.id).first.count_on_hand
+        legacy_return_authorization.receive!
+        expect(Spree::StockItem.where(variant_id: inventory_unit.variant_id, stock_location_id: new_stock_location.id).first.count_on_hand).to eq(count_on_hand + 1)
+      end
+
+      it "should NOT raise an error when no stock item exists in the stock location" do
+        inventory_unit.find_stock_item.destroy
+        expect { legacy_return_authorization.receive! }.not_to raise_error
+      end
+
+      it "should not update the stock item counts in the original stock location" do
+        count_on_hand = inventory_unit.find_stock_item.count_on_hand
+        legacy_return_authorization.receive!
+        expect(inventory_unit.find_stock_item.count_on_hand).to eq(count_on_hand)
+      end
+    end
+  end
+
+  context "force_positive_amount" do
+    it "should ensure the amount is always positive" do
+      legacy_return_authorization.amount = -10
+      legacy_return_authorization.send :force_positive_amount
+      expect(legacy_return_authorization.amount).to eq(10)
+    end
+  end
+
+  context "after_save" do
+    it "should run correct callbacks" do
+      expect(legacy_return_authorization).to receive(:force_positive_amount)
+      legacy_return_authorization.run_callbacks(:save)
+    end
+  end
+
+  context "currency" do
+    before { allow(order).to receive(:currency) { "ABC" } }
+    it "returns the order currency" do
+      expect(legacy_return_authorization.currency).to eq("ABC")
+    end
+  end
+
+  context "display_amount" do
+    it "returns a Spree::Money" do
+      legacy_return_authorization.amount = 21.22
+      expect(legacy_return_authorization.display_amount).to eq(Spree::Money.new(21.22))
+    end
+  end
+
+  context "returnable_inventory" do
+    skip "should return inventory from shipped shipments" do
+      expect(legacy_return_authorization.returnable_inventory).to eq([inventory_unit])
+    end
+
+    skip "should not return inventory from unshipped shipments" do
+      expect(legacy_return_authorization.returnable_inventory).to eq([])
+    end
+  end
+
+  context "destroy" do
+    before do
+      legacy_return_authorization.add_variant(variant.id, 1)
+      legacy_return_authorization.destroy
+    end
+
+    # Regression test for https://github.com/spree/spree/issues/4935
+    it "disassociates inventory units" do
+      expect(Spree::InventoryUnit.where(legacy_return_authorization_id: legacy_return_authorization.id).count).to eq 0
+    end
+  end
+end

data/spec/models/spree/permission_sets/legacy_return_authorization_display_spec.rb

@@ -0,0 +1,22 @@
+require 'spec_helper'
+
+describe Spree::PermissionSets::LegacyReturnAuthorizationDisplay do
+  let(:ability) { Spree::Ability.new nil }
+
+  subject { ability }
+
+  context "when activated" do
+    before do
+      described_class.new(ability).activate!
+    end
+
+    it { should be_able_to(:display, Spree::LegacyReturnAuthorization) }
+    it { should be_able_to(:admin, Spree::LegacyReturnAuthorization) }
+  end
+
+  context "when not activated" do
+    it { should_not be_able_to(:display, Spree::LegacyReturnAuthorization) }
+    it { should_not be_able_to(:admin, Spree::LegacyReturnAuthorization) }
+  end
+end
+

data/spec/models/spree/permission_sets/legacy_return_authorization_management_spec.rb

@@ -0,0 +1,20 @@
+require 'spec_helper'
+
+describe Spree::PermissionSets::LegacyReturnAuthorizationManagement do
+  let(:ability) { Spree::Ability.new nil }
+
+  subject { ability }
+
+  context "when activated" do
+    before do
+      described_class.new(ability).activate!
+    end
+
+    it { should be_able_to(:manage, Spree::LegacyReturnAuthorization) }
+  end
+
+  context "when not activated" do
+    it { should_not be_able_to(:manage, Spree::LegacyReturnAuthorization) }
+  end
+end
+

data/spec/spec_helper.rb

@@ -0,0 +1,74 @@
+# Run Coverage report
+require 'simplecov'
+SimpleCov.start do
+  add_filter 'spec/dummy'
+  add_group 'Controllers', 'app/controllers'
+  add_group 'Helpers', 'app/helpers'
+  add_group 'Mailers', 'app/mailers'
+  add_group 'Models', 'app/models'
+  add_group 'Views', 'app/views'
+  add_group 'Libraries', 'lib'
+end
+
+# Configure Rails Environment
+ENV['RAILS_ENV'] = 'test'
+
+require File.expand_path('../dummy/config/environment.rb',  __FILE__)
+
+require 'rspec/rails'
+
+require 'database_cleaner'
+require 'ffaker'
+
+require 'spree/testing_support/factories'
+require 'spree/testing_support/controller_requests'
+require 'spree/testing_support/authorization_helpers'
+require 'spree/testing_support/url_helpers'
+
+require 'spree/api/testing_support/helpers'
+require 'cancan/matchers'
+
+require 'spree_legacy_return_authorizations/factories'
+
+Dir[File.join(File.dirname(__FILE__), 'support/**/*.rb')].each { |f| require f }
+
+RSpec.configure do |config|
+  config.infer_spec_type_from_file_location!
+  config.mock_with :rspec
+
+  config.color = true
+  config.order = "random"
+
+  config.expose_current_running_example_as :example
+  config.fail_fast = ENV["FAIL_FAST"] || false
+
+  config.filter_run focus: true
+  config.run_all_when_everything_filtered = true
+  config.use_transactional_fixtures = false
+
+  config.include FactoryGirl::Syntax::Methods
+  config.include Spree::TestingSupport::ControllerRequests, type: :controller
+  config.include Spree::TestingSupport::UrlHelpers, type: :controller
+  config.include Spree::Api::TestingSupport::Helpers, type: :controller
+  config.include AuthenticationSupport, type: :controller
+
+  # Ensure Suite is set to use transactions for speed.
+  config.before :suite do
+    DatabaseCleaner.strategy = :transaction
+    DatabaseCleaner.clean_with :truncation
+  end
+
+  # Before each spec check if it is a Javascript test and switch between using database transactions or not where necessary.
+  config.before :each do
+    DatabaseCleaner.strategy = example.metadata[:js] ? :truncation : :transaction
+    DatabaseCleaner.start
+
+    Spree::Config.reset
+    Spree::Api::Config[:requires_authentication] = true
+  end
+
+  # After each spec clean the database.
+  config.after :each do
+    DatabaseCleaner.clean
+  end
+end

data/spec/support/authentication_support.rb

@@ -0,0 +1,7 @@
+module AuthenticationSupport
+  def stub_api_controller_authentication!(options={})
+    @current_api_user = options[:admin] ? create(:admin_user) : create(:user)
+    allow(controller).to receive(:load_user)
+    controller.instance_variable_set(:@current_api_user, @current_api_user)
+  end
+end

data/spec/support/have_attributes_matcher.rb

@@ -0,0 +1,8 @@
+RSpec::Matchers.define :have_attributes do |expected_attributes|
+  match do |actual|
+    # actual is a Hash object representing an object, like this:
+    # { "name" => "Product #1" }
+    actual_attributes = actual.keys.map(&:to_sym)
+    expected_attributes.map(&:to_sym).all? { |attr| actual_attributes.include?(attr) }
+  end
+end

metadata

@@ -0,0 +1,245 @@
+--- !ruby/object:Gem::Specification
+name: solidus_legacy_return_authorizations
+version: !ruby/object:Gem::Version
+  version: 1.0.0
+platform: ruby
+authors:
+- Richard Nuno
+- Jordan Brough
+autorequire: 
+bindir: bin
+cert_chain: []
+date: 2015-08-27 00:00:00.000000000 Z
+dependencies:
+- !ruby/object:Gem::Dependency
+  name: solidus_core
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 1.0.0
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: 1.2.0
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 1.0.0
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: 1.2.0
+- !ruby/object:Gem::Dependency
+  name: rspec-rails
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.2'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.2'
+- !ruby/object:Gem::Dependency
+  name: simplecov
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: sqlite3
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: sass-rails
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 4.0.2
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 4.0.2
+- !ruby/object:Gem::Dependency
+  name: coffee-rails
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: capybara
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.1'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.1'
+- !ruby/object:Gem::Dependency
+  name: factory_girl
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '4.4'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '4.4'
+- !ruby/object:Gem::Dependency
+  name: database_cleaner
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: ffaker
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+description: Provides models and admin interfaces to interact with the LegacyReturnAuthorization
+  models from Spree versions prior to 2.4
+email: 
+executables: []
+extensions: []
+extra_rdoc_files: []
+files:
+- ".gitignore"
+- ".rspec"
+- Gemfile
+- LICENSE
+- README.md
+- Rakefile
+- app/assets/javascripts/spree/backend/solidus_legacy_return_authorizations.js
+- app/assets/stylesheets/spree/backend/solidus_legacy_return_authorizations.css
+- app/controllers/spree/admin/legacy_return_authorizations_controller.rb
+- app/controllers/spree/api/legacy_return_authorizations_controller.rb
+- app/helpers/spree/admin/navigation_helper_decorator.rb
+- app/helpers/spree/api/api_helpers_decorator.rb
+- app/models/spree/adjustment_decorator.rb
+- app/models/spree/inventory_unit_decorator.rb
+- app/models/spree/legacy_return_authorization.rb
+- app/models/spree/order_decorator.rb
+- app/models/spree/permission_sets/legacy_return_authorization_display.rb
+- app/models/spree/permission_sets/legacy_return_authorization_management.rb
+- app/models/spree/strong_parameters_decorator.rb
+- app/overrides/admin_legacy_return_authorizations.rb
+- app/views/spree/admin/legacy_return_authorizations/_form.html.erb
+- app/views/spree/admin/legacy_return_authorizations/edit.html.erb
+- app/views/spree/admin/legacy_return_authorizations/index.html.erb
+- app/views/spree/api/legacy_return_authorizations/index.v1.rabl
+- app/views/spree/api/legacy_return_authorizations/new.v1.rabl
+- app/views/spree/api/legacy_return_authorizations/show.v1.rabl
+- bin/rails
+- circle.yml
+- config/locales/en.yml
+- config/routes.rb
+- db/migrate/20140710044402_create_spree_legacy_return_authorizations.rb
+- lib/generators/solidus_legacy_return_authorizations/install/install_generator.rb
+- lib/solidus_legacy_return_authorizations.rb
+- lib/spree_legacy_return_authorizations/engine.rb
+- lib/spree_legacy_return_authorizations/factories.rb
+- solidus_legacy_return_authorizations.gemspec
+- spec/controllers/admin/legacy_return_authorizations_controller_spec.rb
+- spec/controllers/spree/api/legacy_return_authorizations_controller_spec.rb
+- spec/features/admin/orders/legacy_return_authorizations_spec.rb
+- spec/models/spree/legacy_return_authorization_spec.rb
+- spec/models/spree/permission_sets/legacy_return_authorization_display_spec.rb
+- spec/models/spree/permission_sets/legacy_return_authorization_management_spec.rb
+- spec/spec_helper.rb
+- spec/support/authentication_support.rb
+- spec/support/have_attributes_matcher.rb
+homepage: 
+licenses: []
+metadata: {}
+post_install_message: 
+rdoc_options: []
+require_paths:
+- lib
+required_ruby_version: !ruby/object:Gem::Requirement
+  requirements:
+  - - ">="
+    - !ruby/object:Gem::Version
+      version: '2.1'
+required_rubygems_version: !ruby/object:Gem::Requirement
+  requirements:
+  - - ">="
+    - !ruby/object:Gem::Version
+      version: '0'
+requirements:
+- none
+rubyforge_project: 
+rubygems_version: 2.2.5
+signing_key: 
+specification_version: 4
+summary: Interfaces for Spree 2.3 Legacy Return Authorizations
+test_files:
+- spec/controllers/admin/legacy_return_authorizations_controller_spec.rb
+- spec/controllers/spree/api/legacy_return_authorizations_controller_spec.rb
+- spec/features/admin/orders/legacy_return_authorizations_spec.rb
+- spec/models/spree/legacy_return_authorization_spec.rb
+- spec/models/spree/permission_sets/legacy_return_authorization_display_spec.rb
+- spec/models/spree/permission_sets/legacy_return_authorization_management_spec.rb
+- spec/spec_helper.rb
+- spec/support/authentication_support.rb
+- spec/support/have_attributes_matcher.rb