solidus_graphql_api 0.1.0 → 0.3.0

data/spec/integration/queries/current_user_spec.rb

@@ -12,8 +12,13 @@ RSpec.describe_query :current_user, query: :current_user, freeze_date: true do
            bill_address: bill_address)
   }
 
-  let(:ship_address) { create(:ship_address, id: 1, zipcode: 10_001) }
-  let(:bill_address) { create(:bill_address, id: 2, zipcode: 10_002) }
+  # Previos to Solidus v3.3, states_required was always false and the state was
+  # always automatically assigned. We force the behavior here to have the same
+  # response for any Solidus version.
+  let(:country) { create(:country, states_required: false) }
+  let(:state) { create(:state, name: "Alabama", abbr: "AL", country: country) }
+  let(:ship_address) { create(:ship_address, id: 1, zipcode: 10_001, country: country, state: state) }
+  let(:bill_address) { create(:bill_address, id: 2, zipcode: 10_002, country: country, state: state) }
   let(:credit_card) {
     create(:credit_card,
            user: user,

data/spec/integration/queries/products_spec.rb

@@ -24,7 +24,10 @@ RSpec.describe_query :products, query: :products, freeze_date: true do
       let!(:solidus_tote) { create(:product, name: 'Solidus Tote', id: 4, price: 15.99) }
 
       context 'when no query is passed' do
-        it { is_expected.to match_array([{ id: solidus_t_shirt.id }, { id: ruby_mug.id }, { id: solidus_mug.id }, { id: solidus_tote.id }]) }
+        it {
+          expect(subject).to match_array([{ id: solidus_t_shirt.id }, { id: ruby_mug.id }, { id: solidus_mug.id },
+                                          { id: solidus_tote.id }])
+        }
       end
 
       context 'when a query is passed' do

data/spec/integration/queries/taxonomies_spec.rb

@@ -9,14 +9,22 @@ RSpec.describe_query :taxonomies do
     end
 
     context 'when taxonomies exists' do
-      let!(:brand_taxonomy) { create(:taxonomy, :with_taxon_meta, id: 1, root_taxon_id: 1) }
-      let!(:category_taxonomy) { create(:taxonomy, id: 2, name: 'Category', root_taxon_id: 2) }
+      let!(:brand_taxonomy) do
+        create(:taxonomy, :with_taxon_meta, :with_root_icon, id: 1, name: "Brand", root_taxon_id: 1)
+      end
+      let!(:category_taxonomy) { create(:taxonomy, :with_root_icon, id: 2, name: 'Category', root_taxon_id: 2) }
+      # Need to reload taxon to get the correct icon url, because the icon is attached after the taxon is created
+      let!(:taxon) { create(:taxon, :with_icon, id: 3, name: 'Solidus', taxonomy: brand_taxonomy).tap(&:reload) }
 
       before do
-        create(:taxon, id: 3, name: 'Solidus', parent: brand_taxonomy.root, taxonomy: brand_taxonomy)
+        taxon.update(parent: brand_taxonomy.root)
       end
 
-      it { is_expected.to match_response(:taxonomies) }
+      it {
+        expect(subject).to match_response(:taxonomies).with_args(brand_url: brand_taxonomy.taxons.first.icon.url,
+                                                                 category_url: category_taxonomy.taxons.first.icon.url,
+                                                                 taxon_url: taxon.icon.url)
+      }
     end
   end
 end

data/spec/integration/types/json_spec.rb

@@ -0,0 +1,17 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+RSpec.describe 'JSON type' do
+  it 'coerces JSON custom type', type: :feature do
+    create(:product, name: 'Shirt')
+
+    post '/graphql',
+      params: {
+        query: "{ products(query: { search: { name_cont: \"Shirt\" } }) { nodes { name } } }"
+      },
+      headers: headers
+
+    expect(JSON.parse(response.body).dig(*%w[data products nodes])[0]['name']).to eq('Shirt')
+  end
+end

data/spec/lib/solidus_graphql_api/batch_loader/belongs_to_spec.rb

@@ -2,7 +2,9 @@
 
 require 'spec_helper'
 
-RSpec.describe SolidusGraphqlApi::BatchLoader::BelongsTo do
+RSpec.describe SolidusGraphqlApi::BatchLoader::BelongsTo, skip: (ENV["DB"] == "mysql") do
+  include Helpers::ActiveRecord
+
   subject(:loader) do
     described_class.new(
       object,
@@ -14,19 +16,21 @@ RSpec.describe SolidusGraphqlApi::BatchLoader::BelongsTo do
   let(:options) { {} }
 
   context 'with a regular association' do
-    with_model :Article, scope: :all do
-      model do
-        has_many :comments
+    before do
+      run_migrations do
+        create_table :articles, force: true
+        create_table :comments, force: true do |t|
+          t.belongs_to :article
+        end
       end
+      create_model("Article")
+      create_model("Comment") { belongs_to :article }
     end
 
-    with_model :Comment, scope: :all do
-      table do |t|
-        t.belongs_to :article
-      end
-
-      model do
-        belongs_to :article
+    after do
+      run_migrations do
+        drop_table :articles
+        drop_table :comments
       end
     end
 
@@ -39,21 +43,16 @@ RSpec.describe SolidusGraphqlApi::BatchLoader::BelongsTo do
   end
 
   context 'with a polymorphic association' do
-    with_model :Image, scope: :all do
-      table do |t|
-        t.integer :imageable_id
-        t.string :imageable_type
-      end
-
-      model do
-        belongs_to :imageable, polymorphic: true
-      end
-    end
-
-    with_model :Article, scope: :all do
-      model do
-        has_many :images, as: :imageable
+    before do
+      run_migrations do
+        create_table :images, force: true do |t|
+          t.integer :imageable_id
+          t.string :imageable_type
+        end
+        create_table :articles, force: true
       end
+      create_model("Image") { belongs_to :imageable, polymorphic: true }
+      create_model("Article") { has_many :images, as: :imageable }
     end
 
     let!(:object) { Image.create!(imageable: Article.create!) }

data/spec/lib/solidus_graphql_api/batch_loader/has_many_spec.rb

@@ -2,7 +2,9 @@
 
 require 'spec_helper'
 
-RSpec.describe SolidusGraphqlApi::BatchLoader::HasMany do
+RSpec.describe SolidusGraphqlApi::BatchLoader::HasMany, skip: (ENV["DB"] == "mysql") do
+  include Helpers::ActiveRecord
+
   subject(:loader) do
     described_class.new(
       article,
@@ -10,28 +12,28 @@ RSpec.describe SolidusGraphqlApi::BatchLoader::HasMany do
     )
   end
 
-  with_model :Article, scope: :all do
-    model do
-      has_many :comments
+  before do
+    run_migrations do
+      create_table :articles, force: true
+      create_table :comments, force: true do |t|
+        t.belongs_to :article
+      end
     end
-  end
+    create_model("Article") { has_many :comments }
+    create_model("Comment") { belongs_to :article }
 
-  with_model :Comment, scope: :all do
-    table do |t|
-      t.belongs_to :article
-    end
+    article.comments.create!
+  end
 
-    model do
-      belongs_to :article
+  after do
+    run_migrations do
+      drop_table :articles
+      drop_table :comments
     end
   end
 
   let!(:article) { Article.create! }
 
-  before do
-    article.comments.create!
-  end
-
   it 'loads the association properly' do
     expect(loader.load.sync).to eq(article.comments)
   end

data/spec/lib/solidus_graphql_api/batch_loader/has_many_through_spec.rb

@@ -2,46 +2,63 @@
 
 require 'spec_helper'
 
-RSpec.describe SolidusGraphqlApi::BatchLoader::HasManyThrough do
+RSpec.describe SolidusGraphqlApi::BatchLoader::HasManyThrough, skip: (ENV["DB"] == "mysql") do
+  include Helpers::ActiveRecord
+
   subject(:loader) do
     described_class.new(
-      article,
-      Article.reflect_on_association(:comment_authors)
+      physician,
+      Physician.reflect_on_association(:patients)
     )
   end
 
-  with_model :Article, scope: :all do
-    model do
-      has_many :comments
-      has_many :comment_authors, through: :comments, source: :author
+  before do
+    run_migrations do
+      create_table :physicians, force: true
+      create_table :patients, force: true
+      create_table :appointments, force: true do |t|
+        t.belongs_to :physician
+        t.belongs_to :patient
+      end
     end
-  end
-
-  with_model :Comment, scope: :all do
-    table do |t|
-      t.belongs_to :article
-      t.belongs_to :author
+    create_model("Physician") do
+      has_many :appointments
+      has_many :patients, through: :appointments
     end
-
-    model do
-      belongs_to :article
-      belongs_to :author
+    create_model("Patient") do
+      has_many :appointments
+    end
+    create_model("Appointment") do
+      belongs_to :physician
+      belongs_to :patient
     end
+
+    physician.appointments.create!(patient: Patient.create!)
   end
 
-  with_model :Author, scope: :all do
-    model do
-      has_many :comments
+  after do
+    run_migrations do
+      drop_table :physicians
+      drop_table :patients
+      drop_table :appointments
     end
   end
 
-  let!(:article) { Article.create! }
+  let!(:physician) { Physician.create! }
 
-  before do
-    article.comments.create!(author: Author.create!)
+  it 'loads the association properly' do
+    expect(loader.load.sync).to eq(physician.patients)
   end
 
-  it 'loads the association properly' do
-    expect(loader.load.sync).to eq(article.comment_authors)
+  it "doesn't duplicate result when another record loaded in the batch is also associated to the same target record" do
+    second_physician = Physician.create!
+    Appointment.create!(patient: physician.patients.first, physician: second_physician)
+
+    described_class.new(
+      second_physician,
+      Physician.reflect_on_association(:patients)
+    ).load
+
+    expect(loader.load.sync.length).to be(1)
   end
 end

data/spec/lib/solidus_graphql_api/batch_loader/has_one_spec.rb

@@ -2,7 +2,9 @@
 
 require 'spec_helper'
 
-RSpec.describe SolidusGraphqlApi::BatchLoader::HasOne do
+RSpec.describe SolidusGraphqlApi::BatchLoader::HasOne, skip: (ENV["DB"] == "mysql") do
+  include Helpers::ActiveRecord
+
   subject(:loader) do
     described_class.new(
       article,
@@ -10,28 +12,28 @@ RSpec.describe SolidusGraphqlApi::BatchLoader::HasOne do
     )
   end
 
-  with_model :Article, scope: :all do
-    model do
-      has_one :image
+  before do
+    run_migrations do
+      create_table :articles, force: true
+      create_table :images, force: true do |t|
+        t.belongs_to :article
+      end
     end
-  end
+    create_model("Article") { has_one :image }
+    create_model("Image") { belongs_to :article }
 
-  with_model :Image, scope: :all do
-    table do |t|
-      t.belongs_to :article
-    end
+    article.create_image!
+  end
 
-    model do
-      belongs_to :article
+  after do
+    run_migrations do
+      drop_table :articles
+      drop_table :images
     end
   end
 
   let!(:article) { Article.create! }
 
-  before do
-    article.create_image!
-  end
-
   it 'loads the association properly' do
     expect(loader.load.sync).to eq(article.image)
   end

data/spec/lib/solidus_graphql_api/context_spec.rb

@@ -7,7 +7,10 @@ RSpec.describe SolidusGraphqlApi::Context do
 
   let(:headers) do
     headers_hash = {}
-    headers_hash['Authorization'] = "Bearer #{authorization_token}" if defined?(authorization_token) && authorization_token
+    if defined?(authorization_token) && authorization_token
+      headers_hash['Authorization'] =
+        "Bearer #{authorization_token}"
+    end
     headers_hash['X-Spree-Order-Token'] = order_token if defined?(order_token) && order_token
     headers_hash
   end
@@ -55,8 +58,62 @@ RSpec.describe SolidusGraphqlApi::Context do
   describe '#current_user' do
     subject { schema_context.current_user }
 
-    context 'when headers do not contains the authorization token' do
-      it { is_expected.to be_nil }
+    context 'when headers do not contain the authorization token' do
+      context "and there's no user with nil or empty spree_api_key" do
+        it { is_expected.to be_nil }
+      end
+
+      context "and there's a user with nil spree_api_key" do
+        before { FactoryBot.create(:user, spree_api_key: nil) }
+
+        it { is_expected.to be_nil }
+      end
+
+      context "and there's a user with empty string as spree_api_key" do
+        before { FactoryBot.create(:user, spree_api_key: '') }
+
+        it { is_expected.to be_nil }
+      end
+    end
+
+    context 'when headers contain an empty authorization token' do
+      let(:authorization_token) { '' }
+
+      context "and there's no user with nil or empty spree_api_key" do
+        it { is_expected.to be_nil }
+      end
+
+      context "and there's a user with nil spree_api_key" do
+        before { FactoryBot.create(:user, spree_api_key: nil) }
+
+        it { is_expected.to be_nil }
+      end
+
+      context "and there's a user with empty string as spree_api_key" do
+        before { FactoryBot.create(:user, spree_api_key: '') }
+
+        it { is_expected.to be_nil }
+      end
+    end
+
+    context "when headers contain a authorization header that doesn't match" do
+      let(:headers) { { 'Authorization' => 'abc' } }
+
+      context "and there's no user with nil or empty spree_api_key" do
+        it { is_expected.to be_nil }
+      end
+
+      context "and there's a user with nil spree_api_key" do
+        before { FactoryBot.create(:user, spree_api_key: nil) }
+
+        it { is_expected.to be_nil }
+      end
+
+      context "and there's a user with empty string as spree_api_key" do
+        before { FactoryBot.create(:user, spree_api_key: '') }
+
+        it { is_expected.to be_nil }
+      end
     end
 
     context 'when headers contains the authorization token' do
@@ -171,8 +228,12 @@ RSpec.describe SolidusGraphqlApi::Context do
       end
 
       context 'when the current user has many incompleted orders in the current store' do
-        let!(:first_created_order) { create :order, user: current_user, store: current_store, created_at: Time.zone.yesterday }
-        let!(:last_created_order) { create :order, user: current_user, store: current_store, created_at: Time.zone.today }
+        let!(:first_created_order) {
+          create :order, user: current_user, store: current_store, created_at: Time.zone.yesterday
+        }
+        let!(:last_created_order) {
+          create :order, user: current_user, store: current_store, created_at: Time.zone.today
+        }
 
         it { is_expected.to eq last_created_order }
       end
@@ -228,9 +289,61 @@ RSpec.describe SolidusGraphqlApi::Context do
         it { is_expected.to be_nil }
       end
 
+      # Need to bypass application layer to reproduce race database state
+      # rubocop:disable Rails/SkipsModelValidations
       context 'when is provided no order token' do
-        it { is_expected.to be_nil }
+        context "and there's no order with nil or empty guest_token" do
+          it { is_expected.to be_nil }
+        end
+
+        context "and there's an order with nil guest_token" do
+          before do
+            order = FactoryBot.create(:order)
+            order.update_column(:guest_token, nil)
+          end
+
+          it { is_expected.to be_nil }
+        end
+
+        context "and there's an order with empty string as guest_token" do
+          before do
+            order = FactoryBot.create(:order)
+            order.update_column(:guest_token, '')
+          end
+
+          it { is_expected.to be_nil }
+        end
+      end
+      # rubocop:enable Rails/SkipsModelValidations
+
+      # Need to bypass application layer to reproduce race database state
+      # rubocop:disable Rails/SkipsModelValidations
+      context 'when is provided an empty order token' do
+        let(:order_token) { '' }
+
+        context "and there's no order with nil or empty guest_token" do
+          it { is_expected.to be_nil }
+        end
+
+        context "and there's an order with nil guest_token" do
+          before do
+            order = FactoryBot.create(:order)
+            order.update_column(:guest_token, nil)
+          end
+
+          it { is_expected.to be_nil }
+        end
+
+        context "and there's an order with empty string as guest_token" do
+          before do
+            order = FactoryBot.create(:order)
+            order.update_column(:guest_token, '')
+          end
+
+          it { is_expected.to be_nil }
+        end
       end
+      # rubocop:enable Rails/SkipsModelValidations
     end
   end
 end

data/spec/lib/solidus_graphql_api/queries/option_value/option_type_query_spec.rb

@@ -0,0 +1,10 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+RSpec.describe SolidusGraphqlApi::Queries::OptionValue::OptionTypeQuery do
+  let(:option_type) { create(:option_type) }
+  let(:option_value) { create(:option_value, option_type: option_type) }
+
+  it { expect(described_class.new(option_value: option_value).call.sync).to eq(option_type) }
+end

data/spec/lib/solidus_graphql_api/queries/shipping_rate/shipping_method_query_spec.rb

@@ -0,0 +1,11 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+RSpec.describe SolidusGraphqlApi::Queries::ShippingRate::ShippingMethodQuery do
+  let(:shipping_method) { create(:shipping_method) }
+
+  let(:shipping_rate) { create(:shipping_rate, shipping_method: shipping_method) }
+
+  it { expect(described_class.new(shipping_rate: shipping_rate).call.sync).to eq(shipping_method) }
+end

data/spec/lib/solidus_graphql_api/queries/taxon/children_query_spec.rb

@@ -3,9 +3,13 @@
 require 'spec_helper'
 
 RSpec.describe SolidusGraphqlApi::Queries::Taxon::ChildrenQuery do
-  let(:taxon) { create(:taxon) }
-
-  let!(:children) { create_list(:taxon, 2, parent: taxon) }
-
-  it { expect(described_class.new(taxon: taxon).call.sync).to match_array(children) }
+  it do
+    taxonomy = create(:taxonomy)
+    root = taxonomy.root
+    children = [
+      create(:taxon, name: "Taxon one", parent: root),
+      create(:taxon, name: "Taxon two", parent: root)
+    ]
+    expect(described_class.new(taxon: root).call.sync).to match_array(children)
+  end
 end

data/spec/lib/solidus_graphql_api/queries/taxonomy/taxons_query_spec.rb

@@ -3,9 +3,12 @@
 require 'spec_helper'
 
 RSpec.describe SolidusGraphqlApi::Queries::Taxonomy::TaxonsQuery do
-  let(:taxons) { build_list(:taxon, 2) }
-
-  let(:taxonomy) { create(:taxonomy, taxons: taxons) }
-
-  it { expect(described_class.new(taxonomy: taxonomy).call.sync).to match_array(taxons) }
+  it do
+    taxonomy = create(:taxonomy)
+    root_taxon = taxonomy.root
+    taxon = create(:taxon, taxonomy: taxonomy, parent: root_taxon)
+    create(:taxon)
+
+    expect(described_class.new(taxonomy: taxonomy).call.sync).to match_array([root_taxon, taxon])
+  end
 end

data/spec/lib/solidus_graphql_api/queries/variant/default_price_query_spec.rb

@@ -5,5 +5,5 @@ require 'spec_helper'
 RSpec.describe SolidusGraphqlApi::Queries::Variant::DefaultPriceQuery do
   let(:variant) { create(:variant) }
 
-  it { expect(described_class.new(variant: variant).call.sync).to eq(variant.default_price) }
+  it { expect(described_class.new(variant: variant).call).to eq(variant.default_price) }
 end

data/spec/lib/solidus_graphql_api/types/base/object_spec.rb

@@ -3,7 +3,11 @@
 require 'spec_helper'
 
 RSpec.describe SolidusGraphqlApi::Types::Base::Object do
-  subject { Class.new(described_class) }
+  subject do
+    Class.new(described_class) do
+      graphql_name :test
+    end
+  end
 
   describe '.remove_field' do
     context 'when the field is defined' do

data/spec/lib/solidus_graphql_api/types/json_spec.rb

@@ -37,7 +37,8 @@ RSpec.describe SolidusGraphqlApi::Types::Json do
         hash_array: [
           {
             ids_array: [
-              'U3ByZWU6OlByb21vdGlvbkFjdGlvbi02', 'U3ByZWU6OlByb21vdGlvbkFjdGlvbi04' # Spree::PromotionAction-6, Spree::PromotionAction-8
+              'U3ByZWU6OlByb21vdGlvbkFjdGlvbi02',
+              'U3ByZWU6OlByb21vdGlvbkFjdGlvbi04' # Spree::PromotionAction-6, Spree::PromotionAction-8
             ],
             ids_hash: {
               id: 'U3ByZWU6OkFkanVzdG1lbnQtNQ==', # Spree::Adjustment-5

data/spec/lib/solidus_graphql_api/types/option_value_spec.rb

@@ -0,0 +1,22 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+RSpec.describe SolidusGraphqlApi::Types::OptionValue do
+  let(:option_value) { create(:option_value) }
+  let(:query_object) { spy(:query_object) }
+
+  subject { described_class.send(:new, option_value, {}) }
+
+  describe '#option_type' do
+    before do
+      allow(SolidusGraphqlApi::Queries::OptionValue::OptionTypeQuery).
+        to receive(:new).with(option_value: option_value).
+        and_return(query_object)
+    end
+
+    after { subject.option_type }
+
+    it { expect(query_object).to receive(:call) }
+  end
+end

data/spec/lib/solidus_graphql_api/types/product_spec.rb

@@ -34,7 +34,9 @@ RSpec.describe SolidusGraphqlApi::Types::Product do
 
   describe '#product_properties' do
     before do
-      allow(SolidusGraphqlApi::Queries::Product::ProductPropertiesQuery).to receive(:new).with(product: product).and_return(query_object)
+      allow(SolidusGraphqlApi::Queries::Product::ProductPropertiesQuery).
+        to receive(:new).with(product: product).
+        and_return(query_object)
     end
 
     after { subject.product_properties }

data/spec/lib/solidus_graphql_api/types/query_spec.rb

@@ -24,7 +24,9 @@ RSpec.describe SolidusGraphqlApi::Types::Query do
 
     let(:slug) { 'slug' }
 
-    before { allow(SolidusGraphqlApi::Queries::ProductBySlugQuery).to receive(:new).with(no_args).and_return(query_object) }
+    before {
+      allow(SolidusGraphqlApi::Queries::ProductBySlugQuery).to receive(:new).with(no_args).and_return(query_object)
+    }
 
     after { subject.product_by_slug(slug: slug) }
 

data/spec/lib/solidus_graphql_api/types/shipping_rate_spec.rb

@@ -0,0 +1,22 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+RSpec.describe SolidusGraphqlApi::Types::ShippingRate do
+  let(:shipping_rate) { create(:shipping_rate) }
+  let(:query_object) { spy(:query_object) }
+
+  subject { described_class.send(:new, shipping_rate, {}) }
+
+  describe '#shipping_method' do
+    before do
+      allow(SolidusGraphqlApi::Queries::ShippingRate::ShippingMethodQuery).
+        to receive(:new).with(shipping_rate: shipping_rate).
+        and_return(query_object)
+    end
+
+    after { subject.shipping_method }
+
+    it { expect(query_object).to receive(:call) }
+  end
+end