solidus_graphql_api 0.1.0 → 0.2.0

data/spec/integration/types/json_spec.rb

@@ -0,0 +1,17 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+RSpec.describe 'JSON type' do
+  it 'coerces JSON custom type', type: :feature do
+    create(:product, name: 'Shirt')
+
+    post '/graphql',
+      params: {
+        query: "{ products(query: { search: { name_cont: \"Shirt\" } }) { nodes { name } } }"
+      },
+      headers: headers
+
+    expect(JSON.parse(response.body).dig(*%w[data products nodes])[0]['name']).to eq('Shirt')
+  end
+end

data/spec/lib/solidus_graphql_api/batch_loader/has_many_through_spec.rb

@@ -5,43 +5,55 @@ require 'spec_helper'
 RSpec.describe SolidusGraphqlApi::BatchLoader::HasManyThrough do
   subject(:loader) do
     described_class.new(
-      article,
-      Article.reflect_on_association(:comment_authors)
+      physician,
+      Physician.reflect_on_association(:patients)
     )
   end
 
-  with_model :Article, scope: :all do
+  with_model :Physician, scope: :all do
     model do
-      has_many :comments
-      has_many :comment_authors, through: :comments, source: :author
+      has_many :appointments
+      has_many :patients, through: :appointments
     end
   end
 
-  with_model :Comment, scope: :all do
+  with_model :Appointment, scope: :all do
     table do |t|
-      t.belongs_to :article
-      t.belongs_to :author
+      t.belongs_to :physician, index: { name: :appointment_on_physician }
+      t.belongs_to :patient
     end
 
     model do
-      belongs_to :article
-      belongs_to :author
+      belongs_to :physician
+      belongs_to :patient
     end
   end
 
-  with_model :Author, scope: :all do
+  with_model :Patient, scope: :all do
     model do
-      has_many :comments
+      has_many :appointments
     end
   end
 
-  let!(:article) { Article.create! }
+  let!(:physician) { Physician.create! }
 
   before do
-    article.comments.create!(author: Author.create!)
+    physician.appointments.create!(patient: Patient.create!)
   end
 
   it 'loads the association properly' do
-    expect(loader.load.sync).to eq(article.comment_authors)
+    expect(loader.load.sync).to eq(physician.patients)
+  end
+
+  it "doesn't duplicate result when another record loaded in the batch is also associated to the same target record" do
+    second_physician = Physician.create!
+    Appointment.create!(patient: physician.patients.first, physician: second_physician)
+
+    described_class.new(
+      second_physician,
+      Physician.reflect_on_association(:patients)
+    ).load
+
+    expect(loader.load.sync.length).to be(1)
   end
 end

data/spec/lib/solidus_graphql_api/context_spec.rb

@@ -7,7 +7,10 @@ RSpec.describe SolidusGraphqlApi::Context do
 
   let(:headers) do
     headers_hash = {}
-    headers_hash['Authorization'] = "Bearer #{authorization_token}" if defined?(authorization_token) && authorization_token
+    if defined?(authorization_token) && authorization_token
+      headers_hash['Authorization'] =
+        "Bearer #{authorization_token}"
+    end
     headers_hash['X-Spree-Order-Token'] = order_token if defined?(order_token) && order_token
     headers_hash
   end
@@ -55,8 +58,62 @@ RSpec.describe SolidusGraphqlApi::Context do
   describe '#current_user' do
     subject { schema_context.current_user }
 
-    context 'when headers do not contains the authorization token' do
-      it { is_expected.to be_nil }
+    context 'when headers do not contain the authorization token' do
+      context "and there's no user with nil or empty spree_api_key" do
+        it { is_expected.to be_nil }
+      end
+
+      context "and there's a user with nil spree_api_key" do
+        before { FactoryBot.create(:user, spree_api_key: nil) }
+
+        it { is_expected.to be_nil }
+      end
+
+      context "and there's a user with empty string as spree_api_key" do
+        before { FactoryBot.create(:user, spree_api_key: '') }
+
+        it { is_expected.to be_nil }
+      end
+    end
+
+    context 'when headers contain an empty authorization token' do
+      let(:authorization_token) { '' }
+
+      context "and there's no user with nil or empty spree_api_key" do
+        it { is_expected.to be_nil }
+      end
+
+      context "and there's a user with nil spree_api_key" do
+        before { FactoryBot.create(:user, spree_api_key: nil) }
+
+        it { is_expected.to be_nil }
+      end
+
+      context "and there's a user with empty string as spree_api_key" do
+        before { FactoryBot.create(:user, spree_api_key: '') }
+
+        it { is_expected.to be_nil }
+      end
+    end
+
+    context "when headers contain a authorization header that doesn't match" do
+      let(:headers) { { 'Authorization' => 'abc' } }
+
+      context "and there's no user with nil or empty spree_api_key" do
+        it { is_expected.to be_nil }
+      end
+
+      context "and there's a user with nil spree_api_key" do
+        before { FactoryBot.create(:user, spree_api_key: nil) }
+
+        it { is_expected.to be_nil }
+      end
+
+      context "and there's a user with empty string as spree_api_key" do
+        before { FactoryBot.create(:user, spree_api_key: '') }
+
+        it { is_expected.to be_nil }
+      end
     end
 
     context 'when headers contains the authorization token' do
@@ -171,8 +228,12 @@ RSpec.describe SolidusGraphqlApi::Context do
       end
 
       context 'when the current user has many incompleted orders in the current store' do
-        let!(:first_created_order) { create :order, user: current_user, store: current_store, created_at: Time.zone.yesterday }
-        let!(:last_created_order) { create :order, user: current_user, store: current_store, created_at: Time.zone.today }
+        let!(:first_created_order) {
+          create :order, user: current_user, store: current_store, created_at: Time.zone.yesterday
+        }
+        let!(:last_created_order) {
+          create :order, user: current_user, store: current_store, created_at: Time.zone.today
+        }
 
         it { is_expected.to eq last_created_order }
       end
@@ -228,9 +289,61 @@ RSpec.describe SolidusGraphqlApi::Context do
         it { is_expected.to be_nil }
       end
 
+      # Need to bypass application layer to reproduce race database state
+      # rubocop:disable Rails/SkipsModelValidations
       context 'when is provided no order token' do
-        it { is_expected.to be_nil }
+        context "and there's no order with nil or empty guest_token" do
+          it { is_expected.to be_nil }
+        end
+
+        context "and there's an order with nil guest_token" do
+          before do
+            order = FactoryBot.create(:order)
+            order.update_column(:guest_token, nil)
+          end
+
+          it { is_expected.to be_nil }
+        end
+
+        context "and there's an order with empty string as guest_token" do
+          before do
+            order = FactoryBot.create(:order)
+            order.update_column(:guest_token, '')
+          end
+
+          it { is_expected.to be_nil }
+        end
+      end
+      # rubocop:enable Rails/SkipsModelValidations
+
+      # Need to bypass application layer to reproduce race database state
+      # rubocop:disable Rails/SkipsModelValidations
+      context 'when is provided an empty order token' do
+        let(:order_token) { '' }
+
+        context "and there's no order with nil or empty guest_token" do
+          it { is_expected.to be_nil }
+        end
+
+        context "and there's an order with nil guest_token" do
+          before do
+            order = FactoryBot.create(:order)
+            order.update_column(:guest_token, nil)
+          end
+
+          it { is_expected.to be_nil }
+        end
+
+        context "and there's an order with empty string as guest_token" do
+          before do
+            order = FactoryBot.create(:order)
+            order.update_column(:guest_token, '')
+          end
+
+          it { is_expected.to be_nil }
+        end
       end
+      # rubocop:enable Rails/SkipsModelValidations
     end
   end
 end

data/spec/lib/solidus_graphql_api/queries/option_value/option_type_query_spec.rb

@@ -0,0 +1,10 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+RSpec.describe SolidusGraphqlApi::Queries::OptionValue::OptionTypeQuery do
+  let(:option_type) { create(:option_type) }
+  let(:option_value) { create(:option_value, option_type: option_type) }
+
+  it { expect(described_class.new(option_value: option_value).call.sync).to eq(option_type) }
+end

data/spec/lib/solidus_graphql_api/queries/shipping_rate/shipping_method_query_spec.rb

@@ -0,0 +1,11 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+RSpec.describe SolidusGraphqlApi::Queries::ShippingRate::ShippingMethodQuery do
+  let(:shipping_method) { create(:shipping_method) }
+
+  let(:shipping_rate) { create(:shipping_rate, shipping_method: shipping_method) }
+
+  it { expect(described_class.new(shipping_rate: shipping_rate).call.sync).to eq(shipping_method) }
+end

data/spec/lib/solidus_graphql_api/queries/variant/default_price_query_spec.rb

@@ -5,5 +5,5 @@ require 'spec_helper'
 RSpec.describe SolidusGraphqlApi::Queries::Variant::DefaultPriceQuery do
   let(:variant) { create(:variant) }
 
-  it { expect(described_class.new(variant: variant).call.sync).to eq(variant.default_price) }
+  it { expect(described_class.new(variant: variant).call).to eq(variant.default_price) }
 end

data/spec/lib/solidus_graphql_api/types/base/object_spec.rb

@@ -3,7 +3,11 @@
 require 'spec_helper'
 
 RSpec.describe SolidusGraphqlApi::Types::Base::Object do
-  subject { Class.new(described_class) }
+  subject do
+    Class.new(described_class) do
+      graphql_name :test
+    end
+  end
 
   describe '.remove_field' do
     context 'when the field is defined' do

data/spec/lib/solidus_graphql_api/types/json_spec.rb

@@ -37,7 +37,8 @@ RSpec.describe SolidusGraphqlApi::Types::Json do
         hash_array: [
           {
             ids_array: [
-              'U3ByZWU6OlByb21vdGlvbkFjdGlvbi02', 'U3ByZWU6OlByb21vdGlvbkFjdGlvbi04' # Spree::PromotionAction-6, Spree::PromotionAction-8
+              'U3ByZWU6OlByb21vdGlvbkFjdGlvbi02',
+              'U3ByZWU6OlByb21vdGlvbkFjdGlvbi04' # Spree::PromotionAction-6, Spree::PromotionAction-8
             ],
             ids_hash: {
               id: 'U3ByZWU6OkFkanVzdG1lbnQtNQ==', # Spree::Adjustment-5

data/spec/lib/solidus_graphql_api/types/option_value_spec.rb

@@ -0,0 +1,22 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+RSpec.describe SolidusGraphqlApi::Types::OptionValue do
+  let(:option_value) { create(:option_value) }
+  let(:query_object) { spy(:query_object) }
+
+  subject { described_class.send(:new, option_value, {}) }
+
+  describe '#option_type' do
+    before do
+      allow(SolidusGraphqlApi::Queries::OptionValue::OptionTypeQuery).
+        to receive(:new).with(option_value: option_value).
+        and_return(query_object)
+    end
+
+    after { subject.option_type }
+
+    it { expect(query_object).to receive(:call) }
+  end
+end

data/spec/lib/solidus_graphql_api/types/product_spec.rb

@@ -34,7 +34,9 @@ RSpec.describe SolidusGraphqlApi::Types::Product do
 
   describe '#product_properties' do
     before do
-      allow(SolidusGraphqlApi::Queries::Product::ProductPropertiesQuery).to receive(:new).with(product: product).and_return(query_object)
+      allow(SolidusGraphqlApi::Queries::Product::ProductPropertiesQuery).
+        to receive(:new).with(product: product).
+        and_return(query_object)
     end
 
     after { subject.product_properties }

data/spec/lib/solidus_graphql_api/types/query_spec.rb

@@ -24,7 +24,9 @@ RSpec.describe SolidusGraphqlApi::Types::Query do
 
     let(:slug) { 'slug' }
 
-    before { allow(SolidusGraphqlApi::Queries::ProductBySlugQuery).to receive(:new).with(no_args).and_return(query_object) }
+    before {
+      allow(SolidusGraphqlApi::Queries::ProductBySlugQuery).to receive(:new).with(no_args).and_return(query_object)
+    }
 
     after { subject.product_by_slug(slug: slug) }
 

data/spec/lib/solidus_graphql_api/types/shipping_rate_spec.rb

@@ -0,0 +1,22 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+RSpec.describe SolidusGraphqlApi::Types::ShippingRate do
+  let(:shipping_rate) { create(:shipping_rate) }
+  let(:query_object) { spy(:query_object) }
+
+  subject { described_class.send(:new, shipping_rate, {}) }
+
+  describe '#shipping_method' do
+    before do
+      allow(SolidusGraphqlApi::Queries::ShippingRate::ShippingMethodQuery).
+        to receive(:new).with(shipping_rate: shipping_rate).
+        and_return(query_object)
+    end
+
+    after { subject.shipping_method }
+
+    it { expect(query_object).to receive(:call) }
+  end
+end

data/spec/requests/spree/graphql_controller_spec.rb

@@ -7,11 +7,24 @@ RSpec.describe Spree::GraphqlController do
 
   before { allow_any_instance_of(SolidusGraphqlApi::Context).to receive(:to_h).and_return(context) }
 
-  after { post '/graphql', headers: headers }
-
   it 'passes the right context to the schema' do
     expect(SolidusGraphqlApi::Schema).to receive(:execute).with(
       nil, hash_including(context: context)
     )
+
+    post '/graphql', headers: headers
+  end
+
+  it 'can return blob URLs on disk storage' do
+    product = create(:product)
+    product.images.create(attributes_for(:image))
+
+    post '/graphql',
+         params: {
+           query: "{ productBySlug(slug: \"#{product.slug}\") { masterVariant { images { nodes { smallUrl } } } } }"
+         },
+         headers: headers
+
+    expect(JSON.parse(response.body).dig(*%w[data productBySlug masterVariant images nodes])[0]['smallUrl']).to match('http://')
   end
 end

data/spec/spec_helper.rb

@@ -6,24 +6,23 @@ ENV['RAILS_ENV'] = 'test'
 # Run Coverage report
 require 'solidus_dev_support/rspec/coverage'
 
-require(File.expand_path('dummy/config/environment.rb', __dir__).tap { |file|
-  # Create the dummy app if it's still missing.
-  system 'bin/rake extension:test_app' unless File.exist? file
-})
+# Create the dummy app if it's still missing.
+dummy_env = "#{__dir__}/dummy/config/environment.rb"
+system 'bin/rake extension:test_app' unless File.exist? dummy_env
+require dummy_env
 
 # Requires factories and other useful helpers defined in spree_core.
-require 'solidus_dev_support/rspec/rails_helper'
-require 'pry'
+require 'solidus_dev_support/rspec/feature_helper'
 require "graphql/schema_comparator"
 require 'with_model'
 require 'timecop'
 
 # Requires supporting ruby files with custom matchers and macros, etc,
 # in spec/support/ and its subdirectories.
-Dir[File.join(File.dirname(__FILE__), 'support/**/*.rb')].each { |f| require f }
+Dir["#{__dir__}/support/**/*.rb"].sort.each { |f| require f }
 
-# Requires factories defined in lib/solidus_graphql_api/factories.rb
-require 'solidus_graphql_api/factories'
+# Requires factories defined in lib/solidus_graphql_api/testing_support/factories.rb
+SolidusDevSupport::TestingSupport::Factories.load_for(SolidusGraphqlApi::Engine)
 
 RSpec.configure do |config|
   config.add_setting :default_freeze_date, default: "21/12/2012 12:00:00"
@@ -33,6 +32,13 @@ RSpec.configure do |config|
 
   config.infer_spec_type_from_file_location!
   config.use_transactional_fixtures = false
+
+  if defined?(ActiveStorage::Current)
+    config.before(:all) do
+      ActiveStorage::Current.host = 'https://www.example.com'
+    end
+  end
+
   config.include Helpers::Graphql
   config.include Matchers::Graphql
 

data/spec/support/expected_schema.graphql

@@ -85,9 +85,8 @@ type Address implements Node {
   company: String
   country: Country!
   createdAt: ISO8601DateTime
-  firstname: String!
   id: ID!
-  lastname: String
+  name: String!
   phone: String!
   state: State
   stateName: String
@@ -140,14 +139,18 @@ input AddressInput {
   city: String!
   company: String
   countryId: ID!
-  firstname: String!
-  lastname: String
+  name: String!
   phone: String!
   stateId: ID
   stateName: String
   zipcode: String!
 }
 
+enum AddressTypeInput {
+  billing
+  shipping
+}
+
 """
 Adjustment.
 """
@@ -562,9 +565,9 @@ type ManifestItem {
 }
 
 """
-Autogenerated input type of MarkDefaultAddress
+Autogenerated input type of MarkDefaultShipAddress
 """
-input MarkDefaultAddressInput {
+input MarkDefaultShipAddressInput {
   addressId: ID!
 
   """
@@ -574,9 +577,9 @@ input MarkDefaultAddressInput {
 }
 
 """
-Autogenerated return type of MarkDefaultAddress
+Autogenerated return type of MarkDefaultShipAddress
 """
-type MarkDefaultAddressPayload {
+type MarkDefaultShipAddressPayload {
   """
   A unique identifier for the client performing the mutation.
   """
@@ -585,22 +588,102 @@ type MarkDefaultAddressPayload {
 }
 
 type Mutation {
-  addAddressesToCheckout(input: AddAddressesToCheckoutInput!): AddAddressesToCheckoutPayload
-  addPaymentToCheckout(input: AddPaymentToCheckoutInput!): AddPaymentToCheckoutPayload
-  addToCart(input: AddToCartInput!): AddToCartPayload
-  advanceCheckout(input: AdvanceCheckoutInput!): AdvanceCheckoutPayload
-  applyCouponCode(input: ApplyCouponCodeInput!): ApplyCouponCodePayload
-  completeCheckout(input: CompleteCheckoutInput!): CompleteCheckoutPayload
-  createOrder(input: CreateOrderInput!): CreateOrderPayload
-  emptyCart(input: EmptyCartInput!): EmptyCartPayload
-  markDefaultAddress(input: MarkDefaultAddressInput!): MarkDefaultAddressPayload
-  nextCheckoutState(input: NextCheckoutStateInput!): NextCheckoutStatePayload
-  removeFromAddressBook(input: RemoveFromAddressBookInput!): RemoveFromAddressBookPayload
-  removeFromCart(input: RemoveFromCartInput!): RemoveFromCartPayload
-  saveInAddressBook(input: SaveInAddressBookInput!): SaveInAddressBookPayload
-  selectShippingRate(input: SelectShippingRateInput!): SelectShippingRatePayload
-  setOrderEmail(input: SetOrderEmailInput!): SetOrderEmailPayload
-  updateCartQuantity(input: UpdateCartQuantityInput!): UpdateCartQuantityPayload
+  addAddressesToCheckout(
+    """
+    Parameters for AddAddressesToCheckout
+    """
+    input: AddAddressesToCheckoutInput!
+  ): AddAddressesToCheckoutPayload
+  addPaymentToCheckout(
+    """
+    Parameters for AddPaymentToCheckout
+    """
+    input: AddPaymentToCheckoutInput!
+  ): AddPaymentToCheckoutPayload
+  addToCart(
+    """
+    Parameters for AddToCart
+    """
+    input: AddToCartInput!
+  ): AddToCartPayload
+  advanceCheckout(
+    """
+    Parameters for AdvanceCheckout
+    """
+    input: AdvanceCheckoutInput!
+  ): AdvanceCheckoutPayload
+  applyCouponCode(
+    """
+    Parameters for ApplyCouponCode
+    """
+    input: ApplyCouponCodeInput!
+  ): ApplyCouponCodePayload
+  completeCheckout(
+    """
+    Parameters for CompleteCheckout
+    """
+    input: CompleteCheckoutInput!
+  ): CompleteCheckoutPayload
+  createOrder(
+    """
+    Parameters for CreateOrder
+    """
+    input: CreateOrderInput!
+  ): CreateOrderPayload
+  emptyCart(
+    """
+    Parameters for EmptyCart
+    """
+    input: EmptyCartInput!
+  ): EmptyCartPayload
+  markDefaultShipAddress(
+    """
+    Parameters for MarkDefaultShipAddress
+    """
+    input: MarkDefaultShipAddressInput!
+  ): MarkDefaultShipAddressPayload
+  nextCheckoutState(
+    """
+    Parameters for NextCheckoutState
+    """
+    input: NextCheckoutStateInput!
+  ): NextCheckoutStatePayload
+  removeFromAddressBook(
+    """
+    Parameters for RemoveFromAddressBook
+    """
+    input: RemoveFromAddressBookInput!
+  ): RemoveFromAddressBookPayload
+  removeFromCart(
+    """
+    Parameters for RemoveFromCart
+    """
+    input: RemoveFromCartInput!
+  ): RemoveFromCartPayload
+  saveInAddressBook(
+    """
+    Parameters for SaveInAddressBook
+    """
+    input: SaveInAddressBookInput!
+  ): SaveInAddressBookPayload
+  selectShippingRate(
+    """
+    Parameters for SelectShippingRate
+    """
+    input: SelectShippingRateInput!
+  ): SelectShippingRatePayload
+  setOrderEmail(
+    """
+    Parameters for SetOrderEmail
+    """
+    input: SetOrderEmailInput!
+  ): SetOrderEmailPayload
+  updateCartQuantity(
+    """
+    Parameters for UpdateCartQuantity
+    """
+    input: UpdateCartQuantityInput!
+  ): UpdateCartQuantityPayload
 }
 
 """
@@ -710,6 +793,7 @@ type OptionValue implements Node {
   createdAt: ISO8601DateTime
   id: ID!
   name: String!
+  optionType: OptionType!
   position: String!
   presentation: String!
   updatedAt: ISO8601DateTime
@@ -1387,6 +1471,7 @@ Autogenerated input type of SaveInAddressBook
 """
 input SaveInAddressBookInput {
   address: AddressInput!
+  addressType: AddressTypeInput = shipping
 
   """
   A unique identifier for the client performing the mutation.
@@ -1524,6 +1609,23 @@ type ShipmentEdge {
   node: Shipment
 }
 
+"""
+Shipping Method.
+"""
+type ShippingMethod implements Node {
+  adminName: String
+  availableToAll: Boolean!
+  availableToUsers: Boolean!
+  carrier: String
+  code: String
+  createdAt: ISO8601DateTime
+  id: ID!
+  name: String!
+  serviceLevel: String
+  trackingUrl: String
+  updatedAt: ISO8601DateTime
+}
+
 """
 Shipping Rate.
 """
@@ -1533,6 +1635,7 @@ type ShippingRate implements Node {
   currency: String!
   id: ID!
   selected: Boolean!
+  shippingMethod: ShippingMethod!
   updatedAt: ISO8601DateTime
 }
 
@@ -1861,7 +1964,6 @@ type User implements Node {
   billAddress: Address
   createdAt: ISO8601DateTime
   currentSignInAt: ISO8601DateTime
-  defaultAddress: Address
   email: String!
   id: ID!
   lastSignInAt: ISO8601DateTime
@@ -2067,4 +2169,4 @@ type WalletPaymentSourceEdge {
   The item at the end of the edge.
   """
   node: WalletPaymentSource
-}
+}