solidus_frontend 4.0.0.dev → 4.6.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e44b1fc677f1a5395be411196cf20483f8d6c96e18251f78376046c102d9ca7a
-  data.tar.gz: 0cbb98a3a5864aefecbaa0fa140a21f58ab92e730b52ecf18b03ca3848a64435
+  metadata.gz: dd60be911178a15bc3341c721a5b19dcf84e11558199d5634ec9382c17bde14d
+  data.tar.gz: 7809c9e463ed1bea60b8e3f710dcd59f084fc318d47a2abf08beac4b1d6a2f38
 SHA512:
-  metadata.gz: ea2f67025d772768902918cd58a6ad6f7fdee7f2b86e8715914f1d9ad6d57e2e446b1c6240247230baf2a6effdf6a93c0faafaa05766ed5fc8a8f6a40d55d665
-  data.tar.gz: ac9c5b3c28cc76a64c13769fabe5a22c4d111aef5caedbbf903b32637e010b4891c94724ffdd91b58d98338c3bdc9bc1e93a16f3ff51d3208e4bac83bdad0caa
+  metadata.gz: 88fcf1c04e3e8ee9439abc31cafd00b8d9af66115a0d6dec5618c5db75656ff2163479791e117104507e71a32216d29430aa40caf4f76ec493b1da659a95b533
+  data.tar.gz: 7cffedee5244f1f0aa5a24a58c0e6cc832e63993ec97f42f31ba1356ebcc37b51061022be3e76167fd6a34e25ad2fbbcc31e45f1eb6e8ac209ae11fbc5014255

data/.github/workflows/test.yml

@@ -0,0 +1,25 @@
+name: Test
+
+on:
+  push:
+    branches:
+      - main
+      - v4.6
+  pull_request:
+  workflow_dispatch:
+  schedule:
+    - cron: "0 0 * * 4" # every Thursday
+
+concurrency:
+  group: test-${{ github.ref_name }}
+  cancel-in-progress: ${{ github.ref_name != 'main' }}
+
+permissions:
+  contents: read
+
+jobs:
+  test:
+    uses: solidusio/test-solidus-extension/.github/workflows/test.yml@main
+    with:
+      solidus_branches: '["v4.6"]'
+      ruby_versions: '["3.2", "3.4"]'

data/CHANGELOG.md

@@ -1,36 +1,3 @@
 # Changelog
 
-## Solidus v3.4.0 (v3.4, 2023-04-21)
-
-## Solidus v3.3.0 (v3.3, 2023-01-24)
-
-- Fix CircleCI errors due to libvips not being found [#27](https://github.com/solidusio/solidus_frontend/pull/27) ([waiting-for-dev](https://github.com/waiting-for-dev))
-- Update Changelog with latest released versions [#26](https://github.com/solidusio/solidus_frontend/pull/26) ([waiting-for-dev](https://github.com/waiting-for-dev))
-- [v3.2] Notify CI failures on Slack [#25](https://github.com/solidusio/solidus_frontend/pull/25) ([waiting-for-dev](https://github.com/waiting-for-dev))
-- Notify CI failures on Slack [#24](https://github.com/solidusio/solidus_frontend/pull/24) ([waiting-for-dev](https://github.com/waiting-for-dev))
-- Touch the robots file before appending to it [#18](https://github.com/solidusio/solidus_frontend/pull/18) ([elia](https://github.com/elia))
-- Handle robots in here [#17](https://github.com/solidusio/solidus_frontend/pull/17) ([elia](https://github.com/elia))
-- [v3.2] Skip trying to install solidus_bolt when there's no Gemfile [#16](https://github.com/solidusio/solidus_frontend/pull/16) ([waiting-for-dev](https://github.com/waiting-for-dev))
-- Skip trying to install solidus_bolt when there's no Gemfile [#15](https://github.com/solidusio/solidus_frontend/pull/15) ([waiting-for-dev](https://github.com/waiting-for-dev))
-- Ask whether to add solidus_bolt during installation [#14](https://github.com/solidusio/solidus_frontend/pull/14) ([waiting-for-dev](https://github.com/waiting-for-dev))
-- Fix display of tax adjustments in checkout [#11](https://github.com/solidusio/solidus_frontend/pull/11) ([adammathys](https://github.com/adammathys))
-- Utilize Rails redirect methods [#9](https://github.com/solidusio/solidus_frontend/pull/9) ([cpfergus1](https://github.com/cpfergus1))
-- Bump version to 3.3.0.alpha [#6](https://github.com/solidusio/solidus_frontend/pull/6) ([waiting-for-dev](https://github.com/waiting-for-dev))
-
-## Solidus v3.2.5 (v3.2, 2022-12-23)
-
-## Solidus v3.2.4 (v3.2, 2022-11-09)
-
-## Solidus v3.2.3 (v3.2, 2022-11-03)
-
-## Solidus v3.2.2 (v3.2, 2022-09-09)
-
--  Ask whether to add solidus_bolt during installation [#14](https://github.com/solidusio/solidus_frontend/pull/14) ([waiting-for-dev](https://github.com/waiting-for-dev))
-
-## Solidus v3.2.1 (v3.2, 2022-09-09)
-
-## Solidus v3.2.0 (v3.2, 2022-08-18)
-
-- Initial release from the standalone repository. See [Solidus'
-  CHANGELOG](https://github.com/solidusio/solidus/blob/master/CHANGELOG.md) for
-  previous updates.
+See https://github.com/solidusio/solidus_frontend/releases.

data/Gemfile

@@ -2,14 +2,16 @@
 
 source 'https://rubygems.org'
 
-branch = ENV.fetch('SOLIDUS_BRANCH', 'master')
+branch = ENV.fetch('SOLIDUS_BRANCH', 'v4.6')
 
-git "https://github.com/solidusio/solidus.git", branch: branch do
-  gem 'solidus_api'
-  gem 'solidus_core'
-end
+# The storefront's promotion features build on the legacy promotion
+# system, which lives in the solidus_legacy_promotions gem since Solidus
+# 4.4, and its admin assets require solidus_backend, so we test against
+# the full solidus gem.
+gem 'solidus', git: "https://github.com/solidusio/solidus.git", branch: branch
 
-gem 'rails', ENV.fetch('RAILS_VERSION', nil)
+rails_version = ENV.fetch('RAILS_VERSION', '7.2')
+gem 'rails', "~> #{rails_version}"
 
 # Temporarily locking sprockets to v3.x
 # see https://github.com/solidusio/solidus/issues/3374
@@ -22,7 +24,11 @@ when 'mysql'
 when 'postgresql'
   gem 'pg'
 else
-  gem 'sqlite3'
+  if rails_version <= "7.2"
+    gem 'sqlite3', "~> 1.7"
+  else
+    gem 'sqlite3', "~> 2.0"
+  end
 end
 
 gemspec

data/README.md

@@ -1,19 +1,30 @@
 # solidus\_frontend
 
-Frontend contains controllers and views implementing a storefront and cart for Solidus.
+Frontend contains controllers and views implementing a storefront and cart for
+Solidus.
 
-## Warning
+## 🚧 Warning
 
-For new Solidus apps, we recommend that you use
-[SolidusStarterFrontend](https://github.com/solidusio/solidus_starter_frontend)
+This gem is deprecated. New Solidus installations use
+[Solidus Storefront](https://github.com/solidusio/solidus/tree/main/storefront#readme)
 instead.
 
+This repository will only accept bug fixes and security patches for the branches
+that match supported versions of Solidus:
+
+| Branch                                                          | End of Life |
+| --------------------------------------------------------------- | ----------- |
+| [v4.7](https://github.com/solidusio/solidus_frontend/tree/v4.7) | 2027-10-08  |
+| [v4.6](https://github.com/solidusio/solidus_frontend/tree/v4.6) | 2027-03-03  |
+
 ## Override views
 
-In order to customize a view you should copy the file into your host app. Using Deface is not
-recommended as it provides lots of headaches while debugging and degrades your shops performance.
+In order to customize a view you should copy the file into your host app. Using
+Deface is not recommended as it provides lots of headaches while debugging and
+degrades your shops performance.
 
-Solidus provides a generator to help with copying the right view into your host app.
+Solidus provides a generator to help with copying the right view into your host
+app.
 
 Simply call the generator to copy all views into your host app.
 
@@ -21,27 +32,31 @@ Simply call the generator to copy all views into your host app.
 $ bundle exec rails g solidus:views:override
 ```
 
-If you only want to copy certain views into your host app, you can provide the `--only` argument:
+If you only want to copy certain views into your host app, you can provide the
+`--only` argument:
 
 ```bash
 $ bundle exec rails g solidus:views:override --only products/show
 ```
 
-The argument to `--only` can also be a substring of the name of the view from the `app/views/spree` folder:
+The argument to `--only` can also be a substring of the name of the view from
+the `app/views/spree` folder:
 
 ```bash
 $ bundle exec rails g solidus:views:override --only product
 ```
 
-This will copy all views whose directory or filename contains the string "product".
+This will copy all views whose directory or filename contains the string
+"product".
 
 ### Handle upgrades
 
-After upgrading Solidus to a new version run the generator again and follow on screen instructions.
+After upgrading Solidus to a new version run the generator again and follow on
+screen instructions.
 
 ## Developing Solidus Frontend
 
-* Clone the Git repo
+- Clone the Git repo
 
   ```bash
   git clone git://github.com/solidusio/solidus_frontend.git
@@ -50,13 +65,14 @@ After upgrading Solidus to a new version run the generator again and follow on s
 
 ### Without Docker
 
-* Install the gem dependencies
+- Install the gem dependencies
 
   ```bash
   bin/setup
   ```
 
-  _Note_: If you're using PostgreSQL or MySQL, you'll need to install those gems through the DB environment variable.
+  _Note_: If you're using PostgreSQL or MySQL, you'll need to install those gems
+  through the DB environment variable.
 
   ```bash
   # PostgreSQL
@@ -74,7 +90,8 @@ After upgrading Solidus to a new version run the generator again and follow on s
 docker-compose up -d
 ```
 
-Wait for all the gems to be installed (progress can be checked through `docker-compose logs -f app`).
+Wait for all the gems to be installed (progress can be checked through
+`docker-compose logs -f app`).
 
 You can provide the ruby version you want your image to use:
 
@@ -83,7 +100,8 @@ docker-compose build --build-arg RUBY_VERSION=2.6 app
 docker-compose up -d
 ```
 
-The rails version can be customized at runtime through `RAILS_VERSION` environment variable:
+The rails version can be customized at runtime through `RAILS_VERSION`
+environment variable:
 
 ```bash
 RAILS_VERSION='~> 5.0' docker-compose up -d
@@ -131,13 +149,14 @@ testing purposes.
 This sandbox includes solidus\_auth\_devise and generates with seed and sample
 data already loaded.
 
-* Create the sandbox application
+- Create the sandbox application
 
   ```bash
   bin/sandbox
   ```
 
-  You can create a sandbox with PostgreSQL or MySQL by setting the DB environment variable.
+  You can create a sandbox with PostgreSQL or MySQL by setting the DB
+  environment variable.
 
   ```bash
   # PostgreSQL
@@ -149,9 +168,9 @@ data already loaded.
   bin/sandbox
   ```
 
-  If you need to create a Rails 5.2 application for your sandbox, for example
-  if you are still using Ruby 2.4 which is not supported by Rails 6, you can
-  use the `RAILS_VERSION` environment variable.
+  If you need to create a Rails 5.2 application for your sandbox, for example if
+  you are still using Ruby 2.4 which is not supported by Rails 6, you can use
+  the `RAILS_VERSION` environment variable.
 
   ```bash
     export RAILS_VERSION='~> 5.2.0'
@@ -159,7 +178,7 @@ data already loaded.
     bin/sandbox
   ```
 
-* Start the server (`bin/rails` will forward any argument to the sandbox)
+- Start the server (`bin/rails` will forward any argument to the sandbox)
 
   ```bash
   bin/rails server
@@ -167,8 +186,8 @@ data already loaded.
 
 ### Tests
 
-Solidus uses [RSpec](http://rspec.info) for tests. Refer to its documentation for
-more information about the testing library.
+Solidus uses [RSpec](http://rspec.info) for tests. Refer to its documentation
+for more information about the testing library.
 
 #### CircleCI
 
@@ -205,3 +224,8 @@ coverage report:
 COVERAGE=true bundle exec rspec
 ```
 
+### Releasing new versions
+
+Please refer to the dedicated
+[page](https://github.com/solidusio/solidus/wiki/How-to-release-extensions) on
+Solidus wiki.

data/Rakefile

@@ -2,12 +2,28 @@
 
 require 'spree/testing_support/dummy_app/rake_tasks'
 require 'solidus_dev_support/rake_tasks'
+require 'bundler/gem_tasks'
 
 DummyApp::RakeTasks.new(
   gem_root: File.expand_path(__dir__),
   lib_name: 'solidus_frontend'
 )
 
+require 'rake/clean'
+CLOBBER.include('spec/dummy')
+
 SolidusDevSupport::RakeTasks.install
 
+# The combined `db:drop db:create db:migrate` invocation used to set up the
+# dummy database leaves SQLite with a stale connection to the dropped
+# database file, so the migrated schema never reaches the file on disk.
+# Re-running the migrations in a fresh process writes the real database.
+task 'extension:test_app' do
+  if ENV['DB'].nil? || %w[sqlite sqlite3].include?(ENV['DB'])
+    cd 'spec/dummy' do
+      sh 'bin/rails db:migrate VERBOSE=false RAILS_ENV=test'
+    end
+  end
+end
+
 task default: 'extension:specs'

data/app/controllers/spree/store_controller.rb

@@ -5,6 +5,8 @@ module Spree
     include Spree::Core::ControllerHelpers::Pricing
     include Spree::Core::ControllerHelpers::Order
 
+    respond_to :html
+
     def unauthorized
       render 'spree/shared/unauthorized', layout: Spree::Config[:layout], status: 401
     end

data/bin/rspec

@@ -0,0 +1,27 @@
+#!/usr/bin/env ruby
+# frozen_string_literal: true
+
+#
+# This file was generated by Bundler.
+#
+# The application 'rspec' is installed as part of a gem, and
+# this file is here to facilitate running it.
+#
+
+ENV["BUNDLE_GEMFILE"] ||= File.expand_path("../Gemfile", __dir__)
+
+bundle_binstub = File.expand_path("bundle", __dir__)
+
+if File.file?(bundle_binstub)
+  if File.read(bundle_binstub, 300) =~ /This file was generated by Bundler/
+    load(bundle_binstub)
+  else
+    abort("Your `bin/bundle` was not generated by Bundler, so this binstub cannot run.
+Replace `bin/bundle` by running `bundle binstubs bundler --force`, then run this command again.")
+  end
+end
+
+require "rubygems"
+require "bundler/setup"
+
+load Gem.bin_path("rspec-core", "rspec")

data/lib/generators/solidus_frontend/install/install_generator.rb

@@ -5,9 +5,7 @@ module SolidusFrontend
     class InstallGenerator < Rails::Generators::Base
       source_root File.expand_path('templates', __dir__)
 
-      class_option :auto_accept,
-                   type: :boolean,
-                   default: false
+      class_option :auto_accept, type: :boolean, default: false
 
       def self.exit_on_failure?
         true

data/lib/spree/frontend/version.rb

@@ -2,7 +2,7 @@
 
 module Spree
   module Frontend
-    VERSION = "4.0.0.dev"
+    VERSION = "4.6.0"
 
     def self.version
       VERSION

data/solidus_frontend.gemspec

@@ -7,13 +7,13 @@ Gem::Specification.new do |s|
   s.name        = 'solidus_frontend'
   s.version     = Spree::Frontend.version
 
-  s.summary     = <<~SUMMARY
-    Legacy cart and storefront for the Solidus e-commerce project.
-    For new Solidus apps, we recommend that you use
-    [SolidusStarterFrontend](https://github.com/solidusio/solidus_starter_frontend)
-    instead.
+  s.summary = <<~SUMMARY
+    Legacy storefront for the Solidus e-commerce platform. New Solidus
+    installations use Solidus Storefront:
+    https://github.com/solidusio/solidus/tree/main/storefront#readme
   SUMMARY
 
+
   s.description = s.summary
 
   s.author      = 'Solidus Team'
@@ -24,7 +24,7 @@ Gem::Specification.new do |s|
   s.metadata['rubygems_mfa_required'] = 'true'
   s.metadata['homepage_uri'] = s.homepage
   s.metadata['source_code_uri'] = 'https://github.com/solidusio/solidus_frontend'
-  s.metadata['changelog_uri'] = 'https://github.com/solidusio/solidus_frontend/blob/master/CHANGELOG.md'
+  s.metadata['changelog_uri'] = 'https://github.com/solidusio/solidus_frontend/releases'
 
   s.files = `git ls-files -z`.split("\x0").reject do |f|
     f.match(%r{^(spec|script)/})
@@ -47,6 +47,7 @@ Gem::Specification.new do |s|
   s.add_development_dependency 'capybara-accessible'
   s.add_development_dependency 'solidus_dev_support', '~> 2.5'
   s.add_development_dependency 'rspec-activemodel-mocks', '~> 1.1'
+  s.add_development_dependency 'rspec-retry'
   s.add_development_dependency 'rails-controller-testing'
   s.add_development_dependency 'generator_spec'
 end

metadata

@@ -1,14 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: solidus_frontend
 version: !ruby/object:Gem::Version
-  version: 4.0.0.dev
+  version: 4.6.0
 platform: ruby
 authors:
 - Solidus Team
-autorequire: 
 bindir: bin
 cert_chain: []
-date: 2023-04-21 00:00:00.000000000 Z
+date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: solidus_api
@@ -184,6 +183,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.1'
+- !ruby/object:Gem::Dependency
+  name: rspec-retry
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rails-controller-testing
   requirement: !ruby/object:Gem::Requirement
@@ -212,19 +225,18 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-description: Legacy cart and storefront for the Solidus e-commerce project. For new
-  Solidus apps, we recommend that you use [SolidusStarterFrontend](https://github.com/solidusio/solidus_starter_frontend)
-  instead.
+description: 'Legacy storefront for the Solidus e-commerce platform. New Solidus installations
+  use Solidus Storefront: https://github.com/solidusio/solidus/tree/main/storefront#readme'
 email: contact@solidus.io
 executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- ".circleci/config.yml"
 - ".dockerdev/.psqlrc"
 - ".dockerdev/Dockerfile"
 - ".gem_release.yml"
 - ".github/stale.yml"
+- ".github/workflows/test.yml"
 - ".github_changelog_generator"
 - ".gitignore"
 - ".rspec"
@@ -344,6 +356,7 @@ files:
 - bin/rails-engine
 - bin/rails-sandbox
 - bin/rake
+- bin/rspec
 - bin/sandbox
 - bin/setup
 - config/initializers/assets.rb
@@ -373,8 +386,7 @@ metadata:
   rubygems_mfa_required: 'true'
   homepage_uri: http://solidus.io
   source_code_uri: https://github.com/solidusio/solidus_frontend
-  changelog_uri: https://github.com/solidusio/solidus_frontend/blob/master/CHANGELOG.md
-post_install_message: 
+  changelog_uri: https://github.com/solidusio/solidus_frontend/releases
 rdoc_options: []
 require_paths:
 - lib
@@ -389,10 +401,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: 1.8.23
 requirements: []
-rubygems_version: 3.4.6
-signing_key: 
+rubygems_version: 4.0.10
 specification_version: 4
-summary: Legacy cart and storefront for the Solidus e-commerce project. For new Solidus
-  apps, we recommend that you use [SolidusStarterFrontend](https://github.com/solidusio/solidus_starter_frontend)
-  instead.
+summary: 'Legacy storefront for the Solidus e-commerce platform. New Solidus installations
+  use Solidus Storefront: https://github.com/solidusio/solidus/tree/main/storefront#readme'
 test_files: []

data/.circleci/config.yml

@@ -1,61 +0,0 @@
-version: 2.1
-
-orbs:
-  browser-tools: circleci/browser-tools@1.3
-
-  # Always take the latest version of the orb, this allows us to
-  # run specs against Solidus supported versions only without the need
-  # to change this configuration every time a Solidus version is released
-  # or goes EOL.
-  solidusio_extensions: solidusio/extensions@volatile
-
-commands:
-  libvips:
-    steps:
-      - run:
-          name: Install libvips
-          command: |
-            sudo apt-get update
-            sudo apt-get install -yq libvips-dev
-
-jobs:
-  run-specs-with-postgres:
-    executor: solidusio_extensions/postgres
-    steps:
-      - checkout
-      - browser-tools/install-chrome
-      - browser-tools/install-chromedriver
-      - libvips
-      - solidusio_extensions/run-tests-solidus-master
-      - solidusio_extensions/store-test-results
-  run-specs-with-mysql:
-    executor: solidusio_extensions/mysql
-    steps:
-      - checkout
-      - browser-tools/install-chrome
-      - browser-tools/install-chromedriver
-      - libvips
-      - solidusio_extensions/run-tests-solidus-master
-      - solidusio_extensions/store-test-results
-  lint-code:
-    executor: solidusio_extensions/sqlite-memory
-    steps:
-      - solidusio_extensions/lint-code
-
-workflows:
-  "Run specs on supported Solidus versions":
-    jobs:
-      - run-specs-with-postgres
-      - run-specs-with-mysql
-
-  "Weekly run specs against master":
-    triggers:
-      - schedule:
-          cron: "0 0 * * 4" # every Thursday
-          filters:
-            branches:
-              only:
-                - master
-    jobs:
-      - run-specs-with-postgres
-      - run-specs-with-mysql