solidus_dev_support 2.5.2 → 2.5.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e98ad4f08c0abe09fd5c4a86640e25db13f003324dcbd0ca1dc8e8747dcfd35b
-  data.tar.gz: 76ac684f40e4615ed1cad8a91c0f1140416e4009ad0e2ddd61986d05a04703e5
+  metadata.gz: aca5f58a3e39d6a6e6dcac45c538fc7963bc059eac65b4d8127c3a8a29a4740b
+  data.tar.gz: d868457dd1c63018a4f94bac62cac24897efe3bc5c478878cf00d52f67e59e00
 SHA512:
-  metadata.gz: 075e9de0887997b6893354aa756a720b82e8cad4f15bbaf59face03658b1a3259360aff1d6b25850d9ea37365dc81e12321b69ed6130b4919384df8ac1b79a9c
-  data.tar.gz: 8b9432063e8147d83bc856961d8404b140bedc8a921137ba3db8f04542e1d18bfcf87a31f7bcba516a76adc4e977d0bcde8698568945f60e51bd114aaf3631ee
+  metadata.gz: 9755aa55ac8beab16aacdea85f5bbe6a9b020c49aecca8ff761ff82bb8328f480964525e5d236a1bc2a43ee3cc244e7823c1b4fe6efbebf02934b7b49b8b9c71
+  data.tar.gz: 71ea3d512238276d23ff582febe5233eb5dd090e06857b9584386a50c5ebf2736d6179af49b39dd0fac530996d0d094768ef61313db648844df3df08829ec3d1

data/lib/solidus_dev_support/rake_tasks.rb

@@ -13,7 +13,7 @@ module SolidusDevSupport
 
     def initialize(root: Dir.pwd)
       @root = Pathname(root)
-      @test_app_path = @root.join(ENV['DUMMY_PATH'] || 'spec/dummy')
+      @test_app_path = @root.join(ENV.fetch('DUMMY_PATH', 'spec/dummy'))
       @gemspec = Bundler.load_gemspec(@root.glob("{,*}.gemspec").first)
     end
 
@@ -43,7 +43,7 @@ module SolidusDevSupport
           cd root
         end
 
-        directory ENV['DUMMY_PATH'] do
+        directory ENV.fetch('DUMMY_PATH', nil) do
           Rake::Task['extension:test_app'].invoke
         end
       end
@@ -61,7 +61,7 @@ module SolidusDevSupport
       require 'rspec/core/rake_task'
 
       namespace :extension do
-        ::RSpec::Core::RakeTask.new(:specs, [] => FileList[ENV['DUMMY_PATH']]) do |t|
+        ::RSpec::Core::RakeTask.new(:specs, [] => FileList[ENV.fetch('DUMMY_PATH', nil)]) do |t|
           # Ref: https://circleci.com/docs/2.0/configuration-reference#store_test_results
           # Ref: https://github.com/solidusio/circleci-orbs-extensions#test-results-rspec
           if ENV['TEST_RESULTS_PATH']
@@ -82,7 +82,7 @@ module SolidusDevSupport
 
         config.user = repo.owner
         config.project = repo.name
-        config.future_release = "v#{ENV['UNRELEASED_VERSION'] || gemspec.version}"
+        config.future_release = "v#{ENV.fetch('UNRELEASED_VERSION') { gemspec.version }}"
 
       rescue Octokit::InvalidRepository
         warn <<~WARN

data/lib/solidus_dev_support/rspec/capybara.rb

@@ -3,16 +3,20 @@
 require 'webdrivers/chromedriver'
 
 # Allow to override the initial windows size
-CAPYBARA_WINDOW_SIZE = (ENV['CAPYBARA_WINDOW_SIZE'] || '1920x1080').split('x', 2).map(&:to_i)
+CAPYBARA_WINDOW_SIZE = ENV.fetch('CAPYBARA_WINDOW_SIZE', '1920x1080').split('x', 2).map(&:to_i)
+CAPYBARA_WINDOW_WIDTH = CAPYBARA_WINDOW_SIZE[0]
+CAPYBARA_WINDOW_HEIGHT = CAPYBARA_WINDOW_SIZE[1]
 
-Capybara.javascript_driver = (ENV['CAPYBARA_JAVASCRIPT_DRIVER'] || "solidus_chrome_headless").to_sym
+Capybara.javascript_driver = ENV.fetch('CAPYBARA_JAVASCRIPT_DRIVER', "solidus_chrome_headless").to_sym
 Capybara.default_max_wait_time = 10
 Capybara.server = :puma, { Silent: true } # A fix for rspec/rspec-rails#1897
 
 Capybara.drivers[:selenium_chrome_headless].tap do |original_driver|
   Capybara.register_driver :solidus_chrome_headless do |app|
     original_driver.call(app).tap do |driver|
-      driver.options[:options].args << "--window-size=#{CAPYBARA_WINDOW_SIZE.join(',')}"
+      driver.resize_window_to(
+        driver.current_window_handle, CAPYBARA_WINDOW_WIDTH, CAPYBARA_WINDOW_HEIGHT
+      )
     end
   end
 end

data/lib/solidus_dev_support/rspec/spec_helper.rb

@@ -14,7 +14,7 @@ RSpec.configure do |config|
   config.mock_with :rspec
   config.color = true
 
-  config.fail_fast = ENV['FAIL_FAST'] || false
+  config.fail_fast = ENV.fetch('FAIL_FAST', false)
   config.order = 'random'
 
   config.raise_errors_for_deprecations!

data/lib/solidus_dev_support/templates/extension/.circleci/config.yml

@@ -1,6 +1,9 @@
 version: 2.1
 
 orbs:
+  # Required for feature specs.
+  browser-tools: circleci/browser-tools@1.1
+
   # Always take the latest version of the orb, this allows us to
   # run specs against Solidus supported versions only without the need
   # to change this configuration every time a Solidus version is released
@@ -11,14 +14,17 @@ jobs:
   run-specs-with-postgres:
     executor: solidusio_extensions/postgres
     steps:
+      - browser-tools/install-browser-tools
       - solidusio_extensions/run-tests
   run-specs-with-mysql:
     executor: solidusio_extensions/mysql
     steps:
+      - browser-tools/install-browser-tools
       - solidusio_extensions/run-tests
   lint-code:
     executor: solidusio_extensions/sqlite-memory
     steps:
+      - browser-tools/install-browser-tools
       - solidusio_extensions/lint-code
 
 workflows:

data/lib/solidus_dev_support/templates/extension/Gemfile

@@ -14,7 +14,7 @@ gem 'rails', '>0.a'
 # Provides basic authentication functionality for testing parts of your engine
 gem 'solidus_auth_devise'
 
-case ENV['DB']
+case ENV.fetch('DB', nil)
 when 'mysql'
   gem 'mysql2'
 when 'postgresql'

data/lib/solidus_dev_support/version.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 module SolidusDevSupport
-  VERSION = "2.5.2"
+  VERSION = "2.5.3"
 
   def self.gem_version
     Gem::Version.new(VERSION)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: solidus_dev_support
 version: !ruby/object:Gem::Version
-  version: 2.5.2
+  version: 2.5.3
 platform: ruby
 authors:
 - Alessandro Desantis
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2021-11-23 00:00:00.000000000 Z
+date: 2022-05-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: capybara
@@ -412,7 +412,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
+rubygems_version: 3.1.6
 signing_key: 
 specification_version: 4
 summary: Development tools for Solidus extensions.