solidus_dev_support 2.5.1 → 2.5.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: de0e1de74a5245a5b53d6b3a472e9c7135277231a68530530309f7ac40799eab
-  data.tar.gz: 50967859e827b59b3e3bc91036e224d6e85a13ab3fae5cbb1d27021e90b27523
+  metadata.gz: 85a6ab192c62cc4e24367a2dc3be90d11779653bf8aa065a5079c390a19e8bc1
+  data.tar.gz: 839d23671a6475fbc0a67fdb2647e275debf52bbe04bffa3acffa06ccb75fd16
 SHA512:
-  metadata.gz: 3f81406fe09a753bdf323ba7823e72ef581a9cce0ceb67cd884a6703a565c461f604cb92c8449f59d998b9d06e046135a8d5d3d04c44a1a5987b97abee347865
-  data.tar.gz: 51c1c774c0252bbce8af10aa3b8369b9dc47f8452c87eb0385fe11a6c849295f19ba6b4e051a7c089d3a9e5baf763d6767fb5355cdb74012cb5892c4b9b4327b
+  metadata.gz: a872cd08b37f12b1fdad990c97bfa943a12f8ea86948fd5f28aea51e5f6d8f11e399049e26e78138caf2dd0ca218b363020940d7eff3b9e53a6b74230996537c
+  data.tar.gz: 03d5230592262f2027272467ff7c5f866ef8943c590710b476fafa45b21c10e1faf0f4b58c209334e06148caf979e2bd50be4aab438e46d67341fa3de0499a56

data/.rubocop.yml

@@ -36,6 +36,11 @@ Style/RedundantRegexpEscape:
 Style/SlicingWithRange:
   Enabled: true
 
+# Disable this cop until this isssue gets a clear answer:
+# https://github.com/rubocop/rubocop/issues/10675
+Gemspec/DeprecatedAttributeAssignment:
+  Enabled: false
+
 AllCops:
   TargetRubyVersion: 2.5
   Exclude:

data/CHANGELOG.md

@@ -1,5 +1,26 @@
 # Changelog
 
+## [2.5.4](https://github.com/solidusio/solidus_dev_support/tree/2.5.4) (2022-05-31)
+
+[Full Changelog](https://github.com/solidusio/solidus_dev_support/compare/v2.5.2...2.5.4)
+
+**Fixed bugs:**
+
+- Add a missing require for octokit/repository [\#185](https://github.com/solidusio/solidus_dev_support/pull/185) ([elia](https://github.com/elia))
+- Fix window resizing of `solidus_chrome_headless` driver  [\#184](https://github.com/solidusio/solidus_dev_support/pull/184) ([gsmendoza](https://github.com/gsmendoza))
+
+## [v2.5.2](https://github.com/solidusio/solidus_dev_support/tree/v2.5.2) (2021-11-23)
+
+[Full Changelog](https://github.com/solidusio/solidus_dev_support/compare/v2.5.1...v2.5.2)
+
+**Merged pull requests:**
+
+- Loosen webdrivers constraint in solidus\_dev\_support [\#180](https://github.com/solidusio/solidus_dev_support/pull/180) ([gsmendoza](https://github.com/gsmendoza))
+
+## [v2.5.1](https://github.com/solidusio/solidus_dev_support/tree/v2.5.1) (2021-08-31)
+
+[Full Changelog](https://github.com/solidusio/solidus_dev_support/compare/v2.5.0...v2.5.1)
+
 ## [v2.5.0](https://github.com/solidusio/solidus_dev_support/tree/v2.5.0) (2021-04-20)
 
 [Full Changelog](https://github.com/solidusio/solidus_dev_support/compare/v2.4.3...v2.5.0)

data/lib/solidus_dev_support/rake_tasks.rb

@@ -13,7 +13,7 @@ module SolidusDevSupport
 
     def initialize(root: Dir.pwd)
       @root = Pathname(root)
-      @test_app_path = @root.join(ENV['DUMMY_PATH'] || 'spec/dummy')
+      @test_app_path = @root.join(ENV.fetch('DUMMY_PATH', 'spec/dummy'))
       @gemspec = Bundler.load_gemspec(@root.glob("{,*}.gemspec").first)
     end
 
@@ -43,7 +43,7 @@ module SolidusDevSupport
           cd root
         end
 
-        directory ENV['DUMMY_PATH'] do
+        directory ENV.fetch('DUMMY_PATH', nil) do
           Rake::Task['extension:test_app'].invoke
         end
       end
@@ -61,7 +61,7 @@ module SolidusDevSupport
       require 'rspec/core/rake_task'
 
       namespace :extension do
-        ::RSpec::Core::RakeTask.new(:specs, [] => FileList[ENV['DUMMY_PATH']]) do |t|
+        ::RSpec::Core::RakeTask.new(:specs, [] => FileList[ENV.fetch('DUMMY_PATH', nil)]) do |t|
           # Ref: https://circleci.com/docs/2.0/configuration-reference#store_test_results
           # Ref: https://github.com/solidusio/circleci-orbs-extensions#test-results-rspec
           if ENV['TEST_RESULTS_PATH']
@@ -78,11 +78,12 @@ module SolidusDevSupport
 
       GitHubChangelogGenerator::RakeTask.new(:changelog) do |config|
         require 'octokit'
+        require 'octokit/repository'
         repo = Octokit::Repository.from_url(gemspec.metadata['source_code_uri'] || gemspec.homepage)
 
         config.user = repo.owner
         config.project = repo.name
-        config.future_release = "v#{ENV['UNRELEASED_VERSION'] || gemspec.version}"
+        config.future_release = "v#{ENV.fetch('UNRELEASED_VERSION') { gemspec.version }}"
 
       rescue Octokit::InvalidRepository
         warn <<~WARN

data/lib/solidus_dev_support/rspec/capybara.rb

@@ -3,16 +3,20 @@
 require 'webdrivers/chromedriver'
 
 # Allow to override the initial windows size
-CAPYBARA_WINDOW_SIZE = (ENV['CAPYBARA_WINDOW_SIZE'] || '1920x1080').split('x', 2).map(&:to_i)
+CAPYBARA_WINDOW_SIZE = ENV.fetch('CAPYBARA_WINDOW_SIZE', '1920x1080').split('x', 2).map(&:to_i)
+CAPYBARA_WINDOW_WIDTH = CAPYBARA_WINDOW_SIZE[0]
+CAPYBARA_WINDOW_HEIGHT = CAPYBARA_WINDOW_SIZE[1]
 
-Capybara.javascript_driver = (ENV['CAPYBARA_JAVASCRIPT_DRIVER'] || "solidus_chrome_headless").to_sym
+Capybara.javascript_driver = ENV.fetch('CAPYBARA_JAVASCRIPT_DRIVER', "solidus_chrome_headless").to_sym
 Capybara.default_max_wait_time = 10
 Capybara.server = :puma, { Silent: true } # A fix for rspec/rspec-rails#1897
 
 Capybara.drivers[:selenium_chrome_headless].tap do |original_driver|
   Capybara.register_driver :solidus_chrome_headless do |app|
     original_driver.call(app).tap do |driver|
-      driver.options[:options].args << "--window-size=#{CAPYBARA_WINDOW_SIZE.join(',')}"
+      driver.resize_window_to(
+        driver.current_window_handle, CAPYBARA_WINDOW_WIDTH, CAPYBARA_WINDOW_HEIGHT
+      )
     end
   end
 end

data/lib/solidus_dev_support/rspec/spec_helper.rb

@@ -14,7 +14,7 @@ RSpec.configure do |config|
   config.mock_with :rspec
   config.color = true
 
-  config.fail_fast = ENV['FAIL_FAST'] || false
+  config.fail_fast = ENV.fetch('FAIL_FAST', false)
   config.order = 'random'
 
   config.raise_errors_for_deprecations!

data/lib/solidus_dev_support/templates/extension/.circleci/config.yml

@@ -1,6 +1,9 @@
 version: 2.1
 
 orbs:
+  # Required for feature specs.
+  browser-tools: circleci/browser-tools@1.1
+
   # Always take the latest version of the orb, this allows us to
   # run specs against Solidus supported versions only without the need
   # to change this configuration every time a Solidus version is released
@@ -11,14 +14,17 @@ jobs:
   run-specs-with-postgres:
     executor: solidusio_extensions/postgres
     steps:
+      - browser-tools/install-browser-tools
       - solidusio_extensions/run-tests
   run-specs-with-mysql:
     executor: solidusio_extensions/mysql
     steps:
+      - browser-tools/install-browser-tools
       - solidusio_extensions/run-tests
   lint-code:
     executor: solidusio_extensions/sqlite-memory
     steps:
+      - browser-tools/install-browser-tools
       - solidusio_extensions/lint-code
 
 workflows:

data/lib/solidus_dev_support/templates/extension/Gemfile

@@ -14,7 +14,7 @@ gem 'rails', '>0.a'
 # Provides basic authentication functionality for testing parts of your engine
 gem 'solidus_auth_devise'
 
-case ENV['DB']
+case ENV.fetch('DB', nil)
 when 'mysql'
   gem 'mysql2'
 when 'postgresql'

data/lib/solidus_dev_support/version.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 module SolidusDevSupport
-  VERSION = "2.5.1"
+  VERSION = "2.5.4"
 
   def self.gem_version
     Gem::Version.new(VERSION)

data/solidus_dev_support.gemspec

@@ -15,6 +15,7 @@ Gem::Specification.new do |spec|
   spec.metadata['homepage_uri'] = spec.homepage
   spec.metadata['source_code_uri'] = 'https://github.com/solidusio/solidus_dev_support'
   spec.metadata['changelog_uri'] = 'https://github.com/solidusio/solidus_dev_support/blob/master/CHANGELOG.md'
+  spec.metadata['rubygems_mfa_required'] = 'true'
 
   spec.required_ruby_version = '>= 2.5.0'
 
@@ -45,7 +46,7 @@ Gem::Specification.new do |spec|
   spec.add_dependency 'rubocop-rails', '~> 2.3'
   spec.add_dependency 'rubocop-rspec', '~> 2.0'
   spec.add_dependency 'solidus_core', ['>= 2.0', '< 4']
-  spec.add_dependency 'webdrivers', '~> 4.4'
+  spec.add_dependency 'webdrivers', '>= 4.4'
 
   spec.add_development_dependency 'bundler'
   spec.add_development_dependency 'rake'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: solidus_dev_support
 version: !ruby/object:Gem::Version
-  version: 2.5.1
+  version: 2.5.4
 platform: ruby
 authors:
 - Alessandro Desantis
-autorequire:
+autorequire: 
 bindir: exe
 cert_chain: []
-date: 2021-08-31 00:00:00.000000000 Z
+date: 2022-05-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: capybara
@@ -270,14 +270,14 @@ dependencies:
   name: webdrivers
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '4.4'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '4.4'
 - !ruby/object:Gem::Dependency
@@ -308,7 +308,7 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-description:
+description: 
 email:
 - alessandrodesantis@nebulab.it
 executables:
@@ -396,7 +396,8 @@ metadata:
   homepage_uri: https://github.com/solidusio/solidus_dev_support
   source_code_uri: https://github.com/solidusio/solidus_dev_support
   changelog_uri: https://github.com/solidusio/solidus_dev_support/blob/master/CHANGELOG.md
-post_install_message:
+  rubygems_mfa_required: 'true'
+post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
@@ -411,8 +412,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.20
-signing_key:
+rubygems_version: 3.0.3.1
+signing_key: 
 specification_version: 4
 summary: Development tools for Solidus extensions.
 test_files: