solidus_dev_support 1.6.0 → 2.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 57ffc454eba9fcbba02fb86c44287829fff79b729667b7337e3acf2c7fa09528
-  data.tar.gz: 1e408fd52a16aa8bafb5a87d8180661bf2e43126a61203916c0bee70b3dbe13d
+  metadata.gz: ca90c2de99b0e00b59747e9aaf0cc9149adcdbd0568311d4fbc7a921fa61b9e0
+  data.tar.gz: c0063153a36c95f8b3fa8f406b46b412242bfef54055857b3f109de682966e6c
 SHA512:
-  metadata.gz: 754b6f714db2c8436875c69c9af9aabe018f321c5ea12b683657d56e5a1e6595fb7f16f965cf5ea6701bcd5ea6e0f3c10a27fabd4d07f9abc815f9b1499046d2
-  data.tar.gz: c2f11a1b7bd1983dca96baf5a9f62f61b237ff6402657ba4bba72e91133e3a835887e4f9d15a1a423d8236d035516eddc64dab4ff1ba194c39c3c1ca4216f08f
+  metadata.gz: 4e59dc8c12d5fde03a58a67102e72194a34a7dd19df88b79b4e59ba9d77900fcdeb6b3216c31618a429ada33bb8558548e3854105e2a17e7b126b4f651a7d4dc
+  data.tar.gz: 3c6f158eb5ed20f1eec861a7fc971a7bbdd296bd8529afa61f434ba23933d7843456714cbb3c657cffecee90c0d8ff642a6920c31d89dd464c42684342c02079

data/.circleci/config.yml

@@ -11,7 +11,9 @@ commands:
   setup:
     steps:
       - checkout
-      - run: "gem install bundler -v '>=2' --conservative"
+      - run:
+          command: "gem install bundler -v '>=2' --conservative"
+          no_output_timeout: 20m
 
 jobs:
   solidus-master:

data/CHANGELOG.md

@@ -4,8 +4,15 @@
 
 [Full Changelog](https://github.com/solidusio/solidus_dev_support/compare/v1.5.0...HEAD)
 
+**Breaking changes:**
+
+- Switch the JS driver to WebDriver/Selenium [\#136](https://github.com/solidusio/solidus_dev_support/pull/136) ([elia](https://github.com/elia))
+
 **Implemented enhancements:**
 
+- Enable new RuboCop cops automatically [\#143](https://github.com/solidusio/solidus_dev_support/pull/143) ([aldesantis](https://github.com/aldesantis))
+- Don't forcefully close issues via stale-bot [\#139](https://github.com/solidusio/solidus_dev_support/pull/139) ([elia](https://github.com/elia))
+- Add the approximate recommendation for dev-support to the gemspec [\#137](https://github.com/solidusio/solidus_dev_support/pull/137) ([elia](https://github.com/elia))
 - Let the extension name include spaces [\#133](https://github.com/solidusio/solidus_dev_support/pull/133) ([elia](https://github.com/elia))
 - Add precompiled badges fro CI and coverage [\#132](https://github.com/solidusio/solidus_dev_support/pull/132) ([elia](https://github.com/elia))
 - Add Changelog Rake task [\#128](https://github.com/solidusio/solidus_dev_support/pull/128) ([tvdeyen](https://github.com/tvdeyen))
@@ -13,6 +20,9 @@
 
 **Fixed bugs:**
 
+- fix capybara driver declaration [\#141](https://github.com/solidusio/solidus_dev_support/pull/141) ([ccarruitero](https://github.com/ccarruitero))
+- Bump RuboCop to latest 0.90.0 version [\#138](https://github.com/solidusio/solidus_dev_support/pull/138) ([peterberkenbosch](https://github.com/peterberkenbosch))
+- Fix missing backslash in solidus install command [\#135](https://github.com/solidusio/solidus_dev_support/pull/135) ([nirebu](https://github.com/nirebu))
 - Don't install a payment-method in the sandbox [\#131](https://github.com/solidusio/solidus_dev_support/pull/131) ([elia](https://github.com/elia))
 - Run extension generator in sandbox [\#127](https://github.com/solidusio/solidus_dev_support/pull/127) ([elia](https://github.com/elia))
 

data/lib/solidus_dev_support/rspec/capybara.rb

@@ -0,0 +1,18 @@
+# frozen_string_literal: true
+
+# Allow to override the initial windows size
+CAPYBARA_WINDOW_SIZE = (ENV['CAPYBARA_WINDOW_SIZE'] || '1920x1080').split('x', 2).map(&:to_i)
+
+Capybara.javascript_driver = (ENV['CAPYBARA_JAVASCRIPT_DRIVER'] || "solidus_chrome_headless").to_sym
+Capybara.default_max_wait_time = 10
+Capybara.server = :puma, { Silent: true } # A fix for rspec/rspec-rails#1897
+
+Capybara.drivers[:selenium_chrome_headless].tap do |original_driver|
+  Capybara.register_driver :solidus_chrome_headless do |app|
+    original_driver.call(app).tap do |driver|
+      driver.options[:options].args << "--window-size=#{CAPYBARA_WINDOW_SIZE.join(',')}"
+    end
+  end
+end
+
+require 'spree/testing_support/capybara_ext'

data/lib/solidus_dev_support/rspec/feature_helper.rb

@@ -10,17 +10,7 @@
 require 'solidus_dev_support/rspec/rails_helper'
 
 require 'capybara-screenshot/rspec'
-require 'capybara/apparition'
-
-Capybara.javascript_driver = (ENV['CAPYBARA_DRIVER'] || :apparition).to_sym
-Capybara.default_max_wait_time = 10
-Capybara.server = :puma, { Silent: true } # A fix for rspec/rspec-rails#1897
-
-Capybara.register_driver :apparition do |app|
-  Capybara::Apparition::Driver.new(app, window_size: [1920, 1080])
-end
-
-require 'spree/testing_support/capybara_ext'
+require 'solidus_dev_support/rspec/capybara'
 
 def dev_support_assets_preload
   if Rails.application.respond_to?(:precompiled_assets)

data/lib/solidus_dev_support/rubocop/config.yml

@@ -1,6 +1,6 @@
 require: ["rubocop-rspec", "rubocop-rails", "rubocop-performance"]
 
-AllCops: {TargetRubyVersion: 2.5, Exclude: ["spec/dummy/**/*", "sandbox/**/*", "vendor/**/*"]}
+AllCops: {TargetRubyVersion: 2.5, Exclude: ["spec/dummy/**/*", "sandbox/**/*", "vendor/**/*"], NewCops: enable}
 
 Layout/ArgumentAlignment: {EnforcedStyle: with_fixed_indentation}
 Layout/DotPosition: {Enabled: false, StyleGuide: "https://relaxed.ruby.style/#layoutdotposition"}

data/lib/solidus_dev_support/templates/extension/.github/stale.yml

@@ -1,17 +1,17 @@
 # Number of days of inactivity before an issue becomes stale
 daysUntilStale: 60
 # Number of days of inactivity before a stale issue is closed
-daysUntilClose: 7
+daysUntilClose: false
 # Issues with these labels will never be considered stale
 exemptLabels:
   - pinned
   - security
 # Label to use when marking an issue as stale
-staleLabel: wontfix
+staleLabel: stale
 # Comment to post when marking an issue as stale. Set to `false` to disable
 markComment: >
   This issue has been automatically marked as stale because it has not had
-  recent activity. It will be closed if no further activity occurs. Thank you
+  recent activity. It might be closed if no further activity occurs. Thank you
   for your contributions.
 # Comment to post when closing a stale issue. Set to `false` to disable
-closeComment: false
+closeComment: false

data/lib/solidus_dev_support/templates/extension/README.md

@@ -84,7 +84,11 @@ git commit -m "Update the changelog"
 Your new extension version can be released using `gem-release` like this:
 
 ```shell
-bundle exec gem bump -v VERSION --tag --push --remote origin && gem release
+bundle exec gem bump -v 1.6.0
+bin/rake changelog
+git commit -a --amend
+git push
+bundle exec gem release
 ```
 
 ## License

data/lib/solidus_dev_support/templates/extension/bin/sandbox.tt

@@ -72,7 +72,7 @@ unbundled bundle exec rails generate spree:install \
   --user_class=Spree::User \
   --enforce_available_locales=true \
   --with-authentication=false \
-  --payment-method=none
+  --payment-method=none \
   $@
 
 unbundled bundle exec rails generate solidus:auth:install

data/lib/solidus_dev_support/templates/extension/extension.gemspec.tt

@@ -32,5 +32,5 @@ Gem::Specification.new do |spec|
   spec.add_dependency 'solidus_core', ['>= 2.0.0', '< 3']
   spec.add_dependency 'solidus_support', '~> 0.5'
 
-  spec.add_development_dependency 'solidus_dev_support'
+  spec.add_development_dependency 'solidus_dev_support', '<%= SolidusDevSupport.gem_version.approximate_recommendation %>'
 end

data/lib/solidus_dev_support/version.rb

@@ -1,5 +1,9 @@
 # frozen_string_literal: true
 
 module SolidusDevSupport
-  VERSION = "1.6.0"
+  VERSION = "2.0.0"
+
+  def self.gem_version
+    Gem::Version.new(VERSION)
+  end
 end

data/solidus_dev_support.gemspec

@@ -28,7 +28,6 @@ Gem::Specification.new do |spec|
   spec.executables = files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
 
-  spec.add_dependency 'apparition', '~> 0.4'
   spec.add_dependency 'capybara', '~> 3.29'
   spec.add_dependency 'capybara-screenshot', '~> 1.0'
   spec.add_dependency 'codecov', '~> 0.2'
@@ -40,11 +39,12 @@ Gem::Specification.new do |spec|
   spec.add_dependency 'puma', '~> 4.3'
   spec.add_dependency 'rspec_junit_formatter'
   spec.add_dependency 'rspec-rails', '~> 4.0.0.beta3'
-  spec.add_dependency 'rubocop', '~> 0.87.1'
+  spec.add_dependency 'rubocop', '~> 0.90'
   spec.add_dependency 'rubocop-performance', '~> 1.5'
   spec.add_dependency 'rubocop-rails', '~> 2.3'
   spec.add_dependency 'rubocop-rspec', '~> 1.36'
   spec.add_dependency 'solidus_core', ['>= 2.0', '< 3']
+  spec.add_dependency 'webdrivers', '~> 4.4'
 
   spec.add_development_dependency 'bundler'
   spec.add_development_dependency 'rake'

data/spec/features/create_extension_spec.rb

@@ -21,13 +21,18 @@ RSpec.describe 'Create extension' do
     mkdir_p(tmp_path)
   end
 
+  def step(method_name)
+    puts "Step #{method_name}"
+    send method_name
+  end
+
   it 'checks the create extension process' do
-    check_solidus_cmd
-    check_create_extension
-    check_bundle_install
-    check_default_task
-    check_run_specs
-    check_sandbox
+    step :check_solidus_cmd
+    step :check_create_extension
+    step :check_bundle_install
+    step :check_default_task
+    step :check_run_specs
+    step :check_sandbox
   end
 
   private

metadata

@@ -1,29 +1,15 @@
 --- !ruby/object:Gem::Specification
 name: solidus_dev_support
 version: !ruby/object:Gem::Version
-  version: 1.6.0
+  version: 2.0.0
 platform: ruby
 authors:
 - Alessandro Desantis
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2020-08-26 00:00:00.000000000 Z
+date: 2020-09-22 00:00:00.000000000 Z
 dependencies:
-- !ruby/object:Gem::Dependency
-  name: apparition
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.4'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.4'
 - !ruby/object:Gem::Dependency
   name: capybara
   requirement: !ruby/object:Gem::Requirement
@@ -184,14 +170,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.87.1
+        version: '0.90'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.87.1
+        version: '0.90'
 - !ruby/object:Gem::Dependency
   name: rubocop-performance
   requirement: !ruby/object:Gem::Requirement
@@ -254,6 +240,20 @@ dependencies:
     - - "<"
       - !ruby/object:Gem::Version
         version: '3'
+- !ruby/object:Gem::Dependency
+  name: webdrivers
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '4.4'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '4.4'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -313,6 +313,7 @@ files:
 - lib/solidus_dev_support.rb
 - lib/solidus_dev_support/extension.rb
 - lib/solidus_dev_support/rake_tasks.rb
+- lib/solidus_dev_support/rspec/capybara.rb
 - lib/solidus_dev_support/rspec/coverage.rb
 - lib/solidus_dev_support/rspec/feature_helper.rb
 - lib/solidus_dev_support/rspec/rails_helper.rb
@@ -379,7 +380,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.4
+rubygems_version: 3.1.2
 signing_key:
 specification_version: 4
 summary: Development tools for Solidus extensions.