solidus_dev_support 1.5.0 → 2.2.0

data/lib/solidus_dev_support/templates/extension/bin/sandbox.tt

@@ -72,9 +72,11 @@ unbundled bundle exec rails generate spree:install \
   --user_class=Spree::User \
   --enforce_available_locales=true \
   --with-authentication=false \
+  --payment-method=none \
   $@
 
 unbundled bundle exec rails generate solidus:auth:install
+unbundled bundle exec rails generate ${extension_name}:install
 
 echo
 echo "🚀 Sandbox app successfully created for $extension_name!"

data/lib/solidus_dev_support/templates/extension/extension.gemspec.tt

@@ -9,12 +9,12 @@ Gem::Specification.new do |spec|
   spec.email = '<%= gemspec.email %>'
 
   spec.summary = '<%= gemspec.summary %>'
-  spec.description = '<%= gemspec.description %>'
-  spec.homepage = '<%= gemspec.homepage %>'
+  <% if gemspec.description %>spec.description = '<%= gemspec.description %>'
+  <% end %>spec.homepage = '<%= gemspec.homepage %>'
   spec.license = '<%= gemspec.license %>'
 
   spec.metadata['homepage_uri'] = spec.homepage
-  spec.metadata['source_code_uri'] = '<%= gemspec.homepage %>'
+  spec.metadata['source_code_uri'] = '<%= gemspec.metadata["source_code_uri"] %>'
   spec.metadata['changelog_uri'] = '<%= gemspec.metadata["changelog_uri"] %>'
 
   spec.required_ruby_version = Gem::Requirement.new('~> 2.5')
@@ -32,5 +32,5 @@ Gem::Specification.new do |spec|
   spec.add_dependency 'solidus_core', ['>= 2.0.0', '< 3']
   spec.add_dependency 'solidus_support', '~> 0.5'
 
-  spec.add_development_dependency 'solidus_dev_support'
+  spec.add_development_dependency 'solidus_dev_support', '<%= SolidusDevSupport.gem_version.approximate_recommendation %>'
 end

data/lib/solidus_dev_support/templates/extension/github_changelog_generator

@@ -0,0 +1,2 @@
+issues=false
+exclude-labels=infrastructure

data/lib/solidus_dev_support/templates/extension/lib/%file_name%.rb.tt

@@ -3,5 +3,6 @@
 require 'solidus_core'
 require 'solidus_support'
 
+require '<%=file_name%>/configuration'
 require '<%=file_name%>/version'
 require '<%=file_name%>/engine'

data/lib/solidus_dev_support/templates/extension/lib/%file_name%/configuration.rb.tt

@@ -0,0 +1,21 @@
+# frozen_string_literal: true
+
+module <%= class_name %>
+  class Configuration
+    # Define here the settings for this extensions, e.g.:
+    #
+    # attr_accessor :my_setting
+  end
+
+  class << self
+    def configuration
+      @configuration ||= Configuration.new
+    end
+
+    alias config configuration
+
+    def configure
+      yield configuration
+    end
+  end
+end

data/lib/solidus_dev_support/templates/extension/lib/generators/%file_name%/install/install_generator.rb.tt

@@ -4,15 +4,20 @@ module <%= class_name %>
   module Generators
     class InstallGenerator < Rails::Generators::Base
       class_option :auto_run_migrations, type: :boolean, default: false
+      source_root File.expand_path('templates', __dir__)
+
+      def copy_initializer
+        template 'initializer.rb', 'config/initializers/<%= file_name %>.rb'
+      end
 
       def add_javascripts
-        append_file 'vendor/assets/javascripts/spree/frontend/all.js', "//= require spree/frontend/<%= file_name %>\n" # rubocop:disable Metrics/LineLength
-        append_file 'vendor/assets/javascripts/spree/backend/all.js', "//= require spree/backend/<%= file_name %>\n" # rubocop:disable Metrics/LineLength
+        append_file 'vendor/assets/javascripts/spree/frontend/all.js', "//= require spree/frontend/<%= file_name %>\n"
+        append_file 'vendor/assets/javascripts/spree/backend/all.js', "//= require spree/backend/<%= file_name %>\n"
       end
 
       def add_stylesheets
-        inject_into_file 'vendor/assets/stylesheets/spree/frontend/all.css', " *= require spree/frontend/<%= file_name %>\n", before: %r{\*/}, verbose: true # rubocop:disable Metrics/LineLength
-        inject_into_file 'vendor/assets/stylesheets/spree/backend/all.css', " *= require spree/backend/<%= file_name %>\n", before: %r{\*/}, verbose: true # rubocop:disable Metrics/LineLength
+        inject_into_file 'vendor/assets/stylesheets/spree/frontend/all.css', " *= require spree/frontend/<%= file_name %>\n", before: %r{\*/}, verbose: true # rubocop:disable Layout/LineLength
+        inject_into_file 'vendor/assets/stylesheets/spree/backend/all.css', " *= require spree/backend/<%= file_name %>\n", before: %r{\*/}, verbose: true # rubocop:disable Layout/LineLength
       end
 
       def add_migrations
@@ -20,7 +25,7 @@ module <%= class_name %>
       end
 
       def run_migrations
-        run_migrations = options[:auto_run_migrations] || ['', 'y', 'Y'].include?(ask('Would you like to run the migrations now? [Y/n]')) # rubocop:disable Metrics/LineLength
+        run_migrations = options[:auto_run_migrations] || ['', 'y', 'Y'].include?(ask('Would you like to run the migrations now? [Y/n]')) # rubocop:disable Layout/LineLength
         if run_migrations
           run 'bin/rails db:migrate'
         else

data/lib/solidus_dev_support/templates/extension/lib/generators/%file_name%/install/templates/initializer.rb.tt

@@ -0,0 +1,6 @@
+# frozen_string_literal: true
+
+<%= class_name %>.configure do |config|
+  # TODO: Remember to change this with the actual preferences you have implemented!
+  # config.sample_preference = 'sample_value'
+end

data/lib/solidus_dev_support/templates/extension/rubocop.yml

@@ -1,2 +1,5 @@
 require:
   - solidus_dev_support/rubocop
+
+AllCops:
+  NewCops: disable

data/lib/solidus_dev_support/templates/extension/spec/spec_helper.rb.tt

@@ -6,22 +6,26 @@ ENV['RAILS_ENV'] = 'test'
 # Run Coverage report
 require 'solidus_dev_support/rspec/coverage'
 
-require File.expand_path('dummy/config/environment.rb', __dir__).tap { |file|
-  # Create the dummy app if it's still missing.
-  system 'bin/rake extension:test_app' unless File.exist? file
-}
+# Create the dummy app if it's still missing.
+dummy_env = "#{__dir__}/dummy/config/environment.rb"
+system 'bin/rake extension:test_app' unless File.exist? dummy_env
+require dummy_env
 
 # Requires factories and other useful helpers defined in spree_core.
 require 'solidus_dev_support/rspec/feature_helper'
 
 # Requires supporting ruby files with custom matchers and macros, etc,
 # in spec/support/ and its subdirectories.
-Dir[File.join(File.dirname(__FILE__), 'support/**/*.rb')].each { |f| require f }
+Dir["#{__dir__}/support/**/*.rb"].sort.each { |f| require f }
 
-# Requires factories defined in lib/<%= file_name %>/factories.rb
-require '<%= file_name %>/factories'
+# Requires factories defined in lib/<%= file_name %>/testing_support/factories.rb
+require '<%= file_name %>/testing_support/factories'
 
 RSpec.configure do |config|
   config.infer_spec_type_from_file_location!
   config.use_transactional_fixtures = false
+
+  if Spree.solidus_gem_version < Gem::Version.new('2.11')
+    config.extend Spree::TestingSupport::AuthorizationHelpers::Request, type: :system
+  end
 end

data/lib/solidus_dev_support/version.rb

@@ -1,5 +1,9 @@
 # frozen_string_literal: true
 
 module SolidusDevSupport
-  VERSION = "1.5.0"
+  VERSION = "2.2.0"
+
+  def self.gem_version
+    Gem::Version.new(VERSION)
+  end
 end

data/solidus_dev_support.gemspec

@@ -1,8 +1,6 @@
 # frozen_string_literal: true
 
-lib = File.expand_path('lib', __dir__)
-$LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
-require 'solidus_dev_support/version'
+require_relative 'lib/solidus_dev_support/version'
 
 Gem::Specification.new do |spec|
   spec.name = 'solidus_dev_support'
@@ -16,33 +14,37 @@ Gem::Specification.new do |spec|
 
   spec.metadata['homepage_uri'] = spec.homepage
   spec.metadata['source_code_uri'] = 'https://github.com/solidusio/solidus_dev_support'
+  spec.metadata['changelog_uri'] = 'https://github.com/solidusio/solidus_dev_support/blob/master/CHANGELOG.md'
+
+  spec.required_ruby_version = Gem::Requirement.new('~> 2.5')
 
   # Specify which files should be added to the gem when it is released.
   # The `git ls-files -z` loads the files in the RubyGem that have been added into git.
-  spec.files = Dir.chdir(File.expand_path(__dir__)) do
-    `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
-  end
-  spec.bindir = 'exe'
-  spec.executables = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
-  spec.require_paths = ['lib']
-
-  spec.add_dependency 'apparition', '~> 0.4'
+  files = Dir.chdir(__dir__) { `git ls-files -z`.split("\x0") }
+
+  spec.files = files.grep_v(%r{^(test|spec|features)/})
+  spec.test_files = files.grep(%r{^(test|spec|features)/})
+  spec.bindir = "exe"
+  spec.executables = files.grep(%r{^exe/}) { |f| File.basename(f) }
+  spec.require_paths = ["lib"]
+
   spec.add_dependency 'capybara', '~> 3.29'
   spec.add_dependency 'capybara-screenshot', '~> 1.0'
-  spec.add_dependency 'codecov', '~> 0.1.16'
+  spec.add_dependency 'codecov', '~> 0.2'
   spec.add_dependency 'database_cleaner', '~> 1.7'
   spec.add_dependency 'factory_bot_rails', '~> 5.1'
   spec.add_dependency 'ffaker', '~> 2.13'
   spec.add_dependency 'gem-release', '~> 2.1'
   spec.add_dependency 'github_changelog_generator', '~> 1.15'
   spec.add_dependency 'puma', '~> 4.3'
-  spec.add_dependency 'rspec-rails', '~> 4.0.0.beta3'
   spec.add_dependency 'rspec_junit_formatter'
-  spec.add_dependency 'rubocop', '~> 0.76.0'
+  spec.add_dependency 'rspec-rails', '~> 4.0.0.beta3'
+  spec.add_dependency 'rubocop', '~> 1.0'
   spec.add_dependency 'rubocop-performance', '~> 1.5'
   spec.add_dependency 'rubocop-rails', '~> 2.3'
   spec.add_dependency 'rubocop-rspec', '~> 1.36'
   spec.add_dependency 'solidus_core', ['>= 2.0', '< 3']
+  spec.add_dependency 'webdrivers', '~> 4.4'
 
   spec.add_development_dependency 'bundler'
   spec.add_development_dependency 'rake'

data/spec/features/create_extension_spec.rb

@@ -0,0 +1,187 @@
+# frozen_string_literal: true
+
+require 'fileutils'
+require 'open3'
+require 'spec_helper'
+require 'spree/core/version'
+
+RSpec.describe 'Create extension' do
+  include FileUtils
+
+  let(:gem_root) { File.expand_path('../..', __dir__) }
+  let(:solidus_cmd) { "#{gem_root}/exe/solidus" }
+  let(:extension_name) { 'test_extension' }
+  let(:gemspec_name) { "solidus_#{extension_name}.gemspec" }
+  let(:tmp_path) { Pathname.new(gem_root).join('tmp') }
+  let(:install_path) { tmp_path.join("solidus_#{extension_name}") }
+  let(:command_failed_error) { Class.new(StandardError) }
+
+  before do
+    rm_rf(install_path)
+    mkdir_p(tmp_path)
+  end
+
+  def step(method_name)
+    puts "Step #{method_name}"
+    send method_name
+  end
+
+  it 'checks the create extension process' do
+    step :check_solidus_cmd
+    step :check_gem_version
+    step :check_create_extension
+    step :check_bundle_install
+    step :check_default_task
+    step :check_run_specs
+    step :check_sandbox
+  end
+
+  private
+
+  def check_solidus_cmd
+    cd(tmp_path) do
+      output = `#{solidus_cmd} -h`
+      expect($?).to be_success
+      expect(output).to include('Commands:')
+    end
+  end
+
+  def check_gem_version
+    gem_version_commands = ['version', '--version', '-v']
+    gem_version = SolidusDevSupport::VERSION
+    solidus_version = Spree.solidus_gem_version
+
+    cd(tmp_path) do
+      gem_version_commands.each do |gem_version_cmd|
+        output = `#{solidus_cmd} #{gem_version_cmd}`
+        expect($?).to be_success
+        expect(output).to include("Solidus version #{solidus_version}")
+        expect(output).to include("Solidus Dev Support version #{gem_version}")
+      end
+    end
+  end
+
+  def check_create_extension
+    cd(tmp_path) do
+      output = `#{solidus_cmd} extension #{extension_name}`
+      expect($?).to be_success
+      expect(output).to include(gemspec_name)
+      expect(output).to include('.circleci')
+    end
+
+    cd(install_path) do
+      aggregate_failures do
+        %w[
+          bin/console
+          bin/rails
+          bin/rails-engine
+          bin/rails-sandbox
+          bin/sandbox
+          bin/setup
+        ].each do |bin|
+          bin = Pathname(bin)
+          expect(
+            name: bin,
+            exist: bin.exist?,
+            executable: bin.stat.executable?
+          ).to eq(
+            name: bin,
+            exist: true,
+            executable: true
+          )
+        end
+      end
+    end
+  end
+
+  def check_bundle_install
+    cd(install_path) do
+      open('Gemfile', 'a') { |f| f.puts "gem 'solidus_dev_support', path: '../../..'" }
+    end
+
+    expect { bundle_install }.to raise_error(command_failed_error, /invalid gemspec/)
+
+    # Update gemspec with the required fields
+    gemspec_path = install_path.join(gemspec_name)
+    gemspec = gemspec_path.read.lines
+    gemspec.grep(/spec\.author/).first.replace("  spec.author = 'John Doe'\n")
+    gemspec.grep(/spec\.email/).first.replace("  spec.email = 'john@example.com'\n")
+    gemspec.grep(/spec\.summary/).first.replace("  spec.summary = 'A nice extension'\n")
+    gemspec.grep(/spec\.description/).first.replace("  spec.description = 'A super nice extension'\n")
+    gemspec_path.write(gemspec.join)
+
+    expect(bundle_install).to match(/Bundle complete/)
+  end
+
+  def check_default_task
+    cd(install_path) do
+      output = sh('bin/rake')
+      expect(output).to include('Generating dummy Rails application')
+      expect(output).to include('0 examples, 0 failures')
+    end
+  end
+
+  def check_run_specs
+    install_path.join('spec', 'some_spec.rb').write(
+      "require 'spec_helper'\nRSpec.describe 'Some test' do it { expect(true).to be_truthy } end\n"
+    )
+    cd(install_path) do
+      output = sh('bundle exec rspec')
+      expect(output).to include('1 example, 0 failures')
+      expect(output).to include(ENV['CODECOV_TOKEN'] ? 'Coverage reports upload successfully' : 'Provide a CODECOV_TOKEN environment variable to enable Codecov uploads')
+    end
+  end
+
+  def check_sandbox
+    cd(install_path) do
+      # rubocop:disable Lint/InterpolationCheck
+      command = 'bin/rails-sandbox runner "puts %{The version of SolidusTestExtension is #{SolidusTestExtension::VERSION}}"'
+      # rubocop:enable Lint/InterpolationCheck
+
+      first_run_output = sh(command)
+      expect(first_run_output).to include("Creating the sandbox app...")
+      expect(first_run_output).to include('The version of SolidusTestExtension is 0.0.1')
+
+      second_run_output = sh(command)
+      expect(second_run_output).not_to include("Creating the sandbox app...")
+      expect(second_run_output).to include('The version of SolidusTestExtension is 0.0.1')
+    end
+  end
+
+  def sh(*args)
+    command = args.size == 1 ? args.first : args.shelljoin
+    output, status = with_unbundled_env { Open3.capture2e(command) }
+
+    if status.success?
+      output.to_s
+    else
+      if $DEBUG
+        warn '~' * 80
+        warn "$ #{command}"
+        warn output.to_s
+      end
+      raise(command_failed_error, "command failed: #{command}\n#{output}")
+    end
+  end
+
+  def with_unbundled_env(&block)
+    if Bundler.respond_to?(:with_unbundled_env)
+      Bundler.with_unbundled_env(&block)
+    else
+      Bundler.with_clean_env(&block)
+    end
+  end
+
+  def bundle_install
+    # Optimize the bundle path within the CI, in this context using bundler env
+    # variables doesn't help because commands are run with a clean env.
+    bundle_path = "#{gem_root}/vendor/bundle"
+
+    command = 'bundle install'
+    command += " --path=#{bundle_path.shellescape}" if File.exist?(bundle_path)
+
+    output = nil
+    cd(install_path) { output = sh command }
+    output
+  end
+end

data/spec/lib/extension_spec.rb

@@ -0,0 +1,69 @@
+require 'solidus_dev_support/extension'
+
+RSpec.describe SolidusDevSupport::Extension do
+  describe '#path=' do
+    specify 'with an existing extension' do
+      allow(subject).to receive(:git).with('remote get-url origin', any_args).and_return('git@github.com:some_user/solidus_my_ext.git')
+      allow(subject).to receive(:git).with('config user.name', any_args).and_return('John Doe')
+      allow(subject).to receive(:git).with('config user.email', any_args).and_return('john.doe@example.com')
+
+      allow(File).to receive(:exist?).with('/foo/bar/solidus_my_ext/solidus_my_ext.gemspec').and_return(true)
+      allow(Gem::Specification).to receive(:load).with('/foo/bar/solidus_my_ext/solidus_my_ext.gemspec').and_return(
+        Gem::Specification.new('solidus_my_ext', '0.1.1') do |gem|
+          gem.author = "Jane Doe"
+          gem.email = "jane.doe@example.com"
+
+          gem.summary = 'This extension is awesome!'
+          gem.license = 'MIT'
+
+          gem.homepage = "some_user.github.io/solidus_my_ext"
+          gem.metadata['changelog_uri'] = "https://github.com/some_user/solidus_my_ext/releases"
+          gem.metadata['source_code_uri'] = "https://github.com/some_user/solidus_my_ext"
+        end
+      )
+
+      subject.path = '/foo/bar/solidus_my_ext'
+
+      aggregate_failures do
+        expect(subject.file_name).to eq("solidus_my_ext")
+        expect(subject.class_name).to eq("SolidusMyExt")
+        expect(subject.root).to eq("/foo/bar")
+        expect(subject.path).to eq("/foo/bar/solidus_my_ext")
+        expect(subject.repo).to eq("some_user/solidus_my_ext")
+        expect(subject.gemspec.author).to eq('Jane Doe')
+        expect(subject.gemspec.email).to eq('jane.doe@example.com')
+        expect(subject.gemspec.summary).to eq('This extension is awesome!')
+        expect(subject.gemspec.license).to eq('MIT')
+        expect(subject.gemspec.homepage).to eq("some_user.github.io/solidus_my_ext")
+        expect(subject.gemspec.metadata['changelog_uri']).to eq("https://github.com/some_user/solidus_my_ext/releases")
+        expect(subject.gemspec.metadata['source_code_uri']).to eq("https://github.com/some_user/solidus_my_ext")
+      end
+    end
+
+    specify 'when creating a new extension' do
+      allow(subject).to receive(:git).with('remote get-url origin', any_args) { |_, default| default }
+      allow(subject).to receive(:git).with('config user.name', any_args).and_return('John Doe')
+      allow(subject).to receive(:git).with('config user.email', any_args).and_return('john.doe@example.com')
+
+      allow(Dir).to receive(:pwd).and_return('/foo/bar')
+
+      subject.path = '/foo/bar/solidus_my_ext'
+
+      aggregate_failures do
+        expect(subject.file_name).to eq("solidus_my_ext")
+        expect(subject.class_name).to eq("SolidusMyExt")
+        expect(subject.root).to eq("/foo/bar")
+        expect(subject.path).to eq("/foo/bar/solidus_my_ext")
+        expect(subject.repo).to eq("solidusio-contrib/solidus_my_ext")
+        expect(subject.gemspec.author).to eq('John Doe')
+        expect(subject.gemspec.email).to eq('john.doe@example.com')
+        expect(subject.gemspec.summary).to eq('TODO: Write a short summary, because RubyGems requires one.')
+        expect(subject.gemspec.description).to eq('TODO: Write a longer description or delete this line.')
+        expect(subject.gemspec.license).to eq('BSD-3-Clause')
+        expect(subject.gemspec.homepage).to eq("https://github.com/solidusio-contrib/solidus_my_ext#readme")
+        expect(subject.gemspec.metadata['changelog_uri']).to eq("https://github.com/solidusio-contrib/solidus_my_ext/blob/master/CHANGELOG.md")
+        expect(subject.gemspec.metadata['source_code_uri']).to eq("https://github.com/solidusio-contrib/solidus_my_ext")
+      end
+    end
+  end
+end