solidus_dev_support 1.2.0 → 2.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 57982502f6b6cda3d014e241f319db1a59e5fb7c5b108d5c41e60e2458ce7fe3
-  data.tar.gz: 4a738944d3d5fa4789ea68c372f861a0665c0ad9347cb9bda11195b4dcf3c451
+  metadata.gz: ca90c2de99b0e00b59747e9aaf0cc9149adcdbd0568311d4fbc7a921fa61b9e0
+  data.tar.gz: c0063153a36c95f8b3fa8f406b46b412242bfef54055857b3f109de682966e6c
 SHA512:
-  metadata.gz: 65cf8c5ebb47608aaeb7aab52823d7ad8ccec81697ad922144880a971ffea891442cc1fa584b1311df120fc85e762ae06f90a1849083f0058f05c5026336f3b9
-  data.tar.gz: f013f6ee048e65a40be05b330e7472fb934c1a14a345efd7319466e976681daba40425b0723356f5f95b3ce0f1ebb65183a8397c7e3afa544b96c5741f830b7e
+  metadata.gz: 4e59dc8c12d5fde03a58a67102e72194a34a7dd19df88b79b4e59ba9d77900fcdeb6b3216c31618a429ada33bb8558548e3854105e2a17e7b126b4f651a7d4dc
+  data.tar.gz: 3c6f158eb5ed20f1eec861a7fc971a7bbdd296bd8529afa61f434ba23933d7843456714cbb3c657cffecee90c0d8ff642a6920c31d89dd464c42684342c02079

data/.circleci/config.yml

@@ -7,35 +7,27 @@ orbs:
   # or goes EOL.
   solidusio_extensions: solidusio/extensions@volatile
 
-executors:
-  # We don't rely directly on the DB, but we still want to ensure generated
-  # extensions are able to connect and spin up Solidus. Using an in-memory
-  # SQLite makes it blazingly fast.
-  sqlite-memory:
-    docker:
-       - image: circleci/ruby:2.5.6-node-browsers
-         environment:
-           RAILS_ENV: test
-           DB: sqlite
-           DATABASE_URL: sqlite3::memory:?pool=1
-           DATABASE_CLEANER_ALLOW_REMOTE_DATABASE_URL: true
-
 commands:
   setup:
     steps:
       - checkout
-      - run: "gem install bundler -v '>=2' --conservative"
+      - run:
+          command: "gem install bundler -v '>=2' --conservative"
+          no_output_timeout: 20m
 
 jobs:
   solidus-master:
-    executor: sqlite-memory
+    executor: solidusio_extensions/sqlite-memory
     steps: ['setup', 'solidusio_extensions/run-tests-solidus-master']
   solidus-current:
-    executor: sqlite-memory
+    executor: solidusio_extensions/sqlite-memory
     steps: ['setup', 'solidusio_extensions/run-tests-solidus-current']
   solidus-older:
-    executor: sqlite-memory
+    executor: solidusio_extensions/sqlite-memory
     steps: ['setup', 'solidusio_extensions/run-tests-solidus-older']
+  lint-code:
+    executor: solidusio_extensions/sqlite-memory
+    steps: ['setup', 'solidusio_extensions/lint-code']
 
 workflows:
   "Run specs on supported Solidus versions":
@@ -43,6 +35,7 @@ workflows:
       - solidus-master
       - solidus-current
       - solidus-older
+      - lint-code
 
   "Weekly run specs against master":
     triggers:

data/.github/PULL_REQUEST_TEMPLATE.md

@@ -8,4 +8,3 @@ Fixes #XXX.
 
 - [ ] I have structured the commits for clarity and conciseness.
 - [ ] I have added relevant automated tests for this change.
-- [ ] I have added an entry to the changelog for this change.

data/.github_changelog_generator

@@ -0,0 +1,4 @@
+issues=false
+exclude-labels=infrastructure
+since-tag=v1.4.0
+base=OLD_CHANGELOG.md

data/.mergify.yml

@@ -0,0 +1,39 @@
+pull_request_rules:
+  - name: request changelog labels when a PR is missing them
+    conditions:
+      - base=master
+      - -label=bug
+      - -label=enhancement
+      - -label=documentation
+      - -label=security
+      - -label=removed
+      - -label=infrastructure
+    actions:
+      label:
+        add:
+          - needs changelog label
+      comment:
+        message: |
+          It looks like this PR is missing a label to determine the type of change it introduces. The maintainer should add one of the following labels:
+
+          - `bug` for bugfixes.
+          - `enhancement` for new features and improvements.
+          - `documentation` for documentation changes.
+          - `security` for security patches.
+          - `removed` for feature removals.
+          - `infrastructure` for internal changes that should not go in the changelog.
+
+          Additionally, the maintainer may also want to add one of the following:
+
+          - `breaking` for breaking changes.
+          - `deprecated` for feature deprecations.
+
+          Once the correct labels have been set, simply remove the `needs changelog label` label from this PR so I can merge it.
+  - name: merge PRs automatically
+    conditions:
+      - base=master
+      - -label="needs changelog label"
+      - -label=blocked
+    actions:
+      merge:
+        method: merge

data/.rubocop.yml

@@ -1,11 +1,53 @@
 inherit_from:
   - https://relaxed.ruby.style/rubocop.yml
 
+Layout/EmptyLinesAroundAttributeAccessor:
+  Enabled: true
+Layout/SpaceAroundMethodCallOperator:
+  Enabled: true
+Lint/DeprecatedOpenSSLConstant:
+  Enabled: true
+Lint/MixedRegexpCaptureTypes:
+  Enabled: true
+Lint/RaiseException:
+  Enabled: true
+Lint/StructNewOverride:
+  Enabled: true
+Style/AccessorGrouping:
+  Enabled: true
+Style/BisectedAttrAccessor:
+  Enabled: true
+Style/ExponentialNotation:
+  Enabled: true
+Style/HashEachMethods:
+  Enabled: true
+Style/HashTransformKeys:
+  Enabled: true
+Style/HashTransformValues:
+  Enabled: true
+Style/RedundantAssignment:
+  Enabled: true
+Style/RedundantFetchBlock:
+  Enabled: true
+Style/RedundantRegexpCharacterClass:
+  Enabled: true
+Style/RedundantRegexpEscape:
+  Enabled: true
+Style/SlicingWithRange:
+  Enabled: true
+
+
 AllCops:
+  TargetRubyVersion: 2.5
   Exclude:
     - tmp/**/*
+    - "vendor/**/*"
+    # Generated binstubs
+    - bin/rake
 
 Style/FrozenStringLiteralComment:
   Exclude:
     - "**/bin/*"
     - "**/exe/*"
+    - "spec/**/*"
+

data/CHANGELOG.md

@@ -1,11 +1,82 @@
 # Changelog
 
-All notable changes to this project will be documented in this file.
+## [Unreleased](https://github.com/solidusio/solidus_dev_support/tree/HEAD)
 
-The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project
-adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
+[Full Changelog](https://github.com/solidusio/solidus_dev_support/compare/v1.5.0...HEAD)
 
-## [Unreleased]
+**Breaking changes:**
+
+- Switch the JS driver to WebDriver/Selenium [\#136](https://github.com/solidusio/solidus_dev_support/pull/136) ([elia](https://github.com/elia))
+
+**Implemented enhancements:**
+
+- Enable new RuboCop cops automatically [\#143](https://github.com/solidusio/solidus_dev_support/pull/143) ([aldesantis](https://github.com/aldesantis))
+- Don't forcefully close issues via stale-bot [\#139](https://github.com/solidusio/solidus_dev_support/pull/139) ([elia](https://github.com/elia))
+- Add the approximate recommendation for dev-support to the gemspec [\#137](https://github.com/solidusio/solidus_dev_support/pull/137) ([elia](https://github.com/elia))
+- Let the extension name include spaces [\#133](https://github.com/solidusio/solidus_dev_support/pull/133) ([elia](https://github.com/elia))
+- Add precompiled badges fro CI and coverage [\#132](https://github.com/solidusio/solidus_dev_support/pull/132) ([elia](https://github.com/elia))
+- Add Changelog Rake task [\#128](https://github.com/solidusio/solidus_dev_support/pull/128) ([tvdeyen](https://github.com/tvdeyen))
+- Readme fixes [\#122](https://github.com/solidusio/solidus_dev_support/pull/122) ([elia](https://github.com/elia))
+
+**Fixed bugs:**
+
+- fix capybara driver declaration [\#141](https://github.com/solidusio/solidus_dev_support/pull/141) ([ccarruitero](https://github.com/ccarruitero))
+- Bump RuboCop to latest 0.90.0 version [\#138](https://github.com/solidusio/solidus_dev_support/pull/138) ([peterberkenbosch](https://github.com/peterberkenbosch))
+- Fix missing backslash in solidus install command [\#135](https://github.com/solidusio/solidus_dev_support/pull/135) ([nirebu](https://github.com/nirebu))
+- Don't install a payment-method in the sandbox [\#131](https://github.com/solidusio/solidus_dev_support/pull/131) ([elia](https://github.com/elia))
+- Run extension generator in sandbox [\#127](https://github.com/solidusio/solidus_dev_support/pull/127) ([elia](https://github.com/elia))
+
+## [v1.5.0](https://github.com/solidusio/solidus_dev_support/tree/v1.5.0) (2020-06-13)
+
+[Full Changelog](https://github.com/solidusio/solidus_dev_support/compare/v1.4.0...v1.5.0)
+
+**Fixed bugs:**
+
+- Fix formatting typo in readme [\#117](https://github.com/solidusio/solidus_dev_support/pull/117) ([aldesantis](https://github.com/aldesantis))
+
+**Removed:**
+
+- Remove deprecated bin/r and bin/sandbox\_rails binaries [\#118](https://github.com/solidusio/solidus_dev_support/pull/118) ([aldesantis](https://github.com/aldesantis))
+
+## [1.4.0] - 2020-06-05
+
+### Added
+
+- Added a "Usage" section to the default readme
+
+### Changed
+
+- Restored `bin/rails` and renamed the context specific bins to `bin/rails-engine` and `bin/rails-sandbox`
+- Adjusted the readme structure with better formatting and grammar
+- Moved the RuboCop `AllCops/Exclude` statement back to the internal configuration 
+
+### Deprecated
+
+- Deprecated `bin/r` in favor of `bin/rails-engine` and `bin/sandbox_rails` in favor of `bin/rails-sandbox`
+
+## [1.3.0] - 2020-05-22
+
+### Added
+
+- Ignored `.rvmrc`, `.ruby-version` and `.ruby-gemset` by default in extensions
+- Added deprecation warning when extensions don't support Zeitwerk
+
+### Changed
+
+- Updated the extension template to use latest (0.5.X) solidus_support
+- Set Ruby 2.5+ as the minimum Ruby version in generated extensions
+
+### Removed
+
+- Removed Stale from the default extension configuration
+
+## [1.2.0] - 2020-04-24
+
+### Changed
+
+- Updated the extension template with the latest modifications
+
+## [1.1.0] - 2020-03-06
 
 ### Added
 
@@ -15,8 +86,8 @@ adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 ### Changed
 
 - Split `bin/rails` into `bin/r` and `bin/sandbox_rails`
-- Updated the extension template with the latest modifications
- 
+
+
 ### Fixed
 
 - Fixed the sandbox Gemfile not including Solidus
@@ -152,7 +223,11 @@ adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
 Initial release.
 
-[Unreleased]: https://github.com/solidusio/solidus_dev_support/compare/v1.0.1...HEAD
+[Unreleased]: https://github.com/solidusio/solidus_dev_support/compare/v1.4.0...HEAD
+[1.4.0]: https://github.com/solidusio/solidus_dev_support/compare/v1.3.0...v1.4.0
+[1.3.0]: https://github.com/solidusio/solidus_dev_support/compare/v1.2.0...v1.3.0
+[1.2.0]: https://github.com/solidusio/solidus_dev_support/compare/v1.1.0...v1.2.0
+[1.1.0]: https://github.com/solidusio/solidus_dev_support/compare/v1.0.1...v1.1.0
 [1.0.1]: https://github.com/solidusio/solidus_dev_support/compare/v1.0.0...v1.0.1
 [1.0.0]: https://github.com/solidusio/solidus_dev_support/compare/v0.6.0...v1.0.0
 [0.6.0]: https://github.com/solidusio/solidus_dev_support/compare/v0.5.0...v0.6.0
@@ -163,3 +238,6 @@ Initial release.
 [0.2.0]: https://github.com/solidusio/solidus_dev_support/compare/v0.1.1...v0.2.0
 [0.1.1]: https://github.com/solidusio/solidus_dev_support/compare/v0.1.0...v0.1.1
 [0.1.0]: https://github.com/solidusio/solidus_dev_support/releases/tag/v0.1.0
+
+
+\* *This Changelog was automatically generated by [github_changelog_generator](https://github.com/github-changelog-generator/github-changelog-generator)*

data/Gemfile

@@ -15,10 +15,10 @@ gem 'rails', '>0.a'
 
 # These gems will be used by the temporary extensions generated by tests
 group :test do
-  gem 'solidus_auth_devise'
   gem 'factory_bot', '> 4.10.0'
   gem 'mysql2'
   gem 'pg'
+  gem 'solidus_auth_devise'
   gem 'sqlite3'
 end
 

data/OLD_CHANGELOG.md

@@ -0,0 +1,200 @@
+## [1.4.0] - 2020-06-05
+
+### Added
+
+- Added a "Usage" section to the default readme
+
+### Changed
+
+- Restored `bin/rails` and renamed the context specific bins to `bin/rails-engine` and `bin/rails-sandbox`
+- Adjusted the readme structure with better formatting and grammar
+- Moved the RuboCop `AllCops/Exclude` statement back to the internal configuration 
+
+### Deprecated
+
+- Deprecated `bin/r` in favor of `bin/rails-engine` and `bin/sandbox_rails` in favor of `bin/rails-sandbox`
+
+## [1.3.0] - 2020-05-22
+
+### Added
+
+- Ignored `.rvmrc`, `.ruby-version` and `.ruby-gemset` by default in extensions
+- Added deprecation warning when extensions don't support Zeitwerk
+
+### Changed
+
+- Updated the extension template to use latest (0.5.X) solidus_support
+- Set Ruby 2.5+ as the minimum Ruby version in generated extensions
+
+### Removed
+
+- Removed Stale from the default extension configuration
+
+## [1.2.0] - 2020-04-24
+
+### Changed
+
+- Updated the extension template with the latest modifications
+
+## [1.1.0] - 2020-03-06
+
+### Added
+
+- Made Git ignore `sandbox` in generated extensions
+- Added support for specifying `SOLIDUS_BRANCH` in the sandbox
+
+### Changed
+
+- Split `bin/rails` into `bin/r` and `bin/sandbox_rails`
+
+
+### Fixed
+
+- Fixed the sandbox Gemfile not including Solidus
+
+## [1.0.1] - 2020-02-17
+
+### Fixed
+
+- Fixed missing factory definitions when using `modify` on Solidus factories
+
+## [1.0.0] - 2020-02-07
+
+### Added
+
+- Added a binstub for `rake` to the extension generator
+- Added the ability for the generator to reuse existing data for the gemspec
+
+### Fixed
+
+- Fixed Dependabot throwing an error because of `eval_gemfile` in the Gemfile
+
+## [0.6.0] - 2020-01-20
+
+### Added
+
+- Added support for a local Gemfile for local development dependencies (e.g. 'pry-debug')
+- Added a `bin/sandbox` script to all extension for local development with `bin/rails` support.
+
+### Changed
+
+- The default rake task no longer re-generates the `test_app` each time it runs.
+  In order to get that behavior back simply call clobber before launching it:
+  `bin/rake clobber default`
+
+### Fixed
+
+- Fixed generated extensions isolating the wrong namespace
+
+## [0.5.0] - 2020-01-16
+
+### Added
+
+- Added `--require spec_helper` to the generated `.rspec`
+
+### Fixed
+
+- Replaced "Spree" with "Solidus" in the license of generated extensions
+
+### Changed
+
+- Updated gem-release to use tags instead of branches for new releases
+
+## [0.4.1] - 2020-01-15
+
+### Fixed
+
+- Fixed the generated RuboCop config inheriting from this gem's dev-only config
+- Fixed the generated extension not requiring the `version` file
+- Fixed the generator not properly marking `bin/` files as executable
+
+## [0.4.0] - 2020-01-10
+
+### Added
+
+- Enforced Rails version depending on the Solidus version in generated Gemfile
+- Made Git ignore `spec/examples.txt` in generated extensions
+- Added the ability to run `solidus extension .` to update an extension
+
+### Changed
+
+- The `solidus` executable is now solely managed by Thor and is open to extension by other gems
+
+### Fixed
+
+- Fixed generated extensions using an old Rakefile
+- Fixed some RuboCop offenses in the generated files
+- Fixed the `bin/setup` script calling a non-existing Rake binary
+
+### Removed
+
+- Removed RuboCop from the default Rake task
+- Removed the `-v` option from the `solidus` executable
+- Removed the factory_bot gem from the Gemfile
+
+## [0.3.0] - 2020-01-10
+
+### Added
+
+- Adopted Ruby 2.4+ as the minimum Ruby version in generated extensions
+- Added `bin/console`, `bin/rails` and `bin/setup` to generated extensions
+- Added some Bundler gemspec defaults to generated extensions
+- Configured the default Rake task to run generate the test app before running RSpec
+
+### Changed
+
+- Updated solidus_support to 0.4.0 for Zeitwerk and Rails 6 compatibility
+- Updated the `solidus` executable to only rely on Thor and be open to extension by other gems
+
+### Removed
+
+- Removed solidus_support as a dependency
+
+### Fixed
+
+- Fixed `extension:test_app` not going back to the root after execution
+
+## [0.2.0] - 2019-12-16
+
+### Added
+
+- Adopted [Apparition](https://github.com/twalpole/apparition) as the deafult JS driver for Capybara
+- Fixed window size to 1920x1080px in feature specs
+- Added [Stale](https://github.com/apps/stale) to automatically mark GitHub issues as stale
+
+### Changed
+
+- Disabled all `Metrics` cops except for `LineLength`
+- Set `Layout/AlignArguments` cop to `with_fixed_indentation`
+- Disabled `Layout/MultilineOperationIndentation` cop
+- Renamed the project to SolidusDevSupport (was SolidusExtensionDevTools)
+
+### Fixed
+
+- Fixed Chrome not starting in headless mode
+
+## [0.1.1] - 2019-11-11
+
+### Fixed
+
+- Fixed `rails_helper` not working due to `SolidusDevSupport` not being available
+
+## [0.1.0] - 2019-11-11
+
+Initial release.
+
+[Unreleased]: https://github.com/solidusio/solidus_dev_support/compare/v1.4.0...HEAD
+[1.4.0]: https://github.com/solidusio/solidus_dev_support/compare/v1.3.0...v1.4.0
+[1.3.0]: https://github.com/solidusio/solidus_dev_support/compare/v1.2.0...v1.3.0
+[1.2.0]: https://github.com/solidusio/solidus_dev_support/compare/v1.1.0...v1.2.0
+[1.1.0]: https://github.com/solidusio/solidus_dev_support/compare/v1.0.1...v1.1.0
+[1.0.1]: https://github.com/solidusio/solidus_dev_support/compare/v1.0.0...v1.0.1
+[1.0.0]: https://github.com/solidusio/solidus_dev_support/compare/v0.6.0...v1.0.0
+[0.6.0]: https://github.com/solidusio/solidus_dev_support/compare/v0.5.0...v0.6.0
+[0.5.0]: https://github.com/solidusio/solidus_dev_support/compare/v0.4.1...v0.5.0
+[0.4.1]: https://github.com/solidusio/solidus_dev_support/compare/v0.4.0...v0.4.1
+[0.4.0]: https://github.com/solidusio/solidus_dev_support/compare/v0.3.0...v0.4.0
+[0.3.0]: https://github.com/solidusio/solidus_dev_support/compare/v0.2.0...v0.3.0
+[0.2.0]: https://github.com/solidusio/solidus_dev_support/compare/v0.1.1...v0.2.0
+[0.1.1]: https://github.com/solidusio/solidus_dev_support/compare/v0.1.0...v0.1.1
+[0.1.0]: https://github.com/solidusio/solidus_dev_support/releases/tag/v0.1.0