solidus_core_devise_token_auth 2.8.0.alpha.0

data/spec/models/spree/ability_spec.rb

@@ -0,0 +1,279 @@
+# frozen_string_literal: true
+
+require 'rails_helper'
+require 'cancan'
+require 'cancan/matchers'
+require 'spree/testing_support/ability_helpers'
+
+Spree::Deprecation.silence do
+  require 'spree/testing_support/bar_ability'
+end
+
+# Fake ability for testing registration of additional abilities
+class FooAbility
+  include CanCan::Ability
+
+  def initialize(_user)
+    # allow anyone to perform index on Order
+    can :index, Spree::Order
+    # allow anyone to update an Order with id of 1
+    can :update, Spree::Order do |order|
+      order.id == 1
+    end
+  end
+end
+
+RSpec.describe Spree::Ability, type: :model do
+  let(:user) { build(:user) }
+  let(:ability) { Spree::Ability.new(user) }
+  let(:token) { nil }
+
+  after(:each) {
+    Spree::Ability.abilities = Set.new
+  }
+
+  describe "#initialize" do
+    subject { Spree::Ability.new(user) }
+
+    it "activates permissions from the role configuration" do
+      expect(Spree::Config.roles).to receive(:activate_permissions!).
+        once
+
+      subject
+    end
+  end
+
+  context 'register_ability' do
+    it 'should add the ability to the list of abilties' do
+      Spree::Ability.register_ability(FooAbility)
+      expect(Spree::Ability.new(user).abilities).not_to be_empty
+    end
+
+    it 'should apply the registered abilities permissions' do
+      Spree::Ability.register_ability(FooAbility)
+      expect(Spree::Ability.new(user).can?(:update, mock_model(Spree::Order, user: nil, id: 1))).to be true
+    end
+  end
+
+  context 'for general resource' do
+    let(:resource) { Object.new }
+
+    context 'with admin user' do
+      let(:user) { build :admin_user }
+      it_should_behave_like 'access granted'
+      it_should_behave_like 'index allowed'
+    end
+
+    context 'with customer' do
+      it_should_behave_like 'access denied'
+      it_should_behave_like 'no index allowed'
+    end
+  end
+
+  context 'for admin protected resources' do
+    let(:resource) { Object.new }
+    let(:resource_shipment) { Spree::Shipment.new }
+    let(:resource_product) { Spree::Product.new }
+    let(:resource_user) { create :user }
+    let(:resource_order) { Spree::Order.new }
+    let(:fakedispatch_user) { Spree.user_class.create }
+    let(:fakedispatch_ability) { Spree::Ability.new(fakedispatch_user) }
+
+    context 'with admin user' do
+      it 'should be able to admin' do
+        user.spree_roles << Spree::Role.find_or_create_by(name: 'admin')
+        expect(ability).to be_able_to :admin, resource
+        expect(ability).to be_able_to :index, resource_order
+        expect(ability).to be_able_to :show, resource_product
+        expect(ability).to be_able_to :create, resource_user
+      end
+    end
+
+    context 'with fakedispatch user' do
+      it 'should be able to admin on the order and shipment pages' do
+        user.spree_roles << Spree::Role.find_or_create_by(name: 'bar')
+
+        Spree::Ability.register_ability(BarAbility)
+
+        expect(ability).not_to be_able_to :admin, resource
+
+        expect(ability).to be_able_to :admin, resource_order
+        expect(ability).to be_able_to :index, resource_order
+        expect(ability).not_to be_able_to :update, resource_order
+        # ability.should_not be_able_to :create, resource_order # Fails
+
+        expect(ability).to be_able_to :admin, resource_shipment
+        expect(ability).to be_able_to :index, resource_shipment
+        expect(ability).to be_able_to :create, resource_shipment
+
+        expect(ability).not_to be_able_to :admin, resource_product
+        expect(ability).not_to be_able_to :update, resource_product
+        # ability.should_not be_able_to :show, resource_product # Fails
+
+        expect(ability).not_to be_able_to :admin, resource_user
+        expect(ability).not_to be_able_to :update, resource_user
+        expect(ability).to be_able_to :update, user
+        # ability.should_not be_able_to :create, resource_user # Fails
+        # It can create new users if is has access to the :admin, User!!
+
+        # TODO: change the Ability class so only users and customers get the extra premissions?
+
+        Spree::Ability.remove_ability(BarAbility)
+      end
+    end
+
+    context 'with customer' do
+      it 'should not be able to admin' do
+        expect(ability).not_to be_able_to :admin, resource
+        expect(ability).not_to be_able_to :admin, resource_order
+        expect(ability).not_to be_able_to :admin, resource_product
+        expect(ability).not_to be_able_to :admin, resource_user
+      end
+    end
+  end
+
+  context 'as Guest User' do
+    context 'for Country' do
+      let(:resource) { Spree::Country.new }
+      context 'requested by any user' do
+        it_should_behave_like 'read only'
+      end
+    end
+
+    context 'for OptionType' do
+      let(:resource) { Spree::OptionType.new }
+      context 'requested by any user' do
+        it_should_behave_like 'read only'
+      end
+    end
+
+    context 'for OptionValue' do
+      let(:resource) { Spree::OptionType.new }
+      context 'requested by any user' do
+        it_should_behave_like 'read only'
+      end
+    end
+
+    context 'for Order' do
+      let(:resource) { Spree::Order.new }
+
+      context 'requested by same user' do
+        before(:each) { resource.user = user }
+        it_should_behave_like 'access granted'
+        it_should_behave_like 'no index allowed'
+      end
+
+      context 'requested by other user' do
+        before(:each) { resource.user = Spree.user_class.new }
+        it_should_behave_like 'create only'
+      end
+
+      context 'requested with proper token' do
+        let(:token) { 'TOKEN123' }
+        before(:each) { allow(resource).to receive_messages guest_token: 'TOKEN123' }
+        it_should_behave_like 'access granted'
+        it_should_behave_like 'no index allowed'
+      end
+
+      context 'requested with inproper token' do
+        let(:token) { 'FAIL' }
+        before(:each) { allow(resource).to receive_messages guest_token: 'TOKEN123' }
+        it_should_behave_like 'create only'
+      end
+    end
+
+    context 'for Product' do
+      let(:resource) { Spree::Product.new }
+      context 'requested by any user' do
+        it_should_behave_like 'read only'
+      end
+    end
+
+    context 'for ProductProperty' do
+      let(:resource) { Spree::Product.new }
+      context 'requested by any user' do
+        it_should_behave_like 'read only'
+      end
+    end
+
+    context 'for Property' do
+      let(:resource) { Spree::Product.new }
+      context 'requested by any user' do
+        it_should_behave_like 'read only'
+      end
+    end
+
+    context 'for State' do
+      let(:resource) { Spree::State.new }
+      context 'requested by any user' do
+        it_should_behave_like 'read only'
+      end
+    end
+
+    context 'for Stock Item' do
+      let(:resource) { Spree::StockItem.new }
+      context 'active stock location' do
+        before { resource.build_stock_location(active: true) }
+        it_should_behave_like 'read only'
+      end
+
+      context 'inactive stock location' do
+        before { resource.build_stock_location(active: false) }
+        it_should_behave_like 'access denied'
+      end
+    end
+
+    context 'for Stock Location' do
+      let(:resource) { Spree::StockLocation.new }
+      context 'active' do
+        before { resource.active = true }
+        it_should_behave_like 'read only'
+      end
+
+      context 'inactive' do
+        before { resource.active = false }
+        it_should_behave_like 'access denied'
+      end
+    end
+
+    context 'for Taxons' do
+      let(:resource) { Spree::Taxon.new }
+      context 'requested by any user' do
+        it_should_behave_like 'read only'
+      end
+    end
+
+    context 'for Taxonomy' do
+      let(:resource) { Spree::Taxonomy.new }
+      context 'requested by any user' do
+        it_should_behave_like 'read only'
+      end
+    end
+
+    context 'for User' do
+      context 'requested by same user' do
+        let(:resource) { user }
+        it_should_behave_like 'access granted'
+        it_should_behave_like 'no index allowed'
+      end
+      context 'requested by other user' do
+        let(:resource) { Spree.user_class.create }
+        it_should_behave_like 'create only'
+      end
+    end
+
+    context 'for Variant' do
+      let(:resource) { Spree::Variant.new }
+      context 'requested by any user' do
+        it_should_behave_like 'read only'
+      end
+    end
+
+    context 'for Zone' do
+      let(:resource) { Spree::Zone.new }
+      context 'requested by any user' do
+        it_should_behave_like 'read only'
+      end
+    end
+  end
+end

data/spec/models/spree/address_spec.rb

@@ -0,0 +1,375 @@
+# frozen_string_literal: true
+
+require 'rails_helper'
+
+RSpec.describe Spree::Address, type: :model do
+  subject { Spree::Address }
+
+  context "aliased attributes" do
+    let(:address) { Spree::Address.new firstname: 'Ryan', lastname: 'Bigg' }
+
+    it " first_name" do
+      expect(address.first_name).to eq("Ryan")
+    end
+
+    it "last_name" do
+      expect(address.last_name).to eq("Bigg")
+    end
+  end
+
+  context "validation" do
+    let(:country) { create :country, states_required: true }
+    let(:state) { Spree::State.new name: 'maryland', abbr: 'md', country: country }
+    let(:address) { build(:address, country: country) }
+
+    before do
+      allow(country.states).to receive_messages with_name_or_abbr: [state]
+    end
+
+    context 'address does not require state' do
+      before do
+        Spree::Config.address_requires_state = false
+      end
+      it "address_requires_state preference is false" do
+        address.state = nil
+        address.state_name = nil
+        expect(address).to be_valid
+      end
+    end
+
+    context 'address requires state' do
+      before do
+        Spree::Config.address_requires_state = true
+      end
+
+      it "state_name is not nil and country does not have any states" do
+        address.state = nil
+        address.state_name = 'alabama'
+        expect(address).to be_valid
+      end
+
+      it "errors when state_name is nil" do
+        address.state_name = nil
+        address.state = nil
+        expect(address).not_to be_valid
+      end
+
+      it "full state name is in state_name and country does contain that state" do
+        address.state_name = 'alabama'
+        # called by state_validate to set up state_id.
+        # Perhaps this should be a before_validation instead?
+        expect(address).to be_valid
+        expect(address.state).not_to be_nil
+        expect(address.state_name).to be_nil
+      end
+
+      it "state abbr is in state_name and country does contain that state" do
+        address.state_name = state.abbr
+        expect(address).to be_valid
+        expect(address.state_id).not_to be_nil
+        expect(address.state_name).to be_nil
+      end
+
+      context 'when the country does not match the state' do
+        context 'when the country requires states' do
+          it 'is invalid' do
+            address.state = state
+            address.country = Spree::Country.new(states_required: true)
+            address.valid?
+            expect(address.errors["state"]).to eq(['is invalid', 'does not match the country'])
+          end
+        end
+
+        context 'when the country does not require states' do
+          it 'is invalid' do
+            address.state = state
+            address.country = Spree::Country.new(states_required: false)
+            address.valid?
+            expect(address.errors["state"]).to eq(['does not match the country'])
+          end
+        end
+      end
+
+      it "both state and state_name are entered but country does not contain the state" do
+        address.state = state
+        address.state_name = 'maryland'
+        address.country = create :country, states_required: true
+        expect(address).to be_valid
+        expect(address.state_id).to be_nil
+      end
+
+      it "both state and state_name are entered and country does contain the state" do
+        address.state = state
+        address.state_name = 'maryland'
+        expect(address).to be_valid
+        expect(address.state_name).to be_nil
+      end
+    end
+
+    it "requires phone" do
+      address.phone = ""
+      address.valid?
+      expect(address.errors["phone"]).to eq(["can't be blank"])
+    end
+
+    it "requires zipcode" do
+      address.zipcode = ""
+      address.valid?
+      expect(address.errors['zipcode']).to include("can't be blank")
+    end
+
+    context "phone not required" do
+      before { allow(address).to receive_messages require_phone?: false }
+
+      it "shows no errors when phone is blank" do
+        address.phone = ""
+        address.valid?
+        expect(address.errors[:phone].size).to eq 0
+      end
+    end
+
+    context "zipcode not required" do
+      before { allow(address).to receive_messages require_zipcode?: false }
+
+      it "shows no errors when zipcode is blank" do
+        address.zipcode = ""
+        address.valid?
+        expect(address.errors[:zipcode]).to be_blank
+      end
+    end
+  end
+
+  context ".build_default" do
+    context "no user given" do
+      let!(:default_country) { create(:country) }
+
+      context 'has a default country' do
+        before do
+          Spree::Config[:default_country_iso] = default_country.iso
+        end
+
+        it "sets up a new record with Spree::Config[:default_country_iso]" do
+          expect(Spree::Address.build_default.country).to eq default_country
+        end
+      end
+
+      # Regression test for https://github.com/spree/spree/issues/1142
+      it "raises ActiveRecord::RecordNotFound if :default_country_iso is set to an invalid value" do
+        Spree::Config[:default_country_iso] = "00"
+        expect {
+          Spree::Address.build_default.country
+        }.to raise_error(ActiveRecord::RecordNotFound)
+      end
+    end
+  end
+
+  context '.factory' do
+    context 'with attributes that use setters defined in Address' do
+      let(:address_attributes) { attributes_for(:address, country_id: nil, country_iso: country.iso) }
+      let(:country) { create(:country, iso: 'ZW') }
+
+      it 'uses the setters' do
+        expect(subject.factory(address_attributes).country_id).to eq(country.id)
+      end
+    end
+  end
+
+  context ".immutable_merge" do
+    RSpec::Matchers.define :be_address_equivalent_attributes do |expected|
+      fields_of_interest = [:firstname, :lastname, :company, :address1, :address2, :city, :zipcode, :phone, :alternative_phone]
+      match do |actual|
+        expected_attrs = expected.symbolize_keys.slice(*fields_of_interest)
+        actual_attrs = actual.symbolize_keys.slice(*fields_of_interest)
+        expected_attrs == actual_attrs
+      end
+    end
+
+    let(:new_address_attributes) { attributes_for(:address) }
+    subject { Spree::Address.immutable_merge(existing_address, new_address_attributes) }
+
+    context "no existing address supplied" do
+      let(:existing_address) { nil }
+
+      context 'and there is not a matching address in the database' do
+        it "returns new Address matching attributes given" do
+          expect(subject.attributes).to be_address_equivalent_attributes(new_address_attributes)
+        end
+      end
+
+      context 'and there is a matching address in the database' do
+        let(:new_address_attributes) { Spree::Address.value_attributes(matching_address.attributes) }
+        let!(:matching_address) { create(:address, firstname: 'Jordan') }
+
+        it "returns the matching address" do
+          expect(subject.attributes).to be_address_equivalent_attributes(new_address_attributes)
+          expect(subject.id).to eq(matching_address.id)
+        end
+      end
+    end
+
+    context "with existing address" do
+      let(:existing_address) { create(:address) }
+
+      it "returns a new Address of merged data" do
+        merged_attributes = subject.attributes.merge(new_address_attributes.symbolize_keys)
+        expect(subject.attributes).to be_address_equivalent_attributes merged_attributes
+        expect(subject.id).not_to eq existing_address.id
+      end
+
+      context "and no changes to attributes" do
+        let(:new_address_attributes) { existing_address.attributes }
+
+        it "returns existing address" do
+          expect(subject).to eq existing_address
+          expect(subject.id).to eq existing_address.id
+        end
+      end
+
+      context 'and changed address matches an existing address' do
+        let(:new_address_attributes) { Spree::Address.value_attributes(matching_address.attributes) }
+        let!(:matching_address) { create(:address, firstname: 'Jordan') }
+
+        it 'returns the matching address' do
+          expect(subject.attributes).to be_address_equivalent_attributes(new_address_attributes)
+          expect(subject.id).to eq(matching_address.id)
+        end
+      end
+    end
+  end
+
+  describe '.value_attributes' do
+    subject do
+      Spree::Address.value_attributes(base_attributes, merge_attributes)
+    end
+
+    context 'with symbols and strings' do
+      let(:base_attributes) { { 'address1' => '1234 way', 'address2' => 'apt 2' } }
+      let(:merge_attributes) { { address1: '5678 way' } }
+
+      it 'stringifies and merges the keys' do
+        expect(subject).to eq('address1' => '5678 way', 'address2' => 'apt 2')
+      end
+    end
+
+    context 'with database-only attributes' do
+      let(:base_attributes) do
+        {
+          'id' => 1,
+          'created_at' => Time.current,
+          'updated_at' => Time.current,
+          'address1' => '1234 way'
+        }
+      end
+      let(:merge_attributes) do
+        {
+          'updated_at' => Time.current,
+          'address2' => 'apt 2'
+        }
+      end
+
+      it 'removes the database-only addresses' do
+        expect(subject).to eq('address1' => '1234 way', 'address2' => 'apt 2')
+      end
+    end
+
+    context 'with aliased attributes' do
+      let(:base_attributes) { { 'first_name' => 'Jordan' } }
+      let(:merge_attributes) { { 'last_name' => 'Brough' } }
+
+      it 'renames them to the normalized value' do
+        expect(subject).to eq('firstname' => 'Jordan', 'lastname' => 'Brough')
+      end
+
+      it 'does not modify the original hashes' do
+        subject
+        expect(base_attributes).to eq('first_name' => 'Jordan')
+        expect(merge_attributes).to eq('last_name' => 'Brough')
+      end
+    end
+  end
+
+  describe '.taxation_attributes' do
+    context 'both taxation and non-taxation attributes are present ' do
+      let(:address) { Spree::Address.new firstname: 'Michael', lastname: 'Jackson', state_id: 1, country_id: 2, zipcode: '12345' }
+
+      it 'removes the non-taxation attributes' do
+        expect(address.taxation_attributes).not_to eq('firstname' => 'Michael', 'lastname' => 'Jackson')
+      end
+
+      it 'returns only the taxation attributes' do
+        expect(address.taxation_attributes).to eq('state_id' => 1, 'country_id' => 2, 'zipcode' => '12345')
+      end
+    end
+
+    context 'taxation attributes are blank' do
+      let(:address) { Spree::Address.new firstname: 'Michael', lastname: 'Jackson' }
+
+      it 'returns a subset of the attributes with the correct keys and nil values' do
+        expect(address.taxation_attributes).to eq('state_id' => nil, 'country_id' => nil, 'zipcode' => nil)
+      end
+    end
+  end
+
+  context '#country_iso=' do
+    let(:address) { build(:address, country_id: nil) }
+    let(:country) { create(:country, iso: 'ZW') }
+
+    it 'sets the country to the country with the matching iso code' do
+      address.country_iso = country.iso
+      expect(address.country_id).to eq(country.id)
+    end
+
+    it 'raises an exception if the iso is not found' do
+      expect {
+        address.country_iso = "NOCOUNTRY"
+      }.to raise_error(::ActiveRecord::RecordNotFound, "Couldn't find Spree::Country")
+    end
+  end
+
+  context '#full_name' do
+    context 'both first and last names are present' do
+      let(:address) { Spree::Address.new firstname: 'Michael', lastname: 'Jackson' }
+      specify { expect(address.full_name).to eq('Michael Jackson') }
+    end
+
+    context 'first name is blank' do
+      let(:address) { Spree::Address.new firstname: nil, lastname: 'Jackson' }
+      specify { expect(address.full_name).to eq('Jackson') }
+    end
+
+    context 'last name is blank' do
+      let(:address) { Spree::Address.new firstname: 'Michael', lastname: nil }
+      specify { expect(address.full_name).to eq('Michael') }
+    end
+
+    context 'both first and last names are blank' do
+      let(:address) { Spree::Address.new firstname: nil, lastname: nil }
+      specify { expect(address.full_name).to eq('') }
+    end
+  end
+
+  context '#state_text' do
+    context 'state is blank' do
+      let(:address) { Spree::Address.new state: nil, state_name: 'virginia' }
+      specify { expect(address.state_text).to eq('virginia') }
+    end
+
+    context 'both name and abbr is present' do
+      let(:state) { Spree::State.new name: 'virginia', abbr: 'va' }
+      let(:address) { Spree::Address.new state: state }
+      specify { expect(address.state_text).to eq('va') }
+    end
+
+    context 'only name is present' do
+      let(:state) { Spree::State.new name: 'virginia', abbr: nil }
+      let(:address) { Spree::Address.new state: state }
+      specify { expect(address.state_text).to eq('virginia') }
+    end
+  end
+
+  context '#requires_phone' do
+    subject { described_class.new }
+
+    it { is_expected.to be_require_phone }
+  end
+end

data/spec/models/spree/adjustment_reason_spec.rb

@@ -0,0 +1,11 @@
+# frozen_string_literal: true
+
+require 'rails_helper'
+
+RSpec.describe Spree::AdjustmentReason do
+  describe 'creation' do
+    it 'is successful' do
+      create(:adjustment_reason)
+    end
+  end
+end