solidus_core 4.6.1 → 4.7.0

data/lib/spree/testing_support/factories/inventory_unit_factory.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 FactoryBot.define do
-  factory :inventory_unit, class: 'Spree::InventoryUnit' do
+  factory :inventory_unit, class: "Spree::InventoryUnit" do
     transient do
       order { nil }
       stock_location { nil }
@@ -15,12 +15,12 @@ FactoryBot.define do
         build(:line_item, variant:)
       end
     end
-    state { 'on_hand' }
+    state { "on_hand" }
     shipment do
       if stock_location
-        build(:shipment, state: 'pending', order: line_item.order, stock_location:)
+        build(:shipment, state: "pending", order: line_item.order, stock_location:)
       else
-        build(:shipment, state: 'pending', order: line_item.order)
+        build(:shipment, state: "pending", order: line_item.order)
       end
     end
     # return_authorization

data/lib/spree/testing_support/factories/line_item_factory.rb

@@ -1,9 +1,9 @@
 # frozen_string_literal: true
 
 FactoryBot.define do
-  factory :line_item, class: 'Spree::LineItem' do
+  factory :line_item, class: "Spree::LineItem" do
     quantity { 1 }
-    price { BigDecimal('10.00') }
+    price { BigDecimal("10.00") }
     order
     transient do
       product { nil }

data/lib/spree/testing_support/factories/option_type_factory.rb

@@ -1,8 +1,8 @@
 # frozen_string_literal: true
 
 FactoryBot.define do
-  factory :option_type, class: 'Spree::OptionType' do
+  factory :option_type, class: "Spree::OptionType" do
     sequence(:name) { |n| "foo-size-#{n}" }
-    presentation { 'Size' }
+    presentation { "Size" }
   end
 end

data/lib/spree/testing_support/factories/option_value_factory.rb

@@ -1,10 +1,10 @@
 # frozen_string_literal: true
 
 FactoryBot.define do
-  factory :option_value, class: 'Spree::OptionValue' do
+  factory :option_value, class: "Spree::OptionValue" do
     sequence(:name) { |n| "Size-#{n}" }
 
-    presentation { 'S' }
+    presentation { "S" }
     option_type
   end
 end

data/lib/spree/testing_support/factories/order_factory.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 FactoryBot.define do
-  factory :order, class: 'Spree::Order' do
+  factory :order, class: "Spree::Order" do
     user
     bill_address
     ship_address
@@ -43,12 +43,12 @@ FactoryBot.define do
         evaluator.stock_location # must evaluate before creating line items
 
         evaluator.line_items_attributes.each do |attributes|
-          attributes = { order:, price: evaluator.line_items_price }.merge(attributes).tap do |attrs|
+          attributes = {order:, price: evaluator.line_items_price}.merge(attributes).tap do |attrs|
             tax_category = attributes.delete(:tax_category)
             if attrs[:variant] && tax_category
-              attrs[:variant].update(tax_category: )
+              attrs[:variant].update(tax_category:)
             elsif tax_category
-              attrs[:variant] = create(:variant, tax_category: )
+              attrs[:variant] = create(:variant, tax_category:)
             end
           end
 
@@ -63,8 +63,8 @@ FactoryBot.define do
       end
 
       factory :order_ready_to_complete do
-        state { 'confirm' }
-        payment_state { 'checkout' }
+        state { "confirm" }
+        payment_state { "checkout" }
 
         transient do
           payment_type { :credit_card_payment }
@@ -85,33 +85,33 @@ FactoryBot.define do
         transient do
           completed_at { Time.current }
         end
-        state { 'complete' }
+        state { "complete" }
 
         after(:create) do |order, evaluator|
           order.shipments.each do |shipment|
-            shipment.inventory_units.update_all state: 'on_hand', pending: false
+            shipment.inventory_units.update_all state: "on_hand", pending: false
           end
           order.update_column(:completed_at, evaluator.completed_at)
         end
 
         factory :completed_order_with_pending_payment do
           after(:create) do |order|
-            create(:payment, amount: order.total, order:, state: 'pending')
+            create(:payment, amount: order.total, order:, state: "pending")
           end
         end
 
         factory :order_ready_to_ship do
-          payment_state { 'paid' }
-          shipment_state { 'ready' }
+          payment_state { "paid" }
+          shipment_state { "ready" }
 
           transient do
             payment_type { :credit_card_payment }
           end
 
           after(:create) do |order, evaluator|
-            create(evaluator.payment_type, amount: order.total, order:, state: 'completed')
+            create(evaluator.payment_type, amount: order.total, order:, state: "completed")
             order.shipments.each do |shipment|
-              shipment.update_column('state', 'ready')
+              shipment.update_column("state", "ready")
             end
             order.reload
           end
@@ -122,8 +122,8 @@ FactoryBot.define do
             end
             after(:create) do |order, evaluator|
               order.shipments.each do |shipment|
-                shipment.inventory_units.update_all state: 'shipped'
-                shipment.update_columns(state: 'shipped', shipped_at: Time.current)
+                shipment.inventory_units.update_all state: "shipped"
+                shipment.update_columns(state: "shipped", shipped_at: Time.current)
                 next unless evaluator.with_cartons
                 Spree::Carton.create!(
                   stock_location: shipment.stock_location,
@@ -134,7 +134,7 @@ FactoryBot.define do
                 )
               end
               # We need to update the shipment_state after all callbacks have run
-              order.update_columns(shipment_state: 'shipped')
+              order.update_columns(shipment_state: "shipped")
               order.reload
             end
           end

data/lib/spree/testing_support/factories/payment_factory.rb

@@ -1,20 +1,20 @@
 # frozen_string_literal: true
 
 FactoryBot.define do
-  factory :payment, aliases: [:credit_card_payment], class: 'Spree::Payment' do
+  factory :payment, aliases: [:credit_card_payment], class: "Spree::Payment" do
     association(:payment_method, factory: :credit_card_payment_method)
     source { create(:credit_card, user: order.user, address: order.bill_address) }
     order
-    state { 'checkout' }
-    response_code { '12345' }
+    state { "checkout" }
+    response_code { "12345" }
 
     trait :completed do
-      state { 'completed' }
+      state { "completed" }
     end
 
     trait :failing do
-      response_code { '00000' }
-      association(:source, :failing, { factory: :credit_card })
+      response_code { "00000" }
+      association(:source, :failing, {factory: :credit_card})
     end
 
     factory :payment_with_refund do
@@ -24,7 +24,7 @@ FactoryBot.define do
 
       amount { refund_amount }
 
-      state { 'completed' }
+      state { "completed" }
 
       refunds { build_list :refund, 1, amount: refund_amount }
     end
@@ -34,12 +34,12 @@ FactoryBot.define do
     end
   end
 
-  factory :check_payment, class: 'Spree::Payment' do
+  factory :check_payment, class: "Spree::Payment" do
     association(:payment_method, factory: :check_payment_method)
     order
   end
 
-  factory :store_credit_payment, class: 'Spree::Payment', parent: :payment do
+  factory :store_credit_payment, class: "Spree::Payment", parent: :payment do
     association(:payment_method, factory: :store_credit_payment_method)
     association(:source, factory: :store_credit)
   end

data/lib/spree/testing_support/factories/payment_method_factory.rb

@@ -1,30 +1,30 @@
 # frozen_string_literal: true
 
 FactoryBot.define do
-  factory :payment_method, aliases: [:credit_card_payment_method], class: 'Spree::PaymentMethod::BogusCreditCard' do
-    name { 'Credit Card' }
+  factory :payment_method, aliases: [:credit_card_payment_method], class: "Spree::PaymentMethod::BogusCreditCard" do
+    name { "Credit Card" }
     available_to_admin { true }
     available_to_users { true }
   end
 
-  factory :check_payment_method, class: 'Spree::PaymentMethod::Check' do
-    name { 'Check' }
+  factory :check_payment_method, class: "Spree::PaymentMethod::Check" do
+    name { "Check" }
     available_to_admin { true }
     available_to_users { true }
   end
 
   # authorize.net was moved to spree_gateway.
   # Leaving this factory in place with bogus in case anyone is using it.
-  factory :simple_credit_card_payment_method, class: 'Spree::PaymentMethod::SimpleBogusCreditCard' do
-    name { 'Credit Card' }
+  factory :simple_credit_card_payment_method, class: "Spree::PaymentMethod::SimpleBogusCreditCard" do
+    name { "Credit Card" }
     available_to_admin { true }
     available_to_users { true }
   end
 
-  factory :store_credit_payment_method, class: 'Spree::PaymentMethod::StoreCredit' do
-    name          { "Store Credit" }
-    description   { "Store Credit" }
-    active        { true }
+  factory :store_credit_payment_method, class: "Spree::PaymentMethod::StoreCredit" do
+    name { "Store Credit" }
+    description { "Store Credit" }
+    active { true }
     available_to_admin { false }
     available_to_users { false }
     auto_capture { true }

data/lib/spree/testing_support/factories/price_factory.rb

@@ -1,9 +1,9 @@
 # frozen_string_literal: true
 
 FactoryBot.define do
-  factory :price, class: 'Spree::Price' do
+  factory :price, class: "Spree::Price" do
     variant
     amount { 19.99 }
-    currency { 'USD' }
+    currency { "USD" }
   end
 end

data/lib/spree/testing_support/factories/product_factory.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 FactoryBot.define do
-  factory :base_product, class: 'Spree::Product' do
+  factory :base_product, class: "Spree::Product" do
     sequence(:name) { |n| "Product ##{n} - #{Kernel.rand(9999)}" }
     description { "As seen on TV!" }
     price { 19.99 }
@@ -18,7 +18,7 @@ FactoryBot.define do
     before(:create) { create(:stock_location) if Spree::StockLocation.count == 0 }
 
     factory :custom_product do
-      name { 'Custom Product' }
+      name { "Custom Product" }
       price { 17.99 }
 
       tax_category { |r| Spree::TaxCategory.first || r.association(:tax_category) }

data/lib/spree/testing_support/factories/product_option_type_factory.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 FactoryBot.define do
-  factory :product_option_type, class: 'Spree::ProductOptionType' do
+  factory :product_option_type, class: "Spree::ProductOptionType" do
     product
     option_type
   end

data/lib/spree/testing_support/factories/product_property_factory.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 FactoryBot.define do
-  factory :product_property, class: 'Spree::ProductProperty' do
+  factory :product_property, class: "Spree::ProductProperty" do
     product
     property
   end

data/lib/spree/testing_support/factories/property_factory.rb

@@ -1,8 +1,8 @@
 # frozen_string_literal: true
 
 FactoryBot.define do
-  factory :property, class: 'Spree::Property' do
-    name { 'baseball_cap_color' }
-    presentation { 'cap color' }
+  factory :property, class: "Spree::Property" do
+    name { "baseball_cap_color" }
+    presentation { "cap color" }
   end
 end

data/lib/spree/testing_support/factories/refund_factory.rb

@@ -3,7 +3,7 @@
 FactoryBot.define do
   sequence(:refund_transaction_id) { |n| "fake-refund-transaction-#{n}" }
 
-  factory :refund, class: 'Spree::Refund' do
+  factory :refund, class: "Spree::Refund" do
     transient do
       payment_amount { 100 }
     end
@@ -11,7 +11,7 @@ FactoryBot.define do
     amount { 100.00 }
     transaction_id { generate(:refund_transaction_id) }
     payment do
-      association(:payment, state: 'completed', amount: payment_amount)
+      association(:payment, state: "completed", amount: payment_amount)
     end
     association(:reason, factory: :refund_reason)
   end

data/lib/spree/testing_support/factories/refund_reason_factory.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 FactoryBot.define do
-  factory :refund_reason, class: 'Spree::RefundReason' do
+  factory :refund_reason, class: "Spree::RefundReason" do
     sequence(:name) { |n| "Refund for return ##{n}" }
   end
 end

data/lib/spree/testing_support/factories/reimbursement_factory.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 FactoryBot.define do
-  factory :reimbursement, class: 'Spree::Reimbursement' do
+  factory :reimbursement, class: "Spree::Reimbursement" do
     transient do
       return_items_count { 1 }
     end

data/lib/spree/testing_support/factories/reimbursement_type_factory.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 FactoryBot.define do
-  factory :reimbursement_type, class: 'Spree::ReimbursementType' do
+  factory :reimbursement_type, class: "Spree::ReimbursementType" do
     sequence(:name) { |n| "Reimbursement Type #{n}" }
     active { true }
     mutable { true }

data/lib/spree/testing_support/factories/return_authorization_factory.rb

@@ -1,14 +1,14 @@
 # frozen_string_literal: true
 
 FactoryBot.define do
-  factory :return_authorization, class: 'Spree::ReturnAuthorization' do
+  factory :return_authorization, class: "Spree::ReturnAuthorization" do
     association(:order, factory: :shipped_order)
     association(:stock_location, factory: :stock_location)
     association(:reason, factory: :return_reason)
-    memo { 'Items were broken' }
+    memo { "Items were broken" }
   end
 
-  factory :new_return_authorization, class: 'Spree::ReturnAuthorization' do
+  factory :new_return_authorization, class: "Spree::ReturnAuthorization" do
     association(:order, factory: :shipped_order)
     association(:stock_location, factory: :stock_location)
     association(:reason, factory: :return_reason)

data/lib/spree/testing_support/factories/return_item_factory.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 FactoryBot.define do
-  factory :return_item, class: 'Spree::ReturnItem' do
+  factory :return_item, class: "Spree::ReturnItem" do
     association(:inventory_unit, factory: :inventory_unit, state: :shipped)
     association(:return_reason, factory: :return_reason)
     return_authorization do |_return_item|

data/lib/spree/testing_support/factories/return_reason_factory.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 FactoryBot.define do
-  factory :return_reason, class: 'Spree::ReturnReason' do
+  factory :return_reason, class: "Spree::ReturnReason" do
     sequence(:name) { |n| "Defect ##{n}" }
   end
 end

data/lib/spree/testing_support/factories/role_factory.rb

@@ -1,11 +1,11 @@
 # frozen_string_literal: true
 
 FactoryBot.define do
-  factory :role, class: 'Spree::Role' do
+  factory :role, class: "Spree::Role" do
     sequence(:name) { |n| "Role ##{n}" }
 
     factory :admin_role do
-      name { 'admin' }
+      name { "admin" }
     end
   end
 end

data/lib/spree/testing_support/factories/shipment_factory.rb

@@ -1,10 +1,10 @@
 # frozen_string_literal: true
 
 FactoryBot.define do
-  factory :shipment, class: 'Spree::Shipment' do
-    tracking { 'U10000' }
+  factory :shipment, class: "Spree::Shipment" do
+    tracking { "U10000" }
     cost { 100.00 }
-    state { 'pending' }
+    state { "pending" }
     order
     stock_location
 

data/lib/spree/testing_support/factories/shipping_category_factory.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 FactoryBot.define do
-  factory :shipping_category, class: 'Spree::ShippingCategory' do
+  factory :shipping_category, class: "Spree::ShippingCategory" do
     sequence(:name) { |n| "ShippingCategory ##{n}" }
   end
 end

data/lib/spree/testing_support/factories/shipping_method_factory.rb

@@ -6,16 +6,16 @@ FactoryBot.define do
     aliases: [
       :base_shipping_method
     ],
-    class: 'Spree::ShippingMethod'
+    class: "Spree::ShippingMethod"
   ) do
     zones do
-      [Spree::Zone.find_by(name: 'GlobalZone') || FactoryBot.create(:global_zone)]
+      [Spree::Zone.find_by(name: "GlobalZone") || FactoryBot.create(:global_zone)]
     end
 
-    name { 'UPS Ground' }
-    code { 'UPS_GROUND' }
-    carrier { 'UPS' }
-    service_level { '1DAYGROUND' }
+    name { "UPS Ground" }
+    code { "UPS_GROUND" }
+    carrier { "UPS" }
+    service_level { "1DAYGROUND" }
 
     calculator { |s| s.association(:shipping_calculator, strategy: :build, preferred_amount: s.cost, preferred_currency: s.currency) }
 
@@ -30,7 +30,7 @@ FactoryBot.define do
       end
     end
 
-    factory :free_shipping_method, class: 'Spree::ShippingMethod' do
+    factory :free_shipping_method, class: "Spree::ShippingMethod" do
       cost { nil }
       association(:calculator, factory: :shipping_no_amount_calculator, strategy: :build)
     end

data/lib/spree/testing_support/factories/shipping_rate_factory.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 FactoryBot.define do
-  factory :shipping_rate, class: 'Spree::ShippingRate' do
+  factory :shipping_rate, class: "Spree::ShippingRate" do
     shipping_method
     shipment
   end

data/lib/spree/testing_support/factories/state_factory.rb

@@ -1,10 +1,10 @@
 # frozen_string_literal: true
 
 FactoryBot.define do
-  factory :state, class: 'Spree::State' do
+  factory :state, class: "Spree::State" do
     transient do
-      country_iso { 'US' }
-      state_code { 'AL' }
+      country_iso { "US" }
+      state_code { "AL" }
 
       carmen_subregion do
         carmen_country = Carmen::Country.coded(country.iso)
@@ -17,7 +17,7 @@ FactoryBot.define do
         carmen_regions = carmen_regions.flat_map(&:subregions) if carmen_regions.first.subregions?
         region_collection = Carmen::RegionCollection.new(carmen_regions)
 
-        region_collection.coded(state_code) || region_collection.sort_by(&:name).first
+        region_collection.coded(state_code) || region_collection.min_by(&:name)
       end
     end
 

data/lib/spree/testing_support/factories/stock_item_factory.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 FactoryBot.define do
-  factory :stock_item, class: 'Spree::StockItem' do
+  factory :stock_item, class: "Spree::StockItem" do
     backorderable { true }
     association :stock_location, factory: :stock_location_without_variant_propagation
     variant

data/lib/spree/testing_support/factories/stock_location_factory.rb

@@ -1,16 +1,16 @@
 # frozen_string_literal: true
 
 FactoryBot.define do
-  factory :stock_location, class: 'Spree::StockLocation' do
-    name { 'NY Warehouse' }
-    address1 { '1600 Pennsylvania Ave NW' }
-    city { 'Washington' }
-    zipcode { '20500' }
-    phone { '(202) 456-1111' }
+  factory :stock_location, class: "Spree::StockLocation" do
+    name { "NY Warehouse" }
+    address1 { "1600 Pennsylvania Ave NW" }
+    city { "Washington" }
+    zipcode { "20500" }
+    phone { "(202) 456-1111" }
     active { true }
     backorderable_default { true }
 
-    country  { |stock_location| Spree::Country.first || stock_location.association(:country) }
+    country { |stock_location| Spree::Country.first || stock_location.association(:country) }
     state do |stock_location|
       carmen_country = Carmen::Country.coded(stock_location.country.iso)
       if carmen_country.subregions?

data/lib/spree/testing_support/factories/stock_movement_factory.rb

@@ -1,13 +1,13 @@
 # frozen_string_literal: true
 
 FactoryBot.define do
-  factory :stock_movement, class: 'Spree::StockMovement' do
+  factory :stock_movement, class: "Spree::StockMovement" do
     quantity { 1 }
-    action { 'sold' }
+    action { "sold" }
     stock_item
   end
 
   trait :received do
-    action { 'received' }
+    action { "received" }
   end
 end

data/lib/spree/testing_support/factories/stock_package_factory.rb

@@ -1,12 +1,12 @@
 # frozen_string_literal: true
 
 FactoryBot.define do
-  factory :stock_package, class: 'Spree::Stock::Package' do
+  factory :stock_package, class: "Spree::Stock::Package" do
     skip_create
 
     transient do
       stock_location { build(:stock_location) }
-      contents       { [] }
+      contents { [] }
       variants_contents { {} }
     end
 
@@ -19,7 +19,7 @@ FactoryBot.define do
     end
 
     factory :stock_package_fulfilled do
-      transient { variants_contents { { build(:variant) => 2 } } }
+      transient { variants_contents { {build(:variant) => 2} } }
     end
   end
 end

data/lib/spree/testing_support/factories/store_credit_category_factory.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 FactoryBot.define do
-  factory :store_credit_category, class: 'Spree::StoreCreditCategory' do
+  factory :store_credit_category, class: "Spree::StoreCreditCategory" do
     name { "Exchange" }
 
     trait :reimbursement do

data/lib/spree/testing_support/factories/store_credit_event_factory.rb

@@ -1,27 +1,27 @@
 # frozen_string_literal: true
 
 FactoryBot.define do
-  factory :store_credit_event, class: 'Spree::StoreCreditEvent' do
+  factory :store_credit_event, class: "Spree::StoreCreditEvent" do
     store_credit
-    amount             { 100.00 }
+    amount { 100.00 }
     authorization_code { "#{store_credit.id}-SC-20140602164814476128" }
-    action               { Spree::StoreCredit::AUTHORIZE_ACTION }
+    action { Spree::StoreCredit::AUTHORIZE_ACTION }
 
-    factory :store_credit_auth_event, class: 'Spree::StoreCreditEvent' do
-      action             { Spree::StoreCredit::AUTHORIZE_ACTION }
+    factory :store_credit_auth_event, class: "Spree::StoreCreditEvent" do
+      action { Spree::StoreCredit::AUTHORIZE_ACTION }
     end
 
     factory :store_credit_capture_event do
-      action             { Spree::StoreCredit::CAPTURE_ACTION }
+      action { Spree::StoreCredit::CAPTURE_ACTION }
     end
 
     factory :store_credit_adjustment_event do
-      action              { Spree::StoreCredit::ADJUSTMENT_ACTION }
+      action { Spree::StoreCredit::ADJUSTMENT_ACTION }
       store_credit_reason { create(:store_credit_reason) }
     end
 
     factory :store_credit_invalidate_event do
-      action              { Spree::StoreCredit::INVALIDATE_ACTION }
+      action { Spree::StoreCredit::INVALIDATE_ACTION }
       store_credit_reason { create(:store_credit_reason) }
     end
   end

data/lib/spree/testing_support/factories/store_credit_factory.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 FactoryBot.define do
-  factory :store_credit, class: 'Spree::StoreCredit' do
+  factory :store_credit, class: "Spree::StoreCredit" do
     association :user, strategy: :create
     association :created_by, factory: :user, strategy: :create
     association :category, factory: :store_credit_category, strategy: :create