solidus_core 3.1.7 → 3.2.0.alpha

data/lib/spree/migrations.rb

@@ -66,7 +66,7 @@ module Spree
     end
 
     def app_dir
-      "#{Rails.root}/db/migrate"
+      Spree::Config.migration_path
     end
 
     def engine_dir

data/lib/spree/permission_sets/default_customer.rb

@@ -7,7 +7,14 @@ module Spree
         can :read, Country
         can :read, OptionType
         can :read, OptionValue
-        can :create, Order
+        can :create, Order do |order, token|
+          # same user, or both nil
+          order.user == user ||
+          # guest checkout order
+          order.email.present? ||
+          # via API, just like with show and update
+          (order.guest_token.present? && token == order.guest_token)
+        end
         can [:show, :update], Order, Order.where(user: user) do |order, token|
           order.user == user || (order.guest_token.present? && token == order.guest_token)
         end

data/lib/spree/permitted_attributes.rb

@@ -65,10 +65,10 @@ module Spree
 
     @@line_item_attributes = [:id, :variant_id, :quantity]
 
-    @@option_type_attributes = [:name, :presentation, :option_values_attributes]
-
     @@option_value_attributes = [:name, :presentation]
 
+    @@option_type_attributes = [:name, :presentation, option_values_attributes: option_value_attributes]
+
     @@payment_attributes = [:amount, :payment_method_id, :payment_method]
 
     @@product_properties_attributes = [:property_name, :value, :position]
@@ -131,8 +131,8 @@ module Spree
     @@variant_attributes = [
       :name, :presentation, :cost_price, :lock_version,
       :position, :track_inventory,
-      :product_id, :product, :option_values_attributes, :price,
-      :weight, :height, :width, :depth, :sku, :cost_currency, option_value_ids: [], options: [:name, :value]
+      :product_id, :product, :price,
+      :weight, :height, :width, :depth, :sku, :cost_currency, :tax_category_id, option_value_ids: [], options: [:name, :value]
     ]
 
     @@checkout_address_attributes = [

data/lib/spree/preferences/configuration.rb

@@ -38,6 +38,7 @@ module Spree::Preferences
     #     defaults. Set via {#load_defaults}
     attr_reader :loaded_defaults
 
+    # @api private
     attr_reader :load_defaults_called
 
     def initialize
@@ -45,9 +46,9 @@ module Spree::Preferences
       @load_defaults_called = false
     end
 
-    # @param [String] Solidus version from which take defaults when not
-    # overriden.
-    # @see #load_defaults
+    # @param [String] Solidus version from which take defaults when preferences
+    # are not overriden by the user.
+    # @see #loaded_defaults
     def load_defaults(version)
       @loaded_defaults = version
       @load_defaults_called = true
@@ -118,21 +119,35 @@ module Spree::Preferences
       end
     end
 
-    # Generates a different preference default depending on {#version_defaults}
+    def self.inherited(klass)
+      klass.instance_variable_set(:@versioned_preferences, [])
+      class << klass
+        attr_reader :versioned_preferences
+      end
+    end
+
+    # Adds a preference with different default depending on {#loaded_defaults}
     #
-    # This method is meant to be used in the `default:` keyword argument for
-    # {.preference}. For instance, in the example, `foo`'s default was `true`
-    # until version 3.0.0.alpha, when it became `false`:
+    # This method is a specialized version of {.preference} that generates a
+    # different default value for different Solidus versions. For instance, in
+    # the example, `foo`'s default was `true` until version 3.0.0.alpha, when it
+    # became `false`:
     #
     # @example
-    #   preference :foo, :boolean, default: by_version(true, "3.0.0.alpha" => false)
+    #   versioned_preference :foo, :boolean, initial_value: true, boundaries: { "3.0.0.alpha" => false }
     #
+    # @see .preference
     # @see #loaded_defaults
     # @see Spree::Core::VersionedValue
-    def self.by_version(*args)
-      proc do |loaded_defaults|
-        Spree::Core::VersionedValue.new(*args).call(loaded_defaults)
-      end
+    def self.versioned_preference(name, type, initial_value:, boundaries:, **options)
+      @versioned_preferences << name
+      preference(
+        name,
+        type,
+        options.merge(
+          default: by_version(initial_value, boundaries)
+        )
+      )
     end
 
     def self.preference(name, type, options = {})
@@ -160,6 +175,13 @@ module Spree::Preferences
       end
     end
 
+    def self.by_version(*args)
+      proc do |loaded_defaults|
+        Spree::Core::VersionedValue.new(*args).call(loaded_defaults)
+      end
+    end
+    private_class_method :by_version
+
     private
 
     def context_for_default

data/lib/spree/preferences/preferable_class_methods.rb

@@ -49,7 +49,7 @@ module Spree::Preferences
 
                       If you want to branch on the provided Solidus version, you can do like the following:
 
-                      preference :foo, :string, default: by_version(true, "3.2.0" => false)
+                      versioned_preference :foo, :string, initial_value: true, boundaries: { "3.2.0" => false }
 
                     MSG
                     ->(_default_context) { given.call }

data/lib/spree/preferences/preference_differentiator.rb

@@ -12,7 +12,8 @@ module Spree
       def call(from:, to:)
         preferences_from = config_class.new.load_defaults(from)
         preferences_to = config_class.new.load_defaults(to)
-        preferences_from.reduce({}) do |changes, (pref_key, value_from)|
+        config_class.versioned_preferences.reduce({}) do |changes, pref_key|
+          value_from = preferences_from[pref_key]
           value_to = preferences_to[pref_key]
           if value_from == value_to
             changes

data/lib/spree/preferences/static_model_preferences.rb

@@ -36,8 +36,6 @@ module Spree
       end
 
       def add(klass, name, preferences)
-        # We use class name instead of class to allow reloading in dev
-        raise "Static model preference '#{name}' on #{klass} is already defined" if @store[klass.to_s][name]
         @store[klass.to_s][name] = Definition.new(klass, preferences)
       end
 

data/lib/spree/rails_compatibility.rb

@@ -0,0 +1,99 @@
+# frozen_string_literal: true
+
+module Spree
+  # Supported Rails versions compatibility
+  #
+  # This module is meant to wrap some Rails API changes between supported
+  # versions. It's also meant to contain compatibility for features that we use
+  # internally in the Solidus code base.
+  module RailsCompatibility
+    # Method `#to_fs`
+    #
+    # Available since Rails 7.0, substitutes `#to_s(format)`
+    #
+    # It includes:
+    #
+    # ActiveSupport::NumericWithFormat
+    # ActiveSupport::RangeWithFormat
+    # ActiveSupport::TimeWithZone
+    # Array
+    # Date
+    # DateTime
+    # Time
+    #
+    # See https://github.com/rails/rails/pull/43772 &
+    # https://github.com/rails/rails/pull/44354
+    #
+    # TODO: Remove when deprecating Rails 6.1
+    def self.to_fs(value, *args, **kwargs, &block)
+      if version_gte?('7.0')
+        value.to_fs(*args, **kwargs, &block)
+      else
+        value.to_s(*args, **kwargs, &block)
+      end
+    end
+
+    # `raise_on_missing_translations` config option
+    #
+    # Changed from ActionView to I18n on Rails 6.1
+    #
+    # See https://github.com/rails/rails/pull/31571
+    #
+    # TODO: Remove when deprecating Rails 6.0
+    def self.raise_on_missing_translations(value)
+      if version_gte?('6.1')
+        Rails.application.config.i18n.raise_on_missing_translations = value
+      else
+        Rails.application.config.action_view.raise_on_missing_translations = value
+      end
+    end
+
+    # Set current host for ActiveStorage in a controller
+    #
+    # Changed from `#host` to including a module in Rails 6
+    #
+    # See https://github.com/rails/rails/commit/e33c3cd8ccbecaca6c6af0438956431b02cb3fb2
+    #
+    # TODO: Remove when deprecating Rails 5.2
+    def self.active_storage_set_current(controller)
+      if version_gte?('6')
+        controller.include ActiveStorage::SetCurrent
+      else
+        controller.before_action do
+          ActiveStorage::Current.host = request.base_url
+        end
+      end
+    end
+
+    # Set current host for ActiveStorage
+    #
+    # Changed from `#host` to `#url_options` on Rails 7
+    #
+    # See https://github.com/rails/rails/issues/41388
+    #
+    # TODO: Remove when deprecating Rails 6.1
+    def self.active_storage_url_options_host(value)
+      if version_gte?('7')
+        ActiveStorage::Current.url_options = { host: value }
+      else
+        ActiveStorage::Current.host = value
+      end
+    end
+
+    # Default ActiveStorage variant processor
+    #
+    # Changed from `:mini_magick` to `vips` on Rails 7
+    #
+    # See https://github.com/rails/rails/issues/42744
+    #
+    # TODO: Remove when deprecating Rails 6.1
+    def self.variant_processor
+      version_gte?('7') ? :vips : :mini_magick
+    end
+
+    def self.version_gte?(version)
+      ::Rails.gem_version >= Gem::Version.new(version)
+    end
+    private_class_method :version_gte?
+  end
+end

data/lib/spree/testing_support/bus_helpers.rb

@@ -0,0 +1,101 @@
+# frozen_string_literal: true
+
+require 'spree/bus'
+
+module Spree
+  module TestingSupport
+    # RSpec test helpers for the event bus
+    #
+    # If you want to use the methods defined in this module, include it in your
+    # specs:
+    #
+    # @example
+    #   require 'rails_helper'
+    #   require 'spree/testing_support/bus_helpers'
+    #
+    #   RSpec.describe MyClass do
+    #     include Spree::TestingSupport::BusHelpers
+    #   end
+    #
+    # or, globally, in your `spec_helper.rb`:
+    #
+    # @example
+    #   require 'spree/testing_support/bus_helpers'
+    #
+    #   RSpec.configure do |config|
+    #     config.include Spree::TestingSupport::BusHelpers
+    #   end
+    module BusHelpers
+      extend RSpec::Matchers::DSL
+
+      # Stubs {Spree::Bus}
+      #
+      # After you have called this method in an example, {Spree::Bus} will no
+      # longer publish any event for the duration of that example. All the
+      # method invocations on it will be stubbed.
+      #
+      # Internally, it stubs {Spree::Bus#publish}.
+      #
+      # After you call this method, probably you'll want to call some of the
+      # matchers defined in this module.
+      def stub_spree_bus
+        allow(Spree::Bus).to receive(:publish)
+      end
+
+      # @!method have_been_published(event_name)
+      #   Matcher to test that an event has been published via {Spree::Bus#publish}
+      #
+      #   Before using this matcher, you need to call {#stub_spree_bus}.
+      #
+      #   Remember that the event listeners won't be performed.
+      #
+      #   @example
+      #     it 'publishes foo event' do
+      #       stub_spree_bus
+      #
+      #       Spree::Bus.publish 'foo'
+      #
+      #       expect('foo').to have_been_published
+      #     end
+      #
+      #   It can be chain through `with` to match with the published payload:
+      #
+      #   @example
+      #     it 'publishes foo event with the expected payload' do
+      #       stub_spree_bus
+      #
+      #       Spree::Bus.publish 'foo', bar: :baz, qux: :quux
+      #
+      #       expect('foo').to have_been_published.with(a_hash_including(bar: :baz))
+      #     end
+      #
+      #   @param [Symbol] event_name
+      matcher :have_been_published do
+        chain :with, :payload
+
+        match do |expected_event|
+          expected_event = normalize_name(expected_event)
+          arguments = payload ? [expected_event, payload] : [expected_event, any_args]
+          expect(Spree::Bus).to have_received(:publish).with(*arguments)
+        end
+
+        failure_message do |expected_event|
+          <<~MSG
+            expected #{expected_event.inspect} to have been published.
+            Make sure that provided payload, if any, also matches.
+          MSG
+        end
+
+        def normalize_name(event_name)
+          if event_name.is_a?(Symbol)
+            eq(event_name)
+          else
+            raise ArgumentError, <<~MSG
+              "#{event_name.inspect} is not a valid event name. It must be a Symbol."
+            MSG
+          end
+        end
+      end
+    end
+  end
+end

data/lib/spree/testing_support/common_rake.rb

@@ -6,33 +6,61 @@ end
 
 require 'generators/spree/dummy/dummy_generator'
 
-namespace :common do
-  task :test_app, :user_class do |_t, args|
-    args.with_defaults(user_class: "Spree::LegacyUser")
-    require ENV['LIB_NAME']
+class CommonRakeTasks
+  include Rake::DSL
 
-    ENV["RAILS_ENV"] = 'test'
+  def initialize
+    namespace :common do
+      task :test_app, :user_class do |_t, args|
+        args.with_defaults(user_class: "Spree::LegacyUser")
+        require ENV['LIB_NAME']
+
+        force_rails_environment_to_test
+
+        Spree::DummyGenerator.start ["--lib_name=#{ENV['LIB_NAME']}", "--quiet"]
+        Solidus::InstallGenerator.start ["--lib_name=#{ENV['LIB_NAME']}", "--auto-accept", "--with-authentication=false", "--payment-method=none", "--migrate=false", "--seed=false", "--sample=false", "--quiet", "--user_class=#{args[:user_class]}"]
+
+        puts "Setting up dummy database..."
 
-    Spree::DummyGenerator.start ["--lib_name=#{ENV['LIB_NAME']}", "--quiet"]
-    Solidus::InstallGenerator.start ["--lib_name=#{ENV['LIB_NAME']}", "--auto-accept", "--with-authentication=false", "--payment-method=none", "--migrate=false", "--seed=false", "--sample=false", "--quiet", "--user_class=#{args[:user_class]}"]
+        sh "bin/rails db:environment:set RAILS_ENV=test"
+        sh "bin/rails db:drop db:create db:migrate VERBOSE=false RAILS_ENV=test"
 
-    puts "Setting up dummy database..."
+        if extension_installation_generator_exists?
+          puts 'Running extension installation generator...'
+          sh "bin/rails generate #{rake_generator_namespace}:install --auto-run-migrations"
+        end
+      end
 
-    sh "bin/rails db:environment:set RAILS_ENV=test"
-    sh "bin/rails db:drop db:create db:migrate VERBOSE=false RAILS_ENV=test"
+      task :seed do |_t, _args|
+        puts "Seeding ..."
 
-    begin
-      require "generators/#{ENV['LIB_NAME']}/install/install_generator"
-      puts 'Running extension installation generator...'
-      "#{ENV['LIB_NAMESPACE'] || ENV['LIB_NAME'].camelize}::Generators::InstallGenerator".constantize.start(["--auto-run-migrations"])
-    rescue LoadError
-      # No extension generator to run
+        sh "bundle exec rake db:seed RAILS_ENV=test"
+      end
     end
   end
 
-  task :seed do |_t, _args|
-    puts "Seeding ..."
+  private
 
-    sh "bundle exec rake db:seed RAILS_ENV=test"
+  def force_rails_environment_to_test
+    ENV["RAILS_ENV"] = 'test'
+    Rails.env = 'test'
+  end
+
+  def extension_installation_generator_exists?
+    require "generators/#{generator_namespace}/install/install_generator"
+
+    true
+  rescue LoadError
+    false
+  end
+
+  def generator_namespace
+    "#{ENV['LIB_NAMESPACE']&.underscore || ENV['LIB_NAME']}"
+  end
+
+  def rake_generator_namespace
+    generator_namespace.gsub("/", ":")
   end
 end
+
+CommonRakeTasks.new

data/lib/spree/testing_support/dummy_app/assets/javascripts/spree/backend/all.js

@@ -1,5 +1,5 @@
 // This is a manifest file that'll be compiled into including all the files listed below.
-// Add new JavaScript/Coffee code in separate files in this directory and they'll automatically
+// Add new JavaScript code in separate files in this directory and they'll automatically
 // be included in the compiled file accessible from http://example.com/assets/application.js
 // It's not advisable to add code directly here, but if you do, it'll appear at the bottom of the
 // the compiled file.

data/lib/spree/testing_support/dummy_app/assets/javascripts/spree/frontend/all.js

@@ -1,5 +1,5 @@
 // This is a manifest file that'll be compiled into including all the files listed below.
-// Add new JavaScript/Coffee code in separate files in this directory and they'll automatically
+// Add new JavaScript code in separate files in this directory and they'll automatically
 // be included in the compiled file accessible from http://example.com/assets/application.js
 // It's not advisable to add code directly here, but if you do, it'll appear at the bottom of the
 // the compiled file.

data/lib/spree/testing_support/dummy_app.rb

@@ -48,7 +48,6 @@ module DummyApp
   class Application < ::Rails::Application
     config.load_defaults("#{Rails::VERSION::MAJOR}.#{Rails::VERSION::MINOR}")
     # Make the test environment more production-like:
-    config.cache_classes = true
     config.action_controller.allow_forgery_protection = false
     config.action_controller.default_protect_from_forgery = false
     config.action_mailer.perform_caching = false
@@ -60,6 +59,10 @@ module DummyApp
     # https://github.com/solidusio/solidus/issues/4110
     config.action_controller.perform_caching = false
 
+    # It needs to be explicitly set from Rails 7
+    # https://guides.rubyonrails.org/upgrading_ruby_on_rails.html#upgrading-from-rails-6-1-to-rails-7-0-spring
+    config.cache_classes = true
+
     # Make debugging easier:
     config.consider_all_requests_local = true
     config.action_dispatch.show_exceptions = false
@@ -96,7 +99,7 @@ module DummyApp
           }
         }
         config.active_storage.service = :test
-        config.active_storage.variant_processor = ENV.fetch('ACTIVE_STORAGE_VARIANT_PROCESSOR', :mini_magick).to_sym
+        config.active_storage.variant_processor = ENV.fetch('ACTIVE_STORAGE_VARIANT_PROCESSOR', Spree::RailsCompatibility.variant_processor).to_sym
       end
     end
 
@@ -135,6 +138,7 @@ Spree.user_class = 'Spree::LegacyUser'
 Spree.load_defaults(Spree.solidus_version)
 Spree.config do |config|
   config.mails_from = "store@example.com"
+  config.use_legacy_events = ENV['USE_LEGACY_EVENTS'].present?
 
   if ENV['DISABLE_ACTIVE_STORAGE']
     config.image_attachment_module = 'Spree::Image::PaperclipAttachment'

data/lib/spree/testing_support/factories/address_factory.rb

@@ -26,14 +26,19 @@ FactoryBot.define do
 
     state do |address|
       Spree::State.joins(:country).where('spree_countries.iso = (?)', country_iso_code).find_by(abbr: state_code) ||
-        address.association(:state, country_iso: country_iso_code, state_code: state_code)
+        address.association(
+          :state,
+          strategy: :create,
+          country_iso: country_iso_code,
+          state_code: state_code
+        )
     end
 
     country do |address|
       if address.state
         address.state.country
       else
-        address.association(:country, iso: country_iso_code)
+        address.association(:country, strategy: :create, iso: country_iso_code)
       end
     end
   end

data/lib/spree/testing_support/factories/inventory_unit_factory.rb

@@ -17,7 +17,7 @@ FactoryBot.define do
       stock_location { nil }
     end
 
-    variant
+    association :variant, strategy: :create
     line_item do
       if order
         build(:line_item, variant: variant, order: order)

data/lib/spree/testing_support/factories/order_factory.rb

@@ -19,7 +19,7 @@ FactoryBot.define do
     ship_address
     completed_at { nil }
     email { user.try(:email) }
-    store
+    association :store, strategy: :create
 
     transient do
       line_items_price { BigDecimal(10) }
@@ -68,6 +68,7 @@ FactoryBot.define do
 
       factory :completed_order_with_promotion do
         transient do
+          completed_at { Time.current }
           promotion { nil }
         end
 
@@ -79,7 +80,7 @@ FactoryBot.define do
           order.order_promotions.create!(promotion: promotion, promotion_code: promotion_code)
 
           # Complete the order after the promotion has been activated
-          order.update_column(:completed_at, Time.current)
+          order.update_column(:completed_at, evaluator.completed_at)
           order.update_column(:state, "complete")
         end
       end
@@ -104,13 +105,16 @@ FactoryBot.define do
       end
 
       factory :completed_order_with_totals do
+        transient do
+          completed_at { Time.current }
+        end
         state { 'complete' }
 
-        after(:create) do |order|
+        after(:create) do |order, evaluator|
           order.shipments.each do |shipment|
             shipment.inventory_units.update_all state: 'on_hand', pending: false
           end
-          order.update_column(:completed_at, Time.current)
+          order.update_column(:completed_at, evaluator.completed_at)
         end
 
         factory :completed_order_with_pending_payment do

data/lib/spree/testing_support/factories/product_factory.rb

@@ -20,7 +20,10 @@ FactoryBot.define do
     sku { generate(:sku) }
     available_on { 1.year.ago }
     deleted_at { nil }
-    shipping_category { |r| Spree::ShippingCategory.first || r.association(:shipping_category) }
+    shipping_category do |r|
+      Spree::ShippingCategory.first ||
+        r.association(:shipping_category, strategy: :create)
+    end
 
     # ensure stock item will be created for this products master
     before(:create) { create(:stock_location) if Spree::StockLocation.count == 0 }

data/lib/spree/testing_support/factories/store_credit_factory.rb

@@ -11,11 +11,11 @@ end
 
 FactoryBot.define do
   factory :store_credit, class: 'Spree::StoreCredit' do
-    user
-    association :created_by, factory: :user
-    association :category, factory: :store_credit_category
+    association :user, strategy: :create
+    association :created_by, factory: :user, strategy: :create
+    association :category, factory: :store_credit_category, strategy: :create
     amount { 150.00 }
     currency { "USD" }
-    association :credit_type, factory: :primary_credit_type
+    association :credit_type, factory: :primary_credit_type, strategy: :create
   end
 end

data/lib/spree/testing_support/factory_bot.rb

@@ -44,7 +44,7 @@ module Spree
       def self.check_version
         require "factory_bot/version"
 
-        requirement = Gem::Requirement.new("~> 4.8")
+        requirement = Gem::Requirement.new(">= 4.8")
         version = Gem::Version.new(::FactoryBot::VERSION)
 
         unless requirement.satisfied_by? version

data/lib/spree/testing_support/order_walkthrough.rb

@@ -3,11 +3,11 @@
 module Spree
   module TestingSupport
     class OrderWalkthrough
-      def self.up_to(state)
-        new.up_to(state)
+      def self.up_to(state, user: nil)
+        new.up_to(state, user: user)
       end
 
-      def up_to(state)
+      def up_to(state, user: nil)
         # Need to create a valid zone too...
         @zone = ::FactoryBot.create(:zone)
         @country = ::FactoryBot.create(:country)
@@ -23,6 +23,7 @@ module Spree
         end
 
         order = Spree::Order.create!(
+          user: user,
           email: "solidus@example.com",
           store: Spree::Store.first || ::FactoryBot.create(:store)
         )
@@ -61,7 +62,7 @@ module Spree
       end
 
       def payment(order)
-        credit_card = ::FactoryBot.create(:credit_card)
+        credit_card = ::FactoryBot.create(:credit_card, user: order.user)
         order.payments.create!(payment_method: credit_card.payment_method, amount: order.total, source: credit_card)
         # TODO: maybe look at some way of making this payment_state change automatic
         order.payment_state = 'paid'

data/lib/spree/testing_support/silence_deprecations.rb

@@ -0,0 +1,9 @@
+# frozen_string_literal: true
+
+RSpec.configure do |config|
+  config.around(:each, silence_deprecations: true) do |example|
+    Spree::Deprecation.silence do
+      example.run
+    end
+  end
+end