solidus_core 3.0.0 → 4.5.1

data/lib/spree/deprecator.rb

@@ -0,0 +1,9 @@
+# frozen_string_literal: true
+
+require 'active_support/deprecation'
+
+module Spree
+  def self.deprecator
+    @deprecator ||= ActiveSupport::Deprecation.new('5.0', 'Solidus')
+  end
+end

data/lib/spree/i18n.rb

@@ -5,7 +5,7 @@ require 'i18n'
 module Spree
   def self.i18n_available_locales
     I18n.available_locales.select do |locale|
-      I18n.t('spree.i18n.this_file_language', locale: locale, fallback: false, default: nil)
+      I18n.t('spree.i18n.this_file_language', locale:, fallback: false, default: nil)
     end
   end
 

data/lib/spree/mailer_previews/carton_preview.rb

@@ -7,7 +7,7 @@ module Spree
         carton = Carton.joins(:orders).last
         raise "Your database needs at least one shipped order with a carton to render this preview" unless carton
 
-        Spree::Config.carton_shipped_email_class.shipped_email(order: carton.orders.first, carton: carton)
+        Spree::Config.carton_shipped_email_class.shipped_email(order: carton.orders.first, carton:)
       end
     end
   end

data/lib/spree/migration_helpers.rb

@@ -6,9 +6,9 @@ module Spree
       remove_index(table, column) if index_exists?(table, column)
     end
 
-    def safe_add_index(table, column, options = {})
-      if columns_exist?(table, column) && !index_exists?(table, column, options)
-        add_index(table, column, options)
+    def safe_add_index(table, column, **options)
+      if columns_exist?(table, column) && !index_exists?(table, column, **options)
+        add_index(table, column, **options)
       end
     end
 

data/lib/spree/migrations.rb

@@ -23,16 +23,18 @@ module Spree
     # Shouldn't run on test mode because migrations inside engine don't have
     # engine name on the file name
     def check
-      if File.directory?(app_dir)
-        unless missing_migrations.empty?
-          puts "[#{engine_name.capitalize} WARNING] Missing migrations."
-          missing_migrations.each do |migration|
-            puts "[#{engine_name.capitalize} WARNING] #{migration} from #{engine_name} is missing."
-          end
-          puts "[#{engine_name.capitalize} WARNING] Run `bundle exec rake railties:install:migrations` to get them.\n\n"
-          true
-        end
-      end
+      return unless File.directory?(app_dir)
+      return if missing_migrations.empty?
+      return if ENV['SOLIDUS_SKIP_MIGRATIONS_CHECK']
+
+      prefix = "[WARNING #{engine_name.capitalize}]"
+      warn <<~WARN
+        #{prefix} Missing migrations.
+        #{missing_migrations.map {|m| "#{prefix} - #{m}"}.join("\n")}
+        #{prefix}
+        #{prefix} Run `bin/rails railties:install:migrations` to get them.
+        #{prefix} You can silence this warning by setting the `SOLIDUS_SKIP_MIGRATIONS_CHECK` environment variable.
+      WARN
     end
 
     def missing_migrations
@@ -66,7 +68,7 @@ module Spree
     end
 
     def app_dir
-      "#{Rails.root}/db/migrate"
+      Spree::Config.migration_path
     end
 
     def engine_dir

data/lib/spree/money.rb

@@ -1,120 +1,7 @@
 # frozen_string_literal: true
 
-module Spree
-  # Spree::Money is a relatively thin wrapper around Monetize which handles
-  # formatting via Spree::Config.
-  class Money
-    include Comparable
-    DifferentCurrencyError = Class.new(StandardError)
-
-    class <<self
-      attr_accessor :default_formatting_rules
-
-      def parse(amount, currency = Spree::Config[:currency])
-        new(parse_to_money(amount, currency))
-      end
-
-      # @api private
-      def parse_to_money(amount, currency)
-        ::Monetize.parse(amount, currency)
-      end
-    end
-    self.default_formatting_rules = {
-      # Ruby money currently has this as false, which is wrong for the vast
-      # majority of locales.
-      sign_before_symbol: true
-    }
-
-    attr_reader :money
-
-    delegate :cents, :currency, :to_d, :zero?, to: :money
-
-    # @param amount [Money, #to_s] the value of the money object
-    # @param options [Hash] the default options for formatting the money object See #format
-    def initialize(amount, options = {})
-      if amount.is_a?(::Money)
-        @money = amount
-      else
-        currency = (options[:currency] || Spree::Config[:currency])
-
-        @money = Monetize.from_string(amount, currency)
-      end
-      @options = Spree::Money.default_formatting_rules.merge(options)
-    end
-
-    # @return [String] the value of this money object formatted according to
-    #   its options
-    def to_s
-      format
-    end
-
-    # @param options [Hash, String] the options for formatting the money object
-    # @option options [Boolean] with_currency when true, show the currency
-    # @option options [Boolean] no_cents when true, round to the closest dollar
-    # @option options [String] decimal_mark the mark for delimiting the
-    #   decimals
-    # @option options [String, false, nil] thousands_separator the character to
-    #   delimit powers of 1000, if one is desired, otherwise false or nil
-    # @option options [Boolean] sign_before_symbol when true the sign of the
-    #   value comes before the currency symbol
-    # @option options [:before, :after] symbol_position the position of the
-    #   currency symbol
-    # @return [String] the value of this money object formatted according to
-    #   its options
-    def format(options = {})
-      @money.format(@options.merge(options))
-    end
-
-    # @note If you pass in options, ensure you pass in the { html_wrap: true } as well.
-    # @param options [Hash] additional formatting options
-    # @return [String] the value of this money object formatted according to
-    #   its options and any additional options, by default with html_wrap.
-    def to_html(options = { html_wrap: true })
-      output = format(options)
-      # Maintain compatibility by checking html option renamed to html_wrap.
-      if options[:html_wrap]
-        output = output.html_safe
-      end
-      output
-    end
-
-    # (see #to_s)
-    def as_json(*)
-      to_s
-    end
-
-    def <=>(other)
-      if !other.respond_to?(:money)
-        raise TypeError, "Can't compare #{other.class} to Spree::Money"
-      end
-      if currency != other.currency
-        # By default, ::Money will try to run a conversion on `other.money` and
-        # try a comparison on that. We do not want any currency conversion to
-        # take place so we'll catch this here and raise an error.
-        raise(
-          DifferentCurrencyError,
-          "Can't compare #{currency} with #{other.currency}"
-        )
-      end
-      @money <=> other.money
-    end
-
-    # Delegates comparison to the internal ruby money instance.
-    #
-    # @see http://www.rubydoc.info/gems/money/Money/Arithmetic#%3D%3D-instance_method
-    def ==(other)
-      raise TypeError, "Can't compare #{other.class} to Spree::Money" if !other.respond_to?(:money)
-      @money == other.money
-    end
-
-    def -(other)
-      raise TypeError, "Can't subtract #{other.class} to Spree::Money" if !other.respond_to?(:money)
-      self.class.new(@money - other.money)
-    end
-
-    def +(other)
-      raise TypeError, "Can't add #{other.class} to Spree::Money" if !other.respond_to?(:money)
-      self.class.new(@money + other.money)
-    end
-  end
-end
+Spree.deprecator.warn(
+  <<~MSG
+    The file "#{__FILE__}" does not need to be `require`d any longer, it is now autoloaded.
+  MSG
+)

data/lib/spree/permission_sets/base.rb

@@ -1,32 +1,7 @@
 # frozen_string_literal: true
 
-module Spree
-  module PermissionSets
-    # This is the base class used for crafting permission sets.
-    #
-    # This is used by {Spree::RoleConfiguration} when adding custom behavior to {Spree::Ability}.
-    # See one of the subclasses for example structure such as {Spree::PermissionSets::UserDisplay}
-    #
-    # @see Spree::RoleConfiguration
-    # @see Spree::PermissionSets
-    class Base
-      # @param ability [CanCan::Ability]
-      #   The ability that will be extended with the current permission set.
-      #   The ability passed in must respond to #user
-      def initialize(ability)
-        @ability = ability
-      end
-
-      # Activate permissions on the ability. Put your can and cannot statements here.
-      # Must be overriden by subclasses
-      def activate!
-        raise NotImplementedError.new
-      end
-
-      private
-
-      attr_reader :ability
-      delegate :can, :cannot, :user, to: :ability
-    end
-  end
-end
+Spree.deprecator.warn(
+  <<~MSG
+    The file "#{__FILE__}" does not need to be `require`d any longer, it is now autoloaded.
+  MSG
+)

data/lib/spree/permission_sets/configuration_display.rb

@@ -1,25 +1,7 @@
 # frozen_string_literal: true
 
-module Spree
-  module PermissionSets
-    class ConfigurationDisplay < PermissionSets::Base
-      def activate!
-          can [:edit, :admin], :general_settings
-          can [:read, :admin], Spree::TaxCategory
-          can [:read, :admin], Spree::TaxRate
-          can [:read, :admin], Spree::Zone
-          can [:read, :admin], Spree::Country
-          can [:read, :admin], Spree::State
-          can [:read, :admin], Spree::PaymentMethod
-          can [:read, :admin], Spree::Taxonomy
-          can [:read, :admin], Spree::ShippingMethod
-          can [:read, :admin], Spree::ShippingCategory
-          can [:read, :admin], Spree::StockLocation
-          can [:read, :admin], Spree::StockMovement
-          can [:read, :admin], Spree::RefundReason
-          can [:read, :admin], Spree::ReimbursementType
-          can [:read, :admin], Spree::ReturnReason
-      end
-    end
-  end
-end
+Spree.deprecator.warn(
+  <<~MSG
+    The file "#{__FILE__}" does not need to be `require`d any longer, it is now autoloaded.
+  MSG
+)

data/lib/spree/permission_sets/configuration_management.rb

@@ -1,25 +1,7 @@
 # frozen_string_literal: true
 
-module Spree
-  module PermissionSets
-    class ConfigurationManagement < PermissionSets::Base
-      def activate!
-        can :manage, :general_settings
-        can :manage, Spree::TaxCategory
-        can :manage, Spree::TaxRate
-        can :manage, Spree::Zone
-        can :manage, Spree::Country
-        can :manage, Spree::State
-        can :manage, Spree::PaymentMethod
-        can :manage, Spree::Taxonomy
-        can :manage, Spree::ShippingMethod
-        can :manage, Spree::ShippingCategory
-        can :manage, Spree::StockLocation
-        can :manage, Spree::StockMovement
-        can :manage, Spree::RefundReason
-        can :manage, Spree::ReimbursementType
-        can :manage, Spree::ReturnReason
-      end
-    end
-  end
-end
+Spree.deprecator.warn(
+  <<~MSG
+    The file "#{__FILE__}" does not need to be `require`d any longer, it is now autoloaded.
+  MSG
+)

data/lib/spree/permission_sets/dashboard_display.rb

@@ -1,11 +1,7 @@
 # frozen_string_literal: true
 
-module Spree
-  module PermissionSets
-    class DashboardDisplay < PermissionSets::Base
-      def activate!
-          can [:admin, :home], :dashboards
-      end
-    end
-  end
-end
+Spree.deprecator.warn(
+  <<~MSG
+    The file "#{__FILE__}" does not need to be `require`d any longer, it is now autoloaded.
+  MSG
+)

data/lib/spree/permission_sets/default_customer.rb

@@ -1,37 +1,7 @@
 # frozen_string_literal: true
 
-module Spree
-  module PermissionSets
-    class DefaultCustomer < PermissionSets::Base
-      def activate!
-        can :read, Country
-        can :read, OptionType
-        can :read, OptionValue
-        can :create, Order
-        can [:show, :update], Order, Order.where(user: user) do |order, token|
-          order.user == user || (order.guest_token.present? && token == order.guest_token)
-        end
-        cannot :update, Order do |order|
-          order.completed?
-        end
-        can :create, ReturnAuthorization do |return_authorization|
-          return_authorization.order.user == user
-        end
-        can [:read, :update], CreditCard, user_id: user.id
-        can :read, Product
-        can :read, ProductProperty
-        can :read, Property
-        can :create, Spree.user_class
-        can [:show, :update, :update_email], Spree.user_class, id: user.id
-        can :read, State
-        can :read, StockItem, stock_location: { active: true }
-        can :read, StockLocation, active: true
-        can :read, Taxon
-        can :read, Taxonomy
-        can [:save_in_address_book, :remove_from_address_book], Spree.user_class, id: user.id
-        can [:read, :view_out_of_stock], Variant
-        can :read, Zone
-      end
-    end
-  end
-end
+Spree.deprecator.warn(
+  <<~MSG
+    The file "#{__FILE__}" does not need to be `require`d any longer, it is now autoloaded.
+  MSG
+)

data/lib/spree/permission_sets/order_display.rb

@@ -1,21 +1,7 @@
 # frozen_string_literal: true
 
-module Spree
-  module PermissionSets
-    class OrderDisplay < PermissionSets::Base
-      def activate!
-        can [:read, :admin, :edit, :cart], Spree::Order
-        can [:read, :admin], Spree::Payment
-        can [:read, :admin], Spree::Shipment
-        can [:read, :admin], Spree::Adjustment
-        can [:read, :admin], Spree::LineItem
-        can [:read, :admin], Spree::ReturnAuthorization
-        can [:read, :admin], Spree::CustomerReturn
-        can [:read, :admin], Spree::OrderCancellations
-        can [:read, :admin], Spree::Reimbursement
-        can [:read, :admin], Spree::ReturnItem
-        can [:read, :admin], Spree::Refund
-      end
-    end
-  end
-end
+Spree.deprecator.warn(
+  <<~MSG
+    The file "#{__FILE__}" does not need to be `require`d any longer, it is now autoloaded.
+  MSG
+)

data/lib/spree/permission_sets/order_management.rb

@@ -1,22 +1,7 @@
 # frozen_string_literal: true
 
-module Spree
-  module PermissionSets
-    class OrderManagement < PermissionSets::Base
-      def activate!
-        can :read, Spree::ReimbursementType
-        can :manage, Spree::Order
-        can :manage, Spree::Payment
-        can :manage, Spree::Shipment
-        can :manage, Spree::Adjustment
-        can :manage, Spree::LineItem
-        can :manage, Spree::ReturnAuthorization
-        can :manage, Spree::CustomerReturn
-        can :manage, Spree::OrderCancellations
-        can :manage, Spree::Reimbursement
-        can :manage, Spree::ReturnItem
-        can :manage, Spree::Refund
-      end
-    end
-  end
-end
+Spree.deprecator.warn(
+  <<~MSG
+    The file "#{__FILE__}" does not need to be `require`d any longer, it is now autoloaded.
+  MSG
+)

data/lib/spree/permission_sets/product_display.rb

@@ -1,19 +1,7 @@
 # frozen_string_literal: true
 
-module Spree
-  module PermissionSets
-    class ProductDisplay < PermissionSets::Base
-      def activate!
-        can [:read, :admin, :edit], Spree::Product
-        can [:read, :admin], Spree::Image
-        can [:read, :admin], Spree::Variant
-        can [:read, :admin], Spree::OptionValue
-        can [:read, :admin], Spree::ProductProperty
-        can [:read, :admin], Spree::OptionType
-        can [:read, :admin], Spree::Property
-        can [:read, :admin], Spree::Taxonomy
-        can [:read, :admin], Spree::Taxon
-      end
-    end
-  end
-end
+Spree.deprecator.warn(
+  <<~MSG
+    The file "#{__FILE__}" does not need to be `require`d any longer, it is now autoloaded.
+  MSG
+)

data/lib/spree/permission_sets/product_management.rb

@@ -1,21 +1,7 @@
 # frozen_string_literal: true
 
-module Spree
-  module PermissionSets
-    class ProductManagement < PermissionSets::Base
-      def activate!
-        can :manage, Spree::Classification
-        can :manage, Spree::Image
-        can :manage, Spree::OptionType
-        can :manage, Spree::OptionValue
-        can :manage, Spree::Price
-        can :manage, Spree::Product
-        can :manage, Spree::ProductProperty
-        can :manage, Spree::Property
-        can :manage, Spree::Taxon
-        can :manage, Spree::Taxonomy
-        can :manage, Spree::Variant
-      end
-    end
-  end
-end
+Spree.deprecator.warn(
+  <<~MSG
+    The file "#{__FILE__}" does not need to be `require`d any longer, it is now autoloaded.
+  MSG
+)

data/lib/spree/permission_sets/restricted_stock_display.rb

@@ -1,18 +1,7 @@
 # frozen_string_literal: true
 
-module Spree
-  module PermissionSets
-    class RestrictedStockDisplay < PermissionSets::Base
-      def activate!
-        can [:read, :admin], Spree::StockItem, stock_location_id: location_ids
-        can :read, Spree::StockLocation, id: location_ids
-      end
-
-      private
-
-      def location_ids
-        @ids ||= user.stock_locations.pluck(:id)
-      end
-    end
-  end
-end
+Spree.deprecator.warn(
+  <<~MSG
+    The file "#{__FILE__}" does not need to be `require`d any longer, it is now autoloaded.
+  MSG
+)

data/lib/spree/permission_sets/restricted_stock_management.rb

@@ -1,18 +1,7 @@
 # frozen_string_literal: true
 
-module Spree
-  module PermissionSets
-    class RestrictedStockManagement < PermissionSets::Base
-      def activate!
-        can :manage, Spree::StockItem, stock_location_id: location_ids
-        can :read, Spree::StockLocation, id: location_ids
-      end
-
-      private
-
-      def location_ids
-        @ids ||= user.stock_locations.pluck(:id)
-      end
-    end
-  end
-end
+Spree.deprecator.warn(
+  <<~MSG
+    The file "#{__FILE__}" does not need to be `require`d any longer, it is now autoloaded.
+  MSG
+)

data/lib/spree/permission_sets/stock_display.rb

@@ -1,12 +1,7 @@
 # frozen_string_literal: true
 
-module Spree
-  module PermissionSets
-    class StockDisplay < PermissionSets::Base
-      def activate!
-        can [:read, :admin], Spree::StockItem
-        can :read, Spree::StockLocation
-      end
-    end
-  end
-end
+Spree.deprecator.warn(
+  <<~MSG
+    The file "#{__FILE__}" does not need to be `require`d any longer, it is now autoloaded.
+  MSG
+)

data/lib/spree/permission_sets/stock_management.rb

@@ -1,12 +1,7 @@
 # frozen_string_literal: true
 
-module Spree
-  module PermissionSets
-    class StockManagement < PermissionSets::Base
-      def activate!
-        can :manage, Spree::StockItem
-        can :read, Spree::StockLocation
-      end
-    end
-  end
-end
+Spree.deprecator.warn(
+  <<~MSG
+    The file "#{__FILE__}" does not need to be `require`d any longer, it is now autoloaded.
+  MSG
+)

data/lib/spree/permission_sets/super_user.rb

@@ -1,11 +1,7 @@
 # frozen_string_literal: true
 
-module Spree
-  module PermissionSets
-    class SuperUser < PermissionSets::Base
-      def activate!
-        can :manage, :all
-      end
-    end
-  end
-end
+Spree.deprecator.warn(
+  <<~MSG
+    The file "#{__FILE__}" does not need to be `require`d any longer, it is now autoloaded.
+  MSG
+)

data/lib/spree/permission_sets/user_display.rb

@@ -1,13 +1,7 @@
 # frozen_string_literal: true
 
-module Spree
-  module PermissionSets
-    class UserDisplay < PermissionSets::Base
-      def activate!
-        can [:read, :admin, :edit, :addresses, :orders, :items], Spree.user_class
-        can [:read, :admin], Spree::StoreCredit
-        can :read, Spree::Role
-      end
-    end
-  end
-end
+Spree.deprecator.warn(
+  <<~MSG
+    The file "#{__FILE__}" does not need to be `require`d any longer, it is now autoloaded.
+  MSG
+)

data/lib/spree/permission_sets/user_management.rb

@@ -1,25 +1,7 @@
 # frozen_string_literal: true
 
-module Spree
-  module PermissionSets
-    class UserManagement < PermissionSets::Base
-      def activate!
-        can [:admin, :read, :create, :update, :save_in_address_book, :remove_from_address_book, :addresses, :orders, :items], Spree.user_class
-
-        # Note: This does not work with accessible_by.
-        # See https://github.com/solidusio/solidus/pull/1263
-        can :update_email, Spree.user_class do |user|
-          user.spree_roles.none?
-        end
-        can :update_password, Spree.user_class do |user|
-          user.spree_roles.none?
-        end
-
-        cannot :destroy, Spree.user_class
-        can :manage, Spree::StoreCredit
-        can :manage, :api_key
-        can :read, Spree::Role
-      end
-    end
-  end
-end
+Spree.deprecator.warn(
+  <<~MSG
+    The file "#{__FILE__}" does not need to be `require`d any longer, it is now autoloaded.
+  MSG
+)

data/lib/spree/permission_sets.rb

@@ -1,20 +1,7 @@
 # frozen_string_literal: true
 
-require 'spree/permission_sets/base'
-require 'spree/permission_sets/configuration_display'
-require 'spree/permission_sets/configuration_management'
-require 'spree/permission_sets/dashboard_display'
-require 'spree/permission_sets/default_customer'
-require 'spree/permission_sets/order_display'
-require 'spree/permission_sets/order_management'
-require 'spree/permission_sets/product_display'
-require 'spree/permission_sets/product_management'
-require 'spree/permission_sets/promotion_display'
-require 'spree/permission_sets/promotion_management'
-require 'spree/permission_sets/restricted_stock_display'
-require 'spree/permission_sets/restricted_stock_management'
-require 'spree/permission_sets/stock_display'
-require 'spree/permission_sets/stock_management'
-require 'spree/permission_sets/super_user'
-require 'spree/permission_sets/user_display'
-require 'spree/permission_sets/user_management'
+Spree.deprecator.warn(
+  <<~MSG
+    The file "#{__FILE__}" does not need to be `require`d any longer, it is now autoloaded.
+  MSG
+)