solidus_core 2.9.6 → 2.11.0

data/spec/models/spree/returns_calculator_spec.rb

@@ -1,16 +0,0 @@
-# frozen_string_literal: true
-
-require 'rails_helper'
-
-module Spree
-  RSpec.describe ReturnsCalculator, type: :model do
-    let(:return_item) { build(:return_item) }
-    subject { ReturnsCalculator.new }
-
-    it 'compute_shipment must be overridden' do
-      expect {
-        subject.compute(return_item)
-      }.to raise_error NotImplementedError
-    end
-  end
-end

data/spec/models/spree/shipment_spec.rb

@@ -1,914 +0,0 @@
-# frozen_string_literal: true
-
-require 'rails_helper'
-require 'benchmark'
-
-RSpec.describe Spree::Shipment, type: :model do
-  let(:order) { create(:order_ready_to_ship, line_items_count: 1) }
-  let(:shipping_method) { create(:shipping_method, name: "UPS") }
-  let(:stock_location) { create(:stock_location) }
-  let(:shipment) do
-    order.shipments.create!(
-      state: 'pending',
-      cost: 1,
-      inventory_units: order.inventory_units,
-      shipping_rates: [shipping_rate],
-      stock_location: stock_location
-    )
-  end
-  let(:shipping_rate) do
-    Spree::ShippingRate.create!(
-      shipping_method: shipping_method,
-      selected: true
-    )
-  end
-
-  let(:variant) { mock_model(Spree::Variant) }
-  let(:line_item) { mock_model(Spree::LineItem, variant: variant) }
-
-  context '#transfer_to_location' do
-    it 'transfers unit to a new shipment with given location' do
-      order = create(:completed_order_with_totals, line_items_count: 2)
-      shipment = order.shipments.first
-      variant = order.inventory_units.map(&:variant).first
-
-      aggregate_failures("verifying new shipment attributes") do
-        expect do
-          Spree::Deprecation.silence do
-            shipment.transfer_to_location(variant, 1, stock_location)
-          end
-        end.to change { Spree::Shipment.count }.by(1)
-
-        new_shipment = order.shipments.order(:created_at).last
-        expect(new_shipment.number).to_not eq(shipment.number)
-        expect(new_shipment.stock_location).to eq(stock_location)
-        expect(new_shipment.line_items.count).to eq(1)
-        expect(new_shipment.line_items.first.variant).to eq(variant)
-      end
-    end
-  end
-
-  # Regression test for https://github.com/spree/spree/issues/4063
-  context "number generation" do
-    before { allow(order).to receive :update! }
-
-    it "generates a number containing a letter + 11 numbers" do
-      shipment.save
-      expect(shipment.number[0]).to eq("H")
-      expect(/\d{11}/.match(shipment.number)).not_to be_nil
-      expect(shipment.number.length).to eq(12)
-    end
-  end
-
-  it 'is backordered if one if its inventory_units is backordered' do
-    shipment.inventory_units = [
-      build(:inventory_unit, state: 'backordered', shipment: nil),
-      build(:inventory_unit, state: 'shipped', shipment: nil)
-    ]
-    expect(shipment).to be_backordered
-  end
-
-  context '#determine_state' do
-    it 'returns canceled if order is canceled?' do
-      allow(order).to receive_messages canceled?: true
-      expect(shipment.determine_state(order)).to eq 'canceled'
-    end
-
-    it 'returns pending unless order.can_ship?' do
-      allow(order).to receive_messages can_ship?: false
-      expect(shipment.determine_state(order)).to eq 'pending'
-    end
-
-    it 'returns pending if backordered' do
-      allow(shipment).to receive_messages inventory_units: [mock_model(Spree::InventoryUnit, allow_ship?: false, canceled?: false, shipped?: false)]
-      expect(shipment.determine_state(order)).to eq 'pending'
-    end
-
-    it 'returns shipped when already shipped' do
-      allow(shipment).to receive_messages state: 'shipped'
-      expect(shipment.determine_state(order)).to eq 'shipped'
-    end
-
-    it 'returns pending when unpaid' do
-      allow(order).to receive_messages paid?: false
-      expect(shipment.determine_state(order)).to eq 'pending'
-    end
-
-    it 'returns ready when paid' do
-      allow(order).to receive_messages paid?: true
-      expect(shipment.determine_state(order)).to eq 'ready'
-    end
-  end
-
-  context "display_amount" do
-    it "retuns a Spree::Money" do
-      shipment.cost = 21.22
-      expect(shipment.display_amount).to eq(Spree::Money.new(21.22))
-    end
-  end
-
-  context "display_total" do
-    it "retuns a Spree::Money" do
-      allow(shipment).to receive(:total) { 21.22 }
-      expect(shipment.display_total).to eq(Spree::Money.new(21.22))
-    end
-  end
-
-  context "display_item_cost" do
-    it "retuns a Spree::Money" do
-      allow(shipment).to receive(:item_cost) { 21.22 }
-      expect(shipment.display_item_cost).to eq(Spree::Money.new(21.22))
-    end
-  end
-
-  context "#item_cost" do
-    let(:shipment) { order.shipments[0] }
-
-    let(:order) do
-      create(
-        :order_ready_to_ship,
-        line_items_attributes: [{ price: 10, variant: variant }],
-        ship_address: ship_address,
-      )
-    end
-
-    let!(:ship_address) { create(:address) }
-    let!(:tax_zone) { create(:global_zone) } # will include the above address
-    let!(:tax_rate) { create(:tax_rate, amount: 0.1, zone: tax_zone, tax_categories: [tax_category]) }
-    let(:tax_category) { create(:tax_category) }
-    let(:variant) { create(:variant, tax_category: tax_category) }
-
-    it 'should equal line items final amount with tax' do
-      expect(shipment.item_cost).to eql(11.0)
-    end
-  end
-
-  it "#discounted_cost" do
-    shipment = create(:shipment)
-    shipment.cost = 10
-    shipment.promo_total = -1
-    expect(Spree::Deprecation.silence { shipment.discounted_cost }).to eq(9)
-  end
-
-  describe '#total_before_tax' do
-    before do
-      shipment.update_attributes!(cost: 10)
-    end
-    let!(:admin_adjustment) { create(:adjustment, adjustable: shipment, order: shipment.order, amount: -1, source: nil) }
-    let!(:promo_adjustment) { create(:adjustment, adjustable: shipment, order: shipment.order, amount: -2, source: promo_action) }
-    let!(:ineligible_promo_adjustment) { create(:adjustment, eligible: false, adjustable: shipment, order: shipment.order, amount: -4, source: promo_action) }
-    let(:promo_action) { promo.actions[0] }
-    let(:promo) { create(:promotion, :with_line_item_adjustment) }
-
-    it 'returns the amount minus any adjustments' do
-      expect(shipment.total_before_tax).to eq(10 - 1 - 2)
-    end
-  end
-
-  it "#tax_total with included taxes" do
-    shipment = Spree::Shipment.new
-    expect(shipment.tax_total).to eq(0)
-    shipment.included_tax_total = 10
-    expect(shipment.tax_total).to eq(10)
-  end
-
-  it "#tax_total with additional taxes" do
-    shipment = Spree::Shipment.new
-    expect(shipment.tax_total).to eq(0)
-    shipment.additional_tax_total = 10
-    expect(shipment.tax_total).to eq(10)
-  end
-
-  it "#total" do
-    shipment = Spree::Shipment.new
-    shipment.cost = 10
-    shipment.adjustment_total = -2
-    shipment.included_tax_total = 1
-    expect(shipment.total).to eq(8)
-  end
-
-  context "manifest" do
-    let(:order) { create(:order) }
-    let(:variant) { create(:variant) }
-    let!(:line_item) { order.contents.add variant }
-    let!(:shipment) { order.create_proposed_shipments.first }
-
-    it "returns variant expected" do
-      expect(shipment.manifest.first.variant).to eq variant
-    end
-
-    context "variant was removed" do
-      before { variant.discard }
-
-      it "still returns variant expected" do
-        expect(shipment.manifest.first.variant).to eq variant
-      end
-    end
-  end
-
-  context 'shipping_rates' do
-    let(:shipment) { create(:shipment) }
-    let(:shipping_method1) { create(:shipping_method) }
-    let(:shipping_method2) { create(:shipping_method) }
-    let(:shipping_rates) {
-      [
-      Spree::ShippingRate.new(shipping_method: shipping_method1, cost: 10.00, selected: true),
-      Spree::ShippingRate.new(shipping_method: shipping_method2, cost: 20.00)
-    ]
-    }
-
-    it 'returns shipping_method from selected shipping_rate' do
-      shipment.shipping_rates.delete_all
-      shipment.shipping_rates.create shipping_method: shipping_method1, cost: 10.00, selected: true
-      expect(shipment.shipping_method).to eq shipping_method1
-    end
-
-    context 'refresh_rates' do
-      let(:mock_estimator) { double('estimator', shipping_rates: shipping_rates) }
-      before { allow(shipment).to receive(:can_get_rates?){ true } }
-
-      it 'should request new rates, and maintain shipping_method selection' do
-        expect(Spree::Stock::Estimator).to receive(:new).with(no_args).and_return(mock_estimator)
-        allow(shipment).to receive_messages(shipping_method: shipping_method2)
-
-        expect(shipment.refresh_rates).to eq(shipping_rates)
-        expect(shipment.reload.selected_shipping_rate.shipping_method_id).to eq(shipping_method2.id)
-      end
-
-      it 'should handle no shipping_method selection' do
-        expect(Spree::Stock::Estimator).to receive(:new).with(no_args).and_return(mock_estimator)
-        allow(shipment).to receive_messages(shipping_method: nil)
-        expect(shipment.refresh_rates).to eq(shipping_rates)
-        expect(shipment.reload.selected_shipping_rate).not_to be_nil
-      end
-
-      it 'should not refresh if shipment is shipped' do
-        expect(Spree::Stock::Estimator).not_to receive(:new)
-        shipment.shipping_rates.delete_all
-        allow(shipment).to receive_messages(shipped?: true)
-        expect(shipment.refresh_rates).to eq([])
-      end
-
-      it "can't get rates without a shipping address" do
-        shipment.order.update_attributes!(ship_address: nil)
-        expect(shipment.refresh_rates).to eq([])
-      end
-
-      it 'uses the pluggable estimator class' do
-        expect(Spree::Config.stock).to receive(:estimator_class).and_call_original
-        shipment.refresh_rates
-      end
-
-      context 'to_package' do
-        let(:inventory_units) do
-          [build(:inventory_unit, line_item: line_item, variant: variant, state: 'on_hand'),
-           build(:inventory_unit, line_item: line_item, variant: variant, state: 'backordered')]
-        end
-
-        before do
-          allow(line_item).to receive(:order) { order }
-          shipment.inventory_units = inventory_units
-          allow(shipment.inventory_units).to receive_message_chain(:includes, :joins).and_return inventory_units
-        end
-
-        it 'should use symbols for states when adding contents to package' do
-          package = shipment.to_package
-          expect(package.on_hand.count).to eq 1
-          expect(package.backordered.count).to eq 1
-        end
-
-        it 'should set the shipment to itself' do
-          expect(shipment.to_package.shipment).to eq(shipment)
-        end
-      end
-    end
-  end
-
-  context "#update_state" do
-    shared_examples_for "immutable once shipped" do
-      before { shipment.update_columns(state: 'shipped') }
-
-      it "should remain in shipped state once shipped" do
-        expect {
-          shipment.update_state
-        }.not_to change { shipment.state }
-      end
-    end
-
-    shared_examples_for "pending if backordered" do
-      it "should have a state of pending if backordered" do
-        # Set as ready so we can test for change
-        shipment.update_attributes!(state: 'ready')
-
-        allow(shipment).to receive_messages(inventory_units: [mock_model(Spree::InventoryUnit, allow_ship?: false, canceled?: false, shipped?: false)])
-        expect(shipment).to receive(:update_columns).with(state: 'pending', updated_at: kind_of(Time))
-        shipment.update_state
-      end
-    end
-
-    context "when order cannot ship" do
-      before { allow(order).to receive_messages can_ship?: false }
-      it "should result in a 'pending' state" do
-        # Set as ready so we can test for change
-        shipment.update_attributes!(state: 'ready')
-        expect(shipment).to receive(:update_columns).with(state: 'pending', updated_at: kind_of(Time))
-        shipment.update_state
-      end
-    end
-
-    context "when order is paid" do
-      before { allow(order).to receive_messages paid?: true }
-      it "should result in a 'ready' state" do
-        expect(shipment).to receive(:update_columns).with(state: 'ready', updated_at: kind_of(Time))
-        shipment.update_state
-      end
-      it_should_behave_like 'immutable once shipped'
-      it_should_behave_like 'pending if backordered'
-    end
-
-    context "when payment is not required" do
-      before do
-        stub_spree_preferences(require_payment_to_ship: false)
-      end
-
-      it "should result in a 'ready' state" do
-        expect(shipment).to receive(:update_columns).with(state: 'ready', updated_at: kind_of(Time))
-        shipment.update_state
-      end
-      it_should_behave_like 'immutable once shipped'
-      it_should_behave_like 'pending if backordered'
-    end
-
-    context "when order has balance due" do
-      before { allow(order).to receive_messages paid?: false }
-      it "should result in a 'pending' state" do
-        shipment.state = 'ready'
-        expect(shipment).to receive(:update_columns).with(state: 'pending', updated_at: kind_of(Time))
-        shipment.update_state
-      end
-      it_should_behave_like 'immutable once shipped'
-      it_should_behave_like 'pending if backordered'
-    end
-
-    context "when order has a credit owed" do
-      before { allow(order).to receive_messages payment_state: 'credit_owed', paid?: true }
-      it "should result in a 'ready' state" do
-        shipment.state = 'pending'
-        expect(shipment).to receive(:update_columns).with(state: 'ready', updated_at: kind_of(Time))
-        shipment.update_state
-      end
-      it_should_behave_like 'immutable once shipped'
-      it_should_behave_like 'pending if backordered'
-    end
-
-    context "when shipment state changes to shipped" do
-      it "should call after_ship" do
-        shipment.state = 'pending'
-        expect(shipment).to receive :after_ship
-        allow(shipment).to receive_messages determine_state: 'shipped'
-        expect(shipment).to receive(:update_columns).with(state: 'shipped', updated_at: kind_of(Time))
-        shipment.update_state
-      end
-
-      # Regression test for https://github.com/spree/spree/issues/4347
-      context "with adjustments" do
-        before do
-          shipment.adjustments << Spree::Adjustment.create(order: order, label: "Label", amount: 5)
-        end
-
-        it "transitions to shipped" do
-          shipment.update_column(:state, "ready")
-          shipment.ship!
-        end
-      end
-    end
-  end
-
-  context "when order is completed" do
-    before do
-      allow(order).to receive_messages completed?: true
-      allow(order).to receive_messages canceled?: false
-    end
-
-    context "with inventory tracking" do
-      before { stub_spree_preferences(track_inventory_levels: true) }
-
-      it "should validate with inventory" do
-        shipment.inventory_units = [create(:inventory_unit)]
-        expect(shipment.valid?).to be true
-      end
-    end
-
-    context "without inventory tracking" do
-      before { stub_spree_preferences(track_inventory_levels: false) }
-
-      it "should validate with no inventory" do
-        expect(shipment.valid?).to be true
-      end
-    end
-  end
-
-  context "#cancel" do
-    it 'cancels the shipment' do
-      allow(shipment.order).to receive(:update!)
-
-      shipment.state = 'pending'
-      without_partial_double_verification do
-        expect(shipment).to receive(:after_cancel)
-      end
-      shipment.cancel!
-      expect(shipment.state).to eq 'canceled'
-    end
-
-    it 'restocks the items' do
-      variant = shipment.inventory_units.first.variant
-      shipment.stock_location = mock_model(Spree::StockLocation)
-      expect(shipment.stock_location).to receive(:restock).with(variant, 1, shipment)
-      shipment.after_cancel
-    end
-
-    context "with backordered inventory units" do
-      let(:order) { create(:order) }
-      let(:variant) { create(:variant) }
-      let(:other_order) { create(:order) }
-
-      before do
-        order.contents.add variant
-        order.create_proposed_shipments
-
-        other_order.contents.add variant
-        other_order.create_proposed_shipments
-      end
-
-      it "doesn't fill backorders when restocking inventory units" do
-        shipment = order.shipments.first
-        expect(shipment.inventory_units.count).to eq 1
-        expect(shipment.inventory_units.first).to be_backordered
-
-        other_shipment = other_order.shipments.first
-        expect(other_shipment.inventory_units.count).to eq 1
-        expect(other_shipment.inventory_units.first).to be_backordered
-
-        expect {
-          shipment.cancel!
-        }.not_to change { other_shipment.inventory_units.first.state }
-      end
-    end
-  end
-
-  context "#resume" do
-    let(:inventory_unit) { create(:inventory_unit) }
-
-    before { shipment.state = 'canceled' }
-
-    context "when order cannot ship" do
-      before { allow(order).to receive_messages(can_ship?: false) }
-      it "should result in a 'pending' state" do
-        shipment.resume!
-        expect(shipment.state).to eq 'pending'
-      end
-    end
-
-    context "when order is not paid" do
-      before { allow(order).to receive_messages(paid?: false) }
-      it "should result in a 'ready' state" do
-        shipment.resume!
-        expect(shipment.state).to eq 'pending'
-      end
-    end
-
-    context "when any inventory is backordered" do
-      before { allow_any_instance_of(Spree::InventoryUnit).to receive(:allow_ship?).and_return(false) }
-      it "should result in a 'ready' state" do
-        shipment.resume!
-        expect(shipment.state).to eq 'pending'
-      end
-    end
-
-    context "when the order is paid, shippable, and not backordered" do
-      before do
-        allow(order).to receive_messages(can_ship?: true)
-        allow(order).to receive_messages(paid?: true)
-        allow_any_instance_of(Spree::InventoryUnit).to receive(:allow_ship?).and_return(true)
-      end
-
-      it "should result in a 'ready' state" do
-        shipment.resume!
-        expect(shipment.state).to eq 'ready'
-      end
-    end
-
-    it 'unstocks them items' do
-      variant = shipment.inventory_units.first.variant
-      shipment.stock_location = mock_model(Spree::StockLocation)
-      expect(shipment.stock_location).to receive(:unstock).with(variant, 1, shipment)
-      shipment.after_resume
-    end
-  end
-
-  context "#ship" do
-    context "when the shipment is canceled" do
-      let(:address){ create(:address) }
-      let(:order){ create(:order_with_line_items, ship_address: address) }
-      let(:shipment_with_inventory_units) { create(:shipment, order: order, state: 'canceled') }
-      let(:subject) { shipment_with_inventory_units.ship! }
-      before do
-        allow(order).to receive(:update!)
-      end
-
-      it 'unstocks them items' do
-        expect(shipment_with_inventory_units.stock_location).to receive(:unstock).with(an_instance_of(Spree::Variant), 1, shipment_with_inventory_units)
-        subject
-      end
-    end
-
-    ['ready', 'canceled'].each do |state|
-      context "from #{state}" do
-        before do
-          allow(order).to receive(:update!)
-          allow(shipment).to receive_messages(state: state)
-        end
-
-        it "finalizes adjustments" do
-          shipment.adjustments.each do |adjustment|
-            expect(adjustment).to receive(:finalize!)
-          end
-          shipment.ship!
-        end
-      end
-    end
-  end
-
-  context "#ready" do
-    # Regression test for https://github.com/spree/spree/issues/2040
-    it "cannot ready a shipment for an order if the order is unpaid" do
-      expect(order).to receive_messages(paid?: false)
-      expect(shipment).not_to be_can_ready
-    end
-  end
-
-  context "updates cost when selected shipping rate is present" do
-    let(:shipment) { create(:shipment) }
-    before { shipment.selected_shipping_rate.update!(cost: 5) }
-
-    it "updates shipment totals" do
-      expect {
-        shipment.update_amounts
-      }.to change { shipment.cost }.to(5)
-    end
-  end
-
-  context "changes shipping rate via general update" do
-    let!(:ship_address) { create(:address) }
-    let!(:tax_zone) { create(:global_zone) } # will include the above address
-    let!(:tax_rate) { create(:tax_rate, amount: 0.10, zone: tax_zone, tax_categories: [tax_category]) }
-    let(:tax_category) { create(:tax_category) }
-
-    let(:order) do
-      create(
-        :order_ready_to_ship,
-        ship_address: ship_address,
-        shipment_cost: 10,
-        shipping_method: ten_dollar_shipping_method,
-        line_items_count: 1,
-        line_items_price: 100,
-      )
-    end
-
-    let(:ten_dollar_shipping_method)    { create(:shipping_method, tax_category: tax_category, zones: [tax_zone], cost: 10) }
-    let(:twenty_dollar_shipping_method) { create(:shipping_method, tax_category: tax_category, zones: [tax_zone], cost: 20) }
-
-    let(:shipment) { order.shipments[0] }
-
-    let(:twenty_dollar_shipping_rate) do
-      create(:shipping_rate, cost: 20, shipment: shipment, shipping_method: twenty_dollar_shipping_method)
-    end
-
-    it "updates everything around order shipment total and state" do
-      expect(shipment.state).to eq 'ready'
-      expect(shipment.cost).to eq 10
-      expect(shipment.additional_tax_total).to eq 1
-
-      expect(order.shipment_total).to eq 10
-      expect(order.total).to eq 121 # shipment: 10 + 1 (tax) + line item: 100 + 10 (tax)
-      expect(order.payment_state).to eq 'paid'
-
-      shipment.update_attributes_and_order selected_shipping_rate_id: twenty_dollar_shipping_rate.id
-
-      expect(shipment.state).to eq 'pending'
-      expect(shipment.cost).to eq 20
-      expect(shipment.additional_tax_total).to eq 2
-
-      expect(order.shipment_total).to eq 20
-      expect(order.total).to eq 132 # shipment: 20 + 2 (tax) + line item: 100 + 10 (tax)
-      expect(order.payment_state).to eq 'balance_due'
-    end
-  end
-
-  context "currency" do
-    it "returns the order currency" do
-      expect(shipment.currency).to eq(order.currency)
-    end
-  end
-
-  context "nil costs" do
-    it "sets cost to 0" do
-      shipment = Spree::Shipment.new
-      shipment.valid?
-      expect(shipment.cost).to eq 0
-    end
-  end
-
-  context "#tracking_url" do
-    subject { shipment.tracking_url }
-
-    context "when tracking has not yet been set" do
-      it { is_expected.to be nil }
-    end
-
-    context "when tracking has been set, but a shipping method is not present" do
-      before do
-        shipment.tracking = "12345"
-        shipment.shipping_rates.clear
-      end
-
-      it { is_expected.to be nil }
-    end
-
-    context "when tracking has been set and a shipping method exists" do
-      before do
-        shipment.tracking = "12345"
-        shipment.shipping_method.update(tracking_url: "https://example.com/:tracking")
-      end
-
-      it "builds the tracking url with the shipping method" do
-        expect(subject).to eql("https://example.com/12345")
-      end
-    end
-  end
-
-  context "set up new inventory units" do
-    # let(:line_item) { double(
-    let(:variant) { double("Variant", id: 9) }
-
-    let(:inventory_units) { double }
-
-    let(:params) do
-      { variant_id: variant.id, state: 'on_hand', line_item_id: line_item.id }
-    end
-
-    before { allow(shipment).to receive_messages inventory_units: inventory_units }
-
-    it "associates variant and order" do
-      expect(inventory_units).to receive(:create).with(params)
-      shipment.set_up_inventory('on_hand', variant, order, line_item)
-    end
-  end
-
-  # Regression test for https://github.com/spree/spree/issues/3349
-  context "#destroy" do
-    let(:shipping_rate) do
-      Spree::ShippingRate.create!(
-        shipping_method: shipping_method,
-        selected: true,
-        taxes: [Spree::ShippingRateTax.new(amount: 20)]
-      )
-    end
-    it "destroys linked shipping_rates and shipping_rate_taxes" do
-      shipping_rate = shipment.shipping_rates.first
-      shipping_rate_tax = shipping_rate.taxes.first
-
-      shipment.destroy
-
-      expect{ shipping_rate.reload }.to raise_error(ActiveRecord::RecordNotFound)
-      expect{ shipping_rate_tax.reload }.to raise_error(ActiveRecord::RecordNotFound)
-    end
-  end
-
-  # Regression test for https://github.com/spree/spree/issues/4072 (kinda)
-  # The need for this was discovered in the research for https://github.com/spree/spree/issues/4702
-  context "state changes" do
-    before do
-      # Must be stubbed so transition can succeed
-      allow(order).to receive_messages paid?: true
-    end
-
-    it "are logged to the database" do
-      expect(shipment.state_changes).to be_empty
-      expect(shipment.ready!).to be true
-      expect(shipment.state_changes.count).to eq(1)
-      state_change = shipment.state_changes.first
-      expect(state_change.previous_state).to eq('pending')
-      expect(state_change.next_state).to eq('ready')
-    end
-  end
-
-  context "don't require shipment" do
-    let(:stock_location) { create(:stock_location, fulfillable: false) }
-    let(:unshippable_shipment) do
-      create(
-        :shipment,
-        stock_location: stock_location,
-        inventory_units: [build(:inventory_unit)]
-      )
-    end
-
-    before { allow(order).to receive_messages paid?: true }
-
-    it 'proceeds automatically to shipped state' do
-      unshippable_shipment.ready!
-      expect(unshippable_shipment.state).to eq('shipped')
-    end
-
-    it 'does not send a confirmation email' do
-      expect {
-        unshippable_shipment.ready!
-        unshippable_shipment.inventory_units.reload.each do |unit|
-          expect(unit.state).to eq('shipped')
-        end
-      }.not_to change{ ActionMailer::Base.deliveries.count }
-    end
-  end
-
-  context "destroy prevention" do
-    it "can be destroyed when pending" do
-      shipment = create(:shipment, state: "pending")
-      expect(shipment.destroy).to be_truthy
-      expect { shipment.reload }.to raise_error(ActiveRecord::RecordNotFound)
-    end
-
-    it "can be destroyed when ready" do
-      shipment = create(:shipment, state: "ready")
-      expect(shipment.destroy).to be_truthy
-      expect { shipment.reload }.to raise_error(ActiveRecord::RecordNotFound)
-    end
-
-    it "cannot be destroyed when shipped" do
-      shipment = create(:shipment, state: "shipped")
-      expect(shipment.destroy).to eq false
-      expect(shipment.errors.full_messages.join).to match /Cannot destroy/
-      expect { shipment.reload }.not_to raise_error
-    end
-
-    it "cannot be destroyed when canceled" do
-      shipment = create(:shipment, state: "canceled")
-      expect(shipment.destroy).to eq false
-      expect(shipment.errors.full_messages.join).to match /Cannot destroy/
-      expect { shipment.reload }.not_to raise_error
-    end
-  end
-
-  describe "#finalize!" do
-    let(:inventory_unit) { shipment.inventory_units.first }
-    let(:stock_item) { inventory_unit.variant.stock_items.find_by(stock_location: stock_location) }
-    let(:inventory_unit_finalizer) { double(:inventory_unit_finalizer, run!: [true]) }
-
-    before do
-      allow(Spree::Stock::InventoryUnitsFinalizer)
-        .to receive(:new).and_return(inventory_unit_finalizer)
-
-      stock_item.set_count_on_hand(10)
-      stock_item.update_attributes!(backorderable: false)
-      inventory_unit.update_attributes!(pending: true)
-    end
-
-    subject { shipment.finalize! }
-
-    it "call run! on Spree::Stock::InventoryUnitsFinalizer" do
-      expect(inventory_unit_finalizer).to receive(:run!)
-
-      subject
-    end
-
-    context "inventory unit already finalized" do
-      let(:inventory_unit) { build(:inventory_unit, pending: false) }
-
-      it "doesn't pass the inventory unit" do
-        expect(Spree::Stock::InventoryUnitsFinalizer)
-          .to receive(:new).with([])
-
-        subject
-      end
-
-      it "doesn't update the associated inventory units" do
-        expect { subject }.to_not change { inventory_unit.reload.updated_at }
-      end
-
-      it "doesn't unstock the variant" do
-        expect { subject }.to_not change { stock_item.reload.count_on_hand }
-      end
-    end
-  end
-
-  describe ".by_store" do
-    it "returns shipments by store" do
-      olivanders_store = create(:store, name: 'Olivanders')
-      wizard_shipment = create(:shipment, order: create(:order, store: olivanders_store))
-      create(:shipment, order: build(:order, store: create(:store, name: 'Target')))
-
-      shipments = Spree::Shipment.by_store(olivanders_store)
-
-      expect(Spree::Shipment.count).to eq(2)
-      expect(shipments.count).to eq(1)
-      expect(shipments.first).to eq(wizard_shipment)
-    end
-  end
-
-  describe '#selected_shipping_rate_id=' do
-    let!(:air_shipping_method) { create(:shipping_method, name: "Air") }
-    let(:new_rate) { shipment.shipping_rates.create!(shipping_method: air_shipping_method) }
-
-    context 'selecting the same id' do
-      it 'keeps the same shipping rate selected' do
-        expect {
-          shipment.selected_shipping_rate_id = shipping_rate.id
-        }.not_to change { shipping_rate.selected }.from(true)
-      end
-    end
-
-    context 'when the id exists' do
-      it 'sets the new shipping rate as selected' do
-        expect {
-          shipment.selected_shipping_rate_id = new_rate.id
-        }.to change { new_rate.selected }.from(false).to(true)
-      end
-
-      it 'sets the old shipping rate as not selected' do
-        expect {
-          shipment.selected_shipping_rate_id = new_rate.id
-        }.to change { shipping_rate.selected }.from(true).to(false)
-      end
-    end
-
-    context 'when the id does not exist' do
-      it 'raises a RecordNotFound error' do
-        expect {
-          shipment.selected_shipping_rate_id = -1
-        }.to raise_error(ArgumentError)
-
-        # Should not change selection
-        expect(shipping_rate.reload).to be_selected
-      end
-    end
-  end
-
-  describe "#shipping_method" do
-    let(:shipment) { create(:shipment) }
-
-    subject { shipment.shipping_method }
-
-    context "when no shipping rate is selected" do
-      before do
-        shipment.shipping_rates.update_all(selected: false)
-        shipment.reload
-      end
-
-      it { is_expected.to be_nil }
-    end
-
-    context "when a shipping rate is selected" do
-      it "is expected to be the shipping rate's shipping method" do
-        expect(shipment.shipping_method).to eq(shipment.selected_shipping_rate.shipping_method)
-      end
-    end
-  end
-
-  describe '#can_transition_from_pending_to_ready?' do
-    let(:shipment) { create(:shipment, order: order) }
-
-    subject { shipment.can_transition_from_pending_to_ready? }
-
-    context "with backordered inventory" do
-      before { shipment.inventory_units.update_all(state: "backordered") }
-
-      it "returns false" do
-        expect(subject).to be false
-      end
-    end
-
-    context "with on_hand inventory" do
-      before { shipment.inventory_units.update_all(state: "on_hand") }
-
-      it "returns true" do
-        expect(subject).to be true
-      end
-    end
-
-    context "with shipped inventory" do
-      before { shipment.inventory_units.update_all(state: "shipped") }
-
-      it "returns true" do
-        expect(subject).to be true
-      end
-    end
-  end
-
-  describe '#cartons' do
-    let(:carton)   { create(:carton) }
-    let(:shipment) { carton.shipments.first }
-
-    subject { shipment.cartons }
-
-    it { is_expected.to include carton }
-  end
-end