solidus_core 2.8.6 → 2.9.0.rc.1

data/spec/models/spree/order_updater_spec.rb

@@ -117,7 +117,7 @@ module Spree
               end
             end
 
-            Spree::Config.promotion_chooser_class = Spree::TestPromotionChooser
+            stub_spree_preferences(promotion_chooser_class: Spree::TestPromotionChooser)
           end
 
           it 'uses the defined promotion chooser' do
@@ -322,7 +322,7 @@ module Spree
 
           before do
             order # generate this first so we can expect it
-            Spree::Config.tax_calculator_class = custom_calculator_class
+            stub_spree_preferences(tax_calculator_class: custom_calculator_class)
           end
 
           it 'uses the configured class' do

data/spec/models/spree/payment_spec.rb

@@ -1255,4 +1255,16 @@ RSpec.describe Spree::Payment, type: :model do
       end
     end
   end
+
+  describe '::valid scope' do
+    before do
+      create :payment, state: :void
+      create :payment, state: :failed
+      create :payment, state: :invalid
+    end
+
+    it 'does not include void, failed and invalid payments' do
+      expect(described_class.valid).to be_empty
+    end
+  end
 end

data/spec/models/spree/product_spec.rb

@@ -153,7 +153,7 @@ RSpec.describe Spree::Product, type: :model do
         before do
           product.master.default_price.currency = 'JPY'
           product.master.default_price.save!
-          Spree::Config[:currency] = 'JPY'
+          stub_spree_preferences(currency: 'JPY')
         end
 
         it "displays the currency in yen" do
@@ -514,12 +514,12 @@ RSpec.describe Spree::Product, type: :model do
 
   context '#total_on_hand' do
     it 'should be infinite if track_inventory_levels is false' do
-      Spree::Config[:track_inventory_levels] = false
+      stub_spree_preferences(track_inventory_levels: false)
       expect(build(:product, variants_including_master: [build(:master_variant)]).total_on_hand).to eql(Float::INFINITY)
     end
 
     it 'should be infinite if variant is on demand' do
-      Spree::Config[:track_inventory_levels] = true
+      stub_spree_preferences(track_inventory_levels: true)
       expect(build(:product, variants_including_master: [build(:on_demand_master_variant)]).total_on_hand).to eql(Float::INFINITY)
     end
 

data/spec/models/spree/promotion/rules/first_order_spec.rb

@@ -8,11 +8,11 @@ RSpec.describe Spree::Promotion::Rules::FirstOrder, type: :model do
   let(:user) { mock_model(Spree::LegacyUser) }
 
   context "without a user or email" do
-    it { expect(rule).not_to be_eligible(order) }
-    it "sets an error message" do
+    it { expect(rule).to be_eligible(order) }
+    it "does not set an error message" do
       rule.eligible?(order)
       expect(rule.eligibility_errors.full_messages.first).
-        to eq "You need to login or provide your email before applying this coupon code."
+        to be_nil
     end
   end
 
@@ -51,6 +51,11 @@ RSpec.describe Spree::Promotion::Rules::FirstOrder, type: :model do
             expect(rule.eligibility_errors.full_messages.first).
               to eq "This coupon code can only be applied to your first order."
           end
+          it "sets an error code" do
+            rule.eligible?(order)
+            expect(rule.eligibility_errors.details[:base].first[:error_code]).
+              to eq :not_first_order
+          end
         end
       end
     end
@@ -71,6 +76,11 @@ RSpec.describe Spree::Promotion::Rules::FirstOrder, type: :model do
           expect(rule.eligibility_errors.full_messages.first).
             to eq "This coupon code can only be applied to your first order."
         end
+        it "sets an error code" do
+          rule.eligible?(order)
+          expect(rule.eligibility_errors.details[:base].first[:error_code]).
+            to eq :not_first_order
+        end
       end
     end
   end

data/spec/models/spree/promotion/rules/item_total_spec.rb

@@ -44,6 +44,11 @@ RSpec.describe Spree::Promotion::Rules::ItemTotal, type: :model do
         expect(rule.eligibility_errors.full_messages.first).
           to eq "This coupon code can't be applied to orders less than or equal to $50.00."
       end
+      it "sets an error code" do
+        rule.eligible?(order)
+        expect(rule.eligibility_errors.details[:base].first[:error_code]).
+          to eq :item_total_less_than_or_equal
+      end
     end
 
     context "when item total is lower than preferred amount" do
@@ -58,6 +63,11 @@ RSpec.describe Spree::Promotion::Rules::ItemTotal, type: :model do
         expect(rule.eligibility_errors.full_messages.first).
           to eq "This coupon code can't be applied to orders less than or equal to $50.00."
       end
+      it "sets an error code" do
+        rule.eligible?(order)
+        expect(rule.eligibility_errors.details[:base].first[:error_code]).
+          to eq :item_total_less_than_or_equal
+      end
     end
   end
 
@@ -108,6 +118,11 @@ RSpec.describe Spree::Promotion::Rules::ItemTotal, type: :model do
         expect(rule.eligibility_errors.full_messages.first).
           to eq "This coupon code can't be applied to orders less than $50.00."
       end
+      it "sets an error code" do
+        rule.eligible?(order)
+        expect(rule.eligibility_errors.details[:base].first[:error_code]).
+          to eq :item_total_less_than
+      end
     end
   end
 end

data/spec/models/spree/promotion/rules/one_use_per_user_spec.rb

@@ -24,6 +24,11 @@ RSpec.describe Spree::Promotion::Rules::OneUsePerUser, type: :model do
           expect(rule.eligibility_errors.full_messages.first).
             to eq "This coupon code can only be used once per user."
         end
+        it "sets an error code" do
+          rule.eligible?(order)
+          expect(rule.eligibility_errors.details[:base].first[:error_code]).
+            to eq :limit_once_per_user
+        end
       end
 
       context 'when the user has not used this promotion before' do
@@ -39,6 +44,11 @@ RSpec.describe Spree::Promotion::Rules::OneUsePerUser, type: :model do
         expect(rule.eligibility_errors.full_messages.first).
           to eq "You need to login before applying this coupon code."
       end
+      it "sets an error code" do
+        rule.eligible?(order)
+        expect(rule.eligibility_errors.details[:base].first[:error_code]).
+          to eq :no_user_specified
+      end
     end
   end
 end

data/spec/models/spree/promotion/rules/product_spec.rb

@@ -38,6 +38,11 @@ RSpec.describe Spree::Promotion::Rules::Product, type: :model do
           expect(rule.eligibility_errors.full_messages.first).
             to eq "You need to add an applicable product before applying this coupon code."
         end
+        it "sets an error code" do
+          rule.eligible?(order)
+          expect(rule.eligibility_errors.details[:base].first[:error_code]).
+            to eq :no_applicable_products
+        end
       end
     end
 
@@ -61,6 +66,11 @@ RSpec.describe Spree::Promotion::Rules::Product, type: :model do
           expect(rule.eligibility_errors.full_messages.first).
             to eq "This coupon code can't be applied because you don't have all of the necessary products in your cart."
         end
+        it "sets an error code" do
+          rule.eligible?(order)
+          expect(rule.eligibility_errors.details[:base].first[:error_code]).
+            to eq :missing_product
+        end
       end
     end
 
@@ -84,6 +94,11 @@ RSpec.describe Spree::Promotion::Rules::Product, type: :model do
           expect(rule.eligibility_errors.full_messages.first).
             to eq "Your cart contains a product that prevents this coupon code from being applied."
         end
+        it "sets an error code" do
+          rule.eligible?(order)
+          expect(rule.eligibility_errors.details[:base].first[:error_code]).
+            to eq :has_excluded_product
+        end
       end
     end
 

data/spec/models/spree/promotion/rules/taxon_spec.rb

@@ -48,6 +48,11 @@ RSpec.describe Spree::Promotion::Rules::Taxon, type: :model do
           expect(rule.eligibility_errors.full_messages.first).
             to eq "You need to add a product from an applicable category before applying this coupon code."
         end
+        it "sets an error code" do
+          rule.eligible?(order)
+          expect(rule.eligibility_errors.details[:base].first[:error_code]).
+            to eq :no_matching_taxons
+        end
       end
 
       context 'when a product has a taxon child of a taxon rule' do
@@ -83,6 +88,11 @@ RSpec.describe Spree::Promotion::Rules::Taxon, type: :model do
           expect(rule.eligibility_errors.full_messages.first).
             to eq "You need to add a product from all applicable categories before applying this coupon code."
         end
+        it "sets an error code" do
+          rule.eligible?(order)
+          expect(rule.eligibility_errors.details[:base].first[:error_code]).
+            to eq :missing_taxon
+        end
       end
 
       context 'when a product has a taxon child of a taxon rule' do
@@ -91,7 +101,6 @@ RSpec.describe Spree::Promotion::Rules::Taxon, type: :model do
         before do
           taxon.children << taxon2
           taxon.save!
-          taxon.reload
           product.taxons = [taxon2, taxon3]
           rule.taxons = [taxon, taxon3]
         end
@@ -123,6 +132,11 @@ RSpec.describe Spree::Promotion::Rules::Taxon, type: :model do
           expect(rule.eligibility_errors.full_messages.first).
             to eq "Your cart contains a product from an excluded category that prevents this coupon code from being applied."
         end
+        it "sets an error code" do
+          rule.eligible?(order)
+          expect(rule.eligibility_errors.details[:base].first[:error_code]).
+            to eq :has_excluded_taxon
+        end
       end
     end
 
@@ -152,14 +166,14 @@ RSpec.describe Spree::Promotion::Rules::Taxon, type: :model do
     let(:order) { create :order_with_line_items }
     let(:taxon) { create :taxon, name: 'first' }
 
-    before do
-      rule.preferred_match_policy = 'invalid'
-      rule.save!(validate: false)
-      line_item.product.taxons << taxon
-      rule.taxons << taxon
-    end
-
     context 'with an invalid match policy' do
+      before do
+        rule.preferred_match_policy = 'invalid'
+        rule.save!(validate: false)
+        line_item.product.taxons << taxon
+        rule.taxons << taxon
+      end
+
       it 'logs a warning and uses "any" policy' do
         expect(Spree::Deprecation).to(
           receive(:warn).
@@ -171,5 +185,42 @@ RSpec.describe Spree::Promotion::Rules::Taxon, type: :model do
         ).to be_truthy
       end
     end
+
+    context 'when a product has a taxon of a taxon rule' do
+      before do
+        product.taxons << taxon
+        rule.taxons << taxon
+        rule.save!
+      end
+
+      it 'is actionable' do
+        expect(rule).to be_actionable(line_item)
+      end
+    end
+
+    context 'when a product has a taxon child of a taxon rule' do
+      before do
+        taxon.children << taxon2
+        product.taxons << taxon2
+        rule.taxons << taxon
+        rule.save!
+      end
+
+      it 'is actionable' do
+        expect(rule).to be_actionable(line_item)
+      end
+    end
+
+    context 'when a product does not have taxon or child taxon of a taxon rule' do
+      before do
+        product.taxons << taxon2
+        rule.taxons << taxon
+        rule.save!
+      end
+
+      it 'is not actionable' do
+        expect(rule).not_to be_actionable(line_item)
+      end
+    end
   end
 end

data/spec/models/spree/promotion/rules/user_logged_in_spec.rb

@@ -23,6 +23,11 @@ RSpec.describe Spree::Promotion::Rules::UserLoggedIn, type: :model do
         expect(rule.eligibility_errors.full_messages.first).
           to eq "You need to login before applying this coupon code."
       end
+      it "sets an error code" do
+        rule.eligible?(order)
+        expect(rule.eligibility_errors.details[:base].first[:error_code]).
+          to eq :no_user_specified
+      end
     end
   end
 end

data/spec/models/spree/promotion_handler/shipping_spec.rb

@@ -76,7 +76,7 @@ module Spree
         before do
           stub_const('CustomShippingAction', custom_klass)
 
-          Spree::Config.environment.promotions.shipping_actions = ['CustomShippingAction']
+          allow(Spree::Config.environment.promotions).to receive(:shipping_actions) { ['CustomShippingAction'] }
 
           order.order_promotions.create!(promotion: promotion, promotion_code: promotion.codes.first)
         end

data/spec/models/spree/promotion_spec.rb

@@ -384,6 +384,86 @@ RSpec.describe Spree::Promotion, type: :model do
     end
   end
 
+  describe '#not_started?' do
+    let(:promotion) { Spree::Promotion.new(starts_at: starts_at) }
+    subject { promotion.not_started? }
+
+    context 'no starts_at date' do
+      let(:starts_at) { nil }
+      it { is_expected.to be_falsey }
+    end
+
+    context 'when starts_at date is in the past' do
+      let(:starts_at) { Time.current - 1.day }
+      it { is_expected.to be_falsey }
+    end
+
+    context 'when starts_at date is not already reached' do
+      let(:starts_at) { Time.current + 1.day }
+      it { is_expected.to be_truthy }
+    end
+  end
+
+  describe '#started?' do
+    let(:promotion) { Spree::Promotion.new(starts_at: starts_at) }
+    subject { promotion.started? }
+
+    context 'when no starts_at date' do
+      let(:starts_at) { nil }
+      it { is_expected.to be_truthy }
+    end
+
+    context 'when starts_at date is in the past' do
+      let(:starts_at) { Time.current - 1.day }
+      it { is_expected.to be_truthy }
+    end
+
+    context 'when starts_at date is not already reached' do
+      let(:starts_at) { Time.current + 1.day }
+      it { is_expected.to be_falsey }
+    end
+  end
+
+  describe '#expired?' do
+    let(:promotion) { Spree::Promotion.new(expires_at: expires_at) }
+    subject { promotion.expired? }
+
+    context 'when no expires_at date' do
+      let(:expires_at) { nil }
+      it { is_expected.to be_falsey }
+    end
+
+    context 'when expires_at date is not already reached' do
+      let(:expires_at) { Time.current + 1.days }
+      it { is_expected.to be_falsey }
+    end
+
+    context 'when expires_at date is in the past' do
+      let(:expires_at) { Time.current - 1.days }
+      it { is_expected.to be_truthy }
+    end
+  end
+
+  describe '#not_expired?' do
+    let(:promotion) { Spree::Promotion.new(expires_at: expires_at) }
+    subject { promotion.not_expired? }
+
+    context 'when no expired_at date' do
+      let(:expires_at) { nil }
+      it { is_expected.to be_truthy }
+    end
+
+    context 'when expires_at date is not already reached' do
+      let(:expires_at) { Time.current + 1.days }
+      it { is_expected.to be_truthy }
+    end
+
+    context 'when expires_at date is in the past' do
+      let(:expires_at) { Time.current - 1.days }
+      it { is_expected.to be_falsey }
+    end
+  end
+
   context "#active" do
     it "should be active" do
       expect(promotion.active?).to eq(true)

data/spec/models/spree/reimbursement_spec.rb

@@ -154,7 +154,8 @@ RSpec.describe Spree::Reimbursement, type: :model do
     context 'when reimbursement cannot be fully performed' do
       let!(:non_return_refund) { create(:refund, amount: 1, payment: payment) }
 
-      it 'raises IncompleteReimbursement error' do
+      it 'does not send a reimbursement email and raises IncompleteReimbursement error' do
+        expect(Spree::ReimbursementMailer).not_to receive(:reimbursement_email)
         expect { subject }.to raise_error(Spree::Reimbursement::IncompleteReimbursementError)
       end
     end
@@ -168,7 +169,7 @@ RSpec.describe Spree::Reimbursement, type: :model do
       end
     end
 
-    it "triggers the reimbursement mailer to be sent" do
+    it "triggers the reimbursement mailer to be sent via subscribed event" do
       expect(Spree::ReimbursementMailer).to receive(:reimbursement_email).with(reimbursement.id) { double(deliver_later: true) }
       subject
     end

data/spec/models/spree/return_item_spec.rb

@@ -43,6 +43,15 @@ RSpec.describe Spree::ReturnItem, type: :model do
       subject
     end
 
+    context 'when the `skip_customer_return_processing` flag is not set to true' do
+      before { return_item.skip_customer_return_processing = false }
+
+      it 'shows a deprecation warning' do
+        expect(Spree::Deprecation).to receive(:warn)
+        subject
+      end
+    end
+
     context 'when there is a received return item with the same inventory unit' do
       let!(:return_item_with_dupe_inventory_unit) { create(:return_item, inventory_unit: inventory_unit, reception_status: 'received') }
 

data/spec/models/spree/shipment_spec.rb

@@ -328,7 +328,7 @@ RSpec.describe Spree::Shipment, type: :model do
 
     context "when payment is not required" do
       before do
-        Spree::Config[:require_payment_to_ship] = false
+        stub_spree_preferences(require_payment_to_ship: false)
       end
 
       it "should result in a 'ready' state" do
@@ -391,7 +391,7 @@ RSpec.describe Spree::Shipment, type: :model do
     end
 
     context "with inventory tracking" do
-      before { Spree::Config.set track_inventory_levels: true }
+      before { stub_spree_preferences(track_inventory_levels: true) }
 
       it "should validate with inventory" do
         shipment.inventory_units = [create(:inventory_unit)]
@@ -400,7 +400,7 @@ RSpec.describe Spree::Shipment, type: :model do
     end
 
     context "without inventory tracking" do
-      before { Spree::Config.set track_inventory_levels: false }
+      before { stub_spree_preferences(track_inventory_levels: false) }
 
       it "should validate with no inventory" do
         expect(shipment.valid?).to be true