solidus_core 2.4.2 → 2.5.0.beta1

data/spec/models/spree/permission_sets/restricted_stock_transfer_display_spec.rb

@@ -1,49 +0,0 @@
-require 'rails_helper'
-
-RSpec.describe Spree::PermissionSets::RestrictedStockTransferDisplay do
-  let(:ability) { Spree::Ability.new(user) }
-  let(:user) { create :user }
-
-  subject { ability }
-
-  let!(:sl1) { create :stock_location, active: false }
-  let!(:sl2) { create :stock_location, active: false }
-
-  let!(:source_transfer) { create :stock_transfer, source_location: sl1 }
-  let!(:other_source_transfer) { create :stock_transfer, source_location: sl2 }
-  let!(:dest_transfer) { create :stock_transfer, source_location: sl2, destination_location: sl1 }
-
-  before do
-    user.stock_locations << sl1
-  end
-
-  context "when activated" do
-    before do
-      described_class.new(ability).activate!
-    end
-
-    it { is_expected.to be_able_to(:display, sl1) }
-    it { is_expected.to_not be_able_to(:display, sl2) }
-
-    it { is_expected.to be_able_to(:display, source_transfer) }
-    it { is_expected.to_not be_able_to(:display, other_source_transfer) }
-    it { is_expected.to be_able_to(:display, dest_transfer) }
-
-    it { is_expected.to be_able_to(:admin, source_transfer) }
-    it { is_expected.to_not be_able_to(:admin, other_source_transfer) }
-    it { is_expected.to be_able_to(:admin, dest_transfer) }
-  end
-
-  context "when not activated" do
-    it { is_expected.to_not be_able_to(:display, sl1) }
-    it { is_expected.to_not be_able_to(:display, sl2) }
-
-    it { is_expected.to_not be_able_to(:display, source_transfer) }
-    it { is_expected.to_not be_able_to(:display, other_source_transfer) }
-    it { is_expected.to_not be_able_to(:display, dest_transfer) }
-
-    it { is_expected.to_not be_able_to(:admin, source_transfer) }
-    it { is_expected.to_not be_able_to(:admin, other_source_transfer) }
-    it { is_expected.to_not be_able_to(:admin, dest_transfer) }
-  end
-end

data/spec/models/spree/permission_sets/restricted_stock_transfer_management_spec.rb

@@ -1,218 +0,0 @@
-require 'rails_helper'
-
-RSpec.describe Spree::PermissionSets::RestrictedStockTransferManagement do
-  let(:ability) { Spree::Ability.new(user) }
-
-  subject { ability }
-
-  # Inactive stock locations will default to not being visible
-  # for users without explicit permissions.
-  let!(:source_location) { create :stock_location, active: false }
-  let!(:destination_location) { create :stock_location, active: false }
-
-  # This has the side effect of creating a stock item for each stock location above,
-  # which is what we actually want.
-  let!(:variant) { create :variant }
-
-  let(:transfer_with_source) { create :stock_transfer, source_location: source_location }
-  let(:transfer_with_destination) { create :stock_transfer, source_location: destination_location }
-  let(:transfer_with_source_and_destination) do
-    create :stock_transfer, source_location: source_location, destination_location: destination_location
-  end
-
-  let(:transfer_amount) { 1 }
-  let(:source_transfer_item) do
-    transfer_with_source.transfer_items.create(variant: variant, expected_quantity: transfer_amount)
-  end
-  let(:destination_transfer_item) do
-    transfer_with_destination.transfer_items.create(variant: variant, expected_quantity: transfer_amount)
-  end
-  let(:source_and_destination_transfer_item) do
-    transfer_with_source_and_destination.transfer_items.create(variant: variant, expected_quantity: transfer_amount)
-  end
-
-  context "when activated" do
-    let(:user) { create :user, stock_locations: stock_locations }
-    let(:stock_locations) { [] }
-
-    before do
-      user.stock_locations = stock_locations
-      # When creating transfer_items for a stock transfer, stock items must have a count on hand
-      # with an amount that would allow a transfer item to pass validations (meaning the count on hand has to be equal
-      # to the expected_quantity for the transfer)
-      variant.stock_items.update_all count_on_hand: transfer_amount
-
-      described_class.new(ability).activate!
-    end
-
-    context "when the user is only associated with the source location" do
-      let(:stock_locations) { [source_location] }
-
-      it { is_expected.to be_able_to(:display, source_location) }
-      it { is_expected.to_not be_able_to(:display, destination_location) }
-
-      it { is_expected.to be_able_to(:display, Spree::StockTransfer) }
-      it { is_expected.to be_able_to(:admin, Spree::StockTransfer) }
-      it { is_expected.to be_able_to(:create, Spree::StockTransfer) }
-
-      it { is_expected.to be_able_to(:transfer_from, source_location) }
-      it { is_expected.to be_able_to(:transfer_to, source_location) }
-
-      it { is_expected.to_not be_able_to(:transfer_from, destination_location) }
-      it { is_expected.to_not be_able_to(:transfer_to, destination_location) }
-
-      it { is_expected.to be_able_to(:display, transfer_with_source) }
-      it { is_expected.to be_able_to(:display, transfer_with_source_and_destination) }
-      it { is_expected.to_not be_able_to(:display, transfer_with_destination) }
-
-      it { is_expected.to be_able_to(:manage, transfer_with_source) }
-      it { is_expected.to be_able_to(:manage, transfer_with_source_and_destination) }
-      it { is_expected.to_not be_able_to(:manage, transfer_with_destination) }
-
-      it { is_expected.to be_able_to(:manage, source_transfer_item) }
-      it { is_expected.to be_able_to(:manage, source_and_destination_transfer_item) }
-      it { is_expected.to_not be_able_to(:manage, destination_transfer_item) }
-
-      context "stock transfer has been shipped" do
-        before do
-          transfer_with_source_and_destination.update_attributes!(shipped_at: Time.current)
-          described_class.new(ability).activate!
-        end
-
-        it { is_expected.to_not be_able_to(:manage, transfer_with_source_and_destination) }
-        it { is_expected.to_not be_able_to(:manage, source_and_destination_transfer_item) }
-      end
-    end
-
-    context "when the user is only associated with the destination location" do
-      let(:stock_locations) { [destination_location] }
-
-      it { is_expected.to be_able_to(:display, destination_location) }
-      it { is_expected.to_not be_able_to(:display, source_location) }
-
-      it { is_expected.to be_able_to(:display, Spree::StockTransfer) }
-      it { is_expected.to be_able_to(:admin, Spree::StockTransfer) }
-      it { is_expected.to be_able_to(:create, Spree::StockTransfer) }
-
-      it { is_expected.to_not be_able_to(:transfer_from, source_location) }
-      it { is_expected.to_not be_able_to(:transfer_to, source_location) }
-
-      it { is_expected.to be_able_to(:transfer_from, destination_location) }
-      it { is_expected.to be_able_to(:transfer_to, destination_location) }
-
-      it { is_expected.to be_able_to(:display, transfer_with_destination) }
-      it { is_expected.to_not be_able_to(:display, transfer_with_source) }
-      it { is_expected.to_not be_able_to(:display, transfer_with_source_and_destination) }
-
-      it { is_expected.to be_able_to(:manage, transfer_with_destination) }
-      it { is_expected.to_not be_able_to(:manage, transfer_with_source) }
-      it { is_expected.to_not be_able_to(:manage, transfer_with_source_and_destination) }
-
-      it { is_expected.to be_able_to(:manage, destination_transfer_item) }
-      it { is_expected.to_not be_able_to(:manage, source_transfer_item) }
-      it { is_expected.to_not be_able_to(:manage, source_and_destination_transfer_item) }
-
-      context "stock transfer has been shipped" do
-        before do
-          transfer_with_source_and_destination.update_attributes!(shipped_at: Time.current)
-          described_class.new(ability).activate!
-        end
-
-        it { is_expected.to be_able_to(:manage, transfer_with_source_and_destination) }
-        it { is_expected.to be_able_to(:manage, source_and_destination_transfer_item) }
-      end
-    end
-
-    context "when the user is associated with both locations" do
-      let(:stock_locations) { [source_location, destination_location] }
-
-      it { is_expected.to be_able_to(:display, source_location) }
-      it { is_expected.to be_able_to(:display, destination_location) }
-
-      it { is_expected.to be_able_to(:display, Spree::StockTransfer) }
-      it { is_expected.to be_able_to(:admin, Spree::StockTransfer) }
-      it { is_expected.to be_able_to(:create, Spree::StockTransfer) }
-
-      it { is_expected.to be_able_to(:transfer_from, source_location) }
-      it { is_expected.to be_able_to(:transfer_to, source_location) }
-
-      it { is_expected.to be_able_to(:transfer_from, destination_location) }
-      it { is_expected.to be_able_to(:transfer_to, destination_location) }
-
-      it { is_expected.to be_able_to(:display, transfer_with_source) }
-      it { is_expected.to be_able_to(:display, transfer_with_source_and_destination) }
-      it { is_expected.to be_able_to(:display, transfer_with_destination) }
-
-      it { is_expected.to be_able_to(:manage, transfer_with_source) }
-      it { is_expected.to be_able_to(:manage, transfer_with_destination) }
-      it { is_expected.to be_able_to(:manage, transfer_with_source_and_destination) }
-
-      it { is_expected.to be_able_to(:manage, source_transfer_item) }
-      it { is_expected.to be_able_to(:manage, destination_transfer_item) }
-      it { is_expected.to be_able_to(:manage, source_and_destination_transfer_item) }
-
-      context "stock transfer has been shipped" do
-        before do
-          transfer_with_source_and_destination.update_attributes!(shipped_at: Time.current)
-          described_class.new(ability).activate!
-        end
-
-        it { is_expected.to be_able_to(:manage, transfer_with_source_and_destination) }
-        it { is_expected.to be_able_to(:manage, source_and_destination_transfer_item) }
-      end
-    end
-
-    context "when the user is associated with neither location" do
-      let(:stock_locations) { [] }
-
-      it { is_expected.to_not be_able_to(:display, source_location) }
-      it { is_expected.to_not be_able_to(:display, destination_location) }
-
-      it { is_expected.to_not be_able_to(:display, Spree::StockTransfer) }
-      it { is_expected.to_not be_able_to(:admin, Spree::StockTransfer) }
-      it { is_expected.to_not be_able_to(:create, Spree::StockTransfer) }
-
-      it { is_expected.to_not be_able_to(:transfer_from, source_location) }
-      it { is_expected.to_not be_able_to(:transfer_to, source_location) }
-
-      it { is_expected.to_not be_able_to(:transfer_from, destination_location) }
-      it { is_expected.to_not be_able_to(:transfer_to, destination_location) }
-
-      it { is_expected.to_not be_able_to(:manage, transfer_with_source) }
-      it { is_expected.to_not be_able_to(:manage, transfer_with_destination) }
-      it { is_expected.to_not be_able_to(:manage, transfer_with_source_and_destination) }
-
-      it { is_expected.to_not be_able_to(:manage, source_transfer_item) }
-      it { is_expected.to_not be_able_to(:manage, destination_transfer_item) }
-      it { is_expected.to_not be_able_to(:manage, source_and_destination_transfer_item) }
-    end
-  end
-
-  context "when not activated" do
-    let(:user) { create :user }
-
-    it { is_expected.to_not be_able_to(:display, Spree::StockTransfer) }
-    it { is_expected.to_not be_able_to(:admin, Spree::StockTransfer) }
-    it { is_expected.to_not be_able_to(:create, Spree::StockTransfer) }
-
-    it { is_expected.to_not be_able_to(:display, source_location) }
-    it { is_expected.to_not be_able_to(:display, destination_location) }
-
-    it { is_expected.to_not be_able_to(:transfer_from, source_location) }
-    it { is_expected.to_not be_able_to(:transfer_to, source_location) }
-
-    it { is_expected.to_not be_able_to(:transfer_from, destination_location) }
-    it { is_expected.to_not be_able_to(:transfer_to, destination_location) }
-
-    it { is_expected.to_not be_able_to(:display, source_location) }
-    it { is_expected.to_not be_able_to(:display, destination_location) }
-
-    it { is_expected.to_not be_able_to(:manage, transfer_with_source) }
-    it { is_expected.to_not be_able_to(:manage, transfer_with_destination) }
-    it { is_expected.to_not be_able_to(:manage, transfer_with_source_and_destination) }
-
-    it { is_expected.to_not be_able_to(:manage, source_transfer_item) }
-    it { is_expected.to_not be_able_to(:manage, destination_transfer_item) }
-    it { is_expected.to_not be_able_to(:manage, source_and_destination_transfer_item) }
-  end
-end

data/spec/models/spree/permission_sets/stock_transfer_display_spec.rb

@@ -1,23 +0,0 @@
-require 'rails_helper'
-
-RSpec.describe Spree::PermissionSets::StockTransferDisplay do
-  let(:ability) { DummyAbility.new }
-
-  subject { ability }
-
-  context "when activated" do
-    before do
-      described_class.new(ability).activate!
-    end
-
-    it { is_expected.to be_able_to(:display, Spree::StockTransfer) }
-    it { is_expected.to be_able_to(:admin, Spree::StockTransfer) }
-    it { is_expected.to be_able_to(:display, Spree::StockLocation) }
-  end
-
-  context "when not activated" do
-    it { is_expected.not_to be_able_to(:display, Spree::StockTransfer) }
-    it { is_expected.not_to be_able_to(:admin, Spree::StockTransfer) }
-    it { is_expected.not_to be_able_to(:display, Spree::StockLocation) }
-  end
-end

data/spec/models/spree/permission_sets/stock_transfer_management_spec.rb

@@ -1,23 +0,0 @@
-require 'rails_helper'
-
-RSpec.describe Spree::PermissionSets::StockTransferManagement do
-  let(:ability) { DummyAbility.new }
-
-  subject { ability }
-
-  context "when activated" do
-    before do
-      described_class.new(ability).activate!
-    end
-
-    it { is_expected.to be_able_to(:manage, Spree::StockTransfer) }
-    it { is_expected.to be_able_to(:manage, Spree::TransferItem) }
-    it { is_expected.to be_able_to(:display, Spree::StockLocation) }
-  end
-
-  context "when not activated" do
-    it { is_expected.to_not be_able_to(:manage, Spree::StockTransfer) }
-    it { is_expected.to_not be_able_to(:manage, Spree::TransferItem) }
-    it { is_expected.not_to be_able_to(:display, Spree::StockLocation) }
-  end
-end

data/spec/models/spree/stock_transfer_spec.rb

@@ -1,308 +0,0 @@
-require 'rails_helper'
-
-module Spree
-  RSpec.describe StockTransfer, type: :model do
-    let(:destination_location) { create(:stock_location_with_items) }
-    let(:source_location) { create(:stock_location_with_items) }
-    let(:stock_item) { source_location.stock_items.order(:id).first }
-    let(:variant) { stock_item.variant }
-    let(:stock_transfer) do
-      StockTransfer.create(description: 'PO123', source_location: source_location, destination_location: destination_location)
-    end
-
-    subject { stock_transfer }
-
-    describe '#description' do
-      subject { super().description }
-      it { is_expected.to eq 'PO123' }
-    end
-
-    describe '#to_param' do
-      subject { super().to_param }
-      it { is_expected.to match /T\d+/ }
-    end
-
-    describe "transfer item building" do
-      let(:stock_transfer) do
-        variant = source_location.stock_items.first.variant
-        stock_transfer = Spree::StockTransfer.new(
-          number: "T123",
-          source_location: source_location,
-          destination_location: destination_location
-        )
-        stock_transfer.transfer_items.build(variant: variant, expected_quantity: 5)
-        stock_transfer
-      end
-
-      subject { stock_transfer.save }
-
-      it { is_expected.to eq true }
-
-      it "creates the associated transfer item" do
-        expect { subject }.to change { Spree::TransferItem.count }.by(1)
-      end
-    end
-
-    describe "#receivable?" do
-      subject { stock_transfer.receivable? }
-
-      context "finalized" do
-        before do
-          stock_transfer.update_attributes(finalized_at: Time.current)
-        end
-
-        it { is_expected.to eq false }
-      end
-
-      context "shipped" do
-        before do
-          stock_transfer.update_attributes(shipped_at: Time.current)
-        end
-
-        it { is_expected.to eq false }
-      end
-
-      context "closed" do
-        before do
-          stock_transfer.update_attributes(closed_at: Time.current)
-        end
-
-        it { is_expected.to eq false }
-      end
-
-      context "finalized and closed" do
-        before do
-          stock_transfer.update_attributes(finalized_at: Time.current, closed_at: Time.current)
-        end
-
-        it { is_expected.to eq false }
-      end
-
-      context "shipped and closed" do
-        before do
-          stock_transfer.update_attributes(shipped_at: Time.current, closed_at: Time.current)
-        end
-
-        it { is_expected.to eq false }
-      end
-
-      context "finalized and shipped" do
-        before do
-          stock_transfer.update_attributes(finalized_at: Time.current, shipped_at: Time.current)
-        end
-
-        it { is_expected.to eq true }
-      end
-    end
-
-    describe "#finalizable?" do
-      subject { stock_transfer.finalizable? }
-
-      context "finalized" do
-        before do
-          stock_transfer.update_attributes(finalized_at: Time.current)
-        end
-
-        it { is_expected.to eq false }
-      end
-
-      context "shipped" do
-        before do
-          stock_transfer.update_attributes(shipped_at: Time.current)
-        end
-
-        it { is_expected.to eq false }
-      end
-
-      context "closed" do
-        before do
-          stock_transfer.update_attributes(closed_at: Time.current)
-        end
-
-        it { is_expected.to eq false }
-      end
-
-      context "finalized and closed" do
-        before do
-          stock_transfer.update_attributes(finalized_at: Time.current, closed_at: Time.current)
-        end
-
-        it { is_expected.to eq false }
-      end
-
-      context "shipped and closed" do
-        before do
-          stock_transfer.update_attributes(shipped_at: Time.current, closed_at: Time.current)
-        end
-
-        it { is_expected.to eq false }
-      end
-
-      context "no action taken on stock transfer" do
-        before do
-          stock_transfer.update_attributes(finalized_at: nil, shipped_at: nil, closed_at: nil)
-        end
-
-        it { is_expected.to eq true }
-      end
-    end
-
-    describe "#finalize" do
-      let(:user) { create(:user) }
-
-      subject { stock_transfer.finalize(user) }
-
-      context "can be finalized" do
-        it "sets a finalized_at date" do
-          expect { subject }.to change { stock_transfer.finalized_at }
-        end
-
-        it "sets the finalized_by to the supplied user" do
-          subject
-          expect(stock_transfer.finalized_by).to eq user
-        end
-      end
-
-      context "can't be finalized" do
-        before do
-          stock_transfer.update_attributes(finalized_at: Time.current)
-        end
-
-        it "doesn't set a finalized_at date" do
-          expect { subject }.to_not change { stock_transfer.finalized_at }
-        end
-
-        it "doesn't set a finalized_by user" do
-          expect { subject }.to_not change { stock_transfer.finalized_by }
-        end
-
-        it "adds an error message" do
-          subject
-          expect(stock_transfer.errors.full_messages).to include Spree.t(:stock_transfer_cannot_be_finalized)
-        end
-      end
-    end
-
-    describe "#close" do
-      let(:user) { create(:user) }
-      let(:stock_transfer) { create(:receivable_stock_transfer_with_items) }
-
-      subject { stock_transfer.close(user) }
-
-      context "can be closed" do
-        it "sets a closed_at date" do
-          expect { subject }.to change { stock_transfer.closed_at }
-        end
-
-        it "sets the closed_by to the supplied user" do
-          subject
-          expect(stock_transfer.closed_by).to eq user
-        end
-      end
-
-      context "can't be closed" do
-        before do
-          stock_transfer.update_attributes(finalized_at: nil)
-        end
-
-        it "doesn't set a closed_at date" do
-          expect { subject }.to_not change { stock_transfer.closed_at }
-        end
-
-        it "doesn't set a closed_by user" do
-          expect { subject }.to_not change { stock_transfer.closed_by }
-        end
-
-        it "adds an error message" do
-          subject
-          expect(stock_transfer.errors.full_messages).to include Spree.t(:stock_transfer_must_be_receivable)
-        end
-      end
-    end
-
-    describe "destroying" do
-      subject { stock_transfer.destroy }
-
-      context "stock transfer is finalized" do
-        before do
-          stock_transfer.update_attributes!(finalized_at: Time.current)
-        end
-
-        it "doesn't destroy the stock transfer" do
-          expect { subject }.to_not change { Spree::StockTransfer.count }
-        end
-
-        it "adds an error message to the model" do
-          subject
-          expect(stock_transfer.errors.full_messages).to include Spree.t('errors.messages.cannot_delete_finalized_stock_transfer')
-        end
-      end
-
-      context "stock transfer is not finalized" do
-        before do
-          stock_transfer.update_attributes!(finalized_at: nil)
-        end
-
-        it "destroys the stock transfer" do
-          expect { subject }.to change { Spree::StockTransfer.count }.by(-1)
-        end
-      end
-    end
-
-    describe '#ship' do
-      let(:stock_transfer) { create(:stock_transfer, tracking_number: "ABC123") }
-
-      context "tracking number is provided" do
-        subject { stock_transfer.ship(tracking_number: "XYZ123") }
-
-        it "updates the tracking number" do
-          expect { subject }.to change { stock_transfer.tracking_number }.from("ABC123").to("XYZ123")
-        end
-      end
-
-      context "tracking number is not provided" do
-        subject { stock_transfer.ship }
-
-        it "preserves the existing tracking number" do
-          expect { subject }.to_not change { stock_transfer.tracking_number }.from("ABC123")
-        end
-      end
-    end
-
-    describe '#transfer' do
-      let(:stock_transfer) { create(:stock_transfer_with_items) }
-
-      before do
-        stock_transfer.transfer_items.each { |item| item.update_attributes(expected_quantity: 1) }
-      end
-
-      subject { stock_transfer.transfer }
-
-      context 'with enough stock' do
-        it 'creates stock movements for transfer items' do
-          expect{ subject }.to change{ Spree::StockMovement.count }.by(stock_transfer.transfer_items.count)
-        end
-      end
-
-      context 'without enough stock' do
-        before do
-          stockless_variant = stock_transfer.transfer_items.last.variant
-          stock_transfer.source_location.stock_item(stockless_variant).set_count_on_hand(0)
-        end
-
-        it 'rollsback the transaction' do
-          expect{ subject }.to_not change{ Spree::StockMovement.count }
-        end
-
-        it 'adds errors' do
-          subject
-          expect(stock_transfer.errors.full_messages.join(', ')).to match /not enough inventory/
-        end
-
-        it 'returns false' do
-          expect(subject).to eq false
-        end
-      end
-    end
-  end
-end