solidus_core 2.3.1 → 2.4.0.beta1

data/spec/models/spree/payment/cancellation_spec.rb

@@ -0,0 +1,81 @@
+require 'spec_helper'
+
+RSpec.describe Spree::Payment::Cancellation do
+  describe '#initialize' do
+    it 'has default refund reason' do
+      expect(subject.reason).to eq Spree::Payment::Cancellation::DEFAULT_REASON
+    end
+
+    context 'with reason given' do
+      subject { described_class.new(reason: 'My custom reason') }
+
+      it 'has this as refund reason' do
+        expect(subject.reason).to eq 'My custom reason'
+      end
+    end
+  end
+
+  describe '#cancel' do
+    subject { described_class.new.cancel(payment) }
+
+    let(:payment_method) { create(:payment_method) }
+    let(:payment) { create(:payment, payment_method: payment_method, amount: 10) }
+
+    context 'if the payment_method responds to `try_void`' do
+      context 'if payment method returns void response' do
+        before do
+          expect(payment_method).to receive(:try_void).with(payment) { double }
+        end
+
+        it 'handles the void' do
+          expect(payment).to receive(:handle_void_response)
+          subject
+        end
+      end
+
+      context 'if payment method rejects the void' do
+        before do
+          expect(payment_method).to receive(:try_void).with(payment) { false }
+        end
+
+        it 'refunds the payment' do
+          expect { subject }.to change { payment.refunds.count }.from(0).to(1)
+        end
+
+        context 'if payment has partial refunds' do
+          let(:credit_amount) { payment.amount / 2 }
+
+          before do
+            payment.refunds.create!(
+              amount: credit_amount,
+              reason: Spree::RefundReason.where(name: 'test').first_or_create
+            )
+          end
+
+          it 'only refunds the allowed credit amount' do
+            subject
+            refund = payment.refunds.last
+            expect(refund.amount).to eq(credit_amount)
+          end
+        end
+      end
+    end
+
+    context 'if the payment_method does not respond to `try_void`' do
+      before do
+        allow(payment_method).to receive(:respond_to?) { false }
+        expect(payment_method).to receive(:cancel) { double }
+        expect(payment).to receive(:handle_void_response)
+      end
+
+      it 'calls cancel instead' do
+        Spree::Deprecation.silence { subject }
+      end
+
+      it 'prints depcrecation warning' do
+        expect(Spree::Deprecation).to receive(:warn)
+        subject
+      end
+    end
+  end
+end

data/spec/models/spree/payment_create_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 
 module Spree
   RSpec.describe PaymentCreate do

data/spec/models/spree/payment_method/bogus_credit_card_spec.rb

@@ -1,7 +1,7 @@
-require 'spec_helper'
+require 'rails_helper'
 
 module Spree
-  describe PaymentMethod::BogusCreditCard, type: :model do
+  RSpec.describe PaymentMethod::BogusCreditCard, type: :model do
     let(:bogus) { create(:credit_card_payment_method) }
     let!(:cc) { create(:credit_card, payment_method: bogus, gateway_customer_profile_id: "BGS-RERTERT") }
   end

data/spec/models/spree/payment_method/check_spec.rb

@@ -1,6 +1,6 @@
-require 'spec_helper'
+require 'rails_helper'
 
-describe Spree::PaymentMethod::Check do
+RSpec.describe Spree::PaymentMethod::Check do
   let(:order) { create(:order) }
   subject { described_class.new }
 
@@ -53,25 +53,25 @@ describe Spree::PaymentMethod::Check do
   end
 
   context "#capture" do
-    it "succeds" do
+    it "succeeds" do
       expect(subject.capture).to be_success
     end
   end
 
-  context "#cancel" do
-    it "returns nil" do
-      expect(subject.cancel).to be_nil
+  context "#try_void" do
+    it "succeeds" do
+      expect(subject.try_void).to be_success
     end
   end
 
   context "#void" do
-    it "succeds" do
+    it "succeeds" do
       expect(subject.void).to be_success
     end
   end
 
   context "#credit" do
-    it "succeds" do
+    it "succeeds" do
       expect(subject.credit).to be_success
     end
   end

data/spec/models/spree/payment_method/credit_card_spec.rb

@@ -1,6 +1,6 @@
-require 'spec_helper'
+require 'rails_helper'
 
-describe Spree::PaymentMethod::CreditCard, type: :model do
+RSpec.describe Spree::PaymentMethod::CreditCard, type: :model do
   context "fetching payment sources" do
     let(:store) { create :store }
     let(:user) { create :user }

data/spec/models/spree/payment_method/simple_bogus_credit_card_spec.rb

@@ -1,6 +1,6 @@
-require 'spec_helper'
+require 'rails_helper'
 
-describe Spree::PaymentMethod::SimpleBogusCreditCard, type: :model do
+RSpec.describe Spree::PaymentMethod::SimpleBogusCreditCard, type: :model do
   subject { Spree::PaymentMethod::SimpleBogusCreditCard.new }
 
   # regression test for https://github.com/spree/spree/issues/3824

data/spec/models/spree/payment_method/store_credit_spec.rb

@@ -1,6 +1,6 @@
-require 'spec_helper'
+require 'rails_helper'
 
-describe Spree::PaymentMethod::StoreCredit do
+RSpec.describe Spree::PaymentMethod::StoreCredit do
   let(:order)           { create(:order) }
   let(:payment)         { create(:payment, order: order) }
   let(:gateway_options) { payment.gateway_options }
@@ -246,13 +246,14 @@ describe Spree::PaymentMethod::StoreCredit do
     end
   end
 
-  context "#cancel" do
+  context "#try_void" do
     subject do
-      Spree::PaymentMethod::StoreCredit.new.cancel(auth_code)
+      payment_method.try_void(double(response_code: auth_code))
     end
 
-    let(:store_credit) { create(:store_credit, amount: original_amount, amount_used: captured_amount) }
-    let(:auth_code)    { "1-SC-20141111111111" }
+    let(:payment_method)  { described_class.create!(name: 'Store Credit') }
+    let(:store_credit)    { create(:store_credit, amount: original_amount, amount_used: captured_amount) }
+    let(:auth_code)       { "1-SC-20141111111111" }
     let(:original_amount) { 100.0 }
     let(:captured_amount) { 10.0 }
 
@@ -263,48 +264,59 @@ describe Spree::PaymentMethod::StoreCredit do
     end
 
     context "capture event found" do
-      let!(:store_credit_event) {
+      let!(:store_credit_event) do
         create(:store_credit_capture_event,
-                                        authorization_code: auth_code,
-                                        amount: captured_amount,
-                                        store_credit: store_credit)
-      }
+          authorization_code: auth_code,
+          amount: captured_amount,
+          store_credit: store_credit)
+      end
+
+      it { is_expected.to be(false) }
+
+      describe "called from payment#cancel!" do
+        subject { payment.cancel! }
 
-      it_behaves_like "a spree payment method"
+        let!(:payment) do
+          create(:payment,
+            order: order,
+            payment_method: payment_method,
+            source: store_credit,
+            amount: captured_amount,
+            response_code: auth_code)
+        end
 
-      it "refunds the capture amount" do
-        expect { subject }.to change{ store_credit.reload.amount_remaining }.
-                              from(original_amount - captured_amount).
-                              to(original_amount)
+        it "refunds the capture amount" do
+          expect { subject }.to change { store_credit.reload.amount_remaining }.
+                                from(original_amount - captured_amount).
+                                to(original_amount)
+        end
       end
     end
 
     context "capture event not found" do
       context "auth event found" do
-        let!(:store_credit_event) {
+        let!(:store_credit_event) do
           create(:store_credit_auth_event,
-                                          authorization_code: auth_code,
-                                          amount: captured_amount,
-                                          store_credit: store_credit)
-        }
+            authorization_code: auth_code,
+            amount: captured_amount,
+            store_credit: store_credit)
+        end
 
         it_behaves_like "a spree payment method"
 
-        it "refunds the capture amount" do
-          expect { subject }.to change{ store_credit.reload.amount_remaining }.
+        it "voids the capture amount" do
+          expect { subject }.to change { store_credit.reload.amount_remaining }.
                                 from(original_amount - captured_amount).
                                 to(original_amount)
         end
       end
 
       context "store credit event not found" do
-        subject do
-          Spree::PaymentMethod::StoreCredit.new.cancel('INVALID')
-        end
+        let(:auth_code) { 'INVALID' }
 
         it_behaves_like "a spree payment method"
 
-        it { expect(subject.success?).to be(false) }
+        it { is_expected.to_not be_success }
       end
     end
   end

data/spec/models/spree/payment_method_spec.rb

@@ -1,6 +1,6 @@
-require 'spec_helper'
+require 'rails_helper'
 
-describe Spree::PaymentMethod, type: :model do
+RSpec.describe Spree::PaymentMethod, type: :model do
   let!(:payment_method_nil_display)  { create(:payment_method, active: true,
                                               available_to_users: true,
                                               available_to_admin: true) }

data/spec/models/spree/payment_spec.rb

@@ -1,6 +1,6 @@
-require 'spec_helper'
+require 'rails_helper'
 
-describe Spree::Payment, type: :model do
+RSpec.describe Spree::Payment, type: :model do
   let(:store) { create :store }
   let(:order) { Spree::Order.create(store: store) }
   let(:refund_reason) { create(:refund_reason) }
@@ -481,25 +481,34 @@ describe Spree::Payment, type: :model do
     end
 
     describe "#cancel!" do
+      subject { payment.cancel! }
+
       before do
         payment.response_code = 'abc'
         payment.state = 'pending'
       end
 
-      context "if successful" do
+      context "if void returns successful response" do
+        before do
+          expect(gateway).to receive(:try_void) { success_response }
+        end
+
+        it "should update the state to void" do
+          expect { subject }.to change { payment.state }.to('void')
+        end
+
         it "should update the response_code with the authorization from the gateway" do
-          # Change it to something different
-          allow(gateway).to receive_messages cancel: success_response
-          payment.cancel!
-          expect(payment.state).to eq('void')
-          expect(payment.response_code).to eq('123')
+          expect { subject }.to change { payment.response_code }.to('123')
         end
       end
 
-      context "if unsuccessful" do
-        it "should not void the payment" do
-          allow(gateway).to receive_messages cancel: failed_response
-          expect { payment.cancel! }.to raise_error(Spree::Core::GatewayError)
+      context "if void returns failed response" do
+        before do
+          expect(gateway).to receive(:try_void) { failed_response }
+        end
+
+        it "should raise gateway error and not change payment state or response_code", :aggregate_failures do
+          expect { subject }.to raise_error(Spree::Core::GatewayError)
           expect(payment.state).to eq('pending')
           expect(payment.response_code).to eq('abc')
         end
@@ -653,13 +662,12 @@ describe Spree::Payment, type: :model do
     end
 
     context "completed orders" do
-      let(:payment_method) { create(:check_payment_method) }
       before { allow(order).to receive_messages completed?: true }
 
       it "updates payment_state and shipments" do
         expect(order.updater).to receive(:update_payment_state)
         expect(order.updater).to receive(:update_shipment_state)
-        Spree::Payment.create!(amount: 100, order: order, payment_method: payment_method)
+        Spree::Payment.create(amount: 100, order: order)
       end
     end
 
@@ -742,14 +750,60 @@ describe Spree::Payment, type: :model do
       expect(payment.reload.state).to eq('checkout')
     end
 
+    context 'with order having other payments' do
+      let!(:existing_payment) do
+        create(:payment,
+          payment_method: existing_payment_method,
+          source: existing_payment_source,
+          order: order,
+          amount: 5)
+      end
+
+      let(:payment_method) { create(:payment_method) }
+      let(:payment_source) { create(:credit_card) }
+      let(:payment) do
+        build(:payment,
+          payment_method: payment_method,
+          source: payment_source,
+          order: order,
+          amount: 5)
+      end
+
+      context 'that are store credit payments' do
+        let(:existing_payment_method) { create(:store_credit_payment_method) }
+        let(:existing_payment_source) { create(:store_credit) }
+
+        it 'does not invalidate existing payments' do
+          expect { payment.save! }.to_not change { order.payments.with_state(:invalid).count }
+        end
+
+        context 'when payment itself is a store credit payment' do
+          let(:payment_method) { existing_payment_method }
+          let(:payment_source) { existing_payment_source }
+
+          it 'does not invalidate existing payments' do
+            expect { payment.save! }.to_not change { order.payments.with_state(:invalid).count }
+          end
+        end
+      end
+
+      context 'that are not store credit payments' do
+        let(:existing_payment_method) { create(:payment_method) }
+        let(:existing_payment_source) { create(:credit_card) }
+
+        it 'invalidates existing payments' do
+          expect { payment.save! }.to change { order.payments.with_state(:invalid).count }
+        end
+      end
+    end
+
     describe "invalidating payments updates in memory objects" do
-      let(:payment_method) { create(:check_payment_method) }
       before do
-        Spree::PaymentCreate.new(order, amount: 1, payment_method_id: payment_method.id).build.save!
+        Spree::PaymentCreate.new(order, amount: 1).build.save!
         expect(order.payments.map(&:state)).to contain_exactly(
           'checkout'
         )
-        Spree::PaymentCreate.new(order, amount: 2, payment_method_id: payment_method.id).build.save!
+        Spree::PaymentCreate.new(order, amount: 2).build.save!
       end
 
       it 'should not have stale payments' do

data/spec/models/spree/permission_sets/base_spec.rb

@@ -1,6 +1,6 @@
-require 'spec_helper'
+require 'rails_helper'
 
-describe Spree::PermissionSets::Base do
+RSpec.describe Spree::PermissionSets::Base do
   let(:ability) { Spree::Ability.new nil }
   subject { described_class.new(ability).activate! }
 

data/spec/models/spree/permission_sets/configuration_display.rb

@@ -1,6 +1,6 @@
-require 'spec_helper'
+require 'rails_helper'
 
-describe Spree::PermissionSets::ConfigurationDisplay do
+RSpec.describe Spree::PermissionSets::ConfigurationDisplay do
   let(:ability) { DummyAbility.new }
 
   subject { ability }

data/spec/models/spree/permission_sets/configuration_management_spec.rb

@@ -1,6 +1,6 @@
-require 'spec_helper'
+require 'rails_helper'
 
-describe Spree::PermissionSets::ConfigurationManagement do
+RSpec.describe Spree::PermissionSets::ConfigurationManagement do
   let(:ability) { DummyAbility.new }
 
   subject { ability }

data/spec/models/spree/permission_sets/dashboard_display_spec.rb

@@ -1,6 +1,6 @@
-require 'spec_helper'
+require 'rails_helper'
 
-describe Spree::PermissionSets::DashboardDisplay do
+RSpec.describe Spree::PermissionSets::DashboardDisplay do
   let(:ability) { DummyAbility.new }
 
   subject { ability }