solidus_core 2.11.17 → 3.0.0.rc2

data/app/models/spree/payment_method.rb

@@ -1,6 +1,5 @@
 # frozen_string_literal: true
 
-require 'spree/preferences/persistable'
 require 'spree/preferences/statically_configurable'
 
 module Spree
@@ -12,8 +11,6 @@ module Spree
   # This class is not meant to be instantiated. Please create instances of concrete payment methods.
   #
   class PaymentMethod < Spree::Base
-    include Spree::Preferences::Persistable
-
     preference :server, :string, default: 'test'
     preference :test_mode, :boolean, default: true
 
@@ -21,19 +18,6 @@ module Spree
 
     acts_as_list
 
-    # @private
-    def self.const_missing(name)
-      if name == :DISPLAY
-        Spree::Deprecation.warn(
-          "#{self}::DISPLAY has been deprecated and will be removed in Solidus v3.",
-          caller
-        )
-        const_set(:DISPLAY, [:both, :front_end, :back_end])
-      else
-        super
-      end
-    end
-
     validates :name, :type, presence: true
 
     has_many :payments, class_name: "Spree::Payment", inverse_of: :payment_method
@@ -70,51 +54,9 @@ module Spree
     end
 
     class << self
-      # @deprecated Use Spree::Config.environment.payment_methods instead
-      def providers
-        Spree::Deprecation.warn 'Spree::PaymentMethod.providers is deprecated and will be deleted in Solidus 3.0. ' \
-          'Please use Rails.application.config.spree.payment_methods instead'
-        Spree::Config.environment.payment_methods
-      end
-
-      # @deprecated Use {.active}, {.available_to_users}, and {.available_to_admin} scopes instead.
-      def available(display_on = nil, store: nil)
-        Spree::Deprecation.warn "Spree::PaymentMethod.available is deprecated."\
-          "Please use .active, .available_to_users, and .available_to_admin scopes instead."\
-          "For payment methods associated with a specific store, use Spree::PaymentMethod.available_to_store(your_store)"\
-          " as the base applying any further filtering"
-
-        display_on = display_on.to_s
-
-        available_payment_methods =
-          case display_on
-          when 'front_end'
-            active.available_to_users
-          when 'back_end'
-            active.available_to_admin
-          else
-            active.available_to_users.available_to_admin
-          end
-        available_payment_methods.select do |payment|
-          store.nil? || store.payment_methods.empty? || store.payment_methods.include?(payment)
-        end
-      end
-
       def model_name
         ModelName.new(self, Spree)
       end
-
-      # @deprecated Use .active.any? instead
-      def active?
-        Spree::Deprecation.warn "#{self}.active? is deprecated. Use #{self}.active.any? instead"
-        where(type: to_s, active: true).count > 0
-      end
-
-      # @deprecated Use .with_discarded.find instead
-      def find_with_destroyed(*args)
-        Spree::Deprecation.warn "#{self}.find_with_destroyed is deprecated. Use #{self}.with_discarded.find instead"
-        unscoped { find(*args) }
-      end
     end
 
     # Represents the gateway of this payment method
@@ -141,8 +83,6 @@ module Spree
 
       @gateway ||= gateway_class.new(gateway_options)
     end
-    alias_method :provider, :gateway
-    deprecate provider: :gateway, deprecator: Spree::Deprecation
 
     # Represents all preferences as a Hash
     #
@@ -162,29 +102,6 @@ module Spree
       raise ::NotImplementedError, "You must implement payment_source_class method for #{self.class}."
     end
 
-    # @deprecated Use {Spree::PaymentMethod#available_to_users=} and {Spree::PaymentMethod#available_to_admin=} instead
-    def display_on=(value)
-      Spree::Deprecation.warn "Spree::PaymentMethod#display_on= is deprecated."\
-        "Please use #available_to_users= and #available_to_admin= instead."
-      self.available_to_users = value.blank? || value == 'front_end'
-      self.available_to_admin = value.blank? || value == 'back_end'
-    end
-
-    # @deprecated Use {Spree::PaymentMethod#available_to_users} and {Spree::PaymentMethod#available_to_admin} instead
-    def display_on
-      Spree::Deprecation.warn "Spree::PaymentMethod#display_on is deprecated."\
-        "Please use #available_to_users and #available_to_admin instead."
-      if available_to_users? && available_to_admin?
-        ''
-      elsif available_to_users?
-        'front_end'
-      elsif available_to_admin?
-        'back_end'
-      else
-        'none'
-      end
-    end
-
     # Used as partial name for your payment method
     #
     # Currently your payment method needs to provide these partials:
@@ -205,21 +122,7 @@ module Spree
     #     The view that represents your payment method on orders through the api
     #
     def partial_name
-      deprecated_method_type_override || type.demodulize.underscore
-    end
-
-    # :nodoc:
-    # If method_type has been overridden, call it and return the value, otherwise return nil
-    def deprecated_method_type_override
-      if method(:method_type).owner != Spree::PaymentMethod
-        Spree::Deprecation.warn "#{method(:method_type).owner} is overriding PaymentMethod#method_type. This is deprecated and will be removed from Solidus 3.0 (override partial_name instead).", caller[1..-1]
-        method_type
-      end
-    end
-
-    def method_type
-      Spree::Deprecation.warn "method_type is deprecated and will be removed from Solidus 3.0 (use partial_name instead)", caller
-      partial_name
+      type.demodulize.underscore
     end
 
     def payment_profiles_supported?
@@ -277,14 +180,7 @@ module Spree
     # Represents the gateway class of this payment method
     #
     def gateway_class
-      if respond_to? :provider_class
-        Spree::Deprecation.warn \
-          "provider_class is deprecated and will be removed from Solidus 3.0 " \
-          "(use gateway_class instead)"
-        public_send :provider_class
-      else
-        raise ::NotImplementedError, "You must implement gateway_class method for #{self.class}."
-      end
+      raise ::NotImplementedError, "You must implement gateway_class method for #{self.class}."
     end
   end
 end

data/app/models/spree/product/scopes.rb

@@ -201,33 +201,6 @@ module Spree
             where(subquery.arel.exists)
           end
 
-          def self.distinct_by_product_ids(sort_order = nil)
-            Spree::Deprecation.warn "Product.distinct_by_product_ids is deprecated and should not be used"
-
-            sort_column = sort_order.split(" ").first
-
-            # Postgres will complain when using ordering by expressions not present in
-            # SELECT DISTINCT. e.g.
-            #
-            #   PG::InvalidColumnReference: ERROR:  for SELECT DISTINCT, ORDER BY
-            #   expressions must appear in select list. e.g.
-            #
-            #   SELECT  DISTINCT "spree_products".* FROM "spree_products" LEFT OUTER JOIN
-            #   "spree_variants" ON "spree_variants"."product_id" = "spree_products"."id" AND "spree_variants"."is_master" = 't'
-            #   AND "spree_variants"."deleted_at" IS NULL LEFT OUTER JOIN "spree_prices" ON
-            #   "spree_prices"."variant_id" = "spree_variants"."id" AND "spree_prices"."currency" = 'USD'
-            #   AND "spree_prices"."deleted_at" IS NULL WHERE "spree_products"."deleted_at" IS NULL AND ('t'='t')
-            #   ORDER BY "spree_prices"."amount" ASC LIMIT 10 OFFSET 0
-            #
-            # Don't allow sort_column, a variable coming from params,
-            # to be anything but a column in the database
-            if ActiveRecord::Base.connection.adapter_name == 'PostgreSQL' && !column_names.include?(sort_column)
-              all
-            else
-              distinct
-            end
-          end
-
           class << self
             private
 

data/app/models/spree/product.rb

@@ -5,10 +5,6 @@ module Spree
   # variations, called variants. Product properties include description,
   # permalink, availability, shipping category, etc. that do not change by
   # variant.
-  #
-  # @note this model uses {https://github.com/radar/paranoia paranoia}.
-  #   +#destroy+ will only soft-destroy records and the default scope hides
-  #   soft-destroyed records using +WHERE deleted_at IS NULL+.
   class Product < Spree::Base
     extend FriendlyId
     friendly_id :slug_candidates, use: :history
@@ -89,7 +85,6 @@ module Spree
              :has_default_price?,
              :images,
              :price_for,
-             :price_in,
              :rebuild_vat_prices=,
              to: :find_or_build_master
 
@@ -186,19 +181,6 @@ module Spree
       !!discontinue_on&.past?
     end
 
-    # Groups variants by the specified option type.
-    #
-    # @deprecated This method is not called in the Solidus codebase
-    # @param opt_type [String] the name of the option type to group by
-    # @param pricing_options [Spree::Config.pricing_options_class] the pricing options to search
-    #   for, default: the default pricing options
-    # @return [Hash] option_type as keys, array of variants as values.
-    def categorise_variants_from_option(opt_type, pricing_options = Spree::Config.default_pricing_options)
-      return {} unless option_types.include?(opt_type)
-      variants.with_prices(pricing_options).group_by { |variant| variant.option_values.detect { |option| option.option_type == opt_type } }
-    end
-    deprecate :categorise_variants_from_option, deprecator: Spree::Deprecation
-
     # Poor man's full text search.
     #
     # Filters products to those which have any of the strings in +values+ in
@@ -214,17 +196,6 @@ module Spree
       where conditions.inject(:or)
     end
 
-    # @param current_currency [String] currency to filter variants by; defaults to Spree's default
-    # @deprecated This method can only handle prices for currencies
-    # @return [Array<Spree::Variant>] all variants with at least one option value
-    def variants_and_option_values(current_currency = nil)
-      variants.includes(:option_values).active(current_currency).select do |variant|
-        variant.option_values.any?
-      end
-    end
-    deprecate variants_and_option_values: :variants_and_option_values_for,
-              deprecator: Spree::Deprecation
-
     # @param pricing_options [Spree::Variant::PricingOptions] the pricing options to search
     #   for, default: the default pricing options
     # @return [Array<Spree::Variant>] all variants with at least one option value
@@ -296,16 +267,6 @@ module Spree
       end
     end
 
-    # Image that can be used for the product.
-    #
-    # Will first search for images on the product, then those belonging to the
-    # variants. If all else fails, will return a new image object.
-    # @return [Spree::Image] the image to display
-    def display_image
-      Spree::Deprecation.warn('Spree::Product#display_image is DEPRECATED. Choose an image from Spree::Product#gallery instead.')
-      images.first || variant_images.first || Spree::Image.new
-    end
-
     # Finds the variant property rule that matches the provided option value ids.
     #
     # @param option_value_ids [Array<Integer>] list of option value ids

data/app/models/spree/promotion/actions/create_adjustment.rb

@@ -39,9 +39,6 @@ module Spree
         # item_total and ship_total
         def compute_amount(calculable)
           amount = calculator.compute(calculable)
-          if !amount.is_a?(BigDecimal)
-            Spree::Deprecation.warn "#{calculator.class.name}#compute returned #{amount.inspect}, it should return a BigDecimal"
-          end
           amount ||= BigDecimal(0)
           amount = amount.abs
           [(calculable.item_total + calculable.ship_total), amount].min * -1

data/app/models/spree/promotion/actions/create_item_adjustments.rb

@@ -33,9 +33,6 @@ module Spree
           order = adjustable.is_a?(Order) ? adjustable : adjustable.order
           return 0 unless promotion.line_item_actionable?(order, adjustable)
           promotion_amount = calculator.compute(adjustable)
-          if !promotion_amount.is_a?(BigDecimal)
-            Spree::Deprecation.warn "#{calculator.class.name}#compute returned #{promotion_amount.inspect}, it should return a BigDecimal"
-          end
           promotion_amount ||= BigDecimal(0)
           promotion_amount = promotion_amount.abs
           [adjustable.amount, promotion_amount].min * -1

data/app/models/spree/promotion/actions/create_quantity_adjustments.rb

@@ -57,9 +57,6 @@ module Spree
         #
         def compute_amount(line_item)
           adjustment_amount = calculator.compute(PartialLineItem.new(line_item))
-          if !adjustment_amount.is_a?(BigDecimal)
-            Spree::Deprecation.warn "#{calculator.class.name}#compute returned #{adjustment_amount.inspect}, it should return a BigDecimal"
-          end
           adjustment_amount ||= BigDecimal(0)
           adjustment_amount = adjustment_amount.abs
 

data/app/models/spree/promotion/rules/taxon.rb

@@ -38,11 +38,7 @@ module Spree
               eligibility_errors.add(:base, eligibility_error_message(:has_excluded_taxon), error_code: :has_excluded_taxon)
             end
           else
-            # Change this to an exception in a future version of Solidus
-            warn_invalid_match_policy(assume: 'any')
-            unless order_taxons.where(id: rule_taxon_ids_with_children).exists?
-              eligibility_errors.add(:base, eligibility_error_message(:no_matching_taxons), error_code: :no_matching_taxons)
-            end
+            raise "unexpected match policy: #{preferred_match_policy.inspect}"
           end
 
           eligibility_errors.empty?
@@ -60,9 +56,7 @@ module Spree
           when 'none'
             !found
           else
-            # Change this to an exception in a future version of Solidus
-            warn_invalid_match_policy(assume: 'any')
-            found
+            raise "unexpected match policy: #{preferred_match_policy.inspect}"
           end
         end
 
@@ -77,13 +71,6 @@ module Spree
 
         private
 
-        def warn_invalid_match_policy(assume:)
-          Spree::Deprecation.warn(
-            "#{self.class.name} id=#{id} has unexpected match policy #{preferred_match_policy.inspect}. "\
-            "Interpreting it as '#{assume}'."
-          )
-        end
-
         # All taxons in an order
         def taxons_in_order(order)
           Spree::Taxon.joins(products: { variants_including_master: :line_items })

data/app/models/spree/promotion.rb

@@ -38,11 +38,7 @@ module Spree
 
     scope :coupons, -> { joins(:codes).distinct }
     scope :advertised, -> { where(advertise: true) }
-    scope :active, -> do
-      return started_and_unexpired if Spree::Config.consider_actionless_promotion_active == true
-
-      has_actions.started_and_unexpired
-    end
+    scope :active, -> { has_actions.started_and_unexpired }
     scope :started_and_unexpired, -> do
       table = arel_table
       time = Time.current
@@ -93,7 +89,7 @@ module Spree
     end
 
     def active?
-      started? && not_expired? && (Spree::Config.consider_actionless_promotion_active || actions.present?)
+      started? && not_expired? && actions.present?
     end
 
     def inactive?

data/app/models/spree/promotion_action.rb

@@ -1,14 +1,11 @@
 # frozen_string_literal: true
 
-require 'spree/preferences/persistable'
-
 module Spree
   # Base class for all types of promotion action.
   #
   # PromotionActions perform the necessary tasks when a promotion is activated
   # by an event and determined to be eligible.
   class PromotionAction < Spree::Base
-    include Spree::Preferences::Persistable
     include Spree::SoftDeletable
 
     belongs_to :promotion, class_name: 'Spree::Promotion', inverse_of: :promotion_actions, optional: true
@@ -32,15 +29,8 @@ module Spree
     #
     # @param order [Spree::Order] the order to remove the action from
     # @return [void]
-    def remove_from(order)
-      Spree::Deprecation.warn("#{self.class.name.inspect} does not define #remove_from. The default behavior may be incorrect and will be removed in a future version of Solidus.", caller)
-      [order, *order.line_items, *order.shipments].each do |item|
-        item.adjustments.each do |adjustment|
-          if adjustment.source == self
-            item.adjustments.destroy(adjustment)
-          end
-        end
-      end
+    def remove_from(_order)
+      raise 'remove_from should be implemented in a sub-class of PromotionAction'
     end
 
     def to_partial_path

data/app/models/spree/promotion_code/batch_builder.rb

@@ -10,20 +10,6 @@ class ::Spree::PromotionCode::BatchBuilder
     sample_characters: ('a'..'z').to_a + (2..9).to_a.map(&:to_s)
   }
 
-  [:random_code_length, :batch_size, :sample_characters].each do |attr|
-    define_singleton_method(attr) do
-      Spree::Deprecation.warn "#{name}.#{attr} is deprecated. Use #{name}::DEFAULT_OPTIONS[:#{attr}] instead"
-      DEFAULT_OPTIONS[attr]
-    end
-
-    define_singleton_method(:"#{attr}=") do |val|
-      Spree::Deprecation.warn "#{name}.#{attr}= is deprecated. Use #{name}::DEFAULT_OPTIONS[:#{attr}]= instead"
-      DEFAULT_OPTIONS[attr] = val
-    end
-
-    delegate attr, to: self
-  end
-
   def initialize(promotion_code_batch, options = {})
     @promotion_code_batch = promotion_code_batch
     options.assert_valid_keys(*DEFAULT_OPTIONS.keys)

data/app/models/spree/promotion_code.rb

@@ -5,12 +5,12 @@ class Spree::PromotionCode < Spree::Base
   belongs_to :promotion_code_batch, class_name: "Spree::PromotionCodeBatch", optional: true
   has_many :adjustments
 
-  before_validation :normalize_code
-
   validates :value, presence: true, uniqueness: { allow_blank: true, case_sensitive: true }
   validates :promotion, presence: true
   validate :promotion_not_apply_automatically, on: :create
 
+  before_save :normalize_code
+
   self.whitelisted_ransackable_attributes = ['value']
 
   # Whether the promotion code has exceeded its usage restrictions

data/app/models/spree/promotion_rule.rb

@@ -1,12 +1,8 @@
 # frozen_string_literal: true
 
-require 'spree/preferences/persistable'
-
 module Spree
   # Base class for all promotion rules
   class PromotionRule < Spree::Base
-    include Spree::Preferences::Persistable
-
     belongs_to :promotion, class_name: 'Spree::Promotion', inverse_of: :promotion_rules, optional: true
 
     scope :of_type, ->(type) { where(type: type) }

data/app/models/spree/refund.rb

@@ -15,11 +15,6 @@ module Spree
     validate :amount_is_less_than_or_equal_to_allowed_amount, on: :create
 
     attr_reader :perform_response
-    attr_accessor :perform_after_create
-
-    after_create :set_perform_after_create_default
-    after_create :perform!
-    after_create :clear_perform_after_create
 
     scope :non_reimbursement, -> { where(reimbursement_id: nil) }
 
@@ -36,14 +31,6 @@ module Spree
       end
     end
 
-    # Sets this price's amount to a new value, parsing it if the new value is
-    # a string.
-    #
-    # @param price [String, #to_d] a new amount
-    def amount=(price)
-      self[:amount] = Spree::LocalizedNumber.parse(price)
-    end
-
     def description
       payment.payment_method.name
     end
@@ -53,29 +40,14 @@ module Spree
     # Attempts to perform the refund,
     # raises an error if the refund fails.
     def perform!
-      return true if perform_after_create == false
       return true if transaction_id.present?
 
-      # This is needed otherwise set_perform_after_create_default callback
-      # will print a deprecation warning when save! creates a record
-      self.perform_after_create = false unless persisted?
-
       credit_cents = money.cents
 
       @perform_response = process!(credit_cents)
-
-      @response = Spree::DeprecatedInstanceVariableProxy.new(
-        self,
-        :perform_response,
-        :@response,
-        Spree::Deprecation,
-        "Please, do not use Spree::Refund @response anymore, use Spree::Refund#perform_response"
-      )
-
       log_entries.build(details: perform_response.to_yaml)
 
       self.transaction_id = perform_response.authorization
-
       save!
 
       update_order
@@ -83,38 +55,6 @@ module Spree
 
     private
 
-    # This callback takes care of setting the behavior that determines if it is needed
-    # to execute the perform! callback after_create.
-    # Existing code that creates refund without explicitely passing
-    #
-    # perform_after_create: false
-    #
-    # as attribute will still call perform! but a deprecation warning is emitted in order
-    # to ask users to change their code with the new supported behavior.
-    def set_perform_after_create_default
-      return true if perform_after_create == false
-
-      Spree::Deprecation.warn <<-WARN.strip_heredoc, caller
-        From Solidus v3.0 onwards, #perform! will need to be explicitly called when creating new
-        refunds. Please, change your code from:
-
-          Spree::Refund.create(your: attributes)
-
-        to:
-
-          Spree::Refund.create(your: attributes, perform_after_create: false).perform!
-      WARN
-
-      self.perform_after_create = true
-    end
-
-    # This is needed to avoid that when you create a refund with perform_after_create = false,
-    # it's not possibile to call perform! on that instance, since the value of this attribute
-    # will remain false until a reload of the instance.
-    def clear_perform_after_create
-      @perform_after_create = nil
-    end
-
     # return an activemerchant response object if successful or else raise an error
     def process!(credit_cents)
       response = if payment.payment_method.payment_profiles_supported?

data/app/models/spree/reimbursement.rb

@@ -51,14 +51,6 @@ module Spree
     class_attribute :reimbursement_performer
     self.reimbursement_performer = ReimbursementPerformer
 
-    # These are called if the call to "reimburse!" succeeds.
-    class_attribute :reimbursement_success_hooks
-    self.reimbursement_success_hooks = []
-
-    # These are called if the call to "reimburse!" fails.
-    class_attribute :reimbursement_failure_hooks
-    self.reimbursement_failure_hooks = []
-
     include ::Spree::Config.state_machines.reimbursement
 
     class << self
@@ -91,10 +83,7 @@ module Spree
       total - paid_amount
     end
 
-    def perform!(created_by: nil)
-      unless created_by
-        Spree::Deprecation.warn("Calling #perform on #{self} without created_by is deprecated")
-      end
+    def perform!(created_by:)
       reimbursement_tax_calculator.call(self)
       reload
       update!(total: calculated_total)
@@ -104,21 +93,9 @@ module Spree
       if unpaid_amount_within_tolerance?
         reimbursed!
         Spree::Event.fire 'reimbursement_reimbursed', reimbursement: self
-        if reimbursement_success_hooks.any?
-          Spree::Deprecation.warn \
-            "reimbursement_success_hooks are deprecated. Please remove them " \
-            "and subscribe to `reimbursement_reimbursed` event instead", caller(1)
-        end
-        reimbursement_success_hooks.each { |hook| hook.call self }
       else
         errored!
         Spree::Event.fire 'reimbursement_errored', reimbursement: self
-        if reimbursement_failure_hooks.any?
-          Spree::Deprecation.warn \
-            "reimbursement_failure_hooks are deprecated. Please remove them " \
-            "and subscribe to `reimbursement_errored` event instead", caller(1)
-        end
-        reimbursement_failure_hooks.each { |hook| hook.call self }
       end
 
       if errored?
@@ -126,10 +103,7 @@ module Spree
       end
     end
 
-    def simulate(created_by: nil)
-      unless created_by
-        Spree::Deprecation.warn("Calling #simulate on #{self} without created_by is deprecated")
-      end
+    def simulate(created_by:)
       reimbursement_simulator_tax_calculator.call(self)
       reload
       update!(total: calculated_total)
@@ -154,10 +128,7 @@ module Spree
     # @api public
     # @param [Spree.user_class] created_by the user that is performing this action
     # @return [void]
-    def return_all(created_by: nil)
-      unless created_by
-        Spree::Deprecation.warn("Calling #return_all on #{self} without created_by is deprecated")
-      end
+    def return_all(created_by:)
       return_items.each(&:accept!)
       save!
       perform!(created_by: created_by)
@@ -168,15 +139,6 @@ module Spree
     #
     # @return [Spree::StoreCreditCategory]
     def store_credit_category
-      if Spree::Config.use_legacy_store_credit_reimbursement_category_name
-        Spree::Deprecation.warn("Using the legacy reimbursement_category_name is deprecated. "\
-          "Set Spree::Config.use_legacy_store_credit_reimbursement_category_name to false to use "\
-          "the new version instead.", caller)
-
-        name = Spree::StoreCreditCategory.reimbursement_category_name
-        return Spree::StoreCreditCategory.find_by(name: name) || Spree::StoreCreditCategory.first
-      end
-
       Spree::StoreCreditCategory.find_by(name: Spree::StoreCreditCategory::REIMBURSEMENT)
     end
 

data/app/models/spree/reimbursement_performer.rb

@@ -11,18 +11,12 @@ module Spree
       # - #description
       # - #display_amount
       # so they can be displayed in the Admin UI appropriately.
-      def simulate(reimbursement, created_by: nil)
-        unless created_by
-          Spree::Deprecation.warn("Calling #simulate on #{self} without created_by is deprecated")
-        end
+      def simulate(reimbursement, created_by:)
         execute(reimbursement, true, created_by: created_by)
       end
 
       # Actually perform the reimbursement
-      def perform(reimbursement, created_by: nil)
-        unless created_by
-          Spree::Deprecation.warn("Calling #perform on #{self} without created_by is deprecated")
-        end
+      def perform(reimbursement, created_by:)
         execute(reimbursement, false, created_by: created_by)
       end
 

data/app/models/spree/reimbursement_type/credit.rb

@@ -5,10 +5,7 @@ module Spree
     extend Spree::ReimbursementType::ReimbursementHelpers
 
     class << self
-      def reimburse(reimbursement, return_items, simulate, created_by: nil)
-        unless created_by
-          Spree::Deprecation.warn("Calling #reimburse on #{self} without created_by is deprecated")
-        end
+      def reimburse(reimbursement, return_items, simulate, created_by:)
         unpaid_amount = return_items.sum(&:total).round(2, :down)
         reimbursement_list, _unpaid_amount = create_credits(reimbursement, unpaid_amount, simulate, created_by: created_by)
         reimbursement_list

data/app/models/spree/reimbursement_type/reimbursement_helpers.rb

@@ -34,8 +34,7 @@ module Spree
       refund = reimbursement.refunds.build({
         payment: payment,
         amount: amount,
-        reason: Spree::RefundReason.return_processing_reason,
-        perform_after_create: false
+        reason: Spree::RefundReason.return_processing_reason
       })
 
       if simulate