solidus_core 2.11.10 → 3.0.2

data/app/models/spree/promotion_handler/free_shipping.rb

@@ -1,9 +0,0 @@
-# frozen_string_literal: true
-
-module Spree::PromotionHandler
-  FreeShipping = ActiveSupport::Deprecation::DeprecatedConstantProxy.new(
-    'Spree::PromotionHandler::FreeShipping',
-    'Spree::PromotionHandler::Shipping',
-    Spree::Deprecation,
-  )
-end

data/lib/generators/spree/install/install_generator.rb

@@ -1,15 +0,0 @@
-# frozen_string_literal: true
-
-require 'generators/solidus/install/install_generator'
-
-module Spree
-  # @private
-  class InstallGenerator < Solidus::InstallGenerator
-    def print_deprecation_warning
-      puts " "
-      puts "*" * 50
-      puts "spree:install generator is deprecated, please use solidus:install."
-      puts " "
-    end
-  end
-end

data/lib/solidus/migrations/rename_gateways.rb

@@ -1,41 +0,0 @@
-# frozen_string_literal: true
-
-module Solidus
-  module Migrations
-    class RenameGateways
-      DEFAULT_MAPPING = {
-        'Spree::Gateway' => 'Spree::PaymentMethod::CreditCard',
-        'Spree::Gateway::Bogus' => 'Spree::PaymentMethod::BogusCreditCard',
-        'Spree::Gateway::BogusSimple' => 'Spree::PaymentMethod::SimpleBogusCreditCard'
-      }
-
-      attr_reader :gateway_mapping
-
-      def initialize(gateway_mapping = DEFAULT_MAPPING)
-        Spree::Deprecation.warn 'Solidus::Migrations::RenameGateways is deprecated and will be removed with Solidus 3.0.'
-
-        @gateway_mapping = gateway_mapping
-      end
-
-      def up
-        gateway_mapping.inject(0) do |count, mapping|
-          count + update(from: mapping[0], to: mapping[1])
-        end
-      end
-
-      def down
-        gateway_mapping.inject(0) do |count, mapping|
-          count + update(from: mapping[1], to: mapping[0])
-        end
-      end
-
-      private
-
-      def update(from:, to:)
-        ActiveRecord::Base.connection.update <<-SQL.strip_heredoc
-          UPDATE spree_payment_methods SET type = '#{to}' WHERE type = '#{from}';
-        SQL
-      end
-    end
-  end
-end

data/lib/spree/core/current_store.rb

@@ -1,24 +0,0 @@
-# frozen_string_literal: true
-
-# Default class for deciding what the current store is, given an HTTP request
-# This is an extension point used in Spree::Core::ControllerHelpers::Store
-# Custom versions of this class must respond to a store instance method
-module Spree
-  module Core
-    class CurrentStore
-      def initialize(request)
-        @request = request
-        @current_store_selector = Spree::Config.current_store_selector_class.new(request)
-        Spree::Deprecation.warn "Using Spree::Core::CurrentStore is deprecated. Use Spree::Config.current_store_selector_class instead", caller
-      end
-
-      # Delegate store selection to Spree::Config.current_store_selector_class
-      # Using this class is deprecated.
-      #
-      # @return [Spree::Store]
-      def store
-        @current_store_selector.store
-      end
-    end
-  end
-end

data/lib/spree/paranoia_deprecations.rb

@@ -1,41 +0,0 @@
-# frozen_string_literal: true
-
-module Spree
-  module ParanoiaDeprecations
-    module InstanceMethods
-      def paranoia_destroy
-        Spree::Deprecation.warn <<~WARN, caller
-          Calling #destroy (or #paranoia_destroy) on a #{self.class} currently performs a soft-destroy using the paranoia gem.
-          In Solidus 3.0, paranoia will be removed, and this will perform a HARD destroy instead. To continue soft-deleting, use #discard instead.
-        WARN
-        super
-      end
-
-      def paranoia_delete
-        Spree::Deprecation.warn <<~WARN, caller
-          Calling #delete (or #paranoia_delete) on a #{self.class} currently performs a soft-destroy using the paranoia gem.
-          In Solidus 3.0, paranoia will be removed, and this will perform a HARD destroy instead. To continue soft-deleting, use #discard instead.
-        WARN
-        super
-      end
-    end
-
-    module ClassMethods
-      def with_deleted
-        Spree::Deprecation.warn <<~WARN, caller
-          #{self}.with_deleted has been deprecated. Use #{self}.with_discarded instead.
-          In Solidus 3.0, paranoia will be removed, and this method will be replaced by #{self}.with_discarded.
-        WARN
-        super
-      end
-
-      def only_deleted
-        Spree::Deprecation.warn <<~WARN, caller
-          #{self}.only_deleted has been deprecated. Use #{self}.discarded instead.
-          In Solidus 3.0, paranoia will be removed, and this method will be replaced by #{self}.discarded.
-        WARN
-        super
-      end
-    end
-  end
-end

data/lib/spree/promo/environment.rb

@@ -1,12 +0,0 @@
-# frozen_string_literal: true
-
-module Spree
-  module Promo
-    Environment =
-      ActiveSupport::Deprecation::DeprecatedConstantProxy.new(
-        'Spree::Promo::Environment',
-        'Spree::Core::Environment::Promotions',
-        Spree::Deprecation
-      )
-  end
-end

data/lib/spree/testing_support/bar_ability.rb

@@ -1,19 +0,0 @@
-# frozen_string_literal: true
-
-Spree::Deprecation.warn "BarAbility is deprecated. Use stub_authorization! instead"
-
-# Fake ability for testing administration
-# @private
-class BarAbility
-  include CanCan::Ability
-
-  def initialize(user)
-    user ||= Spree::User.new
-    if user.has_spree_role? 'bar'
-      # allow dispatch to :admin, :index, and :show on Spree::Order
-      can [:admin, :index, :show], Spree::Order
-      # allow dispatch to :index, :show, :create and :update shipments on the admin
-      can [:admin, :manage], Spree::Shipment
-    end
-  end
-end

data/lib/tasks/core.rake

@@ -1,104 +0,0 @@
-# frozen_string_literal: true
-
-require 'active_record'
-
-def prompt_for_agree(prompt)
-  print prompt
-  ["y", "yes"].include? STDIN.gets.strip.downcase
-end
-
-namespace :db do
-  desc 'Loads a specified fixture file:
-use rake db:load_file[/absolute/path/to/sample/filename.rb]'
-
-  task :load_file, [:file, :dir] => :environment do |_t, args|
-    Spree::Deprecation.warn("load_file has been deprecated. Please load your own file.")
-    file = Pathname.new(args.file)
-
-    puts "loading ruby #{file}"
-    require file
-  end
-
-  desc "Loads fixtures from the the dir you specify using rake db:load_dir[loadfrom]"
-  task :load_dir, [:dir] => :environment do |_t, args|
-    Spree::Deprecation.warn("rake spree:load_dir has been deprecated and will be removed with Solidus 3.0. Please load your files directly.")
-    dir = args.dir
-    dir = File.join(Rails.root, "db", dir) if Pathname.new(dir).relative?
-
-    ruby_files = {}
-    Dir.glob(File.join(dir, '**/*.{rb}')).each do |fixture_file|
-      ruby_files[File.basename(fixture_file, '.*')] = fixture_file
-    end
-    ruby_files.sort.each do |fixture, ruby_file|
-      # If file is exists within application it takes precendence.
-      if File.exist?(File.join(Rails.root, "db/default/spree", "#{fixture}.rb"))
-        ruby_file = File.expand_path(File.join(Rails.root, "db/default/spree", "#{fixture}.rb"))
-      end
-      # an invoke will only execute the task once
-      Rake::Task["db:load_file"].execute( Rake::TaskArguments.new([:file], [ruby_file]) )
-    end
-  end
-
-  desc "Migrate schema to version 0 and back up again. WARNING: Destroys all data in tables!!"
-  task remigrate: :environment do
-    Spree::Deprecation.warn("remigrate has been deprecated. Please use db:reset or other db: commands instead.")
-
-    if ENV['SKIP_NAG'] || ENV['OVERWRITE'].to_s.casecmp('true') || prompt_for_agree("This task will destroy any data in the database. Are you sure you want to \ncontinue? [y/n] ")
-
-      # Drop all tables
-      ActiveRecord::Base.connection.tables.each { |t| ActiveRecord::Base.connection.drop_table t }
-
-      # Migrate upward
-      Rake::Task["db:migrate"].invoke
-
-      # Dump the schema
-      Rake::Task["db:schema:dump"].invoke
-    else
-      puts "Task cancelled."
-      exit
-    end
-  end
-
-  desc "Bootstrap is: migrating, loading defaults, sample data and seeding (for all extensions) and load_products tasks"
-  task :bootstrap do
-    Spree::Deprecation.warn("rake bootstrap has been deprecated, please run db:setup instead.")
-
-    # remigrate unless production mode (as saftey check)
-    if %w[demo development test].include? Rails.env
-      if ENV['AUTO_ACCEPT'] || prompt_for_agree("This task will destroy any data in the database. Are you sure you want to \ncontinue? [y/n] ")
-        ENV['SKIP_NAG'] = 'yes'
-        Rake::Task["db:create"].invoke
-        Rake::Task["db:remigrate"].invoke
-      else
-        puts "Task cancelled, exiting."
-        exit
-      end
-    else
-      puts "NOTE: Bootstrap in production mode will not drop database before migration"
-      Rake::Task["db:migrate"].invoke
-    end
-
-    ActiveRecord::Base.send(:subclasses).each(&:reset_column_information)
-
-    load_defaults = Spree::Country.count == 0
-    load_defaults ||= prompt_for_agree('Countries present, load sample data anyways? [y/n]: ')
-    if load_defaults
-      Rake::Task["db:seed"].invoke
-    end
-
-    if Rails.env.production? && Spree::Product.count > 0
-      load_sample = prompt_for_agree("WARNING: In Production and products exist in database, load sample data anyways? [y/n]:" )
-    else
-      load_sample = true if ENV['AUTO_ACCEPT']
-      load_sample ||= prompt_for_agree('Load Sample Data? [y/n]: ')
-    end
-
-    if load_sample
-      # Reload models' attributes in case they were loaded in old migrations with wrong attributes
-      ActiveRecord::Base.descendants.each(&:reset_column_information)
-      Rake::Task["spree_sample:load"].invoke
-    end
-
-    puts "Bootstrap Complete.\n\n"
-  end
-end

data/lib/tasks/email.rake

@@ -1,12 +0,0 @@
-# frozen_string_literal: true
-
-namespace :email do
-  desc 'Sends test email to specified address - Example: EMAIL=solidus@example.com bundle exec rake email:test'
-  task test: :environment do
-    Spree::Deprecation.warn("rake email:test has been deprecated and will be removed with Solidus 3.0")
-
-    raise ArgumentError, "Must pass EMAIL environment variable. Example: EMAIL=solidus@example.com bundle exec rake email:test" if ENV['EMAIL'].blank?
-
-    Spree::TestMailer.test_email(ENV['EMAIL']).deliver!
-  end
-end

data/lib/tasks/migrations/copy_order_bill_address_to_credit_card.rake

@@ -1,119 +0,0 @@
-# frozen_string_literal: true
-
-namespace 'spree:migrations:copy_order_bill_address_to_credit_card' do
-  # This copies the billing address from the order associated with a
-  # credit card's most recent payment to the credit card.
-
-  # Used in the migration CopyOrderBillAddressToCreditCard and made available as a
-  # rake task to allow running it a second time after deploying the new code, in
-  # case some order->credit card data was missed between the time that the
-  # migration was run and the application servers were restarted with the new
-  # code.
-
-  # This task should be safe to run multiple times.
-
-  task up: :environment do
-    Spree::Deprecation.warn("rake spree:migrations:copy_order_bill_address_to_credit_card:up has been deprecated and will be removed with Solidus 3.0.")
-
-    if Spree::CreditCard.connection.adapter_name =~ /postgres/i
-      postgres_copy
-    else
-      ruby_copy
-    end
-  end
-
-  task down: :environment do
-    Spree::Deprecation.warn("rake spree:migrations:copy_order_bill_address_to_credit_card:down has been deprecated and will be removed with Solidus 3.0.")
-
-    Spree::CreditCard.update_all(address_id: nil)
-  end
-
-  def ruby_copy
-    scope = Spree::CreditCard.where(address_id: nil).includes(payments: :order)
-
-    scope.find_each(batch_size: 500) do |cc|
-      # remove payments that lack a bill address
-      payments = cc.payments.select { |p| p.order.bill_address_id }
-
-      payment = payments.sort_by do |p|
-        [
-          %w(failed invalid).include?(p.state) ? 0 : 1, # prioritize valid payments
-          p.created_at, # prioritize more recent payments
-        ]
-      end.last
-
-      next if payment.nil?
-
-      cc.update_column(:address_id, payment.order.bill_address_id)
-      puts "Successfully associated billing address (#{payment.order.bill_address_id}) with credit card (#{cc.id})"
-    end
-  end
-
-  # This was 20x faster for us but the syntax is postgres-specific. I'm sure
-  # there are equivalent versions for other DBs if someone wants to write them.
-  # I took a quick stab at crafting a cross-db compatible version but it was
-  # slow.
-  def postgres_copy
-    batch_size = 10_000
-
-    current_start_id = 1
-
-    while current_start_id <= last_credit_card_id
-      current_end_id = current_start_id + batch_size
-      puts "updating #{current_start_id} to #{current_end_id}"
-
-      # first try to find a valid payment for each credit card
-      Spree::CreditCard.connection.execute(
-        postgres_sql(
-          start_id: current_start_id,
-          end_id: current_end_id,
-          payment_state: "not in ('failed', 'invalid')"
-        )
-      )
-
-      # fall back to using invalid payments for each credit card
-      Spree::CreditCard.connection.execute(
-        postgres_sql(
-          start_id: current_start_id,
-          end_id: current_end_id,
-          payment_state: "in ('failed', 'invalid')"
-        )
-      )
-
-      current_start_id += batch_size
-    end
-  end
-
-  def postgres_sql(start_id:, end_id:, payment_state:)
-    <<-SQL
-      update spree_credit_cards c
-      set address_id = o.bill_address_id
-      from spree_payments p
-      inner join spree_orders o
-        on  o.id = p.order_id
-        and o.bill_address_id is not null
-      left join (
-        select p2.*
-        from spree_payments p2
-        inner join spree_orders o2
-          on  o2.id = p2.order_id
-          and o2.bill_address_id is not null
-      ) more_recent_payment
-        on  more_recent_payment.source_id = p.source_id
-        and more_recent_payment.source_type = 'Spree::CreditCard'
-        and more_recent_payment.created_at > p.created_at
-        and more_recent_payment.state #{payment_state}
-      where c.address_id is null
-        and p.source_id = c.id
-        and p.source_type = 'Spree::CreditCard'
-        and p.state #{payment_state}
-        and more_recent_payment.id is null
-        and o.bill_address_id is not null
-        and c.id between #{start_id} and #{end_id}
-    SQL
-  end
-
-  def last_credit_card_id
-    Spree::CreditCard.last.try!(:id) || 0
-  end
-end

data/lib/tasks/migrations/migrate_address_names.rake

@@ -1,158 +0,0 @@
-# frozen_string_literal: true
-
-require 'thor'
-
-namespace :solidus do
-  namespace :migrations do
-    namespace :migrate_address_names do
-      desc 'Backfills Spree::Address name attribute using firstname and lastname
-        concatenation in order to retain historical data when upgrading to new
-        address name format'
-      task up: :environment do
-        puts "Combining addresses' firstname and lastname into name ... "
-        class Spree::AddressForMigration < ApplicationRecord
-          self.table_name = 'spree_addresses'
-        end
-
-        records = Spree::AddressForMigration.unscoped.where(name: [nil, ''])
-        count = records.count
-        connection = ActiveRecord::Base.connection
-        adapter_name = connection.adapter_name.downcase
-        shell = Thor::Shell::Basic.new
-        puts "  Your DB contains #{count} addresses that may be affected by this task."
-        # `trim` is not needed for pg or mysql when using `concat_ws`:
-        # select concat_ws('joinstring', 'foo', null);
-        #  concat_ws
-        # -----------
-        #  foo
-        # (1 row)
-        # select concat_ws('joinstring', 'foo', null) = trim(concat_ws('joinstring', 'foo', null));
-        #  ?column?
-        # ----------
-        #  t
-        # (1 row)
-        unless count.zero?
-          concat_statement = begin
-            case adapter_name
-            when /sqlite/
-              "name = TRIM(COALESCE(firstname, '') || ' ' || COALESCE(lastname, ''))"
-            when /postgres/, /mysql2/
-              "name = CONCAT_WS(' ', firstname, lastname)"
-            else
-              abort "  No migration path available for adapter #{adapter_name}. Please write your own."
-            end
-          end
-
-          # The batch size should be limited to avoid locking the table records for too long. These are
-          # the numbers I got with 1_000_000 records in `spree_addresses`, all with different name and
-          # surname, with postgresql:
-          #
-          # Updating 1000000 records in one shot
-          # batch took 178 seconds
-          #
-          # Updating 1000000 addresses in batches of 200000
-          # batch took 36 seconds
-          # batch took 31 seconds
-          # batch took 31 seconds
-          # batch took 31 seconds
-          # batch took 30 seconds
-          #
-          # Updating 1000000 addresses in batches of 150000
-          # batch took 29 seconds
-          # batch took 27 seconds
-          # batch took 27 seconds
-          # batch took 27 seconds
-          # batch took 26 seconds
-          # batch took 26 seconds
-          # batch took 19 seconds
-          #
-          # Updating 1000000 addresses in batches of 100000
-          # batch took 17 seconds
-          # batch took 15 seconds
-          # batch took 17 seconds
-          # batch took 17 seconds
-          # batch took 17 seconds
-          # batch took 17 seconds
-          # batch took 17 seconds
-          # batch took 17 seconds
-          # batch took 17 seconds
-          # batch took 17 seconds
-          #
-          # This is with mysql:
-          # Updating 1000000 records in one shot
-          # batch updated in 153 seconds
-          #
-          # Updating 1000000 records in batches of 200000, this may take a while...
-          # batch took 41 seconds
-          # batch took 37 seconds
-          # batch took 35 seconds
-          # batch took 28 seconds
-          # batch took 27 seconds
-          #
-          # Updating 1000000 records in batches of 150000, this may take a while...
-          # batch took 30 seconds
-          # batch took 29 seconds
-          # batch took 18 seconds
-          # batch took 18 seconds
-          # batch took 17 seconds
-          # batch took 29 seconds
-          # batch took 12 seconds
-          #
-          # Updating 1000000 records in batches of 100000, this may take a while...
-          # batch took 10 seconds
-          # batch took 11 seconds
-          # batch took 12 seconds
-          # batch took 13 seconds
-          # batch took 12 seconds
-          # batch took 12 seconds
-          # batch took 14 seconds
-          # batch took 19 seconds
-          # batch took 20 seconds
-          # batch took 21 seconds
-          #
-          # Please note that the migration will be much faster when there's no index
-          # on the `name` column. For example, with mysql each batch takes exactly
-          # the same time:
-          #
-          # Updating 1000000 records in batches of 200000, this may take a while...
-          # batch took 17 seconds
-          # batch took 17 seconds
-          # batch took 17 seconds
-          # batch took 16 seconds
-          # batch took 17 seconds
-          #
-          # So, if special need arise, one can drop the index added with migration
-          # 20210122110141_add_name_to_spree_addresses.rb and add the index later,
-          # in non blocking ways. For postgresql:
-          # add_index(:spree_addresses, :name, algorithm: :concurrently)
-          #
-          # For mysql 5.6:
-          # sql = "ALTER TABLE spree_addresses ADD INDEX index_spree_addresses_on_name (name), ALGORITHM=INPLACE, LOCK=NONE;"
-          # ActiveRecord::Base.connection.execute sql
-          #
-          puts '  Data migration will happen in batches. The default value is 100_000, which should take less than 20 seconds on mysql or postgresql.'
-          size = shell.ask('  Please enter a different batch size, or press return to confirm the default: ')
-          size = (size.presence || 100_000).to_i
-
-          abort "  Invalid batch size number #{size}, please run the task again." unless size.positive?
-
-          batches_total = (count / size).ceil
-          puts "  We're going to migrate #{count} records in #{batches_total} batches of #{size}."
-
-          answer = shell.ask('  Do you want to proceed?', limited_to: ['Y', 'N'], case_insensitive: true)
-          if answer == 'Y'
-            puts "  Updating #{count} records in batches of #{size}, this may take a while..."
-
-            records.in_batches(of: size).each.with_index(1) do |batch, index|
-              now = Time.zone.now
-              batch.update_all(concat_statement)
-              puts "  Batch #{index}/#{batches_total} done in #{(Time.zone.now - now).to_i} seconds."
-            end
-          else
-            puts "  Database not migrated. Please, make sure to fill address's name field on your own."
-          end
-        end
-      end
-    end
-  end
-end