solidus_core 1.1.4 → 1.2.0.beta1

data/spec/helpers/products_helper_spec.rb

@@ -42,7 +42,7 @@ module Spree
           let(:variant_price) { 15 }
 
           it { is_expected.to eq("(Add: $5.00)") }
-          # Regression test for #2737
+          # Regression test for https://github.com/spree/spree/issues/2737
           it { is_expected.to be_html_safe }
         end
 
@@ -119,7 +119,7 @@ module Spree
 
 
     context "#product_description" do
-      # Regression test for #1607
+      # Regression test for https://github.com/spree/spree/issues/1607
       it "renders a product description without excessive paragraph breaks" do
         product.description = %Q{
 <p>Lorem ipsum dolor sit amet, consectetur adipiscing elit. Vivamus a ligula leo. Proin eu arcu at ipsum dapibus ullamcorper. Pellentesque egestas orci nec magna condimentum luctus. Cum sociis natoque penatibus et magnis dis parturient montes, nascetur ridiculus mus. Ut ac ante et mauris bibendum ultricies non sed massa. Fusce facilisis dui eget lacus scelerisque eget aliquam urna ultricies. Duis et rhoncus quam. Praesent tellus nisi, ultrices sed iaculis quis, euismod interdum ipsum.</p>

data/spec/helpers/taxons_helper_spec.rb

@@ -1,7 +1,7 @@
 require 'spec_helper'
 
 describe Spree::TaxonsHelper, :type => :helper do
-  # Regression test for #4382
+  # Regression test for https://github.com/spree/spree/issues/4382
   it "#taxon_preview" do
     taxon = create(:taxon)
     child_taxon = create(:taxon, parent: taxon)

data/spec/lib/spree/core/controller_helpers/payment_parameters_spec.rb

@@ -5,17 +5,13 @@ class FakeController < ApplicationController
 end
 
 describe Spree::Core::ControllerHelpers::PaymentParameters, type: :controller do
-  subject do
-    controller.move_payment_source_into_payments_attributes(params)
-  end
 
   controller(FakeController) { }
 
   describe '#move_payment_source_into_payments_attributes' do
-    let(:payment_method_1) { create(:credit_card_payment_method) }
-    let(:payment_method_2) { create(:credit_card_payment_method) }
-    let(:credit_card_1_params) { attributes_for(:credit_card, name: 'Jordan1') }
-    let(:credit_card_2_params) { attributes_for(:credit_card, name: 'Jordan2') }
+    subject do
+      controller.move_payment_source_into_payments_attributes(params)
+    end
 
     let(:params) do
       ActionController::Parameters.new(
@@ -35,6 +31,11 @@ describe Spree::Core::ControllerHelpers::PaymentParameters, type: :controller do
       )
     end
 
+    let(:payment_method_1) { create(:credit_card_payment_method) }
+    let(:payment_method_2) { create(:credit_card_payment_method) }
+    let(:credit_card_1_params) { attributes_for(:credit_card, name: 'Jordan1') }
+    let(:credit_card_2_params) { attributes_for(:credit_card, name: 'Jordan2') }
+
     it 'produces the expected hash' do
       expect(subject).to eq(
         ActionController::Parameters.new(
@@ -77,4 +78,103 @@ describe Spree::Core::ControllerHelpers::PaymentParameters, type: :controller do
       it('returns the original hash') { expect(subject).to eq(params) }
     end
   end
+
+  describe '#move_existing_card_into_payments_attributes' do
+    subject do
+      controller.move_existing_card_into_payments_attributes(params)
+    end
+
+    let(:params) do
+      ActionController::Parameters.new(
+        order: {
+          existing_card: '123',
+          other_order_param: 1,
+        },
+        cvc_confirm: '456',
+        other_param: 2,
+      )
+    end
+
+    it 'produces the expected hash' do
+      expect(subject).to eq(
+        ActionController::Parameters.new(
+          order: {
+            payments_attributes: [
+              {
+                source_attributes: {
+                  existing_card_id: '123',
+                  verification_value: '456'
+                },
+              },
+            ],
+            other_order_param: 1,
+          },
+          other_param: 2,
+        )
+      )
+    end
+
+    context 'when cvc_confirm is missing' do
+      before { params.delete(:cvc_confirm) }
+
+      it 'produces the expected hash' do
+        expect(subject).to eq(
+          ActionController::Parameters.new(
+            order: {
+              payments_attributes: [
+                {
+                  source_attributes: {
+                    existing_card_id: '123',
+                    verification_value: nil,
+                  },
+                },
+              ],
+              other_order_param: 1,
+            },
+            other_param: 2,
+          )
+        )
+      end
+    end
+
+    context 'when order params are missing' do
+      before { params.delete(:order) }
+      it('returns the original hash') { expect(subject).to eq(params) }
+    end
+
+    context 'when existing_card is missing' do
+      before { params[:order].delete(:existing_card) }
+      it('returns the original hash') { expect(subject).to eq(params) }
+    end
+
+  end
+
+  describe '#set_payment_parameters_amount' do
+    subject do
+      controller.set_payment_parameters_amount(params, order)
+    end
+
+    let(:params) do
+      ActionController::Parameters.new(
+        order: {
+          payments_attributes: [{}],
+          other_order_param: 1,
+        },
+        other_param: 2,
+      )
+    end
+    let(:order) { create(:order_with_line_items, line_items_price: 101.00, line_items_count: 1, shipment_cost: 0) }
+
+    it 'produces the expected hash' do
+      expect(subject).to eq(
+        ActionController::Parameters.new(
+          order: {
+            payments_attributes: [{amount: 101}],
+            other_order_param: 1,
+          },
+          other_param: 2,
+        )
+      )
+    end
+  end
 end

data/spec/lib/spree/core/importer/order_spec.rb

@@ -46,7 +46,7 @@ module Spree
 
       it 'optionally add completed at' do
         params = { email: 'test@test.com',
-                   completed_at: Time.now,
+                   completed_at: Time.current,
                    line_items_attributes: line_items }
         order = Importer::Order.import(user,params)
         expect(order).to be_completed

data/spec/lib/spree/core/stock_configuration_spec.rb

@@ -0,0 +1,16 @@
+require 'spec_helper'
+
+RSpec.describe Spree::StockConfiguration do
+  before(:all) { @estimator_class = described_class.estimator_class.to_s }
+  after(:all)  { described_class.estimator_class = @estimator_class }
+
+  describe '.estimator_class' do
+    subject { described_class.estimator_class }
+    let(:foo) { Struct.new :foo }
+
+    before { described_class.estimator_class = 'Foo' }
+    before { Foo = foo }
+
+    it { is_expected.to eq foo }
+  end
+end

data/spec/lib/spree/core/testing_support/factories/address_factory_spec.rb

@@ -0,0 +1,24 @@
+require 'spec_helper'
+require 'spree/testing_support/factories/address_factory'
+
+RSpec.describe 'address factory' do
+  let(:factory_class) { Spree::Address }
+
+  describe 'plain address' do
+    let(:factory) { :address }
+
+    it_behaves_like 'a working factory'
+  end
+
+  describe 'ship_address' do
+    let(:factory) { :ship_address }
+
+    it_behaves_like 'a working factory'
+  end
+
+  describe 'bill address' do
+    let(:factory) { :bill_address }
+
+    it_behaves_like 'a working factory'
+  end
+end

data/spec/lib/spree/core/testing_support/factories/adjustment_factory_spec.rb

@@ -0,0 +1,18 @@
+require 'spec_helper'
+require 'spree/testing_support/factories/adjustment_factory'
+
+RSpec.describe 'adjustment factory' do
+  let(:factory_class) { Spree::Adjustment }
+
+  describe 'plain adjustment' do
+    let(:factory) { :adjustment }
+
+    it_behaves_like 'a working factory'
+  end
+
+  describe 'tax adjustment' do
+    let(:factory) { :tax_adjustment }
+
+    it_behaves_like 'a working factory'
+  end
+end

data/spec/lib/spree/core/testing_support/factories/adjustment_reason_factory_spec.rb

@@ -0,0 +1,12 @@
+require 'spec_helper'
+require 'spree/testing_support/factories/adjustment_reason_factory'
+
+RSpec.describe 'adjustment reason factory' do
+  let(:factory_class) { Spree::AdjustmentReason }
+
+  describe 'adjustment reason' do
+    let(:factory) { :adjustment_reason }
+
+    it_behaves_like 'a working factory'
+  end
+end

data/spec/lib/spree/core/testing_support/factories/calculator_factory_spec.rb

@@ -0,0 +1,42 @@
+require 'spec_helper'
+require 'spree/testing_support/factories/calculator_factory'
+
+RSpec.describe 'calculator factory' do
+  let(:factory_class) { Spree::Calculator }
+
+  describe 'calculator' do
+    let(:factory) { :calculator }
+
+    it_behaves_like 'a working factory'
+  end
+
+  describe 'no amount calculator' do
+    let(:factory) { :no_amount_calculator }
+
+    it_behaves_like 'a working factory'
+  end
+
+  describe 'default_tax_calculator' do
+    let(:factory) { :default_tax_calculator }
+
+    it_behaves_like 'a working factory'
+  end
+
+  describe 'shipping calculator' do
+    let(:factory) { :shipping_calculator }
+
+    it_behaves_like 'a working factory'
+  end
+
+  describe 'shipping no amount calculator' do
+    let(:factory) { :shipping_no_amount_calculator }
+
+    it_behaves_like 'a working factory'
+  end
+
+  describe 'percent on item calculator' do
+    let(:factory) { :percent_on_item_calculator }
+
+    it_behaves_like 'a working factory'
+  end
+end

data/spec/lib/spree/core/testing_support/factories/carton_factory_spec.rb

@@ -0,0 +1,12 @@
+require 'spec_helper'
+require 'spree/testing_support/factories/carton_factory'
+
+RSpec.describe 'carton factory' do
+  let(:factory_class) { Spree::Carton }
+
+  describe 'plain adjustment' do
+    let(:factory) { :carton }
+
+    it_behaves_like 'a working factory'
+  end
+end

data/spec/lib/spree/core/testing_support/factories/country_factory_spec.rb

@@ -0,0 +1,12 @@
+require 'spec_helper'
+require 'spree/testing_support/factories/country_factory'
+
+RSpec.describe 'country factory' do
+  let(:factory_class) { Spree::Country }
+
+  describe 'plain adjustment' do
+    let(:factory) { :country }
+
+    it_behaves_like 'a working factory'
+  end
+end

data/spec/lib/spree/core/testing_support/factories/credit_card_factory_spec.rb

@@ -0,0 +1,12 @@
+require 'spec_helper'
+require 'spree/testing_support/factories/credit_card_factory'
+
+RSpec.describe 'credit card factory' do
+  let(:factory_class) { Spree::CreditCard }
+
+  describe 'plain credit card' do
+    let(:factory) { :credit_card }
+
+    it_behaves_like 'a working factory'
+  end
+end

data/spec/lib/spree/core/testing_support/factories/customer_return_factory_spec.rb

@@ -0,0 +1,28 @@
+require 'spec_helper'
+require 'spree/testing_support/factories/customer_return_factory'
+
+RSpec.describe 'customer return factory' do
+  let(:factory_class) { Spree::CustomerReturn }
+
+  describe 'customer return' do
+    let(:factory) { :customer_return }
+
+    it_behaves_like 'a working factory'
+  end
+
+  describe 'customer return with accepted items' do
+    let(:factory) { :customer_return_with_accepted_items }
+
+    it_behaves_like 'a working factory'
+  end
+
+  describe 'customer return without return items' do
+    let(:factory) { :customer_return_without_return_items }
+
+    it "builds successfully" do
+      expect(build factory).to be_a(factory_class)
+    end
+
+    # No create test, because this factory is (intentionally) invalid
+  end
+end

data/spec/lib/spree/core/testing_support/factories/image_factory_spec.rb

@@ -0,0 +1,12 @@
+require 'spec_helper'
+require 'spree/testing_support/factories/image_factory'
+
+RSpec.describe 'image factory' do
+  let(:factory_class) { Spree::Image }
+
+  describe 'plain adjustment' do
+    let(:factory) { :image }
+
+    it_behaves_like 'a working factory'
+  end
+end

data/spec/lib/spree/core/testing_support/factories/inventory_unit_factory_spec.rb

@@ -0,0 +1,12 @@
+require 'spec_helper'
+require 'spree/testing_support/factories/inventory_unit_factory'
+
+RSpec.describe 'inventory unit factory' do
+  let(:factory_class) { Spree::InventoryUnit }
+
+  describe 'plain inventory unit' do
+    let(:factory) { :inventory_unit }
+
+    it_behaves_like 'a working factory'
+  end
+end

data/spec/lib/spree/core/testing_support/factories/line_item_factory_spec.rb

@@ -0,0 +1,12 @@
+require 'spec_helper'
+require 'spree/testing_support/factories/line_item_factory'
+
+RSpec.describe 'line item factory' do
+  let(:factory_class) { Spree::LineItem }
+
+  describe 'plain inventory unit' do
+    let(:factory) { :line_item }
+
+    it_behaves_like 'a working factory'
+  end
+end

data/spec/lib/spree/core/testing_support/factories/option_type_factory_spec.rb

@@ -0,0 +1,12 @@
+require 'spec_helper'
+require 'spree/testing_support/factories/option_type_factory'
+
+RSpec.describe 'option type factory' do
+  let(:factory_class) { Spree::OptionType }
+
+  describe 'plain option type' do
+    let(:factory) { :option_type }
+
+    it_behaves_like 'a working factory'
+  end
+end

data/spec/lib/spree/core/testing_support/factories/option_value_factory_spec.rb

@@ -0,0 +1,12 @@
+require 'spec_helper'
+require 'spree/testing_support/factories/option_value_factory'
+
+RSpec.describe 'option value factory' do
+  let(:factory_class) { Spree::OptionValue }
+
+  describe 'plain option value' do
+    let(:factory) { :option_value }
+
+    it_behaves_like 'a working factory'
+  end
+end

data/spec/lib/spree/core/testing_support/factories/order_factory_spec.rb

@@ -0,0 +1,49 @@
+require 'spec_helper'
+require 'spree/testing_support/factories/order_factory'
+
+RSpec.describe 'order factory' do
+  let(:factory_class) { Spree::Order }
+
+  describe 'plain order' do
+    let(:factory) { :order }
+
+    it_behaves_like 'a working factory'
+  end
+
+
+  describe 'order with totals' do
+    let(:factory) { :order_with_totals }
+
+    it_behaves_like 'a working factory'
+  end
+
+  describe 'order with line items' do
+    let(:factory) { :order_with_line_items }
+
+    it_behaves_like 'a working factory'
+  end
+
+  describe 'completed order with totals' do
+    let(:factory) { :completed_order_with_totals }
+
+    it_behaves_like 'a working factory'
+  end
+
+  describe 'completed order with pending payment' do
+    let(:factory) { :completed_order_with_pending_payment }
+
+    it_behaves_like 'a working factory'
+  end
+
+  describe 'order ready to ship' do
+    let(:factory) { :order_ready_to_ship }
+
+    it_behaves_like 'a working factory'
+  end
+
+  describe 'shipped order' do
+    let(:factory) { :shipped_order }
+
+    it_behaves_like 'a working factory'
+  end
+end