solidus_core 1.0.7 → 1.1.0.beta1

data/spec/models/spree/user_spec.rb

@@ -1,223 +0,0 @@
-require 'spec_helper'
-
-describe Spree::LegacyUser, :type => :model do
-  context "#last_incomplete_order" do
-    let!(:user) { create(:user) }
-
-
-    it "excludes orders that are not frontend_viewable" do
-      order = create(:order, user: user, frontend_viewable: false)
-      expect(user.last_incomplete_spree_order).to eq nil
-    end
-
-    it "can include orders that are not frontend viewable" do
-      order = create(:order, user: user, frontend_viewable: false)
-      expect(user.last_incomplete_spree_order(only_frontend_viewable: false)).to eq order
-    end
-
-    it "can scope to a store" do
-      store = create(:store)
-      store_1_order = create(:order, user: user, store: store)
-      store_2_order = create(:order, user: user, store: create(:store))
-      expect(user.last_incomplete_spree_order(store: store)).to eq store_1_order
-    end
-
-    it "excludes completed orders" do
-      order = create(:completed_order_with_totals, user: user, created_by: user)
-      expect(user.last_incomplete_spree_order).to eq nil
-    end
-
-    it "excludes orders created prior to the user's last completed order" do
-      incomplete_order = create(:order, user: user, created_by: user, created_at: 1.second.ago)
-      completed_order = create(:completed_order_with_totals, user: user, created_by: user)
-      expect(user.last_incomplete_spree_order).to eq nil
-    end
-
-    it "chooses the most recently created incomplete order" do
-      order_1 = create(:order, user: user, created_at: 1.second.ago)
-      order_2 = create(:order, user: user)
-      expect(user.last_incomplete_spree_order).to eq order_2
-    end
-
-    context "persists order address" do
-      let!(:order) { create(:order, bill_address: create(:address), ship_address: create(:address)) }
-
-      it "copies over order addresses" do
-        expect {
-          user.persist_order_address(order)
-        }.to change { Spree::Address.count }.by(2)
-
-        expect(user.bill_address).to eq order.bill_address
-        expect(user.ship_address).to eq order.ship_address
-      end
-
-      it "doesnt create new addresses if user has already" do
-        user.update_column(:bill_address_id, create(:address))
-        user.update_column(:ship_address_id, create(:address))
-        user.reload
-
-        expect {
-          user.persist_order_address(order)
-        }.not_to change { Spree::Address.count }
-      end
-
-      it "set both bill and ship address id on subject" do
-        user.persist_order_address(order)
-
-        expect(user.bill_address_id).not_to be_blank
-        expect(user.ship_address_id).not_to be_blank
-      end
-    end
-
-    context "payment source" do
-      let(:payment_method) { create(:credit_card_payment_method) }
-      let!(:cc) do
-        create(:credit_card, user_id: user.id, payment_method: payment_method, gateway_customer_profile_id: "2342343")
-      end
-
-      it "has payment sources" do
-        expect(user.payment_sources.first.gateway_customer_profile_id).not_to be_empty
-      end
-
-      it "drops payment source" do
-        user.drop_payment_source cc
-        expect(cc.gateway_customer_profile_id).to be_nil
-      end
-    end
-  end
-end
-
-describe Spree.user_class, :type => :model do
-  context "reporting" do
-    let(:order_value) { BigDecimal.new("80.94") }
-    let(:order_count) { 4 }
-    let(:orders) { Array.new(order_count, double(total: order_value)) }
-
-    before do
-      allow(orders).to receive(:pluck).with(:total).and_return(orders.map(&:total))
-      allow(orders).to receive(:count).and_return(orders.length)
-    end
-
-    def load_orders
-      allow(subject).to receive(:spree_orders).and_return(double(complete: orders))
-    end
-
-    describe "#lifetime_value" do
-      context "with orders" do
-        before { load_orders }
-        it "returns the total of completed orders for the user" do
-          expect(subject.lifetime_value).to eq (order_count * order_value)
-        end
-      end
-      context "without orders" do
-        it "returns 0.00" do
-          expect(subject.lifetime_value).to eq BigDecimal("0.00")
-        end
-      end
-    end
-
-    describe "#display_lifetime_value" do
-      it "returns a Spree::Money version of lifetime_value" do
-        value = BigDecimal("500.05")
-        allow(subject).to receive(:lifetime_value).and_return(value)
-        expect(subject.display_lifetime_value).to eq Spree::Money.new(value)
-      end
-    end
-
-    describe "#order_count" do
-      before { load_orders }
-      it "returns the count of completed orders for the user" do
-        expect(subject.order_count).to eq BigDecimal(order_count)
-      end
-    end
-
-    describe "#average_order_value" do
-      context "with orders" do
-        before { load_orders }
-        it "returns the average completed order price for the user" do
-          expect(subject.average_order_value).to eq order_value
-        end
-      end
-      context "without orders" do
-        it "returns 0.00" do
-          expect(subject.average_order_value).to eq BigDecimal("0.00")
-        end
-      end
-    end
-
-    describe "#display_average_order_value" do
-      before { load_orders }
-      it "returns a Spree::Money version of average_order_value" do
-        value = BigDecimal("500.05")
-        allow(subject).to receive(:average_order_value).and_return(value)
-        expect(subject.display_average_order_value).to eq Spree::Money.new(value)
-      end
-    end
-  end
-
-  describe "#total_available_store_credit" do
-    context "user does not have any associated store credits" do
-      subject { create(:user) }
-
-      it "returns 0" do
-        expect(subject.total_available_store_credit).to be_zero
-      end
-    end
-
-    context "user has several associated store credits" do
-      let(:user)                     { create(:user) }
-      let(:amount)                   { 120.25 }
-      let(:additional_amount)        { 55.75 }
-      let(:store_credit)             { create(:store_credit, user: user, amount: amount, amount_used: 0.0) }
-      let!(:additional_store_credit) { create(:store_credit, user: user, amount: additional_amount, amount_used: 0.0) }
-
-      subject { store_credit.user }
-
-      context "part of the store credit has been used" do
-        let(:amount_used) { 35.00 }
-
-        before { store_credit.update_attributes(amount_used: amount_used) }
-
-        context "part of the store credit has been authorized" do
-          let(:authorized_amount) { 10 }
-
-          before { additional_store_credit.update_attributes(amount_authorized: authorized_amount) }
-
-          it "returns sum of amounts minus used amount and authorized amount" do
-            expect(subject.total_available_store_credit.to_f).to eq (amount + additional_amount - amount_used - authorized_amount)
-          end
-        end
-
-        context "there are no authorized amounts on any of the store credits" do
-          it "returns sum of amounts minus used amount" do
-            expect(subject.total_available_store_credit.to_f).to eq (amount + additional_amount - amount_used)
-          end
-        end
-      end
-
-      context "store credits have never been used" do
-        context "part of the store credit has been authorized" do
-          let(:authorized_amount) { 10 }
-
-          before { additional_store_credit.update_attributes(amount_authorized: authorized_amount) }
-
-          it "returns sum of amounts minus authorized amount" do
-            expect(subject.total_available_store_credit.to_f).to eq (amount + additional_amount - authorized_amount)
-          end
-        end
-
-        context "there are no authorized amounts on any of the store credits" do
-          it "returns sum of amounts" do
-            expect(subject.total_available_store_credit.to_f).to eq (amount + additional_amount)
-          end
-        end
-      end
-
-      context "all store credits have never been used or authorized" do
-        it "returns sum of amounts" do
-          expect(subject.total_available_store_credit.to_f).to eq (amount + additional_amount)
-        end
-      end
-    end
-  end
-end

data/spec/models/spree/validations/db_maximum_length_validator_spec.rb

@@ -1,23 +0,0 @@
-require 'spec_helper'
-
-describe Spree::Validations::DbMaximumLengthValidator, type: :model do
-  context 'when Spree::Product' do
-    Spree::Product.class_eval do
-      attribute :slug, ActiveRecord::Type::String.new(limit: 255)
-      # Slug currently has no validation for maximum length
-      validates_with Spree::Validations::DbMaximumLengthValidator, field: :slug
-    end
-    let(:limit) { 255 }
-    let(:product) { Spree::Product.new }
-    let(:slug) { "x" * (limit + 1)}
-
-    before do
-      product.slug = slug
-    end
-
-    it 'should maximum validate slug' do
-      product.valid?
-      expect(product.errors[:slug]).to include(I18n.t("errors.messages.too_long", count: limit))
-    end
-  end
-end

data/spec/models/spree/variant/scopes_spec.rb

@@ -1,55 +0,0 @@
-require 'spec_helper'
-
-describe "Variant scopes", :type => :model do
-  let!(:product) { create(:product) }
-  let!(:variant_1) { create(:variant, :product => product) }
-  let!(:variant_2) { create(:variant, :product => product) }
-
-  it ".descend_by_popularity" do
-    # Requires a product with at least two variants, where one has a higher number of
-    # orders than the other
-    Spree::LineItem.delete_all # FIXME leaky database - too many line_items
-    create(:line_item, :variant => variant_1)
-    expect(Spree::Variant.descend_by_popularity.first).to eq(variant_1)
-  end
-
-
-  context "finding by option values" do
-    let!(:option_type) { create(:option_type, :name => "bar") }
-    let!(:option_value_1) do
-      option_value = create(:option_value, :name => "foo", :option_type => option_type)
-      variant_1.option_values << option_value
-      option_value
-    end
-
-    let!(:option_value_2) do
-      option_value = create(:option_value, :name => "fizz", :option_type => option_type)
-      variant_1.option_values << option_value
-      option_value
-    end
-
-    let!(:product_variants) { product.variants_including_master }
-
-    it "by objects" do
-      variants = product_variants.has_option(option_type, option_value_1)
-      expect(variants).to include(variant_1)
-      expect(variants).not_to include(variant_2)
-    end
-
-    it "by names" do
-      variants = product_variants.has_option("bar", "foo")
-      expect(variants).to include(variant_1)
-      expect(variants).not_to include(variant_2)
-    end
-
-    it "by ids" do
-      variants = product_variants.has_option(option_type.id, option_value_1.id)
-      expect(variants).to include(variant_1)
-      expect(variants).not_to include(variant_2)
-    end
-
-    it "by mixed conditions" do
-      variants = product_variants.has_option(option_type.id, "foo", option_value_2)
-    end
-  end
-end

data/spec/models/spree/variant_spec.rb

@@ -1,546 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-describe Spree::Variant, :type => :model do
-  let!(:variant) { create(:variant) }
-
-  it_behaves_like 'default_price'
-
-  context "validations" do
-    it "should validate price is greater than 0" do
-      variant.price = -1
-      expect(variant).to be_invalid
-    end
-
-    it "should validate price is 0" do
-      variant.price = 0
-      expect(variant).to be_valid
-    end
-  end
-
-  context "after create" do
-    let!(:product) { create(:product) }
-
-    it "propagate to stock items" do
-      expect_any_instance_of(Spree::StockLocation).to receive(:propagate_variant)
-      product.variants.create(:name => "Foobar")
-    end
-
-    context "stock location has disable propagate all variants" do
-      before { Spree::StockLocation.update_all propagate_all_variants: false }
-
-      it "propagate to stock items" do
-        expect_any_instance_of(Spree::StockLocation).not_to receive(:propagate_variant)
-        product.variants.create(:name => "Foobar")
-      end
-    end
-
-    describe 'mark_master_out_of_stock' do
-      before do
-        product.master.stock_items.first.set_count_on_hand(5)
-      end
-      context 'when product is created without variants but with stock' do
-        it { expect(product.master).to be_in_stock }
-      end
-
-      context 'when a variant is created' do
-        before(:each) do
-          product.variants.create!(:name => 'any-name')
-        end
-
-        it { expect(product.master).to_not be_in_stock }
-      end
-    end
-  end
-
-  context "product has other variants" do
-    describe "option value accessors" do
-      before {
-        @multi_variant = FactoryGirl.create :variant, :product => variant.product
-        variant.product.reload
-      }
-
-      let(:multi_variant) { @multi_variant }
-
-      it "should set option value" do
-        expect(multi_variant.option_value('media_type')).to be_nil
-
-        multi_variant.set_option_value('media_type', 'DVD')
-        expect(multi_variant.option_value('media_type')).to eql 'DVD'
-
-        multi_variant.set_option_value('media_type', 'CD')
-        expect(multi_variant.option_value('media_type')).to eql 'CD'
-      end
-
-      it "should not duplicate associated option values when set multiple times" do
-        multi_variant.set_option_value('media_type', 'CD')
-
-        expect {
-         multi_variant.set_option_value('media_type', 'DVD')
-        }.to_not change(multi_variant.option_values, :count)
-
-        expect {
-          multi_variant.set_option_value('coolness_type', 'awesome')
-        }.to change(multi_variant.option_values, :count).by(1)
-      end
-    end
-
-    context "product has other variants" do
-      describe "option value accessors" do
-        before {
-          @multi_variant = create(:variant, :product => variant.product)
-          variant.product.reload
-        }
-
-        let(:multi_variant) { @multi_variant }
-
-        it "should set option value" do
-          expect(multi_variant.option_value('media_type')).to be_nil
-
-          multi_variant.set_option_value('media_type', 'DVD')
-          expect(multi_variant.option_value('media_type')).to eql 'DVD'
-
-          multi_variant.set_option_value('media_type', 'CD')
-          expect(multi_variant.option_value('media_type')).to eql 'CD'
-        end
-
-        it "should not duplicate associated option values when set multiple times" do
-          multi_variant.set_option_value('media_type', 'CD')
-
-          expect {
-           multi_variant.set_option_value('media_type', 'DVD')
-          }.to_not change(multi_variant.option_values, :count)
-
-          expect {
-            multi_variant.set_option_value('coolness_type', 'awesome')
-          }.to change(multi_variant.option_values, :count).by(1)
-        end
-      end
-    end
-  end
-
-  context "#cost_price=" do
-    it "should use LocalizedNumber.parse" do
-      expect(Spree::LocalizedNumber).to receive(:parse).with('1,599.99')
-      subject.cost_price = '1,599.99'
-    end
-  end
-
-  context "#price=" do
-    it "should use LocalizedNumber.parse" do
-      expect(Spree::LocalizedNumber).to receive(:parse).with('1,599.99')
-      subject.price = '1,599.99'
-    end
-  end
-
-  context "#weight=" do
-    it "should use LocalizedNumber.parse" do
-      expect(Spree::LocalizedNumber).to receive(:parse).with('1,599.99')
-      subject.weight = '1,599.99'
-    end
-  end
-
-  context "#currency" do
-    it "returns the globally configured currency" do
-      expect(variant.currency).to eql "USD"
-    end
-  end
-
-  context "#display_amount" do
-    it "returns a Spree::Money" do
-      variant.price = 21.22
-      expect(variant.display_amount.to_s).to eql "$21.22"
-    end
-  end
-
-  context "#cost_currency" do
-    context "when cost currency is nil" do
-      before { variant.cost_currency = nil }
-      it "populates cost currency with the default value on save" do
-        variant.save!
-        expect(variant.cost_currency).to eql "USD"
-      end
-    end
-  end
-
-  context "#default_price" do
-    context "when multiple prices are present in addition to a default price" do
-      before do
-        variant.prices << create(:price, :variant => variant, :currency => "USD", :amount => 12.12, :is_default => false)
-        variant.prices << create(:price, :variant => variant, :currency => "EUR", :amount => 29.99)
-        variant.prices << create(:price, :variant => variant, :currency => "EUR", :amount => 10.00, :is_default => false)
-        variant.reload
-      end
-
-      it "the default stays the same" do
-        expect(variant.default_price.amount).to eq(19.99)
-      end
-
-      it "displays default price" do
-        expect(variant.price_in("USD").display_amount.to_s).to eq("$19.99")
-        expect(variant.price_in("EUR").display_amount.to_s).to eq("€29.99")
-      end
-    end
-
-    context "when adding multiple prices" do
-      it "it can reassign a default price" do
-        expect(variant.default_price.amount).to eq(19.99)
-        variant.prices << create(:price, :variant => variant, :currency => "USD", :amount => 12.12)
-        expect(variant.reload.default_price.amount).to eq(12.12)
-      end
-    end
-  end
-
-  describe '.price_in' do
-    before do
-      variant.prices << create(:price, :variant => variant, :currency => "EUR", :amount => 33.33)
-    end
-    subject { variant.price_in(currency).display_amount }
-
-    context "when currency is not specified" do
-      let(:currency) { nil }
-
-      it "returns 0" do
-        expect(subject.to_s).to eql "$0.00"
-      end
-    end
-
-    context "when currency is EUR" do
-      let(:currency) { 'EUR' }
-
-      it "returns the value in the EUR" do
-        expect(subject.to_s).to eql "€33.33"
-      end
-    end
-
-    context "when currency is USD" do
-      let(:currency) { 'USD' }
-
-      it "returns the value in the USD" do
-        expect(subject.to_s).to eql "$19.99"
-      end
-    end
-  end
-
-  describe '.amount_in' do
-    before do
-      variant.prices << create(:price, :variant => variant, :currency => "EUR", :amount => 33.33)
-    end
-
-    subject { variant.amount_in(currency) }
-
-    context "when currency is not specified" do
-      let(:currency) { nil }
-
-      it "returns nil" do
-        expect(subject).to be_nil
-      end
-    end
-
-    context "when currency is EUR" do
-      let(:currency) { 'EUR' }
-
-      it "returns the value in the EUR" do
-        expect(subject).to eql 33.33
-      end
-    end
-
-    context "when currency is USD" do
-      let(:currency) { 'USD' }
-
-      it "returns the value in the USD" do
-        expect(subject).to eql 19.99
-      end
-    end
-  end
-
-  # Regression test for #2432
-  describe 'options_text' do
-    let!(:variant) { create(:variant, option_values: []) }
-    let!(:master) { create(:master_variant) }
-
-    before do
-      # Order bar than foo
-      variant.option_values << create(:option_value, {name: 'Foo', presentation: 'Foo', option_type: create(:option_type, position: 2, name: 'Foo Type', presentation: 'Foo Type')})
-      variant.option_values << create(:option_value, {name: 'Bar', presentation: 'Bar', option_type: create(:option_type, position: 1, name: 'Bar Type', presentation: 'Bar Type')})
-    end
-
-    it 'should order by bar than foo' do
-      expect(variant.options_text).to eql 'Bar Type: Bar, Foo Type: Foo'
-    end
-
-  end
-
-  describe 'exchange_name' do
-    let!(:variant) { create(:variant, option_values: []) }
-    let!(:master) { create(:master_variant) }
-
-    before do
-      variant.option_values << create(:option_value, {
-                                                     name: 'Foo',
-                                                     presentation: 'Foo',
-                                                     option_type: create(:option_type, position: 2, name: 'Foo Type', presentation: 'Foo Type')
-                                                   })
-    end
-
-    context 'master variant' do
-      it 'should return name' do
-        expect(master.exchange_name).to eql master.name
-      end
-    end
-
-    context 'variant' do
-      it 'should return options text' do
-        expect(variant.exchange_name).to eql 'Foo Type: Foo'
-      end
-    end
-
-  end
-
-  describe 'exchange_name' do
-    let!(:variant) { create(:variant, option_values: []) }
-    let!(:master) { create(:master_variant) }
-
-    before do
-      variant.option_values << create(:option_value, {
-                                                     name: 'Foo',
-                                                     presentation: 'Foo',
-                                                     option_type: create(:option_type, position: 2, name: 'Foo Type', presentation: 'Foo Type')
-                                                   })
-    end
-
-    context 'master variant' do
-      it 'should return name' do
-        expect(master.exchange_name).to eql master.name
-      end
-    end
-
-    context 'variant' do
-      it 'should return options text' do
-        expect(variant.exchange_name).to eql 'Foo Type: Foo'
-      end
-    end
-
-  end
-
-  describe 'descriptive_name' do
-    let!(:variant) { create(:variant, option_values: []) }
-    let!(:master) { create(:master_variant) }
-
-    before do
-      variant.option_values << create(:option_value, {
-                                                     name: 'Foo',
-                                                     presentation: 'Foo',
-                                                     option_type: create(:option_type, position: 2, name: 'Foo Type', presentation: 'Foo Type')
-                                                   })
-    end
-
-    context 'master variant' do
-      it 'should return name with Master identifier' do
-        expect(master.descriptive_name).to eql master.name + ' - Master'
-      end
-    end
-
-    context 'variant' do
-      it 'should return options text with name' do
-        expect(variant.descriptive_name).to eql variant.name + ' - Foo Type: Foo'
-      end
-    end
-
-  end
-
-  # Regression test for #2744
-  describe "set_position" do
-    it "sets variant position after creation" do
-      variant = create(:variant)
-      expect(variant.position).to_not be_nil
-    end
-  end
-
-  describe '#in_stock?' do
-    before do
-      Spree::Config.track_inventory_levels = true
-    end
-
-    context 'when stock_items are not backorderable' do
-      before do
-        allow_any_instance_of(Spree::StockItem).to receive_messages(backorderable: false)
-      end
-
-      context 'when stock_items in stock' do
-        before do
-          variant.stock_items.first.update_column(:count_on_hand, 10)
-        end
-
-        it 'returns true if stock_items in stock' do
-          expect(variant.in_stock?).to be true
-        end
-      end
-
-      context 'when stock_items out of stock' do
-        before do
-          allow_any_instance_of(Spree::StockItem).to receive_messages(backorderable: false)
-          allow_any_instance_of(Spree::StockItem).to receive_messages(count_on_hand: 0)
-        end
-
-        it 'return false if stock_items out of stock' do
-          expect(variant.in_stock?).to be false
-        end
-      end
-    end
-
-    describe "#can_supply?" do
-      it "calls out to quantifier" do
-        expect(Spree::Stock::Quantifier).to receive(:new).and_return(quantifier = double)
-        expect(quantifier).to receive(:can_supply?).with(10)
-        variant.can_supply?(10)
-      end
-    end
-
-    context 'when stock_items are backorderable' do
-      before do
-        allow_any_instance_of(Spree::StockItem).to receive_messages(backorderable: true)
-      end
-
-      context 'when stock_items out of stock' do
-        before do
-          allow_any_instance_of(Spree::StockItem).to receive_messages(count_on_hand: 0)
-        end
-
-        it 'in_stock? returns false' do
-          expect(variant.in_stock?).to be false
-        end
-
-        it 'can_supply? return true' do
-          expect(variant.can_supply?).to be true
-        end
-      end
-    end
-  end
-
-  describe '#is_backorderable' do
-    let(:variant) { build(:variant) }
-    subject { variant.is_backorderable? }
-
-    it 'should invoke Spree::Stock::Quantifier' do
-      expect_any_instance_of(Spree::Stock::Quantifier).to receive(:backorderable?) { true }
-      subject
-    end
-  end
-
-  describe '#total_on_hand' do
-    it 'should be infinite if track_inventory_levels is false' do
-      Spree::Config[:track_inventory_levels] = false
-      expect(build(:variant).total_on_hand).to eql(Float::INFINITY)
-    end
-
-    it 'should match quantifier total_on_hand' do
-      variant = build(:variant)
-      expect(variant.total_on_hand).to eq(Spree::Stock::Quantifier.new(variant).total_on_hand)
-    end
-  end
-
-  describe '#tax_category' do
-    context 'when tax_category is nil' do
-      let(:product) { build(:product) }
-      let(:variant) { build(:variant, product: product, tax_category_id: nil) }
-      it 'returns the parent products tax_category' do
-        expect(variant.tax_category).to eq(product.tax_category)
-      end
-    end
-
-    context 'when tax_category is set' do
-      let(:tax_category) { create(:tax_category) }
-      let(:variant) { build(:variant, tax_category: tax_category) }
-      it 'returns the tax_category set on itself' do
-        expect(variant.tax_category).to eq(tax_category)
-      end
-    end
-  end
-
-  describe "touching" do
-    it "updates a product" do
-      variant.product.update_column(:updated_at, 1.day.ago)
-      variant.touch
-      expect(variant.product.reload.updated_at).to be_within(3.seconds).of(Time.now)
-    end
-
-    it "clears the in_stock cache key" do
-      expect(Rails.cache).to receive(:delete).with(variant.send(:in_stock_cache_key))
-      variant.touch
-    end
-  end
-
-  describe "#should_track_inventory?" do
-
-    it 'should not track inventory when global setting is off' do
-      Spree::Config[:track_inventory_levels] = false
-
-      expect(build(:variant).should_track_inventory?).to eq(false)
-    end
-
-    it 'should not track inventory when variant is turned off' do
-      Spree::Config[:track_inventory_levels] = true
-
-      expect(build(:on_demand_variant).should_track_inventory?).to eq(false)
-    end
-
-    it 'should track inventory when global and variant are on' do
-      Spree::Config[:track_inventory_levels] = true
-
-      expect(build(:variant).should_track_inventory?).to eq(true)
-    end
-  end
-
-  describe "deleted_at scope" do
-    before { variant.destroy && variant.reload }
-    it "should have a price if deleted" do
-      variant.price = 10
-      expect(variant.price).to eq(10)
-    end
-  end
-
-  describe "stock movements" do
-    let!(:movement) { create(:stock_movement, stock_item: variant.stock_items.first) }
-
-    it "builds out collection just fine through stock items" do
-      expect(variant.stock_movements.to_a).not_to be_empty
-    end
-  end
-
-  describe "in_stock scope" do
-    it "returns all in stock variants" do
-      in_stock_variant = create(:variant)
-      out_of_stock_variant = create(:variant)
-
-      in_stock_variant.stock_items.first.update_column(:count_on_hand, 10)
-
-      expect(Spree::Variant.in_stock).to eq [in_stock_variant]
-    end
-  end
-
-  describe "#display_image" do
-    subject { variant.display_image }
-
-    context "variant has associated images" do
-      let(:attachment) { File.open(File.expand_path('../../../fixtures/thinking-cat.jpg', __FILE__)) }
-      let(:image_params) { { viewable_id: variant.id, viewable_type: 'Spree::Variant', attachment: attachment, alt: "position 1", position: 1 } }
-      let!(:first_image) { Spree::Image.create(image_params) }
-      let!(:second_image) { image_params.merge(alt: "position 2", position: 2) }
-
-      it "returns the first image" do
-        expect(subject).to eq first_image
-      end
-    end
-
-    context "variant does not have any associated images" do
-      it "returns an image" do
-        expect(subject).to be_a(Spree::Image)
-      end
-      it "returns unpersisted record" do
-        expect(subject).to be_new_record
-      end
-    end
-  end
-end