solidus_braintree 1.4.0 → 2.0.0

data/spec/features/frontend/paypal_checkout_spec.rb

@@ -0,0 +1,166 @@
+require 'spec_helper'
+
+describe "Checkout", type: :feature, js: true do
+  Capybara.default_max_wait_time = 60
+
+  # let!(:store) do
+  #   create(:store, payment_methods: [payment_method]).tap do |s|
+  #     s.braintree_configuration.update!(braintree_preferences)
+  #   end
+  # end
+  let(:braintree_preferences) { { paypal: true }.merge(paypal_options) }
+  let(:paypal_options) { {} }
+
+  let!(:country) { create(:country, states_required: true) }
+  # let!(:state) { create(:state, country: country, abbr: "CA", name: "California") }
+  # let!(:shipping_method) { create(:shipping_method) }
+  # let!(:stock_location) { create(:stock_location) }
+  let!(:mug) { create(:product, name: "RoR Mug") }
+  let!(:payment_method) { create_gateway }
+  # let!(:zone) { create(:zone) }
+
+  before do
+    create(:store, payment_methods: [payment_method]).tap do |s|
+      s.braintree_configuration.update!(braintree_preferences)
+    end
+    create(:state, country: country, abbr: "CA", name: "California")
+    create(:shipping_method)
+    create(:stock_location)
+    create(:zone)
+  end
+
+  context "when going through express checkout using paypal cart button" do
+    before do
+      payment_method
+      add_mug_to_cart
+    end
+
+    it "checks out successfully", skip: "Broken. To be revisited" do
+      pend_if_paypal_slow do
+        expect_any_instance_of(Spree::Order).to receive(:restart_checkout_flow)
+        move_through_paypal_popup
+        expect(page).to have_content("Shipments")
+        click_on "Place Order"
+        expect(page).to have_content("Your order has been processed successfully")
+      end
+    end
+
+    context 'when using custom paypal button style' do
+      let(:paypal_options) { { preferred_paypal_button_color: 'blue' } }
+
+      it 'displays required PayPal button style' do
+        within_frame find('#paypal-button iframe') do
+          expect(page).to have_selector('.paypal-button-color-blue')
+        end
+      end
+    end
+  end
+
+  context "when going through regular checkout using paypal payment method" do
+    before do
+      payment_method
+      add_mug_to_cart
+      click_button("Checkout")
+      fill_in("order_email", with: "paypal_buyer@paypaltest.com")
+      click_button("Continue")
+      fill_in_address
+      click_button("Save and Continue")
+      click_button("Save and Continue")
+    end
+
+    it "formats the address variable correctly" do
+      expect(page.evaluate_script("address['recipientName']")).to eq "Ryan Bigg"
+    end
+
+    it "checks out successfully", skip: "Broken. To be revisited" do
+      pend_if_paypal_slow do
+        expect_any_instance_of(Spree::Order).not_to receive(:restart_checkout_flow)
+        move_through_paypal_popup
+
+        expect(page).to have_content("Shipments")
+        click_on "Place Order"
+        expect(page).to have_content("Your order has been processed successfully")
+      end
+    end
+  end
+
+  # Selenium does not clear cookies properly between test runs, even when
+  # using Capybara.reset_sessions!, see:
+  # https://github.com/jnicklas/capybara/issues/535
+  #
+  # This causes Paypal to remain logged in and not prompt for an email on the
+  # second test run and causes the test to fail. Adding conditional logic for
+  # this greatly increases the test time, so it is left out since CI runs
+  # these with poltergeist.
+  def move_through_paypal_popup
+    expect(page).to have_css('#paypal-button .paypal-button')
+
+    sleep 2 # the PayPal button is not immediately ready
+
+    popup = page.window_opened_by do
+      within_frame find('#paypal-button iframe') do
+        find('div.paypal-button').click
+      end
+    end
+    page.switch_to_window(popup)
+
+    # We don't control this popup window.
+    # So javascript errors are not our errors.
+    begin
+      expect(page).not_to have_selector('body.loading')
+      fill_in("login_email", with: "stembolt_buyer@stembolttest.com")
+      click_on "Next"
+      fill_in("login_password", with: "test1234")
+
+      expect(page).not_to have_selector('body.loading')
+      click_button("btnLogin")
+
+      expect(page).not_to have_selector('body.loading')
+      click_button("Continue")
+      click_button("Agree & Continue")
+    rescue Selenium::WebDriver::Error::JavascriptError => e
+      pending "PayPal had javascript errors in their popup window."
+      raise e
+    rescue Capybara::ElementNotFound => e
+      pending "PayPal delivered unkown HTML in their popup window."
+      raise e
+    rescue Selenium::WebDriver::Error::NoSuchWindowError => e
+      pending "PayPal popup not available."
+      raise e
+    end
+
+    page.switch_to_window(page.windows.first)
+  end
+
+  def fill_in_address
+    address = "order_bill_address_attributes"
+    if page.has_css?("##{address}_firstname", wait: 0)
+      fill_in "#{address}_firstname", with: "Ryan"
+      fill_in "#{address}_lastname", with: "Bigg"
+    else
+      fill_in "#{address}_name", with: "Ryan Bigg"
+    end
+    fill_in "#{address}_address1", with: "143 Swan Street"
+    fill_in "#{address}_city", with: "San Jose"
+    select "United States of America", from: "#{address}_country_id"
+    select "California", from: "#{address}_state_id"
+    fill_in "#{address}_zipcode", with: "95131"
+    fill_in "#{address}_phone", with: "(555) 555-0111"
+  end
+
+  def add_mug_to_cart
+    visit spree.root_path
+    click_link mug.name
+    click_button "add-to-cart-button"
+  end
+
+  def pend_if_paypal_slow
+    yield
+  rescue RSpec::Expectations::ExpectationNotMetError => e
+    pending "PayPal did not answer in #{Capybara.default_max_wait_time} seconds."
+    raise e
+  rescue Selenium::WebDriver::Error::JavascriptError => e
+    pending "PayPal delivered wrong payload because of errors in their popup window."
+    raise e
+  end
+end

data/spec/features/frontend/venmo_checkout_spec.rb

@@ -0,0 +1,194 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+require 'spree/testing_support/order_walkthrough'
+
+describe "Checkout", type: :feature, js: true do
+  let(:braintree_preferences) { { venmo: true }.merge(preferences) }
+  let(:preferences) { {} }
+  let(:user) { create(:user) }
+  let!(:payment_method) { create_gateway }
+
+  before do
+    create(:store, payment_methods: [payment_method]).tap do |s|
+      s.braintree_configuration.update!(braintree_preferences)
+    end
+
+    go_to_payment_checkout_page
+  end
+
+  context 'with Venmo checkout' do
+    context 'when Venmo is disabled' do
+      let(:preferences) { { venmo: false } }
+
+      it 'does not load the Venmo payment button' do
+        expect(page).not_to have_selector('#venmo-button')
+      end
+    end
+
+    context 'when Venmo is enabled' do
+      it 'loads the Venmo payment button' do
+        expect(page).to have_selector('#venmo-button')
+      end
+    end
+
+    context "when Venmo's button style is customized" do
+      context 'when venmo_button_color is "blue" and venmo_button_width is "280"' do
+        let(:preferences) { { preferred_venmo_button_color: 'blue', preferred_venmo_button_width: '280' } }
+
+        it 'has the correct style' do
+          venmo_button.assert_matches_style(width: '280px', 'background-image': /venmo_blue_button_280x48/)
+          venmo_button.hover
+          venmo_button.assert_matches_style('background-image': /venmo_active_blue_button_280x48/)
+        end
+      end
+
+      context 'when venmo_button_color is "white" and venmo_button_width is "375"' do
+        let(:preferences) { { preferred_venmo_button_color: 'white', preferred_venmo_button_width: '375' } }
+
+        it 'has the correct style' do
+          venmo_button.assert_matches_style(width: '375px', 'background-image': /venmo_white_button_375x48/)
+          venmo_button.hover
+          venmo_button.assert_matches_style('background-image': /venmo_active_white_button_375x48/)
+        end
+      end
+    end
+
+    context 'when the Venmo button is clicked' do
+      before { venmo_button.click }
+
+      it 'opens the QR modal which shows an error when closed' do
+        within_frame(venmo_frame) do
+          expect(page).to have_selector('#venmo-qr-code-view')
+
+          click_button('close-icon')
+
+          expect(page).not_to have_selector('#venmo-qr-code-view')
+        end
+
+        expect(page).to have_content('Venmo authorization was canceled by closing the Venmo Desktop modal.')
+      end
+    end
+
+    # TODO: Reenable these specs once Venmo is enabled on the Braintree sandbox.
+    xcontext 'with Venmo transactions', vcr: { cassette_name: 'checkout/valid_venmo_transaction' } do
+      before do
+        fake_venmo_successful_tokenization
+      end
+
+      context 'with CreditCard disabled' do
+        it 'can checkout with Venmo' do
+          next_checkout_step
+          finalize_checkout
+
+          expect(Spree::Order.last.complete?).to be(true)
+        end
+      end
+
+      # To test that the hosted-fields inputs do not conflict with Venmo's
+      context 'with CreditCard enabled' do
+        let(:preferences) { { credit_card: true } }
+
+        it 'can checkout with Venmo' do
+          disable_hosted_fields_inputs
+          disable_hosted_fields_form_listener
+
+          next_checkout_step
+          finalize_checkout
+
+          expect(Spree::Order.last.complete?).to be(true)
+          expect(Spree::Payment.last.source.venmo?).to be(true)
+        end
+      end
+
+      # https://developer.paypal.com/braintree/docs/guides/venmo/client-side#custom-integration
+      it "meet's Braintree's acceptance criteria during checkout", aggregate_failures: true do
+        next_checkout_step
+
+        expect(page).to have_content('Payment Type: Venmo')
+
+        finalize_checkout
+
+        expect(page).to have_content('Venmo Account: venmojoe')
+      end
+
+      # the VCR must be based on this test, so it includes HTTP requests of the second order
+      it 'saves the used Venmo source in the wallet and can be reused' do
+        next_checkout_step
+        finalize_checkout
+        go_to_payment_checkout_page(order_number: 'R300000002')
+
+        expect(Spree::User.first.wallet.wallet_payment_sources).not_to be_empty
+        expect(page).to have_selector('#existing_cards')
+        expect(page).to have_content('venmojoe')
+
+        next_checkout_step
+        finalize_checkout
+
+        expect(Spree::Order.all.all?(&:complete?)).to be(true)
+      end
+    end
+  end
+
+  private
+
+  def go_to_payment_checkout_page(order_number: 'R300000001' )
+    order = if Spree.solidus_gem_version >= Gem::Version.new('2.6.0')
+              Spree::TestingSupport::OrderWalkthrough.up_to(:address)
+            else
+              OrderWalkthrough.up_to(:address)
+            end
+
+    order.update!(user: user, number: order_number) # constant order number for VCRs
+
+    allow_any_instance_of(Spree::CheckoutController).to receive_messages(current_order: order)
+
+    first_user = Spree::User.first
+    allow_any_instance_of(Spree::CheckoutController).to receive_messages(try_spree_current_user: first_user)
+    allow_any_instance_of(Spree::CheckoutController).to receive_messages(spree_current_user: first_user)
+
+    allow_any_instance_of(Spree::Payment).to receive(:gateway_order_id).and_return(order_number)
+
+    visit spree.checkout_state_path(order.state)
+    next_checkout_step
+  end
+
+  def next_checkout_step
+    click_button('Save and Continue')
+  end
+
+  def finalize_checkout
+    click_button('Place Order')
+  end
+
+  def venmo_button
+    find_button('venmo-button', disabled: false)
+  end
+
+  def venmo_frame
+    find('#venmo-desktop-iframe')
+  end
+
+  def fake_venmo_successful_tokenization
+    enable_venmo_inputs
+    fake_payment_method_nonce
+  end
+
+  def enable_venmo_inputs
+    page.execute_script("$('.venmo-fields input').each(function(_index, input){input.removeAttribute('disabled');});")
+  end
+
+  def fake_payment_method_nonce
+    page.execute_script("$('#venmo_payment_method_nonce').val('fake-venmo-account-nonce');")
+  end
+
+  def disable_hosted_fields_inputs
+    page.execute_script("$('.hosted-fields input').each(function(_index, input){input.disabled=true;});")
+  end
+
+  def disable_hosted_fields_form_listener
+    # Once the submit button is enabled, the submit listener has been added
+    find("#checkout_form_payment input[type='submit']:not(:disabled)")
+    page.execute_script("$('#checkout_form_payment').off('submit');")
+  end
+end

data/spec/fixtures/cassettes/admin/invalid_credit_card.yml

@@ -0,0 +1,63 @@
+---
+http_interactions:
+- request:
+    method: post
+    uri: https://api.sandbox.braintreegateway.com/merchants/7rdg92j7bm7fk5h3/client_token
+    body:
+      encoding: UTF-8
+      string: |
+        <?xml version="1.0" encoding="UTF-8"?>
+        <client-token>
+          <version type="integer">2</version>
+        </client-token>
+    headers:
+      Accept-Encoding:
+      - gzip
+      Accept:
+      - application/xml
+      User-Agent:
+      - Braintree Ruby Gem 2.98.0
+      X-Apiversion:
+      - '5'
+      Content-Type:
+      - application/xml
+      Authorization:
+      - Basic bXdqa2t4d2NwMzJja2huZjphOTI5OGY0M2IzMGM2OTlkYjMwNzJjYzRhMDBmN2Y0OQ==
+  response:
+    status:
+      code: 201
+      message: Created
+    headers:
+      Server:
+      - nginx
+      Date:
+      - Fri, 13 Sep 2019 14:27:11 GMT
+      Content-Type:
+      - application/xml; charset=utf-8
+      Transfer-Encoding:
+      - chunked
+      X-Authentication:
+      - server_to_server
+      Braintree-Service-Origin:
+      - clientauth
+      Vary:
+      - Accept-Encoding
+      Content-Encoding:
+      - gzip
+      Etag:
+      - W/"c95fd3caa086065297edd0aeeb8e6d55"
+      Cache-Control:
+      - max-age=0, private, must-revalidate
+      X-Request-Id:
+      - 51cbbac6-bce1-4f90-ab14-6d61a064e77b
+      X-Runtime:
+      - '0.200715'
+      Strict-Transport-Security:
+      - max-age=31536000; includeSubDomains
+    body:
+      encoding: ASCII-8BIT
+      string: !binary |-
+        H4sIAD+ne10AA3xWXXObOBR976/o9H13+QiZeCbtTkkAWzFyLEASegNEC0bCtLax4dfvBaeTZja7D57BSLr33HvPOeL+74tWH/vy56Het58/mX8anz6WbbGXdfv986ck9v+4+/T3lw/3harL9vjHcd+U7ZcPHz/e95k6lV/KAVmCozFji9Nqtx/WD6iSnOxzG3Wl9o3pPdHqJCw6FEvU5e223tRIlcn+LGjlZsmii5ojC6nfxR5+ygK0TC31nCVdQHmHwsTpIo5RzsmZNRjhRv2IuMQ0kHbcEBQ2ZsI42YWNMFkjn6Smj9GuOQmunvKArrYMYjXJJdZdG3rOLeEKlw0dI2aew8CPo1igTFeH2JC0VCoRowtQUBcbhEjPWTLIlcWArSFZnlw4xNmU+nJklCDsLeC/2iSGgnjOJqSqu8YjDmDZ4cQ85iMWefx1ZNocQ+Z7MVPh1ujO6YjxtXbUMB/1gmJUGOoYsssuT5ye0cIMPfWjeJQob1YXxsybwm8uG+5mW6OxItY1Je2W6Uhxzu5GxoxzaHbHYvQr4plzL0PVpVHrZrm+aBajAPYHG6YU3amfTMksCwgvH12UtS7UI29K2B8uoddNd2Y7tA8D7EA9vEw6Y8KT+fuBatHkSXpJm4pktIqlperQWJ1TWjiSzftVOHrOusFRBE90/HrhVjckrRskCX2SiZlKn7h8xDytzXUe7G1ioyNuqm+JQR+l0TXSUM/U29uRt0hjvailcdFUI3dD/SQ0aU9bQqUWzzjGZmarrvToE/S5XdXnOrUWJ6FVSzk6AB/rbEmMYhnerodFVQTNqbD8kwhQXz44daF94CMZBKNtyomSlu+sNe7zeG/gx7DPGR1Sq6pgz7ge5SCCwgn13k61YQt9MDPYk1qXTjDH4JZ/zqKFFUaLXW45OmPSLF74P+ESNoL8FYkfVregGVg7TzrYyyU5F+O+X9tuVTJTzblaXOWa1Ln9/ZS2qMogfqGpWrMphwPxjf4l3iV/WB1WmlQySCDeaggfvZt1/NWE382qNWAN71N2OQDGVvCw3qijBI1CHtEVenGCGk8SMK1ec9awvssDNWFxi0DRf2Gda3XGlDlNqhc3a42GlKmTXCIlmAQs1E55c4JZHDe7rREOiyN4xC4LfNgT9thGjRibIdvJOo+lzka6hz2/cn5LudvNs+R4FJyM787SxgpivemPsHxDcFmV1x7Vv7zovfPT+3UrVK7N/r/6/V68XPuHkpMutaGX7aGW/47dF8C/jN0coT9VvlTAATyu+ZRj+x/8S45TzTP3oju70KTdxOgHtkAXlviJ2fdxnmVL9hMu4mOV2nQQCT2lDMFswVMhjmQJ7AEecbfKvf9Zu3KwyTg+54HvxNo/igg4oLAhmFnn1sW4aunK7YjNnu3CPHQ+iodUp2OphGC+iIhyn0jcOCWtHmSDbjHb3mQmeca2+wzzj6EWUiyTgRiXZ0pXQ9G6QnrmQ5qAJ9vVLh2rh7CRTW4TL9PFEOvvThytJqxDxkWV2m/5t6nvesFBk9w9iBctFMuv02zMAu6YLZOTno8T7jdzf5x4S29S8P08SGZurm3SF8OkH9CSRd/j+QjvjWL4H6+YsOqXfSYdpt6udGXIpTtOWME/VGode8lh9tBr+B1ezxHQIN1J77f82jHz4DzFPOTBwo4m7BATtGWKCHyEOVbGUQ+8nbSyyQ0HdCCBcwc4K4BvWL2rb73QQl+6XCdzr2AdzhElPFMVs0c4xmrXafCKccrzuw62b3kAXAWe8F8esR1nrmgFeOGeN/x2OjPnXWIf9FLDPdxAbKNo6YTt1Qs8fwdzACwEiasHveUfcBxinYADqLAWj7lF1DRPSrF39bZX7Fdsq/e1A7HguwB6cTfh74VOZy0XS+AQBU1Esx5GGfiGnDwSaswt/PPlPpnwDWWCezF7LKLJzBlsFi30WWNnay2aq35oTGY//h0XmebUwZ2kinqaw+va774D/VJy6t8briWnwobzDOa93J4ywA+4R8ndM3xfQa/IBvzRhuefwONbBt9ioOlqwp0zH+qZ7i9/EDMm0DifvX3S/S63BeBB8hs3Pt//df2W+3D/19uvvH8AAAD//wMABRjVUhwKAAA=
+    http_version: 
+  recorded_at: Fri, 13 Sep 2019 14:27:11 GMT
+recorded_with: VCR 5.0.0