solidus_bactracs 3.4.0 → 3.5.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9bbd41ca4504892004e3c4b39dd1688529cc02ca50dafbeb62b33f7f1bff14e4
-  data.tar.gz: 11c2cf0ee91d07eec4e08fa3ed2c5c0f4756cb2ef3e2cccacb605ee1d1f8dc74
+  metadata.gz: 4e535e8a59bea282ee76d1fe01b99f738d19061abf29d1745e40bdcce792337e
+  data.tar.gz: 75d5f6d07e1fd88e1f30c46418c674059b582aca33a884b16830be441d39a708
 SHA512:
-  metadata.gz: cb76a600bbefb62da8c9e066b9dec324c85506ebb7d616c2e3b6a857eff8f89133a08b0369f700e4441250e8342c093adbc4547951baf3a0da5b5b4f83347fca
-  data.tar.gz: 57eee50b741eb981483c6952aface01438f00bbd8fc7e7fae64819669997059009a72d3aafdcb4fb14c06466e18efc5dae6172497953eaffa6668cd39fc18c10
+  metadata.gz: 39918c8782cd792f3fa091b2762dda89ea07db28a33a0598711fa561010a9eef293e2d7eb94c5f921f23a49a9afef5d995ee242f3a8fb4ce949f41a53d36f038
+  data.tar.gz: b47a72baad881dfe7645addb7caadf4be5529d90d625b73bd32341d992d04ad110d56f7dc8730744a46ba55cb6edb45b1e3a19bbe6efe78a6363fbb2a17822c4

data/README.md

@@ -112,6 +112,11 @@ end
 
 You should overwrite this with your own means of determining the RMA type for a given shipment.
 
+##### DF Part
+Andlor uses the key "DFPart" to enable the indication of which item was 'defective' and being returned.  This only applies to Type 4 RMAs.
+
+Currently, the DF Part is the `number` on the shipment, and there is not yet an override method.
+
 #### API integration: Usage
 
 Once you've configured the integration, you will also need to enqueue the `ScheduleShipmentSyncsJob`

data/lib/solidus_bactracs/api/shipment_serializer.rb

@@ -13,8 +13,6 @@ module SolidusBactracs
       def call(sguid: nil)
         order = @shipment.order
         user = @shipment.user
-        rma_type = safe_rma_type
-        rp_location = get_rp_location
 
         xml = Builder::XmlMarkup.new
         xml.instruct!(:xml, :encoding => "UTF-8")
@@ -25,7 +23,7 @@ module SolidusBactracs
               xml.sGuid                       sguid
               xml.NewRMA {
                 xml.RMANumber                 @shipment.number
-                xml.RMATypeName               rma_type
+                xml.RMATypeName               safe_rma_type
                 xml.RMASubTypeName
                 xml.CustomerRef
                 xml.InboundShippingPriority
@@ -94,7 +92,8 @@ module SolidusBactracs
           xml.WarrantyRepair
           xml.RMALineTest
           xml.InboundShipWeight       variant.weight.to_f
-          xml.RPLocation              rp_location
+          xml.RPLocation              get_rp_location
+          xml.DFPart                  get_df_part
         }
       end
 
@@ -104,13 +103,24 @@ module SolidusBactracs
       end
 
       def get_rp_location
-        rp_location = @shipment.get_rma_rp_location if @shipment.get_rma_rp_location
+        #Double verifing
+        return nil if safe_rma_type == "4"
+
         @config.default_rp_location.call(@shipment)
       end
 
       def find_sku_variant(variant)
         @config.sku_map[variant.sku].present? ? @config.sku_map[variant.sku] : variant.sku
       end
+
+      def get_df_part
+        df_part =
+          if safe_rma_type == "4"
+            @shipment.number
+          else
+            nil
+          end rescue nil
+      end
     end
   end
 end

data/lib/solidus_bactracs/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module SolidusBactracs
-  VERSION = '3.4.0'
+  VERSION = '3.5.1'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: solidus_bactracs
 version: !ruby/object:Gem::Version
-  version: 3.4.0
+  version: 3.5.1
 platform: ruby
 authors:
 - Zeryab Ali
@@ -9,7 +9,7 @@ authors:
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2022-11-03 00:00:00.000000000 Z
+date: 2022-11-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: httparty