solidus_backend 2.9.5 → 2.10.2

data/spec/features/admin/configuration/taxonomies_spec.rb

@@ -38,6 +38,13 @@ describe "Taxonomies", type: :feature do
       click_button "Create"
       expect(page).to have_content("can't be blank")
     end
+
+    it "disables the button at submit", :js do
+      page.execute_script "$('form').submit(function(e) { e.preventDefault()})"
+      fill_in "taxonomy_name", with: "sports"
+      click_button "Create"
+      expect(page).to have_button("Create", disabled: true)
+    end
   end
 
   context "edit" do

data/spec/features/admin/orders/customer_details_spec.rb

@@ -117,7 +117,7 @@ describe "Customer Details", type: :feature, js: true do
     end
 
     it "should show validation errors" do
-      order.update_attributes!(ship_address_id: nil)
+      order.update!(ship_address_id: nil)
       click_link "Customer"
       click_button "Update"
       expect(page).to have_content("Shipping address first name can't be blank")
@@ -157,7 +157,6 @@ describe "Customer Details", type: :feature, js: true do
       end
 
       it "sets default country when displaying form" do
-        click_link "Cart"
         click_link "Customer"
         expect(page).to have_field("order_bill_address_attributes_country_id", with: brazil.id, visible: false)
       end

data/spec/features/admin/orders/customer_returns_spec.rb

@@ -8,21 +8,34 @@ describe 'Customer returns', type: :feature do
   context 'when the order has more than one line item' do
     let(:order) { create :shipped_order, line_items_count: 2 }
 
+    def create_customer_return
+      find('#select-all').click
+      page.execute_script "$('select.add-item').val('receive')"
+      select 'NY Warehouse', from: 'Stock Location'
+      click_button 'Create'
+    end
+
+    before do
+      visit spree.new_admin_order_customer_return_path(order)
+    end
+
     context 'when creating a return with state "Received"' do
       it 'marks the order as returned', :js do
-        visit spree.new_admin_order_customer_return_path(order)
-
-        find('#select-all').click
-        page.execute_script "$('select.add-item').val('receive')"
-        select 'NY Warehouse', from: 'Stock Location'
-        click_button 'Create'
+        create_customer_return
 
         expect(page).to have_content 'Customer Return has been successfully created'
-
         within 'dd.order-state' do
           expect(page).to have_content 'Returned'
         end
       end
     end
+
+    it 'disables the button at submit', :js do
+      page.execute_script "$('form').submit(function(e) { e.preventDefault()})"
+
+      create_customer_return
+
+      expect(page).to have_button("Create", disabled: true)
+    end
   end
 end

data/spec/features/admin/orders/new_order_spec.rb

@@ -154,14 +154,14 @@ describe "New Order", type: :feature do
       click_on "Update"
 
       # Automatically redirected to Shipments page
-      select2_search product.name, from: I18n.t('spree.name_or_sku')
-
-      click_icon :plus
+      within '.no-objects-found' do
+        click_on "Cart"
+      end
 
-      expect(page).to have_css('.stock-item')
+      add_line_item product.name
 
       click_on "Payments"
-      click_on "Continue"
+      click_on "Update"
 
       within(".additional-info") do
         expect(page).to have_content("Confirm")
@@ -169,6 +169,54 @@ describe "New Order", type: :feature do
     end
   end
 
+  context "when changing customer", :js do
+    let!(:other_user) { create :user, bill_address: bill_address }
+
+    context "when one customer address have only textual state" do
+      let(:country) { create :country, iso: "IT" }
+      let(:bill_address) { create :address, country: country, state: nil, state_name: "Veneto" }
+
+      it "changes the bill address state accordingly" do
+        click_on "Customer"
+
+        within "#select-customer" do
+          targetted_select2_search user.email, from: "#s2id_customer_search"
+        end
+
+        expect(find("select#order_bill_address_attributes_state_id").value).to eq user.bill_address.state_id.to_s
+
+        within "#select-customer" do
+          targetted_select2_search other_user.email, from: "#s2id_customer_search"
+        end
+
+        expect(find("select#order_bill_address_attributes_state_id", visible: false).value).to eq ""
+        expect(find("#order_bill_address_attributes_state_name").value).to eq other_user.bill_address.state_name
+      end
+    end
+
+    context "when customers have same country but different state" do
+      let(:different_state) { Spree::State.where.not(id: user.bill_address.state_id).first }
+
+      let(:bill_address) { create :address, country: user.bill_address.country, state: different_state }
+
+      it "changes the bill address state accordingly" do
+        click_on "Customer"
+
+        within "#select-customer" do
+          targetted_select2_search user.email, from: "#s2id_customer_search"
+        end
+
+        expect(find('#order_bill_address_attributes_state_id').value).to eq user.bill_address.state_id.to_s
+
+        within "#select-customer" do
+          targetted_select2_search other_user.email, from: "#s2id_customer_search"
+        end
+
+        expect(find('#order_bill_address_attributes_state_id').value).to eq other_user.bill_address.state_id.to_s
+      end
+    end
+  end
+
   # Regression test for https://github.com/spree/spree/issues/5327
   context "customer with default credit card", js: true do
     let!(:credit_card) { create(:credit_card, user: user) }

data/spec/features/admin/orders/new_refund_spec.rb

@@ -29,7 +29,7 @@ RSpec.describe 'New Refund creation', :js do
       fill_in 'refund_amount', with: amount
       select reason.name, from: 'Reason'
       click_button 'Refund'
-      expect(find('input[type="submit"]')).to be_disabled
+      expect(page).to have_button('Refund', disabled: true)
     end
   end
 end

data/spec/features/admin/orders/order_details_spec.rb

@@ -76,6 +76,19 @@ describe "Order Details", type: :feature, js: true do
         expect(page).to have_field('quantity')
       end
 
+      it "can remove all items with empty cart" do
+        expect(page).to have_content("spree t-shirt")
+
+        accept_confirm "Are you sure you want to delete this record?" do
+          click_on 'Empty Cart'
+        end
+
+        expect(page).not_to have_content("spree t-shirt")
+
+        # Should have a new item row
+        expect(page).to have_field('quantity')
+      end
+
       # Regression test for https://github.com/spree/spree/issues/3862
       it "can cancel removing an item from a shipment" do
         expect(page).to have_content("spree t-shirt")
@@ -278,8 +291,7 @@ describe "Order Details", type: :feature, js: true do
 
           context 'A shipment has shipped' do
             it 'should not show or let me back to the cart page, nor show the shipment edit buttons' do
-              order = create(:order, state: 'payment')
-              order.shipments.create!(stock_location_id: stock_location.id, state: 'shipped')
+              order = create(:shipped_order, state: 'payment', stock_location: stock_location)
 
               visit spree.cart_admin_order_path(order)
 
@@ -525,8 +537,6 @@ describe "Order Details", type: :feature, js: true do
       expect(page).not_to have_css('.delete-item')
       expect(page).not_to have_css('.split-item')
       expect(page).not_to have_css('.edit-tracking')
-
-      expect(page).not_to have_css('#add-line-item')
     end
   end
 

data/spec/features/admin/orders/return_authorizations_spec.rb

@@ -8,20 +8,49 @@ describe "ReturnAuthorizations", type: :feature do
   stub_authorization!
 
   let!(:order) { create(:shipped_order) }
-  let!(:return_authorization) { create(:return_authorization, order: order) }
 
-  it "can visit the return authorizations list page" do
-    visit spree.admin_order_return_authorizations_path(order)
+  describe "create" do
+    def create_return_authorization
+      find("#select-all").click
+      select "NY Warehouse", from: "Stock Location"
+      click_button "Create"
+    end
+
+    before do
+      visit spree.new_admin_order_return_authorization_path(order)
+    end
+
+    it "creates a return authorization" do
+      create_return_authorization
+
+      expect(page).to have_content "Return Authorization has been successfully created!"
+    end
+
+    it "disables the button at submit", :js do
+      page.execute_script "$('form').submit(function(e) { e.preventDefault()})"
+
+      create_return_authorization
+
+      expect(page).to have_button("Create", disabled: true)
+    end
   end
 
-  describe "edit" do
-    it "can visit the return authorizations edit page" do
-      visit spree.edit_admin_order_return_authorization_path(order, return_authorization)
+  describe "when a return authorization exists" do
+    let!(:return_authorization) { create(:return_authorization, order: order) }
+
+    it "can visit the return authorizations list page" do
+      visit spree.admin_order_return_authorizations_path(order)
     end
 
-    it "return authorizations edit page has a data hook for extensions to add content above, below or within the RA form" do
-      visit spree.edit_admin_order_return_authorization_path(order, return_authorization)
-      expect(page).to have_selector("[data-hook=return-authorization-form-wrapper]")
+    describe "edit" do
+      it "can visit the return authorizations edit page" do
+        visit spree.edit_admin_order_return_authorization_path(order, return_authorization)
+      end
+
+      it "return authorizations edit page has a data hook for extensions to add content above, below or within the RA form" do
+        visit spree.edit_admin_order_return_authorization_path(order, return_authorization)
+        expect(page).to have_selector("[data-hook=return-authorization-form-wrapper]")
+      end
     end
   end
 end

data/spec/features/admin/products/edit/images_spec.rb

@@ -5,7 +5,7 @@ require 'spec_helper'
 describe "Product Images", type: :feature do
   stub_authorization!
 
-  let(:file_path) { Rails.root + "../../spec/support/ror_ringer.jpeg" }
+  let(:file_path) { file_fixture("ror_ringer.jpeg") }
   let(:product)   { create(:product) }
 
   before do

data/spec/features/admin/products/edit/taxons_spec.rb

@@ -26,13 +26,19 @@ describe "Product Display Order", type: :feature do
       visit spree.edit_admin_product_path(product)
 
       assert_selected_taxons([taxon_1])
-
       select2_search "Clothing", from: "Taxon"
       assert_selected_taxons([taxon_1, taxon_2])
 
+      # Without this line we have a flaky spec probably due to select2 not
+      # closing its fixed overlay correctly. Clicking anywhere in the page
+      # before submit apparently solves the issue.
+      find('.edit_product', visible: true, obscured: false).click
+
       click_button "Update"
 
-      expect(find(".flash")).to have_text "Product \"#{product.name}\" has been successfully updated!"
+      within('.flash') do
+        expect(page).to have_content(%(Product "#{product.name}" has been successfully updated!))
+      end
       assert_selected_taxons([taxon_1, taxon_2])
     end
 

data/spec/features/admin/products/products_spec.rb

@@ -172,6 +172,18 @@ describe "Products", type: :feature do
         expect(page).to have_content("successfully updated!")
       end
 
+      it "disables the button at submit", :js do
+        page.execute_script "$('form').submit(function(e) { e.preventDefault()})"
+        fill_in "product_name", with: "Baseball Cap"
+        fill_in "product_sku", with: "B100"
+        fill_in "product_price", with: "100"
+        fill_in "product_available_on", with: "2012/01/24"
+        select @shipping_category.name, from: "product_shipping_category_id"
+        click_button "Create"
+
+        expect(page).to have_button("Create", disabled: true)
+      end
+
       it "should show validation errors", js: false do
         fill_in "product_name", with: "Baseball Cap"
         fill_in "product_sku", with: "B100"

data/spec/features/admin/promotion_adjustments_spec.rb

@@ -167,6 +167,15 @@ describe "Promotion Adjustments", type: :feature, js: true do
       expect(promotion.actions.first).to be_a(Spree::Promotion::Actions::FreeShipping)
     end
 
+    it "disables the button at submit", :js do
+      page.execute_script "$('form').submit(function(e) { e.preventDefault()})"
+      fill_in "Name", with: "SAVE SAVE SAVE"
+      choose "Apply to all orders"
+      click_button "Create"
+
+      expect(page).to have_button("Create", disabled: true)
+    end
+
     it "should allow an admin to create an automatic promotion" do
       fill_in "Name", with: "SAVE SAVE SAVE"
       choose "Apply to all orders"

data/spec/features/admin/promotions/promotion_code_batches_spec.rb

@@ -0,0 +1,37 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+feature "Promotion Code Batches", partial_double_verification: false do
+  stub_authorization!
+
+  describe "create" do
+    let(:promotion) { create :promotion }
+
+    before do
+      user = double.as_null_object
+      allow_any_instance_of(ActionView::Base).to receive(:spree_current_user) { user }
+      visit spree.new_admin_promotion_promotion_code_batch_path(promotion)
+    end
+
+    def create_code_batch
+      fill_in "Base code", with: "base"
+      fill_in "Number of codes", with: 3
+      click_button "Create"
+    end
+
+    it "creates a new promotion code batch and disables the submit button", :js do
+      create_code_batch
+
+      expect(page).to have_content "Promotion Code Batch has been successfully created!"
+
+      visit spree.new_admin_promotion_promotion_code_batch_path(promotion)
+
+      page.execute_script "$('form').submit(function(e) { e.preventDefault()})"
+
+      create_code_batch
+
+      expect(page).to have_button("Create", disabled: true)
+    end
+  end
+end

data/spec/features/admin/promotions/promotion_code_spec.rb

@@ -0,0 +1,31 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+feature "Promotion Codes" do
+  stub_authorization!
+
+  describe "create" do
+    let(:promotion) { create :promotion }
+
+    before do
+      visit spree.new_admin_promotion_promotion_code_path(promotion)
+    end
+
+    it "creates a new promotion code" do
+      fill_in "Value", with: "XYZ"
+      click_button "Create"
+
+      expect(page).to have_content "Promotion Code has been successfully created!"
+    end
+
+    it "disables the button at submit", :js do
+      page.execute_script "$('form').submit(function(e) { e.preventDefault()})"
+
+      fill_in "Value", with: "XYZ"
+      click_button "Create"
+
+      expect(page).to have_button("Create", disabled: true)
+    end
+  end
+end

data/spec/features/admin/taxons_spec.rb

@@ -75,4 +75,16 @@ describe "Taxonomies and taxons", type: :feature do
       end
     end
   end
+
+  scenario "Removes attachments from taxon" do
+    taxon = create(:taxon)
+    taxon.update(icon: File.new(file_fixture('ror_ringer.jpeg')))
+
+    visit spree.edit_admin_taxonomy_taxon_path(taxon.taxonomy, taxon.id)
+    within('#taxon_icon_field') do
+      click_on 'Remove'
+    end
+
+    expect(page).to have_content("Icon has been successfully removed!")
+  end
 end

data/spec/features/admin/users_spec.rb

@@ -158,14 +158,6 @@ describe 'Users', type: :feature do
       expect(page).to have_field('user_email', with: 'a@example.com99')
     end
 
-    it 'can edit the user password' do
-      fill_in 'user_password', with: 'welcome'
-      fill_in 'user_password_confirmation', with: 'welcome'
-      click_button 'Update'
-
-      expect(page).to have_text 'Account updated'
-    end
-
     it 'can edit user roles' do
       click_link 'Account'
 
@@ -213,6 +205,24 @@ describe 'Users', type: :feature do
       expect(user_a.reload.bill_address.address1).to eq "1313 Mockingbird Ln"
     end
 
+    it 'can edit the user password' do
+      fill_in 'user_password', with: 'welcome'
+      fill_in 'user_password_confirmation', with: 'welcome'
+      click_button 'Update'
+
+      expect(page).to have_text 'Account updated'
+    end
+
+    context 'without password permissions' do
+      custom_authorization! do |_user|
+        cannot [:update_password], Spree.user_class
+      end
+
+      it 'cannot edit the user password' do
+        expect(page).to_not have_text 'Password'
+      end
+    end
+
     context 'invalid entry' do
       around do |example|
         ::AlwaysInvalidUser = Class.new(Spree.user_class) do