solidus_backend 2.4.2 → 2.5.0.beta1

data/app/views/spree/admin/stock_transfers/edit.html.erb

@@ -1,52 +0,0 @@
-<% admin_breadcrumb(link_to Spree.t(:stock), spree.admin_stock_items_path) %>
-<% admin_breadcrumb(link_to plural_resource_name(Spree::StockTransfer), spree.admin_stock_transfers_path) %>
-<% admin_breadcrumb(@stock_transfer.number) %>
-
-
-<% content_for :page_actions do %>
-  <li>
-  </li>
-  <li>
-    <%= button_link_to Spree.t(:ready_to_ship),
-      finalize_admin_stock_transfer_path(@stock_transfer),
-      method: 'put',
-      data: { confirm: Spree.t('finalize_stock_transfer.confirm') }
-    %>
-  </li>
-<% end %>
-
-<%= form_for [:admin, @stock_transfer] do |f| %>
-  <fieldset class="no-border-top">
-    <div>
-      <label><%= Spree.t(:created_by) %></label>
-      <p><%= @stock_transfer.created_by.email %></p>
-    </div>
-    <%= f.field_container :description do %>
-      <%= f.label :description %>
-      <%= f.text_field :description, value: @stock_transfer.description, maxlength: 255, size: 0, class: 'fullwidth' %>
-      <%= f.error_message_on :description %>
-    <% end %>
-    <%= f.field_container :destination_location do %>
-      <%= f.label :destination_location_id %>
-      <%= f.select :destination_location_id, options_from_collection_for_select(@destination_stock_locations, :id, :name, @stock_transfer.destination_location_id), {include_blank: true}, {class: 'custom-select fullwidth', "data-placeholder" => Spree.t(:select_a_stock_location)} %>
-      <%= f.error_message_on :destination_location %>
-    <% end %>
-    <div class="filter-actions actions" data-hook="buttons">
-      <%= button Spree.t('actions.save') %>
-    </div>
-  </fieldset>
-<% end %>
-
-<fieldset id='stock-transfer-edit-variants'>
-  <legend align="center"><%= Spree.t(:variant_to_add) %></legend>
-  <div data-hook="transfer_item_selection">
-    <%= hidden_field_tag :stock_transfer_number, @stock_transfer.number %>
-    <%= hidden_field_tag :variant_display_attributes, @variant_display_attributes.to_json %>
-    <%= text_field_tag :transfer_item_variant_id, "", class: "variant_autocomplete fullwidth" %>
-  </div>
-</fieldset>
-
-<fieldset id='stock-transfer-transfer-items'>
-  <legend align="center"><%= Spree.t(:added) %></legend>
-  <%= render partial: 'transfer_item_table', locals: { transfer_items: @stock_transfer.transfer_items, show_expected: true, show_received: false, show_actions: true } %>
-</fieldset>

data/app/views/spree/admin/stock_transfers/index.html.erb

@@ -1,123 +0,0 @@
-<% admin_breadcrumb(link_to Spree.t(:stock), spree.admin_stock_items_path) %>
-<% admin_breadcrumb(plural_resource_name(Spree::StockTransfer)) %>
-
-
-<% content_for :page_actions do %>
-  <% if can? :create, Spree::StockTransfer %>
-    <li>
-      <%= button_link_to Spree.t(:new_stock_transfer), new_admin_stock_transfer_path %>
-    </li>
-  <% end %>
-<% end %>
-
-<% content_for :table_filter_title do %>
-  <%= Spree.t(:search) %>
-<% end %>
-
-<% content_for :table_filter do %>
-  <div data-hook="admin_stock_transfers_index_search">
-    <%= search_form_for [:admin, @search] do |f| %>
-      <div class="row">
-        <div class="field-block col-3">
-          <div class="field">
-            <%= f.label nil, Spree::StockLocation.model_name.human %>
-            <%= f.select :source_location_id_or_destination_location_id_eq, options_from_collection_for_select(@stock_locations, :id, :name, params[:q][:source_location_id_or_destination_location_id_eq]), {include_blank: true}, {class: 'custom-select fullwidth'} %>
-          </div>
-        </div>
-
-        <div class="field-block col-3">
-          <div class="date-range-filter field">
-            <%= f.label nil, Spree.t(:date_range) %>
-            <div class="date-range-fields input-group">
-              <%= f.text_field :created_at_gt, class: 'datepicker datepicker-from form-control', include_blank: true, value: params[:q][:created_at_gt], placeholder: Spree.t(:start) %>
-
-              <span class="range-divider input-group-addon">
-                <i class="fa fa-arrow-right"></i>
-              </span>
-
-              <%= f.text_field :created_at_lt, class: 'datepicker datepicker-to form-control', include_blank: true, value: params[:q][:created_at_lt], placeholder: Spree.t(:stop) %>
-            </div>
-          </div>
-        </div>
-
-        <div class="field-block col-3">
-          <div class="field">
-            <%= f.label nil, Spree::StockTransfer.human_attribute_name(:number) %>
-            <%= f.text_field :number_cont, value: params[:q][:number_cont] %>
-          </div>
-        </div>
-
-        <div class="field-block col-3">
-          <div class="field checkbox">
-            <label>
-              <%= f.check_box :closed_at_null, { checked: @show_only_open }, '1', '0' %>
-              <%= Spree.t(:show_only_open_transfers) %>
-            </label>
-          </div>
-        </div>
-      </div>
-
-      <div class="clearfix"></div>
-
-      <div class="actions filter-actions">
-        <div data-hook="admin_stock_transfers_index_search_buttons">
-          <%= button Spree.t(:filter_results) %>
-        </div>
-      </div>
-    <% end %>
-  </div>
-<% end %>
-
-<%= paginate @stock_transfers, theme: "solidus_admin" %>
-
-
-<% if @stock_transfers.any? %>
-  <table class="index" id="listing_stock_transfers">
-    <thead>
-      <tr>
-        <th><%= sort_link @search, :number,          Spree.t(:number) %></th>
-        <th><%= sort_link @search, :from,            Spree.t(:from) %></th>
-        <th><%= sort_link @search, :to,              Spree.t(:to) %></th>
-        <th><%= sort_link @search, :expected_items,  Spree.t(:expected) %></th>
-        <th><%= sort_link @search, :received_items,  Spree.t(:received) %></th>
-        <th><%= sort_link @search, :shipped_at,      Spree.t(:shipped) %></th>
-        <th><%= sort_link @search, :status,          Spree.t(:status) %></th>
-        <th class="actions"></th>
-      </tr>
-    </thead>
-    <tbody>
-      <% @stock_transfers.each do |stock_transfer| %>
-        <tr id="<%= spree_dom_id stock_transfer %>">
-          <td><%= handle_stock_transfer(stock_transfer) %></td>
-          <td><%= stock_transfer.source_location.name %></td>
-          <td><%= stock_transfer.destination_location.try(:name) %></td>
-          <td><%= stock_transfer.expected_item_count %></td>
-          <td><%= stock_transfer.received_item_count %></td>
-          <td><%= stock_transfer.shipped_at.try(:to_date) %></td>
-          <td>
-            <span class="pill pill-<%= stock_transfer.closed? ? 'complete' : 'pending' %>">
-              <%= Spree.t(stock_transfer.closed? ? :closed : :open) %>
-            </span>
-          </td>
-          <td class="actions">
-            <% if stock_transfer.receivable? && can?(:edit, stock_transfer) %>
-              <%= link_to_with_icon 'download', Spree.t('actions.receive'), receive_admin_stock_transfer_path(stock_transfer), no_text: true, data: { action: 'receive' } %>
-            <% elsif !stock_transfer.closed? && can?(:edit, stock_transfer) %>
-              <%= link_to_with_icon 'edit', Spree.t('actions.edit'), stock_transfer_edit_or_ship_path(stock_transfer), no_text: true, data: { action: 'edit' } %>
-            <% elsif can?(:show, stock_transfer) %>
-              <%= link_to_with_icon 'eye', Spree.t(:show), admin_stock_transfer_path(stock_transfer), no_text: true, data: { action: 'show' } %>
-            <% end %>
-          </td>
-        </tr>
-      <% end %>
-    </tbody>
-  </table>
-<% else %>
-  <div class="col-9 no-objects-found">
-    <%= render 'spree/admin/shared/no_objects_found',
-                  resource: Spree::StockTransfer,
-                  new_resource_url: new_object_url %>
-  </div>
-<% end %>
-
-<%= paginate @stock_transfers, theme: "solidus_admin" %>

data/app/views/spree/admin/stock_transfers/new.html.erb

@@ -1,26 +0,0 @@
-<% admin_breadcrumb(link_to Spree.t(:stock), spree.admin_stock_items_path) %>
-<% admin_breadcrumb(link_to plural_resource_name(Spree::StockTransfer), spree.admin_stock_transfers_path) %>
-<% admin_breadcrumb(Spree.t(:new_stock_transfer)) %>
-
-
-<% content_for :page_actions do %>
-<% end %>
-
-<%= form_for [:admin, @stock_transfer] do |f| %>
-  <fieldset class="no-border-top">
-    <%= f.field_container :source_location do %>
-      <%= f.label :source_location_id %>
-      <%= f.select :source_location_id, options_from_collection_for_select(@source_stock_locations, :id, :name), {include_blank: true}, {class: 'custom-select fullwidth', "data-placeholder" => Spree.t(:select_a_stock_location)} %>
-      <%= f.error_message_on :source_location %>
-    <% end %>
-    <%= f.field_container :description do %>
-      <%= f.label :description %>
-      <%= f.text_field :description, maxlength: 255, size: 0, class: 'fullwidth' %>
-      <%= f.error_message_on :description %>
-    <% end %>
-    <div class="filter-actions actions" data-hook="buttons">
-      <%= button Spree.t(:continue) %>
-      <%= link_to Spree.t('actions.cancel'), admin_stock_transfers_path, class: 'button' %>
-    </div>
-  </fieldset>
-<% end %>

data/app/views/spree/admin/stock_transfers/receive.html.erb

@@ -1,38 +0,0 @@
-<% admin_breadcrumb("#{Spree.t(:receiving)} #{@stock_transfer.number}") %>
-
-
-<% content_for :page_actions do %>
-  <li>
-    <%= button_link_to Spree.t(:back_to_stock_transfers_list), admin_stock_transfers_path %>
-  </li>
-  <li>
-    <%= button_link_to Spree.t(:close),
-      close_admin_stock_transfer_path(@stock_transfer),
-      method: 'put',
-      data: { confirm: Spree.t('close_stock_transfer.confirm') } %>
-  </li>
-<% end %>
-
-<div id='stock_transfer_summary' class='fullwidth'>
-  <%= render 'spree/admin/stock_transfers/location', stock_transfer: @stock_transfer %>
-  <div class='count-summary'>
-    <span id='total-received-quantity'><%= @stock_transfer.received_item_count %></span>
-    /
-    <span><%= @stock_transfer.expected_item_count %></span>
-    <span class='summary-field'><%= Spree.t(:received) %></span>
-  </div>
-</div>
-
-<fieldset>
-  <legend align="center"><%= Spree.t(:variant_to_be_received) %></legend>
-  <div data-hook="transfer_item_selection">
-    <%= hidden_field_tag :stock_transfer_number, @stock_transfer.number %>
-    <%= hidden_field_tag :variant_display_attributes, @variant_display_attributes.to_json %>
-    <%= text_field_tag :transfer_item_variant_id, "", class: "variant_autocomplete fullwidth" %>
-  </div>
-</fieldset>
-
-<fieldset id='received-transfer-items'>
-  <legend align="center"><%= Spree.t(:received_items) %></legend>
-  <%= render partial: 'transfer_item_table', locals: { transfer_items: @received_items, show_expected: false, show_received: true, show_actions: true } %>
-</fieldset>

data/app/views/spree/admin/stock_transfers/show.html.erb

@@ -1,50 +0,0 @@
-<% admin_breadcrumb(link_to Spree.t(:stock), spree.admin_stock_items_path) %>
-<% admin_breadcrumb(Spree::StockTransfer.model_name.human, @stock_transfer.number) %>
-
-
-<% content_for :page_actions do %>
-  <li>
-    <%= button_link_to Spree.t(:back_to_stock_transfers_list), admin_stock_transfers_path %>
-  </li>
-<% end %>
-
-<fieldset class="no-border-bottom">
-  <%= render 'spree/admin/stock_transfers/location', stock_transfer: @stock_transfer %>
-
-  <div>
-    <label><%= Spree::StockTransfer.human_attribute_name(:description) %></label>
-    <p><%= @stock_transfer.description %></p>
-  </div>
-
-  <div class="row">
-    <div class='field-block col-3'>
-      <label><%= Spree::StockTransfer.human_attribute_name(:created_by_id) %></label>
-      <p><%= @stock_transfer.created_by.email %></p>
-    </div>
-
-    <div class='field-block col-2'>
-      <label><%= Spree::StockTransfer.human_attribute_name(:created_at) %></label>
-      <p><%= @stock_transfer.created_at.try(:to_date) %></p>
-    </div>
-
-    <div class='field-block col-2'>
-      <label><%= Spree::StockTransfer.human_attribute_name(:finalized_at) %></label>
-      <p><%= @stock_transfer.finalized_at.try(:to_date) %></p>
-    </div>
-
-    <div class='field-block col-3'>
-      <label><%= Spree::StockTransfer.human_attribute_name(:finalized_by_id) %></label>
-      <p><%= @stock_transfer.finalized_by.try(:email) %></p>
-    </div>
-
-    <div class='field-block col-2'>
-      <label><%= Spree::StockTransfer.human_attribute_name(:shipped_at) %></label>
-      <p><%= @stock_transfer.shipped_at.try(:to_date) %></p>
-    </div>
-  </div> 
-</fieldset>
-
-<fieldset>
-  <legend><%= plural_resource_name(Spree::TransferItem) %></legend>
-  <%= render partial: 'transfer_item_table', locals: { transfer_items: @stock_transfer.transfer_items, show_expected: true, show_received: true, show_actions: false } %>
-</fieldset>

data/app/views/spree/admin/stock_transfers/tracking_info.html.erb

@@ -1,46 +0,0 @@
-<% admin_breadcrumb("#{Spree.t('actions.ship')} #{Spree::StockTransfer.model_name.human} \##{@stock_transfer.number}") %>
-
-
-<% content_for :page_actions do %>
-  <li>
-    <%= button_link_to Spree.t(:back_to_stock_transfers_list), admin_stock_transfers_path %>
-  </li>
-  <li>
-    <%= button_link_to Spree.t('actions.ship'),
-      ship_admin_stock_transfer_path(@stock_transfer),
-      method: 'put',
-      data: { confirm: Spree.t('ship_stock_transfer.confirm') }
-      %>
-  </li>
-<% end %>
-
-<div id='stock_transfer_summary' class='fullwidth'>
-  <%= render 'spree/admin/stock_transfers/location', stock_transfer: @stock_transfer %>
-  <div class='shipment-description'>
-    <div class='summary-field creator'><%= Spree::StockTransfer.human_attribute_name(:created_by) %>: <%= @stock_transfer.created_by.email %></div>
-    <div class='summary-field description'><%= @stock_transfer.description %></div>
-  </div>
-</div>
-
-<fieldset>
-  <legend align='center'><%= Spree.t(:tracking_info) %></legend>
-    <%= form_for [:admin, @stock_transfer] do |f| %>
-    <div class='field-block'>
-      <div class='field'>
-        <%= f.label :tracking_number %>
-        <%= f.text_field :tracking_number, value: @stock_transfer.tracking_number, maxlength: 255, size: 0, class: 'fullwidth' %>
-      </div>
-    </div>
-
-    <div class='clearfix'></div>
-
-    <div class="actions filter-actions add_tracking_number">
-      <%= f.submit Spree.t('actions.save') %>
-    </div>
-  <% end %>
-</fieldset>
-
-<fieldset id='stock-transfer-transfer-items'>
-  <legend align="center"><%= plural_resource_name(Spree::TransferItem) %></legend>
-  <%= render partial: 'transfer_item_table', locals: { transfer_items: @stock_transfer.transfer_items, show_expected: true, show_received: false, show_actions: false } %>
-</fieldset>

data/spec/controllers/spree/admin/stock_transfers_controller_spec.rb

@@ -1,365 +0,0 @@
-require 'spec_helper'
-
-module Spree
-  describe Admin::StockTransfersController, type: :controller do
-    stub_authorization!
-
-    let(:warehouse) { StockLocation.create(name: "Warehouse") }
-    let(:ny_store) { StockLocation.create(name: "NY Store") }
-    let(:la_store) { StockLocation.create(name: "LA Store") }
-
-    context "#index" do
-      let!(:stock_transfer1) {
-        StockTransfer.create do |transfer|
-          transfer.source_location_id = warehouse.id
-          transfer.destination_location_id = ny_store.id
-        end
-      }
-
-      let!(:stock_transfer2) {
-        StockTransfer.create do |transfer|
-          transfer.source_location_id = warehouse.id
-          transfer.destination_location_id = la_store.id
-          transfer.finalized_at = DateTime.current
-          transfer.closed_at = DateTime.current
-        end
-      }
-
-      describe "stock location filtering" do
-        let(:user) { create(:admin_user) }
-        let(:ability) { Spree::Ability.new(user) }
-        let!(:sf_store) { StockLocation.create(name: "SF Store") }
-
-        before do
-          ability.cannot :manage, Spree::StockLocation
-          ability.can :display, Spree::StockLocation, id: [warehouse.id]
-          ability.can :display, Spree::StockLocation, id: [ny_store.id, la_store.id]
-
-          allow_any_instance_of(Spree::Admin::BaseController).to receive(:spree_current_user).and_return(user)
-          allow_any_instance_of(Spree::Admin::BaseController).to receive(:current_ability).and_return(ability)
-        end
-
-        it "doesn't display stock locations the user doesn't have access to" do
-          get :index
-          expect(assigns(:stock_locations)).to match_array [warehouse, ny_store, la_store]
-        end
-      end
-
-      it "searches by stock location" do
-        get :index, params: { q: { source_location_id_or_destination_location_id_eq: ny_store.id } }
-        expect(assigns(:stock_transfers).count).to eq 1
-        expect(assigns(:stock_transfers)).to include(stock_transfer1)
-      end
-
-      it "filters the closed stock transfers" do
-        get :index, params: { q: { closed_at_null: '1' } }
-        expect(assigns(:stock_transfers)).to match_array [stock_transfer1]
-      end
-
-      it "doesn't filter any stock transfers" do
-        get :index, params: { q: { closed_at_null: '0' } }
-        expect(assigns(:stock_transfers)).to match_array [stock_transfer1, stock_transfer2]
-      end
-    end
-
-    context "#create" do
-      let(:warehouse) { StockLocation.create(name: "Warehouse", active: false) }
-
-      subject do
-        post :create, params: { stock_transfer: { source_location_id: warehouse.id, description: nil } }
-      end
-
-      context "user doesn't have read access to the selected stock location" do
-        before do
-          expect(controller).to receive(:authorize!) { raise CanCan::AccessDenied }
-        end
-
-        it "redirects to authorization_failure" do
-          subject
-          expect(response).to redirect_to('/unauthorized')
-        end
-      end
-
-      context "valid parameters" do
-        let!(:user) { create(:user) }
-
-        before do
-          allow(controller).to receive(:try_spree_current_user) { user }
-        end
-
-        it "redirects to the edit page" do
-          subject
-          expect(response).to redirect_to(spree.edit_admin_stock_transfer_path(assigns(:stock_transfer)))
-        end
-
-        it "sets the created_by to the current user" do
-          subject
-          expect(assigns(:stock_transfer).created_by).to eq(user)
-        end
-      end
-
-      # Regression spec for Solidus issue #1087
-      context "missing source_stock_location parameter" do
-        subject do
-          post :create, params: { stock_transfer: { source_location_id: nil, description: nil } }
-        end
-
-        it "sets a flash error" do
-          subject
-          expect(flash[:error]).to eq assigns(:stock_transfer).errors.full_messages.join(', ')
-        end
-      end
-    end
-
-    context "#receive" do
-      let!(:transfer_with_items) { create(:receivable_stock_transfer_with_items) }
-      let(:variant_1)            { transfer_with_items.transfer_items[0].variant }
-      let(:variant_2)            { transfer_with_items.transfer_items[1].variant }
-      let(:parameters)           { { id: transfer_with_items.to_param } }
-
-      subject do
-        get :receive, params: parameters
-      end
-
-      context 'stock transfer is not receivable' do
-        before do
-          transfer_with_items.update_attributes(finalized_at: nil, shipped_at: nil)
-        end
-
-        it 'redirects back to index' do
-          subject
-          expect(flash[:error]).to eq Spree.t(:stock_transfer_must_be_receivable)
-          expect(response).to redirect_to(spree.admin_stock_transfers_path)
-        end
-      end
-
-      context "no items have been received" do
-        let(:parameters) do
-          { id: transfer_with_items.to_param }
-        end
-
-        before { subject }
-
-        it "doesn't assign received_items" do
-          expect(assigns(:received_items)).to be_empty
-        end
-      end
-
-      context "some items have been received" do
-        let(:transfer_item) { transfer_with_items.transfer_items.first }
-        let(:parameters) do
-          { id: transfer_with_items.to_param, variant_search_term: variant_1.sku }
-        end
-
-        before do
-          transfer_item.update_attributes(received_quantity: 1)
-          subject
-        end
-
-        it "assigns received_items correctly" do
-          expect(assigns(:received_items)).to match_array [transfer_item]
-        end
-      end
-    end
-
-    context "#finalize" do
-      let!(:user) { create(:user) }
-      let!(:transfer_with_items) { create(:receivable_stock_transfer_with_items, finalized_at: nil, shipped_at: nil) }
-
-      before do
-        allow(controller).to receive(:try_spree_current_user) { user }
-      end
-
-      subject do
-        put :finalize, params: { id: transfer_with_items.to_param }
-      end
-
-      context 'stock transfer is not finalizable' do
-        before do
-          transfer_with_items.update_attributes(finalized_at: Time.current)
-        end
-
-        it 'redirects back to edit' do
-          subject
-          expect(flash[:error]).to eq Spree.t(:stock_transfer_cannot_be_finalized)
-          expect(response).to redirect_to(spree.edit_admin_stock_transfer_path(transfer_with_items))
-        end
-      end
-
-      context "successfully finalized" do
-        it "redirects to tracking_info" do
-          subject
-          expect(response).to redirect_to(spree.tracking_info_admin_stock_transfer_path(transfer_with_items))
-        end
-
-        it "sets the finalized_by to the current user" do
-          subject
-          expect(transfer_with_items.reload.finalized_by).to eq(user)
-        end
-
-        it "sets the finalized_at date" do
-          subject
-          expect(transfer_with_items.reload.finalized_at).to_not be_nil
-        end
-      end
-
-      context "error finalizing the stock transfer" do
-        before do
-          transfer_with_items.update_attributes(destination_location_id: nil)
-        end
-
-        it "redirects back to edit" do
-          subject
-          expect(response).to redirect_to(spree.edit_admin_stock_transfer_path(transfer_with_items))
-        end
-
-        it "displays a flash error message" do
-          subject
-          expect(flash[:error]).to eq "Destination location can't be blank"
-        end
-      end
-    end
-
-    context "#close" do
-      let!(:user) { create(:user) }
-      let!(:transfer_with_items) { create(:receivable_stock_transfer_with_items) }
-
-      before do
-        allow(controller).to receive(:try_spree_current_user) { user }
-      end
-
-      subject do
-        put :close, params: { id: transfer_with_items.to_param }
-      end
-
-      context 'stock transfer is not receivable' do
-        before do
-          transfer_with_items.update_attributes(finalized_at: nil, shipped_at: nil)
-        end
-
-        it 'redirects back to receive' do
-          subject
-          expect(flash[:error]).to eq Spree.t(:stock_transfer_must_be_receivable)
-          expect(response).to redirect_to(spree.receive_admin_stock_transfer_path(transfer_with_items))
-        end
-      end
-
-      context "successfully closed" do
-        it "redirects back to index" do
-          subject
-          expect(response).to redirect_to(spree.admin_stock_transfers_path)
-        end
-
-        it "sets the closed_by to the current user" do
-          subject
-          expect(transfer_with_items.reload.closed_by).to eq(user)
-        end
-
-        it "sets the closed_at date" do
-          subject
-          expect(transfer_with_items.reload.closed_at).to_not be_nil
-        end
-
-        context "stock movements" do
-          let(:source)          { transfer_with_items.source_location }
-          let(:destination)     { transfer_with_items.destination_location }
-          let(:transfer_item_1) { transfer_with_items.transfer_items[0] }
-          let(:transfer_item_2) { transfer_with_items.transfer_items[1] }
-
-          before do
-            transfer_item_1.update_columns(received_quantity: 2)
-            transfer_item_2.update_columns(received_quantity: 5)
-            subject
-          end
-
-          it 'creates 2 stock movements' do
-            expect(assigns(:stock_movements).length).to eq 2
-          end
-
-          it 'sets the stock transfer as the originator of the stock movements' do
-            subject
-            originators = assigns(:stock_movements).map(&:originator)
-            expect(originators).to match_array [transfer_with_items, transfer_with_items]
-          end
-
-          it 'only creates stock movements for the destination stock location' do
-            subject
-            locations = assigns(:stock_movements).map(&:stock_item).flat_map(&:stock_location)
-            expect(locations).to match_array [destination, destination]
-          end
-
-          it 'creates the stock movements for the received quantities' do
-            subject
-            movement_for_transfer_item_1 = assigns(:stock_movements).find { |sm| sm.stock_item.variant == transfer_item_1.variant }
-            expect(movement_for_transfer_item_1.quantity).to eq 2
-            movement_for_transfer_item_2 = assigns(:stock_movements).find { |sm| sm.stock_item.variant == transfer_item_2.variant }
-            expect(movement_for_transfer_item_2.quantity).to eq 5
-          end
-        end
-      end
-
-      context "error closing the stock transfer" do
-        before do
-          transfer_with_items.update_columns(destination_location_id: nil)
-        end
-
-        it "redirects back to receive" do
-          subject
-          expect(response).to redirect_to(spree.receive_admin_stock_transfer_path(transfer_with_items))
-        end
-
-        it "displays a flash error message" do
-          subject
-          expect(flash[:error]).to eq "Destination location can't be blank"
-        end
-      end
-    end
-
-    context "#ship" do
-      let(:stock_transfer) { Spree::StockTransfer.create(source_location: warehouse, destination_location: ny_store, created_by: create(:admin_user)) }
-      let(:transfer_variant) { create(:variant) }
-      let(:warehouse_stock_item) { warehouse.stock_items.find_by(variant: transfer_variant) }
-      let(:ny_stock_item) { ny_store.stock_items.find_by(variant: transfer_variant) }
-
-      subject { put :ship, params: { id: stock_transfer.number } }
-
-      before do
-        warehouse_stock_item.set_count_on_hand(1)
-        stock_transfer.transfer_items.create!(variant: transfer_variant, expected_quantity: 1)
-      end
-
-      context "with transferable items" do
-        it "marks the transfer shipped" do
-          subject
-
-          expect(stock_transfer.reload.shipped_at).to_not be_nil
-          expect(flash[:success]).to be_present
-        end
-
-        it "makes stock movements for the transferred items" do
-          subject
-
-          expect(Spree::StockMovement.count).to eq 1
-          expect(warehouse_stock_item.reload.count_on_hand).to eq 0
-        end
-      end
-
-      context "with non-transferable items" do
-        before { warehouse_stock_item.set_count_on_hand(0) }
-
-        it "does not mark the transfer shipped" do
-          subject
-
-          expect(stock_transfer.reload.shipped_at).to be_nil
-        end
-
-        it "errors and redirects to tracking_info page" do
-          subject
-
-          expect(flash[:error]).to match /not enough inventory/
-          expect(response).to redirect_to(spree.tracking_info_admin_stock_transfer_path(stock_transfer))
-        end
-      end
-    end
-  end
-end