solidus_backend 2.10.2 → 2.11.3

data/spec/features/admin/products/edit/variants_spec.rb

@@ -1,63 +0,0 @@
-# frozen_string_literal: true
-
-require 'spec_helper'
-
-describe "Product Variants", type: :feature do
-  stub_authorization!
-
-  before(:each) do
-    visit spree.admin_path
-  end
-
-  context "editing variant option types", js: true do
-    let!(:product) { create(:product) }
-
-    it "should allow an admin to create option types for a variant" do
-      click_nav "Products"
-
-      within_row(1) { click_icon :edit }
-
-      within('nav > ul.tabs') { click_link "Variants" }
-      expect(page).to have_content("To add variants, you must first define")
-    end
-
-    it "allows admin to create a variant if there are option types" do
-      click_nav "Products"
-      click_link "Option Types"
-      click_link "new_option_type_link"
-      fill_in "option_type_name", with: "shirt colors"
-      fill_in "option_type_presentation", with: "colors"
-      click_button "Create"
-      expect(page).to have_content("successfully created!")
-
-      page.find('#option_type_option_values_attributes_0_name').set('color')
-      page.find('#option_type_option_values_attributes_0_presentation').set('black')
-      click_button "Update"
-      expect(page).to have_content("successfully updated!")
-
-      visit spree.admin_path
-      click_nav "Products"
-      within('table.index tbody tr:nth-child(1)') do
-        click_icon :edit
-      end
-
-      select2_search "shirt", from: "Option Types"
-      click_button "Update"
-      expect(page).to have_content("successfully updated!")
-
-      within('nav > ul.tabs') { click_link "Variants" }
-      click_link "New Variant"
-
-      select "black", from: "Colors"
-      fill_in "variant_sku", with: "A100"
-      click_button "Create"
-      expect(page).to have_content("successfully created!")
-
-      within(".index") do
-        expect(page).to have_content("19.99")
-        expect(page).to have_content("black")
-        expect(page).to have_content("A100")
-      end
-    end
-  end
-end

data/spec/features/admin/products/option_types_spec.rb

@@ -1,116 +0,0 @@
-# frozen_string_literal: true
-
-require 'spec_helper'
-
-describe "Option Types", type: :feature do
-  stub_authorization!
-
-  before(:each) do
-    visit spree.admin_path
-    click_nav "Products"
-  end
-
-  context "listing option types" do
-    it "should list existing option types" do
-      create(:option_type, name: "tshirt-color", presentation: "Color")
-      create(:option_type, name: "tshirt-size", presentation: "Size")
-
-      click_link "Option Types"
-      within("table#listing_option_types") do
-        expect(page).to have_content("Color")
-        expect(page).to have_content("tshirt-color")
-        expect(page).to have_content("Size")
-        expect(page).to have_content("tshirt-size")
-      end
-    end
-  end
-
-  context "creating a new option type" do
-    it "should allow an admin to create a new option type", js: true do
-      click_link "Option Types"
-      click_link "new_option_type_link"
-      expect(page).to have_content("New Option Type")
-      fill_in "option_type_name", with: "shirt colors"
-      fill_in "option_type_presentation", with: "colors"
-      click_button "Create"
-      expect(page).to have_content("successfully created!")
-
-      page.find('#option_type_option_values_attributes_0_name').set('color')
-      page.find('#option_type_option_values_attributes_0_presentation').set('black')
-
-      click_button "Update"
-      expect(page).to have_content("successfully updated!")
-    end
-  end
-
-  context "editing an existing option type" do
-    it "should allow an admin to update an existing option type" do
-      create(:option_type, name: "tshirt-color", presentation: "Color")
-      create(:option_type, name: "tshirt-size", presentation: "Size")
-      click_link "Option Types"
-      within('table#listing_option_types') do
-        find('tr', text: 'Size').click_link "Edit"
-      end
-      fill_in "option_type_name", with: "foo-size 99"
-      click_button "Update"
-      expect(page).to have_content("successfully updated!")
-      expect(page).to have_content("foo-size 99")
-    end
-  end
-
-  # Regression test for https://github.com/spree/spree/issues/2277
-  it "can remove an option value from an option type", js: true do
-    option_value = create(:option_value)
-    click_link "Option Types"
-    within('table#listing_option_types') { click_icon :edit }
-    expect(page).to have_title("#{option_value.option_type.name} - Option Types - Products")
-    expect(page).to have_css("tbody#option_values tr", count: 1)
-    within("tbody#option_values") do
-      find('.spree_remove_fields').click
-    end
-    # Assert that the field is hidden automatically
-    expect(page).to have_no_css("tbody#option_values tr")
-
-    # Ensure the DELETE request finishes
-    expect(page).to have_no_css("#progress")
-
-    # Then assert that on a page refresh that it's still not visible
-    visit page.current_url
-    # What *is* visible is a new option value field, with blank values
-    # Sometimes the page doesn't load before the all check is done
-    # lazily finding the element gives the page 10 seconds
-    expect(page).to have_css("tbody#option_values")
-    all("tbody#option_values tr input", count: 2).each do |input|
-      expect(input.value).to be_blank
-    end
-  end
-
-  # Regression test for https://github.com/spree/spree/issues/3204
-  it "can remove a non-persisted option value from an option type", js: true do
-    create(:option_type)
-    click_link "Option Types"
-    within('table#listing_option_types') { click_icon :edit }
-
-    expect(page).to have_css("tbody#option_values tr", count: 1)
-
-    # Add a new option type
-    click_link "Add Option Value"
-    expect(page).to have_css("tbody#option_values tr", count: 2)
-
-    # Remove default option type
-    within("tbody#option_values") do
-      within_row(1) do
-        find('.fa-trash').click
-      end
-    end
-    # Assert that the field is hidden automatically
-    expect(page).to have_css("tbody#option_values tr", count: 1)
-
-    # Remove added option type
-    within("tbody#option_values") do
-      find('.fa-trash').click
-    end
-    # Assert that the field is hidden automatically
-    expect(page).to have_css("tbody#option_values tr", count: 0)
-  end
-end

data/spec/features/admin/products/pricing_spec.rb

@@ -1,127 +0,0 @@
-# frozen_string_literal: true
-
-require 'spec_helper'
-
-describe 'Pricing' do
-  stub_authorization!
-
-  let(:product) { create(:product) }
-
-  before do
-    visit spree.edit_admin_product_path(product)
-  end
-
-  it 'has a Prices tab' do
-    within(".tabs") do
-      expect(page).to have_link("Prices")
-    end
-  end
-
-  context "in the prices tab" do
-    let!(:country) { create :country, iso: "DE" }
-    let(:master_price) { product.master.default_price }
-    let!(:other_price) { product.master.prices.create(amount: 34.56, currency: "RUB", country_iso: "DE") }
-
-    before do
-      visit spree.admin_product_prices_path(product)
-    end
-
-    it 'displays a table with the prices' do
-      expect(page).to have_content(product.name)
-      within(".tabs .active") do
-        expect(page).to have_content("Prices")
-      end
-
-      within('table.master_prices') do
-        expect(page).to have_content("$19.99")
-        expect(page).to have_content("USD")
-        expect(page).to have_content("34.56 ₽")
-        expect(page).to have_content("RUB")
-        expect(page).to have_content("Any Country")
-        expect(page).to have_content("Germany")
-      end
-    end
-
-    context "searching" do
-      let(:variant) { create(:variant, price: 20) }
-      let(:product) { variant.product }
-
-      before do
-        product.master.update(price: 49.99)
-      end
-
-      it 'has a working table filter' do
-        expect(page).to have_selector("#table-filter")
-        within "#table-filter" do
-          within "fieldset legend" do
-            expect(page).to have_content("Search")
-          end
-        end
-        select variant.options_text, from: "q_variant_id_eq", exact: false
-        click_button "Filter Results"
-        expect(page).to have_content("20")
-        expect(page).to_not have_content("49.99")
-      end
-    end
-
-    context "editing" do
-      let(:product) { create(:product, price: 123.99) }
-      let!(:variant) { product.master }
-      let!(:other_price) { product.master.prices.create(amount: 34.56, currency: "EUR") }
-
-      it 'has a working edit page' do
-        within "#spree_price_#{product.master.prices.first.id}" do
-          click_icon :edit
-        end
-        expect(page).to have_content("Edit Price")
-
-        within("#price_price_field") do
-          expect(page).to have_field('price_price', with: '123.99')
-        end
-
-        fill_in "price_price", with: 999.99
-        click_button "Update"
-        expect(page).to have_content("Price has been successfully updated!")
-        expect(page).to have_content("$999.99")
-        expect(page).to have_content("€34.56")
-      end
-
-      it "will not reset the currency to default" do
-        within "#spree_price_#{other_price.id}" do
-          click_icon :edit
-        end
-        expect(page).to have_content("Edit Price")
-        expect(page).to_not have_field('price_currency', with: 'USD')
-        within("#price_price_field") do
-          expect(page).to have_css('.number-with-currency-addon', text: 'EUR')
-        end
-      end
-    end
-
-    context "deleting", js: true do
-      let(:product) { create(:product, price: 65.43) }
-      let!(:variant) { product.master }
-      let!(:other_price) { product.master.prices.create(amount: 34.56, currency: "EUR") }
-
-      it "will delete the non-default price" do
-        within "#spree_price_#{other_price.id}" do
-          accept_alert do
-            click_icon :trash
-          end
-        end
-        expect(page).to have_content("Price has been successfully removed")
-      end
-
-      it "does not break when default price is deleted" do
-        within "#spree_price_#{variant.default_price.id}" do
-          accept_alert do
-            click_icon :trash
-          end
-        end
-        expect(page).to have_content("Price has been successfully removed")
-        visit spree.admin_products_path
-        expect(page).to have_selector("#spree_product_#{product.id}")
-      end
-    end
-  end
-end

data/spec/features/admin/products/products_spec.rb

@@ -1,348 +0,0 @@
-# frozen_string_literal: true
-
-require 'spec_helper'
-
-describe "Products", type: :feature do
-  context "as admin user" do
-    stub_authorization!
-
-    before(:each) do
-      visit spree.admin_path
-    end
-
-    def build_option_type_with_values(name, values)
-      ot = FactoryBot.create(:option_type, name: name)
-      values.each do |val|
-        ot.option_values.create(name: val.downcase, presentation: val)
-      end
-      ot
-    end
-
-    context "listing products" do
-      context "sorting" do
-        before do
-          create(:product, name: 'apache baseball cap', price: 10)
-          create(:product, name: 'zomg shirt', price: 5)
-        end
-
-        it "should list existing products with correct sorting by name" do
-          click_nav "Products"
-          # Name ASC
-          within_row(1) { expect(page).to have_content('apache baseball cap') }
-          within_row(2) { expect(page).to have_content("zomg shirt") }
-
-          # Name DESC
-          click_link "admin_products_listing_name_title"
-          within_row(1) { expect(page).to have_content("zomg shirt") }
-          within_row(2) { expect(page).to have_content('apache baseball cap') }
-        end
-
-        it "should list existing products with correct sorting by price" do
-          click_nav "Products"
-
-          # Name ASC (default)
-          within_row(1) { expect(page).to have_content('apache baseball cap') }
-          within_row(2) { expect(page).to have_content("zomg shirt") }
-
-          # Price DESC
-          click_link "admin_products_listing_price_title"
-          within_row(1) { expect(page).to have_content("zomg shirt") }
-          within_row(2) { expect(page).to have_content('apache baseball cap') }
-        end
-      end
-
-      context "currency displaying" do
-        context "using Russian Rubles" do
-          before do
-            stub_spree_preferences(currency: "RUB")
-          end
-
-          let!(:product) do
-            create(:product, name: "Just a product", price: 19.99)
-          end
-
-          # Regression test for https://github.com/spree/spree/issues/2737
-          context "uses руб as the currency symbol" do
-            it "on the products listing page" do
-              visit spree.admin_products_path
-              within_row(1) { expect(page).to have_content("19.99 ₽") }
-            end
-          end
-        end
-      end
-      context "when none of the product prices are in the same currency as the default in the store" do
-        before do
-          stub_spree_preferences(currency: "MXN")
-        end
-
-        let!(:product) do
-          create(:product, name: "Just a product", price: 19.99)
-        end
-
-        it 'defaults it to Spree::Config.currency and sets the price as blank' do
-          stub_spree_preferences(currency: "USD")
-          visit spree.admin_product_path(product)
-          within("#product_price_field") do
-            expect(page).to have_content("USD")
-          end
-        end
-      end
-    end
-
-    context "searching products" do
-      it "should be able to search deleted products", js: true do
-        create(:product, name: 'apache baseball cap', deleted_at: "2011-01-06 18:21:13")
-        create(:product, name: 'zomg shirt')
-
-        click_nav "Products"
-        expect(page).to have_content("zomg shirt")
-        expect(page).not_to have_content("apache baseball cap")
-        check "Show Deleted"
-        click_button 'Search'
-        expect(find('input[name="q[with_deleted]"]')).to be_checked
-        expect(page).to have_content("zomg shirt")
-        expect(page).to have_content("apache baseball cap")
-        uncheck "Show Deleted"
-        click_button 'Search'
-        expect(page).to have_content("zomg shirt")
-        expect(page).not_to have_content("apache baseball cap")
-      end
-
-      it "should be able to search products by their properties" do
-        create(:product, name: 'apache baseball cap', sku: "A100")
-        create(:product, name: 'apache baseball cap2', sku: "B100")
-        create(:product, name: 'zomg shirt')
-
-        click_nav "Products"
-        fill_in "Name", with: "ap"
-        click_button 'Search'
-        expect(page).to have_content("apache baseball cap")
-        expect(page).to have_content("apache baseball cap2")
-        expect(page).not_to have_content("zomg shirt")
-
-        fill_in "SKU", with: "A1"
-        click_button "Search"
-        expect(page).to have_content("apache baseball cap")
-        expect(page).not_to have_content("apache baseball cap2")
-        expect(page).not_to have_content("zomg shirt")
-      end
-
-      # Regression test for https://github.com/solidusio/solidus/issues/2016
-      it "should be able to search and sort by price" do
-        product = create(:product, name: 'apache baseball cap', sku: "A001")
-        create(:variant, product: product, sku: "A002")
-        create(:product, name: 'zomg shirt', sku: "Z001")
-
-        click_nav "Products"
-        expect(page).to have_content("apache baseball cap")
-        expect(page).to have_content("zomg shirt")
-        expect(page).to have_css('#listing_products > tbody > tr', count: 2)
-
-        fill_in "SKU", with: "A"
-        click_button 'Search'
-        expect(page).to have_content("apache baseball cap")
-        expect(page).not_to have_content("zomg shirt")
-        expect(page).to have_css('#listing_products > tbody > tr', count: 1)
-
-        # Sort by master price
-        click_on 'Master Price'
-        expect(page).to have_css('.sort_link.asc', text: 'Master Price')
-        expect(page).to have_content("apache baseball cap")
-        expect(page).not_to have_content("zomg shirt")
-        expect(page).to have_css('#listing_products > tbody > tr', count: 1)
-      end
-    end
-
-    context "creating a new product" do
-      before(:each) do
-        @shipping_category = create(:shipping_category)
-        click_nav "Products"
-        click_on "New Product"
-      end
-
-      it "should allow an admin to create a new product", js: true do
-        fill_in "product_name", with: "Baseball Cap"
-        fill_in "product_sku", with: "B100"
-        fill_in "product_price", with: "100"
-        fill_in "product_available_on", with: "2012/01/24"
-        select @shipping_category.name, from: "product_shipping_category_id"
-        click_button "Create"
-        expect(page).to have_content("successfully created!")
-        click_button "Update"
-        expect(page).to have_content("successfully updated!")
-      end
-
-      it "disables the button at submit", :js do
-        page.execute_script "$('form').submit(function(e) { e.preventDefault()})"
-        fill_in "product_name", with: "Baseball Cap"
-        fill_in "product_sku", with: "B100"
-        fill_in "product_price", with: "100"
-        fill_in "product_available_on", with: "2012/01/24"
-        select @shipping_category.name, from: "product_shipping_category_id"
-        click_button "Create"
-
-        expect(page).to have_button("Create", disabled: true)
-      end
-
-      it "should show validation errors", js: false do
-        fill_in "product_name", with: "Baseball Cap"
-        fill_in "product_sku", with: "B100"
-        fill_in "product_price", with: "100"
-        click_button "Create"
-        expect(page).to have_content("Shipping category can't be blank")
-      end
-
-      context "using a locale with a different decimal format " do
-        before do
-          # change English locale’s separator and delimiter to match 19,99 format
-          I18n.backend.store_translations(:en,
-            number: {
-              currency: {
-                format: {
-                  separator: ",",
-                  delimiter: "."
-                }
-              }
-            })
-        end
-
-        after do
-          # revert changes to English locale
-          I18n.backend.store_translations(:en,
-            number: {
-              currency: {
-                format: {
-                  separator: ".",
-                  delimiter: ","
-                }
-              }
-            })
-        end
-
-        it "should show localized price value on validation errors", js: true do
-          fill_in "Name", with: " "
-          select @shipping_category.name, from: "product_shipping_category_id"
-          fill_in "product_price", with: "19,99"
-          click_button "Create"
-          expect(page).to have_content("Name can't be blank")
-          expect(page).to have_field('product_price', with: '19,99')
-        end
-      end
-
-      # Regression test for https://github.com/spree/spree/issues/2097
-      it "can set the count on hand to a null value", js: true do
-        fill_in "product_name", with: "Baseball Cap"
-        fill_in "product_price", with: "100"
-        select @shipping_category.name, from: "product_shipping_category_id"
-        click_button "Create"
-        expect(page).to have_content("successfully created!")
-        click_button "Update"
-        expect(page).to have_content("successfully updated!")
-      end
-    end
-
-    context "cloning a product", js: true do
-      it "should allow an admin to clone a product" do
-        create(:product)
-
-        click_nav "Products"
-        within_row(1) do
-          click_icon :copy
-        end
-
-        expect(page).to have_content("Product has been cloned")
-      end
-
-      context "cloning a deleted product" do
-        it "should allow an admin to clone a deleted product" do
-          create(:product, name: "apache baseball cap")
-
-          click_nav "Products"
-          check "Show Deleted"
-          click_button "Search"
-
-          expect(page).to have_content("apache baseball cap")
-
-          within_row(1) do
-            click_icon :copy
-          end
-
-          expect(page).to have_content("Product has been cloned")
-        end
-      end
-    end
-
-    context 'updating a product', js: true do
-      let(:product) { create(:product) }
-
-      it 'should parse correctly available_on' do
-        visit spree.admin_product_path(product)
-        fill_in "product_available_on", with: "2012/12/25"
-        click_button "Update"
-        expect(page).to have_content("successfully updated!")
-        expect(Spree::Product.last.available_on).to eq('Tue, 25 Dec 2012 00:00:00 UTC +00:00')
-      end
-    end
-
-    context 'deleting a product', js: true do
-      let!(:product) { create(:product) }
-
-      it "product details are still viewable" do
-        visit spree.admin_products_path
-
-        expect(page).to have_content(product.name)
-        accept_alert do
-          click_icon :trash
-        end
-
-        expect(page).to have_no_content(product.name)
-
-        # This will show our deleted product
-        check "Show Deleted"
-        click_button "Search"
-        click_link product.name
-        expect(page).to_not have_field('Master Price')
-        expect(page).to_not have_content('Images')
-        expect(page).to_not have_content('Prices')
-        expect(page).to_not have_content('Product Properties')
-      end
-    end
-  end
-
-  context 'with only product permissions' do
-    before do
-      allow_any_instance_of(Spree::Admin::BaseController).to receive(:try_spree_current_user).and_return(nil)
-    end
-
-    custom_authorization! do |_user|
-      can [:admin, :update, :index, :read], Spree::Product
-    end
-    let!(:product) { create(:product) }
-
-    it "should only display accessible links on index" do
-      visit spree.admin_products_path
-      expect(page).to have_link('Products')
-      expect(page).not_to have_link('Option Types')
-      expect(page).not_to have_link('Properties')
-
-      expect(page).not_to have_link('New Product')
-      expect(page).not_to have_css('a.clone')
-      expect(page).to have_css('a.edit')
-      expect(page).not_to have_css('a.delete-resource')
-    end
-
-    it "should only display accessible links on edit" do
-      visit spree.admin_product_path(product)
-
-      # product tabs should be hidden
-      expect(page).to have_link('Product Details')
-      expect(page).not_to have_link('Images')
-      expect(page).not_to have_link('Variants')
-      expect(page).not_to have_link('Product Properties')
-      expect(page).not_to have_link('Stock Management')
-
-      # no create permission
-      expect(page).not_to have_link('New Product')
-    end
-  end
-end