solidus_backend 2.10.2 → 2.11.0

data/spec/features/admin/orders/risk_analysis_spec.rb

@@ -1,49 +0,0 @@
-# frozen_string_literal: true
-
-require 'spec_helper'
-
-describe 'Order Risk Analysis', type: :feature do
-  stub_authorization!
-
-  let!(:order) do
-    create(:completed_order_with_pending_payment)
-  end
-
-  def visit_order
-    visit spree.admin_path
-    click_link 'Orders'
-    within_row(1) do
-      click_link order.number
-    end
-  end
-
-  context "the order is considered risky" do
-    before do
-      allow_any_instance_of(Spree::Admin::BaseController).to receive_messages try_spree_current_user: create(:user)
-
-      order.payments.first.update_column(:avs_response, 'N')
-      visit_order
-    end
-
-    it "displays 'Risk Analysis' box" do
-      expect(page).to have_content 'Risk Analysis'
-    end
-
-    it "can be approved" do
-      click_button('Approve')
-      expect(page).to have_content 'Approver'
-      expect(page).to have_content 'Approved at'
-      expect(page).to have_content 'Status: Complete'
-    end
-  end
-
-  context "the order is not considered risky" do
-    before do
-      visit_order
-    end
-
-    it "does not display 'Risk Analysis' box" do
-      expect(page).to_not have_content 'Risk Analysis'
-    end
-  end
-end

data/spec/features/admin/orders/shipments_spec.rb

@@ -1,145 +0,0 @@
-# frozen_string_literal: true
-
-require 'spec_helper'
-
-describe "Shipments", type: :feature do
-  include OrderFeatureHelper
-
-  stub_authorization!
-
-  let!(:order) { create(:order_ready_to_ship, number: "R100", state: "complete", line_items_count: 5) }
-
-  # Regression test for https://github.com/spree/spree/issues/4025
-  context "a shipment without a shipping method" do
-    before do
-      order.shipments.each do |s|
-        # Deleting the shipping rates causes there to be no shipping methods
-        s.shipping_rates.delete_all
-      end
-    end
-
-    it "can still be displayed" do
-      visit spree.edit_admin_order_path(order)
-    end
-  end
-
-  context "shipping an order", js: true do
-    before(:each) do
-      visit spree.admin_path
-      click_link "Orders"
-      within_row(1) do
-        click_link "R100"
-      end
-    end
-
-    def ship_shipment
-      find(".ship-shipment-button").click
-
-      expect(page).to have_content("Shipped package")
-      expect(order.reload.shipment_state).to eq("shipped")
-    end
-
-    it "can ship a completed order" do
-      expect {
-        perform_enqueued_jobs {
-          ship_shipment
-        }
-      }.to change{ ActionMailer::Base.deliveries.count }.by(1)
-    end
-
-    it "doesn't send a shipping confirmation email when ask to suppress the mailer" do
-      uncheck 'Send Mailer'
-
-      expect {
-        perform_enqueued_jobs {
-          ship_shipment
-        }
-      }.not_to change{ ActionMailer::Base.deliveries.count }
-    end
-  end
-
-  context "destroying a shipment", js: true do
-    before do
-      visit spree.admin_path
-      click_link "Orders"
-      within_row(1) do
-        click_link "R100"
-      end
-    end
-
-    context "when the line item cannot be found" do
-      it "shows the proper error message" do
-        expect(page).to have_selector '.delete-item'
-        order.shipments.first.line_items.each(&:destroy)
-        accept_alert { first('.delete-item').click }
-        expect(page).to have_content 'The resource you were looking for could not be found.'
-      end
-    end
-
-    context "when the shipment has already been shipped" do
-      it "shows the proper error message" do
-        expect(page).to have_selector '.delete-item'
-        order.shipments.first.ship!
-        accept_alert { first('.delete-item').click }
-        expect(page).to have_content 'Cannot remove items from a shipped shipment'
-      end
-    end
-  end
-
-  context "moving variants between shipments", js: true do
-    let!(:order) { create(:completed_order_with_pending_payment, number: "R100", state: "complete", line_items_count: 5) }
-    let!(:la) { create(:stock_location, name: "LA") }
-    before(:each) do
-      visit spree.admin_path
-      click_link "Orders"
-      within_row(1) do
-        click_link "R100"
-      end
-    end
-
-    it "can move a variant to a new and to an existing shipment" do
-      expect(order.shipments.count).to eq(1)
-      shipment1 = order.shipments[0]
-
-      within('tr', text: order.line_items[0].sku) { click_icon 'arrows-h' }
-      complete_split_to('LA')
-
-      expect(page).to have_css("#shipment_#{shipment1.id} tr.stock-item", count: 4)
-      shipment2 = (order.reload.shipments.to_a - [shipment1]).first
-      expect(page).to have_css("#shipment_#{shipment2.id} tr.stock-item", count: 1)
-      within "#shipment_#{shipment2.id}" do
-        expect(page).to have_content("UPS Ground")
-      end
-
-      within('tr', text: order.line_items[1].sku) { click_icon 'arrows-h' }
-      complete_split_to("LA(#{shipment2.number})")
-      expect(page).to have_css("#shipment_#{shipment2.id} tr.stock-item", count: 2)
-      expect(page).to have_css("#shipment_#{shipment1.id} tr.stock-item", count: 3)
-
-      within "#shipment_#{shipment2.id}" do
-        expect(page).to have_content("UPS Ground")
-      end
-    end
-
-    context "with a ready-to-ship order" do
-      let(:variant) { create(:variant) }
-      let!(:order) do
-        create(
-          :order_ready_to_ship,
-          number: "R100",
-          line_items_attributes: [{ variant: variant, quantity: 5 }]
-        )
-      end
-
-      it "can transfer all items to a new location" do
-        expect(order.shipments.count).to eq(1)
-
-        within('tr', text: order.line_items[0].sku) { click_icon 'arrows-h' }
-        complete_split_to('LA', quantity: 5)
-
-        expect(page).to_not have_content("package from 'NY Warehouse'")
-        expect(page).to have_content("package from 'LA'")
-      end
-    end
-  end
-end

data/spec/features/admin/payments/store_credits_spec.rb

@@ -1,23 +0,0 @@
-# frozen_string_literal: true
-
-require 'spec_helper'
-
-RSpec.describe 'Store credits', type: :feature do
-  stub_authorization!
-
-  let(:order) { FactoryBot.create(:completed_order_with_totals) }
-  let(:payment) do
-    FactoryBot.create(
-      :store_credit_payment,
-      order: order,
-      amount: 20
-    )
-  end
-
-  it "viewing a store credit payment" do
-    visit spree.admin_order_payment_path(order, payment)
-
-    expect(page).to have_content "Store Credit"
-    expect(page).to have_content "Amount: $20.00"
-  end
-end

data/spec/features/admin/products/edit/images_spec.rb

@@ -1,76 +0,0 @@
-# frozen_string_literal: true
-
-require 'spec_helper'
-
-describe "Product Images", type: :feature do
-  stub_authorization!
-
-  let(:file_path) { file_fixture("ror_ringer.jpeg") }
-  let(:product)   { create(:product) }
-
-  before do
-    # Ensure attachment style keys are symbolized before running all tests
-    # Otherwise this would result in this error:
-    # undefined method `processors' for \"48x48>\
-    Spree::Image.attachment_definitions[:attachment][:styles].symbolize_keys!
-  end
-
-  context "uploading, editing, and deleting an image", js: true do
-    it "should allow an admin to upload and edit an image for a product" do
-      Spree::Image.attachment_definitions[:attachment].delete :storage
-
-      create(:product)
-
-      visit spree.admin_path
-      click_nav "Products"
-      click_icon(:edit)
-      click_link "Images"
-      click_link "new_image_link"
-      within_fieldset 'New Image' do
-        attach_file('image_attachment', file_path)
-      end
-      click_button "Update"
-      expect(page).to have_content("successfully created!")
-
-      # Icons are hidden, so hover to have them pop-up
-      find('tbody > tr').hover
-      within_row(1) do
-        within ".actions" do
-          click_icon :edit
-        end
-      end
-
-      fill_in "image_alt", with: "ruby on rails t-shirt"
-      click_button "Update"
-
-      expect(page).to have_content "successfully updated!"
-      expect(page).to have_field "image[alt]", with: "ruby on rails t-shirt"
-
-      find('tbody > tr').hover
-      accept_alert do
-        click_icon :trash
-      end
-      expect(page).not_to have_field "image[alt]", with: "ruby on rails t-shirt"
-    end
-  end
-
-  it "should not see variant column when product has no variants" do
-    product = create(:product)
-    product.images.create!(attachment: File.open(file_path))
-    visit spree.admin_product_images_path(product)
-
-    expect(page).not_to have_content("No Images Found.")
-    within("table.index") do
-      # ensure no duplicate images are displayed
-      expect(page).to have_css("tbody tr", count: 1)
-
-      # ensure variant header is not displayed
-      within("thead") do
-        expect(page).not_to have_content("Variant")
-      end
-
-      # ensure correct cell count
-      expect(page).to have_css("thead th", count: 4)
-    end
-  end
-end

data/spec/features/admin/products/edit/products_spec.rb

@@ -1,92 +0,0 @@
-# frozen_string_literal: true
-
-require 'spec_helper'
-
-describe 'Product Details', type: :feature do
-  stub_authorization!
-
-  context 'editing a product' do
-    it 'should list the product details' do
-      create(:product, name: 'Bún thịt nướng', sku: 'A100',
-              description: 'lorem ipsum', available_on: '2013-08-14 01:02:03')
-
-      visit spree.admin_path
-      click_nav "Products"
-      within_row(1) { click_icon :edit }
-
-      click_link 'Product Details'
-
-      expect(page).to have_content('ProductsBún thịt nướng')
-      expect(page).to have_field('product_name', with: 'Bún thịt nướng')
-      expect(page).to have_field('product_slug', with: 'bun-th-t-n-ng')
-      expect(page).to have_field('product_description', with: 'lorem ipsum')
-      expect(page).to have_field('product_price', with: '19.99')
-      expect(page).to have_field('product_cost_price', with: '17.00')
-      expect(page).to have_field('product_available_on', with: "2013/08/14")
-      expect(page).to have_field('product_sku', with: 'A100')
-    end
-
-    it "should handle slug changes" do
-      create(:product, name: 'Bún thịt nướng', sku: 'A100',
-              description: 'lorem ipsum', available_on: '2011-01-01 01:01:01')
-
-      visit spree.admin_path
-      click_nav "Products"
-      within('table.index tbody tr:nth-child(1)') do
-        click_icon(:edit)
-      end
-
-      fill_in "product_slug", with: 'random-slug-value'
-      click_button "Update"
-      expect(page).to have_content("successfully updated!")
-
-      fill_in "product_slug", with: ''
-      click_button "Update"
-      within('#product_slug_field') { expect(page).to have_content("can't be blank") }
-
-      fill_in "product_slug", with: 'x'
-      click_button "Update"
-      expect(page).to have_content("successfully updated!")
-    end
-  end
-
-  context "when default price is deleted" do
-    it "does not show the master price", js: true do
-      product = create(:product, name: 'Bún thịt nướng', sku: 'A100',
-              description: 'lorem ipsum', available_on: '2013-08-14 01:02:03')
-
-      visit spree.admin_path
-      click_nav "Products"
-      within_row(1) { click_icon :edit }
-
-      click_link 'Prices'
-
-      within "#spree_price_#{product.master.default_price.id}" do
-        accept_alert do
-          click_icon :trash
-        end
-      end
-      expect(page).to have_content("Price has been successfully removed")
-
-      click_link 'Product Details'
-
-      expect(page).not_to have_field('product_price')
-      expect(page).to have_content('This Product has no price in the default currency (USD).')
-    end
-  end
-
-  # Regression test for https://github.com/spree/spree/issues/3385
-  context "deleting a product", js: true do
-    it "is still able to find the master variant" do
-      create(:product)
-
-      visit spree.admin_products_path
-      within_row(1) do
-        accept_alert do
-          click_icon :trash
-        end
-      end
-      expect(page).to have_content('Product has been deleted')
-    end
-  end
-end

data/spec/features/admin/products/edit/taxons_spec.rb

@@ -1,57 +0,0 @@
-# frozen_string_literal: true
-
-require 'spec_helper'
-
-describe "Product Display Order", type: :feature do
-  stub_authorization!
-
-  context "managing display order", js: true do
-    def assert_selected_taxons(taxons)
-      # Regression test for https://github.com/spree/spree/issues/2139
-      taxons.each do |taxon|
-        expect(page).to have_css(".select2-search-choice", text: taxon.name)
-      end
-
-      expected_value = taxons.map(&:id).join(",")
-      expect(page).to have_xpath("//*[@id = 'product_taxon_ids' and @value = '#{expected_value}']", visible: :all)
-    end
-
-    let(:product) { create(:product) }
-
-    it "should allow an admin to manage display order (taxons)" do
-      taxon_1 = create(:taxon)
-      taxon_2 = create(:taxon, name: 'Clothing')
-      product.taxons << taxon_1
-
-      visit spree.edit_admin_product_path(product)
-
-      assert_selected_taxons([taxon_1])
-      select2_search "Clothing", from: "Taxon"
-      assert_selected_taxons([taxon_1, taxon_2])
-
-      # Without this line we have a flaky spec probably due to select2 not
-      # closing its fixed overlay correctly. Clicking anywhere in the page
-      # before submit apparently solves the issue.
-      find('.edit_product', visible: true, obscured: false).click
-
-      click_button "Update"
-
-      within('.flash') do
-        expect(page).to have_content(%(Product "#{product.name}" has been successfully updated!))
-      end
-      assert_selected_taxons([taxon_1, taxon_2])
-    end
-
-    context "with an XSS attempt", skip: true do
-      let(:taxon_name) { %(<script>throw("XSS")</script>) }
-      let!(:taxon) { create(:taxon, name: taxon_name) }
-      it "displays the escaped HTML without executing it" do
-        visit spree.edit_admin_product_path(product)
-
-        select2_search "<script>", from: "Taxon"
-
-        expect(page).to have_content(taxon_name)
-      end
-    end
-  end
-end