solidus_backend 1.1.4 → 1.2.0.beta1

data/spec/features/admin/orders/payments_spec.rb

@@ -30,7 +30,7 @@ describe 'Payments', :type => :feature do
       visit current_path
     end
 
-    # Regression tests for #1453
+    # Regression tests for https://github.com/spree/spree/issues/1453
     context 'with a check payment' do
       let(:order) { create(:completed_order_with_totals, number: 'R100') }
       let!(:payment) do
@@ -80,7 +80,7 @@ describe 'Payments', :type => :feature do
       end
 
       click_icon :void
-      expect(find('#payment_status').text).to eq('BALANCE DUE')
+      expect(page).to have_css('#payment_status', text: 'BALANCE DUE')
       expect(page).to have_content('Payment Updated')
 
       within_row(1) do
@@ -95,12 +95,12 @@ describe 'Payments', :type => :feature do
       expect(page).to have_content('successfully created!')
 
       click_icon(:capture)
-      expect(find('#payment_status').text).to eq('PAID')
 
+      expect(page).to have_selector('#payment_status', text: 'PAID')
       expect(page).not_to have_selector('#new_payment_section')
     end
 
-    # Regression test for #1269
+    # Regression test for https://github.com/spree/spree/issues/1269
     it 'cannot create a payment for an order with no payment methods' do
       Spree::PaymentMethod.delete_all
       order.payments.delete_all
@@ -150,10 +150,10 @@ describe 'Payments', :type => :feature do
         within_row(1) do
           click_icon(:edit)
           fill_in('amount', with: 'invalid')
-          expect(find('td.amount input').value).to eq('invalid')
-          expect(payment.reload.amount).to eq(150.00)
         end
         expect(page).to have_selector('.flash.error', text: 'Invalid resource. Please fix errors and try again.')
+        expect(page).to have_field('amount', with: 'invalid')
+        expect(payment.reload.amount).to eq(150.00)
       end
     end
 
@@ -173,7 +173,7 @@ describe 'Payments', :type => :feature do
     let(:order) { create(:order_with_line_items, :line_items_count => 1) }
     let!(:payment_method) { create(:credit_card_payment_method)}
 
-    # Regression tests for #4129
+    # Regression tests for https://github.com/spree/spree/issues/4129
     context "with a credit card payment method" do
       before do
         visit spree.admin_order_payments_path(order)
@@ -181,10 +181,10 @@ describe 'Payments', :type => :feature do
 
       it "is able to create a new credit card payment with valid information", :js => true do
         fill_in "Card Number", :with => "4111 1111 1111 1111"
-        fill_in "Name", :with => "Test User"
-        fill_in "Expiration", :with => "09 / #{Time.now.year + 1}"
+        fill_in "Name *", :with => "Test User"
+        fill_in "Expiration", :with => "09 / #{Time.current.year + 1}"
         fill_in "Card Code", :with => "007"
-        # Regression test for #4277
+        # Regression test for https://github.com/spree/spree/issues/4277
         expect(page).to have_css('.ccType[value="visa"]', visible: false)
         click_button "Continue"
         expect(page).to have_content("Payment has been successfully created!")

data/spec/features/admin/orders/shipments_spec.rb

@@ -5,7 +5,7 @@ describe "Shipments", :type => :feature do
 
   let!(:order) { create(:order_ready_to_ship, :number => "R100", :state => "complete", :line_items_count => 5) }
 
-  # Regression test for #4025
+  # Regression test for https://github.com/spree/spree/issues/4025
   context "a shipment without a shipping method" do
     before do
       order.shipments.each do |s|
@@ -15,7 +15,7 @@ describe "Shipments", :type => :feature do
     end
 
     it "can still be displayed" do
-      expect { visit spree.edit_admin_order_path(order) }.not_to raise_error
+      visit spree.edit_admin_order_path(order)
     end
   end
 

data/spec/features/admin/products/edit/images_spec.rb

@@ -19,7 +19,7 @@ describe "Product Images", :type => :feature do
       create(:product)
 
       visit spree.admin_path
-      click_link "Products"
+      click_nav "Products"
       click_icon(:edit)
       click_link "Images"
       click_link "new_image_link"
@@ -27,7 +27,9 @@ describe "Product Images", :type => :feature do
       click_button "Update"
       expect(page).to have_content("successfully created!")
 
-      click_icon(:edit)
+      within_row(1) do
+        click_icon(:edit)
+      end
       fill_in "image_alt", :with => "ruby on rails t-shirt"
       click_button "Update"
       expect(page).to have_content("successfully updated!")
@@ -40,7 +42,7 @@ describe "Product Images", :type => :feature do
     end
   end
 
-  # Regression test for #2228
+  # Regression test for https://github.com/spree/spree/issues/2228
   it "should see variant images" do
     variant = create(:variant)
     variant.images.create!(:attachment => File.open(file_path))

data/spec/features/admin/products/edit/products_spec.rb

@@ -10,19 +10,19 @@ describe 'Product Details', :type => :feature do
               :description => 'lorem ipsum', :available_on => '2013-08-14 01:02:03')
 
       visit spree.admin_path
-      click_link 'Products'
+      click_nav "Products"
       within_row(1) { click_icon :edit }
 
       click_link 'Product Details'
 
-      expect(find('.page-title').text.strip).to eq('Editing Product “Bún thịt nướng”')
-      expect(find('input#product_name').value).to eq('Bún thịt nướng')
-      expect(find('input#product_slug').value).to eq('bun-th-t-n-ng')
-      expect(find('textarea#product_description').text.strip).to eq('lorem ipsum')
-      expect(find('input#product_price').value).to eq('19.99')
-      expect(find('input#product_cost_price').value).to eq('17.00')
-      expect(find('input#product_available_on').value).to eq("2013/08/14")
-      expect(find('input#product_sku').value).to eq('A100')
+      expect(page).to have_css('.page-title', text: 'Editing Product “Bún thịt nướng”')
+      expect(page).to have_field('product_name', with: 'Bún thịt nướng')
+      expect(page).to have_field('product_slug', with: 'bun-th-t-n-ng')
+      expect(page).to have_field('product_description', with: 'lorem ipsum')
+      expect(page).to have_field('product_price', with: '19.99')
+      expect(page).to have_field('product_cost_price', with: '17.00')
+      expect(page).to have_field('product_available_on', with: "2013/08/14")
+      expect(page).to have_field('product_sku', with: 'A100')
     end
 
     it "should handle slug changes" do
@@ -30,7 +30,7 @@ describe 'Product Details', :type => :feature do
               :description => 'lorem ipsum', :available_on => '2011-01-01 01:01:01')
 
       visit spree.admin_path
-      click_link 'Products'
+      click_nav "Products"
       within('table.index tbody tr:nth-child(1)') do
         click_icon(:edit)
       end
@@ -49,7 +49,7 @@ describe 'Product Details', :type => :feature do
     end
   end
 
-  # Regression test for #3385
+  # Regression test for https://github.com/spree/spree/issues/3385
   context "deleting a product", :js => true do
     it "is still able to find the master variant" do
       create(:product)

data/spec/features/admin/products/edit/taxons_spec.rb

@@ -3,54 +3,30 @@ require 'spec_helper'
 describe "Product Taxons", :type => :feature do
   stub_authorization!
 
-  after do
-    Capybara.ignore_hidden_elements = true
-  end
-
-  before do
-    Capybara.ignore_hidden_elements = false
-  end
+  context "managing taxons" do
+    def assert_selected_taxons(taxons)
+      # Regression test for https://github.com/spree/spree/issues/2139
+      taxons.each do |taxon|
+        expect(page).to have_css(".select2-search-choice", text: taxon.name)
+      end
 
-  context "managing taxons", js: true do
-    def selected_taxons
-      find("#product_taxon_ids").value.split(',').map(&:to_i).uniq
+      expected_value = taxons.map(&:id).join(",")
+      expect(page).to have_xpath("//*[@id = 'product_taxon_ids' and @value = '#{expected_value}']", visible: :all)
     end
 
-    let(:product) { create(:product) }
-
-    it "should allow an admin to manage taxons" do
+    it "should allow an admin to manage taxons", :js => true do
       taxon_1 = create(:taxon)
-      taxon_2 = create(:taxon, name: 'Clothing')
+      taxon_2 = create(:taxon, :name => 'Clothing')
+      product = create(:product)
       product.taxons << taxon_1
 
-      visit spree.admin_path
-      click_link "Products"
-      within("table.index") do
-        click_icon :edit
-      end
+      visit spree.edit_admin_product_path(product)
 
-      expect(find(".select2-search-choice").text).to eq(taxon_1.name)
-      expect(selected_taxons).to match_array([taxon_1.id])
+      assert_selected_taxons([taxon_1])
 
       select2_search "Clothing", :from => "Taxons"
       click_button "Update"
-      expect(selected_taxons).to match_array([taxon_1.id, taxon_2.id])
-
-      # Regression test for #2139
-      expect(page).to have_css(".select2-search-choice", text: taxon_1.name)
-      expect(page).to have_css(".select2-search-choice", text: taxon_2.name)
-    end
-
-    context "with an XSS attempt" do
-      let(:taxon_name) { %(<script>throw("XSS")</script>) }
-      let!(:taxon) { create(:taxon, name: taxon_name) }
-      it "displays the escaped HTML without executing it" do
-        visit spree.edit_admin_product_path(product)
-
-        select2_search "<script>", from: "Taxons"
-
-        expect(page).to have_content(taxon_name)
-      end
+      assert_selected_taxons([taxon_1, taxon_2])
     end
   end
 end

data/spec/features/admin/products/edit/variants_spec.rb

@@ -11,7 +11,7 @@ describe "Product Variants", :type => :feature do
     let!(:product) { create(:product) }
 
     it "should allow an admin to create option types for a variant" do
-      click_link "Products"
+      click_nav "Products"
 
       within_row(1) { click_icon :edit }
 
@@ -20,7 +20,7 @@ describe "Product Variants", :type => :feature do
     end
 
     it "allows admin to create a variant if there are option types" do
-      click_link "Products"
+      click_nav "Products"
       click_link "Option Types"
       click_link "new_option_type_link"
       fill_in "option_type_name", :with => "shirt colors"
@@ -34,7 +34,7 @@ describe "Product Variants", :type => :feature do
       expect(page).to have_content("successfully updated!")
 
       visit spree.admin_path
-      click_link "Products"
+      click_nav "Products"
       within('table.index tbody tr:nth-child(1)') do
         click_icon :edit
       end

data/spec/features/admin/products/option_types_spec.rb

@@ -5,7 +5,7 @@ describe "Option Types", :type => :feature do
 
   before(:each) do
     visit spree.admin_path
-    click_link "Products"
+    click_nav "Products"
   end
 
   context "listing option types" do
@@ -46,7 +46,9 @@ describe "Option Types", :type => :feature do
       create(:option_type, :name => "tshirt-color", :presentation => "Color")
       create(:option_type, :name => "tshirt-size", :presentation => "Size")
       click_link "Option Types"
-      within('table#listing_option_types') { click_link "Edit" }
+      within('table#listing_option_types') do
+        find('tr', text: 'Size').click_link "Edit"
+      end
       fill_in "option_type_name", :with => "foo-size 99"
       click_button "Update"
       expect(page).to have_content("successfully updated!")
@@ -54,18 +56,21 @@ describe "Option Types", :type => :feature do
     end
   end
 
-  # Regression test for #2277
+  # Regression test for https://github.com/spree/spree/issues/2277
   it "can remove an option value from an option type", :js => true do
     create(:option_value)
     click_link "Option Types"
     within('table#listing_option_types') { click_icon :edit }
     expect(page).to have_content("Editing Option Type")
-    expect(all("tbody#option_values tr").count).to eq(1)
+    expect(page).to have_css("tbody#option_values tr", count: 1)
     within("tbody#option_values") do
       find('.spree_remove_fields').click
     end
     # Assert that the field is hidden automatically
-    expect(all("tbody#option_values tr").select(&:visible?).count).to eq(0)
+    expect(page).to have_no_css("tbody#option_values tr")
+
+    # Ensure the DELETE request finishes
+    expect(page).to have_no_css("#progress")
 
     # Then assert that on a page refresh that it's still not visible
     visit page.current_url
@@ -73,42 +78,38 @@ describe "Option Types", :type => :feature do
     # Sometimes the page doesn't load before the all check is done
     # lazily finding the element gives the page 10 seconds
     expect(page).to have_css("tbody#option_values")
-    all("tbody#option_values tr input").all? { |input| input.value.blank? }
+    all("tbody#option_values tr input", count: 2).each do |input|
+      expect(input.value).to be_blank
+    end
   end
-  
-  # Regression test for #3204
+
+  # Regression test for https://github.com/spree/spree/issues/3204
   it "can remove a non-persisted option value from an option type", :js => true do
     create(:option_type)
     click_link "Option Types"
     within('table#listing_option_types') { click_icon :edit }
 
-    wait_for_ajax
-    page.find("tbody#option_values", :visible => true)
-
-    expect(all("tbody#option_values tr").select(&:visible?).count).to eq(1)
+    expect(page).to have_css("tbody#option_values tr", count: 1)
 
     # Add a new option type
     click_link "Add Option Value"
-    expect(all("tbody#option_values tr").select(&:visible?).count).to eq(2)
+    expect(page).to have_css("tbody#option_values tr", count: 2)
 
     # Remove default option type
     within("tbody#option_values") do
-      find('.fa-trash').click
+      within_row(1) do
+        find('.fa-trash').click
+      end
     end
-    # Check that there was no HTTP request
-    expect(all("div#progress[style]").count).to eq(0)
     # Assert that the field is hidden automatically
-    expect(all("tbody#option_values tr").select(&:visible?).count).to eq(1)
+    expect(page).to have_css("tbody#option_values tr", count: 1)
 
     # Remove added option type
     within("tbody#option_values") do
       find('.fa-trash').click
     end
-    # Check that there was no HTTP request
-    expect(all("div#progress[style]").count).to eq(0)
     # Assert that the field is hidden automatically
-    expect(all("tbody#option_values tr").select(&:visible?).count).to eq(0)
-
+    expect(page).to have_css("tbody#option_values tr", count: 0)
   end
 
 end

data/spec/features/admin/products/products_spec.rb

@@ -25,7 +25,7 @@ describe "Products", :type => :feature do
         end
 
         it "should list existing products with correct sorting by name" do
-          click_link "Products"
+          click_nav "Products"
           # Name ASC
           within_row(1) { expect(page).to have_content('apache baseball cap') }
           within_row(2) { expect(page).to have_content("zomg shirt") }
@@ -37,7 +37,7 @@ describe "Products", :type => :feature do
         end
 
         it "should list existing products with correct sorting by price" do
-          click_link "Products"
+          click_nav "Products"
 
           # Name ASC (default)
           within_row(1) { expect(page).to have_content('apache baseball cap') }
@@ -60,7 +60,7 @@ describe "Products", :type => :feature do
             create(:product, :name => "Just a product", :price => 19.99)
           end
 
-          # Regression test for #2737
+          # Regression test for https://github.com/spree/spree/issues/2737
           context "uses руб as the currency symbol" do
             it "on the products listing page" do
               visit spree.admin_products_path
@@ -76,7 +76,7 @@ describe "Products", :type => :feature do
         create(:product, :name => 'apache baseball cap', :deleted_at => "2011-01-06 18:21:13")
         create(:product, :name => 'zomg shirt')
 
-        click_link "Products"
+        click_nav "Products"
         expect(page).to have_content("zomg shirt")
         expect(page).not_to have_content("apache baseball cap")
         check "Show Deleted"
@@ -94,7 +94,7 @@ describe "Products", :type => :feature do
         create(:product, :name => 'apache baseball cap2', :sku => "B100")
         create(:product, :name => 'zomg shirt')
 
-        click_link "Products"
+        click_nav "Products"
         fill_in "q_name_cont", :with => "ap"
         click_icon :search
         expect(page).to have_content("apache baseball cap")
@@ -141,7 +141,7 @@ describe "Products", :type => :feature do
         @option_type_prototype = prototype
         @property_prototype = create(:prototype, :name => "Random")
         @shipping_category = create(:shipping_category)
-        click_link "Products"
+        click_nav "Products"
         click_link "admin_new_product"
         within('#new_product') do
           expect(page).to have_content("SKU")
@@ -186,7 +186,7 @@ describe "Products", :type => :feature do
     context "creating a new product" do
       before(:each) do
         @shipping_category = create(:shipping_category)
-        click_link "Products"
+        click_nav "Products"
         click_link "admin_new_product"
         within('#new_product') do
           expect(page).to have_content("SKU")
@@ -241,13 +241,16 @@ describe "Products", :type => :feature do
         end
 
         it "should show localized price value on validation errors", :js => true do
+          fill_in "Name", :with => " "
+          select @shipping_category.name, from: "product_shipping_category_id"
           fill_in "product_price", :with => "19,99"
           click_button "Create"
-          expect(find('input#product_price').value).to eq('19,99')
+          expect(page).to have_content("Name can't be blank")
+          expect(page).to have_field('product_price', with: '19,99')
         end
       end
 
-      # Regression test for #2097
+      # Regression test for https://github.com/spree/spree/issues/2097
       it "can set the count on hand to a null value", :js => true do
         fill_in "product_name", :with => "Baseball Cap"
         fill_in "product_price", :with => "100"
@@ -264,7 +267,7 @@ describe "Products", :type => :feature do
       it "should allow an admin to clone a product" do
         create(:product)
 
-        click_link "Products"
+        click_nav "Products"
         within_row(1) do
           click_icon :copy
         end
@@ -276,7 +279,7 @@ describe "Products", :type => :feature do
         it "should allow an admin to clone a deleted product" do
           create(:product, :name => "apache baseball cap")
 
-          click_link "Products"
+          click_nav "Products"
           check "Show Deleted"
           click_button "Search"
 
@@ -327,7 +330,7 @@ describe "Products", :type => :feature do
         # inspect the first one.
         expect(page).to have_css('#product_properties .product_property', count: 2)
         within('#product_properties .product_property:nth-child(1)') do
-          expect(find('input[type=text]').value).to eq('baseball_cap_color')
+          expect(find('input[type=text]', match: :first).value).to eq('baseball_cap_color')
         end
       end
     end

data/spec/features/admin/products/properties_spec.rb

@@ -5,7 +5,7 @@ describe "Properties", :type => :feature do
 
   before(:each) do
     visit spree.admin_path
-    click_link "Products"
+    click_nav "Products"
   end
 
   context "Property index" do
@@ -82,7 +82,7 @@ describe "Properties", :type => :feature do
       click_link "Product Properties"
     end
 
-    # Regression test for #2279
+    # Regression test for https://github.com/spree/spree/issues/2279
     it "successfully create and then remove product property" do
       fill_in_property
 
@@ -93,7 +93,7 @@ describe "Properties", :type => :feature do
       check_property_row_count(1)
     end
 
-    # Regression test for #4466
+    # Regression test for https://github.com/spree/spree/issues/4466
     it "successfully remove and create a product property at the same time" do
       fill_in_property
 

data/spec/features/admin/products/prototypes_spec.rb

@@ -32,7 +32,7 @@ describe "Prototypes", :type => :feature do
       end
 
       visit spree.admin_path
-      click_link "Products"
+      click_nav "Products"
       click_link "Prototypes"
 
       within_row(1) { expect(column_text(1)).to eq "Shirt" }
@@ -44,7 +44,7 @@ describe "Prototypes", :type => :feature do
   context "creating a prototype" do
     it "should allow an admin to create a new product prototype", :js => true do
       visit spree.admin_path
-      click_link "Products"
+      click_nav "Products"
       click_link "Prototypes"
       click_link "new_prototype_link"
       within('#new_prototype') do
@@ -73,7 +73,7 @@ describe "Prototypes", :type => :feature do
       end
 
       visit spree.admin_path
-      click_link "Products"
+      click_nav "Products"
       click_link "Prototypes"
 
       click_on "Edit"
@@ -96,7 +96,7 @@ describe "Prototypes", :type => :feature do
     shirt_prototype.taxons << create(:taxon)
 
     visit spree.admin_path
-    click_link "Products"
+    click_nav "Products"
     click_link "Prototypes"
 
     within("#spree_prototype_#{shirt_prototype.id}") do

data/spec/features/admin/products/stock_management_spec.rb

@@ -16,19 +16,19 @@ describe "Stock Management", :type => :feature do
     before do
       stock_location.stock_item(variant).update_column(:count_on_hand, 10)
 
-      click_link "Products"
+      click_nav "Products"
       within_row(1) { click_icon :edit }
       click_link "Stock Management"
     end
 
-    # Regression test for #3304
+    # Regression test for https://github.com/spree/spree/issues/3304
     # It is OK to still render the stock page, ensure no errors in this case
     context "with no stock location" do
       before do
         @product = create(:product, name: 'apache baseball cap', price: 10)
         v = @product.variants.create!(sku: 'FOOBAR')
         Spree::StockLocation.destroy_all
-        click_link "Products"
+        click_link "Back To Products List"
         within_row(1) do
           click_icon :edit
         end
@@ -58,9 +58,9 @@ describe "Stock Management", :type => :feature do
     end
 
     def adjust_count_on_hand(count_on_hand)
-      find(:css, ".fa-edit[data-id='#{stock_item.id}']").click
+      find(:css, ".fa-edit[data-id='#{stock_item.id}']").trigger('click')
       find(:css, "[data-variant-id='#{variant.id}'] input[type='number']").set(count_on_hand)
-      find(:css, ".fa-check[data-id='#{stock_item.id}']").click
+      find(:css, ".fa-check[data-id='#{stock_item.id}']").trigger('click')
       expect(page).to have_content('Updated successfully')
     end
 

data/spec/features/admin/products/variant_spec.rb

@@ -13,16 +13,16 @@ describe "Variants", :type => :feature do
       end
 
       visit spree.admin_path
-      click_link "Products"
+      click_nav "Products"
       within_row(1) { click_icon :edit }
       click_link "Variants"
       click_on "New Variant"
-      expect(find('input#variant_price').value).to eq("1.99")
-      expect(find('input#variant_cost_price').value).to eq("1.00")
-      expect(find('input#variant_weight').value).to eq("2.50")
-      expect(find('input#variant_height').value).to eq("3.00")
-      expect(find('input#variant_width').value).to eq("1.00")
-      expect(find('input#variant_depth').value).to eq("1.50")
+      expect(page).to have_field('variant_price', with: "1.99")
+      expect(page).to have_field('variant_cost_price', with: "1.00")
+      expect(page).to have_field('variant_weight', with: "2.50")
+      expect(page).to have_field('variant_height', with: "3.00")
+      expect(page).to have_field('variant_width', with: "1.00")
+      expect(page).to have_field('variant_depth', with: "1.50")
       expect(page).to have_select('variant[tax_category_id]')
     end
   end
@@ -38,7 +38,7 @@ describe "Variants", :type => :feature do
           create(:variant, :product => product, :price => 19.99)
         end
 
-        # Regression test for #2737
+        # Regression test for https://github.com/spree/spree/issues/2737
         context "uses руб as the currency symbol" do
           it "on the products listing page" do
             visit spree.admin_product_variants_path(product)

data/spec/features/admin/promotion_adjustments_spec.rb

@@ -136,7 +136,7 @@ describe "Promotion Adjustments", :type => :feature do
       expect(first_action_calculator.preferred_percent).to eq(10)
     end
 
-    xit "should allow an admin to create an automatic promotion with free shipping (no code)" do
+    it "should allow an admin to create an automatic promotion with free shipping (no code)" do
       fill_in "Name", :with => "Promotion"
       click_button "Create"
       expect(page).to have_content("Editing Promotion")
@@ -146,21 +146,14 @@ describe "Promotion Adjustments", :type => :feature do
       find('[id$=_preferred_amount]').set(30)
       within('#rule_fields') { click_button "Update" }
 
-      select2 "Create whole-order adjustment", :from => "Add action of type"
+      select2 "Free shipping", :from => "Add action of type"
       within('#action_fields') { click_button "Add" }
-      select2 "Free Shipping", :from => "Calculator"
-      within('#actions_container') { click_button "Update" }
+      expect(page).to have_content('MAKES ALL SHIPMENTS FOR THE ORDER FREE')
 
       promotion = Spree::Promotion.find_by_name("Promotion")
-      expect(promotion.code.first.value).to be_blank
-
-      first_rule = promotion.rules.first
-      expect(first_rule.class).to eq(Spree::Promotion::Rules::ItemTotal)
-
-      first_action = promotion.actions.first
-      expect(first_action.class).to eq(Spree::Promotion::Actions::CreateAdjustment)
-      first_action_calculator = first_action.calculator
-      expect(first_action_calculator.class).to eq(Spree::Calculator::FreeShipping)
+      expect(promotion.codes).to be_empty
+      expect(promotion.rules.first).to be_a(Spree::Promotion::Rules::ItemTotal)
+      expect(promotion.actions.first).to be_a(Spree::Promotion::Actions::FreeShipping)
     end
 
     it "should allow an admin to create an automatic promo requiring a landing page to be visited" do