solidus_avatax 0.2.0

data/spec/fixtures/vcr_cassettes/taxes_with_store_credits.yml

@@ -0,0 +1,113 @@
+---
+http_interactions:
+- request:
+    method: post
+    uri: https://development.avalara.net/Tax/TaxSvc.asmx
+    body:
+      encoding: UTF-8
+      string: "<soapenv:Envelope xmlns:soapenv=\"http://schemas.xmlsoap.org/soap/envelope/\"
+        xmlns:ser=\"http://avatax.avalara.com/services\">\n   <soapenv:Header>\n      <wsse:Security
+        xmlns:wsse=\"http://docs.oasis-open.org/wss/2004/01/oasis-200401-wss-wssecurity-secext-1.0.xsd\">\n
+        \        <wsse:UsernameToken wsu:Id=\"UsernameToken-7\" xmlns:wsu=\"http://docs.oasis-open.org/wss/2004/01/oasis-200401-wss-wssecurity-utility-1.0.xsd\">\n
+        \           <wsse:Username>[Username]</wsse:Username>\n            <wsse:Password
+        Type=\"http://docs.oasis-open.org/wss/2004/01/oasis-200401-wss-username-token-profile-1.0#PasswordText\">[Password]</wsse:Password>\n
+        \           <wsu:Created>2012-03-02T23:41:44.511Z</wsu:Created>\n         </wsse:UsernameToken>\n
+        \     </wsse:Security>\n      <ser:Profile>\n         <ser:Name></ser:Name>\n
+        \        <ser:Client>Spree::Avatax</ser:Client>\n         <ser:Adapter>Avatax
+        SDK for Ruby2.0.2</ser:Adapter>\n         <ser:Machine></ser:Machine>\n      </ser:Profile>\n
+        \  </soapenv:Header>\n      <soapenv:Body>\n        <ser:GetTax>\n         <ser:GetTaxRequest>\n
+        \          <ser:CompanyCode>[Company]</ser:CompanyCode>\n           <ser:DocType>SalesInvoice</ser:DocType>\n
+        \          <ser:DocCode>R140311533</ser:DocCode>\n           <ser:DocDate>2015-07-24</ser:DocDate>\n
+        \          <ser:SalespersonCode></ser:SalespersonCode>\n           <ser:CustomerCode>kaylie@keebler.info</ser:CustomerCode>\n
+        \          <ser:CustomerUsageType></ser:CustomerUsageType>\n           <ser:Discount>-0.0</ser:Discount>\n
+        \          <ser:PurchaseOrderNo></ser:PurchaseOrderNo>\n           <ser:ExemptionNo></ser:ExemptionNo>\n
+        \          <ser:OriginCode></ser:OriginCode>\n           <ser:DestinationCode></ser:DestinationCode>\n
+        \          <ser:Addresses>\n           <ser:BaseAddress>\n             <ser:AddressCode>1</ser:AddressCode>\n
+        \            <ser:Line1>YT-1300</ser:Line1>\n             <ser:Line2></ser:Line2>\n
+        \            <ser:Line3></ser:Line3>\n             <ser:City>Mos Eisley</ser:City>\n
+        \            <ser:Region></ser:Region>\n             <ser:PostalCode>12010</ser:PostalCode>\n
+        \            <ser:Country></ser:Country>\n             <ser:TaxRegionId>0</ser:TaxRegionId>\n
+        \            <ser:Latitude></ser:Latitude>\n             <ser:Longitude></ser:Longitude>\n
+        \          </ser:BaseAddress>   \n           </ser:Addresses>\n           <ser:Lines>\n
+        \          <ser:Line>\n             <ser:No>Spree::LineItem-1</ser:No>\n             <ser:OriginCode>1</ser:OriginCode>\n
+        \            <ser:DestinationCode>1</ser:DestinationCode>\n             <ser:ItemCode>SKU-65</ser:ItemCode>\n
+        \            <ser:TaxCode>TaxCode - 659848</ser:TaxCode>\n             <ser:Qty>1</ser:Qty>\n
+        \            <ser:Amount>19.99</ser:Amount>\n             <ser:Discounted>true</ser:Discounted>\n
+        \            <ser:RevAcct></ser:RevAcct>\n             <ser:Ref1></ser:Ref1>
+        \                 \n             <ser:Ref2></ser:Ref2>\n             <ser:ExemptionNo></ser:ExemptionNo>\n
+        \            <ser:CustomerUsageType></ser:CustomerUsageType>\n             <ser:Description>Vel
+        ut accusantium doloremque itaque id praesentium. Voluptatem et quia eum at.
+        Explicabo consequ...</ser:Description>\n             <ser:TaxOverride>\n               <ser:TaxOverrideType>None</ser:TaxOverrideType>\n
+        \              <ser:TaxAmount>0</ser:TaxAmount>\n               <ser:TaxDate>1900-01-01</ser:TaxDate>\n
+        \              <ser:Reason></ser:Reason>\n             </ser:TaxOverride>\n
+        \            <ser:TaxIncluded>false</ser:TaxIncluded>\n             <ser:BusinessIdentificationNo></ser:BusinessIdentificationNo>\n
+        \          </ser:Line>\n           <ser:Line>\n             <ser:No>Spree::Shipment-1</ser:No>\n
+        \            <ser:OriginCode>1</ser:OriginCode>\n             <ser:DestinationCode>1</ser:DestinationCode>\n
+        \            <ser:ItemCode></ser:ItemCode>\n             <ser:TaxCode>FR020100</ser:TaxCode>\n
+        \            <ser:Qty>1</ser:Qty>\n             <ser:Amount>0.0</ser:Amount>\n
+        \            <ser:Discounted>false</ser:Discounted>\n             <ser:RevAcct></ser:RevAcct>\n
+        \            <ser:Ref1></ser:Ref1>                  \n             <ser:Ref2></ser:Ref2>\n
+        \            <ser:ExemptionNo></ser:ExemptionNo>\n             <ser:CustomerUsageType></ser:CustomerUsageType>\n
+        \            <ser:Description>Shipping Charge</ser:Description>\n             <ser:TaxOverride>\n
+        \              <ser:TaxOverrideType>None</ser:TaxOverrideType>\n               <ser:TaxAmount>0</ser:TaxAmount>\n
+        \              <ser:TaxDate>1900-01-01</ser:TaxDate>\n               <ser:Reason></ser:Reason>\n
+        \            </ser:TaxOverride>\n             <ser:TaxIncluded>false</ser:TaxIncluded>\n
+        \            <ser:BusinessIdentificationNo></ser:BusinessIdentificationNo>\n
+        \          </ser:Line>  \n          </ser:Lines>\n          <ser:DetailLevel>Tax</ser:DetailLevel>\n
+        \         <ser:ReferenceCode></ser:ReferenceCode>\n          <ser:HashCode>0</ser:HashCode>\n
+        \         <ser:LocationCode></ser:LocationCode>\n          <ser:Commit>false</ser:Commit>\n
+        \         <ser:BatchCode></ser:BatchCode>\n          <ser:TaxOverride>\n            <ser:TaxOverrideType>None</ser:TaxOverrideType>\n
+        \           <ser:TaxAmount>0</ser:TaxAmount>\n            <ser:TaxDate>1900-01-01</ser:TaxDate>\n
+        \           <ser:Reason></ser:Reason>\n          </ser:TaxOverride>\n          <ser:CurrencyCode></ser:CurrencyCode>\n
+        \         <ser:ServiceMode>Remote</ser:ServiceMode>\n          <ser:PaymentDate>1900-01-01</ser:PaymentDate>\n
+        \         <ser:ExchangeRate>0</ser:ExchangeRate>\n          <ser:ExchangeRateEffDate>1900-01-01</ser:ExchangeRateEffDate>\n
+        \         <ser:PosLaneCode></ser:PosLaneCode>\n          <ser:BusinessIdentificationNo></ser:BusinessIdentificationNo>\n
+        \       </ser:GetTaxRequest>\n      </ser:GetTax>\n   </soapenv:Body>\n</soapenv:Envelope>"
+    headers:
+      Soapaction:
+      - '"http://avatax.avalara.com/services/GetTax"'
+      Content-Type:
+      - text/xml;charset=UTF-8
+      Content-Length:
+      - '5695'
+      Accept-Encoding:
+      - gzip;q=1.0,deflate;q=0.6,identity;q=0.3
+      Accept:
+      - "*/*"
+      User-Agent:
+      - Ruby
+  response:
+    status:
+      code: 200
+      message: OK
+    headers:
+      Content-Type:
+      - text/xml; charset=utf-8
+      Vary:
+      - Accept-Encoding
+      X-Powered-By:
+      - ASP.NET
+      Date:
+      - Fri, 24 Jul 2015 22:56:50 GMT
+      Content-Length:
+      - '1412'
+      Set-Cookie:
+      - TS017f1821=01256c426ec9d076789aa3b731ab9e0cb3fa7a55759b9cb7c29a1eb5a3cb7bab4c369a691f;
+        Path=/
+      - TS017f1821_28=0167927a8784f722bbb25bcbe6d81457a5d4e9cc570d9e99c7edf0f05fd1d5a5c882883aa2fe5ac877460393e98b81445699fb67f3;
+        Path=/
+    body:
+      encoding: UTF-8
+      string: <s:Envelope xmlns:s="http://schemas.xmlsoap.org/soap/envelope/"><s:Body
+        xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema"><GetTaxResponse
+        xmlns="http://avatax.avalara.com/services"><GetTaxResult><TransactionId>1211170742</TransactionId><ResultCode>Success</ResultCode><DocId>102167004</DocId><DocType>SalesInvoice</DocType><DocCode>R140311533</DocCode><DocDate>2015-07-24</DocDate><DocStatus>Saved</DocStatus><Reconciled>false</Reconciled><Timestamp>2015-07-24T22:56:50.527</Timestamp><TotalAmount>19.99</TotalAmount><TotalDiscount>0</TotalDiscount><TotalExemption>0</TotalExemption><TotalTaxable>19.99</TotalTaxable><TotalTax>1.6</TotalTax><TotalTaxCalculated>1.6</TotalTaxCalculated><HashCode>0</HashCode><TaxLines><TaxLine><No>Spree::LineItem-1</No><TaxCode>P0000000</TaxCode><Taxability>true</Taxability><BoundaryLevel>Zip5</BoundaryLevel><Exemption>0</Exemption><Discount>0</Discount><Taxable>19.99</Taxable><Rate>0.080000</Rate><Tax>1.6</Tax><TaxCalculated>1.6</TaxCalculated><TaxIncluded>false</TaxIncluded><TaxDetails><TaxDetail><Country>US</Country><Region>NY</Region><JurisType>State</JurisType><JurisCode>36</JurisCode><TaxType>Sales</TaxType><Base>19.99</Base><Taxable>19.99</Taxable><Rate>0.040000</Rate><Tax>0.8</Tax><TaxCalculated>0.8</TaxCalculated><NonTaxable>0</NonTaxable><Exemption>0</Exemption><JurisName>NEW
+        YORK</JurisName><TaxName>NY STATE TAX</TaxName><TaxAuthorityType>45</TaxAuthorityType><TaxGroup/><RateType>G</RateType><StateAssignedNo/></TaxDetail><TaxDetail><Country>US</Country><Region>NY</Region><JurisType>County</JurisType><JurisCode>057</JurisCode><TaxType>Sales</TaxType><Base>19.99</Base><Taxable>19.99</Taxable><Rate>0.040000</Rate><Tax>0.8</Tax><TaxCalculated>0.8</TaxCalculated><NonTaxable>0</NonTaxable><Exemption>0</Exemption><JurisName>MONTGOMERY</JurisName><TaxName>NY
+        COUNTY TAX</TaxName><TaxAuthorityType>45</TaxAuthorityType><TaxGroup/><RateType>G</RateType><StateAssignedNo>MO
+        2781</StateAssignedNo></TaxDetail></TaxDetails><ExemptCertId>0</ExemptCertId><TaxDate>2015-07-24</TaxDate><ReportingDate>2015-07-24</ReportingDate><AccountingMethod>Accrual</AccountingMethod></TaxLine><TaxLine><No>Spree::Shipment-1</No><TaxCode>FR020100</TaxCode><Taxability>true</Taxability><BoundaryLevel>Zip5</BoundaryLevel><Exemption>0</Exemption><Discount>0</Discount><Taxable>0</Taxable><Rate>0.080000</Rate><Tax>0</Tax><TaxCalculated>0</TaxCalculated><TaxIncluded>false</TaxIncluded><TaxDetails><TaxDetail><Country>US</Country><Region>NY</Region><JurisType>State</JurisType><JurisCode>36</JurisCode><TaxType>Sales</TaxType><Base>0</Base><Taxable>0</Taxable><Rate>0.040000</Rate><Tax>0</Tax><TaxCalculated>0</TaxCalculated><NonTaxable>0</NonTaxable><Exemption>0</Exemption><JurisName>NEW
+        YORK</JurisName><TaxName>NY STATE TAX</TaxName><TaxAuthorityType>45</TaxAuthorityType><TaxGroup/><RateType>G</RateType><StateAssignedNo/></TaxDetail><TaxDetail><Country>US</Country><Region>NY</Region><JurisType>County</JurisType><JurisCode>057</JurisCode><TaxType>Sales</TaxType><Base>0</Base><Taxable>0</Taxable><Rate>0.040000</Rate><Tax>0</Tax><TaxCalculated>0</TaxCalculated><NonTaxable>0</NonTaxable><Exemption>0</Exemption><JurisName>MONTGOMERY</JurisName><TaxName>NY
+        COUNTY TAX</TaxName><TaxAuthorityType>45</TaxAuthorityType><TaxGroup/><RateType>G</RateType><StateAssignedNo>MO
+        2781</StateAssignedNo></TaxDetail></TaxDetails><ExemptCertId>0</ExemptCertId><TaxDate>2015-07-24</TaxDate><ReportingDate>2015-07-24</ReportingDate><AccountingMethod>Accrual</AccountingMethod></TaxLine></TaxLines><TaxAddresses><TaxAddress><Address>YT-1300</Address><AddressCode>1</AddressCode><BoundaryLevel>2</BoundaryLevel><City>Mos
+        Eisley</City><Country>US</Country><PostalCode>12010</PostalCode><Region>NY</Region><TaxRegionId>2088427</TaxRegionId><JurisCode>3605700000</JurisCode><Latitude/><Longitude/><GeocodeType>ZIP5Centroid</GeocodeType><ValidateStatus>StreetNotInCity</ValidateStatus><DistanceToBoundary>0</DistanceToBoundary></TaxAddress></TaxAddresses><Locked>false</Locked><AdjustmentReason>0</AdjustmentReason><AdjustmentDescription/><Version>1</Version><TaxDate>2015-07-24</TaxDate><TaxSummary/><VolatileTaxRates>false</VolatileTaxRates></GetTaxResult></GetTaxResponse></s:Body></s:Envelope>
+    http_version:
+  recorded_at: Fri, 24 Jul 2015 22:57:02 GMT
+recorded_with: VCR 2.9.3

data/spec/models/spree/adjustment_spec.rb

@@ -0,0 +1,23 @@
+require 'spec_helper'
+
+describe Spree::Adjustment do
+  describe 'closed validation' do
+    context 'with a tax adjustment' do
+      let(:adjustment) { build(:adjustment, finalized: false, source: Spree::TaxRate.first) }
+
+      it 'should trigger' do
+        adjustment.valid?
+        expect(adjustment.errors[:finalized]).to include("Tax adjustments must always be finalized for Avatax")
+      end
+    end
+
+    context 'with a non-tax adjustment' do
+      let(:adjustment) { build(:adjustment, finalized: false, source: nil) }
+
+      it 'should not trigger' do
+        adjustment.valid?
+        expect(adjustment.errors[:finalized]).to be_empty
+      end
+    end
+  end
+end

data/spec/models/spree/order_contents_spec.rb

@@ -0,0 +1,35 @@
+require 'spec_helper'
+
+describe Spree::OrderContents do
+  let(:order) { create :order_with_line_items, line_items_count: 1 }
+  let(:order_contents) { Spree::OrderContents.new(order) }
+
+  describe 'add_with_avatax' do
+    let(:variant) { create :variant }
+
+    subject { order_contents.add_with_avatax(variant) }
+
+    it 'clears tax' do
+      expect(SpreeAvatax::SalesShared).to receive(:reset_tax_attributes).with(order)
+      subject
+    end
+  end
+
+  describe 'remove_with_avatax' do
+    subject { order_contents.remove_with_avatax(order.line_items.first.variant) }
+
+    it 'recomputes tax' do
+      expect(SpreeAvatax::SalesShared).to receive(:reset_tax_attributes).with(order)
+      subject
+    end
+  end
+
+  describe 'update_cart_with_avatax' do
+    subject { order_contents.update_cart_with_avatax({}) }
+
+    it 'recomputes tax' do
+      expect(SpreeAvatax::SalesShared).to receive(:reset_tax_attributes).with(order)
+      subject
+    end
+  end
+end

data/spec/models/spree/order_spec.rb

@@ -0,0 +1,111 @@
+require 'spec_helper'
+
+describe Spree::Order do
+  subject { order }
+
+  let!(:order) { create(:order_with_line_items, line_items_count: 1) }
+
+  context 'after_save' do
+    context 'when something unimportant changes' do
+      context 'when in confirm state' do
+        before { order.update_columns(state: 'confirm') }
+
+        it 'does not change the order state' do
+          expect {
+            order.update_attributes!(special_instructions: 'unimportant change')
+          }.to_not change { order.state }
+        end
+      end
+    end
+
+    context 'when the ship address changes' do
+      def change_address
+        order.update_attributes!(ship_address: create(:address))
+      end
+
+      context 'when in confirm state' do
+        before { order.update_columns(state: 'confirm') }
+
+        it 'sets the order state to payment' do
+          expect {
+            change_address
+          }.to change { order.state }.from('confirm').to('payment')
+        end
+      end
+
+      context 'when not in confirm state' do
+        before { order.update_columns(state: 'address') }
+
+        it 'does not update avatax' do
+          expect {
+            change_address
+          }.to_not change { order.state }
+        end
+      end
+    end
+  end
+
+  context "when transitioning from address" do
+    before do
+      subject.update_attributes!(state: 'address')
+    end
+
+    it "clears tax" do
+      expect(SpreeAvatax::SalesShared).to receive(:reset_tax_attributes).with(order)
+      subject.next!
+    end
+  end
+
+  context "when transitioning to payment" do
+    before do
+      subject.update_attributes!(state: 'delivery')
+    end
+
+    it "generates the sales invoice" do
+      expect(SpreeAvatax::SalesInvoice).to receive(:generate).with(subject)
+      subject.next!
+    end
+  end
+
+  context "when transitioning to complete" do
+    before do
+      subject.update_attributes!(state: 'confirm')
+      subject.payments.create!(state: 'checkout')
+    end
+
+    it "commits the sales invoice" do
+      expect(SpreeAvatax::SalesInvoice).to receive(:commit).with(subject)
+      subject.complete!
+    end
+  end
+
+  describe '#avatax_order_adjustment_total' do
+    context 'no adjustments exist' do
+      it 'returns 0' do
+        expect(subject.avatax_order_adjustment_total).to eq 0
+      end
+    end
+
+    context 'eligible non-tax adjustments exist' do
+      let!(:non_eligible_promo_adjustment) do
+        subject.adjustments.create!(order: order, source_type: 'Spree::Promotion', eligible: false, amount: -1.0, label: 'bad promo')
+      end
+      let!(:eligible_promo_adjustment) do
+        subject.adjustments.create!(order: order, source_type: 'Spree::Promotion', eligible: true, amount: -10.0, label: 'good promo')
+      end
+      let!(:eligible_non_promo_adjustment) do
+        subject.adjustments.create!(order: order, source_type: nil, eligible: true, amount: -100.0, label: 'non-promo')
+      end
+      let!(:eligible_positive_adjustment) do
+        subject.adjustments.create!(order: order, source_type: nil, eligible: true, amount: 1000.0, label: 'positive non-promo')
+      end
+      let(:eligible_total) do
+        eligible_promo_adjustment.amount + eligible_non_promo_adjustment.amount + eligible_positive_adjustment.amount
+      end
+
+      it 'returns the correct amount' do
+        expect(subject.avatax_order_adjustment_total).to eq -eligible_total
+      end
+    end
+  end
+end

data/spec/models/spree/shipping_rate_spec.rb

@@ -0,0 +1,23 @@
+require 'spec_helper'
+
+describe Spree::ShippingRate do
+  subject do
+    shipping_rate.calculate_tax_amount
+  end
+
+  let(:shipping_rate) do
+    shipment.shipping_rates.create!({
+      tax_rate:        Spree::TaxRate.first,
+      shipping_method: shipping_method,
+      cost:            10.00,
+      selected:        true,
+    })
+  end
+
+  let(:shipment) { create(:shipment) }
+  let(:shipping_method) { create(:shipping_method) }
+
+  it 'foo' do
+    expect(subject).to eq 0
+  end
+end

data/spec/models/spree/tax_rate_spec.rb

@@ -0,0 +1,40 @@
+require 'spec_helper'
+
+describe Spree::TaxRate do
+  let(:tax_rate) { Spree::TaxRate.first }
+
+  describe '.match' do
+    it { expect(Spree::TaxRate.match(:whatever)).to eq [tax_rate] }
+  end
+
+  describe '.avatax_the_one_rate' do
+    it 'returns the tax rate' do
+      expect(Spree::TaxRate.avatax_the_one_rate).to eq tax_rate
+    end
+  end
+
+  describe 'tax rate count limitation' do
+    let(:tax_rate_2) { build(:tax_rate) }
+
+    it 'limits to a single rate' do
+      expect(tax_rate_2).to be_invalid
+      expect(tax_rate_2.errors.full_messages).to eq ['only one tax rate is allowed and this would make 2']
+    end
+  end
+
+  describe '#adjust' do
+    it 'raises TaxRateInvalidOperation' do
+      expect {
+        tax_rate.adjust(nil, nil)
+      }.to raise_error(SpreeAvatax::TaxRateInvalidOperation)
+    end
+  end
+
+  describe '#compute_amount' do
+    it 'raises TaxRateInvalidOperation' do
+      expect {
+        tax_rate.compute_amount(nil)
+      }.to raise_error(SpreeAvatax::TaxRateInvalidOperation)
+    end
+  end
+end

data/spec/models/spree_avatax/calculator.rb

@@ -0,0 +1,20 @@
+require 'spec_helper'
+
+describe SpreeAvatax::Calculator do
+  let(:calculator) { SpreeAvatax::Calculator.new }
+
+  describe '.description' do
+    it 'should not be nil' do
+      expect(SpreeAvatax::Calculator.description).to eq Spree.t(:avatax_description)
+    end
+  end
+
+  describe '#compute' do
+    it 'should raise DoNotUseCompute' do
+      expect {
+        calculator.compute(nil)
+      }.to raise_error(SpreeAvatax::Calculator::DoNotUseCompute)
+    end
+  end
+
+end

data/spec/models/spree_avatax/return_invoice_spec.rb

@@ -0,0 +1,193 @@
+require 'spec_helper'
+
+describe SpreeAvatax::ReturnInvoice do
+
+  describe '.generate' do
+    let(:reimbursement) { create(:reimbursement) }
+    let(:order) { reimbursement.order }
+    let(:return_item) { reimbursement.return_items.first }
+
+    let(:expected_gettax_params) do
+      {
+        doccode:       reimbursement.number,
+        referencecode: reimbursement.order.number,
+        customercode:  reimbursement.order.user_id,
+        companycode:   SpreeAvatax::Config.company_code,
+
+        doctype: SpreeAvatax::ReturnInvoice::DOC_TYPE,
+        docdate: Date.today,
+
+        commit: false,
+
+        taxoverridetype: SpreeAvatax::ReturnInvoice::TAX_OVERRIDE_TYPE,
+        reason:          SpreeAvatax::ReturnInvoice::TAX_OVERRIDE_REASON,
+        taxdate:         expected_tax_override_date,
+
+        addresses: [
+          {
+            addresscode: SpreeAvatax::ReturnInvoice::DESTINATION_CODE,
+            line1:       REXML::Text.normalize(reimbursement.order.ship_address.address1),
+            line2:       REXML::Text.normalize(reimbursement.order.ship_address.address2),
+            city:        REXML::Text.normalize(reimbursement.order.ship_address.city),
+            postalcode:  REXML::Text.normalize(reimbursement.order.ship_address.zipcode),
+          },
+        ],
+        lines: [
+          {
+            no:                  return_item.id,
+            itemcode:            return_item.inventory_unit.line_item.variant.sku,
+            taxcode:             return_item.inventory_unit.line_item.tax_category.tax_code,
+            qty:                 1,
+            amount:              -return_item.pre_tax_amount,
+            origincodeline:      SpreeAvatax::ReturnInvoice::DESTINATION_CODE,
+            destinationcodeline: SpreeAvatax::ReturnInvoice::DESTINATION_CODE,
+
+            description: REXML::Text.normalize(expected_truncated_description),
+          },
+        ],
+      }
+    end
+
+    let(:expected_tax_override_date) { Date.today }
+    let(:expected_truncated_description) { return_item.inventory_unit.line_item.variant.product.description[0...100] }
+    let(:gettax_response) { return_invoice_gettax_response(reimbursement.number, return_item.id) }
+    let(:gettax_response_return_item_tax_line) { Array.wrap(gettax_response[:tax_lines][:tax_line]).first }
+    let(:return_item_calculated_tax) do
+      BigDecimal.new(gettax_response_return_item_tax_line[:tax]).abs
+    end
+
+    before do
+      expect(SpreeAvatax::ReturnInvoice.send(:tax_svc))
+        .to receive(:gettax)
+        .with(expected_gettax_params)
+        .and_return(gettax_response)
+    end
+
+    subject do
+      SpreeAvatax::ReturnInvoice.generate(reimbursement)
+    end
+
+    it 'creates a return invoice' do
+      expect {
+        subject
+      }.to change { SpreeAvatax::ReturnInvoice.count }.by(1)
+      expect(reimbursement.return_invoice).to eq SpreeAvatax::ReturnInvoice.last
+    end
+
+    it 'persists the results to the return items' do
+      expect {
+        subject
+      }.to change { return_item.reload.additional_tax_total }.from(0).to(return_item_calculated_tax)
+    end
+
+    context 'when the response for a return item is missing' do
+      before do
+        gettax_response_return_item_tax_line[:no] = (return_item.id + 1).to_s
+      end
+
+      it 'raises ReturnItemResponseMissing' do
+        expect {
+          subject
+        }.to raise_error(SpreeAvatax::ReturnInvoice::ReturnItemResponseMissing)
+      end
+    end
+
+    context 'when an invoice already exists' do
+      let!(:previous_return_invoice) { create(:return_invoice, reimbursement: reimbursement) }
+
+      it 'deletes the previous invoice' do
+        subject
+        expect(SpreeAvatax::ReturnInvoice.find_by(id: previous_return_invoice.id)).to be_nil
+      end
+    end
+
+    describe 'when avatax_invoice_at is present' do
+      let(:expected_tax_override_date) { 2.days.ago.to_date }
+
+      before do
+        reimbursement.order.update_attributes!(avatax_invoice_at: expected_tax_override_date)
+      end
+
+      it 'succeeds' do
+        subject # method expectation will fail if date isn't right
+      end
+    end
+
+    describe 'when the description is too long' do
+      let(:description) { 'a'*1000 }
+      let(:expected_truncated_description) { 'a'*100 }
+
+      before do
+        return_item.inventory_unit.line_item.variant.product.update!(description: description)
+      end
+
+      it 'succeeds' do
+        subject # method expectation will fail if date isn't right
+      end
+    end
+
+    context 'user input contains XML characters' do
+      let(:line1) { "<&line1>" }
+      let(:line2) { "<&line2>" }
+      let(:city) { "<&city>" }
+      let(:zipcode) { "<12345>" }
+      let(:description) { "A description <wi>&/th xml characters" }
+
+      before(:each) do
+        ship_address = order.ship_address
+        ship_address.update_columns(address1: line1, address2: line2, city: city, zipcode: zipcode)
+        return_item.inventory_unit.line_item.variant.product.update_columns(description: description)
+      end
+
+      let(:expected_gettax_params) do
+        super().tap do |params|
+          params[:addresses].first.merge!(line1: REXML::Text.normalize(line1), line2: REXML::Text.normalize(line2), city: REXML::Text.normalize(city), postalcode: REXML::Text.normalize(zipcode))
+          params[:lines][0][:description] = REXML::Text.normalize(description)
+        end
+      end
+
+      it 'succeeds' do
+        subject
+      end
+    end
+  end
+
+  describe '.finalize' do
+    let(:return_invoice) { create(:return_invoice) }
+
+    let(:expected_posttax_params) do
+      {
+        doccode:     return_invoice.doc_code,
+        companycode: SpreeAvatax::Config.company_code,
+
+        doctype: SpreeAvatax::ReturnInvoice::DOC_TYPE,
+        docdate: return_invoice.doc_date,
+
+        commit: true,
+
+        totalamount: return_invoice.pre_tax_total,
+        totaltax:    return_invoice.additional_tax_total,
+      }
+    end
+
+    before do
+      expect(SpreeAvatax::ReturnInvoice.send(:tax_svc))
+        .to receive(:posttax)
+        .with(expected_posttax_params)
+        .and_return(
+          return_invoice_posttax_response
+        )
+    end
+
+    subject do
+      SpreeAvatax::ReturnInvoice.finalize(return_invoice.reimbursement)
+    end
+
+    it 'marks the return invoice as committed' do
+      expect {
+        subject
+      }.to change { return_invoice.reload.committed? }.from(false).to(true)
+    end
+  end
+
+end