solidus_auth_devise 2.5.9 → 2.6.0

data/.rubocop_todo.yml

@@ -1,397 +0,0 @@
-# This configuration was generated by
-# `rubocop --auto-gen-config`
-# on 2022-09-09 11:12:37 UTC using RuboCop version 1.36.0.
-# The point is for the user to remove these configuration records
-# one by one as the offenses are removed from the code base.
-# Note that changes in the inspected code, or installation of new
-# versions of RuboCop, may require this file to be generated again.
-
-# Offense count: 2
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: TreatCommentsAsGroupSeparators, ConsiderPunctuation, Include.
-# Include: **/*.gemspec
-Gemspec/OrderedDependencies:
-  Exclude:
-    - 'solidus_auth_devise.gemspec'
-
-# Offense count: 8
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: EnforcedStyle, IndentationWidth.
-# SupportedStyles: with_first_argument, with_fixed_indentation
-Layout/ArgumentAlignment:
-  Exclude:
-    - 'app/models/spree/user.rb'
-    - 'lib/spree/authentication_helpers.rb'
-    - 'spec/controllers/spree/user_sessions_controller_spec.rb'
-    - 'spec/features/sign_out_spec.rb'
-
-# Offense count: 2
-# This cop supports safe autocorrection (--autocorrect).
-Layout/ElseAlignment:
-  Exclude:
-    - 'config/initializers/devise.rb'
-    - 'spec/support/features/fill_addresses_fields.rb'
-
-# Offense count: 1
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: EmptyLineBetweenMethodDefs, EmptyLineBetweenClassDefs, EmptyLineBetweenModuleDefs, AllowAdjacentOneLineDefs, NumberOfEmptyLines.
-Layout/EmptyLineBetweenDefs:
-  Exclude:
-    - 'lib/spree/auth/engine.rb'
-
-# Offense count: 1
-# This cop supports safe autocorrection (--autocorrect).
-Layout/EmptyLines:
-  Exclude:
-    - 'lib/spree/auth/engine.rb'
-
-# Offense count: 2
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: EnforcedStyleAlignWith, Severity.
-# SupportedStylesAlignWith: keyword, variable, start_of_line
-Layout/EndAlignment:
-  Exclude:
-    - 'config/initializers/devise.rb'
-    - 'spec/support/features/fill_addresses_fields.rb'
-
-# Offense count: 4
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: Width, AllowedPatterns, IgnoredPatterns.
-Layout/IndentationWidth:
-  Exclude:
-    - 'config/initializers/devise.rb'
-    - 'spec/features/admin/sign_out_spec.rb'
-    - 'spec/features/sign_out_spec.rb'
-    - 'spec/support/features/fill_addresses_fields.rb'
-
-# Offense count: 4
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: symmetrical, new_line, same_line
-Layout/MultilineMethodCallBraceLayout:
-  Exclude:
-    - 'spec/controllers/spree/user_registrations_controller_spec.rb'
-    - 'spec/controllers/spree/user_sessions_controller_spec.rb'
-    - 'spec/features/admin/password_reset_spec.rb'
-
-# Offense count: 1
-# This cop supports safe autocorrection (--autocorrect).
-Layout/SpaceAfterComma:
-  Exclude:
-    - 'spec/features/account_spec.rb'
-
-# Offense count: 1
-# This cop supports safe autocorrection (--autocorrect).
-Layout/SpaceBeforeComma:
-  Exclude:
-    - 'spec/features/account_spec.rb'
-
-# Offense count: 1
-# Configuration parameters: AllowedMethods, AllowedPatterns, IgnoredMethods.
-Lint/AmbiguousBlockAssociation:
-  Exclude:
-    - 'spec/controllers/spree/checkout_controller_spec.rb'
-
-# Offense count: 3
-# This cop supports safe autocorrection (--autocorrect).
-RSpec/BeEql:
-  Exclude:
-    - 'spec/models/user_spec.rb'
-
-# Offense count: 1
-RSpec/BeforeAfterAll:
-  Exclude:
-    - 'spec/models/user_spec.rb'
-
-# Offense count: 5
-# This cop supports safe autocorrection (--autocorrect).
-Capybara/CurrentPathExpectation:
-  Exclude:
-    - 'spec/features/admin/sign_in_spec.rb'
-    - 'spec/features/sign_in_spec.rb'
-
-# Offense count: 69
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: EnabledMethods.
-RSpec/Capybara/FeatureMethods:
-  Exclude:
-    - 'spec/features/account_spec.rb'
-    - 'spec/features/admin/password_reset_spec.rb'
-    - 'spec/features/admin/products_spec.rb'
-    - 'spec/features/admin/sign_in_spec.rb'
-    - 'spec/features/admin/sign_out_spec.rb'
-    - 'spec/features/admin_permissions_spec.rb'
-    - 'spec/features/change_email_spec.rb'
-    - 'spec/features/checkout_spec.rb'
-    - 'spec/features/confirmation_spec.rb'
-    - 'spec/features/order_spec.rb'
-    - 'spec/features/password_reset_spec.rb'
-    - 'spec/features/sign_in_spec.rb'
-    - 'spec/features/sign_out_spec.rb'
-    - 'spec/features/sign_up_spec.rb'
-    - 'spec/requests/spree/frontend/user_update_spec.rb'
-
-# Offense count: 12
-# This cop supports safe autocorrection (--autocorrect).
-RSpec/ContextMethod:
-  Exclude:
-    - 'spec/controllers/spree/checkout_controller_spec.rb'
-    - 'spec/controllers/spree/user_passwords_controller_spec.rb'
-    - 'spec/controllers/spree/user_registrations_controller_spec.rb'
-    - 'spec/controllers/spree/user_sessions_controller_spec.rb'
-    - 'spec/controllers/spree/users_controller_spec.rb'
-    - 'spec/models/order_spec.rb'
-
-# Offense count: 26
-# Configuration parameters: Prefixes.
-# Prefixes: when, with, without
-RSpec/ContextWording:
-  Exclude:
-    - 'spec/controllers/spree/checkout_controller_spec.rb'
-    - 'spec/controllers/spree/user_passwords_controller_spec.rb'
-    - 'spec/controllers/spree/user_registrations_controller_spec.rb'
-    - 'spec/controllers/spree/user_sessions_controller_spec.rb'
-    - 'spec/controllers/spree/users_controller_spec.rb'
-    - 'spec/features/account_spec.rb'
-    - 'spec/features/admin/password_reset_spec.rb'
-    - 'spec/features/admin/products_spec.rb'
-    - 'spec/features/admin_permissions_spec.rb'
-    - 'spec/mailers/user_mailer_spec.rb'
-    - 'spec/models/order_spec.rb'
-    - 'spec/models/user_spec.rb'
-    - 'spec/requests/spree/frontend/user_update_spec.rb'
-
-# Offense count: 6
-# This cop supports unsafe autocorrection (--autocorrect-all).
-# Configuration parameters: SkipBlocks, EnforcedStyle.
-# SupportedStyles: described_class, explicit
-RSpec/DescribedClass:
-  Exclude:
-    - 'spec/mailers/user_mailer_spec.rb'
-    - 'spec/models/user_spec.rb'
-
-# Offense count: 2
-# This cop supports safe autocorrection (--autocorrect).
-RSpec/EmptyLineAfterFinalLet:
-  Exclude:
-    - 'spec/controllers/spree/user_sessions_controller_spec.rb'
-    - 'spec/models/order_spec.rb'
-
-# Offense count: 1
-# This cop supports safe autocorrection (--autocorrect).
-RSpec/EmptyLineAfterSubject:
-  Exclude:
-    - 'spec/controllers/spree/checkout_controller_spec.rb'
-
-# Offense count: 1
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: CustomTransform, IgnoredWords.
-RSpec/ExampleWording:
-  Exclude:
-    - 'spec/features/sign_in_spec.rb'
-
-# Offense count: 1
-# This cop supports safe autocorrection (--autocorrect).
-RSpec/ExpectActual:
-  Exclude:
-    - 'spec/controllers/spree/user_registrations_controller_spec.rb'
-
-# Offense count: 2
-# This cop supports unsafe autocorrection (--autocorrect-all).
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: method_call, block
-RSpec/ExpectChange:
-  Exclude:
-    - 'spec/controllers/spree/checkout_controller_spec.rb'
-    - 'spec/controllers/spree/user_registrations_controller_spec.rb'
-
-# Offense count: 3
-# Configuration parameters: Include, CustomTransform, IgnoreMethods, SpecSuffixOnly.
-# Include: **/*_spec*rb*, **/spec/**/*
-RSpec/FilePath:
-  Exclude:
-    - 'spec/mailers/user_mailer_spec.rb'
-    - 'spec/models/order_spec.rb'
-    - 'spec/models/user_spec.rb'
-
-# Offense count: 15
-# Configuration parameters: AssignmentOnly.
-RSpec/InstanceVariable:
-  Exclude:
-    - 'spec/controllers/spree/admin/user_passwords_controller_spec.rb'
-    - 'spec/controllers/spree/user_passwords_controller_spec.rb'
-    - 'spec/controllers/spree/user_registrations_controller_spec.rb'
-    - 'spec/features/admin/sign_in_spec.rb'
-    - 'spec/features/checkout_spec.rb'
-    - 'spec/features/sign_in_spec.rb'
-    - 'spec/mailers/user_mailer_spec.rb'
-
-# Offense count: 2
-# This cop supports safe autocorrection (--autocorrect).
-RSpec/LeadingSubject:
-  Exclude:
-    - 'spec/controllers/spree/user_registrations_controller_spec.rb'
-    - 'spec/controllers/spree/user_sessions_controller_spec.rb'
-
-# Offense count: 5
-RSpec/LetSetup:
-  Exclude:
-    - 'spec/features/admin/password_reset_spec.rb'
-    - 'spec/features/confirmation_spec.rb'
-    - 'spec/features/password_reset_spec.rb'
-
-# Offense count: 6
-# Configuration parameters: .
-# SupportedStyles: have_received, receive
-RSpec/MessageSpies:
-  EnforcedStyle: receive
-
-# Offense count: 39
-RSpec/MultipleExpectations:
-  Max: 5
-
-# Offense count: 26
-# Configuration parameters: IgnoreSharedExamples.
-RSpec/NamedSubject:
-  Exclude:
-    - 'spec/controllers/spree/checkout_controller_spec.rb'
-    - 'spec/controllers/spree/user_registrations_controller_spec.rb'
-    - 'spec/controllers/spree/user_sessions_controller_spec.rb'
-    - 'spec/controllers/spree/users_controller_spec.rb'
-
-# Offense count: 30
-RSpec/NestedGroups:
-  Max: 5
-
-# Offense count: 3
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: not_to, to_not
-RSpec/NotToNot:
-  Exclude:
-    - 'spec/controllers/spree/users_controller_spec.rb'
-    - 'spec/features/admin/password_reset_spec.rb'
-    - 'spec/features/password_reset_spec.rb'
-
-# Offense count: 2
-RSpec/RepeatedExampleGroupDescription:
-  Exclude:
-    - 'spec/models/user_spec.rb'
-
-# Offense count: 7
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: and_return, block
-RSpec/ReturnFromStub:
-  Exclude:
-    - 'spec/controllers/spree/checkout_controller_spec.rb'
-    - 'spec/controllers/spree/products_controller_spec.rb'
-    - 'spec/models/order_spec.rb'
-
-# Offense count: 1
-RSpec/StubbedMock:
-  Exclude:
-    - 'spec/models/user_spec.rb'
-
-# Offense count: 2
-# Configuration parameters: IgnoreNameless, IgnoreSymbolicNames.
-RSpec/VerifiedDoubles:
-  Exclude:
-    - 'spec/features/confirmation_spec.rb'
-    - 'spec/models/user_spec.rb'
-
-# Offense count: 12
-# This cop supports unsafe autocorrection (--autocorrect-all).
-# Configuration parameters: Include.
-# Include: app/**/*.rb, config/**/*.rb, db/**/*.rb, lib/**/*.rb
-Rails/Output:
-  Exclude:
-    - 'db/default/users.rb'
-
-# Offense count: 8
-# This cop supports unsafe autocorrection (--autocorrect-all).
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: nested, compact
-Style/ClassAndModuleChildren:
-  Exclude:
-    - 'lib/controllers/backend/spree/admin/user_passwords_controller.rb'
-    - 'lib/controllers/backend/spree/admin/user_sessions_controller.rb'
-    - 'lib/controllers/frontend/spree/user_confirmations_controller.rb'
-    - 'lib/controllers/frontend/spree/user_passwords_controller.rb'
-    - 'lib/controllers/frontend/spree/user_registrations_controller.rb'
-    - 'lib/controllers/frontend/spree/user_sessions_controller.rb'
-    - 'lib/controllers/frontend/spree/users_controller.rb'
-    - 'lib/decorators/backend/controllers/spree/admin/orders/customer_details_controller_decorator.rb'
-
-# Offense count: 1
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: compact, expanded
-Style/EmptyMethod:
-  Exclude:
-    - 'lib/controllers/backend/spree/admin/user_sessions_controller.rb'
-
-# Offense count: 1
-# This cop supports safe autocorrection (--autocorrect).
-Style/ExpandPathArguments:
-  Exclude:
-    - 'spec/support/confirm_helpers.rb'
-
-# Offense count: 3
-# This cop supports unsafe autocorrection (--autocorrect-all).
-Style/GlobalStdStream:
-  Exclude:
-    - 'db/default/users.rb'
-
-# Offense count: 6
-# Configuration parameters: MinBodyLength, AllowConsecutiveConditionals.
-Style/GuardClause:
-  Exclude:
-    - 'db/migrate/20101026184949_create_users.rb'
-    - 'db/migrate/20120203010234_add_reset_password_sent_at_to_spree_users.rb'
-    - 'db/migrate/20190125170630_add_reset_password_token_index_to_spree_users.rb'
-    - 'db/migrate/20200417153503_add_unconfirmed_email_to_spree_users.rb'
-    - 'lib/spree/authentication_helpers.rb'
-
-# Offense count: 1
-# This cop supports safe autocorrection (--autocorrect).
-Style/RedundantFileExtensionInRequire:
-  Exclude:
-    - 'db/seeds.rb'
-
-# Offense count: 1
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: EnforcedStyle, AllowInnerSlashes.
-# SupportedStyles: slashes, percent_r, mixed
-Style/RegexpLiteral:
-  Exclude:
-    - 'spec/features/checkout_spec.rb'
-
-# Offense count: 1
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: implicit, explicit
-Style/RescueStandardError:
-  Exclude:
-    - 'spec/requests/spree/frontend/user_update_spec.rb'
-
-# Offense count: 1
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: AllowModifier.
-Style/SoleNestedConditional:
-  Exclude:
-    - 'config/initializers/warden.rb'
-
-# Offense count: 1
-# This cop supports unsafe autocorrection (--autocorrect-all).
-# Configuration parameters: Mode.
-Style/StringConcatenation:
-  Exclude:
-    - 'app/models/spree/user.rb'
-
-# Offense count: 6
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, AllowedPatterns, IgnoredPatterns.
-# URISchemes: http, https
-Layout/LineLength:
-  Max: 227

data/lib/decorators/backend/controllers/spree/admin/orders/customer_details_controller_decorator.rb

@@ -1,22 +0,0 @@
-# frozen_string_literal: true
-
-module Spree::Admin::Orders::CustomerDetailsControllerDecorator
-  def self.prepended(base)
-    base.before_action :check_authorization
-  end
-
-  private
-
-  def check_authorization
-    load_order
-    session[:access_token] ||= params[:token]
-
-    resource = @order
-    action = params[:action].to_sym
-    action = :edit if action == :show # show route renders :edit for this controller
-
-    authorize! action, resource, session[:access_token]
-  end
-
-  Spree::Admin::Orders::CustomerDetailsController.prepend self
-end

data/lib/generators/solidus/auth/install/templates/config/initializers/devise.rb

@@ -1,3 +0,0 @@
-# frozen_string_literal: true
-
-Devise.secret_key = SecureRandom.hex(50).inspect

data/lib/spree/authentication_helpers.rb

@@ -1,27 +0,0 @@
-# frozen_string_literal: true
-
-module Spree
-  module AuthenticationHelpers
-    def self.included(receiver)
-      if receiver.send(:respond_to?, :helper_method)
-        receiver.send(:helper_method, :spree_current_user)
-
-        if SolidusSupport.frontend_available?
-          receiver.send(:helper_method, :spree_login_path)
-          receiver.send(:helper_method, :spree_signup_path)
-          receiver.send(:helper_method, :spree_logout_path)
-        end
-      end
-    end
-
-    def spree_current_user
-      current_spree_user
-    end
-
-    if SolidusSupport.frontend_available?
-      delegate :login_path, :signup_path, :logout_path,
-               to: :spree,
-               prefix: :spree
-    end
-  end
-end

data/spec/controllers/spree/admin/base_controller_spec.rb

@@ -1,53 +0,0 @@
-# frozen_string_literal: true
-
-require 'spec_helper'
-
-RSpec.describe Spree::Admin::BaseController, type: :controller do
-  describe '#unauthorized_redirect' do
-    controller(described_class) do
-      def index; authorize!(:read, :something); end
-    end
-
-    before do
-      stub_spree_preferences(Spree::Config, redirect_back_on_unauthorized: true)
-    end
-
-    context "when user is logged in" do
-      before { sign_in(create(:user)) }
-
-      context "when http_referrer is not present" do
-        it "redirects to unauthorized path" do
-          get :index
-          expect(response).to redirect_to(spree.admin_unauthorized_path)
-        end
-      end
-
-      context "when http_referrer is present" do
-        before { request.env['HTTP_REFERER'] = '/redirect' }
-
-        it "redirects back" do
-          get :index
-          expect(response).to redirect_to('/redirect')
-        end
-      end
-    end
-
-    context "when user is not logged in" do
-      context "when http_referrer is not present" do
-        it "redirects to login path" do
-          get :index
-          expect(response).to redirect_to(spree.admin_login_path)
-        end
-      end
-
-      context "when http_referrer is present" do
-        before { request.env['HTTP_REFERER'] = '/redirect' }
-
-        it "redirects back" do
-          get :index
-          expect(response).to redirect_to('/redirect')
-        end
-      end
-    end
-  end
-end

data/spec/controllers/spree/admin/user_passwords_controller_spec.rb

@@ -1,14 +0,0 @@
-# frozen_string_literal: true
-
-RSpec.describe Spree::Admin::UserPasswordsController, type: :controller do
-  before { @request.env['devise.mapping'] = Devise.mappings[:spree_user] }
-
-  describe '#create' do
-    it 'responds with success' do
-      post :create, params: { spree_user: { email: 'admin@example.com' } }
-
-      expect(assigns[:spree_user].email).to eq('admin@example.com')
-      expect(response.code).to eq('200')
-    end
-  end
-end

data/spec/controllers/spree/admin/user_sessions_controller_spec.rb

@@ -1,20 +0,0 @@
-# frozen_string_literal: true
-
-RSpec.describe Spree::Admin::UserSessionsController, type: :controller do
-  let(:user) { create(:user, password: 'secret') }
-
-  before { @request.env['devise.mapping'] = Devise.mappings[:spree_user] } # rubocop:disable RSpec/InstanceVariable
-
-  it "redirects to the admin root after signing in with no stored location" do
-    get :new
-
-    post(:create, params: {
-      spree_user: {
-        email: user.email,
-        password: 'secret'
-      },
-    })
-
-    expect(response).to redirect_to spree.admin_path
-  end
-end

data/spec/controllers/spree/base_controller_spec.rb

@@ -1,53 +0,0 @@
-# frozen_string_literal: true
-
-require 'spec_helper'
-
-RSpec.describe Spree::BaseController, type: :controller do
-  describe '#unauthorized_redirect' do
-    controller(described_class) do
-      def index; authorize!(:read, :something); end
-    end
-
-    before do
-      stub_spree_preferences(Spree::Config, redirect_back_on_unauthorized: true)
-    end
-
-    context "when user is logged in" do
-      before { sign_in(create(:user)) }
-
-      context "when http_referrer is not present" do
-        it "redirects to unauthorized path" do
-          get :index
-          expect(response).to redirect_to(spree.unauthorized_path)
-        end
-      end
-
-      context "when http_referrer is present" do
-        before { request.env['HTTP_REFERER'] = '/redirect' }
-
-        it "redirects back" do
-          get :index
-          expect(response).to redirect_to('/redirect')
-        end
-      end
-    end
-
-    context "when user is not logged in" do
-      context "when http_referrer is not present" do
-        it "redirects to login path" do
-          get :index
-          expect(response).to redirect_to(spree.login_path)
-        end
-      end
-
-      context "when http_referrer is present" do
-        before { request.env['HTTP_REFERER'] = '/redirect' }
-
-        it "redirects back" do
-          get :index
-          expect(response).to redirect_to('/redirect')
-        end
-      end
-    end
-  end
-end