solidus_auth_devise 1.0.0

data/spec/controllers/spree/products_controller_spec.rb

@@ -0,0 +1,21 @@
+RSpec.describe Spree::ProductsController, type: :controller do
+
+  let!(:product) { create(:product, available_on: 1.year.from_now) }
+  let!(:user)    { build(:user, spree_api_key: 'fake') }
+
+  it 'allows admins to view non-active products' do
+    allow(controller).to receive(:before_save_new_order)
+    allow(controller).to receive(:spree_current_user) { user }
+    allow(user).to receive(:has_spree_role?) { true }
+    spree_get :show, id: product.to_param
+    expect(response.status).to eq(200)
+  end
+
+  it 'cannot view non-active products' do
+    allow(controller).to receive(:before_save_new_order)
+    allow(controller).to receive(:spree_current_user) { user }
+    allow(user).to receive(:has_spree_role?) { false }
+    spree_get :show, id: product.to_param
+    expect(response.status).to eq(404)
+  end
+end

data/spec/controllers/spree/user_passwords_controller_spec.rb

@@ -0,0 +1,44 @@
+RSpec.describe Spree::UserPasswordsController, type: :controller do
+
+  let(:token) { 'some_token' }
+
+  before { @request.env['devise.mapping'] = Devise.mappings[:spree_user] }
+
+  describe 'GET edit' do
+    context 'when the user token has not been specified' do
+      it 'redirects to the new session path' do
+        spree_get :edit
+        expect(response).to redirect_to(
+          'http://test.host/user/spree_user/sign_in'
+        )
+      end
+
+      it 'flashes an error' do
+        spree_get :edit
+        expect(flash[:alert]).to include(
+          "You can't access this page without coming from a password reset " +
+          'email'
+        )
+      end
+    end
+
+    context 'when the user token has been specified' do
+      it 'does something' do
+        spree_get :edit, reset_password_token: token
+        expect(response.code).to eq('200')
+      end
+    end
+  end
+
+  context '#update' do
+    context 'when updating password with blank password' do
+      it 'shows error flash message, sets spree_user with token and re-displays password edit form' do
+        spree_put :update, { spree_user: { password: '', password_confirmation: '', reset_password_token: token } }
+        expect(assigns(:spree_user).kind_of?(Spree::User)).to eq true
+        expect(assigns(:spree_user).reset_password_token).to eq token
+        expect(flash[:error]).to eq I18n.t(:cannot_be_blank, scope: [:devise, :user_passwords, :spree_user])
+        expect(response).to render_template :edit
+      end
+    end
+  end
+end

data/spec/controllers/spree/user_registrations_controller_spec.rb

@@ -0,0 +1,13 @@
+RSpec.describe Spree::UserRegistrationsController, type: :controller do
+
+  before { @request.env['devise.mapping'] = Devise.mappings[:spree_user] }
+
+  context '#create' do
+    before { allow(controller).to receive(:after_sign_up_path_for).and_return(spree.root_path(thing: 7)) }
+
+    it 'redirects to after_sign_up_path_for' do
+      spree_post :create, { spree_user: { email: 'foobar@example.com', password: 'foobar123', password_confirmation: 'foobar123' } }
+      expect(response).to redirect_to spree.root_path(thing: 7)
+    end
+  end
+end

data/spec/controllers/spree/user_sessions_controller_spec.rb

@@ -0,0 +1,56 @@
+RSpec.describe Spree::UserSessionsController, type: :controller do
+
+  let(:user) { create(:user) }
+
+  before { @request.env['devise.mapping'] = Devise.mappings[:spree_user] }
+
+  context "#create" do
+    context "using correct login information" do
+      it 'properly assigns orders user from guest_token' do
+        order1 = create(:order, guest_token: 'ABC', user_id: nil, created_by_id: nil)
+        order2 = create(:order, guest_token: 'ABC', user_id: 200)
+        request.cookie_jar.signed[:guest_token] = 'ABC'
+        spree_post :create, spree_user: { email: user.email, password: 'secret' }
+
+        expect(order1.reload.user_id).to eq user.id
+        expect(order1.reload.created_by_id).to eq user.id
+        expect(order2.reload.user_id).to eq 200
+      end
+
+      context "and html format is used" do
+        it "redirects to default after signing in" do
+          spree_post :create, spree_user: { email: user.email, password: 'secret' }
+          expect(response).to redirect_to spree.root_path
+        end
+      end
+
+      context "and js format is used" do
+        it "returns a json with ship and bill address" do
+          spree_post :create, spree_user: { email: user.email, password: 'secret' }, format: 'js'
+          parsed = ActiveSupport::JSON.decode(response.body)
+          expect(parsed).to have_key("user")
+          expect(parsed).to have_key("ship_address")
+          expect(parsed).to have_key("bill_address")
+        end
+      end
+    end
+
+    context "using incorrect login information" do
+      context "and html format is used" do
+        it "renders new template again with errors" do
+          spree_post :create, spree_user: { email: user.email, password: 'wrong' }
+          expect(response).to render_template('new')
+          expect(flash[:error]).to eq I18n.t(:'devise.failure.invalid')
+        end
+      end
+
+      context "and js format is used" do
+        it "returns a json with the error" do
+          spree_post :create, spree_user: { email: user.email, password: 'wrong' }, format: 'js'
+          parsed = ActiveSupport::JSON.decode(response.body)
+          expect(parsed).to have_key("error")
+        end
+      end
+    end
+  end
+end

data/spec/controllers/spree/users_controller_spec.rb

@@ -0,0 +1,38 @@
+RSpec.describe Spree::UsersController, type: :controller do
+
+  let(:admin_user) { create(:user) }
+  let(:user) { create(:user) }
+  let(:role) { create(:role) }
+
+  before { allow(controller).to receive(:spree_current_user) { user } }
+
+  context '#load_object' do
+    it 'redirects to signup path if user is not found' do
+      allow(controller).to receive(:spree_current_user) { nil }
+      spree_put :update, { user: { email: 'foobar@example.com' } }
+      expect(response).to redirect_to spree.login_path
+    end
+  end
+
+  context '#create' do
+    it 'creates a new user' do
+      spree_post :create, { user: { email: 'foobar@example.com', password: 'foobar123', password_confirmation: 'foobar123' } }
+      expect(assigns[:user].new_record?).to be false
+    end
+  end
+
+  context '#update' do
+    context 'when updating own account' do
+      it 'performs update' do
+        spree_put :update, { user: { email: 'mynew@email-address.com' } }
+        expect(assigns[:user].email).to eq 'mynew@email-address.com'
+        expect(response).to redirect_to spree.account_url(only_path: true)
+      end
+    end
+
+    it 'does not update roles' do
+      spree_put :update, user: { spree_role_ids: [role.id] }
+      expect(assigns[:user].spree_roles).to_not include role
+    end
+  end
+end

data/spec/factories/confirmed_user.rb

@@ -0,0 +1,7 @@
+FactoryGirl.define do
+  factory :confirmed_user, parent: :user do
+    confirmed_at { Time.now }
+    confirmation_sent_at { Time.now }
+    confirmation_token "12345"
+  end
+end

data/spec/features/account_spec.rb

@@ -0,0 +1,58 @@
+RSpec.feature 'Accounts', type: :feature do
+
+  context 'editing' do
+    scenario 'can edit an admin user' do
+      user = create(:admin_user, email: 'admin@person.com', password: 'password', password_confirmation: 'password')
+      visit spree.login_path
+
+      fill_in 'Email', with: user.email
+      fill_in 'Password', with: user.password
+      click_button 'Login'
+
+      click_link 'My Account'
+      expect(page).to have_text 'admin@person.com'
+    end
+
+    scenario 'can edit a new user' do
+      Spree::Auth::Config.set(signout_after_password_change: false)
+      visit spree.signup_path
+
+      fill_in 'Email', with: 'email@person.com'
+      fill_in 'Password', with: 'password'
+      fill_in 'Password Confirmation', with: 'password'
+      click_button 'Create'
+
+      click_link 'My Account'
+      expect(page).to have_text 'email@person.com'
+      click_link 'Edit'
+
+      fill_in 'Password', with: 'foobar'
+      fill_in 'Password Confirmation', with: 'foobar'
+      click_button 'Update'
+
+      expect(page).to have_text 'email@person.com'
+      expect(page).to have_text 'Account updated'
+    end
+
+    scenario 'can edit an existing user account' do
+      Spree::Auth::Config.set(signout_after_password_change: false)
+      user = create(:user, email: 'email@person.com', password: 'secret', password_confirmation: 'secret')
+      visit spree.login_path
+
+      fill_in 'Email', with: user.email
+      fill_in 'Password', with: user.password
+      click_button 'Login'
+
+      click_link 'My Account'
+      expect(page).to have_text 'email@person.com'
+      click_link 'Edit'
+
+      fill_in 'Password', with: 'foobar'
+      fill_in 'Password Confirmation', with: 'foobar'
+      click_button 'Update'
+
+      expect(page).to have_text 'email@person.com'
+      expect(page).to have_text 'Account updated'
+    end
+  end
+end

data/spec/features/admin/orders_spec.rb

@@ -0,0 +1,29 @@
+RSpec.feature 'Admin orders', type: :feature do
+
+  background do
+    sign_in_as! create(:admin_user)
+  end
+
+  # Regression #203
+  scenario 'can list orders' do
+    expect { visit spree.admin_orders_path }.not_to raise_error
+  end
+
+  # Regression #203
+  scenario 'can new orders' do
+    FactoryGirl.create(:country)
+    expect { visit spree.new_admin_order_path }.not_to raise_error
+  end
+
+  # Regression #203
+  scenario 'can not edit orders' do
+    expect { visit spree.edit_admin_order_path('nodata') }.to raise_error(ActiveRecord::RecordNotFound)
+  end
+
+  # Regression #203
+  scenario 'can edit orders' do
+    create(:order, number: 'R123')
+    visit spree.edit_admin_order_path('R123')
+    expect(page).not_to have_text 'Authorization Failure'
+  end
+end

data/spec/features/admin/password_reset_spec.rb

@@ -0,0 +1,24 @@
+RSpec.feature 'Admin - Reset Password', type: :feature do
+
+  let!(:store) { create(:store) }
+
+  background do
+    ActionMailer::Base.default_url_options[:host] = 'http://example.com'
+  end
+
+  scenario 'allows a user to supply an email for the password reset' do
+    user = create(:user, email: 'foobar@example.com', password: 'secret', password_confirmation: 'secret')
+    visit spree.admin_login_path
+    click_link 'Forgot Password?'
+    fill_in 'Email', with: 'foobar@example.com'
+    click_button 'Reset my password'
+    expect(page).to have_text 'You will receive an email with instructions'
+  end
+
+  scenario 'shows errors if no email is supplied' do
+    visit spree.admin_login_path
+    click_link 'Forgot Password?'
+    click_button 'Reset my password'
+    expect(page).to have_text "Email can't be blank"
+  end
+end

data/spec/features/admin/payment_methods_spec.rb

@@ -0,0 +1,16 @@
+RSpec.feature 'Payment methods', type: :feature do
+
+  background do
+    sign_in_as! create(:admin_user)
+    visit spree.admin_path
+    click_link 'Settings'
+  end
+
+  # Regression test for #5
+  scenario 'can dismiss the banner' do
+    allow_any_instance_of(Spree::User).to receive(:dismissed_banner?) { false }
+    allow(Spree::PaymentMethod).to receive(:production).and_return(payment_methods = [double])
+    allow(payment_methods).to receive(:where).and_return([])
+    click_link 'Payment Methods'
+  end
+end

data/spec/features/admin/products_spec.rb

@@ -0,0 +1,9 @@
+RSpec.feature 'Admin products', type: :feature do
+
+  context 'as anonymous user' do
+    # Regression test for #1250
+    scenario 'redirects to login page when attempting to access product listing' do
+      expect { visit spree.admin_products_path }.not_to raise_error
+    end
+  end
+end

data/spec/features/admin/sign_in_spec.rb

@@ -0,0 +1,44 @@
+RSpec.feature 'Admin - Sign In', type: :feature do
+
+  background do
+    @user = create(:user, email: 'email@person.com')
+    visit spree.admin_login_path
+  end
+
+  scenario 'asks user to sign in' do
+    visit spree.admin_path
+    expect(page).not_to have_text 'Authorization Failure'
+  end
+
+  scenario 'lets a user sign in successfully' do
+    fill_in 'Email', with: @user.email
+    fill_in 'Password', with: 'secret'
+    click_button 'Login'
+
+    expect(page).to have_text 'Logged in successfully'
+    expect(page).not_to have_text 'Login'
+    expect(page).to have_text 'Logout'
+    expect(current_path).to eq '/'
+  end
+
+  scenario 'shows validation erros' do
+    fill_in 'Email', with: @user.email
+    fill_in 'Password', with: 'wrong_password'
+    click_button 'Login'
+
+    expect(page).to have_text 'Invalid email or password'
+    expect(page).to have_text 'Login'
+  end
+
+  scenario 'allows a user to access a restricted page after logging in' do
+    user = create(:admin_user, email: 'admin@person.com')
+    visit spree.admin_path
+
+    fill_in 'Email', with: user.email
+    fill_in 'Password', with: 'secret'
+    click_button 'Login'
+
+    expect(page).to have_text 'Logged in as: admin@person.com'
+    expect(current_path).to eq '/admin/orders'
+  end
+end

data/spec/features/admin/sign_out_spec.rb

@@ -0,0 +1,22 @@
+RSpec.feature 'Admin - Sign Out', type: :feature do
+
+  given!(:user) do
+   create :user, email: 'email@person.com'
+  end
+
+  background do
+    visit spree.admin_login_path
+    fill_in 'Email', with: user.email
+    fill_in 'Password', with: 'secret'
+    # Regression test for #1257
+    check 'Remember me'
+    click_button 'Login'
+  end
+
+  scenario 'allows a signed in user to logout' do
+    click_link 'Logout'
+    visit spree.admin_login_path
+    expect(page).to have_text 'Login'
+    expect(page).not_to have_text 'Logout'
+  end
+end

data/spec/features/admin_permissions_spec.rb

@@ -0,0 +1,46 @@
+RSpec.feature 'Admin Permissions', type: :feature do
+
+  context 'orders' do
+    background do
+      user = create(:admin_user, email: 'admin@person.com', password: 'password', password_confirmation: 'password')
+      Spree::Ability.register_ability(AbilityDecorator)
+      visit spree.login_path
+
+      fill_in 'Email', with: user.email
+      fill_in 'Password', with: user.password
+      click_button 'Login'
+    end
+
+    context 'admin is restricted from accessing orders' do
+      scenario 'can not list orders' do
+        visit spree.admin_orders_path
+        expect(page).to have_text 'Authorization Failure'
+      end
+
+      scenario 'can not edit orders' do
+        create(:order, number: 'R123')
+        visit spree.edit_admin_order_path('R123')
+        expect(page).to have_text 'Authorization Failure'
+      end
+
+      scenario 'can not new orders' do
+        visit spree.new_admin_order_path
+        expect(page).to have_text 'Authorization Failure'
+      end
+    end
+
+    context "admin is restricted from accessing an order's customer details" do
+      given(:order) { create(:order_with_totals) }
+
+      scenario 'can not list customer details for an order' do
+        visit spree.admin_order_customer_path(order)
+        expect(page).to have_text 'Authorization Failure'
+      end
+
+      scenario "can not edit an order's customer details" do
+        visit spree.edit_admin_order_customer_path(order)
+        expect(page).to have_text 'Authorization Failure'
+      end
+    end
+  end
+end