solidus_api 3.1.9 → 3.2.0.alpha

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b92406c37b41f49753572e2aa6ab74e778feae4ef10afabe5596f0bd9ca70a68
-  data.tar.gz: ee352d9fa6437d00cc099afe2ad52a6d8a92d322f8ec374036e95af485a1a047
+  metadata.gz: 954e041b1916b7b90a18bd23c5b62f826589f6c46e6477b9431ab5d581d02252
+  data.tar.gz: 7b2a66b3131d9b5af5d705e59ae6f55a586fce678af50b6f631d9863061a0483
 SHA512:
-  metadata.gz: 5b59195e06ebd6917b003253503881ab98a49fdb388adafc7c58a38a30b0fc511262af98f2c850ade528717ad119a6aea6b20195c0de09e73a132fbfaceba868
-  data.tar.gz: 37ce6153242f6b636a88b2a558d6b66c5ea19340af731092b1ba4cd4247cfbbf2cdcd779e0034547705f9799f82b403303731c290de787e59144555394e76ba6
+  metadata.gz: 11ee74a464094ebee9e038019956e7bb0fb6c7e8fd1bc2fba2efd22932bc4c50bb4335ccdaedf641a982575cc1a3f829abaa44200f8049ba3bca021043827a4a
+  data.tar.gz: ae8e2be6b2454c85ce930b1ab884af06493dd5ae3c3db308c5489d4f42d610e712b61257342a00cc795e67170c6a832e48ae3cbe42f7a600cc00b80d74e1b9c8

data/README.md

@@ -40,5 +40,5 @@ version is released.
   easily extend it with the endpoints provided by your Solidus extensions!
 
 [docs-dir]: https://github.com/solidusio/solidus/tree/master/api/openapi
-[live-docs]: https://solidus.docs.stoplight.io
+[live-docs]: https://solidus.stoplight.io
 [studio]: https://stoplight.io/p/studio

data/app/controllers/spree/api/option_values_controller.rb

@@ -13,11 +13,20 @@ module Spree
       end
 
       def show
+        warn_if_nested_member_route
+
         @option_value = scope.find(params[:id])
         respond_with(@option_value)
       end
 
       def create
+        Spree::Deprecation.warn <<~MSG unless request.path.include?('/option_types/')
+          This route is deprecated, as it'll be no longer possible to create an
+          option_value without an associated option_type. Please, use instead:
+
+            POST api/option_types/{option_type_id}/option_values
+        MSG
+
         authorize! :create, Spree::OptionValue
         @option_value = scope.new(option_value_params)
         if @option_value.save
@@ -28,6 +37,8 @@ module Spree
       end
 
       def update
+        warn_if_nested_member_route
+
         @option_value = scope.accessible_by(current_ability, :update).find(params[:id])
         if @option_value.update(option_value_params)
           render :show
@@ -37,6 +48,8 @@ module Spree
       end
 
       def destroy
+        warn_if_nested_member_route
+
         @option_value = scope.accessible_by(current_ability, :destroy).find(params[:id])
         @option_value.destroy
         render plain: nil, status: 204
@@ -55,6 +68,14 @@ module Spree
       def option_value_params
         params.require(:option_value).permit(permitted_option_value_attributes)
       end
+
+      def warn_if_nested_member_route
+        Spree::Deprecation.warn <<~MSG if request.path.include?('/option_types/')
+          This route is deprecated. Use shallow version instead:
+
+            #{request.method.upcase} api/option_values/:id
+        MSG
+      end
     end
   end
 end

data/app/controllers/spree/api/resource_controller.rb

@@ -1,8 +1,17 @@
 # frozen_string_literal: true
 
+# @deprecated Inherit directly from Spree::Api::BaseController
 class Spree::Api::ResourceController < Spree::Api::BaseController
   before_action :load_resource, only: [:show, :update, :destroy]
 
+  def self.inherited(klass)
+    Spree::Deprecation.warn <<~MSG
+      Spree::Api::ResourceController is deprecated. Please, copy any logic you
+      need and inherit directly from Spree::Api::BaseController.
+    MSG
+    super
+  end
+
   def index
     collection_scope = model_class.accessible_by(current_ability)
     if params[:ids]

data/app/controllers/spree/api/shipments_controller.rb

@@ -40,13 +40,31 @@ module Spree
 
       def create
         authorize! :create, Shipment
-        quantity = params[:quantity].to_i
+
         @shipment = @order.shipments.create(stock_location_id: params.fetch(:stock_location_id))
-        @order.contents.add(variant, quantity, { shipment: @shipment })
 
-        @shipment.save!
+        if passing_deprecated_params_on_create?
+          Spree::Deprecation.warn <<~MSG
+          Passing `quantity` or `variant_id` to
 
-        respond_with(@shipment.reload, default_template: :show)
+              POST /api/shipments
+
+          is deprecated and won't be allowed anymore starting from Solidus 4.0.
+          Instead, create an empty shipment and add items to it subsequently using
+          the dedicated endpoint:
+
+              PUT /api/shipments/{shipment_number}/add
+
+          MSG
+
+          quantity = params[:quantity].to_i
+          variant = Spree::Variant.unscoped.find(params[:variant_id])
+          @order.contents.add(variant, quantity, { shipment: @shipment })
+          @shipment.save!
+          @shipment.reload
+        end
+
+        respond_with(@shipment, default_template: :show)
       end
 
       def update
@@ -130,6 +148,10 @@ module Spree
         authorize! :create, Shipment
       end
 
+      def passing_deprecated_params_on_create?
+        params[:variant_id] || params[:quantity]
+      end
+
       def find_order_on_create
         @order = Spree::Order.find_by!(number: params[:shipment][:order_id])
         authorize! :show, @order

data/app/controllers/spree/api/users_controller.rb

@@ -1,8 +1,10 @@
 # frozen_string_literal: true
 
-class Spree::Api::UsersController < Spree::Api::ResourceController
+class Spree::Api::UsersController < Spree::Api::BaseController
+  before_action :load_resource, only: [:show, :update, :destroy]
+
   def index
-    user_scope = model_class.accessible_by(current_ability, :show)
+    user_scope = user_class.accessible_by(current_ability, :show)
     if params[:ids]
       ids = params[:ids].split(",").flatten
       @users = user_scope.where(id: ids)
@@ -14,20 +16,71 @@ class Spree::Api::UsersController < Spree::Api::ResourceController
     respond_with(@users)
   end
 
-  private
+  def show
+    respond_with(@user)
+  end
+
+  def new
+    authorize! :new, user_class
+    respond_with(user_class.new)
+  end
+
+  def create
+    authorize! :create, user_class
+
+    @user = user_class.new(permitted_user_params)
 
-  attr_reader :user
+    if @user.save
+      respond_with(@user, status: 201, default_template: :show)
+    else
+      invalid_resource!(@user)
+    end
+  end
+
+  def update
+    authorize! :update, @user
 
-  def model_class
+    if @user.update(permitted_user_params)
+      respond_with(@user, status: 200, default_template: :show)
+    else
+      invalid_resource!(@user)
+    end
+  end
+
+  def destroy
+    authorize! :destroy, @user
+
+    destroy_result = if @user.respond_to?(:discard)
+      @user.discard
+    else
+      @user.destroy
+    end
+
+    if destroy_result
+      respond_with(@user, status: 204)
+    else
+      invalid_resource!(@user)
+    end
+  rescue ActiveRecord::DeleteRestrictionError
+    render "spree/api/errors/delete_restriction", status: 422
+  end
+
+  private
+
+  def user_class
     Spree.user_class
   end
 
-  def user_params
-    permitted_resource_params
+  def load_resource
+    @user = user_class.accessible_by(current_ability, :show).find(params[:id])
+  end
+
+  def permitted_user_params
+    params.require(:user).permit(permitted_user_attributes)
   end
 
-  def permitted_resource_attributes
-    if action_name == "create" || can?(:update_email, user)
+  def permitted_user_attributes
+    if action_name == "create" || can?(:update_email, @user)
       super | [:email]
     else
       super

data/app/controllers/spree/api/variants_controller.rb

@@ -6,6 +6,12 @@ module Spree
       before_action :product
 
       def create
+        Spree::Deprecation.warn <<~MSG unless request.path.include?('/products/')
+          This route is deprecated. Use the route nested within the product resource:
+
+            POST api/products/{product_id}/variants
+        MSG
+
         authorize! :create, Variant
         @variant = scope.new(variant_params)
         if @variant.save
@@ -16,6 +22,8 @@ module Spree
       end
 
       def destroy
+        warn_if_nested_member_route
+
         @variant = scope.accessible_by(current_ability, :destroy).find(params[:id])
         @variant.discard
         respond_with(@variant, status: 204)
@@ -25,8 +33,14 @@ module Spree
       # we render on the view so we better update it any time a node is included
       # or removed from the views.
       def index
-        @variants = scope.includes(include_list)
-          .ransack(params[:q]).result
+        @variants =
+          if params[:variant_search_term]
+            Spree::Config.variant_search_class.new(
+              params[:variant_search_term], scope: scope
+            ).results.includes(include_list)
+          else
+            scope.includes(include_list).ransack(params[:q]).result
+          end
 
         @variants = paginate(@variants)
         respond_with(@variants)
@@ -36,12 +50,16 @@ module Spree
       end
 
       def show
+        warn_if_nested_member_route
+
         @variant = scope.includes(include_list)
           .find(params[:id])
         respond_with(@variant)
       end
 
       def update
+        warn_if_nested_member_route
+
         @variant = scope.accessible_by(current_ability, :update).find(params[:id])
         if @variant.update(variant_params)
           respond_with(@variant, status: 200, default_template: :show)
@@ -52,6 +70,14 @@ module Spree
 
       private
 
+      def warn_if_nested_member_route
+        Spree::Deprecation.warn <<~MSG if request.path.include?('/products/')
+          This route is deprecated. Use shallow version instead:
+
+            #{request.method.upcase} api/variants/:id
+        MSG
+      end
+
       def product
         @product ||= Spree::Product.accessible_by(current_ability, :show).friendly.find(params[:product_id]) if params[:product_id]
       end

data/config/routes.rb

@@ -12,10 +12,16 @@ Spree::Core::Engine.routes.draw do
 
     resources :products do
       resources :images
+      # TODO: Use shallow option on Solidus v4.0
       resources :variants
       resources :product_properties
     end
 
+    # TODO: Use only: :index on Solidus v4.0
+    resources :variants do
+      resources :images
+    end
+
     concern :order_routes do
       resources :line_items
       resources :payments do
@@ -47,13 +53,12 @@ Spree::Core::Engine.routes.draw do
       end
     end
 
-    resources :variants do
-      resources :images
-    end
-
     resources :option_types do
+      # TODO: Use shallow option on Solidus v4.0
       resources :option_values
     end
+    # TODO: Use only: :index on Solidus v4.0 and use shallow option on the nested routes
+    # within option_types
     resources :option_values
 
     get '/orders/mine', to: 'orders#mine', as: 'my_orders'

data/lib/spree/api/testing_support/helpers.rb

@@ -47,7 +47,7 @@ module Spree
         end
 
         def upload_image(filename)
-          Rack::Test::UploadedFile.new(File.open(image(filename).path), 'image/jpg')
+          Rack::Test::UploadedFile.new(File.open(image(filename).path), 'image/jpeg')
         end
       end
     end

data/openapi/solidus-api.oas.yml

@@ -682,7 +682,10 @@ paths:
         '404':
           $ref: '#/components/responses/not-found'
       summary: Get product variant
-      description: Retrieves a product's variant.
+      description: |-
+        **Deprecation Warning**: Use [shallow version](/docs/solidus/87df124706c5f-get-variant) instead
+
+        Retrieves a product's variant.
       operationId: get-product-variant
       tags:
         - Variants
@@ -714,7 +717,10 @@ paths:
         '422':
           $ref: '#/components/responses/delete-restriction'
       summary: Delete product variant
-      description: Deletes a product's variant.
+      description: |-
+        **Deprecation Warning**: Use [shallow version](/docs/solidus/82ccaada99139-delete-variant) instead
+
+        Deletes a product's variant.
       operationId: delete-product-variant
       tags:
         - Variants
@@ -735,7 +741,10 @@ paths:
         '422':
           $ref: '#/components/responses/unprocessable-entity'
       summary: Update product variant
-      description: Updates a product's variant.
+      description: |-
+        **Deprecation Warning**: Use [shallow version](/docs/solidus/ce338b5f3b940-update-variant) instead
+
+        Updates a product's variant.
       operationId: update-product-variant
       tags:
         - Variants
@@ -857,7 +866,10 @@ paths:
         '422':
           $ref: '#/components/responses/unprocessable-entity'
       summary: Create variant
-      description: 'Creates a variant. Only users with `can :create, Variant` permissions can perform this action.'
+      description: |-
+        **Deprecation Warning**: Use [nested version](/docs/solidus/681aa6cb75b1e-create-product-variant) instead
+
+        Creates a variant. Only users with `can :create, Variant` permissions can perform this action.
       operationId: create-variant
       tags:
         - Variants
@@ -2544,6 +2556,8 @@ paths:
           $ref: '#/components/responses/unprocessable-entity'
       summary: Create option value
       description: |-
+        **Deprecation Warning**: Use [nested version](/docs/solidus/810154673c613-create-option-type-value) instead
+
         Creates an option value.
 
         Only users with the `create` permission on `Spree::OptionValue` can perform this action.
@@ -2715,7 +2729,10 @@ paths:
         '404':
           $ref: '#/components/responses/not-found'
       summary: Get option type value
-      description: Retrieves an option type's value.
+      description: |-
+        **Deprecation Warning**: Use [shallow version](/docs/solidus/cbbc403ed08a3-get-option-value) instead
+
+        Retrieves an option type's value.
       operationId: get-option-type-value
       tags:
         - Option values
@@ -2749,7 +2766,10 @@ paths:
         '422':
           $ref: '#/components/responses/delete-restriction'
       summary: Delete option type value
-      description: Deletes an option type's value.
+      description: |-
+        **Deprecation Warning**: Use [shallow version](/docs/solidus/0742e63219b1f-delete-option-value) instead
+
+        Deletes an option type's value.
       operationId: delete-option-type-value
       tags:
         - Option values
@@ -2771,6 +2791,8 @@ paths:
           $ref: '#/components/responses/unprocessable-entity'
       summary: Update option type value
       description: |-
+        **Deprecation Warning**: Use [shallow version](/docs/solidus/b43f889175ebb-update-option-value) instead
+
         Updates an option type's value.
 
         Only users with the `update` permission on the option value can perform this action.
@@ -5569,6 +5591,10 @@ paths:
         Creates a shipment.
 
         Please note that this request can be only performed by users with the `create` permission on the shipment.
+
+        **Deprecation Warning**: Adding items to the shipment via this endpoint
+        is deprecated. Instead, create an empty shipment and populate it with
+        the dedicated endpoint [to add items to the shipment](/docs/solidus/7078dbcf415ac-add-shipment-item).
       operationId: create-shipment
       tags:
         - Shipments
@@ -5584,8 +5610,10 @@ paths:
                   type: integer
                 variant_id:
                   type: integer
+                  deprecated: true
                 quantity:
                   type: integer
+                  deprecated: true
             examples:
               Example:
                 value:
@@ -7141,6 +7169,8 @@ components:
           type: boolean
         product_id:
           type: integer
+        tax_category_id:
+          type: integer
         weight:
           type: string
         height:
@@ -7161,6 +7191,23 @@ components:
           type: array
           items:
             $ref: '#/components/schemas/option-value-input'
+        options:
+        weight:
+          type: string
+        height:
+          type: string
+        width:
+          type: string
+        depth:
+          type: string
+        sku:
+          type: string
+        cost_currency:
+          type: string
+        option_value_ids:
+          type: array
+          items:
+            type: integer
         options:
           type: object
           description: '`Name` will be the name/presentation of the option type and `Value` will be the name/presentation of the option value. They will be created if not exist.'

data/solidus_api.gemspec

@@ -14,6 +14,8 @@ Gem::Specification.new do |s|
   s.homepage    = 'http://solidus.io'
   s.license     = 'BSD-3-Clause'
 
+  s.metadata['rubygems_mfa_required'] = 'true'
+
   s.files = `git ls-files -z`.split("\x0").reject do |f|
     f.match(%r{^(spec|script)/})
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: solidus_api
 version: !ruby/object:Gem::Version
-  version: 3.1.9
+  version: 3.2.0.alpha
 platform: ruby
 authors:
 - Solidus Team
-autorequire:
+autorequire: 
 bindir: bin
 cert_chain: []
-date: 2023-02-07 00:00:00.000000000 Z
+date: 2022-08-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: jbuilder
@@ -58,14 +58,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 3.1.9
+        version: 3.2.0.alpha
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 3.1.9
+        version: 3.2.0.alpha
 description: REST API for the Solidus e-commerce framework.
 email: contact@solidus.io
 executables: []
@@ -255,8 +255,9 @@ files:
 homepage: http://solidus.io
 licenses:
 - BSD-3-Clause
-metadata: {}
-post_install_message:
+metadata:
+  rubygems_mfa_required: 'true'
+post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
@@ -271,8 +272,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: 1.8.23
 requirements: []
-rubygems_version: 3.3.7
-signing_key:
+rubygems_version: 3.1.2
+signing_key: 
 specification_version: 4
 summary: REST API for the Solidus e-commerce framework.
 test_files: []