solidus_api 2.5.2 → 2.6.0.rc1

data/spec/models/spree/legacy_user_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 module Spree

data/spec/requests/api/address_books_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 module Spree

data/spec/requests/rabl_cache_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe "Rabl Cache", type: :request, caching: true do

data/spec/requests/ransackable_attributes_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe "Ransackable Attributes" do

data/spec/requests/spree/api/addresses_controller_spec.rb

@@ -1,8 +1,9 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 module Spree
   describe Api::AddressesController, type: :request do
-
     before do
       stub_authentication!
       @address = create(:address)

data/spec/requests/spree/api/checkouts_controller_spec.rb

@@ -1,8 +1,9 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 module Spree
   describe Api::CheckoutsController, type: :request do
-
     before(:each) do
       stub_authentication!
       Spree::Config[:track_inventory_levels] = false

data/spec/requests/spree/api/classifications_controller_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 module Spree

data/spec/requests/spree/api/config_controller_spec.rb

@@ -1,8 +1,10 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 module Spree
   describe Api::ConfigController, type: :request do
-    let!(:default_country) { create :country, iso: "US"}
+    let!(:default_country) { create :country, iso: "US" }
 
     before do
       stub_authentication!

data/spec/requests/spree/api/countries_controller_spec.rb

@@ -1,8 +1,9 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 module Spree
   describe Api::CountriesController, type: :request do
-
     before do
       stub_authentication!
       @state = create(:state)

data/spec/requests/spree/api/credit_cards_controller_spec.rb

@@ -1,9 +1,10 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 module Spree
   describe Api::CreditCardsController, type: :request do
     describe '#index' do
-
       let!(:admin_user) do
         create(:admin_user)
       end

data/spec/requests/spree/api/images_controller_spec.rb

@@ -1,8 +1,9 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 module Spree
   describe Spree::Api::ImagesController, type: :request do
-
     let!(:product) { create(:product) }
     let!(:attributes) {
       [:id, :position, :attachment_content_type,

data/spec/requests/spree/api/inventory_units_controller_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 module Spree

data/spec/requests/spree/api/line_items_controller_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 module Spree
@@ -10,7 +12,6 @@ module Spree
   end
 
   describe Api::LineItemsController, type: :request do
-
     let!(:order) { create(:order_with_line_items, line_items_count: 1) }
 
     let(:product) { create(:product) }

data/spec/requests/spree/api/option_types_controller_spec.rb

@@ -1,8 +1,9 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 module Spree
   describe Api::OptionTypesController, type: :request do
-
     let(:attributes) { [:id, :name, :position, :presentation] }
     let!(:option_value) { create(:option_value) }
     let!(:option_type) { option_value.option_type }

data/spec/requests/spree/api/option_values_controller_spec.rb

@@ -1,8 +1,9 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 module Spree
   describe Api::OptionValuesController, type: :request do
-
     let(:attributes) { [:id, :name, :presentation, :option_type_name, :option_type_name] }
     let!(:option_value) { create(:option_value) }
     let!(:option_type) { option_value.option_type }
@@ -101,7 +102,7 @@ module Spree
         end
 
         it "cannot create an option type with invalid attributes" do
-          post spree.api_option_type_option_values_path(option_type), params: { option_value: {name: ""} }
+          post spree.api_option_type_option_values_path(option_type), params: { option_value: { name: "" } }
           expect(response.status).to eq(422)
         end
 

data/spec/requests/spree/api/orders_controller_spec.rb

@@ -1,5 +1,6 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
-require 'spree/testing_support/bar_ability'
 
 module Spree
   describe Api::OrdersController, type: :request do
@@ -347,6 +348,21 @@ module Spree
           expect(credit_cards[0]['id']).to eq payment.source.id
           expect(credit_cards[0]['address']['id']).to eq credit_card.address_id
         end
+
+        it 'renders the payment source view for gateway' do
+          subject
+          expect(response).to render_template partial: 'spree/api/payments/source_views/_gateway'
+        end
+      end
+
+      context 'when store credit is present' do
+        let!(:payment) { create(:store_credit_payment, order: order, source: store_credit) }
+        let(:store_credit) { create(:store_credit) }
+
+        it 'renders the payment source view for store credit' do
+          subject
+          expect(response).to render_template partial: 'spree/api/payments/source_views/_storecredit'
+        end
       end
     end
 
@@ -373,18 +389,6 @@ module Spree
       expect(response.status).to eq(200)
     end
 
-    context "with BarAbility registered" do
-      before { Spree::Ability.register_ability(::BarAbility) }
-      after { Spree::Ability.remove_ability(::BarAbility) }
-
-      it "can view an order" do
-        user = build(:user, spree_roles: [Spree::Role.new(name: 'bar')])
-        allow(Spree.user_class).to receive_messages find_by: user
-        get spree.api_order_path(order)
-        expect(response.status).to eq(200)
-      end
-    end
-
     it "cannot cancel an order that doesn't belong to them" do
       order.update_attribute(:completed_at, Time.current)
       order.update_attribute(:shipment_state, "ready")

data/spec/requests/spree/api/payments_controller_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 module Spree

data/spec/requests/spree/api/product_properties_controller_spec.rb

@@ -1,9 +1,10 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'shared_examples/protect_product_actions'
 
 module Spree
   describe Spree::Api::ProductPropertiesController, type: :request do
-
     let!(:product) { create(:product) }
     let!(:property_1) { product.product_properties.create(property_name: "My Property 1", value: "my value 1", position: 0) }
     let!(:property_2) { product.product_properties.create(property_name: "My Property 2", value: "my value 2", position: 1) }

data/spec/requests/spree/api/products_controller_spec.rb

@@ -1,9 +1,10 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'shared_examples/protect_product_actions'
 
 module Spree
   describe Spree::Api::ProductsController, type: :request do
-
     let!(:product) { create(:product) }
     let!(:inactive_product) { create(:product, available_on: Time.current.tomorrow, name: "inactive") }
     let(:base_attributes) { Api::ApiHelpers.product_attributes }
@@ -349,7 +350,7 @@ module Spree
           expect(response.status).to eq 200
           expect(json_response['variants'].count).to eq(2) # 2 variants
 
-          variants = json_response['variants'].select { |v| !v['is_master'] }
+          variants = json_response['variants'].reject { |v| v['is_master'] }
           size_option_value = variants.last['option_values'].detect{ |x| x['option_type_name'] == 'size' }
           expect(size_option_value['name']).to eq('small')
 
@@ -373,7 +374,7 @@ module Spree
           } }
 
           expect(json_response['variants'].count).to eq(1)
-          variants = json_response['variants'].select { |v| !v['is_master'] }
+          variants = json_response['variants'].reject { |v| v['is_master'] }
           expect(variants.last['option_values'][0]['name']).to eq('large')
           expect(variants.last['sku']).to eq('456')
           expect(variants.count).to eq(1)

data/spec/requests/spree/api/promotion_application_spec.rb

@@ -1,8 +1,9 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 module Spree::Api
   describe OrdersController, type: :request do
-
     before do
       stub_authentication!
     end

data/spec/requests/spree/api/promotions_controller_spec.rb

@@ -1,8 +1,9 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 module Spree
   describe Spree::Api::PromotionsController, type: :request do
-
     shared_examples "a JSON response" do
       it 'should be ok' do
         subject

data/spec/requests/spree/api/properties_controller_spec.rb

@@ -1,7 +1,8 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 module Spree
   describe Spree::Api::PropertiesController, type: :request do
-
     let!(:property_1) { Property.create!(name: "foo", presentation: "Foo") }
     let!(:property_2) { Property.create!(name: "bar", presentation: "Bar") }
 

data/spec/requests/spree/api/return_authorizations_controller_spec.rb

@@ -1,8 +1,9 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 module Spree
   describe Api::ReturnAuthorizationsController, type: :request do
-
     let!(:order) { create(:shipped_order) }
 
     let(:product) { create(:product) }

data/spec/requests/spree/api/shipments_controller_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Spree::Api::ShipmentsController, type: :request do
@@ -212,6 +214,17 @@ describe Spree::Api::ShipmentsController, type: :request do
               expect(json_response['shipments'][0]['order']['payments'][0]['source'].keys).to match_array ["id"]
             end
           end
+
+          context "check payment" do
+            let(:current_api_user) { shipped_order.user }
+            let(:shipped_order)    { create(:shipped_order, payment_type: :check_payment) }
+
+            before { subject }
+
+            it 'does not try to render a nil source' do
+              expect(json_response['shipments'][0]['order']['payments'][0]['source']).to eq(nil)
+            end
+          end
         end
 
         context 'with filtering' do

data/spec/requests/spree/api/states_controller_spec.rb

@@ -1,8 +1,9 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 module Spree
   describe Api::StatesController, type: :request do
-
     let!(:state) { create(:state, name: "Victoria") }
     let(:attributes) { [:id, :name, :abbr, :country_id] }
 

data/spec/requests/spree/api/stock_items_controller_spec.rb

@@ -1,8 +1,9 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 module Spree
   describe Api::StockItemsController, type: :request do
-
     let!(:stock_location) { create(:stock_location_with_items) }
     let!(:stock_item) { stock_location.stock_items.order(:id).first }
     let!(:attributes) {

data/spec/requests/spree/api/stock_locations_controller_spec.rb

@@ -1,8 +1,9 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 module Spree
   describe Api::StockLocationsController, type: :request do
-
     let!(:stock_location) { create(:stock_location) }
     let!(:attributes) { [:id, :name, :address1, :address2, :city, :state_id, :state_name, :country_id, :zipcode, :phone, :active] }
 

data/spec/requests/spree/api/stock_movements_controller_spec.rb

@@ -1,8 +1,9 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 module Spree
   describe Api::StockMovementsController, type: :request do
-
     let!(:stock_location) { create(:stock_location_with_items) }
     let!(:stock_item) { stock_location.stock_items.order(:id).first }
     let!(:stock_movement) { create(:stock_movement, stock_item: stock_item) }

data/spec/requests/spree/api/store_credit_events_controller_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Spree::Api::StoreCreditEventsController, type: :request do

data/spec/requests/spree/api/stores_controller_spec.rb

@@ -1,8 +1,9 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
 module Spree
   describe Api::StoresController, type: :request do
-
     let!(:store) do
       create(:store, name: "My Spree Store", url: "spreestore.example.com")
     end
@@ -18,8 +19,7 @@ module Spree
         create(:store,
           name: "Extra Store",
           url: "spreestore-5.example.com",
-          default: false
-        )
+          default: false)
       end
 
       it "can list the available stores" do
@@ -35,7 +35,8 @@ module Spree
             "mail_from_address" => "spree@example.org",
             "default_currency" => nil,
             "code" => store.code,
-            "default" => true
+            "default" => true,
+            "available_locales" => ["en"]
           },
           {
             "id" => non_default_store.id,
@@ -47,7 +48,8 @@ module Spree
             "mail_from_address" => "spree@example.org",
             "default_currency" => nil,
             "code" => non_default_store.code,
-            "default" => false
+            "default" => false,
+            "available_locales" => ["en"]
           }
         ])
       end
@@ -64,7 +66,8 @@ module Spree
           "mail_from_address" => "spree@example.org",
           "default_currency" => nil,
           "code" => store.code,
-          "default" => true
+          "default" => true,
+          "available_locales" => ["en"]
         )
       end
 

data/spec/requests/spree/api/taxonomies_controller_spec.rb

@@ -1,8 +1,9 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 module Spree
   describe Api::TaxonomiesController, type: :request do
-
     let(:taxonomy) { create(:taxonomy) }
     let(:taxon) { create(:taxon, name: "Ruby", taxonomy: taxonomy) }
     let(:taxon2) { create(:taxon, name: "Rails", taxonomy: taxonomy) }

data/spec/requests/spree/api/taxons_controller_spec.rb

@@ -1,8 +1,9 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 module Spree
   describe Api::TaxonsController, type: :request do
-
     let(:taxonomy) { create(:taxonomy) }
     let(:taxon) { create(:taxon, name: "Ruby", taxonomy: taxonomy) }
     let(:taxon2) { create(:taxon, name: "Rails", taxonomy: taxonomy) }

data/spec/requests/spree/api/unauthenticated_products_controller_spec.rb

@@ -1,11 +1,12 @@
+# frozen_string_literal: true
+
 require 'shared_examples/protect_product_actions'
 require 'spec_helper'
 
 module Spree
   describe Spree::Api::ProductsController, type: :request do
-
     let!(:product) { create(:product) }
-    let(:attributes) { [:id, :name, :description, :price, :available_on, :slug, :meta_description, :meta_keywords, :taxon_ids] }
+    let(:attributes) { [:id, :name, :description, :price, :available_on, :slug, :meta_description, :meta_keywords, :taxon_ids, :meta_title] }
 
     context "without authentication" do
       before { Spree::Api::Config[:requires_authentication] = false }

data/spec/requests/spree/api/users_controller_spec.rb

@@ -1,8 +1,9 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 module Spree
   describe Api::UsersController, type: :request do
-
     let(:user) { create(:user, spree_api_key: SecureRandom.hex) }
     let(:stranger) { create(:user, email: 'stranger@example.com') }
     let(:attributes) { [:id, :email, :created_at, :updated_at] }

data/spec/requests/spree/api/variants_controller_spec.rb

@@ -1,8 +1,9 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 module Spree
   describe Api::VariantsController, type: :request do
-
     let!(:product) { create(:product) }
     let!(:variant) do
       variant = product.master
@@ -87,7 +88,6 @@ module Spree
       end
 
       context "stock filtering" do
-
         context "only variants in stock" do
           subject { get spree.api_variants_path, params: { in_stock_only: "true" } }
 

data/spec/requests/spree/api/zones_controller_spec.rb

@@ -1,8 +1,9 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 module Spree
   describe Api::ZonesController, type: :request do
-
     let!(:attributes) { [:id, :name, :zone_members] }
     let!(:zone) { create(:zone, name: 'Europe') }
 

data/spec/shared_examples/protect_product_actions.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 shared_examples "modifying product actions are restricted" do
   it "cannot create a new product if not an admin" do
     post spree.api_products_path, params: { product: { name: "Brand new product!" } }

data/spec/spec_helper.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 if ENV["COVERAGE"]
   require 'simplecov'
   SimpleCov.start('rails')
@@ -9,7 +11,7 @@ ENV["RAILS_ENV"] ||= 'test'
 require 'solidus_api'
 require 'spree/testing_support/dummy_app'
 DummyApp.setup(
-  gem_root: File.expand_path('../../', __FILE__),
+  gem_root: File.expand_path('..', __dir__),
   lib_name: 'solidus_api'
 )
 

data/spec/support/be_paginated_matcher.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 RSpec::Matchers.define :be_paginated do
   match do |actual|
     %w[count total_count current_page pages per_page].all? do |attr|

data/spec/support/controller_hacks.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'active_support/all'
 
 module ControllerHacks

data/spec/support/database_cleaner.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 RSpec.configure do |config|
   config.before(:suite) do
     DatabaseCleaner.strategy = :transaction

data/spec/support/have_attributes_matcher.rb

@@ -1,4 +1,6 @@
 
+# frozen_string_literal: true
+
 RSpec::Matchers.define :have_attributes do |expected_attributes|
   match do |actual|
     # actual is a Hash object representing an object, like this:

data/spec/test_views/spree/api/widgets/_widget.json.jbuilder

@@ -1 +1,3 @@
+# frozen_string_literal: true
+
 json.(widget, :id, :name, :position)

data/spec/test_views/spree/api/widgets/index.json.jbuilder

@@ -1,7 +1,9 @@
 
+# frozen_string_literal: true
+
 json.widgets(@collection) do |widget|
   json.partial!("spree/api/widgets/widget", widget: widget)
 end
 json.count @collection.count
-json.current_page (params[:page] or 1)
+json.current_page(params[:page] || 1)
 json.pages @collection.total_pages

data/spec/test_views/spree/api/widgets/new.json.jbuilder

@@ -1 +1,3 @@
+# frozen_string_literal: true
+
 json.attributes [:name]

data/spec/test_views/spree/api/widgets/show.json.jbuilder

@@ -1 +1,3 @@
+# frozen_string_literal: true
+
 json.partial!("spree/api/widgets/widget", widget: @object)