solidus_api 1.0.0 → 1.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d27588691187f5bfafd293c58b32ca4f986f8597
-  data.tar.gz: 03426e3a800a3eb658e90cfbf6ed6b5153a90baf
+  metadata.gz: 34a5d9ad65766d57b6e668c543035339ba715129
+  data.tar.gz: 867a41c74f427ebe79572a9f1794bf11d8a19905
 SHA512:
-  metadata.gz: 70be4d68f085a8720c15b186322c577c2a4d55e1cc7a155a68a523da5dd0bc6d1c1e09b268d0dcacbfc7b71074ef30d3660a3e920ccdd50c7978ccbce584b816
-  data.tar.gz: 9560d163fb767699b587e1bf477a643a34a72787b2d7523518a2c6d3549928cd89aef3e216d6bb27bb74648db34bd429b8fbeb76eb7d4c41c0a6ed096206dfce
+  metadata.gz: 38037983b84aa6132810cb4d25559c82f10c4ddb116fbf4b09679357923c7fb9e386074e6f0b28d0b6625219dd38107d26c17f8070f5dd908de4cb441c5defaa
+  data.tar.gz: e6c21c9dda1779187bc03c9380cdf12e010ab383669fd1c4ec1707d62ff27a84f7221d53ff15f74c2ada177a11a9705dcb806ac878830805955891f4160c187a

data/app/helpers/spree/api/api_helpers.rb

@@ -93,7 +93,7 @@ module Spree
 
       @@payment_attributes = [
         :id, :source_type, :source_id, :amount, :display_amount,
-        :payment_method_id, :response_code, :state, :avs_response, :created_at,
+        :payment_method_id, :state, :avs_response, :created_at,
         :updated_at
       ]
 

data/spec/controllers/spree/api/payments_controller_spec.rb

@@ -6,7 +6,7 @@ module Spree
     let!(:order) { create(:order) }
     let!(:payment) { create(:payment, :order => order) }
     let!(:attributes) { [:id, :source_type, :source_id, :amount, :display_amount,
-                         :payment_method_id, :response_code, :state, :avs_response,
+                         :payment_method_id, :state, :avs_response,
                          :created_at, :updated_at] }
 
     let(:resource_scoping) { { :order_id => order.to_param } }
@@ -107,7 +107,7 @@ module Spree
       end
 
       context "multiple payments" do
-        before { @payment = create(:payment, :order => order, :response_code => '99999') }
+        before { @payment = create(:payment, :order => order) }
 
         it "can view all payments on an order" do
           api_get :index
@@ -120,12 +120,6 @@ module Spree
           expect(json_response['current_page']).to eq(1)
           expect(json_response['pages']).to eq(2)
         end
-
-        it 'can query the results through a paramter' do
-          api_get :index, :q => { :response_code_cont => '999' }
-          expect(json_response['count']).to eq(1)
-          expect(json_response['payments'].first['response_code']).to eq @payment.response_code
-        end
       end
 
       context "for a given payment" do

data/spec/requests/ransackable_attributes_spec.rb

@@ -0,0 +1,79 @@
+require 'spec_helper'
+
+describe "Ransackable Attributes" do
+  let(:user) { create(:user).tap(&:generate_spree_api_key!) }
+  let(:order) { create(:order_with_line_items, user: user) }
+  context "filtering by attributes one association away" do
+    it "does not allow the filtering of variants by order attributes" do
+      2.times { create(:variant) }
+
+      get "/api/variants?q[orders_email_start]=#{order.email}", token: user.spree_api_key
+
+      variants_response = JSON.parse(response.body)
+      expect(variants_response['total_count']).to eq(Spree::Variant.count)
+    end
+  end
+
+  context "filtering by attributes two associations away" do
+    it "does not allow the filtering of variants by user attributes" do
+      2.times { create(:variant) }
+
+      get "/api/variants?q[orders_user_email_start]=#{order.user.email}", token: user.spree_api_key
+
+      variants_response = JSON.parse(response.body)
+      expect(variants_response['total_count']).to eq(Spree::Variant.count)
+    end
+  end
+
+  context "it maintains desired association behavior" do
+    it "allows filtering of variants product name" do
+      product = create(:product, name: "Fritos")
+      variant = create(:variant, product: product)
+      other_variant = create(:variant)
+
+      get "/api/variants?q[product_name_or_sku_cont]=fritos", token: user.spree_api_key
+
+      skus = JSON.parse(response.body)['variants'].map { |variant| variant['sku'] }
+      expect(skus).to include variant.sku
+      expect(skus).not_to include other_variant.sku
+    end
+  end
+
+  context "filtering by attributes" do
+    it "most attributes are not filterable by default" do
+      product = create(:product, description: "special product")
+      other_product = create(:product)
+
+      get "/api/products?q[description_cont]=special", token: user.spree_api_key
+
+      products_response = JSON.parse(response.body)
+      expect(products_response['total_count']).to eq(Spree::Product.count)
+    end
+
+    it "id is filterable by default" do
+      product = create(:product)
+      other_product = create(:product)
+
+      get "/api/products?q[id_eq]=#{product.id}", token: user.spree_api_key
+
+      product_names = JSON.parse(response.body)['products'].map { |product| product['name'] }
+      expect(product_names).to include product.name
+      expect(product_names).not_to include other_product.name
+    end
+  end
+
+  context "filtering by whitelisted attributes" do
+    it "filtering is supported for whitelisted attributes" do
+      product = create(:product, name: "Fritos")
+      other_product = create(:product)
+
+      get "/api/products?q[name_cont]=fritos", token: user.spree_api_key
+
+      product_names = JSON.parse(response.body)['products'].map { |product| product['name'] }
+      expect(product_names).to include product.name
+      expect(product_names).not_to include other_product.name
+    end
+  end
+
+
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: solidus_api
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.1
 platform: ruby
 authors:
 - Solidus Team
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-08-11 00:00:00.000000000 Z
+date: 2015-08-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: solidus_core
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.0.0
+        version: 1.0.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.0.0
+        version: 1.0.1
 - !ruby/object:Gem::Dependency
   name: rabl
   requirement: !ruby/object:Gem::Requirement
@@ -253,6 +253,7 @@ files:
 - spec/fixtures/thinking-cat.jpg
 - spec/models/spree/legacy_user_spec.rb
 - spec/requests/rabl_cache_spec.rb
+- spec/requests/ransackable_attributes_spec.rb
 - spec/shared_examples/protect_product_actions.rb
 - spec/spec_helper.rb
 - spec/support/controller_hacks.rb
@@ -321,6 +322,7 @@ test_files:
 - spec/fixtures/thinking-cat.jpg
 - spec/models/spree/legacy_user_spec.rb
 - spec/requests/rabl_cache_spec.rb
+- spec/requests/ransackable_attributes_spec.rb
 - spec/shared_examples/protect_product_actions.rb
 - spec/spec_helper.rb
 - spec/support/controller_hacks.rb