solidus-returnly 0.11.0 → 0.12.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: bbba58335cd0c6733fd3ac7ac1cd1138f9fe60c3c9fd054d333d6cd214880af4
-  data.tar.gz: 92908dfff3ed9d1725e8439404ea3da94bbe7849d6b004ea95eb81dca871e7ac
+  metadata.gz: c65b26145ed509d151c337ef349bb1573cba5703e80b646dfa874ac6566c66a2
+  data.tar.gz: ea4067aaaf9ebd7b97927c2e9c586f4398654e4388009f2c5f226ceaa9b70979
 SHA512:
-  metadata.gz: acb300cf3987ae5db4687721141f20336abb11cd333e27f44edd60a45a8b0b63d362a5c1cd31da59654c7788a2f07a8099b554facacf5bd8f9273c339d222f48
-  data.tar.gz: bc19abf556483df2f5c5931f1e607607fc2f414cb51e93423c0c1287091c4eee51ecef94e47de732a8c1f7645151ee8c7807e5d4fb403a4cb47191144784245c
+  metadata.gz: 8be45554263a53fd0e88c8a9255d437861815e01cc174bc3f0d0b8476d71e4cca99068a493257b7e6297c60cd9319bc3488b1457d2d41d24cf2f57ec12940de8
+  data.tar.gz: b9322a7879716d05367cce5609737af8f628a43bb34412d0b9691ca3487ce2862a8aa95531b345d1db470616f6d262d627d6f5cd11a9323f6d68891f47bf34a5

data/lib/returnly/builders/return_item.rb

@@ -8,30 +8,19 @@ module Returnly
       end
 
       def build_by_requested_line_items(requested_line_items)
-        is_returned_item = false
-        items = requested_line_items.each_with_object([]) do |request_line_item, return_items|
+        requested_line_items.each_with_object([]) do |request_line_item, return_items|
           quantity = request_line_item[:units].to_i
           next return_items unless quantity > 0
 
-          inventory_units = inventory_units_by(request_line_item[:order_line_item_id])
-          if inventory_units.empty?
-            inventory_units = returned_inventory_units_by(request_line_item[:order_line_item_id])
-            request_line_item[:find_return?] = true
-            is_returned_item = true
-          end
-          inventory_units.take(quantity).each do |inventory_unit|
+          inventory_units_by(request_line_item[:order_line_item_id]).take(quantity).each do |inventory_unit|
             return_items << build_by_inventory_unit(inventory_unit, request_line_item)
           end
 
           return_items
         end
-        {
-          items: items,
-          is_returned_items: is_returned_item
-        }
       end
 
-      def exact_build_by_inventory_unit(inventory_unit, options = {})
+      def build_by_inventory_unit(inventory_unit, options = {})
         Spree::ReturnItem.new(
           amount: inventory_unit.line_item.price,
           acceptance_status: 'accepted',
@@ -41,14 +30,6 @@ module Returnly
         )
       end
 
-      def build_by_inventory_unit(inventory_unit, options = {})
-        return exact_build_by_inventory_unit(inventory_unit, options) unless options[:find_return?]
-        Spree::ReturnItem.find_by(
-          amount: inventory_unit.line_item.price,
-          inventory_unit_id: inventory_unit.id
-        )
-      end
-
       private
 
       def inventory_units_by(line_item_ids)
@@ -56,12 +37,6 @@ module Returnly
           .where(line_item_id: line_item_ids)
           .where.not(state: 'returned')
       end
-
-      def returned_inventory_units_by(line_item_ids)
-        order.inventory_units.includes(:line_item, :return_items)
-          .where(line_item_id: line_item_ids, state: 'returned')
-          .where(spree_return_items: { reimbursement_id: nil })
-      end
     end
   end
 end

data/lib/returnly/refund_calculator.rb

@@ -21,17 +21,12 @@ module Returnly
     end
 
     def line_items_return_items
-      available_to_return = available_return_items
-      items = available_to_return[:items].each_with_object({}) do |return_item, return_items|
+      available_return_items.each_with_object({}) do |return_item, return_items|
         line_item_id = return_item.inventory_unit.line_item_id
         return_items[line_item_id] ||= []
         return_items[line_item_id] << set_tax(return_item)
         return_items
       end
-      {
-        items: items,
-        is_returned_items: available_to_return[:is_returned_items]
-      }
     end
 
     def shipping_tax

data/lib/returnly/refund_presenter.rb

@@ -5,16 +5,12 @@ module Returnly
       sub_total = Money.new 0
       tax = Money.new 0
 
-      return_items = calculator.line_items_return_items
-      return_items[:items].values.flatten.each do |return_item|
-        sub_total += Money.from_amount return_item.total_excluding_vat
+      calculator.line_items_return_items.values.flatten.each do |return_item|
+        sub_total += Money.from_amount return_item.inventory_unit.line_item.price
         tax += Money.from_amount calculator.line_item_tax(return_item.inventory_unit.line_item)
       end
 
       discount = Money.from_amount(calculator.discount)
-      if return_items[:is_returned_items]
-        sub_total += discount
-      end
       total_refund_amount = sub_total + tax - (discount * -1) # discount is negative, so we multiply it by -1 to make it positive for subtraction
       shipping_tax        = calculator.shipping_tax
       {

data/lib/returnly/refunder.rb

@@ -95,7 +95,7 @@ module Returnly
     end
 
     def each_return_item
-      return_items = refund_calculator.line_items_return_items[:items].values.flatten
+      return_items = refund_calculator.line_items_return_items.values.flatten
       self.customer_return = Returnly::Builders::CustomerReturn.build_by_return_items(return_items)
 
       return_items.each do |return_item|

data/lib/returnly/version.rb

@@ -1,5 +1,5 @@
 module Returnly
-  VERSION = '0.11.0'
+  VERSION = '0.12.0'
 
   def platform_version
     defined?(Solidus)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: solidus-returnly
 version: !ruby/object:Gem::Version
-  version: 0.11.0
+  version: 0.12.0
 platform: ruby
 authors:
 - Returnly Technologies, Inc
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-07-30 00:00:00.000000000 Z
+date: 2018-08-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: solidus