solid_use_case 2.1.0 → 2.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 5810571bbc17faba88269dbdbe7f205d1e28d13b
-  data.tar.gz: 9576bcb516c93bd5e2f7b71ef1432746c3181f54
+  metadata.gz: 50ac616300a91a04f78a2a4934820b138485bda7
+  data.tar.gz: 343dcee1c7461a90bb05d9f690ec3e3adfbc9040
 SHA512:
-  metadata.gz: 51fbf7ebc22c9ee27484bf6834e00cece81b165b233142d1fde1e7509fac6bddb4c1c050fdf173e59c77cd577d77452c5b6e8a0ecf0e41add6e32bc0bdb2afe5
-  data.tar.gz: adf744a459a4b8a70febc3bdcc7a0632751e0f0dfb25c895e38df316b8a1bef9bb37cf98bbb0a657846fa4bd6da07a3b7ee71dfdb39d32487af750003c10e306
+  metadata.gz: 0bd5934d65811ec08f7a36086c114319fc08dfcd6928af573753107bbdfee9c15faa88e1512e8cba2062bff8433f047aca97fbac2c9fe1b18f5713e414dab300
+  data.tar.gz: 47984ff8d514e5b4ec51f785fae3c7495a1b22a41529890ba3ea2c2793f710076d515011373f8e3d2dd0c954187356341e65dd0b045d84e398f323b496e95f80

data/README.md

@@ -6,7 +6,7 @@
 
 Add this line to your application's Gemfile:
 
-    gem 'solid_use_case', '~> 2.1.0'
+    gem 'solid_use_case', '~> 2.1.1'
 
 And then execute:
 
@@ -42,7 +42,7 @@ class UserSignup
 
   def save_user(params)
     user = params[:user]
-    if user.save
+    if !user.save
       fail :user_save_failed, :user => user
     else
       continue(params)
@@ -103,7 +103,7 @@ Because we're using consistent successes and failures, we can use different func
 
 ```ruby
 # NOTE: The following assumes that #post_comment returns a Success or Failure
-video = Video.find_by_id(params[:video_id])
+video = Video.find_by(id: params[:video_id])
 check_exists(video).and_then { post_comment(params) }
 
 # NOTE: The following assumes that #find_tag and #create_tag both return a Success or Failure

data/lib/solid_use_case/either.rb

@@ -3,24 +3,24 @@ module SolidUseCase
 
     def run(inputs)
       steps = self.class.instance_variable_get("@__steps").clone
-      result = Success(inputs)
-      return result unless steps
+      current_result = Success(inputs)
+      return current_result unless steps
 
       while steps.count > 0
         next_step = steps.shift
 
-        if next_step.is_a?(Class) && (next_step.respond_to? :can_run_either?) && next_step.can_run_either?
-          subresult = next_step.run(result.value)
-        elsif next_step.is_a?(Symbol)
-          subresult = self.send(next_step, result.value)
-        else
-          raise "Invalid step type: #{next_step.inspect}"
+        current_result = current_result.and_then do
+          if next_step.is_a?(Class) && (next_step.respond_to? :can_run_either?) && next_step.can_run_either?
+            next_step.run(current_result.value)
+          elsif next_step.is_a?(Symbol)
+            self.send(next_step, current_result.value)
+          else
+            raise "Invalid step type: #{next_step.inspect}"
+          end
         end
-
-        result = result.and(subresult)
       end
 
-      result
+      current_result
     end
 
     # # # # # #

data/lib/solid_use_case/version.rb

@@ -1,3 +1,3 @@
 module SolidUseCase
-  VERSION = "2.1.0"
+  VERSION = "2.1.1"
 end

data/spec/either_spec.rb

@@ -77,6 +77,23 @@ describe SolidUseCase::Either do
       expect(result).to be_a_success
       expect(result.value).to eq(41)
     end
+
+    class ShortCircuit
+      include SolidUseCase
+      steps :first, :second
+
+      def first(inputs)
+        fail :jump_out_yo
+      end
+
+      def second(inputs)
+        throw "Should not reach this point"
+      end
+    end
+
+    it "doesn't run the next step a failure occures" do
+      expect { ShortCircuit.run }.to_not raise_error
+    end
   end
 
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: solid_use_case
 version: !ruby/object:Gem::Version
-  version: 2.1.0
+  version: 2.1.1
 platform: ruby
 authors:
 - Gilbert
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-08-11 00:00:00.000000000 Z
+date: 2014-08-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: deterministic