solid_queue_guard 1.3.0 → 1.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d67d9fdbc9de83d8566bfc3c7529e4be2bf3e924cba7f840b555869cd0b2a618
-  data.tar.gz: 63368e74ee06a570c18d7f7cd7ea56de72355ae84327f883a01233f1bee38cd5
+  metadata.gz: 0f68d16b641aa34f7cf2cda0731e1f279d4078466271f25bdac801d812a1c050
+  data.tar.gz: d9765f83f9e100ec1508603cc6e6c461ca5835a925d32ef30b993d122eafb6ce
 SHA512:
-  metadata.gz: 20bfa32ec7ae3b150414576877e57f432364f21df151082e6fd4a6d7da7c9b3802899223fcc33b37dc529b2ecf3a4723748b4a9ec30b5bd32fa168632cf73840
-  data.tar.gz: 4b1553424fb1ad718edd40f22f06cf463837fc82bcb7350efd4c062b956cfd94a7cffdeb329460afbb23f17f40f0e30243b169c314c49f8679c41ed67ea89346
+  metadata.gz: 24f148012d857a399cb27ceab0ca17ed9b09e4215610e82aa96d9bbb2fa9b84b05b85e63723ffbe7edd57d65cb8c3ed81305ee0e2650ffb798aeffd55bbc1c11
+  data.tar.gz: bcd5ab443291828fbf19100ded2010d54d5d57cf764390623ca5e67d4291fb80c1fca37e5498ada656dfc95e184d8484e0a17e4763a0052f634a186980961bff

data/CHANGELOG.md

@@ -5,6 +5,25 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [1.4.0] - 2026-08-03
+
+### Changed
+
+- `recurring_stale` derives per-task thresholds from each task's schedule period
+  (`next_time - previous_time`, multiplied by `2` by default). Frequent crons alert sooner;
+  daily/weekly crons no longer force a single global window that hides shorter schedules.
+- `config.checks.recurring_stale = { threshold: ... }` is now a **fallback** when the schedule
+  period cannot be derived (not a global override for every task).
+- Optional `thresholds: { task_key: duration }` and `multiplier:` overrides for fine-tuning.
+
+## [1.3.1] - 2026-07-31
+
+### Fixed
+
+- `thread_pool` and topology pool recommendations work with Solid Queue 1.6+, which renamed
+  `estimated_number_of_threads` to `estimated_database_pool_size`. Guard now reads whichever
+  private helper the installed gem exposes.
+
 ## [1.3.0] - 2026-07-29
 
 ### Changed

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    solid_queue_guard (1.2.5)
+    solid_queue_guard (1.4.0)
       actionpack (>= 7.1, < 9.0)
       activejob (>= 7.1, < 9.0)
       activerecord (>= 7.1, < 9.0)

data/lib/solid_queue_guard/checks/config/thread_pool_check.rb

@@ -5,7 +5,7 @@ module SolidQueueGuard
     module Config
       class ThreadPoolCheck < Base
         def call
-          required_threads = solid_queue_configuration.send(:estimated_number_of_threads)
+          required_pool = ConfigurationSizing.estimated_database_pool_size(solid_queue_configuration)
           pool_size = SolidQueue::Record.connection_pool&.size
 
           return skip('thread_pool', 'Queue database connection pool is not available') if pool_size.nil?
@@ -17,18 +17,18 @@ module SolidQueueGuard
             )
           end.max || 1
 
-          if pool_size >= required_threads
+          if pool_size >= required_pool
             pass(
               'thread_pool',
               "Worker threads: #{max_worker_threads}, queue DB pool: #{pool_size}",
-              metadata: { threads: max_worker_threads, pool: pool_size, required: required_threads }
+              metadata: { threads: max_worker_threads, pool: pool_size, required: required_pool }
             )
           else
             failure(
               'thread_pool',
               "Worker threads: #{max_worker_threads}, queue DB pool: #{pool_size}",
-              suggestion: "Increase queue DB pool to at least #{required_threads} or reduce worker threads",
-              metadata: { threads: max_worker_threads, pool: pool_size, required: required_threads }
+              suggestion: "Increase queue DB pool to at least #{required_pool} or reduce worker threads",
+              metadata: { threads: max_worker_threads, pool: pool_size, required: required_pool }
             )
           end
         end

data/lib/solid_queue_guard/checks/runtime/recurring_stale_check.rb

@@ -4,15 +4,14 @@ module SolidQueueGuard
   module Checks
     module Runtime
       class RecurringStaleCheck < Base
+        DEFAULT_MULTIPLIER = 2
+
         def call
           with_queue_database do
             tasks = SolidQueue::RecurringTask.static
             return pass(check_id, 'No recurring tasks configured') if tasks.none?
 
-            stale_tasks = tasks.select do |task|
-              last_run = SolidQueue::RecurringExecution.where(task_key: task.key).maximum(:run_at)
-              last_run.nil? || last_run < expected_staleness.ago
-            end
+            stale_tasks = tasks.select { |task| stale?(task) }
 
             if stale_tasks.any?
               warn(
@@ -28,7 +27,48 @@ module SolidQueueGuard
 
         private
 
-        def expected_staleness
+        def stale?(task)
+          last_run = SolidQueue::RecurringExecution.where(task_key: task.key).maximum(:run_at)
+          last_run.nil? || last_run < expected_staleness_for(task).ago
+        end
+
+        def expected_staleness_for(task)
+          override = per_task_threshold(task.key)
+          return override if override
+
+          period = schedule_period_for(task)
+          return period * multiplier if period
+
+          fallback_threshold
+        end
+
+        def per_task_threshold(task_key)
+          thresholds = config.check_setting(:recurring_stale, :thresholds, nil)
+          return unless thresholds
+
+          thresholds[task_key.to_sym] || thresholds[task_key.to_s]
+        end
+
+        def schedule_period_for(task)
+          return unless task.respond_to?(:previous_time) && task.respond_to?(:next_time)
+
+          previous = task.previous_time
+          nxt = task.next_time
+          return unless previous && nxt
+
+          seconds = nxt - previous
+          return unless seconds.positive?
+
+          seconds.seconds
+        rescue StandardError
+          nil
+        end
+
+        def multiplier
+          config.check_setting(:recurring_stale, :multiplier, DEFAULT_MULTIPLIER)
+        end
+
+        def fallback_threshold
           config.check_setting(:recurring_stale, :threshold, config.stale_process_threshold * 2)
         end
       end

data/lib/solid_queue_guard/configuration_sizing.rb

@@ -0,0 +1,24 @@
+# frozen_string_literal: true
+
+module SolidQueueGuard
+  # Reads Solid Queue's estimated queue-DB pool requirement across gem versions.
+  #
+  # Solid Queue 1.6 renamed the private helper from +estimated_number_of_threads+
+  # to +estimated_database_pool_size+ (fiber workers need a different estimate).
+  # Both return the same value for classic thread workers: max capacity + 2.
+  module ConfigurationSizing
+    module_function
+
+    def estimated_database_pool_size(configuration = SolidQueue::Configuration.new)
+      if configuration.respond_to?(:estimated_database_pool_size, true)
+        configuration.send(:estimated_database_pool_size)
+      elsif configuration.respond_to?(:estimated_number_of_threads, true)
+        configuration.send(:estimated_number_of_threads)
+      else
+        raise NoMethodError,
+              'SolidQueue::Configuration has neither estimated_database_pool_size ' \
+              'nor estimated_number_of_threads'
+      end
+    end
+  end
+end

data/lib/solid_queue_guard/recommendations/topology.rb

@@ -33,11 +33,11 @@ module SolidQueueGuard
       def pool_recommendations
         return async_pool_recommendation if PumaPluginSupport.async_supervisor_mode?
 
-        required_threads = configuration.estimated_number_of_threads
+        required_pool = ConfigurationSizing.estimated_database_pool_size(configuration)
         pool_size = SolidQueue::Record.connection_pool&.size
-        return [] if pool_size.nil? || required_threads <= pool_size
+        return [] if pool_size.nil? || required_pool <= pool_size
 
-        ["Increase queue DB pool to at least #{required_threads + 2} (currently #{pool_size})"]
+        ["Increase queue DB pool to at least #{required_pool} (currently #{pool_size})"]
       rescue StandardError
         []
       end
@@ -62,11 +62,11 @@ module SolidQueueGuard
       end
 
       def async_pool_recommendation
-        required_threads = configuration.estimated_number_of_threads
+        required_pool = ConfigurationSizing.estimated_database_pool_size(configuration)
         pool_size = SolidQueue::Record.connection_pool&.size
-        return [] if pool_size.nil? || required_threads <= pool_size
+        return [] if pool_size.nil? || required_pool <= pool_size
 
-        ["Increase queue DB pool to at least #{required_threads + 2} " \
+        ["Increase queue DB pool to at least #{required_pool} " \
          "for async supervisor mode (currently #{pool_size})"]
       rescue StandardError
         []

data/lib/solid_queue_guard/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module SolidQueueGuard
-  VERSION = '1.3.0'
+  VERSION = '1.4.0'
 end

metadata

@@ -1,14 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: solid_queue_guard
 version: !ruby/object:Gem::Version
-  version: 1.3.0
+  version: 1.4.0
 platform: ruby
 authors:
 - Rafael Pissardo
-autorequire:
 bindir: bin
 cert_chain: []
-date: 2026-07-29 00:00:00.000000000 Z
+date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: actionpack
@@ -359,6 +358,7 @@ files:
 - lib/solid_queue_guard/checks/runtime/stale_process_check.rb
 - lib/solid_queue_guard/cli.rb
 - lib/solid_queue_guard/configuration.rb
+- lib/solid_queue_guard/configuration_sizing.rb
 - lib/solid_queue_guard/engine.rb
 - lib/solid_queue_guard/formatters/json.rb
 - lib/solid_queue_guard/formatters/terminal.rb
@@ -394,7 +394,6 @@ metadata:
   bug_tracker_uri: https://github.com/rafael-pissardo/solid_queue_guard/issues
   documentation_uri: https://github.com/rafael-pissardo/solid_queue_guard#readme
   rubygems_mfa_required: 'true'
-post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -409,8 +408,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.5.3
-signing_key:
+rubygems_version: 3.6.9
 specification_version: 4
 summary: Production readiness checks and runtime guards for Rails Solid Queue.
 test_files: []